Repository navigation
test: narrow five more mock factories without unknown - #17685
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe changes update test mocks to use narrower TypeScript types. They add typed ChangesTyped test mocks
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to This PR narrows test-only mock types while preserving existing values and behavior, so no actionable merge risk remains. Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The changed-file list and PR description are available, but the PR title and commit subjects are not available in the review context. The check requires those fields to evaluate the bug-fix language condition. The available description presents type-only test-mock changes and does not provide the missing title or commit subjects. Resolution Provide the PR title and all commit subjects, then reevaluate whether any bug-fix signal exists. If no such signal exists, the check passes; otherwise verify the browser_tests/ change and the description's concrete explanation for not adding an end-to-end regression test. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2016 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 10 MB gzip 🔴 +319 kBDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.44 MB (baseline 1.43 MB) • 🔴 +14.7 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 124 kB) • 🔴 +7.89 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 622 kB (baseline 621 kB) • 🔴 +972 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 16 unchanged User & Accounts — 26.2 kB (baseline 27.8 kB) • 🟢 -1.62 kBAuthentication, profile, and account management bundles
Status: 8 added / 8 removed / 3 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +740 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 123 kB (baseline 117 kB) • 🔴 +6.26 kBReusable component library chunks
Status: 16 added / 15 removed Data & Services — 3.73 MB (baseline 3.6 MB) • 🔴 +130 kBStores, services, APIs, and repositories
Status: 16 added / 16 removed Utilities & Hooks — 560 kB (baseline 559 kB) • 🔴 +1.58 kBHelpers, composables, and utility bundles
Status: 29 added / 28 removed / 8 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.1 MB) • 🔴 +137 kBExternal libraries and shared vendor chunks
Status: 9 added / 9 removed / 9 unchanged Other — 17.5 MB (baseline 16.4 MB) • 🔴 +1.12 MBBundles that do not match a named category
Status: 171 added / 171 removed / 125 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-15T17:53:22.077Z",
"gitSha": "bfd0b64fa9683b9841f84896d57390c6ac6bd689",
"branch": "drjkl/fe-2343-mock-factories-batch-2",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2011.3000000000056,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.452,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.81300000000005,
"heapDeltaBytes": 3965080,
"heapUsedBytes": 66259976,
"domNodes": -262,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.064,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2035.2550000000065,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.514999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.3389999999999,
"heapDeltaBytes": 8232716,
"heapUsedBytes": 70456696,
"domNodes": -264,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 13.171999999999999,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2026.742000000013,
"styleRecalcs": 77,
"styleRecalcDurationMs": 33.882999999999996,
"layouts": 14,
"layoutDurationMs": 5.7860000000000005,
"taskDurationMs": 936.01,
"heapDeltaBytes": 246696,
"heapUsedBytes": 62588032,
"domNodes": -265,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 190.111,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1873.2449999999972,
"styleRecalcs": 76,
"styleRecalcDurationMs": 33.678,
"layouts": 14,
"layoutDurationMs": 4.921,
"taskDurationMs": 898.926,
"heapDeltaBytes": 16408600,
"heapUsedBytes": 78597236,
"domNodes": -264,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 161.52,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1733.3500000000868,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.53,
"layouts": 6,
"layoutDurationMs": 1.1909999999999998,
"taskDurationMs": 361.697,
"heapDeltaBytes": 2273116,
"heapUsedBytes": 64111840,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 12.600999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.9060000000663,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.157,
"layouts": 6,
"layoutDurationMs": 1.287,
"taskDurationMs": 426.24800000000005,
"heapDeltaBytes": 2354412,
"heapUsedBytes": 63330804,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 16.035,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 711.4359999999351,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.260999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.792,
"heapDeltaBytes": 17632980,
"heapUsedBytes": 79942432,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 169.314,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 710.0729999999658,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.515999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.06100000000004,
"heapDeltaBytes": 17907164,
"heapUsedBytes": 80218044,
"domNodes": 16,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 170.793,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2043.8609999999926,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.927,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 583.8319999999999,
"heapDeltaBytes": 3758396,
"heapUsedBytes": 82979388,
"domNodes": -252,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 34.63099999999999,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2068.7749999999596,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.887,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 803.0759999999999,
"heapDeltaBytes": 275656,
"heapUsedBytes": 79496388,
"domNodes": -256,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 42.071,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2359.175999999934,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.420999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1685.6170000000002,
"heapDeltaBytes": -585924,
"heapUsedBytes": 80196332,
"domNodes": -252,
"jsHeapTotalBytes": 479232,
"scriptDurationMs": 850.585,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2641.6419999999334,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.949,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1800.7490000000003,
"heapDeltaBytes": 15205708,
"heapUsedBytes": 79692724,
"domNodes": -251,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 871.6709999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3609.960000000001,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.081000000000001,
"layouts": 60,
"layoutDurationMs": 14.904,
"taskDurationMs": 1757.4829999999997,
"heapDeltaBytes": 10034196,
"heapUsedBytes": 75746796,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 838.528,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3882.955999999922,
"styleRecalcs": 60,
"styleRecalcDurationMs": 12.056000000000001,
"layouts": 60,
"layoutDurationMs": 15.566999999999998,
"taskDurationMs": 1873.92,
"heapDeltaBytes": 11702744,
"heapUsedBytes": 78258616,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 848.918,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3155.2070000000185,
"styleRecalcs": 42,
"styleRecalcDurationMs": 7.349000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1979.86,
"heapDeltaBytes": 36228,
"heapUsedBytes": 84056832,
"domNodes": -263,
"jsHeapTotalBytes": 147456,
"scriptDurationMs": 993.135,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3295.158000000015,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.8079999999999945,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2221.2740000000003,
"heapDeltaBytes": 4161492,
"heapUsedBytes": 88078528,
"domNodes": -264,
"jsHeapTotalBytes": 409600,
"scriptDurationMs": 1092.041,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2005.3010000000313,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.442000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.272,
"heapDeltaBytes": 19725868,
"heapUsedBytes": 83770316,
"domNodes": -248,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.604999999999993,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2013.3580000000393,
"styleRecalcs": 2,
"styleRecalcDurationMs": 4.566999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 728.6429999999999,
"heapDeltaBytes": 19765996,
"heapUsedBytes": 83854252,
"domNodes": -256,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 41.775000000000006,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 589.8149999999305,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.743,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.06000000000006,
"heapDeltaBytes": 14333804,
"heapUsedBytes": 78024684,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 148.89600000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 658.986999999911,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.605000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.428,
"heapDeltaBytes": 13760060,
"heapUsedBytes": 77210412,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 149.91,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.2930000000142,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.924000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.651,
"heapDeltaBytes": 3997836,
"heapUsedBytes": 67594928,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.154,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.554000000051,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.870000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 605.776,
"heapDeltaBytes": 9627200,
"heapUsedBytes": 73051768,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 12.731000000000003,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.09400000006,
"styleRecalcs": 78,
"styleRecalcDurationMs": 30.685999999999996,
"layouts": 18,
"layoutDurationMs": 6.234,
"taskDurationMs": 847.9389999999999,
"heapDeltaBytes": -2145008,
"heapUsedBytes": 61329180,
"domNodes": -274,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 116.50399999999999,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1717.1070000000555,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.404999999999998,
"layouts": 18,
"layoutDurationMs": 5.962000000000001,
"taskDurationMs": 887.0790000000002,
"heapDeltaBytes": 9595056,
"heapUsedBytes": 73029692,
"domNodes": -276,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 118.145,
"eventListeners": -202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.5520000000088,
"styleRecalcs": 16,
"styleRecalcDurationMs": 30.912999999999997,
"layouts": 5,
"layoutDurationMs": 14.139000000000003,
"taskDurationMs": 872.673,
"heapDeltaBytes": 19375400,
"heapUsedBytes": 100741716,
"domNodes": 13587,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 33.08,
"eventListeners": 2385,
"totalBlockingTimeMs": 156,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8505.952000000092,
"styleRecalcs": 249,
"styleRecalcDurationMs": 42.866,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6072.37,
"heapDeltaBytes": -11904896,
"heapUsedBytes": 68515136,
"domNodes": -224,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 2877.869,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9001.897999999983,
"styleRecalcs": 246,
"styleRecalcDurationMs": 42.461,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6359.858,
"heapDeltaBytes": -3996908,
"heapUsedBytes": 75550980,
"domNodes": -251,
"jsHeapTotalBytes": -77824,
"scriptDurationMs": 2852.1009999999997,
"eventListeners": -136,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17818.66200000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17571.565,
"heapDeltaBytes": -34876076,
"heapUsedBytes": 180162872,
"domNodes": -6542,
"jsHeapTotalBytes": 1368064,
"scriptDurationMs": 302.466,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18124.609000000077,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17939.59,
"heapDeltaBytes": -27155228,
"heapUsedBytes": 187932812,
"domNodes": -6542,
"jsHeapTotalBytes": 2678784,
"scriptDurationMs": 293.64,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22384.292999999958,
"styleRecalcs": 168,
"styleRecalcDurationMs": 30.703999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22294.066000000003,
"heapDeltaBytes": -31919020,
"heapUsedBytes": 163106848,
"domNodes": -6542,
"jsHeapTotalBytes": 2039808,
"scriptDurationMs": 996.5569999999999,
"eventListeners": -7472,
"totalBlockingTimeMs": 376,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 23207.331000000067,
"styleRecalcs": 175,
"styleRecalcDurationMs": 29.179999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23118.55,
"heapDeltaBytes": -30248884,
"heapUsedBytes": 187476560,
"domNodes": -6542,
"jsHeapTotalBytes": 442368,
"scriptDurationMs": 993.841,
"eventListeners": -7472,
"totalBlockingTimeMs": 149,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-node-resize-workload",
"durationMs": 6678.850999999895,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.938,
"layouts": 20,
"layoutDurationMs": 30.065999999999995,
"taskDurationMs": 6642.237,
"heapDeltaBytes": -16519816,
"heapUsedBytes": 178601804,
"domNodes": -6542,
"jsHeapTotalBytes": 16457728,
"scriptDurationMs": 136.179,
"eventListeners": -7474,
"totalBlockingTimeMs": 434,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6653.424000000086,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.952,
"layouts": 20,
"layoutDurationMs": 31.02500000000001,
"taskDurationMs": 6625.746999999999,
"heapDeltaBytes": -15737312,
"heapUsedBytes": 179100092,
"domNodes": -6542,
"jsHeapTotalBytes": 16982016,
"scriptDurationMs": 132.168,
"eventListeners": -7476,
"totalBlockingTimeMs": 340,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9106.30500000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9020.815,
"heapDeltaBytes": -15064648,
"heapUsedBytes": 173347428,
"domNodes": 0,
"jsHeapTotalBytes": -4194304,
"scriptDurationMs": 176.22499999999997,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9082.765999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8910.026,
"heapDeltaBytes": 2278668,
"heapUsedBytes": 188160484,
"domNodes": 0,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 148.4519999999999,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 460.5860000000348,
"styleRecalcs": 12,
"styleRecalcDurationMs": 20.366,
"layouts": 3,
"layoutDurationMs": 1.1270000000000002,
"taskDurationMs": 118.45100000000002,
"heapDeltaBytes": 4947132,
"heapUsedBytes": 66987388,
"domNodes": 120,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.299999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 103.48799999997027,
"styleRecalcs": 6,
"styleRecalcDurationMs": 10.744,
"layouts": 2,
"layoutDurationMs": 0.704,
"taskDurationMs": 69.57000000000002,
"heapDeltaBytes": 3043760,
"heapUsedBytes": 64998000,
"domNodes": 104,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.617000000000002,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #17685 +/- ##
==========================================
+ Coverage 82.49% 83.51% +1.01%
==========================================
Files 2789 2139 -650
Lines 140050 124224 -15826
Branches 37540 33454 -4086
==========================================
- Hits 115533 103744 -11789
+ Misses 23374 20244 -3130
+ Partials 1143 236 -907
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
## Summary Replace 61 telemetry `vi.mock<unknown>` factories with a matching-name Vitest manual mock for [FE-2343](https://linear.app/comfyorg/issue/FE-2343/audit-and-remove-remaining-vimockunknown-partial-factories-1313-sites). Stacked on Comfy-Org#17685. ## Changes - Load `telemetry/__mocks__/index.ts` through factory-free `vi.mock(import('@/platform/telemetry'))` calls. - Derive the complete no-op dispatcher from `TelemetryRegistry` with `vi.mockObject`. Tests import the real module path and access spies with `vi.mocked`. - Remove duplicate event spies and rebinding hooks. The manual mock exposes only the real module's exports. - Read spies through `useTelemetry()` directly in 40 suites, without cached dispatchers or `assert.exists`. - Set the supported `null` result in nine unavailable-telemetry suites and four suites with stale `trackEvent` mocks. - Declare the convention-loaded mock as a Fallow entry so the unused-code check recognizes it. - Leave custom factories and vendored-layer tests for a separate pass. Scripts remain in ignored `temp/`. ## Review Focus The dispatcher is stable within each file, and Vitest resets its spy implementations and history before every test. Null scenarios override `useTelemetry` per test. No real providers are registered. Assertions retain their expected events and counts. Two onboarding suites select the step-event overload for typed call inspection. Billing-duration assertions narrow finished events before reading `duration_ms`. Validation: 1,670 tests across 62 files pass, including the existing factory-free consumer. Full typecheck, lint, formatting, and Knip are checked before push. --------- Co-authored-by: Amp <amp@ampcode.com>
Summary
Remove five more
vi.mock<unknown>escapes for FE-2343. Stacked on #17682; review this diff against that branch.Changes
as constfor literal results,Set<string>for graph IDs, and the existingSecretErrorCodetype for error doubles.temp/.Review Focus
All five factories now pass module-type inference. Emitted JavaScript tokens match the parent tip, ignoring whitespace and comments.
Validation: 141 tests across five files pass; full typecheck, scoped Oxlint/ESLint/format checks, and Knip pass. No production or UI changes.