Repository navigation
Conversation
Co-authored-by: ShihChi Huang <huge.huang+github@gmail.com>
🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-17612.vercel.app Matches production — what ships if we release right now. This commit: https://website-frontend-cj8qk7jvi-comfyui.vercel.app Last updated: 2026-09-13T21:25:17Z for |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe event end-to-end tests now use ChangesEvent status test classification
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change only corrects end-to-end test classification and does not alter production behavior. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #17612 +/- ##
=======================================
Coverage 82.71% 82.71%
=======================================
Files 2730 2730
Lines 137651 137651
Branches 37213 37213
=======================================
Hits 113856 113856
Misses 22786 22786
Partials 1009 1009
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Pull request was converted to draft
DrJKL
left a comment
There was a problem hiding this comment.
This PR is superseded by #17614 and should be closed without merging.
main already contains the same eventStatus correction, with one captured now value shared by both classifications. This branch now conflicts with main; relative to the current base, it would replace that shared timestamp with two separate clock reads and add a comment that restates the code.
I verified the targeted Playwright case on current main: 1 passed.
DrJKL
left a comment
There was a problem hiding this comment.
Requesting changes because current main already contains this correction in a safer form, and GitHub reports this head as conflicting with main. The clean outcome is to close this superseded PR rather than merge it.
Pre-merge blockers:
- [P1] Superseded and conflicted. Current
maincontains commit19a32b42aa, which makes the sameeventStatuscorrection and uses one clock snapshot. GitHub REST reportsmergeable: falseandmergeable_state: dirty. Close this PR, or rebase and resolve the overlap entirely in favor of currentmain. - [P2] Two clock snapshots. Lines 514 and 556 call
new Date()separately, with navigation and UI interaction between them. An event can cross its end boundary during that interval, so the two fixture selections can represent different states. Currentmainalready fixes this with one capturednow.
Findings without an anchorable line
- [P3] PR description: The exact-head focused run confirms
1 passed, but it took 10.0 seconds in the recorded run, not the stated 2.9 seconds. Drop the unsupported duration and keep the pass result.
Existing findings confirmed
- The earlier DrJKL review correctly identified that current
mainsupersedes this PR and that the branch is now conflicted. I independently confirmed both againstorigin/mainat5e05f647fcba6948c0eacbcff453c61c13cca9fcand the current REST mergeability fields. - The earlier review also correctly identified the new comment as a restatement of the next line. The repository guidance asks us not to retain redundant comments.
Checked and cleared
- The scoped Oxlint run reports one warning at line 692. It predates this PR and is outside the changed hunk.
- Fallow audited the one changed file and found no introduced issue.
- No candidate remains unverified.
Coverage
- Standard-depth lanes: correctness, maintainability, idiomaticity, tests, and documentation.
- Exact-head local checks passed:
pnpm typecheck; website typecheck; focused Vitest, 24 tests; website build; focused Playwright, 1 test; scoped ESLint, Oxlint, and Oxfmt;git diff --check; Fallow audit. - Exact-head CI snapshot: 77 completed check runs, with 38 successful, 37 skipped, and 2 cancelled superseded risk-check runs. No check is pending or failed. The relevant
website-e2e,website-unit,build,lint-and-format, andfallowchecks succeeded.
| // A past card links out instead of offering the menu. | ||
| const past = directoryEvents.find( | ||
| (event) => Date.parse(event.startDateTime) < Date.now() && event.link | ||
| (event) => eventStatus(event, new Date()) === 'past' && event.link |
There was a problem hiding this comment.
[P2] Capture one now value for both classifications. This second clock read happens after navigation, hydration, tab switching, and menu interaction. If an event ends during that interval, the upcoming and past fixtures come from different status snapshots, which makes the CTA assertions time-dependent. Current main already uses one shared now, so the simplest resolution is to close this superseded PR.
| test('cards carry the same upcoming and past CTAs as the list', async ({ | ||
| page | ||
| }) => { | ||
| // Match eventStatus / eventEnd so in-progress events aren't past. |
There was a problem hiding this comment.
[P3] Please delete this comment. It paraphrases the following eventStatus(...) === 'upcoming' call and exposes eventEnd, an implementation detail already owned by the helper.
christian-byrne
left a comment
There was a problem hiding this comment.
LGTM but has a conflict
|
Blocked — not pushing a fix here, because there is no valid fix left to push.
The remaining outcome is the one the review already proposed: close this PR without merging. That is a maintainer decision, so nothing has been pushed or changed on this branch. Please close it, or say if it should be rebased and kept open for some reason not visible here. |
Pull request was closed
Summary
The events directory CTA e2e selected upcoming vs past with
startDateTimevsDate.now(), so an in-progress event (UCAN Jo Zhang during its window) was treated as past while product still classified it as upcoming viaeventStatus/eventEnd. This test now selects with the sameeventStatushelper. Test-only; no product CTA change.Verification
From
apps/website(or via--filterexec, which uses that package cwd):Requires a website build first (
pnpm --filter @comfyorg/website build); Playwright then startspnpm preview. Locally this run: 1 passed (2.9s).CI equivalent after build:
pnpm --filter @comfyorg/website test:e2e.