Skip to content

fix(website): align events e2e past-card filter with the page's end-time status model (red main repair) - #17613

Closed
christian-byrne wants to merge 1 commit into
mainfrom
cifix/website-e2e-past-window
Closed

christian-byrne wants to merge 1 commit into
mainfrom
cifix/website-e2e-past-window

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Justification: red main repair — CI: Website E2E push run on 8190935 failed at exact head; test-only root-cause fix, no product code touched.

Evidence

  • Failing run: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/34782685000 (push to main, head 8190935cd, job website-e2e failed 21:12:21Z, failed through retries: [desktop] e2e/events.spec.ts:508 — cards carry the same upcoming and past CTAs as the list; LEARN MORE link "element(s) not found" on the UCAN card; 517 passed, 1 flaky (visual screenshot, passed on retry)).
  • Root cause: the test picked the past card with a naive Date.parse(event.startDateTime) < Date.now() filter, but the page derives past/upcoming via eventStatus, which is end-time based (startDateTime + 1h default duration). The UCAN event starts 2026-09-13T14:00:00-07:00 = 21:00:00Z, four minutes before the run, so during its live window the page still renders the card as upcoming (calendar menu / Register CTA, no LEARN MORE link) while the test expected a past CTA. The same test passed on the prior main E2E run about 30 min earlier on essentially identical code; the head commit (1.55.8 version bump, #17609) only touches package.json and locale files — the diff is unrelated.
  • Fix: select the past card from the already-imported pastEvents (the same derived, end-time-based model the page renders) instead of the start-time filter. Test-only, one hunk; oxfmt check clean. The failure self-heals after about 01:30Z but recurs for every future linked event during its live window, so the filter is fixed rather than skipped (no FLAKY skip — the test still runs and passes in and out of live windows).

…ime status model

The 'cards carry the same upcoming and past CTAs' test picked the past
card with a naive startDateTime < Date.now() filter, but the page derives
past/upcoming from eventStatus (end-time based: start + 1h default
duration). Once a linked event (UCAN, 2026-09-13T14:00-07:00) started,
the test treated its still-upcoming card as past, expected a LEARN MORE
link that the page correctly does not render, and failed red main
(CI: Website E2E push run 34782685000 on 8190935).

Select the past card from pastEvents - the same derived, end-time-based
model the page renders - so the test and page agree by construction.
@christian-byrne
christian-byrne requested review from a team September 13, 2026 21:39
@christian-byrne christian-byrne self-assigned this Sep 13, 2026
@github-actions

github-actions Bot commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-17613.vercel.app

Matches production — what ships if we release right now.

This commit: https://website-frontend-pvbdm07du-comfyui.vercel.app

Last updated: 2026-09-13T21:40:59Z for 19a32b4

@coderabbitai

coderabbitai Bot commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: cf330fd3-07e9-48f4-8b12-0ee38d3ea4fa

📥 Commits

Reviewing files that changed from the base of the PR and between 8190935 and 19a32b4.

📒 Files selected for processing (1)
  • apps/website/e2e/events.spec.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The past-card E2E test now selects a linked event from pastEvents, matching the page’s end-time-based past-event status.

Changes

Events E2E Coverage

Layer / File(s) Summary
Past event candidate selection
apps/website/e2e/events.spec.ts
The test selects linked entries from pastEvents instead of filtering directoryEvents by start time.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: deepme987

Merge Risk: ⚪ Minimal · up to 19a32

This change removes the timing-sensitive event selection that caused the website E2E failure, with no product-code impact.

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the website E2E test fix and the alignment with the page's end-time-based past-event status model. The parenthetical repair note is extra but does not make the title misle…
Description check ✅ Passed The description explains the failure, root cause, fix, scope, and validation evidence. It does not use the repository's requested section headings, but it provides the required information in equivale…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed The changed file is exclusively under apps/website (apps/website/e2e/events.spec.ts). The custom check explicitly excludes apps/website changes because that package uses apps/website/e2e/ for …
Website End-To-End Regression Coverage ✅ Passed Pass. The PR changes only apps/website/e2e/events.spec.ts. It does not change files under apps/website/src/ or apps/website/public/. The check is therefore out of scope, and the test-only change…
Adr Compliance For Entity/Litegraph Changes ✅ Passed The PR changes only apps/website/e2e/events.spec.ts. This path is outside src/lib/litegraph/, src/ecs/, and the listed graph-entity files. The ADR compliance check is therefore not applicable.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cifix/website-e2e-past-window

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##             main   #17613   +/-   ##
=======================================
  Coverage   82.71%   82.71%           
=======================================
  Files        2730     2730           
  Lines      137651   137651           
  Branches    37213    37213           
=======================================
  Hits       113856   113856           
  Misses      22786    22786           
  Partials     1009     1009           
Flag Coverage Δ
website-unit 74.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 13, 2026
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Dup. Same repair carried by #17612 + bbc #723.

Full context for agent readers

Concurrent sweeper lane filed this first. Same root cause (test's start-time past filter vs the page's end-time-based eventStatus during a linked event's live window, UCAN started 21:00Z). Closing to keep one repair PR for review. Root-cause evidence also in that thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant