Repository navigation
test: agent session replay video demo (Langfuse fixture) - #17584
christian-byrne merged 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1989 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-12T22:14:09.951Z",
"gitSha": "f98cc5e1073fcf91861aeafb4fa6c52726f7958f",
"branch": "christian/agent-replay-video-demo",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1992.5440000000094,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.199,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 290.34499999999997,
"heapDeltaBytes": -6668084,
"heapUsedBytes": 55598928,
"domNodes": -262,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.250999999999997,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1993.3510000000183,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.685999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 349.499,
"heapDeltaBytes": 25001288,
"heapUsedBytes": 85933152,
"domNodes": 18,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 9.069999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1761.1839999999575,
"styleRecalcs": 73,
"styleRecalcDurationMs": 21.178999999999995,
"layouts": 14,
"layoutDurationMs": 3.4709999999999996,
"taskDurationMs": 686.3809999999999,
"heapDeltaBytes": 277068,
"heapUsedBytes": 62338776,
"domNodes": -261,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 121.299,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1727.5999999999954,
"styleRecalcs": 73,
"styleRecalcDurationMs": 23.417,
"layouts": 14,
"layoutDurationMs": 4.083,
"taskDurationMs": 696.419,
"heapDeltaBytes": -3305444,
"heapUsedBytes": 59105744,
"domNodes": -260,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 124.713,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.3690000000047,
"styleRecalcs": 32,
"styleRecalcDurationMs": 12.443,
"layouts": 6,
"layoutDurationMs": 0.995,
"taskDurationMs": 266.994,
"heapDeltaBytes": 2116752,
"heapUsedBytes": 64094812,
"domNodes": 76,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.797,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.5680000000139,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.334,
"layouts": 6,
"layoutDurationMs": 1.1429999999999998,
"taskDurationMs": 289.49199999999996,
"heapDeltaBytes": 1877696,
"heapUsedBytes": 64190740,
"domNodes": 76,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 11.566,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 573.660000000018,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.2940000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.28,
"heapDeltaBytes": 17644688,
"heapUsedBytes": 79441392,
"domNodes": 16,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 139.14800000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 527.5510000000168,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.635999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.422,
"heapDeltaBytes": 17923624,
"heapUsedBytes": 79880024,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 131.162,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2020.50399999996,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.148,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.48699999999997,
"heapDeltaBytes": 3067616,
"heapUsedBytes": 82255176,
"domNodes": -243,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 28.551,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2014.6510000000148,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.659000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.251,
"heapDeltaBytes": 2603432,
"heapUsedBytes": 82627488,
"domNodes": -243,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 28.777000000000005,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2105.1599999999553,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.526000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1321.844,
"heapDeltaBytes": -355944,
"heapUsedBytes": 80746852,
"domNodes": -249,
"jsHeapTotalBytes": 1265664,
"scriptDurationMs": 676.553,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2132.3059999999714,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.203000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1365.7070000000003,
"heapDeltaBytes": -617420,
"heapUsedBytes": 80278360,
"domNodes": -247,
"jsHeapTotalBytes": -307200,
"scriptDurationMs": 701.9340000000001,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3143.256000000008,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.294,
"layouts": 60,
"layoutDurationMs": 12.144,
"taskDurationMs": 1350.525,
"heapDeltaBytes": 3896708,
"heapUsedBytes": 70113360,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 640.225,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3219.799000000023,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.315,
"layouts": 60,
"layoutDurationMs": 12.763,
"taskDurationMs": 1426.7960000000003,
"heapDeltaBytes": 8104288,
"heapUsedBytes": 74008080,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 647.972,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2300.786999999957,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.580000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1536.8149999999998,
"heapDeltaBytes": 11791864,
"heapUsedBytes": 79584000,
"domNodes": 6,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 775.353,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2166.739000000007,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.126000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1553.2140000000002,
"heapDeltaBytes": 5643460,
"heapUsedBytes": 71607212,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 761.088,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2027.311999999995,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.961,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.03800000000007,
"heapDeltaBytes": -8918580,
"heapUsedBytes": 78419304,
"domNodes": -249,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 33.192,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2009.26800000002,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.1109999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.636,
"heapDeltaBytes": 19656920,
"heapUsedBytes": 84115256,
"domNodes": -253,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 28.379,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 492.70799999999326,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.235,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 307.59200000000004,
"heapDeltaBytes": 13058140,
"heapUsedBytes": 76490264,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 110.87099999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 531.5410000000611,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.592,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 336.121,
"heapDeltaBytes": 13698344,
"heapUsedBytes": 76965200,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 118.30600000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2004.433000000006,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.128000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.9549999999999,
"heapDeltaBytes": -3832272,
"heapUsedBytes": 59639332,
"domNodes": -272,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.569999999999998,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.1669999999908,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.417000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.034,
"heapDeltaBytes": -4853480,
"heapUsedBytes": 57989228,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.838000000000001,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1687.108999999964,
"styleRecalcs": 79,
"styleRecalcDurationMs": 21.755999999999997,
"layouts": 18,
"layoutDurationMs": 4.48,
"taskDurationMs": 618.0340000000001,
"heapDeltaBytes": -1189824,
"heapUsedBytes": 62108344,
"domNodes": -274,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 81.67099999999999,
"eventListeners": -228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.7890000000048,
"styleRecalcs": 77,
"styleRecalcDurationMs": 24.993,
"layouts": 18,
"layoutDurationMs": 5.6129999999999995,
"taskDurationMs": 658.551,
"heapDeltaBytes": 14428472,
"heapUsedBytes": 77493948,
"domNodes": -274,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 93.932,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 917.1410000000151,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.571,
"layouts": 5,
"layoutDurationMs": 9.479,
"taskDurationMs": 696.5620000000001,
"heapDeltaBytes": 19635440,
"heapUsedBytes": 101023764,
"domNodes": 13587,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 21.673,
"eventListeners": 2385,
"totalBlockingTimeMs": 90,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8233.409999999993,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.066,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4535.157,
"heapDeltaBytes": -15287172,
"heapUsedBytes": 65532284,
"domNodes": -245,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 2186.881,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8294.557999999939,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.485,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4817.156,
"heapDeltaBytes": -13331660,
"heapUsedBytes": 66655284,
"domNodes": -245,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 2243.6980000000003,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 14198.668000000054,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13715.365000000002,
"heapDeltaBytes": -26206796,
"heapUsedBytes": 181385092,
"domNodes": -6542,
"jsHeapTotalBytes": 196608,
"scriptDurationMs": 199.339,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14464.216999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14290.990000000002,
"heapDeltaBytes": -11799112,
"heapUsedBytes": 184074516,
"domNodes": -6543,
"jsHeapTotalBytes": 5918720,
"scriptDurationMs": 213.00900000000001,
"eventListeners": -7480,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17164.980000000014,
"styleRecalcs": 128,
"styleRecalcDurationMs": 13.936000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16859.1,
"heapDeltaBytes": -12890108,
"heapUsedBytes": 188010136,
"domNodes": -6542,
"jsHeapTotalBytes": -4399104,
"scriptDurationMs": 703.739,
"eventListeners": -7478,
"totalBlockingTimeMs": 7,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17131.751000000007,
"styleRecalcs": 125,
"styleRecalcDurationMs": 15.137000000000011,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17006.816,
"heapDeltaBytes": -44318224,
"heapUsedBytes": 174661172,
"domNodes": -6542,
"jsHeapTotalBytes": -2195456,
"scriptDurationMs": 726.19,
"eventListeners": -7474,
"totalBlockingTimeMs": 12,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5141.499000000011,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.167,
"layouts": 20,
"layoutDurationMs": 22.8,
"taskDurationMs": 5107.622,
"heapDeltaBytes": -45243912,
"heapUsedBytes": 173643692,
"domNodes": -6543,
"jsHeapTotalBytes": 16941056,
"scriptDurationMs": 87.666,
"eventListeners": -7476,
"totalBlockingTimeMs": 279,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5255.341000000044,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.422000000000004,
"layouts": 20,
"layoutDurationMs": 22.544999999999995,
"taskDurationMs": 5225.8910000000005,
"heapDeltaBytes": -46705588,
"heapUsedBytes": 169376648,
"domNodes": -6543,
"jsHeapTotalBytes": 12886016,
"scriptDurationMs": 90.855,
"eventListeners": -7476,
"totalBlockingTimeMs": 282,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7245.732999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7060.937000000001,
"heapDeltaBytes": -7657292,
"heapUsedBytes": 181200048,
"domNodes": 0,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 123.74499999999993,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7289.629999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7178.626999999999,
"heapDeltaBytes": -8118344,
"heapUsedBytes": 173526436,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 106.55799999999994,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 90.65499999996973,
"styleRecalcs": 7,
"styleRecalcDurationMs": 12.887999999999998,
"layouts": 3,
"layoutDurationMs": 1.3980000000000001,
"taskDurationMs": 68.556,
"heapDeltaBytes": 3149608,
"heapUsedBytes": 64758032,
"domNodes": 129,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.646000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 87.73999999993976,
"styleRecalcs": 6,
"styleRecalcDurationMs": 14.163000000000002,
"layouts": 4,
"layoutDurationMs": 1.8,
"taskDurationMs": 66.52199999999999,
"heapDeltaBytes": 3086900,
"heapUsedBytes": 64871588,
"domNodes": 129,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.421,
"eventListeners": 35,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
2bfdcf7 to
37bb6e8
Compare
db92e10 to
ceb0c51
Compare
ceb0c51 to
ccfb3fb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## christian-byrne/ci-playwright-video-diff #17584 +/- ##
=========================================================================
Coverage 83.56% 83.56%
=========================================================================
Files 2110 2110
Lines 122778 122778
Branches 32960 32960
=========================================================================
+ Hits 102601 102603 +2
+ Misses 19996 19994 -2
Partials 181 181
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Merging with admin per program timeline; post-merge review requested. Full context for agent readersThis PR only touches test harness / recorder / CI-upload code and does not affect production runtime code. The agent program needs the harness unblocked for harness-first QA on the 1.54/1.55 PRs. All review threads are resolved and CI is green apart from the feature-flag-policy check, which does not apply to non-runtime paths. Reviewers: please leave post-merge findings as comments and they will be picked up as follow-up PRs. |
7a0e493
into
christian-byrne/ci-playwright-video-diff
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve
No production-runtime blocker was found. This review covers only the 22-line delta from christian-byrne/ci-playwright-video-diff at 1d087326 to ccfb3fbc; it does not review the stack against main. The PR merged into that stack while this review was running. The base branch belongs to PR #17504, not PR #16682.
The focused cloud test and video route both passed on the reviewed head. Two follow-ups should be handled on the open stack before it lands on main.
Findings without an anchorable line
- P2, provenance wording: The title calls this a "Langfuse fixture," but
agent-rec-two-turn-dependent-edit.jsonsays it was recorded from the cloud agent service running in a non-standalone local full stack and explicitly says it was not a production capture. The fixture README documents Langfuse import as a separate workflow. Rename the title or otherwise correct the stack's record so nobody treats this as coverage of the Langfuse importer or a hosted capture.
Existing feedback
- CodeRabbit skipped review because the target was not the default branch.
- CI reported 1,989 Playwright tests passed, including the cloud project and
playwright-video-new-testsonccfb3fbc. - Codecov reported all modified coverable lines covered.
- No earlier review comments or submitted reviews existed before this review.
Checked and cleared
- The spec selects the existing two-turn recorded case and
runTurns()checks panel and canvas state after each turn. @cloudroutes the file to the correct Playwright project. Discovery found exactly one test.- No arbitrary waits, raw canvas interaction, type suppression, unsafe assertion, leaked state, or mock-only frontend behavior was added.
- The final workflow button uses a retrying role-based assertion.
- The fixture data is unchanged from the effective base and the reviewed delta contains no secrets.
Coverage
- Depth: standard.
- Lanes: correctness, maintainability, idiomaticity, tests, and documentation. No lane was skipped.
- Maintainability lenses: Ponytail ultra, no-comments, minimize reader load, subtract before adding, laziness protocol, and migrate callers then delete legacy APIs.
- Correctness lenses: blast radius, regression-risk history, idempotency, shared-state separation, boundary discipline, and root-cause checks.
- Test lenses: full Playwright helper inventory and interaction table, checks A through H, all 23 repository Playwright rules, mock-boundary analysis, flake hardening, setup consolidation, and proof review.
- TypeScript lenses: TypeScript best practices and type-system discipline.
- Documentation lenses: technical writing, unslop, and humanizer.
- Fallow analyzed the one changed file and reported no consequential structural decision, complexity issue, or changed-file duplication item. Its unrelated repository-wide dependency output was excluded.
- Local checks: targeted ESLint passed; targeted oxlint passed;
pnpm typecheck:browserpassed; cloud Playwright discovery listed one test;git diff --checkpassed. - Exact-head CI: 73 successful and 14 intentionally skipped check runs; no failures or pending checks in the fetched REST result.
Replays a real recorded two-turn agent session for CI video capture.
Full context for agent readers
agent-rec-two-turn-dependent-editfixture.playwright-report-new-tests.