Repository navigation
[test-harness followup] demo: diff-based Playwright video upload on changed spec - #17515
christian-byrne wants to merge 6 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1969 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data🔬 E2E Coverage
Top 10 files by uncovered lines
|
f7f9358 to
890e352
Compare
890e352 to
a662b55
Compare
|
Changed-spec video uploaded. Full context for agent readersCI run: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/34670027417 Artifact: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/34670027417/artifacts/10289908784 Artifact name: Changed-spec video: The downloaded artifact also embeds the same recording in the HTML report as |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## christian-byrne/ci-playwright-video-diff #17515 +/- ##
=========================================================================
Coverage 83.56% 83.56%
=========================================================================
Files 2107 2107
Lines 122712 122712
Branches 33811 33811
=========================================================================
+ Hits 102541 102549 +8
+ Misses 19990 19982 -8
Partials 181 181
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
36b3110 to
c5c47ba
Compare
|
Superseded by #17584. |
Changed Agent spec; video proof only.
Full context for agent readers
This draft stacks on #17504 so its changed-spec detector and explicit WebM upload are present. It extends the existing recording-demo spec to close the settings dialog and verify the full open-close lifecycle.
The PR exists to prove CI detects a changed existing spec, records it, and uploads the resulting Playwright video artifact. It should not merge before #17504.
Local checks: commit hooks passed formatting, Oxlint, ESLint, TypeScript, browser TypeScript, and Knip. Playwright discovery found both tests. Browser execution could not run locally because no ComfyUI server was listening on port 8188.