Repository navigation
test(widgets): multiline text keeps paragraph breaks across a round-trip - #17525
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThis change adds an end-to-end test for exact preservation of multiline text, paragraph breaks, blank lines, and trailing whitespace after workflow serialization and reload. ChangesMultiline widget round-trip
Priority: ⚪ Not assessed Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The added test coverage does not introduce a concrete merge-blocking risk. Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The review context provides the changed file and PR description, but it does not provide the PR title or commit subjects. The custom check requires those values to identify bug-fix language. The available metadata shows a ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 1967 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.96 MB gzip 🟢 -222 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 17 added / 17 removed / 1 unchanged Panels & Settings — 622 kB (baseline 622 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 16 unchanged User & Accounts — 26.2 kB (baseline 26.2 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 8 added / 8 removed / 3 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 118 kB (baseline 118 kB) • ⚪ 0 BReusable component library chunks
Status: 15 added / 15 removed Data & Services — 3.71 MB (baseline 3.71 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 16 added / 16 removed Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 28 added / 28 removed / 9 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Status: 6 added / 6 removed / 12 unchanged Other — 17.3 MB (baseline 17.3 MB) • ⚪ 0 BBundles that do not match a named category
Status: 119 added / 119 removed / 177 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-12T06:22:08.797Z",
"gitSha": "ce7782deb89a51ba7c5126904d8455d3cb13fbb2",
"branch": "test/multiline-widget-paragraphs-survive-reload",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2005.7959999999184,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.434,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.967,
"heapDeltaBytes": 1425852,
"heapUsedBytes": 62837056,
"domNodes": -264,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.168000000000001,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 1989.8569999999154,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.961999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 354.962,
"heapDeltaBytes": 5671052,
"heapUsedBytes": 67380260,
"domNodes": -262,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.627000000000002,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1858.6610000000974,
"styleRecalcs": 74,
"styleRecalcDurationMs": 27.819999999999997,
"layouts": 14,
"layoutDurationMs": 4.354,
"taskDurationMs": 831.656,
"heapDeltaBytes": 10690212,
"heapUsedBytes": 72059576,
"domNodes": -261,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 165.291,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1826.6509999999698,
"styleRecalcs": 75,
"styleRecalcDurationMs": 26.974999999999998,
"layouts": 14,
"layoutDurationMs": 4.226999999999999,
"taskDurationMs": 837.179,
"heapDeltaBytes": 6236036,
"heapUsedBytes": 68499844,
"domNodes": -261,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 165.486,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.8310000000183,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.094,
"layouts": 6,
"layoutDurationMs": 1.257,
"taskDurationMs": 338.202,
"heapDeltaBytes": 2052436,
"heapUsedBytes": 64284512,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.047,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1666.8879999999717,
"styleRecalcs": 29,
"styleRecalcDurationMs": 14.699,
"layouts": 6,
"layoutDurationMs": 1.0100000000000002,
"taskDurationMs": 256.628,
"heapDeltaBytes": 2103728,
"heapUsedBytes": 64120388,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.077,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 630.5919999999787,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.919,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.199,
"heapDeltaBytes": 18076300,
"heapUsedBytes": 80134552,
"domNodes": 16,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 166.34700000000004,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 620.9279999999353,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.129,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.887,
"heapDeltaBytes": 17927232,
"heapUsedBytes": 80092208,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 162.863,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2017.8220000000238,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.459000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.6260000000001,
"heapDeltaBytes": 3155856,
"heapUsedBytes": 82963188,
"domNodes": -247,
"jsHeapTotalBytes": -1581056,
"scriptDurationMs": 31.436000000000007,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2036.9600000000219,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.264000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.79,
"heapDeltaBytes": 3316164,
"heapUsedBytes": 83123308,
"domNodes": -245,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 30.233999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2353.1509999999116,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.285999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1712.314,
"heapDeltaBytes": -5048896,
"heapUsedBytes": 75676380,
"domNodes": -223,
"jsHeapTotalBytes": 2052096,
"scriptDurationMs": 875.0400000000001,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2255.1979999999503,
"styleRecalcs": 64,
"styleRecalcDurationMs": 8.643999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1655.55,
"heapDeltaBytes": 20395452,
"heapUsedBytes": 85037644,
"domNodes": 4,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 896.934,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3576.0360000000446,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.912999999999998,
"layouts": 60,
"layoutDurationMs": 12.305,
"taskDurationMs": 1669.6290000000001,
"heapDeltaBytes": 9832468,
"heapUsedBytes": 74399392,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 799.394,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3496.943999999985,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.154,
"layouts": 60,
"layoutDurationMs": 12.504,
"taskDurationMs": 1673.4070000000002,
"heapDeltaBytes": 7746648,
"heapUsedBytes": 73883072,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 781.76,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3108.0759999999827,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.397000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1800.45,
"heapDeltaBytes": 19935852,
"heapUsedBytes": 85878740,
"domNodes": 2,
"jsHeapTotalBytes": 1990656,
"scriptDurationMs": 1044.32,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3109.0240000000904,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.767,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1929.599,
"heapDeltaBytes": 18972540,
"heapUsedBytes": 84808532,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 1009.2090000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2014.2059999999447,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.621,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.1149999999999,
"heapDeltaBytes": 20117000,
"heapUsedBytes": 84014116,
"domNodes": -249,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.367999999999995,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 1990.8100000000104,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.6050000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.78899999999993,
"heapDeltaBytes": 19269516,
"heapUsedBytes": 83733316,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.154,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.3179999999638,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.181000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.90900000000005,
"heapDeltaBytes": 13728452,
"heapUsedBytes": 76973640,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 145.49599999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 578.7840000000415,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.605,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.749,
"heapDeltaBytes": 13855184,
"heapUsedBytes": 76210544,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 143.712,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.273000000031,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.982999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.29400000000004,
"heapDeltaBytes": 17242208,
"heapUsedBytes": 80342536,
"domNodes": -276,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 8.633,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1989.5780000000514,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.849000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.96899999999994,
"heapDeltaBytes": 5225712,
"heapUsedBytes": 68451972,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.860999999999999,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1716.1060000000816,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.694999999999997,
"layouts": 18,
"layoutDurationMs": 5.089,
"taskDurationMs": 800.912,
"heapDeltaBytes": -74492,
"heapUsedBytes": 63439548,
"domNodes": -274,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 109.53299999999999,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.0900000000784,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.637,
"layouts": 18,
"layoutDurationMs": 4.97,
"taskDurationMs": 777.342,
"heapDeltaBytes": -1421688,
"heapUsedBytes": 61643048,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 108.239,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.4289999999019,
"styleRecalcs": 19,
"styleRecalcDurationMs": 29.015,
"layouts": 5,
"layoutDurationMs": 13.451,
"taskDurationMs": 905.155,
"heapDeltaBytes": 17498924,
"heapUsedBytes": 95454184,
"domNodes": 13587,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 38.32599999999999,
"eventListeners": 2387,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8288.840000000051,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.01,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5774.532,
"heapDeltaBytes": -12147196,
"heapUsedBytes": 66780048,
"domNodes": -247,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 2778.702,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8422.491000000036,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.384,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5783.026000000001,
"heapDeltaBytes": -12218708,
"heapUsedBytes": 66321448,
"domNodes": -222,
"jsHeapTotalBytes": 1826816,
"scriptDurationMs": 2817.723,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17575.50500000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16902.601,
"heapDeltaBytes": -44045288,
"heapUsedBytes": 161872960,
"domNodes": -6542,
"jsHeapTotalBytes": -1785856,
"scriptDurationMs": 268.85600000000005,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16725.254999999834,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16086.65,
"heapDeltaBytes": -49873840,
"heapUsedBytes": 159655876,
"domNodes": -6542,
"jsHeapTotalBytes": -28672,
"scriptDurationMs": 283.276,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21888.133000000038,
"styleRecalcs": 170,
"styleRecalcDurationMs": 18.247000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21496.47,
"heapDeltaBytes": -25573228,
"heapUsedBytes": 176600280,
"domNodes": -6542,
"jsHeapTotalBytes": -4395008,
"scriptDurationMs": 919.799,
"eventListeners": -7474,
"totalBlockingTimeMs": 156,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20630.282999999963,
"styleRecalcs": 162,
"styleRecalcDurationMs": 18.181000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20320.003,
"heapDeltaBytes": -25050612,
"heapUsedBytes": 176787636,
"domNodes": -6550,
"jsHeapTotalBytes": 802816,
"scriptDurationMs": 941.955,
"eventListeners": -7472,
"totalBlockingTimeMs": 21,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6162.454000000025,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.29,
"layouts": 20,
"layoutDurationMs": 22.542000000000005,
"taskDurationMs": 6057.026000000001,
"heapDeltaBytes": -37199168,
"heapUsedBytes": 170981312,
"domNodes": -6542,
"jsHeapTotalBytes": 9048064,
"scriptDurationMs": 110.435,
"eventListeners": -7476,
"totalBlockingTimeMs": 316,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6137.042000000065,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.654,
"layouts": 20,
"layoutDurationMs": 21.959000000000007,
"taskDurationMs": 6027.07,
"heapDeltaBytes": -42135392,
"heapUsedBytes": 177010948,
"domNodes": -6542,
"jsHeapTotalBytes": 10698752,
"scriptDurationMs": 108.651,
"eventListeners": -7476,
"totalBlockingTimeMs": 421,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8479.791000000092,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8251.192,
"heapDeltaBytes": 27979504,
"heapUsedBytes": 187541336,
"domNodes": 0,
"jsHeapTotalBytes": -6029312,
"scriptDurationMs": 129.846,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8430.243000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8209.625,
"heapDeltaBytes": 4075284,
"heapUsedBytes": 187451276,
"domNodes": 0,
"jsHeapTotalBytes": -10223616,
"scriptDurationMs": 133.422,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 451.3839999999618,
"styleRecalcs": 15,
"styleRecalcDurationMs": 24.337999999999997,
"layouts": 3,
"layoutDurationMs": 1.7889999999999997,
"taskDurationMs": 119.68600000000002,
"heapDeltaBytes": 5057744,
"heapUsedBytes": 66953632,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.449999999999998,
"eventListeners": 83,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 105.23399999988214,
"styleRecalcs": 8,
"styleRecalcDurationMs": 18.706999999999997,
"layouts": 3,
"layoutDurationMs": 1.4629999999999999,
"taskDurationMs": 82.71600000000001,
"heapDeltaBytes": 3008284,
"heapUsedBytes": 64706564,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.682,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #17525 +/- ##
==========================================
+ Coverage 82.54% 83.56% +1.02%
==========================================
Files 2697 2107 -590
Lines 136243 122718 -13525
Branches 35831 31973 -3858
==========================================
- Hits 112457 102545 -9912
+ Misses 22814 19992 -2822
+ Partials 972 181 -791
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
The ECS 1.53 plan asks for multiple paragraphs in a multiline widget to survive save and reload without flattening. This spec file covers entering multiline content and retaining it across focus changes, but nothing here crosses serialization. The fixture value includes a blank line between paragraphs and a trailing space — the two things a normalising or trimming serializer eats silently. Compared with exact equality rather than a substring, since a value flattened to one line still contains every word. Uses the getExportedWorkflow + loadGraphData round-trip that comboWidget.spec.ts and floatWidget.spec.ts already use for this question.
adc0bd0 to
d7243e8
Compare
|
Superseded — do not merge alongside #17505. 17505's The only thing this PR has that 17505 does not is the trailing space in the fixture value Leaving this open rather than closing it unilaterally — if 17505 stalls, this still covers the |
Summary
The ECS migration test plan (Area 3) asks a tester to enter multiple paragraphs in a multiline
text widget, save, and reload, checking the text is intact with no flattening. Nothing in the
suite crosses a reload for this widget.
multilineStringWidget.spec.tsalready covers entering multiline content and retaining itacross focus changes, so the widget itself is well covered — it is serialization that is not.
What it does
Fills the CLIP Text Encode textarea with a value that has a blank line between paragraphs
and a trailing space on one line, round-trips the workflow through
getExportedWorkflow()→loadGraphData()— the same shapecomboWidget.spec.tsandfloatWidget.spec.tsalready use for this question — and compares therestored value.
Why those two details
They are what a normalising or trimming serializer eats silently, and they are invisible to a
loose assertion:
toContaincheck passes on it. The comparison is exact equality for that reason.\n. Collapsing runs of whitespace keeps the text readableand the paragraph structure gone.
The value is also distinct from the widget's default (empty), so a reload that restored the
default rather than the edit fails with a visible diff rather than passing quietly.
Test plan
Test-only change; no source files touched.
Note on the earlier revision
The first version of this test used
waitForDraftIndexUpdatedSince+ a full page reload, andtimed out in CI at the wait. What I can state from the blob report is the observation, not the
cause: after
fill()on a text widget, noComfy.Workflow.DraftIndex.v2:*entry reported anupdatedAtnewer than the edit inside the 45 s timeout, while the structural mutations incollapse.spec.tsandresize.spec.tsdo satisfy the same wait. Focus is still in thetextarea at that point, so a commit-on-blur checkpoint would explain it, but I have not
confirmed that and am not claiming it.
Either way it is a separate question from this row — serialization is the layer the plan row
concerns — so the test now uses the round-trip helper the sibling widget specs use.