Repository navigation
test(widgets): an emptied promoted text widget stays empty across a round-trip - #17524
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThis change adds an end-to-end test for promoted text widget persistence across workflow serialization and reload. The test covers non-empty and intentionally cleared values. ChangesWidget persistence
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable merge risk remains from this test-only change. Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The PR metadata provides the description and identifies a changed file under ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 1969 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.96 MB gzip 🟢 -222 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 17 added / 17 removed / 1 unchanged Panels & Settings — 622 kB (baseline 622 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 16 unchanged User & Accounts — 26.2 kB (baseline 26.2 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 8 added / 8 removed / 3 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 118 kB (baseline 118 kB) • ⚪ 0 BReusable component library chunks
Status: 15 added / 15 removed Data & Services — 3.71 MB (baseline 3.71 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 16 added / 16 removed Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 28 added / 28 removed / 9 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Status: 6 added / 6 removed / 12 unchanged Other — 17.3 MB (baseline 17.3 MB) • ⚪ 0 BBundles that do not match a named category
Status: 119 added / 119 removed / 177 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-12T06:12:06.681Z",
"gitSha": "5cea6a783a846c89cc46d80cb86b8e17a6805c89",
"branch": "test/promoted-widget-empty-survives-reload",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2036.2569999999778,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.075000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.2049999999999,
"heapDeltaBytes": 891472,
"heapUsedBytes": 62231160,
"domNodes": -266,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.498000000000001,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2003.8219999999,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.788000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.49600000000004,
"heapDeltaBytes": 806372,
"heapUsedBytes": 63093364,
"domNodes": -264,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.155,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1843.9910000000168,
"styleRecalcs": 74,
"styleRecalcDurationMs": 28.009,
"layouts": 14,
"layoutDurationMs": 4.6,
"taskDurationMs": 856.6850000000001,
"heapDeltaBytes": 8854208,
"heapUsedBytes": 70967848,
"domNodes": -263,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 166.70200000000003,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1874.9470000000201,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.556,
"layouts": 14,
"layoutDurationMs": 4.6979999999999995,
"taskDurationMs": 868.1930000000001,
"heapDeltaBytes": 8785708,
"heapUsedBytes": 70969764,
"domNodes": -261,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 169.059,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1684.0730000000121,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.844999999999999,
"layouts": 6,
"layoutDurationMs": 1.1860000000000002,
"taskDurationMs": 344.43,
"heapDeltaBytes": 2188740,
"heapUsedBytes": 64097956,
"domNodes": 77,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.904,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.3310000000065,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.45,
"layouts": 6,
"layoutDurationMs": 1.164,
"taskDurationMs": 353.53600000000006,
"heapDeltaBytes": 2116372,
"heapUsedBytes": 64124564,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.902000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 642.8450000000225,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.186,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.337,
"heapDeltaBytes": 17894508,
"heapUsedBytes": 80005436,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 171.031,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 643.5770000000502,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.6679999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.84299999999996,
"heapDeltaBytes": 17946684,
"heapUsedBytes": 80136760,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 165.635,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2033.2139999999868,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.957000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.4420000000001,
"heapDeltaBytes": 2911264,
"heapUsedBytes": 82650560,
"domNodes": -250,
"jsHeapTotalBytes": -1056768,
"scriptDurationMs": 33.28700000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2036.4679999998998,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.125999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 593.792,
"heapDeltaBytes": 2906816,
"heapUsedBytes": 82627400,
"domNodes": -250,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 33.977999999999994,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2232.9799999999977,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.865,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1545.475,
"heapDeltaBytes": -606548,
"heapUsedBytes": 79607816,
"domNodes": -248,
"jsHeapTotalBytes": 479232,
"scriptDurationMs": 862.966,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2285.9220000000278,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.389000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1641.0849999999998,
"heapDeltaBytes": 18615224,
"heapUsedBytes": 83242460,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 850.6179999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3560.3099999999586,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.772999999999996,
"layouts": 60,
"layoutDurationMs": 13.011000000000001,
"taskDurationMs": 1681.0989999999997,
"heapDeltaBytes": 7273288,
"heapUsedBytes": 73744012,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 784.553,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3574.3329999999105,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.114999999999998,
"layouts": 60,
"layoutDurationMs": 12.572999999999999,
"taskDurationMs": 1767.1570000000002,
"heapDeltaBytes": -10722812,
"heapUsedBytes": 69944652,
"domNodes": -230,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 793.643,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3123.6049999999977,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.855000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1827.4589999999998,
"heapDeltaBytes": 20650872,
"heapUsedBytes": 86672760,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1028.046,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3053.23199999998,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.403000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1940.162,
"heapDeltaBytes": 19693324,
"heapUsedBytes": 85269432,
"domNodes": 2,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 973.3609999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2020.844000000011,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.734000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 608.1999999999999,
"heapDeltaBytes": -11682664,
"heapUsedBytes": 76302924,
"domNodes": -265,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 33.47800000000001,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2007.2720000000572,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.952,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.619,
"heapDeltaBytes": 19770108,
"heapUsedBytes": 84477760,
"domNodes": -251,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.65899999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 578.1199999999558,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.426000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.897,
"heapDeltaBytes": 13685568,
"heapUsedBytes": 76975560,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 143.374,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.2920000000095,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.147,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.268,
"heapDeltaBytes": 13942308,
"heapUsedBytes": 76923240,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 144.22,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2016.6540000000168,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.174,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.11800000000005,
"heapDeltaBytes": 7311024,
"heapUsedBytes": 70590284,
"domNodes": -278,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.476,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2021.8600000000606,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.011999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.94599999999997,
"heapDeltaBytes": 15996568,
"heapUsedBytes": 79203952,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.463999999999999,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.6519999999964,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.868,
"layouts": 18,
"layoutDurationMs": 5.152,
"taskDurationMs": 811.824,
"heapDeltaBytes": 646128,
"heapUsedBytes": 64208056,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 112.705,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.733999999983,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.187,
"layouts": 18,
"layoutDurationMs": 4.976999999999999,
"taskDurationMs": 785.101,
"heapDeltaBytes": 17155272,
"heapUsedBytes": 80354752,
"domNodes": -275,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 107.777,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.8759999999866,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.975,
"layouts": 5,
"layoutDurationMs": 13.144,
"taskDurationMs": 920.479,
"heapDeltaBytes": 19704644,
"heapUsedBytes": 101226304,
"domNodes": 13587,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 31.994000000000007,
"eventListeners": 2387,
"totalBlockingTimeMs": 146,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8468.064000000028,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.492,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5865.821000000001,
"heapDeltaBytes": -13861720,
"heapUsedBytes": 65563864,
"domNodes": -228,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 2763.938,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8425.067000000014,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.61,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5876.33,
"heapDeltaBytes": -12240968,
"heapUsedBytes": 67013368,
"domNodes": -245,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 2764.115,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16915.01599999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16551.056,
"heapDeltaBytes": -33759692,
"heapUsedBytes": 167980552,
"domNodes": -6542,
"jsHeapTotalBytes": -2297856,
"scriptDurationMs": 270.084,
"eventListeners": -7480,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16830.653000000097,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16370.598000000002,
"heapDeltaBytes": -39099748,
"heapUsedBytes": 168744984,
"domNodes": -6542,
"jsHeapTotalBytes": 2375680,
"scriptDurationMs": 257.89099999999996,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20475.549,
"styleRecalcs": 159,
"styleRecalcDurationMs": 17.235,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20205.613999999998,
"heapDeltaBytes": -24665884,
"heapUsedBytes": 176629008,
"domNodes": -6548,
"jsHeapTotalBytes": 1327104,
"scriptDurationMs": 919.4879999999999,
"eventListeners": -7476,
"totalBlockingTimeMs": 84,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20592.698999999924,
"styleRecalcs": 154,
"styleRecalcDurationMs": 17.604999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20356.412,
"heapDeltaBytes": -12834296,
"heapUsedBytes": 188304468,
"domNodes": -6542,
"jsHeapTotalBytes": 2568192,
"scriptDurationMs": 975.7660000000001,
"eventListeners": -7474,
"totalBlockingTimeMs": 28,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6130.786,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.17299999999999,
"layouts": 20,
"layoutDurationMs": 22.200999999999997,
"taskDurationMs": 6054.668,
"heapDeltaBytes": -15498020,
"heapUsedBytes": 179938312,
"domNodes": -6542,
"jsHeapTotalBytes": 11595776,
"scriptDurationMs": 109.87399999999998,
"eventListeners": -7474,
"totalBlockingTimeMs": 379,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6171.382999999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.72099999999999,
"layouts": 20,
"layoutDurationMs": 25.142999999999997,
"taskDurationMs": 6054.840999999999,
"heapDeltaBytes": -3869536,
"heapUsedBytes": 192437176,
"domNodes": -6542,
"jsHeapTotalBytes": 16101376,
"scriptDurationMs": 112.582,
"eventListeners": -7474,
"totalBlockingTimeMs": 505,
"frameDurationMs": 18.329999999999988,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8533.202000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8371.613000000001,
"heapDeltaBytes": 8359376,
"heapUsedBytes": 180457652,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 134.57700000000006,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8633.515999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8466.241,
"heapDeltaBytes": -3323748,
"heapUsedBytes": 181243668,
"domNodes": 0,
"jsHeapTotalBytes": -3670016,
"scriptDurationMs": 138.21000000000006,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 449.31600000001026,
"styleRecalcs": 14,
"styleRecalcDurationMs": 22.787,
"layouts": 4,
"layoutDurationMs": 1.724,
"taskDurationMs": 115.35999999999999,
"heapDeltaBytes": 4899008,
"heapUsedBytes": 66572816,
"domNodes": 120,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.623000000000001,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 108.32400000003872,
"styleRecalcs": 6,
"styleRecalcDurationMs": 13.409,
"layouts": 3,
"layoutDurationMs": 1.599,
"taskDurationMs": 80.976,
"heapDeltaBytes": 3019184,
"heapUsedBytes": 64789032,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.492999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #17524 +/- ##
==========================================
+ Coverage 82.53% 83.56% +1.03%
==========================================
Files 2697 2107 -590
Lines 136244 122717 -13527
Branches 37670 33812 -3858
==========================================
- Hits 112443 102549 -9894
+ Misses 22829 19987 -2842
+ Partials 972 181 -791
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…ound-trip Clearing a promoted text widget and reloading is an ECS 1.53 plan row with no automated coverage. The nearest existing spec clears a plain widget and reopens the tab; the promoted path serializes through the subgraph host instead, where an empty string is the value most likely to be dropped as falsy. The fixture ships this widget empty on the host AND on the interior node, so asserting "empty after a round-trip" on its own is vacuous — a reset to the interior default satisfies it too. The test round-trips a non-empty value first. That serves as a control (promoted text is recorded at all) and gives the second round-trip a distinguishable wrong answer to come back as. Uses the getExportedWorkflow + loadGraphData round-trip that comboWidget.spec.ts and floatWidget.spec.ts already use for this question.
c18445b to
57517a6
Compare
|
Superseded — do not merge alongside #17505. 17505 covers this same ECS Area 3 row ( The one thing it was missing is the control this PR exists for — the fixture ships the widget Leaving this open rather than closing it unilaterally: if 17505 stalls, this still covers the |
|
No follow-up PR needed. The sole review item was fixed before merge. Full context for agent readersDrJKL's suggestion removed the stale explanatory comment. Commit |
Summary
Clearing a promoted text widget and reloading is an unchecked row in the ECS migration
test plan (Area 3, "Clear a promoted text widget (empty it), save, reload. It is still empty —
not reset to a default"). Nothing in the suite asserts it.
The closest existing spec —
an emptied text widget remains empty after save and reopen, inthis same file — clears a plain widget. A promoted widget serializes through the subgraph
host instead, and an empty string is exactly the value a falsy check drops on the way there.
What it does
subgraphs/subgraph-with-promoted-text-widget.The round-trip is
getExportedWorkflow()→loadGraphData(), the same shapecomboWidget.spec.tsandfloatWidget.spec.tsalready use for this question.Why step 2 is not redundant
The fixture ships this widget empty (
widgets_values: ['']on both the host and the interiorCLIPTextEncode). So "empty after a round-trip" on its own is vacuous — a reset to theinterior default satisfies the assertion just as well as a correctly preserved empty value.
Round-tripping a non-empty value first fixes that, and does two jobs at once:
green run means the mechanism is live rather than silently absent.
clear is dropped as falsy, the widget reads
promoted value that must be cleared, not'',and the test fails with the actual wrong value in the diff.
Note on the earlier revision
The first version of this test used
waitForDraftIndexUpdatedSince+ a full page reload, andtimed out in CI at the wait. What I can state from the blob report is the observation, not the
cause: after
fill()on a text widget, noComfy.Workflow.DraftIndex.v2:*entry reported anupdatedAtnewer than the edit inside the 45 s timeout, while the structural mutations incollapse.spec.tsandresize.spec.tsdo satisfy the same wait. Focus is still in thetextarea at that point, so a commit-on-blur checkpoint would explain it, but I have not
confirmed that and am not claiming it.
Either way it is a separate question from this row — serialization is the layer the plan row
concerns — so the test now uses the round-trip helper the sibling widget specs use.
Test plan
Test-only change; no source files touched.