Repository navigation
fix(agent): drop stale workflow tab bindings before resolving graph scope - #17518
Conversation
…cope A persisted Comfy.Agent.WorkflowTabBindings entry can map a cloud workflow id to a tab that now holds a differently named saved workflow. The resolver trusted that binding, so agent mutations for one cloud workflow were applied to another workflow's canvas and saved there (phantom LoadImage / ByteDance2ReferenceNodeV2 / SaveVideo nodes in text-to-image workflows). Detect the stale binding against the cloud name index, unbind it, and fall through to name-based resolution.
|
Warning Review limit reached
On-demand reviews are free for the next 28 days. After that, they cost $0.25 per reviewed file. Or wait 5 minutes for your next included review. View limit detailsLimit details: You’ve used all 8 included reviews currently available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1968 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.96 MB gzip 🔴 +45 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 622 kB (baseline 622 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 26.2 kB (baseline 26.2 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 118 kB (baseline 118 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.71 MB (baseline 3.71 MB) • 🟢 -244 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 18 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.3 MB (baseline 17.3 MB) • ⚪ 0 BBundles that do not match a named category
Status: 72 added / 72 removed / 224 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-12T04:11:17.917Z",
"gitSha": "e6706c421558c325288d6d39856a0d21547db784",
"branch": "christian-byrne/hp-ecw-465-stale-tab-binding",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1988.7850000000071,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.675000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.15500000000003,
"heapDeltaBytes": -3443004,
"heapUsedBytes": 58284496,
"domNodes": -261,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.734000000000001,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1992.3619999999573,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.575000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 361.241,
"heapDeltaBytes": 8837180,
"heapUsedBytes": 70915992,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.5539999999999985,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1726.3810000000035,
"styleRecalcs": 75,
"styleRecalcDurationMs": 22.467000000000002,
"layouts": 14,
"layoutDurationMs": 4.069,
"taskDurationMs": 686.9879999999999,
"heapDeltaBytes": -4448884,
"heapUsedBytes": 57870832,
"domNodes": -261,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 123.336,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1711.5229999999428,
"styleRecalcs": 74,
"styleRecalcDurationMs": 21.273,
"layouts": 14,
"layoutDurationMs": 3.8519999999999994,
"taskDurationMs": 670.413,
"heapDeltaBytes": 15385908,
"heapUsedBytes": 77348304,
"domNodes": -261,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 122.355,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.031000000015,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.299000000000001,
"layouts": 6,
"layoutDurationMs": 1.045,
"taskDurationMs": 270.41499999999996,
"heapDeltaBytes": 2198176,
"heapUsedBytes": 64415980,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.650999999999998,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.6889999999594,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.794000000000002,
"layouts": 6,
"layoutDurationMs": 1.062,
"taskDurationMs": 270.088,
"heapDeltaBytes": 2107316,
"heapUsedBytes": 64210236,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.486,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 526.0569999999802,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.533,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 360.66200000000003,
"heapDeltaBytes": 17924828,
"heapUsedBytes": 80076368,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 130.853,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 527.800999999954,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.858000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 360.40799999999996,
"heapDeltaBytes": 18164184,
"heapUsedBytes": 80254328,
"domNodes": 19,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 127.554,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2017.7249999999844,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.5410000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.939,
"heapDeltaBytes": 2670936,
"heapUsedBytes": 83377992,
"domNodes": -246,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 29.744999999999994,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2023.2449999999744,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.452000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.7580000000001,
"heapDeltaBytes": 4047784,
"heapUsedBytes": 83732712,
"domNodes": -243,
"jsHeapTotalBytes": -1056768,
"scriptDurationMs": 29.265999999999995,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2118.9549999999713,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.008000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1266.8249999999998,
"heapDeltaBytes": 1571636,
"heapUsedBytes": 82679696,
"domNodes": -244,
"jsHeapTotalBytes": 741376,
"scriptDurationMs": 740.005,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2108.3810000000085,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.237,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1263.701,
"heapDeltaBytes": 18106200,
"heapUsedBytes": 82709600,
"domNodes": 8,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 650.958,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3179.5209999999656,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.07,
"layouts": 60,
"layoutDurationMs": 12.195,
"taskDurationMs": 1352.075,
"heapDeltaBytes": 4062328,
"heapUsedBytes": 70085396,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 636.4329999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3234.8220000000083,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.440000000000001,
"layouts": 60,
"layoutDurationMs": 12.857000000000003,
"taskDurationMs": 1441.732,
"heapDeltaBytes": -6634924,
"heapUsedBytes": 73989608,
"domNodes": -263,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 651.3050000000001,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2311.9970000000194,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.084999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1536.75,
"heapDeltaBytes": -18755468,
"heapUsedBytes": 71113100,
"domNodes": -250,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 758.814,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2266.8279999999186,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.529,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1517.7549999999997,
"heapDeltaBytes": 14090868,
"heapUsedBytes": 80018224,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 776.621,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2033.4399999999846,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.607000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.27299999999997,
"heapDeltaBytes": -10224424,
"heapUsedBytes": 77572244,
"domNodes": -257,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 28.467999999999993,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2014.3470000000434,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.432,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.907,
"heapDeltaBytes": -9179308,
"heapUsedBytes": 78327336,
"domNodes": -251,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 28.649,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 515.3260000000159,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.836,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.27799999999996,
"heapDeltaBytes": 13482476,
"heapUsedBytes": 76740332,
"domNodes": 22,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 118.223,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 541.0620000000108,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.900999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 332.304,
"heapDeltaBytes": 13440984,
"heapUsedBytes": 76843604,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 116.64,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.37700000001,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.677000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.596,
"heapDeltaBytes": -2481240,
"heapUsedBytes": 60876756,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.922999999999998,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1991.918999999939,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.098000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.53800000000007,
"heapDeltaBytes": -4427716,
"heapUsedBytes": 58364896,
"domNodes": -275,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.229999999999999,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1687.293000000011,
"styleRecalcs": 78,
"styleRecalcDurationMs": 22.557000000000002,
"layouts": 18,
"layoutDurationMs": 4.534,
"taskDurationMs": 621.842,
"heapDeltaBytes": -1028276,
"heapUsedBytes": 62238484,
"domNodes": -272,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 83.788,
"eventListeners": -228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.9859999999953,
"styleRecalcs": 77,
"styleRecalcDurationMs": 20.187,
"layouts": 18,
"layoutDurationMs": 4.103,
"taskDurationMs": 610.344,
"heapDeltaBytes": 7654476,
"heapUsedBytes": 70878900,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 81.09700000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 867.0319999999947,
"styleRecalcs": 18,
"styleRecalcDurationMs": 21.558000000000007,
"layouts": 5,
"layoutDurationMs": 9.102,
"taskDurationMs": 669.8090000000001,
"heapDeltaBytes": 19544588,
"heapUsedBytes": 101081304,
"domNodes": 13587,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 23.208,
"eventListeners": 2385,
"totalBlockingTimeMs": 90,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8289.219000000003,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.925000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4626.814,
"heapDeltaBytes": -14346116,
"heapUsedBytes": 65488436,
"domNodes": -245,
"jsHeapTotalBytes": 1826816,
"scriptDurationMs": 2195.1969999999997,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8144.444000000021,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.901,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4672.039,
"heapDeltaBytes": -14285676,
"heapUsedBytes": 66032872,
"domNodes": -214,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 2220.704,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14597.511999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13984.326,
"heapDeltaBytes": -28225712,
"heapUsedBytes": 181069012,
"domNodes": -6542,
"jsHeapTotalBytes": 2113536,
"scriptDurationMs": 236.27499999999998,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14414.323999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14141.921000000002,
"heapDeltaBytes": -28060272,
"heapUsedBytes": 180656424,
"domNodes": -6542,
"jsHeapTotalBytes": 3424256,
"scriptDurationMs": 222.99400000000003,
"eventListeners": -7480,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13863.358000000006,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.664000000000009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13223.240999999998,
"heapDeltaBytes": -32593928,
"heapUsedBytes": 168530816,
"domNodes": -6541,
"jsHeapTotalBytes": 9949184,
"scriptDurationMs": 688.493,
"eventListeners": -7478,
"totalBlockingTimeMs": 43,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 17215.06899999997,
"styleRecalcs": 129,
"styleRecalcDurationMs": 20.127000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16994.605,
"heapDeltaBytes": -21807256,
"heapUsedBytes": 173126124,
"domNodes": -6542,
"jsHeapTotalBytes": -2166784,
"scriptDurationMs": 775.38,
"eventListeners": -7476,
"totalBlockingTimeMs": 46,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5092.628999999988,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.65700000000002,
"layouts": 20,
"layoutDurationMs": 21.227999999999998,
"taskDurationMs": 5026.764999999999,
"heapDeltaBytes": -16837956,
"heapUsedBytes": 180939084,
"domNodes": -6542,
"jsHeapTotalBytes": 15503360,
"scriptDurationMs": 87.87899999999999,
"eventListeners": -7478,
"totalBlockingTimeMs": 186,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5224.639000000025,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.42300000000003,
"layouts": 20,
"layoutDurationMs": 21.316000000000003,
"taskDurationMs": 5186.35,
"heapDeltaBytes": -20644744,
"heapUsedBytes": 174288920,
"domNodes": -6542,
"jsHeapTotalBytes": 19853312,
"scriptDurationMs": 90.12699999999998,
"eventListeners": -7475,
"totalBlockingTimeMs": 196,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7113.435999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6891.227000000001,
"heapDeltaBytes": 18339848,
"heapUsedBytes": 181849772,
"domNodes": 0,
"jsHeapTotalBytes": -2621440,
"scriptDurationMs": 124.42900000000007,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7229.858999999919,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7105.287,
"heapDeltaBytes": -12289428,
"heapUsedBytes": 179833272,
"domNodes": 0,
"jsHeapTotalBytes": -3670016,
"scriptDurationMs": 100.66300000000005,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 432.5019999999995,
"styleRecalcs": 15,
"styleRecalcDurationMs": 20.764999999999997,
"layouts": 4,
"layoutDurationMs": 1.8469999999999998,
"taskDurationMs": 106.678,
"heapDeltaBytes": 5070508,
"heapUsedBytes": 66761176,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.418000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 95.71200000004865,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.019,
"layouts": 3,
"layoutDurationMs": 1.3430000000000002,
"taskDurationMs": 66.308,
"heapDeltaBytes": 3013540,
"heapUsedBytes": 64811608,
"domNodes": 126,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.657999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #17518 +/- ##
==========================================
+ Coverage 82.53% 83.57% +1.03%
==========================================
Files 2697 2107 -590
Lines 136238 122726 -13512
Branches 37669 33816 -3853
==========================================
- Hits 112446 102564 -9882
+ Misses 22820 19981 -2839
+ Partials 972 181 -791
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 599 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
The Timeline
The check has sat red since, on a rule that no longer exists. The current merge ref no longer contains it: So a fresh run would not execute this check at all. Any new push to the branch clears it; failing that it needs an admin dismissal, since a check whose workflow no longer exists can never report green on its own. What it was complaining about, for the record. And the policy had a real defect worth knowing if it is ever re-landed. Evaluated against its own risk map with Node's
No action taken on this branch — there is nothing here to fix. |
CodeJuggernaut
left a comment
There was a problem hiding this comment.
Clean: the new test pins the stale-binding fix, nothing else moved. The red feature-flag-policy row is the stale check from the reverted workflow, not a required one.
DrJKL
left a comment
There was a problem hiding this comment.
The stale-binding fix still misses cloud IDs whose names are duplicated in the workflow index. In that case the resolver can return the persisted, unrelated graph and route mutations into it, so I am leaving a correctness comment rather than approving this head.
Linear tickets: none. This is a pre-merge correctness defect in the shipped-code fix, not deferred follow-up.
Local checks at 096bfefeb5e1120f5db84158ec27c2cdfd0bd677:
pnpm typecheck: passedpnpm typecheck:browser: passed- diff-scoped ESLint: passed
- diff-scoped type-aware oxlint: passed
- diff-scoped oxfmt: passed
git diff --check: passed- focused Vitest for the resolver, binding store, and
AgentPanelRoot: 3 files, 234 tests passed - focused duplicate-name falsifier: failed as expected because
boundOrOpenWorkflowFor('cloud-zimage')returned the unrelatedPortraitworkflow
Standard-depth coverage included correctness, maintainability, TypeScript idioms, tests, the binding store and resolver consumers, and the PR's behavior claims.
| } | ||
|
|
||
| function indexedNameFor(workflowId: string): string | undefined { | ||
| for (const [name, id] of cloudIdsByName.value) { |
There was a problem hiding this comment.
P1 correctness: cloudIdsByName deliberately omits every name that maps to multiple cloud IDs, so this reverse lookup returns undefined for each of those IDs. bindingIsStale then trusts the persisted binding even when its saved tab has a different, uniquely mapped cloud ID. A focused test with two image_z_image_turbo IDs and a stale cloud-zimage -> Portrait binding failed: boundOrOpenWorkflowFor("cloud-zimage") returned Portrait instead of null, leaving the cross-workflow mutation path open. Please derive the target ID's indexed name from cloudIndex while keeping the unique name-to-ID map for identifying the bound tab, and cover this duplicate-name case.
…cope (#17518) ## Summary Saved text-to-image workflows durably acquired unrelated `LoadImage` / `ByteDance2ReferenceNodeV2` / `SaveVideo` nodes bound to docs named `image_z_image_turbo*`, persisting across reload (nightly FE 1.55.3; program row ecw-465). **Root cause.** `useAgentWorkflowTabBindingStore` persists `Comfy.Agent.WorkflowTabBindings` (cloud workflow id -> tab path) in localStorage. `matchesWorkflow` is true for any saved tab, so a stale entry such as `cloud-zimage -> <Portrait tab path>` survives after the tab comes to hold a different saved workflow. `useAgentWorkflowResolver.resolveWorkflow` returned that bound tab first, so `AgentPanelRoot` (`graphMutations(workflowId).getScope()`) applied one cloud workflow's mutations to another workflow's canvas, which was then saved. **Fix.** Before trusting a persisted binding, compare it against the cloud name index: a binding is stale when the bound tab is not temporary, the id's indexed name differs from the tab's cloud name, and the tab's name resolves to a different cloud id. Stale bindings are unbound and resolution falls through to the existing name-based loop. Temporary tabs and legitimately renamed tabs are untouched. Distinct from QAF-68 (cross-tab bleed while a mutation stream is in flight, #17331): that is a runtime scope switch; this is a durable persisted-binding mismatch that reproduces on a fresh reload. ## Evidence - Resolution before: binding `cloud-zimage -> Portrait tab` + `matchesWorkflow` true -> Portrait tab returned -> zimage doc ops mutate the Portrait graph. - Resolution after: `bindingIsStale('cloud-zimage', Portrait)` is true (index name `image_z_image_turbo` != `Portrait`, `Portrait -> cloud-portrait`) -> binding removed -> name loop returns the `image_z_image_turbo` tab; `tabPathFor('cloud-zimage')` is `undefined` afterwards. - New test: `rejects a stale binding that points a cloud id at a differently named saved tab` in `useAgentWorkflowResolver.test.ts`. - `pnpm vitest run src/workbench/extensions/agent`: 93 files, 1406 tests passed. - `pnpm typecheck`: exit 0, no errors. - `pnpm adr:check`: passed. - Live nightly repro not re-run here: agent.comfy.org is behind Cloudflare Access (program OOS-1). Verification is at the resolver boundary with the same inputs the panel passes. ## Notes - Touches the same resolver file as #17509 (workflow listing cache); land this after #17509 or expect a trivial rebase. - Severity stays data-loss: the phantom nodes were written into the user's saved workflow. <!-- authored-by:agent role-hard-problem --> (cherry picked from commit d272111)
…cope (#17518) ## Summary Saved text-to-image workflows durably acquired unrelated `LoadImage` / `ByteDance2ReferenceNodeV2` / `SaveVideo` nodes bound to docs named `image_z_image_turbo*`, persisting across reload (nightly FE 1.55.3; program row ecw-465). **Root cause.** `useAgentWorkflowTabBindingStore` persists `Comfy.Agent.WorkflowTabBindings` (cloud workflow id -> tab path) in localStorage. `matchesWorkflow` is true for any saved tab, so a stale entry such as `cloud-zimage -> <Portrait tab path>` survives after the tab comes to hold a different saved workflow. `useAgentWorkflowResolver.resolveWorkflow` returned that bound tab first, so `AgentPanelRoot` (`graphMutations(workflowId).getScope()`) applied one cloud workflow's mutations to another workflow's canvas, which was then saved. **Fix.** Before trusting a persisted binding, compare it against the cloud name index: a binding is stale when the bound tab is not temporary, the id's indexed name differs from the tab's cloud name, and the tab's name resolves to a different cloud id. Stale bindings are unbound and resolution falls through to the existing name-based loop. Temporary tabs and legitimately renamed tabs are untouched. Distinct from QAF-68 (cross-tab bleed while a mutation stream is in flight, #17331): that is a runtime scope switch; this is a durable persisted-binding mismatch that reproduces on a fresh reload. ## Evidence - Resolution before: binding `cloud-zimage -> Portrait tab` + `matchesWorkflow` true -> Portrait tab returned -> zimage doc ops mutate the Portrait graph. - Resolution after: `bindingIsStale('cloud-zimage', Portrait)` is true (index name `image_z_image_turbo` != `Portrait`, `Portrait -> cloud-portrait`) -> binding removed -> name loop returns the `image_z_image_turbo` tab; `tabPathFor('cloud-zimage')` is `undefined` afterwards. - New test: `rejects a stale binding that points a cloud id at a differently named saved tab` in `useAgentWorkflowResolver.test.ts`. - `pnpm vitest run src/workbench/extensions/agent`: 93 files, 1406 tests passed. - `pnpm typecheck`: exit 0, no errors. - `pnpm adr:check`: passed. - Live nightly repro not re-run here: agent.comfy.org is behind Cloudflare Access (program OOS-1). Verification is at the resolver boundary with the same inputs the panel passes. ## Notes - Touches the same resolver file as #17509 (workflow listing cache); land this after #17509 or expect a trivial rebase. - Severity stays data-loss: the phantom nodes were written into the user's saved workflow. <!-- authored-by:agent role-hard-problem --> (cherry picked from commit d272111)
Summary
Saved text-to-image workflows durably acquired unrelated
LoadImage/ByteDance2ReferenceNodeV2/SaveVideonodes bound to docs namedimage_z_image_turbo*, persisting across reload (nightly FE 1.55.3; program row ecw-465).Root cause.
useAgentWorkflowTabBindingStorepersistsComfy.Agent.WorkflowTabBindings(cloud workflow id -> tab path) in localStorage.matchesWorkflowis true for any saved tab, so a stale entry such ascloud-zimage -> <Portrait tab path>survives after the tab comes to hold a different saved workflow.useAgentWorkflowResolver.resolveWorkflowreturned that bound tab first, soAgentPanelRoot(graphMutations(workflowId).getScope()) applied one cloud workflow's mutations to another workflow's canvas, which was then saved.Fix. Before trusting a persisted binding, compare it against the cloud name index: a binding is stale when the bound tab is not temporary, the id's indexed name differs from the tab's cloud name, and the tab's name resolves to a different cloud id. Stale bindings are unbound and resolution falls through to the existing name-based loop. Temporary tabs and legitimately renamed tabs are untouched.
Distinct from QAF-68 (cross-tab bleed while a mutation stream is in flight, #17331): that is a runtime scope switch; this is a durable persisted-binding mismatch that reproduces on a fresh reload.
Evidence
cloud-zimage -> Portrait tab+matchesWorkflowtrue -> Portrait tab returned -> zimage doc ops mutate the Portrait graph.bindingIsStale('cloud-zimage', Portrait)is true (index nameimage_z_image_turbo!=Portrait,Portrait -> cloud-portrait) -> binding removed -> name loop returns theimage_z_image_turbotab;tabPathFor('cloud-zimage')isundefinedafterwards.rejects a stale binding that points a cloud id at a differently named saved tabinuseAgentWorkflowResolver.test.ts.pnpm vitest run src/workbench/extensions/agent: 93 files, 1406 tests passed.pnpm typecheck: exit 0, no errors.pnpm adr:check: passed.Notes