Skip to content

fix(graph): scope untitled reconcile title keep to subgraphs - #17499

Closed
huang47 wants to merge 4 commits into
fix/agent-subgraph-instance-reconcilefrom
cursor/agent-reconcile-title-scope-410e
Closed

huang47 wants to merge 4 commits into
fix/agent-subgraph-instance-reconcilefrom
cursor/agent-reconcile-title-scope-410e

Conversation

@huang47

@huang47 huang47 commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Untitled catalog reconcile was keeping a configure() display name (Load Checkpoint) on the canvas; the committed cloud screenshot expects the type (CheckpointLoaderSimple). Incumbent-title keep is now limited to UUID subgraph instances (PM-827). Untitled catalog reconcile also writes type onto lastSerialization so catch-up rematerialize cannot fall back to display_name. Agent addNode is unchanged so newly added nodes still show their class display name.

Verification

Unit (green):

pnpm test:unit src/core/graph/graphMutations.test.ts src/workbench/extensions/agent/crdt/agentNodeMaterializer.test.ts

62 passed. Catalog untitled reconcile uses type as title and keeps the output wire; subgraph instance title / promoted widgets / output-connectivity (PM-827) still pass.

E2E — @cloud agentConversationReplay.spec.ts cannot run against a live Comfy backend here (no Docker /ComfyUI). Local stand-in: merge-queue-equivalent tree (main + #16964 + this branch), pnpm build:cloud, stub /api/object_info with CheckpointLoaderSimple.display_name = "Load Checkpoint", PLAYWRIGHT_TEST_URL=http://127.0.0.1:8188.

DISTRIBUTION=cloud PLAYWRIGHT_TEST_URL=http://127.0.0.1:8188 RECORD_VIDEO=true \
  pnpm exec playwright test browser_tests/tests/agent/_evidenceTwoTurnWired.spec.ts --project=cloud

Passed. Expected: Vue/canvas title CheckpointLoaderSimple (not Load Checkpoint); CLIPTextEncode → KSampler targetSlot === 2 wire present.

DISTRIBUTION=cloud PLAYWRIGHT_TEST_URL=http://127.0.0.1:8188 \
  pnpm exec playwright test browser_tests/tests/agent/agentConversationReplay.spec.ts --project=cloud --grep "paints the wire"

Failed toHaveScreenshot with 25638 px (ratio 0.01) — local fonts/viewport/stub vs CI cloud snapshot. Title text in the local actual is CheckpointLoaderSimple (the #16964 504 px regression was Load Checkpoint). Committed Playwright snapshots were not bumped.

Before (UUID-gate only; title still Load Checkpoint):

Before fix: checkpoint chrome still reads Load Checkpoint

After (catalog lastSerialization persist; title CheckpointLoaderSimple, second-turn wire present):

After fix: checkpoint chrome reads CheckpointLoaderSimple and the negative CLIP wire is present

Checkpoint node title after fix is CheckpointLoaderSimple

Official spec local actual (title matches baseline; pixel delta is environment):

Official replay spec local actual: CheckpointLoaderSimple

two-turn-wired-after-fix.webm

To show artifacts inline, enable in settings.

Open in Web Open in Cursor 

Untitled reconcile of a catalog node must keep using the type as title so
a follower snapshot does not rename CheckpointLoaderSimple to its class
display name. Subgraph instance titles still survive when the payload has
none.
@coderabbitai

coderabbitai Bot commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: db5af79e-f771-4bc2-81ce-689d9c793f49

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1940 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1919 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/12/2026, 06:38:00 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.0 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.9 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.5 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 88ms TBT · 94.0 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.0 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 179.1 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 68ms TBT · 161.1 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 116ms TBT · 175.4 MB heap
vue-zoom-out-idle: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 173.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 328ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 65.3 MB
canvas-idle: DOM nodes -260
canvas-idle: event listeners -170
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 21ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 73
canvas-mouse-sweep: task duration 647ms
canvas-mouse-sweep: script duration 117ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 72.2 MB
canvas-mouse-sweep: DOM nodes -261
canvas-mouse-sweep: event listeners -152
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 12ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 264ms
canvas-zoom-sweep: script duration 9ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 61.0 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 6ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 355ms
dom-widget-clipping: script duration 132ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 75.9 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 466ms
large-graph-idle: script duration 28ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 76.5 MB
large-graph-idle: DOM nodes -244
large-graph-idle: event listeners -165
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1227ms
large-graph-pan: script duration 626ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 76.7 MB
large-graph-pan: DOM nodes -122
large-graph-pan: event listeners 6
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 11ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 63
large-graph-zoom: task duration 1319ms
large-graph-zoom: script duration 613ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 70.9 MB
large-graph-zoom: DOM nodes 8
large-graph-zoom: event listeners 7
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 1512ms
legacy-node-drag: script duration 765ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 71.7 MB
legacy-node-drag: DOM nodes -109
legacy-node-drag: event listeners 93
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 479ms
minimap-idle: script duration 27ms
minimap-idle: TBT 0ms
minimap-idle: heap used 75.1 MB
minimap-idle: DOM nodes -251
minimap-idle: event listeners -181
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 8ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 311ms
subgraph-dom-widget-clipping: script duration 112ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 73.2 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 6ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 323ms
subgraph-idle: script duration 6ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 65.8 MB
subgraph-idle: DOM nodes -276
subgraph-idle: event listeners -214
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 22ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 79
subgraph-mouse-sweep: task duration 577ms
subgraph-mouse-sweep: script duration 83ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 69.5 MB
subgraph-mouse-sweep: DOM nodes -274
subgraph-mouse-sweep: event listeners -198
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 10ms
subgraph-transition-enter: style recalc duration 22ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 672ms
subgraph-transition-enter: script duration 21ms
subgraph-transition-enter: TBT 88ms
subgraph-transition-enter: heap used 94.0 MB
subgraph-transition-enter: DOM nodes 13587
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 4475ms
viewport-pan-sweep: script duration 2128ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 68.0 MB
viewport-pan-sweep: DOM nodes -242
viewport-pan-sweep: event listeners -136
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 13742ms
vue-large-graph-idle: script duration 211ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 179.1 MB
vue-large-graph-idle: DOM nodes -6542
vue-large-graph-idle: event listeners -7477
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 14ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 132
vue-large-graph-pan: task duration 16419ms
vue-large-graph-pan: script duration 733ms
vue-large-graph-pan: TBT 68ms
vue-large-graph-pan: heap used 161.1 MB
vue-large-graph-pan: DOM nodes -6542
vue-large-graph-pan: event listeners -7475
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 21ms
vue-node-resize-workload: style recalc duration 61ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4461ms
vue-node-resize-workload: script duration 81ms
vue-node-resize-workload: TBT 116ms
vue-node-resize-workload: heap used 175.4 MB
vue-node-resize-workload: DOM nodes -6543
vue-node-resize-workload: event listeners -7479
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 6799ms
vue-zoom-out-idle: script duration 100ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 173.5 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -11
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 16ms
workflow-execution: layout count 3
workflow-execution: style recalc count 15
workflow-execution: task duration 89ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 63.3 MB
workflow-execution: DOM nodes 124
workflow-execution: event listeners 82
Raw data
{
  "timestamp": "2026-09-12T06:52:21.992Z",
  "gitSha": "426c935ac466a35ad078f3f3df17dc307cf1d4d6",
  "branch": "cursor/agent-reconcile-title-scope-410e",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 1989.9430000000393,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 5.375999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 286.47299999999996,
      "heapDeltaBytes": 12356156,
      "heapUsedBytes": 74134480,
      "domNodes": -262,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 7.055000000000002,
      "eventListeners": -154,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2008.6539999999786,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.672000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 370.102,
      "heapDeltaBytes": 1134112,
      "heapUsedBytes": 62828416,
      "domNodes": -258,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 6.830999999999999,
      "eventListeners": -186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1694.833000000017,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 19.605999999999998,
      "layouts": 14,
      "layoutDurationMs": 3.427,
      "taskDurationMs": 642.2710000000001,
      "heapDeltaBytes": 10846692,
      "heapUsedBytes": 72915388,
      "domNodes": -261,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 115.077,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1694.2710000000147,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 21.728,
      "layouts": 14,
      "layoutDurationMs": 3.765,
      "taskDurationMs": 651.995,
      "heapDeltaBytes": 16728584,
      "heapUsedBytes": 78586460,
      "domNodes": -261,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 119.87100000000001,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1725.9449999999674,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 11.979999999999999,
      "layouts": 6,
      "layoutDurationMs": 0.9450000000000001,
      "taskDurationMs": 268.324,
      "heapDeltaBytes": 2176776,
      "heapUsedBytes": 63982680,
      "domNodes": 75,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 9.425000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1708.8470000000484,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 12.465,
      "layouts": 6,
      "layoutDurationMs": 0.8839999999999999,
      "taskDurationMs": 259.695,
      "heapDeltaBytes": 1880912,
      "heapUsedBytes": 63994204,
      "domNodes": 76,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 9.171999999999999,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 534.2909999999961,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.303,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 354.41299999999995,
      "heapDeltaBytes": 17530952,
      "heapUsedBytes": 79586064,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 130.271,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 526.9890000000146,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.504000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 356.451,
      "heapDeltaBytes": 17593144,
      "heapUsedBytes": 79540904,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 132.885,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2023.2560000000035,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 5.512000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 456.69000000000005,
      "heapDeltaBytes": 2478160,
      "heapUsedBytes": 82741396,
      "domNodes": -239,
      "jsHeapTotalBytes": -1282048,
      "scriptDurationMs": 28.274,
      "eventListeners": -150,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2007.74100000001,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.596999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 476.24600000000004,
      "heapDeltaBytes": -2970988,
      "heapUsedBytes": 77724780,
      "domNodes": -249,
      "jsHeapTotalBytes": 290816,
      "scriptDurationMs": 27.312999999999995,
      "eventListeners": -180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2102.47499999997,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 10.253000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1211.8609999999999,
      "heapDeltaBytes": 13879888,
      "heapUsedBytes": 78418776,
      "domNodes": 8,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 621.505,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2143.340999999964,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 10.125000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1241.462,
      "heapDeltaBytes": 18156152,
      "heapUsedBytes": 82498756,
      "domNodes": -252,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 630.2520000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3161.6319999999973,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 11.462,
      "layouts": 60,
      "layoutDurationMs": 11.117,
      "taskDurationMs": 1328.944,
      "heapDeltaBytes": 8373396,
      "heapUsedBytes": 74305808,
      "domNodes": 8,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 622.364,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3092.129,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 11.269000000000002,
      "layouts": 60,
      "layoutDurationMs": 11.049,
      "taskDurationMs": 1309.558,
      "heapDeltaBytes": 8515928,
      "heapUsedBytes": 74288744,
      "domNodes": 8,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 604.0649999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2162.278000000015,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 8.949000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1541.3579999999997,
      "heapDeltaBytes": -17074724,
      "heapUsedBytes": 66347292,
      "domNodes": -224,
      "jsHeapTotalBytes": -8192,
      "scriptDurationMs": 766.3729999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2185.444000000018,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 6.1629999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1482.001,
      "heapDeltaBytes": 16342568,
      "heapUsedBytes": 83923976,
      "domNodes": 6,
      "jsHeapTotalBytes": 942080,
      "scriptDurationMs": 763.729,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2034.3450000000303,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.545000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 475.95200000000006,
      "heapDeltaBytes": -1799508,
      "heapUsedBytes": 78636324,
      "domNodes": -254,
      "jsHeapTotalBytes": 516096,
      "scriptDurationMs": 26.651000000000007,
      "eventListeners": -180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2017.8750000000036,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.8870000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 482.67,
      "heapDeltaBytes": -8380472,
      "heapUsedBytes": 78786656,
      "domNodes": -247,
      "jsHeapTotalBytes": 552960,
      "scriptDurationMs": 27.59099999999999,
      "eventListeners": -182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 531.4940000000092,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 8.695,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 314.746,
      "heapDeltaBytes": 13348528,
      "heapUsedBytes": 76565912,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 111.719,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 513.2360000000062,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 8.122,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 307.342,
      "heapDeltaBytes": 13972784,
      "heapUsedBytes": 76963080,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 112.63600000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1993.7439999999924,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.111999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 289.718,
      "heapDeltaBytes": -4913728,
      "heapUsedBytes": 57652976,
      "domNodes": -276,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 6.305,
      "eventListeners": -230,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.55300000003,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.7440000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 357.2319999999999,
      "heapDeltaBytes": 17524484,
      "heapUsedBytes": 80405204,
      "domNodes": -275,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 6.473000000000002,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1721.9369999999685,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 21.589999999999996,
      "layouts": 18,
      "layoutDurationMs": 3.711,
      "taskDurationMs": 610.0550000000001,
      "heapDeltaBytes": 7774916,
      "heapUsedBytes": 70900556,
      "domNodes": -273,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 80.095,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1695.1520000000073,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 22.535,
      "layouts": 18,
      "layoutDurationMs": 4.661,
      "taskDurationMs": 543.911,
      "heapDeltaBytes": 11875360,
      "heapUsedBytes": 74844852,
      "domNodes": -275,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 85.242,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 850.5860000000212,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 22.194000000000006,
      "layouts": 5,
      "layoutDurationMs": 9.574,
      "taskDurationMs": 672.034,
      "heapDeltaBytes": 17761832,
      "heapUsedBytes": 98551728,
      "domNodes": 13587,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 21.49899999999999,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 88,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8196.41999999999,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 36.004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4479.887,
      "heapDeltaBytes": -13549128,
      "heapUsedBytes": 67169020,
      "domNodes": -241,
      "jsHeapTotalBytes": 4222976,
      "scriptDurationMs": 2121.333,
      "eventListeners": -136,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8176.8850000000275,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 34.403,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4470.799999999999,
      "heapDeltaBytes": -4549448,
      "heapUsedBytes": 75412804,
      "domNodes": -242,
      "jsHeapTotalBytes": -45056,
      "scriptDurationMs": 2134.5170000000003,
      "eventListeners": -136,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14623.568000000034,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13854.167000000001,
      "heapDeltaBytes": -17558028,
      "heapUsedBytes": 194460992,
      "domNodes": -6542,
      "jsHeapTotalBytes": 4173824,
      "scriptDurationMs": 210.20100000000002,
      "eventListeners": -7476,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14431.252000000086,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13629.545000000002,
      "heapDeltaBytes": -15481108,
      "heapUsedBytes": 181121436,
      "domNodes": -6542,
      "jsHeapTotalBytes": -1798144,
      "scriptDurationMs": 211.459,
      "eventListeners": -7478,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16737.267000000033,
      "styleRecalcs": 127,
      "styleRecalcDurationMs": 13.450000000000017,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16308.032999999998,
      "heapDeltaBytes": -21545156,
      "heapUsedBytes": 173021112,
      "domNodes": -6542,
      "jsHeapTotalBytes": -5312512,
      "scriptDurationMs": 751.0450000000001,
      "eventListeners": -7476,
      "totalBlockingTimeMs": 67,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16935.16999999997,
      "styleRecalcs": 136,
      "styleRecalcDurationMs": 14.197000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16529.485999999997,
      "heapDeltaBytes": -33736008,
      "heapUsedBytes": 164931348,
      "domNodes": -6542,
      "jsHeapTotalBytes": -2322432,
      "scriptDurationMs": 715.413,
      "eventListeners": -7474,
      "totalBlockingTimeMs": 69,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4025.6499999999846,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 61.50600000000001,
      "layouts": 20,
      "layoutDurationMs": 21.118,
      "taskDurationMs": 3912.5410000000006,
      "heapDeltaBytes": -18177088,
      "heapUsedBytes": 175514192,
      "domNodes": -6542,
      "jsHeapTotalBytes": 22736896,
      "scriptDurationMs": 75.409,
      "eventListeners": -7478,
      "totalBlockingTimeMs": 58,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5103.984000000082,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 59.798999999999964,
      "layouts": 20,
      "layoutDurationMs": 20.953,
      "taskDurationMs": 5010.097,
      "heapDeltaBytes": -11438920,
      "heapUsedBytes": 192248980,
      "domNodes": -6543,
      "jsHeapTotalBytes": 17358848,
      "scriptDurationMs": 87.587,
      "eventListeners": -7480,
      "totalBlockingTimeMs": 174,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7172.118000000011,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6803.229000000002,
      "heapDeltaBytes": 19492892,
      "heapUsedBytes": 175777096,
      "domNodes": 0,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 99.05999999999999,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7169.902000000093,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6795.278000000001,
      "heapDeltaBytes": 23161216,
      "heapUsedBytes": 188160748,
      "domNodes": 0,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 101.72900000000001,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 424.8890000000074,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 15.787000000000003,
      "layouts": 3,
      "layoutDurationMs": 0.755,
      "taskDurationMs": 89.619,
      "heapDeltaBytes": 4910536,
      "heapUsedBytes": 66432228,
      "domNodes": 124,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 9.754,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666665,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 442.36899999998514,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 17.159,
      "layouts": 2,
      "layoutDurationMs": 0.451,
      "taskDurationMs": 87.841,
      "heapDeltaBytes": 4862736,
      "heapUsedBytes": 66375916,
      "domNodes": 124,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 7.511,
      "eventListeners": 83,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 50140 74814 67.0% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1159
src/LGraphNode.ts 69.7% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.0% 309
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 79.1% 264
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/scripts/app.ts 71.8% 251
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 12, 2026
@codecov

codecov Bot commented Sep 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                            Coverage Diff                            @@
##           fix/agent-subgraph-instance-reconcile   #17499      +/-   ##
=========================================================================
- Coverage                                  83.25%   83.24%   -0.02%     
=========================================================================
  Files                                       2064     2063       -1     
  Lines                                     120479   120478       -1     
  Branches                                   31244    31246       +2     
=========================================================================
- Hits                                      100305   100292      -13     
- Misses                                     19994    20006      +12     
  Partials                                     180      180              
Flag Coverage Δ
e2e 67.05% <ø> (+0.01%) ⬆️
unit 78.00% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/core/graph/graphMutations.ts 92.36% <100.00%> (+0.08%) ⬆️

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Untitled catalog add/reconcile now writes type onto lastSerialization so
configure() cannot replace it with display_name. Subgraph instances still
keep the incumbent title.
@cursor cursor Bot changed the title fix(graph): keep catalog type title on untitled reconcile fix(graph): scope untitled reconcile title keep to subgraphs Sep 12, 2026
Untitled reconcile writes the resolved title onto lastSerialization so
rematerialize configure() cannot restore display_name. addNode is left
untitled so agent-added nodes still pick up the class display name.
Catch-up reconcile of a seed catalog node has no incumbent, so configure()
was still falling back to display_name. Write type onto lastSerialization
for untitled catalog reconcile even without an incumbent. Subgraph
instances still keep the incumbent title only.
claude Bot pushed a commit that referenced this pull request Sep 19, 2026
Records the Option B design for PM-1296/PM-1297 (agent reconcile resets a
manually-renamed node title): a dedicated nodeTitleCustomizationStore keyed
by root graph + node id, set only from the four genuine user-rename UI call
sites, cleared through the existing clearNodeOwnedStoreState node-removal
hook, and consulted in graphMutations.ts's prepareNode() ahead of the
existing nodeTitle() fallback. Composes with, and does not depend on the
merge order of, the draft #17499 subgraph-only untitled-reconcile fallback.

No product code changes; implementation follows in a separate PR.
@christian-byrne

Copy link
Copy Markdown
Contributor

Thanks for this @huang47 — closing it, but not because the reasoning was wrong.

Your read was right: the parent was preserving a configured display title for every incumbent, not only subgraph instances, and scoping it was the correct correction. It turns out main had already solved the underlying problem a different way — #17202 routes a live subgraph host to reconcileNodeFields so its slots and promoted widgets are never rebuilt from the payload, and #17963 makes nodeTitle() fall back to the registered class title. So there is no longer an untitled-reconcile title decision for either PR to scope.

Parent #16964 is closed for the same reason; details are here. The regression coverage is going to main on its own in #18164.

@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support labels Sep 24, 2026
zeus-onl pushed a commit to zeus-onl/ComfyUI_frontend that referenced this pull request Sep 25, 2026
…tate (Comfy-Org#18075)

<!-- ccr-slack-attribution -->
_Requested by **Memie Osuga, Christian Byrne** · [Slack
thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789514768597649?thread_ts=1789514768.597649&cid=C0BGH348Z0C)_

## Before / After

**Before:** two reported bugs (node color loss after reconcile, title
stomp after reconcile) share one root cause with zero regression
coverage: whenever the agent CRDT follower does a full reconcile
(`EcsFollowerAdapter`'s `reconcileNextFrame`, confirmed triggered by
returning to a workflow tab), `graphMutations.ts` always trusts the CRDT
doc's own snapshot over live/local state, with no "was this edited more
recently locally" check anywhere in the reconcile path. A third reported
bug — a widget value overwritten mid-edit, plus related linked reports —
is a separate, direct `set_widget` collision:
`applyWidgetValues`/`setWidgetValue` write straight into
`widgetValueStore` with no focus/in-progress-edit guard, and it never
goes through the reconcile/follower-rebind path at all. All three bugs
happen silently — nothing fails, nothing is asserted, so they ship and
regress again freely.

**After:** node color loss on a same-type reconcile is fixed, robustly.
Title stomp is fixed within a session (a follower rebind, or a node
re-materializing after a doc-only remote edit) but not across a full
workflow-tab reload — that's a second, deeper gap, confirmed and left as
a known repro alongside the pre-existing widget-overwrite-mid-edit one.
See "Fix status" below for exactly what's fixed and why the remaining
two are out of scope here.

### What's covered

- **`browser_tests/tests/agent/agentCrdtReconcileOverwrite.spec.ts`**
(Playwright e2e, using the existing `agentConversationFixture` and the
tab-switch rebind lever already proven in
`agentTabSwitchCatchUp.spec.ts`):
- Node color loss (reconcile): user colors a node from the properties
panel, an unrelated agent reconcile runs, the color survives. **Fixed.**
- Title stomp (reconcile via a workflow-tab reload): user renames a node
from the properties panel, an unrelated agent reconcile runs (returning
to the tab, which reloads it). **Known, intentionally unfixed repro**
(`test.fail()`) — the reload itself is the problem; see "Fix status".
- Widget overwrite mid-edit: a local-edit-vs-remote-write collision (an
agent `set_widget` lands on a `CLIPTextEncode` `text` widget while the
user is actively typing into it, via `setWidgetValue`), not a
reconcile-path symptom — see "Fix status". **Known, intentionally
unfixed repro** (`test.fail()`).
  - Each test attaches before/after screenshots as visual proof.
- The tab-return helper (`reconcileByReturningToTab`) captures the
follower's `subscribeCount()` before switching tabs and polls for it to
rise by one — proof the mock host's request/response round-trip happened
— then captures and polls a browser-side `appliedFrameCount()`
(`status.outcomes.applied` from `useAgentCrdtFollower`'s CRDT debug
instrument) to rise by one before asserting canvas state.
`subscribeCount()` alone only proves the mock host sent the catch-up
frame at send time; `appliedFrameCount()` only rises once the browser
has actually merged that frame into the stores and finished reconciling
the live graph for it, so the assertions genuinely wait for the
reconcile to complete, not just for the tab click to land or the frame
to be sent.
- **`src/workbench/extensions/agent/crdt/graphMutations.test.ts`**
(Vitest): unit-level regression coverage for the title and color fixes
directly against `reconcileNode`/`prepareNode`, isolating the fix from
any DOM/CRDT-transport involved, including a type-changing reconcile
that must not carry a stale local title onto the new-type replacement.
One `it.fails` here covers an unrelated, pre-existing store-only
serialization mismatch (`keeps a store-only node in LGraph.serialize()
without reporting a mismatch`).
-
**`src/workbench/extensions/agent/crdt/agentNodeMaterializer.test.ts`**
(Vitest): regression coverage for the title fix's in-session
materialization case — including a composition test that renames the
live node, reconciles an unchanged payload, then a changed one, and
checks local-then-remote title authority end to end — plus an `it.fails`
case proving the workflow-tab-reload title gap at the unit level (no
Playwright needed to reproduce it).
- The widget-overwrite-mid-edit gap has no Vitest coverage; it is
reproduced only at the Playwright level (`test.fail()` in
`agentCrdtReconcileOverwrite.spec.ts`), since it's a
DOM-focus/in-progress-edit collision rather than something the
store-level unit tests can observe.

### Root cause (confirmed, shared by color and title; the widget case is
distinct — see below)

`graphMutations.ts`'s `reconcileNode`/`reconcileNodeFields`, feeding
`nodeDataStore.ts`'s `updateNode`/`updateNodeFields`
(`assignNodeFields`), always fully replaces scalar node fields from the
CRDT payload:
- Node color/bgcolor are presentation-only and never stored in the CRDT
doc, so a naive reconcile would blank a locally set color on a same-type
replacement.
- `nodePayload.ts`'s `nodeTitle()` had no "keep the incumbent title"
fallback, so a canvas rename (which only ever touches the live node, per
`useNodeEventHandlers.ts`'s `handleNodeTitleUpdate`) was stomped back to
the doc's stale title on the next reconcile.

The widget-overwrite case is a separate mechanism, not a third symptom
of the above: `applyWidgetValues`/`setWidgetValue` write straight into
`widgetValueStore` with no focus/in-progress-edit guard, so an agent
`set_widget` on a widget the user is actively typing into silently
overwrites it — this doesn't go through the tab-return reconcile helper
at all, it's a local-vs-remote edit collision on a single widget write.

### Fix status: color fixed (same-type reconciliation); title fixed
within a session only; two known repros left out of scope

**Fixed: node color/bgcolor loss on same-type reconciliation.**
`assignNodeFields` (`src/stores/nodeDataStore.ts`) unconditionally
resets `color`/`bgcolor` to `undefined` before applying a reconciled
replacement's own fields — that store-level reset is unchanged and stays
generic. Preservation instead lives entirely at the CRDT boundary:
`prepareNode` (`graphMutations.ts`) calls `resolveNodeColors(payload,
incumbent)`, which copies the same-type incumbent's live
`color`/`bgcolor` onto the prepared replacement object whenever the doc
payload doesn't carry its own value (the CRDT doc never carries node
color at all). That replacement, already carrying the live color, is
what reaches `assignNodeFields`, so the store's unconditional reset is
immediately overwritten by the replacement's own (copied-forward) value
in the same object-literal spread. A type-changing replacement is a
different case and intentionally keeps resetting color/bgcolor to the
new incarnation's own values (see the existing "replaces a
field-reconciled node when its type changes" test) — that's correct,
documented behavior, not something this PR changes.

**Fixed within a session: title stomp.** A canvas rename only ever
mutates the live node (`useNodeEventHandlers.ts`'s
`handleNodeTitleUpdate`); it never writes back into the CRDT doc.
`prepareNode` (`graphMutations.ts`) resolves a node's title by comparing
the incoming payload's title against the title recorded on the node's
`lastSerialization` baseline (the doc snapshot as of the last
reconcile), scoped to the same type boundary `prepareNode` already uses
for colors and slots (`incumbent`, i.e. `existing?.type ===
payload.type`): an unchanged doc title on a same-type incumbent means
nothing about the doc's title actually changed, so the live title (which
may reflect an unsynced local rename) is kept; a title that differs from
that baseline, or a type change, is treated as a genuine doc-side change
and the payload's title still wins. `agentNodeMaterializer.ts`'s
`materialize()` also carries that baseline onto a newly materialized
node instead of discarding it — otherwise the very first reconcile after
a node re-materializes (a normal, frequent event for agent-created
nodes) would always see no baseline and blindly trust the doc.

**Which doc-silent cases the baseline actually covers.** The underlying
reason a client-side baseline is needed at all: `comfy-multi-player`'s
`FROZEN_OPS` has no `set_title`/`update_node` op, so a rename performed
after `add_node` produces no CRDT op, and the doc's title is simply
silent on it. Concretely, against the three cases where the doc stays
silent: an **empty/undefined doc title** is covered the same way any
other title is — `resolveNodeTitle`'s `payload.title ===
existing.lastSerialization?.title` check does no special-casing for
empty values, so it preserves a live rename whenever the doc's title is
consistently empty/undefined across reconciles (the same code path as
the covered non-empty case, though no dedicated test here exercises an
empty baseline specifically). A **subgraph node instance**'s own renamed
title is not covered by a dedicated test: `prepareNode` runs on subgraph
instances the same as any other node (the incumbent's `type` is just the
subgraph's UUID), so the mechanism should extend to them, but the only
subgraph-title regression test in this PR
(`agentNodeMaterializer.test.ts`'s promoted-`set_widget` test) pins the
registered-class-name fallback from `nodeTitle()`, not a local rename of
the instance surviving a reconcile. A **serialization round-trip**
(workflow-tab reload) is not covered at all — see the confirmed gap
directly below: `LGraph.clear()`'s `teardownOwnedGraphs` empties the
node's `lastSerialization` baseline before any store-level preservation
could run, so there's no baseline left to compare against.

**Not fixed (confirmed, needs dedicated cross-layer work): title stomp
survives a workflow-tab reload.** Returning to a workflow tab reloads it
via `LGraph.configure()`, and `LGraph.clear()` tears each node down
individually (`teardownOwnedGraphs`) *before* it resets the
`nodeDataStore` bucket — so a node's `lastSerialization` baseline is
already gone by the time any store-level hook could try to preserve it,
regardless of the fix above. A live rename does survive the reload
itself (the tab's own saved JSON already carries it), but the next
reconcile has no baseline to compare the doc's title against and replays
it over the rename regardless. Tried and rejected: a broader "no
baseline means trust the live node" change in `graphMutations.ts`
(regressed several other reconcile scenarios — host resync, node-retype
rebuild — that legitimately rely on trusting the doc the first time a
node reconciles); a `nodeDataStore.ts`-level baseline-preserving cache
keyed off `clearGraph`/`registerNode` (dead code in practice, since
`teardownOwnedGraphs` empties the bucket first). A real fix needs the
reconcile baseline to survive `LGraph.clear()`'s per-node teardown
itself — the same kind of dedicated plumbing as the widget-overwrite
case below, not a change local to one module. Left as
`test.fail()`/`it.fails`.

Review also flagged that `lastSerialization` is currently overloaded —
it serves both the missing-node serialization fallback and this CRDT
title-freshness baseline, with different lifetimes. That's a legitimate
point; giving the reconcile baseline its own narrowly-scoped, CRDT-owned
field/lifecycle is a bigger design change than fits this PR's blast
radius and is tracked as a follow-up rather than done here.

**Not fixed (by design, out of scope for this PR): widget value
overwritten mid-edit.** `applyWidgetValues`/`setWidgetValue`
(`graphMutations.ts`) write straight into `widgetValueStore` with no
focus/in-progress-edit check, and `widgetValueStore` has no concept of
DOM focus at all (it's pure state, by design). A real fix needs new
cross-layer plumbing so some system knows which widget is currently
focused before `applyWidgetValues`/`setWidgetValue` write to it — a
verified requirement (a conflict policy for remote writes landing during
a local edit), not yet an accepted design. Left unchanged as
`test.fail()` (Playwright only; there is no Vitest coverage of this
gap).

### Existing PRs checked

`Comfy-Org#16964` and `Comfy-Org#17499` (both still open/draft) touch nearby code in
`graphMutations.ts`/`nodePayload.ts`, but are scoped to a different bug
(subgraph-instance title loss after a promoted `set_widget`) and do not
address the regular-node title/color/widget defects here.
`Comfy-Org#16309`/`Comfy-Org#16302`/`Comfy-Org#16288` (optimistic-overlay pending-op shadow) are a
presentation-only overlay for the agent's *own* in-flight ops, not a
guard for *user*-initiated local edits, so they don't fix this either.

**`Comfy-Org#18065`** (closed, unmerged) shared this PR's merge base and touched
the same two files (`graphMutations.ts`, `agentNodeMaterializer.ts`)
plus added a new `src/stores/nodeTitleCustomizationStore.ts` and
`docs/adr/CRDT-TITLE-0035-session-local-node-title-customization-flag.md`.
It proposed a different, more explicit solution to the same title-stomp
problem this PR's "Fixed within a session" section covers: instead of
comparing the incoming title against a `lastSerialization` baseline, it
had `useNodeEventHandlers.ts` explicitly mark a node as human-customized
on rename, and `prepareNode`/`resolveNodeTitle` in `graphMutations.ts`
check that explicit flag (scoped to the same `existing.type ===
payload.type` boundary this PR's fix also uses) instead of inferring
"did the doc change" from a stale snapshot. `Comfy-Org#18065` was closed unmerged
in favor of this PR: this PR (`Comfy-Org#18075`) is the selected implementation
going forward, and `Comfy-Org#18065`'s explicit-intent model is retained as
relevant design history for the follow-up work called out above (giving
the reconcile baseline its own CRDT-owned field/lifecycle, and
eventually the workflow-tab-reload gap) rather than as an open decision.

### Verification

- `pnpm exec vitest run src/workbench/extensions/agent` → 1653 passed, 2
expected-fail: the workflow-tab-reload title gap
(`agentNodeMaterializer.test.ts`) and the unrelated store-only
serialization mismatch (`graphMutations.test.ts`). The widget-overwrite
gap has no Vitest coverage — it's a Playwright-only repro
(`test.fail()`).
- `pnpm exec oxfmt --check`, `pnpm exec eslint` clean on all touched
files.
- `pnpm typecheck` (vue-tsc across all sub-projects) clean.
- CI: `playwright-tests (cloud)`, `playwright-video-new-tests`, the
`e2e-status` gate, and `test` (Vitest) all green on this branch's head,
exercising the color fix and the two remaining repros as
`test.fail()`/`it.fails` (expected failures, not blocking).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01L4WMaCPdk7KSva7vwKfz19

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: GitHub Action <action@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants