Repository navigation
test(agent): repro a canvas rename lost on CRDT reconcile - #18102
claude[bot] wants to merge 1 commit into
Conversation
A canvas title rename (handleNodeTitleUpdate) only writes the local node store and never reaches the agent's CRDT doc. The reconcile path (prepareNode -> nodeTitle) always derives a node's title from the doc payload and never falls back to the incumbent's live title, so the next agent-driven graph update (here, the tab-switch catch-up reconcile) reverts the user's rename. Adds a Vitest repro directly against nodeTitle()/prepareNode via reconcileNode, and a Playwright e2e repro that renames a KSampler on canvas and shows the title reverting after a forced reconcile.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2039 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.92 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 637 kB (baseline 637 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.86 MB (baseline 3.86 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 565 kB (baseline 565 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • ⚪ 0 BBundles that do not match a named category Status: 297 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-19T04:13:45.607Z",
"gitSha": "21f21c3cf7868f8ef637da9412a62793c2f48a0d",
"branch": "test/pm-1296-agent-canvas-rename-reconcile",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1996.5579999999932,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.538,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.636,
"heapDeltaBytes": 11362636,
"heapUsedBytes": 72735444,
"domNodes": -260,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.203999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2003.2770000000255,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.608999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.98199999999997,
"heapDeltaBytes": 3183256,
"heapUsedBytes": 65145820,
"domNodes": -262,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.838000000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1931.6919999999982,
"styleRecalcs": 78,
"styleRecalcDurationMs": 33.324999999999996,
"layouts": 14,
"layoutDurationMs": 5.2250000000000005,
"taskDurationMs": 878.787,
"heapDeltaBytes": -6129348,
"heapUsedBytes": 55683428,
"domNodes": -263,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 189.476,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1859.7480000000814,
"styleRecalcs": 76,
"styleRecalcDurationMs": 30.227999999999998,
"layouts": 14,
"layoutDurationMs": 4.64,
"taskDurationMs": 844.942,
"heapDeltaBytes": 12119752,
"heapUsedBytes": 74083944,
"domNodes": -263,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 165.699,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.1259999999793,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.041,
"layouts": 6,
"layoutDurationMs": 1.1080000000000003,
"taskDurationMs": 334.16599999999994,
"heapDeltaBytes": 2137636,
"heapUsedBytes": 64162956,
"domNodes": 77,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.464,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.7750000000033,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.608999999999998,
"layouts": 6,
"layoutDurationMs": 1.42,
"taskDurationMs": 346.04600000000005,
"heapDeltaBytes": 2101596,
"heapUsedBytes": 64115752,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.761,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 642.4579999999764,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.334000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.817,
"heapDeltaBytes": 17924856,
"heapUsedBytes": 79826368,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 164.36700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 651.8680000000359,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.410999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.59700000000004,
"heapDeltaBytes": 18195656,
"heapUsedBytes": 80206264,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 169.687,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2034.9429999999984,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.389000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 621.6679999999999,
"heapDeltaBytes": 3904880,
"heapUsedBytes": 82804848,
"domNodes": -248,
"jsHeapTotalBytes": -532480,
"scriptDurationMs": 38.91700000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2019.5059999999785,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.155,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.211,
"heapDeltaBytes": 2274012,
"heapUsedBytes": 82436320,
"domNodes": -247,
"jsHeapTotalBytes": -1581056,
"scriptDurationMs": 38.444,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2378.1419999999684,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.502000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1733.5620000000001,
"heapDeltaBytes": -665084,
"heapUsedBytes": 79412048,
"domNodes": -249,
"jsHeapTotalBytes": 1003520,
"scriptDurationMs": 875.927,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2352.82600000005,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.383999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1545.623,
"heapDeltaBytes": 15866436,
"heapUsedBytes": 80230812,
"domNodes": 2,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 942.02,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3521.526999999992,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.638999999999996,
"layouts": 60,
"layoutDurationMs": 12.931000000000001,
"taskDurationMs": 1569.6500000000003,
"heapDeltaBytes": 10144360,
"heapUsedBytes": 75015152,
"domNodes": 2,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 808.443,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3569.9690000000146,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.144999999999998,
"layouts": 60,
"layoutDurationMs": 13.762,
"taskDurationMs": 1731.3279999999997,
"heapDeltaBytes": 8424764,
"heapUsedBytes": 74312820,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 801.3209999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3164.701999999977,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.202999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1998.1399999999999,
"heapDeltaBytes": 25058244,
"heapUsedBytes": 90766688,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1010.5630000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3081.780999999978,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.332,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1882.268,
"heapDeltaBytes": 14152008,
"heapUsedBytes": 80085712,
"domNodes": 2,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 955.0730000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2054.0960000000155,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.123,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.9560000000001,
"heapDeltaBytes": -6613456,
"heapUsedBytes": 80475956,
"domNodes": -253,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 31.324000000000005,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2004.7179999999116,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.766000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.6099999999999,
"heapDeltaBytes": 20106688,
"heapUsedBytes": 83936356,
"domNodes": -255,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.722,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 558.1430000000296,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.789,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.54300000000006,
"heapDeltaBytes": 13107804,
"heapUsedBytes": 76323160,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.54899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 586.8920000000344,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.354,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.264,
"heapDeltaBytes": 13743892,
"heapUsedBytes": 77005252,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 144.33599999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2017.3709999999687,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.3480000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.05000000000007,
"heapDeltaBytes": 8520400,
"heapUsedBytes": 71887940,
"domNodes": -277,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 7.174999999999997,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2003.1979999999976,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.717,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.634,
"heapDeltaBytes": 17925864,
"heapUsedBytes": 81126020,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.461,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.9350000000345,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.264,
"layouts": 18,
"layoutDurationMs": 4.962999999999999,
"taskDurationMs": 716.633,
"heapDeltaBytes": 11617220,
"heapUsedBytes": 74847156,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 113.544,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.3519999999908,
"styleRecalcs": 78,
"styleRecalcDurationMs": 25.898000000000003,
"layouts": 18,
"layoutDurationMs": 5.166,
"taskDurationMs": 758.376,
"heapDeltaBytes": 12837120,
"heapUsedBytes": 76104848,
"domNodes": -277,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 106.117,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.6600000000008,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.077000000000005,
"layouts": 5,
"layoutDurationMs": 12.946,
"taskDurationMs": 875.2939999999998,
"heapDeltaBytes": -6445488,
"heapUsedBytes": 81199188,
"domNodes": 13587,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 29.04799999999999,
"eventListeners": 2383,
"totalBlockingTimeMs": 136,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8381.023999999969,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.504999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5856.674,
"heapDeltaBytes": -3677624,
"heapUsedBytes": 75924792,
"domNodes": -245,
"jsHeapTotalBytes": -339968,
"scriptDurationMs": 2821.9339999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8318.573000000015,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.763999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5748.206,
"heapDeltaBytes": -3683836,
"heapUsedBytes": 75633196,
"domNodes": -245,
"jsHeapTotalBytes": 708608,
"scriptDurationMs": 2820.638,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16627.650000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15930.082000000002,
"heapDeltaBytes": -26786444,
"heapUsedBytes": 182976272,
"domNodes": -8061,
"jsHeapTotalBytes": -11866112,
"scriptDurationMs": 252.31300000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16876.548999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16358.245000000004,
"heapDeltaBytes": -32684896,
"heapUsedBytes": 196807548,
"domNodes": -8061,
"jsHeapTotalBytes": -8400896,
"scriptDurationMs": 258.744,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20862.767000000018,
"styleRecalcs": 164,
"styleRecalcDurationMs": 17.893999999999966,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20509.721,
"heapDeltaBytes": -44366908,
"heapUsedBytes": 167514964,
"domNodes": -8061,
"jsHeapTotalBytes": -13828096,
"scriptDurationMs": 905.783,
"eventListeners": -14928,
"totalBlockingTimeMs": 28,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20822.666000000027,
"styleRecalcs": 162,
"styleRecalcDurationMs": 17.618999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20457.448,
"heapDeltaBytes": -32693812,
"heapUsedBytes": 190165208,
"domNodes": -8061,
"jsHeapTotalBytes": -17309696,
"scriptDurationMs": 894.648,
"eventListeners": -14928,
"totalBlockingTimeMs": 32,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6131.883000000016,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.14200000000002,
"layouts": 20,
"layoutDurationMs": 23.403000000000006,
"taskDurationMs": 6036.173,
"heapDeltaBytes": -42999608,
"heapUsedBytes": 180441688,
"domNodes": -8061,
"jsHeapTotalBytes": 11595776,
"scriptDurationMs": 108.13499999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 482,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6253.942999999936,
"styleRecalcs": 20,
"styleRecalcDurationMs": 89.44800000000002,
"layouts": 20,
"layoutDurationMs": 24.751999999999995,
"taskDurationMs": 6177.1669999999995,
"heapDeltaBytes": -36203916,
"heapUsedBytes": 193936168,
"domNodes": -8061,
"jsHeapTotalBytes": 16183296,
"scriptDurationMs": 119.783,
"eventListeners": -14928,
"totalBlockingTimeMs": 434,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8646.931999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8337.730999999998,
"heapDeltaBytes": 2275428,
"heapUsedBytes": 197067176,
"domNodes": 0,
"jsHeapTotalBytes": -29622272,
"scriptDurationMs": 125.77100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8681.326000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8414.795,
"heapDeltaBytes": 1178572,
"heapUsedBytes": 190310344,
"domNodes": 0,
"jsHeapTotalBytes": -19660800,
"scriptDurationMs": 141.52800000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 467.4709999999891,
"styleRecalcs": 21,
"styleRecalcDurationMs": 24.960000000000004,
"layouts": 3,
"layoutDurationMs": 1.54,
"taskDurationMs": 126.50500000000004,
"heapDeltaBytes": 5128620,
"heapUsedBytes": 66668568,
"domNodes": 147,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.306999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 128.61099999997805,
"styleRecalcs": 10,
"styleRecalcDurationMs": 19.529,
"layouts": 3,
"layoutDurationMs": 1.5949999999999998,
"taskDurationMs": 91.18699999999998,
"heapDeltaBytes": 3004980,
"heapUsedBytes": 64562964,
"domNodes": 130,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.905999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18102 +/- ##
==========================================
+ Coverage 82.77% 83.80% +1.03%
==========================================
Files 2936 2242 -694
Lines 144482 127635 -16847
Branches 39021 32469 -6552
==========================================
- Hits 119593 106967 -12626
+ Misses 23632 20378 -3254
+ Partials 1257 290 -967
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
I re-confirmed the RCA against current This exact ambiguity was already hit once in this seam: the two draft PRs mentioned in the description (#16964, #17499) solve a narrower version of it (a subgraph instance's title degrading to its definition UUID after a promoted-widget write) with two techniques worth reusing rather than reinventing:
One more wrinkle: both of those PRs are written against Separately, and I think this is the more load-bearing finding: gap 1 (the rename never reaching the doc) isn't just a missed call site in Given that, I'd rather not push a fix from here. Two real options, and I'd like the team's steer on which to pursue (or both, staged):
Whichever direction, it should land coordinated with #16964/#17499 rather than as a third, independent patch to the same 🤖 Generated with Claude Code |
Merge conflict with
|
|
Closing as superseded, with the superseding test named. This PR's user-visible oracle — a canvas rename lost when the tab is switched away and back — is already on Its other two files cannot be merged at all: That is the distinction this program applies to the refactor's test debt: keep the assertion about user-visible behaviour, discard the fixture that encodes the old internals. The assertion was kept, upstream, by #18187. Reopen if the rename case on |
Summary
The in-app agent silently reverts a user's canvas node rename on the next
graph update. Two compounding gaps:
useNodeEventHandlers.tshandleNodeTitleUpdate)writes only to the local node store. It never reaches the shared CRDT doc
the agent reads from and writes to.
graphMutations.tsprepareNode->nodePayload.tsnodeTitle()) always derives a node's title from theincoming doc payload, with no fallback to the live/incumbent node's
title.
So the doc keeps the node's pre-rename title forever (gap 1), and every
reconcile overwrites the live title from that stale doc value (gap 2).
This PR adds failing repro tests only — no fix.
Repro tests
src/workbench/extensions/agent/crdt/nodePayload.test.ts(new):it.failsprovingnodeTitle()has no incumbent-title parameter to fallback on.
src/workbench/extensions/agent/crdt/graphMutations.test.ts:it.failsproving
reconcileNodedrops a live-renamed title when the doc payloadcarries none, same shape as the existing
it.failsregression above it inthe file.
browser_tests/tests/agent/agentTabSwitchCatchUp.spec.ts: a newtest.fail()end-to-end case appended alongside the existing tab-switchcatch-up tests in this file (same fixture, same forced-reconcile
mechanism already proven elsewhere in the file for the drop of an
unrelated node's other field). It renames a KSampler node on canvas after
the agent's own turn, forces a follower re-subscribe via a tab switch, and
asserts the rename should survive. It currently fails: the reconciled
title reverts to
KSampler(the class display name), and a screenshot ofthe reverted title is attached as evidence via
testInfo.attach.Related PRs checked first
Two open PRs touch this exact reconcile code path but do not fix this bug:
incumbent-title-keep fallback to
graphMutations.ts, but scoped tosubgraph-instance nodes only (a different bug: a promoted-widget write
degrading a subgraph instance's title to its definition UUID).
fallback specifically to UUID subgraph instances, on top of PM-827: fix(agent): keep subgraph instance title, slots and promoted widgets across a remote reconcile #16964.
Neither is merged, and neither generalizes the fallback to a plain node's
user-set title. No other open PR addresses this. Any future fix needs to
extend the incumbent-title fallback in
prepareNodebeyond subgraphinstances without breaking the agent's own legitimate, doc-driven title
changes (renaming a node itself, or naming a newly added node) — those
continue to work correctly today (see the unaffected
agentConversationReplayand
agentTabSwitchCatchUpcases, none of which touch this path).Verification
pnpm lint,pnpm typecheck, andpnpm typecheck:browserall pass clean.The Playwright case was not run against a live backend/browser in this
environment (no ComfyUI backend or installed browser binaries here); it
follows the same fixture, node id, and forced-reconcile mechanism as the
neighboring case in the same file, and is discovered correctly by
Playwright's test lister.
Generated by Claude Code