Repository navigation
test(group-node): assert widget pairing, not set membership - #17464
Conversation
The test I added in #17393 could not fail on the bug it was written for. It flattened every interior widget value into one array and asserted arrayContaining + length 14. Misalignment shuffles values BETWEEN widgets, so the multiset is identical and the length is unchanged — the assertion passes on corrupted data. That is a test that fossilizes the defect. QA hit the real behaviour on 2026-09-10 running the 1.54 plan: converting a v1.3.3 group node shifts widget values two positions, so denoise receives 'euler' and filename_prefix receives 'normal'. On a group node wrapping two samplers, six values land wrong on one node, including strings in numeric fields (noise_seed = 'enable') and a number in a combo (control_after_generate = 0). Deterministic over 16 loads, reproduces through the Workflows sidebar, and saving writes the wrong values back to disk. Now reads each interior node's widgets as a name -> value map and asserts the pairing the asset actually declares: KSampler seed/steps/cfg/sampler_name/ scheduler/denoise, SaveImage filename_prefix. toBeDefined() runs first so a missing node cannot make toMatchObject vacuous. Pinned with test.fail(), matching subgraphPromotion.spec.ts and subgraphConvertAutogrowInputs.spec.ts. CI stays green while the bug exists, and flips red the moment the conversion is fixed, which is the signal to drop the marker.
|
Warning Review limit reached
On-demand reviews are free for the next 28 days. After that, they cost $0.25 per reviewed file. Or wait 7 minutes for your next included review. View limit detailsLimit details: You’ve used all 8 included reviews currently available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Comment |
🎭 Playwright: ✅ 1967 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.94 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 622 kB (baseline 622 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 26.2 kB (baseline 26.2 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 118 kB (baseline 118 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.71 MB (baseline 3.71 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 37 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.2 MB (baseline 17.2 MB) • ⚪ 0 BBundles that do not match a named category Status: 296 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-11T21:09:01.473Z",
"gitSha": "f903459ea0dcc65e0b47325d80f02110c5485464",
"branch": "test/group-node-widget-value-alignment",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2005.0410000000056,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.217999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.7250000000001,
"heapDeltaBytes": 7701284,
"heapUsedBytes": 69602780,
"domNodes": -264,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 9.819999999999999,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2025.4510000000323,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.120000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 379.054,
"heapDeltaBytes": -7199092,
"heapUsedBytes": 54362780,
"domNodes": -265,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 10.236999999999997,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2009.3180000000075,
"styleRecalcs": 80,
"styleRecalcDurationMs": 34.217000000000006,
"layouts": 14,
"layoutDurationMs": 5.316,
"taskDurationMs": 1000.9879999999999,
"heapDeltaBytes": 16074648,
"heapUsedBytes": 76793004,
"domNodes": -263,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 190.45000000000002,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1823.99300000003,
"styleRecalcs": 75,
"styleRecalcDurationMs": 28.499999999999996,
"layouts": 14,
"layoutDurationMs": 4.121,
"taskDurationMs": 855.2360000000001,
"heapDeltaBytes": 9990436,
"heapUsedBytes": 72061032,
"domNodes": -264,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 167.096,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.1499999999892,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.623999999999999,
"layouts": 6,
"layoutDurationMs": 1.145,
"taskDurationMs": 348.847,
"heapDeltaBytes": 2061708,
"heapUsedBytes": 63673248,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.323999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1718.0470000000696,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.046999999999997,
"layouts": 6,
"layoutDurationMs": 1.0759999999999998,
"taskDurationMs": 349.73299999999995,
"heapDeltaBytes": 2154660,
"heapUsedBytes": 64334616,
"domNodes": 74,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.629000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 661.1389999999915,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.312,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.93300000000005,
"heapDeltaBytes": 18225904,
"heapUsedBytes": 80366804,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 171.99200000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 608.6839999999825,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.221,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.11299999999994,
"heapDeltaBytes": 18183256,
"heapUsedBytes": 80178500,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 167.053,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2017.4020000000041,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.381999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 569.677,
"heapDeltaBytes": 3231332,
"heapUsedBytes": 82779716,
"domNodes": -253,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 32.685,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2048.0830000000196,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.628000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.2989999999999,
"heapDeltaBytes": 2621280,
"heapUsedBytes": 81756076,
"domNodes": -248,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 32.78500000000001,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2263.749999999959,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.526999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1644.7509999999997,
"heapDeltaBytes": -1338512,
"heapUsedBytes": 79193284,
"domNodes": -254,
"jsHeapTotalBytes": 217088,
"scriptDurationMs": 856.889,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2334.9530000000414,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.610000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1670.6850000000002,
"heapDeltaBytes": 14879992,
"heapUsedBytes": 78961984,
"domNodes": -250,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 874.244,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3579.2339999999854,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.673000000000002,
"layouts": 60,
"layoutDurationMs": 11.799999999999997,
"taskDurationMs": 1709.791,
"heapDeltaBytes": 9788564,
"heapUsedBytes": 74147156,
"domNodes": -263,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 795.652,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3555.27799999993,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.371000000000002,
"layouts": 60,
"layoutDurationMs": 11.706,
"taskDurationMs": 1694.2939999999996,
"heapDeltaBytes": 7683436,
"heapUsedBytes": 74143156,
"domNodes": -256,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 793.242,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3187.545,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.746000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2021.798,
"heapDeltaBytes": -5472456,
"heapUsedBytes": 84737644,
"domNodes": -231,
"jsHeapTotalBytes": 708608,
"scriptDurationMs": 1016.5470000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3114.9299999999585,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.946000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1983.5829999999999,
"heapDeltaBytes": -10195332,
"heapUsedBytes": 80097720,
"domNodes": -229,
"jsHeapTotalBytes": 2019328,
"scriptDurationMs": 1022.065,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2057.666999999981,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.016999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 667.765,
"heapDeltaBytes": -7770876,
"heapUsedBytes": 79207372,
"domNodes": -259,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 41.771,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 1993.9490000000433,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.703999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.5009999999999,
"heapDeltaBytes": 20286820,
"heapUsedBytes": 84479860,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 38.294999999999995,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 587.0429999999942,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.347,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.98900000000003,
"heapDeltaBytes": 13309316,
"heapUsedBytes": 76652128,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 144.234,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.6949999999961,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.586,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.678,
"heapDeltaBytes": 13561316,
"heapUsedBytes": 76910012,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.933,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2007.3370000000068,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.539000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.10699999999997,
"heapDeltaBytes": 8518264,
"heapUsedBytes": 71807528,
"domNodes": -276,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 8.104,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1995.424000000071,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.478000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.16400000000004,
"heapDeltaBytes": 14249592,
"heapUsedBytes": 77589524,
"domNodes": -276,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.123999999999999,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.075000000008,
"styleRecalcs": 78,
"styleRecalcDurationMs": 26.168000000000003,
"layouts": 18,
"layoutDurationMs": 5.0889999999999995,
"taskDurationMs": 794.332,
"heapDeltaBytes": 4952572,
"heapUsedBytes": 68177580,
"domNodes": -277,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 113.636,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.6870000000217,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.384,
"layouts": 18,
"layoutDurationMs": 4.862,
"taskDurationMs": 794.6229999999999,
"heapDeltaBytes": 15896020,
"heapUsedBytes": 79007988,
"domNodes": -277,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 111.26199999999999,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.8439999999828,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.869,
"layouts": 5,
"layoutDurationMs": 12.991000000000003,
"taskDurationMs": 935.6,
"heapDeltaBytes": 19738060,
"heapUsedBytes": 100955624,
"domNodes": 13587,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 31.851999999999997,
"eventListeners": 2387,
"totalBlockingTimeMs": 145,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8311.803999999995,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.047,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5326.061000000001,
"heapDeltaBytes": -13507472,
"heapUsedBytes": 66207388,
"domNodes": -245,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 2852.221,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8440.53299999996,
"styleRecalcs": 247,
"styleRecalcDurationMs": 37.539,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5867.521,
"heapDeltaBytes": -4566180,
"heapUsedBytes": 75210608,
"domNodes": -248,
"jsHeapTotalBytes": -1093632,
"scriptDurationMs": 2787.7079999999996,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12741.807999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12207.075999999997,
"heapDeltaBytes": -30909084,
"heapUsedBytes": 185470012,
"domNodes": -6543,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 225.676,
"eventListeners": -7482,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16783.80900000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16345.658,
"heapDeltaBytes": -14856972,
"heapUsedBytes": 189141008,
"domNodes": -6542,
"jsHeapTotalBytes": 3821568,
"scriptDurationMs": 272.173,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20497.818999999992,
"styleRecalcs": 155,
"styleRecalcDurationMs": 16.961000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20233.086,
"heapDeltaBytes": -35146028,
"heapUsedBytes": 165549052,
"domNodes": -6542,
"jsHeapTotalBytes": 1589248,
"scriptDurationMs": 931.8280000000001,
"eventListeners": -7476,
"totalBlockingTimeMs": 47,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20707.254000000034,
"styleRecalcs": 159,
"styleRecalcDurationMs": 18.326000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20490.438,
"heapDeltaBytes": -13739052,
"heapUsedBytes": 187592256,
"domNodes": -6542,
"jsHeapTotalBytes": 471040,
"scriptDurationMs": 964.0529999999999,
"eventListeners": -7474,
"totalBlockingTimeMs": 43,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6168.412999999987,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.73200000000003,
"layouts": 20,
"layoutDurationMs": 22.24100000000001,
"taskDurationMs": 6073.311000000001,
"heapDeltaBytes": -8954880,
"heapUsedBytes": 193019736,
"domNodes": -6542,
"jsHeapTotalBytes": 16101376,
"scriptDurationMs": 115.93299999999999,
"eventListeners": -7478,
"totalBlockingTimeMs": 383,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6143.569999999954,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.86700000000002,
"layouts": 20,
"layoutDurationMs": 22.389000000000006,
"taskDurationMs": 6033.541999999999,
"heapDeltaBytes": -14646636,
"heapUsedBytes": 178442832,
"domNodes": -6542,
"jsHeapTotalBytes": 15966208,
"scriptDurationMs": 113.262,
"eventListeners": -7476,
"totalBlockingTimeMs": 397,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8553.43099999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8361.601999999997,
"heapDeltaBytes": -5475744,
"heapUsedBytes": 175065700,
"domNodes": 0,
"jsHeapTotalBytes": -4980736,
"scriptDurationMs": 132.24000000000004,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8442.655000000059,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8267.637999999999,
"heapDeltaBytes": -14138408,
"heapUsedBytes": 171834896,
"domNodes": 0,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 136.09800000000004,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 125.04699999999502,
"styleRecalcs": 10,
"styleRecalcDurationMs": 18.412000000000003,
"layouts": 2,
"layoutDurationMs": 1.2559999999999998,
"taskDurationMs": 96.298,
"heapDeltaBytes": 3112156,
"heapUsedBytes": 64847988,
"domNodes": 133,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.097999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 466.6349999999966,
"styleRecalcs": 13,
"styleRecalcDurationMs": 20.686000000000003,
"layouts": 2,
"layoutDurationMs": 0.9149999999999998,
"taskDurationMs": 109.94599999999998,
"heapDeltaBytes": 4748656,
"heapUsedBytes": 66355444,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.761000000000001,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #17464 +/- ##
==========================================
+ Coverage 82.49% 83.54% +1.04%
==========================================
Files 2685 2107 -578
Lines 135414 122650 -12764
Branches 35504 33776 -1728
==========================================
- Hits 111716 102464 -9252
+ Misses 22779 20005 -2774
+ Partials 919 181 -738
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| test('Preserves group node widget values through subgraph conversion', async ({ | ||
| comfyPage | ||
| }) => { | ||
| test.fail() |
There was a problem hiding this comment.
Might want to move this to just before the point at which we expect it to fail.
|
Follow-up opened: FE #17619 scopes the expected-failure marker to the known widget mismatch. Full context for agent readersThe review suggestion in this thread remains valid on |
## Summary Scope the expected-failure marker to the known widget-value mismatch so setup regressions fail normally. ## Changes - **What**: Moves `test.fail()` immediately before the mismatched widget assertion requested in [Comfy-Org#17464 review feedback](Comfy-Org#17464 (comment)). ## Review Focus Confirm setup and KSampler discovery failures are no longer accepted as the expected widget-pairing defect. ## Verification - Playwright discovery: 1 targeted test found - ESLint: clean - Oxfmt: clean - Browser and repository typechecks: clean - Knip: clean - `git diff --check`: clean
…#18584) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C09K9TPU2G7/p1790120500220719?thread_ts=1790120500.220719&cid=C09K9TPU2G7)_ ## Summary **Before:** the six remaining bugs from the 1.54 QA sweep (three sanitization/XSS gaps, a group-node widget-pairing bug, a VirtualGrid blank-render bug, and a preview-widget text-stripping bug) were being fixed as four independent PRs with no document tying them together as one scope contract — no shared record of root cause, fix approach, or verification plan across the batch. **After:** a single Technical Design Document (`docs/tdd/2026-09-qa-followup-security-and-stability-fixes.md`) covers all six items: problem statement and severity, exact scope (which PR/branch owns which fix), a per-item design section with root cause and fix approach, a sequence diagram for the VirtualGrid clamp-ordering bug, a verification plan (one row per acceptance criterion), and a rollout section noting these are plain merges with no flag needed, with the `core/1.54` backport decision explicitly left to the release owner. This is a docs-only PR; no application code changes. ## How Grounded the write-up by reading the actual source for each of the six fixes as they stand on `main` (`markdownRendererUtil.ts`, `SanitizedHtml.vue`, `DescriptionTabPanel.vue`, `groupNode.ts`, `VirtualGrid.vue`, `TextPreviewWidget.vue`), and by reading the two existing pinned-test PRs (#17464 for the group-node case, #17626 for the VirtualGrid case) that document those two defects in detail. For the VirtualGrid fix, also read the in-progress diff already drafted on branch `fix/virtual-grid-clamp-blank` to confirm the fix approach described matches what's actually being built. The other three fix branches (`fix/sanitization-hardening`, `fix/group-node-widget-pairing`, `fix/preview-widget-bracket-text`) had no commits yet at the time of writing, so their fix-approach sections describe the intended approach rather than an already-implemented diff. Followed the `comfy-tdd` skill's document skeleton (contract, design, verification, rollout), adapted for a bug-fix batch: no PRD (none exists for a QA-sweep-originated fix), no flags/ramp (each fix corrects already-broken behavior rather than adding new gated behavior), and DRI/approver/post-merge-owner left as open questions in Part 5 rather than invented. --- _Generated by [Claude Code](https://claude.ai/code/session_01Y2AsrQqEPrTVKvUm4HHdmc)_ --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Amp <amp@ampcode.com>
…ubgraph conversion (#18596) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C09K9TPU2G7/p1790120500220719?thread_ts=1790120500.220719&cid=C09K9TPU2G7)_ ## Summary Fixes a data-corruption bug where loading a legacy group node and letting it auto-convert to a subgraph could silently misassign widget values between inner nodes that share a widget name. ## Changes **Before:** When a legacy group node is loaded, it's automatically unpacked into its constituent nodes inside a subgraph (`GroupNodeHandler.convertToNodes()` in `src/extensions/core/groupNode.ts`). That code paired each inner node's widget to the group node's own outer widget by searching `node.widgets` for a matching **name** (`Array.findIndex`). If two inner nodes ended up exposing an outer widget with the same name (e.g. two `CLIPTextEncode` nodes both named `text`), the search always resolved to the *first* widget with that name, so a later widget could silently read the wrong value. QA reported this concretely on a `group_node_v1.3.3` fixture: after conversion, `KSampler.denoise` came back as `'euler'` instead of `1`, and `SaveImage.filename_prefix` came back as `'normal'` instead of `'ComfyUI'`. Saving the workflow then wrote those wrong values back to disk. This was pinned as a known, expected-to-fail regression test (`test.fail()`) in `browser_tests/tests/groupNode.spec.ts`, added in #17464. **After:** Widget lookups during conversion no longer rely on name matching alone. A new helper, `findUnconsumedWidgetIndex()`, resolves each requested widget name to an outer widget index while tracking which indices have already been consumed (in a `Set` shared across the whole conversion), so a name that happens to be shared between two inner nodes' widgets can no longer resolve twice to the same outer widget. The regression test in `groupNode.spec.ts` for `Preserves group node widget values through subgraph conversion` has `test.fail()` removed since the underlying defect is fixed. **How:** `convertToNodes()`'s widget-copy loop iterates inner nodes in the same order they were originally declared in the group (`nodeData.nodes` order). `findUnconsumedWidgetIndex()` walks the outer node's widgets, skipping any index already recorded in a `consumedOuterWidgetIndices` set, and returns the first remaining widget whose name matches; that index is then marked consumed before moving on (including all indices touched by a multi-widget `PrimitiveNode` copy). This keeps each widget paired to the widget belonging to its own originating node, in order, rather than resolving to whichever same-named widget happens to come first in the array. Added unit tests in `src/extensions/core/groupNode.test.ts` exercise `findUnconsumedWidgetIndex()` directly against a deliberate name collision to prove the pairing is now unambiguous. Fixes the defect pinned in #17464 (#17464). ## Review Focus I could not run the Playwright/browser suite against a live ComfyUI backend in the environment this fix was written in (no Docker daemon available to stand up the CI container), so the pinned E2E test (`Preserves group node widget values through subgraph conversion`) has not been executed end-to-end here — please let CI confirm it now passes. `pnpm typecheck:app`, `pnpm typecheck:browser`, `eslint`, and the `groupNode.test.ts` unit suite (22 tests, including the new ones) all pass locally. --- _Generated by [Claude Code](https://claude.ai/code/session_01Y2AsrQqEPrTVKvUm4HHdmc)_ --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: bymyself <cbyrne@comfy.org>
Summary
The test I added in #17393 could not fail on the bug it was written for. This replaces the assertion and pins the real defect QA found.
Changes
Preserves group node widget values through subgraph conversioningroupNode.spec.tsto assert widget pairing, pinned withtest.fail().Review Focus
Why the old assertion was vacuous. It flattened every interior widget value into a single array and asserted
arrayContaining([...])plustoHaveLength(14). Misalignment shuffles values between widgets — the multiset is identical and the length is unchanged. It passes on corrupted data.The bug is real, deterministic, and corrupts files. QA hit it on 2026-09-10 running the 1.54 plan: converting a v1.3.3 group node shifts widget values two positions, so
denoisereceives'euler'andfilename_prefixreceives'normal'. On a group node wrapping two samplers, six values land wrong on one node — including strings in numeric fields (noise_seed = 'enable',end_at_step = 'euler') and a number in a combo (control_after_generate = 0). Reproduced across 16 loads through the Workflows sidebar, no scripting. Saving writes the wrong values back to disk, so the workflow executes with values its author never set.Ground truth from the asset's own
extra.groupNodes:So
denoiseis1andfilename_prefixis'ComfyUI'— exactly the two QA reported landing wrong.Now asserts name → value pairing per interior node, with
toBeDefined()first so a missing node cannot maketoMatchObjectvacuous.Pinned with
test.fail(), matchingsubgraphPromotion.spec.ts:235andsubgraphConvertAutogrowInputs.spec.ts:124. CI stays green while the bug exists and flips red the moment the conversion is fixed — which is the signal to delete the marker.Worth deciding separately: this is a silent data-corruption bug on a legacy-workflow path and probably wants its own issue and a fix, not just a pin.