Repository navigation
fix(telemetry): preserve assertion diagnostic fidelity (cloud 1.53 backport) - #17427
Conversation
…6333) *PR Created by the Glary-Bot Agent* --- On Cloud, a failed `assert()` reaches Datadog twice. RUM collects `console.error` on its own, and `assert()` calls it before handing the failure to the reporter that #15189 wired up — so every assertion arrives once untagged from the console and once tagged via `reportError`. The untagged copy also bypasses `reportAssertFailure`'s dedup and its 20-per-session cap, so a render-loop invariant floods RUM regardless of either safeguard. ## Changes - `datadogRumBeforeSend` drops the console-sourced copy of an assertion, but only while a reporter is registered to produce the tagged one, so a boot-path assertion is never silenced entirely. `assert.ts` exports `ASSERTION_FAILURE_PREFIX` and `hasAssertReporter()` for that check; `assert()`'s own output is byte-identical. - Four assertion messages stopped interpolating unbounded values. `reportAssertFailure` dedups on exact message and caps a session at 20 distinct ones, so an interpolated value made each occurrence its own message. `unregisterNodeState` is the sharp case: `detachAllNodesFromStores` loops every node in a graph, so clearing a 20-node graph under identity drift burned the entire session budget in one call — and once the cap is spent no tagged report is produced, while the console echo is now dropped, leaving nothing at all. Static messages hold cardinality at 6 across all 5 call sites. - `nodeShellState.ts` x2 (`node.id`, `rootGraphId`), `inputSpecUtil.ts` (`spec.name`), `schemaGuard.ts` (`String(found)`, read `unknown` from a merged Yjs doc and therefore peer-influenced). `FollowerSchemaError` still carries `found` as a structured field. - `changeTracker.ts` stops interpolating `workflowPath`, which was shipping a user's workflow path to Datadog, Sentry, and the nightly toast. It stays in the local dedup key. All four were already required by `assert()`'s own docstring on `main` — "must be a static description of the invariant. Never interpolate user data (workflow names, paths, prompts) into it." ## Verification - `pnpm typecheck`, `pnpm lint` (0 errors), `pnpm format:check`, `pnpm knip` clean. 100 tests across the 7 affected files, plus the full CRDT suite at 160. - Mutation-tested each new guard: reverting the RUM filter fails `drops the console echo...`; restoring either interpolated `changeTracker` message fails its pinned assertion; restoring `schemaGuard`'s interpolated message fails both the positive and the new negative matcher. - Integration run through real `assert` -> real `reportAssertFailure` -> real `reportError`, capturing only the sinks: one assertion produces exactly one RUM-bound event; 100 repeats still one; 50 distinct node detachments produce one and leave later unrelated assertions deliverable. Under the old interpolated form the same 50 exhaust the cap and a subsequent unrelated assertion produces zero events. - Real browser against the dev server: importing `/src/base/assert.ts` returns `hasAssertReporter() === true`, so the app's own registration is visible to the same module instance, ruling out an import cycle from the new `datadogRumBeforeSend` -> `assert` edge. In that live runtime `rumBeforeSend` returns false for a console-sourced assertion, true for a custom-sourced one, and true for an ordinary console error. ## Follow-ups, deliberately not in scope - `schemaGuard`'s `found` and `inputSpecUtil`'s `specName` no longer reach telemetry at all. The right home is `reportError`'s existing structured `context`/`tags`, which are indexed and do not participate in message grouping — either called directly or by widening `AssertReporter` with an optional context. It is a design change to `assert()` rather than a fix to this bug. That follow-up should also preserve coarse recurrence information (for example thresholded counts) so a one-off and a render-loop storm remain distinguishable without restoring per-occurrence cardinality. - `reportAssertFailure` adds to `reportedMessages` before `reportError` is called, and `reportError` returns early once any sink is live — so a report raised while Sentry is up but RUM is still initializing burns its dedup slot without reaching RUM, and is never buffered for the later flush. Predates this branch, in files it does not touch. ## Context Supersedes #15671, which targeted the same problem before #15189 landed the reporting path on `main` and is now largely redundant against it. #15671 should be closed. --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> Co-authored-by: Pipeline Agent <agent@pipeline.local> (cherry picked from commit 83fb266)
## Summary Set the Datadog error copy's `name` from `reportError()`'s stable `errorType`, so custom errors can be grouped by native `@error.type` instead of `@context.error_type`. ## Changes - Preserve the message, stack, cause, custom metadata, and original Sentry exception; retain legacy RUM context for existing dashboards. - Cover direct, buffered, string, and frozen errors; update instrumentation guidance. - Require generic-to-specific error slugs (`<category>_<operation>_<subject>[_detail]`), consistent vocabulary, and reuse of existing failure names. Example: `failure_initializing_workspace_auth_gate`. Existing emitted slugs require a coordinated query/alert migration before renaming. ## Review Focus Native error types change for new custom reports, which can create new Error Tracking issue groups. Dashboard companion: Comfy-Org/comfy-infra#1106. Switch that dashboard to native types after the frontend change reaches both stable and canary. Validation: 22 focused tests, typecheck, lint (existing warnings), knip, formatting, and commit hooks passed. A check using Datadog SDK 6.33.0 confirmed different filenames/timestamps emit the same native error type. The naming-rule follow-up changes documentation only; formatting and commit/push hooks passed. No UI changes. Created by Codex --------- Co-authored-by: huang47 <157390+huang47@users.noreply.github.com> (cherry picked from commit 74564e3)
Preserve actionable diagnostics for assertion failures across Sentry and Datadog, completing the review follow-up from #16333 without changing assertion message grouping. - **Structured diagnostics**: `assert()` accepts optional context and forwards `found`, `specName`, node ID, and root graph ID from the reviewed invariant sites. - **Recurrence signal**: repeated assertions emit at coarse counts 1, 10, 100, and 1000 while retaining the 20-distinct-message bound. - **Cloud delivery**: when Sentry initializes before Datadog RUM, `reportError` still queues the RUM leg without sending a duplicate Sentry event. - **Privacy boundary**: this does not automatically restore `workflowPath`; that remains deliberately excluded pending a separate privacy decision. Please review sink-specific delivery state in `reportError` and the structured context emitted by graph/schema assertions. Follow-up to #16333. - `pnpm vitest run src/base/assert.test.ts src/platform/telemetry/assertFailureReporter.test.ts src/platform/telemetry/reportError.test.ts src/schemas/nodeDef/inputSpecUtil.test.ts src/workbench/extensions/agent/crdt/schemaGuard.test.ts src/core/graph/nodeShell/nodeShellState.test.ts` — 6 files, 42 tests passed. - `pnpm vitest run src/base/assert.test.ts src/platform/telemetry/assertFailureReporter.test.ts src/platform/telemetry/reportError.test.ts` — repeat run: 3 files, 22 tests passed. - `pnpm typecheck` — passed. - Targeted ESLint and oxfmt checks over all 13 changed files — passed. - Pre-commit hooks: lint-staged formatting, full lint, typecheck, and knip passed. - `git diff --check origin/main` — passed. <!-- authored-by:agent lane-act-fe-16333-followup --> --------- Co-authored-by: Glary Bot <bot@comfy.org> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Amp <amp@ampcode.com> (cherry picked from commit 3d7c5d4)
Replaces three console-only layout listener catches with the durable `canvas_layout_listener_failed` signal. The `listener_scope` tag distinguishes geometry, global, and node listeners while preserving catch-and-continue fan-out behavior. - `NODE_OPTIONS=--no-experimental-webstorage pnpm test:unit src/renderer/core/layout/store/layoutStore.test.ts` — 27 passed - `pnpm typecheck` — passed - `pnpm lint` — passed (0 errors; 189 pre-existing warnings) - `pnpm knip` — passed - `pnpm exec oxfmt --check src/renderer/core/layout/store/layoutStore.ts src/renderer/core/layout/store/layoutStore.test.ts` — passed - `git diff --check` — passed Program row: `tele-16` <!-- authored-by:agent lane-tele-16-2239 --> --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Amp <amp@ampcode.com> (cherry picked from commit cf15ffd)
…backport conflict resolution
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1894 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-11T08:25:17.289Z",
"gitSha": "bbe55c1a9bc33308ff94c3fd03d4ac3f9e5bf6b3",
"branch": "backport/15671-cloud-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2040.249000000017,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.238999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.826,
"heapDeltaBytes": -3115196,
"heapUsedBytes": 66789060,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.660999999999998,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2021.2480000000141,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.708,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.09200000000004,
"heapDeltaBytes": 466056,
"heapUsedBytes": 70839600,
"domNodes": -282,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 8.203999999999999,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2067.2589999999786,
"styleRecalcs": 80,
"styleRecalcDurationMs": 42.653,
"layouts": 14,
"layoutDurationMs": 5.697,
"taskDurationMs": 1024.874,
"heapDeltaBytes": 2427528,
"heapUsedBytes": 72267036,
"domNodes": -283,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 164.674,
"eventListeners": -189,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1805.4410000000871,
"styleRecalcs": 75,
"styleRecalcDurationMs": 35.501000000000005,
"layouts": 14,
"layoutDurationMs": 4.38,
"taskDurationMs": 855.893,
"heapDeltaBytes": 12920648,
"heapUsedBytes": 83286640,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 141.29,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.7649999999521,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.555,
"layouts": 6,
"layoutDurationMs": 1.2180000000000002,
"taskDurationMs": 373.258,
"heapDeltaBytes": 4469284,
"heapUsedBytes": 74662176,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.546999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.9379999999328,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.425,
"layouts": 6,
"layoutDurationMs": 1.126,
"taskDurationMs": 348.337,
"heapDeltaBytes": 4354292,
"heapUsedBytes": 74970208,
"domNodes": 78,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 10.848,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 642.2570000000292,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.2860000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.724,
"heapDeltaBytes": -7775836,
"heapUsedBytes": 63001580,
"domNodes": 18,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 154.147,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 666.0440000000563,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.841,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.57599999999996,
"heapDeltaBytes": 18100356,
"heapUsedBytes": 87882916,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 159.233,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2029.4349999999781,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.863000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.9069999999999,
"heapDeltaBytes": -13774880,
"heapUsedBytes": 87225584,
"domNodes": -273,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 34.63899999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2013.243999999986,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.5470000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 570.3929999999999,
"heapDeltaBytes": 11059112,
"heapUsedBytes": 86890020,
"domNodes": -275,
"jsHeapTotalBytes": -2441216,
"scriptDurationMs": 35.01,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2174.5599999999854,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.413999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1549.2949999999998,
"heapDeltaBytes": 19357440,
"heapUsedBytes": 84538980,
"domNodes": -268,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 759.4989999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2157.1740000000545,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.317,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1508.8359999999996,
"heapDeltaBytes": 19358888,
"heapUsedBytes": 85097484,
"domNodes": -271,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 743.263,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3484.5789999999965,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.560000000000004,
"layouts": 60,
"layoutDurationMs": 12.969000000000001,
"taskDurationMs": 1687.4250000000002,
"heapDeltaBytes": 10194608,
"heapUsedBytes": 76532920,
"domNodes": -279,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 770.1030000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3522.3629999999275,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.249,
"layouts": 60,
"layoutDurationMs": 12.479000000000001,
"taskDurationMs": 1638.72,
"heapDeltaBytes": 8720044,
"heapUsedBytes": 75763100,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 748.87,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3112.446000000034,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.527000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1867.8919999999998,
"heapDeltaBytes": 19234260,
"heapUsedBytes": 87206476,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 958.0719999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3078.2899999999245,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.597999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1861.8479999999997,
"heapDeltaBytes": 20791080,
"heapUsedBytes": 88194296,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 942.4699999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2003.3849999999802,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.234000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 564.3969999999999,
"heapDeltaBytes": 21850556,
"heapUsedBytes": 87595908,
"domNodes": -271,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.053000000000004,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2005.2440000000615,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.824000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.1990000000001,
"heapDeltaBytes": 21855076,
"heapUsedBytes": 87588976,
"domNodes": -269,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.750999999999994,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.7600000000025,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.222999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.367,
"heapDeltaBytes": 14764644,
"heapUsedBytes": 87471356,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 138.296,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 578.6399999999503,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.635,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.46100000000007,
"heapDeltaBytes": 14819704,
"heapUsedBytes": 87038748,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 138.93599999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2014.2290000000003,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.431999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.484,
"heapDeltaBytes": -12063956,
"heapUsedBytes": 60739048,
"domNodes": -298,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 8.098999999999998,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.8700000000163,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.209999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.2660000000001,
"heapDeltaBytes": 3124112,
"heapUsedBytes": 75800340,
"domNodes": -298,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.635,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1766.7999999999893,
"styleRecalcs": 77,
"styleRecalcDurationMs": 40.696999999999996,
"layouts": 18,
"layoutDurationMs": 4.971,
"taskDurationMs": 819.857,
"heapDeltaBytes": 2513080,
"heapUsedBytes": 75241308,
"domNodes": -297,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 100.272,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.7320000000036,
"styleRecalcs": 78,
"styleRecalcDurationMs": 37.49100000000001,
"layouts": 18,
"layoutDurationMs": 8.863,
"taskDurationMs": 808.538,
"heapDeltaBytes": -12535068,
"heapUsedBytes": 60202116,
"domNodes": -295,
"jsHeapTotalBytes": 7331840,
"scriptDurationMs": 99.972,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1366.4280000000417,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.031999999999996,
"layouts": 15,
"layoutDurationMs": 14.086999999999998,
"taskDurationMs": 914.8069999999999,
"heapDeltaBytes": 26322344,
"heapUsedBytes": 99140848,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 30.718999999999998,
"eventListeners": 2383,
"totalBlockingTimeMs": 120,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8351.716999999951,
"styleRecalcs": 247,
"styleRecalcDurationMs": 39.059999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5652.736999999999,
"heapDeltaBytes": -20570196,
"heapUsedBytes": 80107104,
"domNodes": -271,
"jsHeapTotalBytes": -868352,
"scriptDurationMs": 2607.026,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8202.126000000022,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.998000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5409.171,
"heapDeltaBytes": -11892416,
"heapUsedBytes": 88950608,
"domNodes": -269,
"jsHeapTotalBytes": -2179072,
"scriptDurationMs": 2463.2019999999998,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18131.13199999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17409.73,
"heapDeltaBytes": -38367376,
"heapUsedBytes": 175332268,
"domNodes": -6548,
"jsHeapTotalBytes": -7790592,
"scriptDurationMs": 305.219,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17837.000999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16987.781000000003,
"heapDeltaBytes": -30224224,
"heapUsedBytes": 176913908,
"domNodes": -6548,
"jsHeapTotalBytes": -6574080,
"scriptDurationMs": 282.66600000000005,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22475.183000000015,
"styleRecalcs": 176,
"styleRecalcDurationMs": 20.87,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22191.743000000002,
"heapDeltaBytes": -27203120,
"heapUsedBytes": 176474456,
"domNodes": -6548,
"jsHeapTotalBytes": 2637824,
"scriptDurationMs": 922.732,
"eventListeners": -7469,
"totalBlockingTimeMs": 160,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21688.86699999996,
"styleRecalcs": 170,
"styleRecalcDurationMs": 19.486000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21319.606,
"heapDeltaBytes": -19507600,
"heapUsedBytes": 190236540,
"domNodes": -6548,
"jsHeapTotalBytes": -5439488,
"scriptDurationMs": 928.192,
"eventListeners": -7469,
"totalBlockingTimeMs": 131,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6462.807999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.96799999999998,
"layouts": 20,
"layoutDurationMs": 24.223999999999997,
"taskDurationMs": 6347.087,
"heapDeltaBytes": -26108624,
"heapUsedBytes": 176797720,
"domNodes": -6548,
"jsHeapTotalBytes": 11821056,
"scriptDurationMs": 112.313,
"eventListeners": -7471,
"totalBlockingTimeMs": 436,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6244.644999999991,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.35300000000001,
"layouts": 20,
"layoutDurationMs": 22.707000000000004,
"taskDurationMs": 6142.233000000001,
"heapDeltaBytes": -21230008,
"heapUsedBytes": 181603324,
"domNodes": -6548,
"jsHeapTotalBytes": 18636800,
"scriptDurationMs": 116.75499999999998,
"eventListeners": -7469,
"totalBlockingTimeMs": 390,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 460.990000000038,
"styleRecalcs": 18,
"styleRecalcDurationMs": 25.079,
"layouts": 4,
"layoutDurationMs": 2.037,
"taskDurationMs": 111.89800000000001,
"heapDeltaBytes": 5235584,
"heapUsedBytes": 73524932,
"domNodes": 151,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.842,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 104.14400000001933,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.981000000000002,
"layouts": 2,
"layoutDurationMs": 0.7360000000000001,
"taskDurationMs": 76.832,
"heapDeltaBytes": 3155116,
"heapUsedBytes": 71845804,
"domNodes": 108,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.732000000000001,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.53 #17427 +/- ##
=============================================
Coverage ? 83.36%
=============================================
Files ? 2026
Lines ? 117406
Branches ? 32346
=============================================
Hits ? 97880
Misses ? 19177
Partials ? 349
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
CodeJuggernaut
left a comment
There was a problem hiding this comment.
Matches the merged core/1.53 sibling file for file. The only difference is two extra sink-retry tests core/1.53 carries in reportError.test.ts, production code identical.
Backport of the telemetry assertion-fidelity fix to cloud/1.53, with its prerequisites. Sibling of the already-merged core/1.53 backport.
3d7c5d4df3).src/platform/telemetry: 29 files, 393 tests) passes on this branch.Full context for agent readers
Cherry-picked with
-x, in dependency order, onto35c46f0ec9(origin/cloud/1.53):83fb266a6e(RUM exactly-once) — required by the assertion code path.74564e32d3(stable native error types) — required by the assertion code path.3d7c5d4df3(the fix itself).cf15ffd685(layout listener failures) — required because threereportError.test.tstests introduced by the fix rely on the layout-listenerreportError()behavior.e2a2cd419falignment commit, cloud-only: the cherry-pick ofcf15ffd685conflicted inassertFailureReporter.tsand the automatic resolution droppedoccurrenceCountfrom the reportedcontext. This commit restorescontext: { ...context, occurrenceCount }and the matching test expectation, so the file now matches the core/1.53 version byte-for-byte.Not pulled:
606fb5eedf(already present on 1.53), and unrelated main.ts changesee86e426ef/05672356c6.