Skip to content

fix: reject malformed subgraph links before unpacking (cloud 1.53 backport) - #17406

Merged
christian-byrne merged 1 commit into
cloud/1.53from
christian-byrne/backport-17330-cloud-1.53
Sep 11, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.53from
christian-byrne/backport-17330-cloud-1.53

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backport of #17330 to the 1.53 release line.

  • Rejects malformed subgraph links before unpacking instead of throwing mid-conversion.
  • Last remaining item from the ECS follow-up list; needed on 1.53 before GA.
  • Cherry-pick resolved by hand; details below.
Full context for agent readers

Source: #17330 (merged to main as c8ddb60).

Conflict resolution on this branch:

  • useSubgraphOperations.ts: kept the 1.53 let changed / if (changed) workflowStore.activeWorkflow?.changeTracker.captureCanvasState() structure; only the malformed-link guard was ported.
  • SubgraphConversion.test.ts: kept the 1.53-only useWidgetValueStore import. The new assertion uses toBeUndefined() rather than toBeNull() because LGraph.getNodeById returns undefined on 1.53 (main returns null). No change to getNodeById itself on this branch.

Verification: pnpm typecheck clean; SubgraphConversion.test.ts 25/25 passing in the worktree.

Fixes #16335

- Unpacking a subgraph that contains a malformed link (input link
missing its output slot) no longer half-applies the mutation; unpack is
rejected up front and the graph is left unchanged.
- Preflight runs before `beforeChange()`, so no change event fires and
no undo entry is created for a rejected unpack.
- Red/green regression test covers both the malformed-link rejection and
the intact-subgraph success path.

<details><summary>Full context for agent readers</summary>

**Root cause:** `LGraph.unpackSubgraph()` began mutating the parent
graph (`beforeChange()`, node removal, link re-creation) before
validating the subgraph's internal links. A link whose `origin_slot` did
not resolve to an output caused a throw mid-mutation, leaving the graph
in a partially unpacked state.

**Fix:** `unpackSubgraph()` now returns `boolean`. It calls a private
`_findMalformedSubgraphLink(subgraphNode)` first; if a malformed link is
found it logs a `console.error` and returns `false` without touching the
graph. Otherwise it proceeds through the existing implementation
(`_unpackSubgraphImpl`) and returns `true`. Existing callers ignore the
return value, so this is non-breaking.

**Tests:** `src/lib/litegraph/src/subgraph/SubgraphConversion.test.ts`
- malformed link → returns `false`, node count / link count / subgraph
node all untouched, no `beforeChange` emitted
- intact subgraph → returns `true`, unpack completes as before

**Verification:** `pnpm vitest run
src/lib/litegraph/src/subgraph/SubgraphConversion.test.ts` 13/13 pass;
`pnpm oxlint` 0 errors; `pnpm knip` clean; `pnpm typecheck` clean.

**Backport:** carries `needs-backport`, `core/1.53`, `cloud/1.53` per
ECS release policy.

<!-- authored-by:agent supreme-operator w3-520-followup -->
</details>

---------

Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Alexander Brown <drjkl@comfy.org>
(cherry picked from commit c8ddb60)
@christian-byrne christian-byrne added cloud/1.53 Backport PRs for cloud 1.53 risk:xhigh PR risk grade (advisory shadow check; grader-owned) labels Sep 11, 2026
@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 11, 2026
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: dd5073d4-5180-4221-b8a9-7671637f8286

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1892 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1871 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/11/2026, 01:12:10 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.4 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.7 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 132ms TBT · 103.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
vue-large-graph-idle: · 54.5 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.7 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 75ms TBT · 168.2 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 658ms TBT · 168.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.7 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 522ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 71.3 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -170
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 44ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 79
canvas-mouse-sweep: task duration 1007ms
canvas-mouse-sweep: script duration 166ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 64.8 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -170
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 363ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.7 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 455ms
dom-widget-clipping: script duration 158ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 84.3 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 624ms
large-graph-idle: script duration 35ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.0 MB
large-graph-idle: DOM nodes -270
large-graph-idle: event listeners -154
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 64
large-graph-pan: task duration 1610ms
large-graph-pan: script duration 777ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 81.8 MB
large-graph-pan: DOM nodes -136
large-graph-pan: event listeners -74
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1713ms
large-graph-zoom: script duration 765ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 71.8 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1961ms
legacy-node-drag: script duration 973ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 85.4 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 568ms
minimap-idle: script duration 36ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.5 MB
minimap-idle: DOM nodes -270
minimap-idle: event listeners -91
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 406ms
subgraph-dom-widget-clipping: script duration 140ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.3 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 510ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 59.8 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -200
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 37ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 837ms
subgraph-mouse-sweep: script duration 107ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 64.7 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -217
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 1009ms
subgraph-transition-enter: script duration 32ms
subgraph-transition-enter: TBT 132ms
subgraph-transition-enter: heap used 103.9 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 39ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 246
viewport-pan-sweep: task duration 5906ms
viewport-pan-sweep: script duration 2697ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 83.2 MB
viewport-pan-sweep: DOM nodes -274
viewport-pan-sweep: event listeners -153
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17578ms
vue-large-graph-idle: script duration 320ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.7 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7473
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 22ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 165
vue-large-graph-pan: task duration 22108ms
vue-large-graph-pan: script duration 931ms
vue-large-graph-pan: TBT 75ms
vue-large-graph-pan: heap used 168.2 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7467
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 28ms
vue-node-resize-workload: style recalc duration 78ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6568ms
vue-node-resize-workload: script duration 124ms
vue-node-resize-workload: TBT 658ms
vue-node-resize-workload: heap used 168.7 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7468
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 19ms
workflow-execution: layout count 4
workflow-execution: style recalc count 15
workflow-execution: task duration 108ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.7 MB
workflow-execution: DOM nodes 135
workflow-execution: event listeners 99
Raw data
{
  "timestamp": "2026-09-11T01:22:49.223Z",
  "gitSha": "130719c7979e669ad312ca33b61c0d320560b27a",
  "branch": "christian-byrne/backport-17330-cloud-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2054.71,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.652,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 516.594,
      "heapDeltaBytes": 9944976,
      "heapUsedBytes": 80313564,
      "domNodes": -280,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.379999999999999,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2051.5980000000127,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.206999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 528.0450000000001,
      "heapDeltaBytes": -570236,
      "heapUsedBytes": 69243840,
      "domNodes": -281,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 9.706,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2110.6379999999945,
      "styleRecalcs": 82,
      "styleRecalcDurationMs": 48.004,
      "layouts": 14,
      "layoutDurationMs": 5.8759999999999994,
      "taskDurationMs": 1137.826,
      "heapDeltaBytes": 3440748,
      "heapUsedBytes": 73100816,
      "domNodes": -282,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 185.25300000000001,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1837.1830000000955,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 39.114999999999995,
      "layouts": 14,
      "layoutDurationMs": 4.753,
      "taskDurationMs": 875.4390000000001,
      "heapDeltaBytes": -7514780,
      "heapUsedBytes": 62705644,
      "domNodes": -280,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 146.649,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1658.0850000000282,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 15.613000000000001,
      "layouts": 6,
      "layoutDurationMs": 1.032,
      "taskDurationMs": 351.38599999999997,
      "heapDeltaBytes": 4432660,
      "heapUsedBytes": 75042276,
      "domNodes": 76,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 10.035000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1720.5069999999978,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 18.391000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.1550000000000002,
      "taskDurationMs": 375.139,
      "heapDeltaBytes": 4413160,
      "heapUsedBytes": 75305912,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 12.451,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 675.3190000000018,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.504000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 465.74499999999995,
      "heapDeltaBytes": 18451036,
      "heapUsedBytes": 88535300,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 161.858,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 659.1560000000527,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.638000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 443.726,
      "heapDeltaBytes": 17781144,
      "heapUsedBytes": 88285544,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 153.76899999999998,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2043.1239999999775,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.418000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 604.8169999999999,
      "heapDeltaBytes": -13680580,
      "heapUsedBytes": 87260744,
      "domNodes": -269,
      "jsHeapTotalBytes": -1617920,
      "scriptDurationMs": 31.67299999999999,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2052.1019999999908,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.597,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 643.587,
      "heapDeltaBytes": -14225236,
      "heapUsedBytes": 86761968,
      "domNodes": -271,
      "jsHeapTotalBytes": -831488,
      "scriptDurationMs": 38.703,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2217.6680000000033,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 9.823000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1530.718,
      "heapDeltaBytes": 22566716,
      "heapUsedBytes": 88146880,
      "domNodes": 2,
      "jsHeapTotalBytes": 487424,
      "scriptDurationMs": 751.475,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2290.9970000000612,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 11.362,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1690.241,
      "heapDeltaBytes": 17570352,
      "heapUsedBytes": 83443612,
      "domNodes": -273,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 802.427,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3564.174000000037,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.948000000000002,
      "layouts": 60,
      "layoutDurationMs": 13.451999999999998,
      "taskDurationMs": 1695.675,
      "heapDeltaBytes": 7713044,
      "heapUsedBytes": 75445196,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 752.1979999999999,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3533.999999999992,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 11.195999999999998,
      "layouts": 60,
      "layoutDurationMs": 13.485000000000001,
      "taskDurationMs": 1729.5889999999997,
      "heapDeltaBytes": 7735648,
      "heapUsedBytes": 75141408,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 778.012,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3055.6080000000065,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.781999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1916.542,
      "heapDeltaBytes": 17428348,
      "heapUsedBytes": 85265056,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 954.555,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3149.94999999999,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.424999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2005.4279999999997,
      "heapDeltaBytes": 26435160,
      "heapUsedBytes": 93750612,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 992.2690000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2013.719999999978,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.3870000000000013,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 548.6940000000001,
      "heapDeltaBytes": 22054320,
      "heapUsedBytes": 88050956,
      "domNodes": -271,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 36.014,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2022.779000000014,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 3.4999999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 588.011,
      "heapDeltaBytes": 10877220,
      "heapUsedBytes": 87093916,
      "domNodes": -269,
      "jsHeapTotalBytes": -1916928,
      "scriptDurationMs": 35.735,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 593.6110000000099,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.557,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 413.609,
      "heapDeltaBytes": 14788148,
      "heapUsedBytes": 87340052,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 143.26500000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 586.2399999999752,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.634000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 398.3929999999999,
      "heapDeltaBytes": 14757708,
      "heapUsedBytes": 87451152,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 137.191,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.5999999999544,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.245999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 482.28900000000004,
      "heapDeltaBytes": -9856556,
      "heapUsedBytes": 62401608,
      "domNodes": -294,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.985000000000002,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.8609999999208,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.483,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 537.164,
      "heapDeltaBytes": -9730604,
      "heapUsedBytes": 63008808,
      "domNodes": -297,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 9.886,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1718.8059999999723,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 36.61200000000001,
      "layouts": 18,
      "layoutDurationMs": 5.567,
      "taskDurationMs": 817.89,
      "heapDeltaBytes": -12498984,
      "heapUsedBytes": 60201900,
      "domNodes": -298,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 104.186,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1714.2669999999498,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 37.691,
      "layouts": 18,
      "layoutDurationMs": 5.471,
      "taskDurationMs": 856.306,
      "heapDeltaBytes": 3784612,
      "heapUsedBytes": 75494360,
      "domNodes": -294,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 110.00999999999999,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1432.2839999999815,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 30.90000000000001,
      "layouts": 16,
      "layoutDurationMs": 15.097999999999997,
      "taskDurationMs": 1008.535,
      "heapDeltaBytes": 21026188,
      "heapUsedBytes": 108980736,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 31.829000000000004,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 132,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8354.746999999974,
      "styleRecalcs": 245,
      "styleRecalcDurationMs": 37.708000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5702.255999999999,
      "heapDeltaBytes": 8903504,
      "heapUsedBytes": 84963712,
      "domNodes": -276,
      "jsHeapTotalBytes": -118784,
      "scriptDurationMs": 2555.203,
      "eventListeners": -169,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8707.242999999948,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 40.05,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6109.655999999999,
      "heapDeltaBytes": -11291712,
      "heapUsedBytes": 89597044,
      "domNodes": -271,
      "jsHeapTotalBytes": 1753088,
      "scriptDurationMs": 2837.863,
      "eventListeners": -137,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999952,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18322.158000000003,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17834.618,
      "heapDeltaBytes": -25098768,
      "heapUsedBytes": 179695648,
      "domNodes": -6548,
      "jsHeapTotalBytes": -3272704,
      "scriptDurationMs": 323.503,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18000.69400000007,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17321.345,
      "heapDeltaBytes": -34243844,
      "heapUsedBytes": 176123528,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2617344,
      "scriptDurationMs": 317.455,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22548.041000000012,
      "styleRecalcs": 163,
      "styleRecalcDurationMs": 22.384999999999987,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22256.118000000002,
      "heapDeltaBytes": -43181652,
      "heapUsedBytes": 166636204,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5894144,
      "scriptDurationMs": 956.181,
      "eventListeners": -7467,
      "totalBlockingTimeMs": 107,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22262.786999999887,
      "styleRecalcs": 167,
      "styleRecalcDurationMs": 21.02900000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21960.239999999998,
      "heapDeltaBytes": -27357512,
      "heapUsedBytes": 186188704,
      "domNodes": -6548,
      "jsHeapTotalBytes": -6381568,
      "scriptDurationMs": 905.3720000000001,
      "eventListeners": -7467,
      "totalBlockingTimeMs": 42,
      "frameDurationMs": 18.330000000000048,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6705.731000000014,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.08000000000004,
      "layouts": 20,
      "layoutDurationMs": 30.72000000000001,
      "taskDurationMs": 6648.0779999999995,
      "heapDeltaBytes": -35449312,
      "heapUsedBytes": 174550752,
      "domNodes": -6548,
      "jsHeapTotalBytes": 4591616,
      "scriptDurationMs": 121.245,
      "eventListeners": -7467,
      "totalBlockingTimeMs": 748,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6570.009000000027,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 78.29399999999997,
      "layouts": 20,
      "layoutDurationMs": 25.662000000000003,
      "taskDurationMs": 6487.707,
      "heapDeltaBytes": -24015524,
      "heapUsedBytes": 179273988,
      "domNodes": -6548,
      "jsHeapTotalBytes": 17559552,
      "scriptDurationMs": 125.84400000000001,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 567,
      "frameDurationMs": 17.773333333333298,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 466.150999999968,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 17.804000000000002,
      "layouts": 3,
      "layoutDurationMs": 0.8519999999999999,
      "taskDurationMs": 102.39299999999999,
      "heapDeltaBytes": 5078640,
      "heapUsedBytes": 73524964,
      "domNodes": 124,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.035,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 486.69999999992797,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 20.662,
      "layouts": 4,
      "layoutDurationMs": 2.0280000000000005,
      "taskDurationMs": 112.80499999999999,
      "heapDeltaBytes": 5214576,
      "heapUsedBytes": 72733724,
      "domNodes": 146,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.813,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48177 70724 68.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.5% 396
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.2% 303
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.4% 261
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/renderer/core/canvas/pathRenderer.ts 24.7% 192

@codecov

codecov Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/lib/litegraph/src/LGraph.ts 60.00% 2 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.53   #17406   +/-   ##
=============================================
  Coverage              ?   83.35%           
=============================================
  Files                 ?     2025           
  Lines                 ?   117347           
  Branches              ?    34391           
=============================================
  Hits                  ?    97820           
  Misses                ?    19179           
  Partials              ?      348           
Flag Coverage Δ
e2e 66.62% <90.90%> (?)
unit 76.74% <95.65%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/composables/graph/useSubgraphOperations.ts 87.03% <100.00%> (ø)
src/lib/litegraph/src/subgraph/subgraphUtils.ts 91.20% <100.00%> (ø)
src/stores/nodeOutputStore.ts 89.01% <100.00%> (ø)
src/lib/litegraph/src/LGraph.ts 77.67% <60.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne merged commit 35c46f0 into cloud/1.53 Sep 11, 2026
129 of 131 checks passed
@christian-byrne
christian-byrne deleted the christian-byrne/backport-17330-cloud-1.53 branch September 11, 2026 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cloud/1.53 Backport PRs for cloud 1.53 risk:R3 PR risk grade (advisory shadow check; grader-owned) risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants