Repository navigation
fix: reject malformed subgraph links before unpacking (cloud 1.53 backport) - #17406
Conversation
Fixes #16335 - Unpacking a subgraph that contains a malformed link (input link missing its output slot) no longer half-applies the mutation; unpack is rejected up front and the graph is left unchanged. - Preflight runs before `beforeChange()`, so no change event fires and no undo entry is created for a rejected unpack. - Red/green regression test covers both the malformed-link rejection and the intact-subgraph success path. <details><summary>Full context for agent readers</summary> **Root cause:** `LGraph.unpackSubgraph()` began mutating the parent graph (`beforeChange()`, node removal, link re-creation) before validating the subgraph's internal links. A link whose `origin_slot` did not resolve to an output caused a throw mid-mutation, leaving the graph in a partially unpacked state. **Fix:** `unpackSubgraph()` now returns `boolean`. It calls a private `_findMalformedSubgraphLink(subgraphNode)` first; if a malformed link is found it logs a `console.error` and returns `false` without touching the graph. Otherwise it proceeds through the existing implementation (`_unpackSubgraphImpl`) and returns `true`. Existing callers ignore the return value, so this is non-breaking. **Tests:** `src/lib/litegraph/src/subgraph/SubgraphConversion.test.ts` - malformed link → returns `false`, node count / link count / subgraph node all untouched, no `beforeChange` emitted - intact subgraph → returns `true`, unpack completes as before **Verification:** `pnpm vitest run src/lib/litegraph/src/subgraph/SubgraphConversion.test.ts` 13/13 pass; `pnpm oxlint` 0 errors; `pnpm knip` clean; `pnpm typecheck` clean. **Backport:** carries `needs-backport`, `core/1.53`, `cloud/1.53` per ECS release policy. <!-- authored-by:agent supreme-operator w3-520-followup --> </details> --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> (cherry picked from commit c8ddb60)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1892 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-11T01:22:49.223Z",
"gitSha": "130719c7979e669ad312ca33b61c0d320560b27a",
"branch": "christian-byrne/backport-17330-cloud-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2054.71,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.652,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.594,
"heapDeltaBytes": 9944976,
"heapUsedBytes": 80313564,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.379999999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2051.5980000000127,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.206999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.0450000000001,
"heapDeltaBytes": -570236,
"heapUsedBytes": 69243840,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.706,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2110.6379999999945,
"styleRecalcs": 82,
"styleRecalcDurationMs": 48.004,
"layouts": 14,
"layoutDurationMs": 5.8759999999999994,
"taskDurationMs": 1137.826,
"heapDeltaBytes": 3440748,
"heapUsedBytes": 73100816,
"domNodes": -282,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 185.25300000000001,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1837.1830000000955,
"styleRecalcs": 76,
"styleRecalcDurationMs": 39.114999999999995,
"layouts": 14,
"layoutDurationMs": 4.753,
"taskDurationMs": 875.4390000000001,
"heapDeltaBytes": -7514780,
"heapUsedBytes": 62705644,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 146.649,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1658.0850000000282,
"styleRecalcs": 29,
"styleRecalcDurationMs": 15.613000000000001,
"layouts": 6,
"layoutDurationMs": 1.032,
"taskDurationMs": 351.38599999999997,
"heapDeltaBytes": 4432660,
"heapUsedBytes": 75042276,
"domNodes": 76,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 10.035000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.5069999999978,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.391000000000002,
"layouts": 6,
"layoutDurationMs": 1.1550000000000002,
"taskDurationMs": 375.139,
"heapDeltaBytes": 4413160,
"heapUsedBytes": 75305912,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.451,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 675.3190000000018,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.504000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.74499999999995,
"heapDeltaBytes": 18451036,
"heapUsedBytes": 88535300,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 161.858,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 659.1560000000527,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.638000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.726,
"heapDeltaBytes": 17781144,
"heapUsedBytes": 88285544,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 153.76899999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2043.1239999999775,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.418000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 604.8169999999999,
"heapDeltaBytes": -13680580,
"heapUsedBytes": 87260744,
"domNodes": -269,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 31.67299999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2052.1019999999908,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.597,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 643.587,
"heapDeltaBytes": -14225236,
"heapUsedBytes": 86761968,
"domNodes": -271,
"jsHeapTotalBytes": -831488,
"scriptDurationMs": 38.703,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2217.6680000000033,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.823000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1530.718,
"heapDeltaBytes": 22566716,
"heapUsedBytes": 88146880,
"domNodes": 2,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 751.475,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2290.9970000000612,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.362,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1690.241,
"heapDeltaBytes": 17570352,
"heapUsedBytes": 83443612,
"domNodes": -273,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 802.427,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3564.174000000037,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.948000000000002,
"layouts": 60,
"layoutDurationMs": 13.451999999999998,
"taskDurationMs": 1695.675,
"heapDeltaBytes": 7713044,
"heapUsedBytes": 75445196,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 752.1979999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3533.999999999992,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.195999999999998,
"layouts": 60,
"layoutDurationMs": 13.485000000000001,
"taskDurationMs": 1729.5889999999997,
"heapDeltaBytes": 7735648,
"heapUsedBytes": 75141408,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 778.012,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3055.6080000000065,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.781999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1916.542,
"heapDeltaBytes": 17428348,
"heapUsedBytes": 85265056,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 954.555,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3149.94999999999,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.424999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2005.4279999999997,
"heapDeltaBytes": 26435160,
"heapUsedBytes": 93750612,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 992.2690000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2013.719999999978,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.3870000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 548.6940000000001,
"heapDeltaBytes": 22054320,
"heapUsedBytes": 88050956,
"domNodes": -271,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.014,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2022.779000000014,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.4999999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 588.011,
"heapDeltaBytes": 10877220,
"heapUsedBytes": 87093916,
"domNodes": -269,
"jsHeapTotalBytes": -1916928,
"scriptDurationMs": 35.735,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 593.6110000000099,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.557,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.609,
"heapDeltaBytes": 14788148,
"heapUsedBytes": 87340052,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.26500000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 586.2399999999752,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.634000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.3929999999999,
"heapDeltaBytes": 14757708,
"heapUsedBytes": 87451152,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 137.191,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.5999999999544,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.245999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.28900000000004,
"heapDeltaBytes": -9856556,
"heapUsedBytes": 62401608,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.985000000000002,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.8609999999208,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.483,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 537.164,
"heapDeltaBytes": -9730604,
"heapUsedBytes": 63008808,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.886,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1718.8059999999723,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.61200000000001,
"layouts": 18,
"layoutDurationMs": 5.567,
"taskDurationMs": 817.89,
"heapDeltaBytes": -12498984,
"heapUsedBytes": 60201900,
"domNodes": -298,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 104.186,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1714.2669999999498,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.691,
"layouts": 18,
"layoutDurationMs": 5.471,
"taskDurationMs": 856.306,
"heapDeltaBytes": 3784612,
"heapUsedBytes": 75494360,
"domNodes": -294,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 110.00999999999999,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1432.2839999999815,
"styleRecalcs": 20,
"styleRecalcDurationMs": 30.90000000000001,
"layouts": 16,
"layoutDurationMs": 15.097999999999997,
"taskDurationMs": 1008.535,
"heapDeltaBytes": 21026188,
"heapUsedBytes": 108980736,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 31.829000000000004,
"eventListeners": 2383,
"totalBlockingTimeMs": 132,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8354.746999999974,
"styleRecalcs": 245,
"styleRecalcDurationMs": 37.708000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5702.255999999999,
"heapDeltaBytes": 8903504,
"heapUsedBytes": 84963712,
"domNodes": -276,
"jsHeapTotalBytes": -118784,
"scriptDurationMs": 2555.203,
"eventListeners": -169,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8707.242999999948,
"styleRecalcs": 247,
"styleRecalcDurationMs": 40.05,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6109.655999999999,
"heapDeltaBytes": -11291712,
"heapUsedBytes": 89597044,
"domNodes": -271,
"jsHeapTotalBytes": 1753088,
"scriptDurationMs": 2837.863,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18322.158000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17834.618,
"heapDeltaBytes": -25098768,
"heapUsedBytes": 179695648,
"domNodes": -6548,
"jsHeapTotalBytes": -3272704,
"scriptDurationMs": 323.503,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18000.69400000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17321.345,
"heapDeltaBytes": -34243844,
"heapUsedBytes": 176123528,
"domNodes": -6548,
"jsHeapTotalBytes": 2617344,
"scriptDurationMs": 317.455,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22548.041000000012,
"styleRecalcs": 163,
"styleRecalcDurationMs": 22.384999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22256.118000000002,
"heapDeltaBytes": -43181652,
"heapUsedBytes": 166636204,
"domNodes": -6548,
"jsHeapTotalBytes": -5894144,
"scriptDurationMs": 956.181,
"eventListeners": -7467,
"totalBlockingTimeMs": 107,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22262.786999999887,
"styleRecalcs": 167,
"styleRecalcDurationMs": 21.02900000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21960.239999999998,
"heapDeltaBytes": -27357512,
"heapUsedBytes": 186188704,
"domNodes": -6548,
"jsHeapTotalBytes": -6381568,
"scriptDurationMs": 905.3720000000001,
"eventListeners": -7467,
"totalBlockingTimeMs": 42,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6705.731000000014,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.08000000000004,
"layouts": 20,
"layoutDurationMs": 30.72000000000001,
"taskDurationMs": 6648.0779999999995,
"heapDeltaBytes": -35449312,
"heapUsedBytes": 174550752,
"domNodes": -6548,
"jsHeapTotalBytes": 4591616,
"scriptDurationMs": 121.245,
"eventListeners": -7467,
"totalBlockingTimeMs": 748,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6570.009000000027,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.29399999999997,
"layouts": 20,
"layoutDurationMs": 25.662000000000003,
"taskDurationMs": 6487.707,
"heapDeltaBytes": -24015524,
"heapUsedBytes": 179273988,
"domNodes": -6548,
"jsHeapTotalBytes": 17559552,
"scriptDurationMs": 125.84400000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 567,
"frameDurationMs": 17.773333333333298,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 466.150999999968,
"styleRecalcs": 13,
"styleRecalcDurationMs": 17.804000000000002,
"layouts": 3,
"layoutDurationMs": 0.8519999999999999,
"taskDurationMs": 102.39299999999999,
"heapDeltaBytes": 5078640,
"heapUsedBytes": 73524964,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.035,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 486.69999999992797,
"styleRecalcs": 16,
"styleRecalcDurationMs": 20.662,
"layouts": 4,
"layoutDurationMs": 2.0280000000000005,
"taskDurationMs": 112.80499999999999,
"heapDeltaBytes": 5214576,
"heapUsedBytes": 72733724,
"domNodes": 146,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.813,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.53 #17406 +/- ##
=============================================
Coverage ? 83.35%
=============================================
Files ? 2025
Lines ? 117347
Branches ? 34391
=============================================
Hits ? 97820
Misses ? 19179
Partials ? 348
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #17330 to the 1.53 release line.
Full context for agent readers
Source: #17330 (merged to main as c8ddb60).
Conflict resolution on this branch:
useSubgraphOperations.ts: kept the 1.53let changed/if (changed) workflowStore.activeWorkflow?.changeTracker.captureCanvasState()structure; only the malformed-link guard was ported.SubgraphConversion.test.ts: kept the 1.53-onlyuseWidgetValueStoreimport. The new assertion usestoBeUndefined()rather thantoBeNull()becauseLGraph.getNodeByIdreturnsundefinedon 1.53 (main returnsnull). No change togetNodeByIditself on this branch.Verification:
pnpm typecheckclean;SubgraphConversion.test.ts25/25 passing in the worktree.