Repository navigation
test(group-node): assert widget values survive subgraph conversion - #17393
Conversation
Gap from the 1.53 -> 1.54 QA plan, covering the legacy-workflow half of PR 17099 (preserve legacy numeric widget rendering) and PR 15759 (migrate sparse widget values). groupNode.spec.ts already loads groupnodes/group_node_v1.3.3, but only counts group-node instances, subgraphs, and the extra.groupNodes flag. A conversion that dropped or shifted every widget value would still pass all three. Asserts distinctive originals survive on the converted subgraph's interior nodes: the seed 156680208700286, 'euler', the checkpoint name, and the positive prompt text. Those are chosen to be shift-sensitive — a value landing on the wrong widget changes its type or content, not just its position. Collects across all subgraphs rather than indexing the first, so there is no dead `if (!subgraph)` guard for the type-aware linter to reject. The interiorValues.length assertion is the real guard against an empty read making the toContain checks vacuous.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe pull request adds an end-to-end migration test for legacy group nodes. The test verifies that converted subgraph nodes preserve 14 widget values, including numeric, sampler, checkpoint, and prompt values. ChangesGroup node migration
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to The added test strengthens legacy group-node migration coverage without introducing an actionable current-head risk. Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (2 inconclusive)
✅ Passed checks (5 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The changed file is available and is under Resolution Provide the PR title and all commit subjects, then reassess whether bug-fix language is present. Based on the available metadata, the PR adds an end-to-end test under Full details: Website End-To-End Regression CoverageExplanation The required PR metadata is incomplete. The changed-file list relative to the base, commit subjects, and diff content are not available in the review context. The summary mentions ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 1944 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 9.92 MB gzip 🟢 -158 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 622 kB (baseline 622 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 26.2 kB (baseline 26.2 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 118 kB (baseline 118 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.69 MB (baseline 3.7 MB) • 🟢 -1.32 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 558 kB (baseline 558 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 18 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.1 MB (baseline 17.1 MB) • ⚪ 0 BBundles that do not match a named category
Status: 72 added / 72 removed / 224 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-11T00:06:28.300Z",
"gitSha": "2cf1fdaac1aefab9e4a3844ad924dee3bcb85dc6",
"branch": "test/group-node-widget-value-migration",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2001.3020000000097,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.188999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.258,
"heapDeltaBytes": 893004,
"heapUsedBytes": 63019884,
"domNodes": -263,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.364,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2022.073999999975,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.237,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.26499999999993,
"heapDeltaBytes": -4709776,
"heapUsedBytes": 57410572,
"domNodes": -265,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 9.479000000000001,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2002.7979999999843,
"styleRecalcs": 79,
"styleRecalcDurationMs": 36.601,
"layouts": 14,
"layoutDurationMs": 4.470999999999999,
"taskDurationMs": 973.1700000000001,
"heapDeltaBytes": 12688920,
"heapUsedBytes": 74790232,
"domNodes": -263,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 190.404,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1849.4550000000345,
"styleRecalcs": 75,
"styleRecalcDurationMs": 29.419,
"layouts": 14,
"layoutDurationMs": 4.231,
"taskDurationMs": 851.652,
"heapDeltaBytes": 11636312,
"heapUsedBytes": 73305164,
"domNodes": -260,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 171.60500000000002,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.2789999999577,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.170000000000005,
"layouts": 6,
"layoutDurationMs": 1.072,
"taskDurationMs": 326.50800000000004,
"heapDeltaBytes": 2130636,
"heapUsedBytes": 64213188,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.352,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.4430000000357,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.178999999999998,
"layouts": 6,
"layoutDurationMs": 0.9349999999999998,
"taskDurationMs": 324.002,
"heapDeltaBytes": 2131060,
"heapUsedBytes": 64391024,
"domNodes": 74,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.824,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 634.0200000000209,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.3549999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.07399999999996,
"heapDeltaBytes": 17905244,
"heapUsedBytes": 80227488,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 169.35399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 641.255000000001,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.152999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.743,
"heapDeltaBytes": 17897972,
"heapUsedBytes": 80071608,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 170.787,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2037.1340000000373,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.303000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 569.7269999999999,
"heapDeltaBytes": 3513580,
"heapUsedBytes": 83026300,
"domNodes": -247,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 39.718,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2033.5280000000466,
"styleRecalcs": 3,
"styleRecalcDurationMs": 7.4069999999999965,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.9309999999999,
"heapDeltaBytes": 3497348,
"heapUsedBytes": 83495668,
"domNodes": -254,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 34.215999999999994,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2299.780999999996,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.309,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1648.971,
"heapDeltaBytes": -388184,
"heapUsedBytes": 79497900,
"domNodes": -250,
"jsHeapTotalBytes": 217088,
"scriptDurationMs": 843.035,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2179.1030000000546,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.422,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1439.4239999999998,
"heapDeltaBytes": 10644524,
"heapUsedBytes": 74804852,
"domNodes": -251,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 835.59,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3451.2640000000374,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.311,
"layouts": 60,
"layoutDurationMs": 11.520000000000001,
"taskDurationMs": 1510.2119999999998,
"heapDeltaBytes": 8393732,
"heapUsedBytes": 74263824,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 784.1320000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3535.6970000000274,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.612999999999998,
"layouts": 60,
"layoutDurationMs": 12.097000000000001,
"taskDurationMs": 1748.478,
"heapDeltaBytes": -15529064,
"heapUsedBytes": 64863976,
"domNodes": -268,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 801.9780000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3116.5260000000217,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.496999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1915.881,
"heapDeltaBytes": 20592588,
"heapUsedBytes": 86471880,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 975.5569999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3120.497999999998,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1944.5959999999998,
"heapDeltaBytes": -6058996,
"heapUsedBytes": 84300036,
"domNodes": -261,
"jsHeapTotalBytes": 1232896,
"scriptDurationMs": 978.448,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2027.86100000003,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.742000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.888,
"heapDeltaBytes": -7988820,
"heapUsedBytes": 79187348,
"domNodes": -257,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 33.647,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2022.2909999999956,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.524,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.6569999999999,
"heapDeltaBytes": -4078720,
"heapUsedBytes": 83214900,
"domNodes": -251,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 31.22399999999999,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 563.3860000000368,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.483,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.59299999999996,
"heapDeltaBytes": 13605784,
"heapUsedBytes": 76824352,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 140.412,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.6059999999516,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.521999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.694,
"heapDeltaBytes": 14025048,
"heapUsedBytes": 77206916,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 144.703,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2018.7260000000151,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.513,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.91799999999995,
"heapDeltaBytes": 839764,
"heapUsedBytes": 64095768,
"domNodes": -272,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.221,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2004.515000000083,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.751,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.20399999999995,
"heapDeltaBytes": 9951680,
"heapUsedBytes": 73011776,
"domNodes": -277,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.5559999999999965,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.6999999999512,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.431000000000004,
"layouts": 18,
"layoutDurationMs": 5.116,
"taskDurationMs": 796.049,
"heapDeltaBytes": 7058656,
"heapUsedBytes": 70249472,
"domNodes": -274,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 114.49000000000001,
"eventListeners": -202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.8949999999786,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.902999999999995,
"layouts": 18,
"layoutDurationMs": 4.630000000000001,
"taskDurationMs": 765.087,
"heapDeltaBytes": 16599560,
"heapUsedBytes": 79769844,
"domNodes": -274,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 110.208,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.411000000061,
"styleRecalcs": 16,
"styleRecalcDurationMs": 28.708,
"layouts": 5,
"layoutDurationMs": 12.828,
"taskDurationMs": 879.2659999999998,
"heapDeltaBytes": 19731788,
"heapUsedBytes": 100355644,
"domNodes": 13587,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 29.941000000000003,
"eventListeners": 2387,
"totalBlockingTimeMs": 143,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8401.452999999947,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.066,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5725.042,
"heapDeltaBytes": -3716408,
"heapUsedBytes": 75464648,
"domNodes": -242,
"jsHeapTotalBytes": -45056,
"scriptDurationMs": 2748.383,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8391.741000000024,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.342999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5795.458,
"heapDeltaBytes": -3838188,
"heapUsedBytes": 75057012,
"domNodes": -250,
"jsHeapTotalBytes": 479232,
"scriptDurationMs": 2782.384,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16693.517999999927,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16179.550000000003,
"heapDeltaBytes": -29766760,
"heapUsedBytes": 178429224,
"domNodes": -6542,
"jsHeapTotalBytes": 16384,
"scriptDurationMs": 298.649,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16779.575999999906,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16249.296,
"heapDeltaBytes": -37427792,
"heapUsedBytes": 164827272,
"domNodes": -6542,
"jsHeapTotalBytes": -405504,
"scriptDurationMs": 262.015,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20569.403999999962,
"styleRecalcs": 172,
"styleRecalcDurationMs": 17.635999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20199.236000000004,
"heapDeltaBytes": -18739136,
"heapUsedBytes": 187674476,
"domNodes": -6542,
"jsHeapTotalBytes": 2510848,
"scriptDurationMs": 918.597,
"eventListeners": -7474,
"totalBlockingTimeMs": 40,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20622.19700000003,
"styleRecalcs": 160,
"styleRecalcDurationMs": 16.575000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20236.066000000003,
"heapDeltaBytes": -31432576,
"heapUsedBytes": 176570936,
"domNodes": -6542,
"jsHeapTotalBytes": -2920448,
"scriptDurationMs": 940.682,
"eventListeners": -7476,
"totalBlockingTimeMs": 66,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4527.843999999959,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.02900000000002,
"layouts": 20,
"layoutDurationMs": 22.935,
"taskDurationMs": 4432.919999999999,
"heapDeltaBytes": -11500792,
"heapUsedBytes": 183578912,
"domNodes": -6546,
"jsHeapTotalBytes": 22130688,
"scriptDurationMs": 92.513,
"eventListeners": -7478,
"totalBlockingTimeMs": 54,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6119.605999999976,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.079,
"layouts": 20,
"layoutDurationMs": 22.84699999999999,
"taskDurationMs": 6002.518999999999,
"heapDeltaBytes": -28602168,
"heapUsedBytes": 171794440,
"domNodes": -6542,
"jsHeapTotalBytes": 8101888,
"scriptDurationMs": 131.878,
"eventListeners": -7476,
"totalBlockingTimeMs": 389,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8483.111000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8293.025000000001,
"heapDeltaBytes": 16092980,
"heapUsedBytes": 194390784,
"domNodes": 0,
"jsHeapTotalBytes": -6291456,
"scriptDurationMs": 134.29999999999998,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8670.816000000059,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8399.755000000001,
"heapDeltaBytes": 1637276,
"heapUsedBytes": 159424516,
"domNodes": 0,
"jsHeapTotalBytes": -3145728,
"scriptDurationMs": 132.19599999999997,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 121.30799999999908,
"styleRecalcs": 9,
"styleRecalcDurationMs": 20.013,
"layouts": 4,
"layoutDurationMs": 2.13,
"taskDurationMs": 96.833,
"heapDeltaBytes": 3164232,
"heapUsedBytes": 64547692,
"domNodes": 113,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.343,
"eventListeners": 35,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 474.378999999999,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.252000000000002,
"layouts": 4,
"layoutDurationMs": 1.8670000000000002,
"taskDurationMs": 118.71000000000001,
"heapDeltaBytes": 5004352,
"heapUsedBytes": 66623748,
"domNodes": 144,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.710999999999999,
"eventListeners": 83,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
| expect( | ||
| interiorValues.length, | ||
| 'converted subgraph should expose interior widgets' | ||
| ).toBeGreaterThan(0) |
There was a problem hiding this comment.
We could probably afford to be more specific here since it's a saved workflow.
| expect(interiorValues).toContain(156680208700286) | ||
| expect(interiorValues).toContain('euler') | ||
| expect(interiorValues).toContain('v1-5-pruned-emaonly.ckpt') |
There was a problem hiding this comment.
We could use arrayContaining here
https://playwright.dev/docs/api/class-genericassertions#generic-assertions-array-containing
There was a problem hiding this comment.
And that could include a stringContaining element
There was a problem hiding this comment.
(I'll make this change, one sec)
There was a problem hiding this comment.
Updated the saved-workflow assertion to require all 14 converted widgets and use arrayContaining, including a stringContaining matcher for the prompt. The focused browser test passes: 3/3.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #17393 +/- ##
==========================================
+ Coverage 81.82% 83.42% +1.59%
==========================================
Files 2518 2090 -428
Lines 128671 121450 -7221
Branches 33260 31734 -1526
==========================================
- Hits 105290 101320 -3970
+ Misses 22847 19951 -2896
+ Partials 534 179 -355
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
DrJKL
left a comment
There was a problem hiding this comment.
The requested assertion cleanup is in place. Verified with the focused Chromium browser test, browser typecheck, lint, formatting, and commit checks.
…-Org#17403) ## Summary Asserts that cycling a link does not accumulate duplicates — Area 4 row 1 of the ECS migration test plan, which has no automated coverage. ## Changes - **What**: one test in `interaction.spec.ts` → `Node Interaction` → `Edge Interaction`. ## Review Focus **Why the existing coverage does not reach this.** `Can disconnect/connect edge normal|reverse` cycles an edge once per direction and asserts by **screenshot** — a second link stacked on the same input renders identically, so accumulation is invisible to it. `graph.spec.ts` → `Deduplicates links without breaking connections on slot-drift workflow` exercises a different path: dedup while *loading corrupt data*, not duplicates produced through the UI. **Two deliberate choices:** 1. **Asserting `graph.links.size` after every half-cycle**, not just at the end. A failure then names the iteration that leaked instead of only reporting a wrong final total. 2. **The run ends disconnected before the reload.** This is the load-bearing detail. Ending *connected* would assert the initial link count — which is also exactly what a pristine default restore produces, so the assertion would pass whether or not the edited draft persisted at all. At `initial - 1`, only a real draft restore can pass. `graph.links` is a `Map`, so `.size` is the count; `graph.spec.ts` already reaches it the same way via `page.evaluate`. Fifth in a series from mining QA plans against the suite: - Comfy-Org#17320 - Comfy-Org#17384 - Comfy-Org#17390 - Comfy-Org#17393 --------- Co-authored-by: Amp <amp@ampcode.com>
…g#17464) ## Summary The test I added in Comfy-Org#17393 **could not fail on the bug it was written for**. This replaces the assertion and pins the real defect QA found. ## Changes - **What**: rewrites `Preserves group node widget values through subgraph conversion` in `groupNode.spec.ts` to assert widget *pairing*, pinned with `test.fail()`. ## Review Focus **Why the old assertion was vacuous.** It flattened every interior widget value into a single array and asserted `arrayContaining([...])` plus `toHaveLength(14)`. Misalignment shuffles values *between* widgets — the multiset is identical and the length is unchanged. It passes on corrupted data. **The bug is real, deterministic, and corrupts files.** QA hit it on 2026-09-10 running the 1.54 plan: converting a v1.3.3 group node shifts widget values two positions, so `denoise` receives `'euler'` and `filename_prefix` receives `'normal'`. On a group node wrapping two samplers, six values land wrong on one node — including strings in numeric fields (`noise_seed = 'enable'`, `end_at_step = 'euler'`) and a number in a combo (`control_after_generate = 0`). Reproduced across 16 loads through the Workflows sidebar, no scripting. **Saving writes the wrong values back to disk**, so the workflow executes with values its author never set. Ground truth from the asset's own `extra.groupNodes`: ``` KSampler -> [156680208700286, 'randomize', 20, 8, 'euler', 'normal', 1] SaveImage -> ['ComfyUI'] ``` So `denoise` is `1` and `filename_prefix` is `'ComfyUI'` — exactly the two QA reported landing wrong. **Now asserts name → value pairing** per interior node, with `toBeDefined()` first so a missing node cannot make `toMatchObject` vacuous. **Pinned with `test.fail()`**, matching `subgraphPromotion.spec.ts:235` and `subgraphConvertAutogrowInputs.spec.ts:124`. CI stays green while the bug exists and flips red the moment the conversion is fixed — which is the signal to delete the marker. Worth deciding separately: this is a silent data-corruption bug on a legacy-workflow path and probably wants its own issue and a fix, not just a pin.
Summary
Asserts that group-node widget values survive the auto-conversion to subgraphs — the legacy-workflow half of #17099 and #15759, which currently has no coverage.
Changes
groupNode.spec.ts→Group node migration.Review Focus
groupNode.spec.tsalready loadsgroupnodes/group_node_v1.3.3, but asserts only three things: group-node instance count, subgraph count, and theextra.groupNodesflag. A conversion that dropped or shifted every widget value would pass all three. That is the hole.The asset carries 14 widget values. The test asserts four distinctive ones survive on the converted subgraph's interior nodes — the seed
156680208700286,'euler', the checkpoint filename, and the positive prompt text. They are picked to be shift-sensitive: if a value lands on the wrong widget its type or content changes, not merely its index, so an off-by-one migration fails rather than silently passing.interiorValues.length > 0is asserted first so an empty read cannot make thetoContainchecks vacuous.Fourth in a series from auditing the 1.53 → 1.54 QA plan against the suite: