Repository navigation
test(keybindings): keep canvas focus after the settings dialog closes - #17384
Conversation
Gap from the 1.53 -> 1.54 QA plan. PR 16401 fixed stale canvas focus after navigation, and nothing asserts it: the suite covers Ctrl+S not falling through to the browser while a dialog is open, but not that shortcuts return to the canvas once a dialog closes. Opens the settings dialog, closes it, presses Ctrl+A, and asserts every node is selected. Reads canvas.selectedItems.size, which is the only observable for selection state — the canvas has no DOM per node in legacy rendering. Asserts the graph has more than one node first, so a graph that failed to load cannot make the selection count match trivially.
🎭 Playwright: ✅ 1947 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.92 MB gzip 🟢 -469 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 622 kB (baseline 622 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 26.2 kB (baseline 26.2 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 4 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 118 kB (baseline 118 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.69 MB (baseline 3.69 MB) • 🔴 +12 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 558 kB (baseline 558 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 20 added / 20 removed / 16 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.1 MB (baseline 17.1 MB) • 🟢 -1.11 kBBundles that do not match a named category
Status: 79 added / 79 removed / 217 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-10T22:56:31.593Z",
"gitSha": "2e67a709bff460e58449a8dc2405f25f0005339e",
"branch": "test/canvas-focus-after-dialog",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2003.9349999999558,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.466000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.648,
"heapDeltaBytes": 16319004,
"heapUsedBytes": 77156236,
"domNodes": -262,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.993,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2005.7620000000043,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.605000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.528,
"heapDeltaBytes": 8353384,
"heapUsedBytes": 70429008,
"domNodes": -264,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.92,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2032.3099999999954,
"styleRecalcs": 78,
"styleRecalcDurationMs": 33.772000000000006,
"layouts": 14,
"layoutDurationMs": 4.392,
"taskDurationMs": 1012.5199999999999,
"heapDeltaBytes": 981532,
"heapUsedBytes": 61898948,
"domNodes": -262,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 188.23000000000002,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1841.1680000000388,
"styleRecalcs": 74,
"styleRecalcDurationMs": 27.984,
"layouts": 14,
"layoutDurationMs": 3.933,
"taskDurationMs": 868.3960000000002,
"heapDeltaBytes": 1583132,
"heapUsedBytes": 63270608,
"domNodes": -264,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 169.02100000000002,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.9280000000049,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.187000000000001,
"layouts": 6,
"layoutDurationMs": 1.012,
"taskDurationMs": 323.66,
"heapDeltaBytes": 2186944,
"heapUsedBytes": 64295264,
"domNodes": 75,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.411,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.0209999999934,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.36,
"layouts": 6,
"layoutDurationMs": 1.008,
"taskDurationMs": 346.324,
"heapDeltaBytes": 2218588,
"heapUsedBytes": 64134368,
"domNodes": 74,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 11.413999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 649.1980000000126,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.683,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.2970000000001,
"heapDeltaBytes": 17934424,
"heapUsedBytes": 79639988,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 167.68800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 627.6709999999639,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.740000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.6599999999999,
"heapDeltaBytes": 17817408,
"heapUsedBytes": 79808532,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 166.28900000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2026.1189999999942,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.773000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.699,
"heapDeltaBytes": 3733420,
"heapUsedBytes": 83379932,
"domNodes": -245,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 32.852000000000004,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2055.6080000000065,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.158999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 616.1089999999999,
"heapDeltaBytes": -1355112,
"heapUsedBytes": 78732868,
"domNodes": -256,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 34.307,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2351.109000000008,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.613,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1696.037,
"heapDeltaBytes": -5110024,
"heapUsedBytes": 75138724,
"domNodes": -249,
"jsHeapTotalBytes": 3100672,
"scriptDurationMs": 855.455,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2229.1470000000118,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.024999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1476.05,
"heapDeltaBytes": 14481312,
"heapUsedBytes": 78627652,
"domNodes": -252,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 847.2669999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3619.0879999999765,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.367999999999999,
"layouts": 60,
"layoutDurationMs": 11.374,
"taskDurationMs": 1745.3339999999998,
"heapDeltaBytes": -9607956,
"heapUsedBytes": 72726576,
"domNodes": -260,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 793.67,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3501.557999999932,
"styleRecalcs": 61,
"styleRecalcDurationMs": 9.950000000000001,
"layouts": 60,
"layoutDurationMs": 11.465,
"taskDurationMs": 1655.742,
"heapDeltaBytes": 8438532,
"heapUsedBytes": 74724324,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 784.6959999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3121.6719999999896,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.116999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1959.9670000000003,
"heapDeltaBytes": 17826832,
"heapUsedBytes": 84090116,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1019.7720000000002,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3098.8820000000032,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.3199999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1867.2640000000001,
"heapDeltaBytes": 15833584,
"heapUsedBytes": 83732324,
"domNodes": 2,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 974.256,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2046.5839999999957,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.781000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 604.066,
"heapDeltaBytes": -7830192,
"heapUsedBytes": 79436924,
"domNodes": -255,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 36.951000000000015,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.2000000000544,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.0889999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.539,
"heapDeltaBytes": 20138344,
"heapUsedBytes": 84007992,
"domNodes": -251,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.499,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.9269999999692,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.573999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.882,
"heapDeltaBytes": 13242492,
"heapUsedBytes": 76577276,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 141.181,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.9179999999878,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.087,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.894,
"heapDeltaBytes": 12988876,
"heapUsedBytes": 76420968,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 146.077,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2004.7989999999913,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.716,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.48600000000005,
"heapDeltaBytes": 10337280,
"heapUsedBytes": 73612288,
"domNodes": -276,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 8.235,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2000.6210000000237,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.877000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.95199999999994,
"heapDeltaBytes": 10479108,
"heapUsedBytes": 73856488,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.363999999999999,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1773.2169999999883,
"styleRecalcs": 78,
"styleRecalcDurationMs": 35.849,
"layouts": 18,
"layoutDurationMs": 4.640999999999999,
"taskDurationMs": 805.7589999999999,
"heapDeltaBytes": -2580092,
"heapUsedBytes": 60886284,
"domNodes": -274,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 112.47600000000001,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.532000000062,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.072999999999997,
"layouts": 18,
"layoutDurationMs": 4.965,
"taskDurationMs": 780.0279999999999,
"heapDeltaBytes": 5679284,
"heapUsedBytes": 68820208,
"domNodes": -277,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 109.651,
"eventListeners": -202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.0440000000171,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.528000000000006,
"layouts": 5,
"layoutDurationMs": 12.993999999999998,
"taskDurationMs": 870.7219999999998,
"heapDeltaBytes": 19721784,
"heapUsedBytes": 100573480,
"domNodes": 13587,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 29.824,
"eventListeners": 2387,
"totalBlockingTimeMs": 143,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8305.675999999949,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.30899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5721.701999999999,
"heapDeltaBytes": 11452632,
"heapUsedBytes": 75188104,
"domNodes": -248,
"jsHeapTotalBytes": 2060288,
"scriptDurationMs": 2728.1809999999996,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8457.839000000036,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.493,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5851.601,
"heapDeltaBytes": -13385396,
"heapUsedBytes": 65798960,
"domNodes": -225,
"jsHeapTotalBytes": 1826816,
"scriptDurationMs": 2855.5229999999997,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16851.022999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16310.203000000001,
"heapDeltaBytes": -39966632,
"heapUsedBytes": 168162032,
"domNodes": -6542,
"jsHeapTotalBytes": 2899968,
"scriptDurationMs": 291.362,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12979.498000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12175.624,
"heapDeltaBytes": -24420112,
"heapUsedBytes": 184240980,
"domNodes": -6542,
"jsHeapTotalBytes": -3084288,
"scriptDurationMs": 224.64300000000003,
"eventListeners": -7480,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20674.507000000005,
"styleRecalcs": 171,
"styleRecalcDurationMs": 17.228999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20247.882,
"heapDeltaBytes": -17341272,
"heapUsedBytes": 176925468,
"domNodes": -6543,
"jsHeapTotalBytes": 2289664,
"scriptDurationMs": 954.5729999999999,
"eventListeners": -7472,
"totalBlockingTimeMs": 36,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20785.331999999926,
"styleRecalcs": 161,
"styleRecalcDurationMs": 17.41100000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20548.833000000002,
"heapDeltaBytes": -24171000,
"heapUsedBytes": 176899176,
"domNodes": -6542,
"jsHeapTotalBytes": 1064960,
"scriptDurationMs": 951.5619999999999,
"eventListeners": -7476,
"totalBlockingTimeMs": 9,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5952.715000000012,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.61100000000005,
"layouts": 20,
"layoutDurationMs": 22.273,
"taskDurationMs": 5838.812000000001,
"heapDeltaBytes": -29807652,
"heapUsedBytes": 172464464,
"domNodes": -6546,
"jsHeapTotalBytes": 15437824,
"scriptDurationMs": 112.66099999999999,
"eventListeners": -7478,
"totalBlockingTimeMs": 325,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6210.427999999979,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.84199999999997,
"layouts": 20,
"layoutDurationMs": 24.885000000000005,
"taskDurationMs": 6113.741999999999,
"heapDeltaBytes": -9081524,
"heapUsedBytes": 191961868,
"domNodes": -6542,
"jsHeapTotalBytes": 17317888,
"scriptDurationMs": 118.714,
"eventListeners": -7476,
"totalBlockingTimeMs": 473,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8402.166999999963,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8157.195,
"heapDeltaBytes": 9959752,
"heapUsedBytes": 181263372,
"domNodes": 0,
"jsHeapTotalBytes": -2359296,
"scriptDurationMs": 131.42900000000003,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8609.637999999904,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8397.389,
"heapDeltaBytes": -10463196,
"heapUsedBytes": 179418092,
"domNodes": 0,
"jsHeapTotalBytes": -2359296,
"scriptDurationMs": 129.926,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 473.18500000000085,
"styleRecalcs": 21,
"styleRecalcDurationMs": 26.093999999999998,
"layouts": 5,
"layoutDurationMs": 2.061,
"taskDurationMs": 133.97500000000002,
"heapDeltaBytes": 5253632,
"heapUsedBytes": 66994088,
"domNodes": 151,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 16.305,
"eventListeners": 83,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 124.93599999993421,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.262999999999998,
"layouts": 2,
"layoutDurationMs": 1.163,
"taskDurationMs": 90.23500000000001,
"heapDeltaBytes": 3016488,
"heapUsedBytes": 64697888,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.08,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThis change adds an end-to-end test for selecting all canvas nodes with ChangesCanvas keyboard selection
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to The added regression test does not introduce an actionable merge risk. Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The available context identifies a change under ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #17384 +/- ##
==========================================
+ Coverage 81.82% 83.38% +1.55%
==========================================
Files 2518 2090 -428
Lines 128671 121413 -7258
Branches 33260 31674 -1586
==========================================
- Hits 105290 101237 -4053
+ Misses 22847 19997 -2850
+ Partials 534 179 -355
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…omfy-Org#17393) ## Summary Asserts that group-node widget values survive the auto-conversion to subgraphs — the legacy-workflow half of Comfy-Org#17099 and Comfy-Org#15759, which currently has no coverage. ## Changes - **What**: one test in `groupNode.spec.ts` → `Group node migration`. ## Review Focus `groupNode.spec.ts` already loads `groupnodes/group_node_v1.3.3`, but asserts only three things: group-node instance count, subgraph count, and the `extra.groupNodes` flag. **A conversion that dropped or shifted every widget value would pass all three.** That is the hole. The asset carries 14 widget values. The test asserts four distinctive ones survive on the converted subgraph's interior nodes — the seed `156680208700286`, `'euler'`, the checkpoint filename, and the positive prompt text. They are picked to be *shift-sensitive*: if a value lands on the wrong widget its type or content changes, not merely its index, so an off-by-one migration fails rather than silently passing. `interiorValues.length > 0` is asserted first so an empty read cannot make the `toContain` checks vacuous. Fourth in a series from auditing the 1.53 → 1.54 QA plan against the suite: - Comfy-Org#17320 - Comfy-Org#17384 - Comfy-Org#17390 --------- Co-authored-by: Amp <amp@ampcode.com>
Comfy-Org#17390) ## Summary Exercises the duplicate node-instance invariants added by Comfy-Org#14256. `copyPaste.spec.ts` only ever pastes once, so nothing in the suite drives the code path those invariants guard. ## Changes - **What**: one test in `copyPaste.spec.ts` → `Copy Paste`. ## Review Focus **Why identity and not just a count.** A count-only assertion still passes if the same instance is added twice under one id — which is precisely the failure `LGraph.add/remove` now guards against. So the test checks both `new Set(graph.nodes).size` and the unique node-ID count against the expected node count after the pastes. **Why the count is checked inside the loop.** Asserting only the final total tells you it broke, not where. Checking after each paste means a failure names the iteration. `page.evaluate` for node identity and IDs: legacy canvas rendering exposes no per-node DOM, so there is no locator-based route to graph state. `fitToView.ts` and `boundsUtils.ts` reach it the same way. Third in a series from auditing the 1.53 → 1.54 QA plan against the suite: - Comfy-Org#17320 - Comfy-Org#17384 --------- Co-authored-by: Amp <amp@ampcode.com>
…-Org#17403) ## Summary Asserts that cycling a link does not accumulate duplicates — Area 4 row 1 of the ECS migration test plan, which has no automated coverage. ## Changes - **What**: one test in `interaction.spec.ts` → `Node Interaction` → `Edge Interaction`. ## Review Focus **Why the existing coverage does not reach this.** `Can disconnect/connect edge normal|reverse` cycles an edge once per direction and asserts by **screenshot** — a second link stacked on the same input renders identically, so accumulation is invisible to it. `graph.spec.ts` → `Deduplicates links without breaking connections on slot-drift workflow` exercises a different path: dedup while *loading corrupt data*, not duplicates produced through the UI. **Two deliberate choices:** 1. **Asserting `graph.links.size` after every half-cycle**, not just at the end. A failure then names the iteration that leaked instead of only reporting a wrong final total. 2. **The run ends disconnected before the reload.** This is the load-bearing detail. Ending *connected* would assert the initial link count — which is also exactly what a pristine default restore produces, so the assertion would pass whether or not the edited draft persisted at all. At `initial - 1`, only a real draft restore can pass. `graph.links` is a `Map`, so `.size` is the count; `graph.spec.ts` already reaches it the same way via `page.evaluate`. Fifth in a series from mining QA plans against the suite: - Comfy-Org#17320 - Comfy-Org#17384 - Comfy-Org#17390 - Comfy-Org#17393 --------- Co-authored-by: Amp <amp@ampcode.com>
Summary
Adds the missing assertion that keyboard shortcuts return to the canvas once a dialog closes — the fix from #16401 (stale canvas focus after navigation) has no test behind it.
Changes
defaultKeybindings.spec.ts→Graph Operations.Review Focus
defaultKeybindings.spec.tscovers the opposite direction —'Ctrl+s' does not fall through to the browser while a dialog is open— but nothing covers focus coming back. So today a regression that left focus stranded on a closed dialog would pass the suite.Two deliberate choices worth checking:
canvas.selectedItems.sizeviapage.evaluate. Legacy canvas rendering has no per-node DOM, so there is no locator-based observable for selection state.fitToView.tsandboundsUtils.tsalready readselectedItemsthe same way.nodeCount > 1first. Without it, a graph that failed to load would make the selection count match trivially at 0 and the test would pass green while asserting nothing.Found by auditing the 1.53 → 1.54 QA test plan against the suite. Second in a series; the first is #17320.