Repository navigation
test: migrate core and state mocks to import() - #17179
Conversation
|
Warning Review limit reachedNext included review available in 1 minute. View limit detailsLimit details: You’ve used all 8 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (81)
Comment |
…e-state Amp-Thread-ID: https://ampcode.com/threads/T-01a08249-8d16-7400-bfa7-360b81ce37c8 # Conflicts: # src/stores/__tests__/authTokenPriority.test.ts # src/stores/apiKeyAuthStore.integration.test.ts # src/stores/authStore.test.ts
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1917 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 9.83 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 128 kB (baseline 128 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 28.9 kB (baseline 28.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.63 MB (baseline 3.63 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 559 kB (baseline 559 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.8 MB (baseline 16.8 MB) • ⚪ 0 BBundles that do not match a named category Status: 297 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-08T19:35:22.529Z",
"gitSha": "06609b43c9489e4677555b3999d4810ed0b50d2c",
"branch": "test/import-mocks-core-state",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2036.6390000000365,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.581999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.94300000000004,
"heapDeltaBytes": -6265896,
"heapUsedBytes": 63054040,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.512999999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2051.4819999999645,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.216999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.626,
"heapDeltaBytes": 2933332,
"heapUsedBytes": 73770340,
"domNodes": -283,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.2989999999999995,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2058.821000000023,
"styleRecalcs": 81,
"styleRecalcDurationMs": 41.69299999999999,
"layouts": 14,
"layoutDurationMs": 4.5729999999999995,
"taskDurationMs": 988.6320000000001,
"heapDeltaBytes": -1615960,
"heapUsedBytes": 67714852,
"domNodes": -276,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 175.518,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1815.2919999999995,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.208,
"layouts": 14,
"layoutDurationMs": 4.316999999999999,
"taskDurationMs": 871.9519999999999,
"heapDeltaBytes": -8517464,
"heapUsedBytes": 62006212,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 158.852,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.3590000000122,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.046999999999997,
"layouts": 6,
"layoutDurationMs": 1.1029999999999998,
"taskDurationMs": 336.3929999999999,
"heapDeltaBytes": 4643404,
"heapUsedBytes": 75181372,
"domNodes": 76,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 12.597000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.8439999999327,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.053,
"layouts": 6,
"layoutDurationMs": 0.954,
"taskDurationMs": 340.11800000000005,
"heapDeltaBytes": 4954296,
"heapUsedBytes": 75258936,
"domNodes": 77,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 9.632000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 623.8109999999892,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.119999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.654,
"heapDeltaBytes": 18954968,
"heapUsedBytes": 88824488,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 161.05,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 630.8289999999488,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.460000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.584,
"heapDeltaBytes": 18962176,
"heapUsedBytes": 88570672,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 164.38599999999997,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2043.0519999999888,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.959999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 590.942,
"heapDeltaBytes": 10314116,
"heapUsedBytes": 86860996,
"domNodes": -267,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 30.206999999999997,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2041.6310000000522,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.592999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.0659999999999,
"heapDeltaBytes": 11446436,
"heapUsedBytes": 86842524,
"domNodes": -268,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 30.954999999999995,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2217.5929999999653,
"styleRecalcs": 62,
"styleRecalcDurationMs": 7.9590000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1564.393,
"heapDeltaBytes": 20727364,
"heapUsedBytes": 87104588,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 792.982,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2202.3880000000418,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.437000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1580,
"heapDeltaBytes": 9007976,
"heapUsedBytes": 85564648,
"domNodes": -274,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 798.64,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3526.276999999993,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.491,
"layouts": 60,
"layoutDurationMs": 11.671000000000001,
"taskDurationMs": 1646.0400000000002,
"heapDeltaBytes": 10249992,
"heapUsedBytes": 76115768,
"domNodes": -283,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 759.908,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3492.587999999955,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.406999999999998,
"layouts": 60,
"layoutDurationMs": 11.580999999999998,
"taskDurationMs": 1636.682,
"heapDeltaBytes": 8210536,
"heapUsedBytes": 75913152,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 765.632,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3088.0619999999794,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.084000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1891.899,
"heapDeltaBytes": 22250392,
"heapUsedBytes": 90287968,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 953.7489999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2998.3479999999645,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.577000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1844.6699999999998,
"heapDeltaBytes": 21712028,
"heapUsedBytes": 88991952,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 922.1949999999998,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2033.7330000000406,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.9569999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.176,
"heapDeltaBytes": 10101152,
"heapUsedBytes": 87431176,
"domNodes": -271,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 30.314999999999994,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2036.3660000000436,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.774000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.162,
"heapDeltaBytes": 10166916,
"heapUsedBytes": 87529716,
"domNodes": -267,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 32.953,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 578.6860000000047,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.48299999999995,
"heapDeltaBytes": 14020140,
"heapUsedBytes": 86419232,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 136.08100000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.8790000000336,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.663,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.508,
"heapDeltaBytes": 14447168,
"heapUsedBytes": 86759148,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 138.31500000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.191999999966,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.710999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.52699999999993,
"heapDeltaBytes": 569064,
"heapUsedBytes": 66472200,
"domNodes": -293,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.600000000000001,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2001.1690000000044,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.238999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.054,
"heapDeltaBytes": 692984,
"heapUsedBytes": 73901044,
"domNodes": -295,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 6.560999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.912000000008,
"styleRecalcs": 78,
"styleRecalcDurationMs": 35.254,
"layouts": 18,
"layoutDurationMs": 4.466,
"taskDurationMs": 799.648,
"heapDeltaBytes": -2424604,
"heapUsedBytes": 70004708,
"domNodes": -292,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 107.69999999999999,
"eventListeners": -222,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.5939999999346,
"styleRecalcs": 79,
"styleRecalcDurationMs": 34.363,
"layouts": 18,
"layoutDurationMs": 4.751999999999999,
"taskDurationMs": 803.412,
"heapDeltaBytes": -3759932,
"heapUsedBytes": 68524520,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 107.66000000000001,
"eventListeners": -222,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.500999999963,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.535999999999994,
"layouts": 15,
"layoutDurationMs": 15.279000000000002,
"taskDurationMs": 892.2299999999999,
"heapDeltaBytes": -7374380,
"heapUsedBytes": 86932544,
"domNodes": 13751,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 31.442999999999998,
"eventListeners": 2385,
"totalBlockingTimeMs": 144,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8328.044999999975,
"styleRecalcs": 247,
"styleRecalcDurationMs": 35.081,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5611.946000000001,
"heapDeltaBytes": -15937452,
"heapUsedBytes": 85812612,
"domNodes": -269,
"jsHeapTotalBytes": -364544,
"scriptDurationMs": 2622.579,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8370.863999999983,
"styleRecalcs": 247,
"styleRecalcDurationMs": 33.92,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5592.314,
"heapDeltaBytes": 14161568,
"heapUsedBytes": 89762064,
"domNodes": -269,
"jsHeapTotalBytes": 385024,
"scriptDurationMs": 2633.789,
"eventListeners": -158,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16141.258999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15102.578999999998,
"heapDeltaBytes": -35212160,
"heapUsedBytes": 175451968,
"domNodes": -6548,
"jsHeapTotalBytes": 2609152,
"scriptDurationMs": 242.107,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16056.408000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15135.915999999997,
"heapDeltaBytes": -33466780,
"heapUsedBytes": 176537380,
"domNodes": -6548,
"jsHeapTotalBytes": 4444160,
"scriptDurationMs": 249.083,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20034.911999999964,
"styleRecalcs": 164,
"styleRecalcDurationMs": 16.531000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19772.324999999997,
"heapDeltaBytes": -19309436,
"heapUsedBytes": 190905856,
"domNodes": -6548,
"jsHeapTotalBytes": -6799360,
"scriptDurationMs": 881.393,
"eventListeners": -7471,
"totalBlockingTimeMs": 29,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20668.127000000026,
"styleRecalcs": 170,
"styleRecalcDurationMs": 16.03600000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20187.945,
"heapDeltaBytes": -28113224,
"heapUsedBytes": 177218400,
"domNodes": -6548,
"jsHeapTotalBytes": 2375680,
"scriptDurationMs": 896.5160000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 26,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5920.694000000026,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.13300000000001,
"layouts": 20,
"layoutDurationMs": 21.62900000000001,
"taskDurationMs": 5769.820999999999,
"heapDeltaBytes": -25025840,
"heapUsedBytes": 180827324,
"domNodes": -6548,
"jsHeapTotalBytes": 13934592,
"scriptDurationMs": 101.605,
"eventListeners": -7473,
"totalBlockingTimeMs": 361,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5864.978999999948,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.94300000000004,
"layouts": 20,
"layoutDurationMs": 21.419000000000008,
"taskDurationMs": 5776.226000000001,
"heapDeltaBytes": -29242116,
"heapUsedBytes": 182276392,
"domNodes": -6548,
"jsHeapTotalBytes": 8654848,
"scriptDurationMs": 97.71600000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 347,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8278.770000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7700.651000000001,
"heapDeltaBytes": 3730016,
"heapUsedBytes": 169680648,
"domNodes": 0,
"jsHeapTotalBytes": -12058624,
"scriptDurationMs": 113.91400000000002,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8211.914000000092,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7759.2300000000005,
"heapDeltaBytes": 19071700,
"heapUsedBytes": 179706308,
"domNodes": 0,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 120.07599999999996,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 114.47999999995773,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.86,
"layouts": 2,
"layoutDurationMs": 1.399,
"taskDurationMs": 77.10699999999999,
"heapDeltaBytes": 3101856,
"heapUsedBytes": 71290088,
"domNodes": 129,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.8629999999999995,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 454.1989999999032,
"styleRecalcs": 18,
"styleRecalcDurationMs": 17.227,
"layouts": 2,
"layoutDurationMs": 0.975,
"taskDurationMs": 91.689,
"heapDeltaBytes": 4931760,
"heapUsedBytes": 72545024,
"domNodes": 144,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.578999999999999,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #17179 +/- ##
==========================================
+ Coverage 81.51% 82.97% +1.45%
==========================================
Files 2494 2057 -437
Lines 127769 119941 -7828
Branches 34743 32848 -1895
==========================================
- Hits 104150 99518 -4632
+ Misses 23099 20243 -2856
+ Partials 520 180 -340
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Current-head verification for Evidence: focused Vitest result |
huang47
left a comment
There was a problem hiding this comment.
Approved at current head b8e905dd1bba639886548ebf1eaed1a4c3d01e7c. Focused verification evidence: #17179 (comment)
Conflicts were the vi.mock import() migration from #17179: main moved vi.mock('path', factory) to vi.mock<unknown>(import('path'), factory) codebase-wide while this branch added mocks in the old string form. Resolved by adopting main's import() syntax with this branch's factory bodies. The settingStore mock keeps this branch's self-contained { get: vi.fn(() => false) } stub rather than main's bare vi.fn(), whose return value was set by the Comfy.Assets.UseAssetAPI scaffolding in enableMocks that this PR removes.
All four conflicts came from the upstream vi.mock import() migration series (#17172-#17179). Resolved by adopting main's vi.mock<unknown>(import(...)) syntax while keeping this branch's factory bodies. In assetService.test.ts and useComboWidget.test.ts the merge base had a settingStore mock that this branch deletes along with the Comfy.Assets.UseAssetAPI setting; main only migrated its syntax. The deletion is kept and only the neighbouring mock adopts the new form.
…assets flag, retire Comfy.Assets.UseAssetAPI (#18727) Manual backport of #17117 to `core/1.54`. The automated backport failed with merge conflicts (#17117 (comment)). Cherry-picked from dffad2d (`git cherry-pick -x`). ## Why #17117 retires the hidden `Comfy.Assets.UseAssetAPI` setting and the `Comfy.ToggleAssetAPI` command. The model library, sidebar tab and model store follow `useFeatureFlags().flags.assetsEnabled` (cloud, or the server advertises the `assets` feature). `Comfy.BrowseModelAssets` opens the browser through `openModelLibraryBrowser()`, and the widget asset-picker gate is renamed to `shouldUseWidgetAssetPicker` / `isWidgetAssetPickerEnabled` and fixed to `isCloud`. Without it, a stale persisted setting can still route the model library to `/api/assets` on a backend that doesn't serve it. ## Dependency check The bot flagged a possible stacking conflict with #18722, #18683, #18334 and #17872. None of the four touch any file changed by #17117, so they aren't the cause. The conflicts are real and come from main-only test refactors that aren't on `core/1.54`: the `vi.mock(import(...))` migrations (#17173, #17175, #17176, #17178, #17179) and the global-Pinia test migrations (#17231, #17234, #17235, #17236, #17237, #17270), plus #16891. All production code, locale, script and e2e changes applied cleanly. ## Conflict resolution All 7 conflicts were in unit tests. Each one keeps `core/1.54`'s mocking style (hoisted `vi.mock` stores, no global Pinia) and ports only the setting-to-flag change: - `src/components/sidebar/tabs/ModelLibrarySidebarTab.test.ts`: kept the target's store/download/setting mocks. Dropped the `Comfy.Assets.UseAssetAPI` branch and added a `useFeatureFlags` mock (`featureFlagState.assetsEnabled`) in its place. - `src/composables/useCoreCommands.test.ts`: kept the target's mocks and `createMockSettingStore`. Added the `useFeatureFlags` mock. The `BrowseModelAssets` tests toggle `assetsEnabled` instead of the setting. - `src/platform/assets/services/assetService.test.ts`: kept the target's imports and mocks. Took the rename to `shouldUseWidgetAssetPicker` and removed the setting-store mock. - `src/platform/assets/utils/assetPreviewUtil.test.ts`: kept the target's `vi.mock` style. Added the `useFeatureFlags` mock and removed the `isAssetAPIEnabled` / `getServerFeature` mocks. - `src/renderer/extensions/vueNodes/widgets/composables/useComboWidget.test.ts`: kept the target's two remote-combo tests, which are absent on main. Took the renamed test and the `shouldUseWidgetAssetPicker` mock. - `src/stores/modelStore.test.ts`: kept the target's `mockDistribution` mock. Took #17117's `remoteConfig` holder mock and reactive `serverFeatures` state, so the store's flag watcher fires and state doesn't leak between tests. - `src/stores/workspace/sidebarTabStore.test.ts`: kept the target's command/menu/setting store mocks. Added the `useFeatureFlags` and `openModelLibraryBrowser` mocks and dropped the `Comfy.Assets.UseAssetAPI` setting reads. No other changes from main are included. ## Validation - Static check: no remaining `Comfy.Assets.UseAssetAPI`, `isAssetAPIEnabled`, `shouldUseAssetBrowser`, `ToggleAssetAPI` or `usesAssetApi` references in `src`, `browser_tests`, `scripts` or `.github`. - `pnpm install --frozen-lockfile`: ok - `pnpm typecheck`: clean - `eslint`, `oxlint`, `oxfmt --check` on changed files: 0 errors - `vitest run` on the touched tests plus `src/stores`, `src/platform/assets`, `src/components/sidebar` and `src/composables/useFeatureFlags*`: 129 files, 2339 passed - `vitest run` on `scripts/checkAssetsFlagArtifact.test.ts`, `widgetInputs`, `missingModelPipeline`, `src/renderer/extensions/vueNodes/widgets` and `useCoreCommands`: 66 files, 960 passed - `vite build` followed by `EXPECTED_DISTRIBUTION=localhost EXPECTED_FRONTEND_COMMIT=<HEAD> pnpm test:assets-flag-artifact`: pass - Local e2e against a real ComfyUI backend without `--enable-assets` (`/api/features` reports `assets: false`), with a temporary request guard that is not included in this PR: - A walk of the sidebars, model library refresh, asset/model commands, missing-model workflows, upload and run, the assets sidebar, linear mode and vue-node dropdowns: 10/10 passed. This covered a user with a stale persisted `Comfy.Assets.UseAssetAPI=true`. No `/api/assets*` requests were made. - `browser_tests/tests/sidebar/modelLibrary.spec.ts`: 13/13 passed with no `/api/assets*` requests.
Summary
Migrates legacy
vi.mockcalls in core, service, store, and utility tests to the dynamicimport()form as an independent slice of #16174.Changes
<unknown>to preserve the string overload's existing type contract.Review Focus
This is a mechanical syntax migration. The lint rule and documentation are intentionally deferred until every domain slice has merged.
Verified with the full pre-commit lint/typecheck gates,
pnpm knip, and the combined unit suite (1,506 files; 20,337 passed).