Repository navigation
test: migrate asset and workflow mocks to import() - #17173
Conversation
🎭 Playwright: ✅ 1922 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.83 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 128 kB (baseline 128 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 622 kB (baseline 622 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 28.9 kB (baseline 28.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 118 kB (baseline 118 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.63 MB (baseline 3.63 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 557 kB (baseline 557 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.8 MB (baseline 16.8 MB) • ⚪ 0 BBundles that do not match a named category Status: 297 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-08T22:02:25.566Z",
"gitSha": "b1f53892ae890624d71cbf99ee1392acfaa1955c",
"branch": "test/import-mocks-platform-assets-workflow",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2040.6900000000405,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.573999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.52400000000006,
"heapDeltaBytes": -5190824,
"heapUsedBytes": 56007696,
"domNodes": -266,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 9.316999999999998,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2017.7960000000326,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.639000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.18899999999996,
"heapDeltaBytes": 15375844,
"heapUsedBytes": 76671576,
"domNodes": -266,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 7.929000000000002,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2067.816999999991,
"styleRecalcs": 81,
"styleRecalcDurationMs": 34.446,
"layouts": 14,
"layoutDurationMs": 5.049,
"taskDurationMs": 986.332,
"heapDeltaBytes": 18464436,
"heapUsedBytes": 80432904,
"domNodes": -265,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 187.842,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1914.799999999957,
"styleRecalcs": 74,
"styleRecalcDurationMs": 27.657,
"layouts": 14,
"layoutDurationMs": 4.1339999999999995,
"taskDurationMs": 866.4860000000001,
"heapDeltaBytes": 9320208,
"heapUsedBytes": 71090024,
"domNodes": -259,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 165.25900000000001,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1698.3849999999734,
"styleRecalcs": 29,
"styleRecalcDurationMs": 15.583000000000002,
"layouts": 6,
"layoutDurationMs": 1.1060000000000003,
"taskDurationMs": 334.86599999999993,
"heapDeltaBytes": 2163104,
"heapUsedBytes": 63805136,
"domNodes": 75,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 10.668000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.737000000062,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.06,
"layouts": 6,
"layoutDurationMs": 1.166,
"taskDurationMs": 361.72600000000006,
"heapDeltaBytes": 2139964,
"heapUsedBytes": 63939716,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 12.371,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 657.9460000000381,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.697000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.7169999999999,
"heapDeltaBytes": 18053360,
"heapUsedBytes": 79324796,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 177.112,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 672.2599999999943,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.177999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.83699999999993,
"heapDeltaBytes": 17884536,
"heapUsedBytes": 79820668,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 165.669,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2034.5780000000104,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.327,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 612.9530000000001,
"heapDeltaBytes": -12145764,
"heapUsedBytes": 80572296,
"domNodes": -247,
"jsHeapTotalBytes": 5009408,
"scriptDurationMs": 37.705000000000005,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2045.6859999999324,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.897999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 596.145,
"heapDeltaBytes": 8550180,
"heapUsedBytes": 81996284,
"domNodes": -250,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 37.813,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2380.493999999999,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.328999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1643.5359999999996,
"heapDeltaBytes": -16867668,
"heapUsedBytes": 78698556,
"domNodes": -248,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 838.026,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2203.2580000000053,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.084999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1644.6080000000004,
"heapDeltaBytes": 14286560,
"heapUsedBytes": 78082044,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 830.1550000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3454.6510000000126,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.029,
"layouts": 60,
"layoutDurationMs": 11.304,
"taskDurationMs": 1627.3849999999998,
"heapDeltaBytes": 10121308,
"heapUsedBytes": 74414712,
"domNodes": -254,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 760.2840000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3602.0039999999653,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.777000000000003,
"layouts": 60,
"layoutDurationMs": 12.285999999999998,
"taskDurationMs": 1712.698,
"heapDeltaBytes": 9779068,
"heapUsedBytes": 74144820,
"domNodes": -254,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 782.234,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3131.2939999999685,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.804999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1901.042,
"heapDeltaBytes": 20152032,
"heapUsedBytes": 85707656,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 965.9000000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3163.5689999999386,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.8130000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1956.5769999999998,
"heapDeltaBytes": 22275512,
"heapUsedBytes": 88121264,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 984.453,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2028.1779999999685,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.883000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.8080000000001,
"heapDeltaBytes": 8655872,
"heapUsedBytes": 82745312,
"domNodes": -251,
"jsHeapTotalBytes": -1581056,
"scriptDurationMs": 30.889,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2005.0099999999702,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.8919999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.4669999999999,
"heapDeltaBytes": 19663648,
"heapUsedBytes": 83635172,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.059999999999995,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.787999999975,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.434,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.36499999999995,
"heapDeltaBytes": 13989852,
"heapUsedBytes": 76417700,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 149.684,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 611.6550000000416,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.411,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.07400000000007,
"heapDeltaBytes": 13973356,
"heapUsedBytes": 76587112,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 154.48700000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2016.0710000000108,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.76,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.69599999999997,
"heapDeltaBytes": -3410000,
"heapUsedBytes": 58992944,
"domNodes": -275,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.127000000000002,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2000.7410000000618,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.48,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.52700000000004,
"heapDeltaBytes": 18544944,
"heapUsedBytes": 80980224,
"domNodes": -278,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.931000000000001,
"eventListeners": -202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.8059999999914,
"styleRecalcs": 78,
"styleRecalcDurationMs": 30.226,
"layouts": 18,
"layoutDurationMs": 5.2379999999999995,
"taskDurationMs": 811.245,
"heapDeltaBytes": -3435060,
"heapUsedBytes": 58277808,
"domNodes": -273,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 116.043,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.5199999999786,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.931,
"layouts": 18,
"layoutDurationMs": 5.572,
"taskDurationMs": 826.005,
"heapDeltaBytes": 7164304,
"heapUsedBytes": 69945888,
"domNodes": -276,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 116.18299999999999,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.9019999999541,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.235000000000003,
"layouts": 5,
"layoutDurationMs": 13.236999999999998,
"taskDurationMs": 884.6609999999997,
"heapDeltaBytes": 20204440,
"heapUsedBytes": 101422296,
"domNodes": 13747,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 29.396000000000004,
"eventListeners": 2387,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8352.836000000025,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.406,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5775.53,
"heapDeltaBytes": -13879300,
"heapUsedBytes": 81312696,
"domNodes": -246,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 2804.054,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8277.754999999957,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.484,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5378.232000000001,
"heapDeltaBytes": -19939196,
"heapUsedBytes": 75447900,
"domNodes": -247,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 2830.4739999999997,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17346.242000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16727.838000000003,
"heapDeltaBytes": -27835688,
"heapUsedBytes": 172453456,
"domNodes": -6542,
"jsHeapTotalBytes": 1064960,
"scriptDurationMs": 296.026,
"eventListeners": -7481,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17379.70000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16788.812,
"heapDeltaBytes": -34403628,
"heapUsedBytes": 172248880,
"domNodes": -6542,
"jsHeapTotalBytes": -4038656,
"scriptDurationMs": 313.47200000000004,
"eventListeners": -7476,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21006.974000000013,
"styleRecalcs": 172,
"styleRecalcDurationMs": 18.02300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20652.057,
"heapDeltaBytes": -33604636,
"heapUsedBytes": 174390632,
"domNodes": -6541,
"jsHeapTotalBytes": -6991872,
"scriptDurationMs": 910.287,
"eventListeners": -7474,
"totalBlockingTimeMs": 205,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21148.220000000038,
"styleRecalcs": 163,
"styleRecalcDurationMs": 19.120000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20812.809,
"heapDeltaBytes": -31439728,
"heapUsedBytes": 174746232,
"domNodes": -6542,
"jsHeapTotalBytes": -2031616,
"scriptDurationMs": 920.3569999999999,
"eventListeners": -7472,
"totalBlockingTimeMs": 67,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6116.444999999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 86.49199999999996,
"layouts": 20,
"layoutDurationMs": 23.525000000000006,
"taskDurationMs": 5966.5960000000005,
"heapDeltaBytes": -31396544,
"heapUsedBytes": 173194316,
"domNodes": -6542,
"jsHeapTotalBytes": 12554240,
"scriptDurationMs": 130.085,
"eventListeners": -7476,
"totalBlockingTimeMs": 380,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6230.838999999946,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.06999999999998,
"layouts": 20,
"layoutDurationMs": 23.041000000000007,
"taskDurationMs": 6093.966,
"heapDeltaBytes": -31010384,
"heapUsedBytes": 176563528,
"domNodes": -6542,
"jsHeapTotalBytes": 9105408,
"scriptDurationMs": 113.86800000000002,
"eventListeners": -7476,
"totalBlockingTimeMs": 357,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8375.21899999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8187.275999999999,
"heapDeltaBytes": -7400560,
"heapUsedBytes": 172613992,
"domNodes": 0,
"jsHeapTotalBytes": -18874368,
"scriptDurationMs": 151.54899999999998,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8921.613999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8589.424,
"heapDeltaBytes": 20422920,
"heapUsedBytes": 174402616,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 146.69199999999992,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 451.56800000000885,
"styleRecalcs": 15,
"styleRecalcDurationMs": 20.989,
"layouts": 3,
"layoutDurationMs": 0.861,
"taskDurationMs": 101.93299999999999,
"heapDeltaBytes": 4613816,
"heapUsedBytes": 65897648,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.631000000000002,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 470.9739999999556,
"styleRecalcs": 18,
"styleRecalcDurationMs": 21.682,
"layouts": 3,
"layoutDurationMs": 1.611,
"taskDurationMs": 114.796,
"heapDeltaBytes": 4708120,
"heapUsedBytes": 65984556,
"domNodes": 142,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.124999999999998,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (54)
Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe changes migrate Vitest mocks across asset and workflow tests from string module paths to typed dynamic-import forms. Mock implementations and test behavior remain unchanged. ChangesTyped Vitest mock migration
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change updates test mocks to typed dynamic-import syntax without changing application behavior or mocked test contracts. No current merge-readiness risk remains. Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The available metadata identifies changed files and provides the PR description, but it does not provide the PR title or commit subjects. The check requires those fields to determine whether bug-fix language is present. The description states that this is a mechanical Resolution Provide the PR title and commit subjects. If neither contains bug-fix language, pass the check. If bug-fix language is present, verify that the PR changes a ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #17173 +/- ##
==========================================
+ Coverage 81.60% 83.04% +1.44%
==========================================
Files 2501 2058 -443
Lines 127856 119990 -7866
Branches 34794 31078 -3716
==========================================
- Hits 104333 99645 -4688
+ Misses 23000 20164 -2836
+ Partials 523 181 -342
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
AustinMroz
left a comment
There was a problem hiding this comment.
Kicked off some internal discussions on followups with i18n and restricted import paths, but the changes here are fine.
…tform-assets-workflow Amp-Thread-ID: https://ampcode.com/threads/T-01a08249-8d16-7400-bfa7-360b81ce37c8 # Conflicts: # src/platform/workflow/sharing/components/publish/ComfyHubPublishDialog.test.ts # src/platform/workflow/sharing/components/publish/ComfyHubThumbnailStep.test.ts
42f32ca
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
…assets flag, retire Comfy.Assets.UseAssetAPI (#18727) Manual backport of #17117 to `core/1.54`. The automated backport failed with merge conflicts (#17117 (comment)). Cherry-picked from dffad2d (`git cherry-pick -x`). ## Why #17117 retires the hidden `Comfy.Assets.UseAssetAPI` setting and the `Comfy.ToggleAssetAPI` command. The model library, sidebar tab and model store follow `useFeatureFlags().flags.assetsEnabled` (cloud, or the server advertises the `assets` feature). `Comfy.BrowseModelAssets` opens the browser through `openModelLibraryBrowser()`, and the widget asset-picker gate is renamed to `shouldUseWidgetAssetPicker` / `isWidgetAssetPickerEnabled` and fixed to `isCloud`. Without it, a stale persisted setting can still route the model library to `/api/assets` on a backend that doesn't serve it. ## Dependency check The bot flagged a possible stacking conflict with #18722, #18683, #18334 and #17872. None of the four touch any file changed by #17117, so they aren't the cause. The conflicts are real and come from main-only test refactors that aren't on `core/1.54`: the `vi.mock(import(...))` migrations (#17173, #17175, #17176, #17178, #17179) and the global-Pinia test migrations (#17231, #17234, #17235, #17236, #17237, #17270), plus #16891. All production code, locale, script and e2e changes applied cleanly. ## Conflict resolution All 7 conflicts were in unit tests. Each one keeps `core/1.54`'s mocking style (hoisted `vi.mock` stores, no global Pinia) and ports only the setting-to-flag change: - `src/components/sidebar/tabs/ModelLibrarySidebarTab.test.ts`: kept the target's store/download/setting mocks. Dropped the `Comfy.Assets.UseAssetAPI` branch and added a `useFeatureFlags` mock (`featureFlagState.assetsEnabled`) in its place. - `src/composables/useCoreCommands.test.ts`: kept the target's mocks and `createMockSettingStore`. Added the `useFeatureFlags` mock. The `BrowseModelAssets` tests toggle `assetsEnabled` instead of the setting. - `src/platform/assets/services/assetService.test.ts`: kept the target's imports and mocks. Took the rename to `shouldUseWidgetAssetPicker` and removed the setting-store mock. - `src/platform/assets/utils/assetPreviewUtil.test.ts`: kept the target's `vi.mock` style. Added the `useFeatureFlags` mock and removed the `isAssetAPIEnabled` / `getServerFeature` mocks. - `src/renderer/extensions/vueNodes/widgets/composables/useComboWidget.test.ts`: kept the target's two remote-combo tests, which are absent on main. Took the renamed test and the `shouldUseWidgetAssetPicker` mock. - `src/stores/modelStore.test.ts`: kept the target's `mockDistribution` mock. Took #17117's `remoteConfig` holder mock and reactive `serverFeatures` state, so the store's flag watcher fires and state doesn't leak between tests. - `src/stores/workspace/sidebarTabStore.test.ts`: kept the target's command/menu/setting store mocks. Added the `useFeatureFlags` and `openModelLibraryBrowser` mocks and dropped the `Comfy.Assets.UseAssetAPI` setting reads. No other changes from main are included. ## Validation - Static check: no remaining `Comfy.Assets.UseAssetAPI`, `isAssetAPIEnabled`, `shouldUseAssetBrowser`, `ToggleAssetAPI` or `usesAssetApi` references in `src`, `browser_tests`, `scripts` or `.github`. - `pnpm install --frozen-lockfile`: ok - `pnpm typecheck`: clean - `eslint`, `oxlint`, `oxfmt --check` on changed files: 0 errors - `vitest run` on the touched tests plus `src/stores`, `src/platform/assets`, `src/components/sidebar` and `src/composables/useFeatureFlags*`: 129 files, 2339 passed - `vitest run` on `scripts/checkAssetsFlagArtifact.test.ts`, `widgetInputs`, `missingModelPipeline`, `src/renderer/extensions/vueNodes/widgets` and `useCoreCommands`: 66 files, 960 passed - `vite build` followed by `EXPECTED_DISTRIBUTION=localhost EXPECTED_FRONTEND_COMMIT=<HEAD> pnpm test:assets-flag-artifact`: pass - Local e2e against a real ComfyUI backend without `--enable-assets` (`/api/features` reports `assets: false`), with a temporary request guard that is not included in this PR: - A walk of the sidebars, model library refresh, asset/model commands, missing-model workflows, upload and run, the assets sidebar, linear mode and vue-node dropdowns: 10/10 passed. This covered a user with a stale persisted `Comfy.Assets.UseAssetAPI=true`. No `/api/assets*` requests were made. - `browser_tests/tests/sidebar/modelLibrary.spec.ts`: 13/13 passed with no `/api/assets*` requests.
Summary
Migrates legacy
vi.mockcalls in asset and workflow tests to the dynamicimport()form as an independent slice of #16174.Changes
<unknown>to preserve the string overload's existing type contract.Review Focus
This is a mechanical syntax migration. The lint rule and documentation are intentionally deferred until every domain slice has merged.
Verified with the full pre-commit lint/typecheck gates,
pnpm knip, and the combined unit suite (1,506 files; 20,337 passed).