Repository navigation
fix: keep widget values on ordinary node removal so undo restores them - #16955
christian-byrne wants to merge 3 commits into
Conversation
🎭 Playwright: ✅ 1907 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.76 MB gzip 🔴 +100 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 128 kB (baseline 128 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 28.9 kB (baseline 28.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • 🔴 +123 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 558 kB (baseline 558 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 18 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.7 MB (baseline 16.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 72 added / 72 removed / 224 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-06T06:12:21.192Z",
"gitSha": "d7844467f0d53431870ef2798289f810a243b704",
"branch": "fix/remove-node-keep-values",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2031.2099999999873,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.745,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 521.9390000000001,
"heapDeltaBytes": -3852348,
"heapUsedBytes": 64997700,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.551,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2035.6349999999566,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.211000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.0409999999999,
"heapDeltaBytes": 13071280,
"heapUsedBytes": 82769356,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 11.910999999999998,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2036.0599999999636,
"styleRecalcs": 82,
"styleRecalcDurationMs": 50.014,
"layouts": 14,
"layoutDurationMs": 7.0409999999999995,
"taskDurationMs": 1055.145,
"heapDeltaBytes": 4902052,
"heapUsedBytes": 75314992,
"domNodes": -279,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 192.193,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1932.5400000000172,
"styleRecalcs": 81,
"styleRecalcDurationMs": 43.653999999999996,
"layouts": 14,
"layoutDurationMs": 4.653,
"taskDurationMs": 984.8780000000002,
"heapDeltaBytes": 1728340,
"heapUsedBytes": 71155468,
"domNodes": -279,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 179.815,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.4780000000192,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.893,
"layouts": 6,
"layoutDurationMs": 1.2839999999999998,
"taskDurationMs": 361.80099999999993,
"heapDeltaBytes": 3913772,
"heapUsedBytes": 67779880,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.581,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.1229999999205,
"styleRecalcs": 31,
"styleRecalcDurationMs": 19.136000000000003,
"layouts": 6,
"layoutDurationMs": 1.163,
"taskDurationMs": 412.707,
"heapDeltaBytes": 5007064,
"heapUsedBytes": 75881496,
"domNodes": 77,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 15.069999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 684.5079999999939,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.24,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.194,
"heapDeltaBytes": -7480096,
"heapUsedBytes": 63076044,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 164.535,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 723.1550000000198,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.780000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.76199999999994,
"heapDeltaBytes": 18839072,
"heapUsedBytes": 87583748,
"domNodes": 16,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 168.65200000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2019.0660000000094,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.723999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 629.3349999999999,
"heapDeltaBytes": 10759968,
"heapUsedBytes": 87206484,
"domNodes": -271,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 33.957,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2062.9169999999704,
"styleRecalcs": 5,
"styleRecalcDurationMs": 6.651999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 690.1600000000001,
"heapDeltaBytes": 11067724,
"heapUsedBytes": 87472084,
"domNodes": -270,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 37.372,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2527.511000000004,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.003000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1704.918,
"heapDeltaBytes": 22734068,
"heapUsedBytes": 88808932,
"domNodes": -276,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 837.7049999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2476.419000000078,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.444,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1726.9629999999997,
"heapDeltaBytes": 18527356,
"heapUsedBytes": 84081700,
"domNodes": -278,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 843.54,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3684.1359999999668,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.049000000000003,
"layouts": 60,
"layoutDurationMs": 12.553,
"taskDurationMs": 1740.8360000000002,
"heapDeltaBytes": 8179824,
"heapUsedBytes": 75841716,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 796.092,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3675.879000000009,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.445,
"layouts": 60,
"layoutDurationMs": 12.654000000000002,
"taskDurationMs": 1790.6,
"heapDeltaBytes": 8518572,
"heapUsedBytes": 75910944,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 807.407,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3103.686000000039,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.1339999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1966.3489999999997,
"heapDeltaBytes": 26681748,
"heapUsedBytes": 94333220,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 953.8460000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3128.991000000042,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.177000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2037.15,
"heapDeltaBytes": 25927132,
"heapUsedBytes": 93578104,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 988.261,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "minimap-idle",
"durationMs": 2031.5580000000182,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.737000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.098,
"heapDeltaBytes": 10245744,
"heapUsedBytes": 87389068,
"domNodes": -269,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 31.662999999999997,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2036.1799999999448,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.291999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 642.5699999999999,
"heapDeltaBytes": 10224180,
"heapUsedBytes": 87315124,
"domNodes": -270,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 34.89600000000001,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 604.2280000000346,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.267000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.668,
"heapDeltaBytes": 15205728,
"heapUsedBytes": 88125904,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 141.341,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 623.3069999999543,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.335999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.299,
"heapDeltaBytes": 14683432,
"heapUsedBytes": 86546332,
"domNodes": 16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 143.223,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2033.8669999999865,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.365999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.3070000000001,
"heapDeltaBytes": -1665184,
"heapUsedBytes": 70162348,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.306,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2031.3129999999546,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.312999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.12,
"heapDeltaBytes": -2108616,
"heapUsedBytes": 69399456,
"domNodes": -294,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 10.577999999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1735.9410000000253,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.472,
"layouts": 18,
"layoutDurationMs": 4.989999999999999,
"taskDurationMs": 871.0769999999999,
"heapDeltaBytes": -12258688,
"heapUsedBytes": 59980916,
"domNodes": -294,
"jsHeapTotalBytes": 7593984,
"scriptDurationMs": 117.295,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1721.8689999999697,
"styleRecalcs": 78,
"styleRecalcDurationMs": 37.53,
"layouts": 18,
"layoutDurationMs": 5.261,
"taskDurationMs": 863.362,
"heapDeltaBytes": -12307720,
"heapUsedBytes": 60376124,
"domNodes": -292,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 114.24799999999999,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.6760000000659,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.760000000000012,
"layouts": 15,
"layoutDurationMs": 15.46,
"taskDurationMs": 972.915,
"heapDeltaBytes": -7473836,
"heapUsedBytes": 86239064,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 30.54799999999999,
"eventListeners": 2385,
"totalBlockingTimeMs": 144,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8514.446000000022,
"styleRecalcs": 247,
"styleRecalcDurationMs": 35.26,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5868.358,
"heapDeltaBytes": -12072308,
"heapUsedBytes": 89567916,
"domNodes": -268,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 2727.6559999999995,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9700.11999999997,
"styleRecalcs": 246,
"styleRecalcDurationMs": 37.760000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6379.3009999999995,
"heapDeltaBytes": 20116956,
"heapUsedBytes": 95890180,
"domNodes": -270,
"jsHeapTotalBytes": -434176,
"scriptDurationMs": 2922.41,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17414.41500000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16690.417999999998,
"heapDeltaBytes": -36152100,
"heapUsedBytes": 174881816,
"domNodes": -6548,
"jsHeapTotalBytes": 991232,
"scriptDurationMs": 266.915,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17685.048000000053,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17046.040999999997,
"heapDeltaBytes": -36065988,
"heapUsedBytes": 174606316,
"domNodes": -6548,
"jsHeapTotalBytes": 1286144,
"scriptDurationMs": 310.902,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21608.85100000007,
"styleRecalcs": 175,
"styleRecalcDurationMs": 19.73400000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21342.617000000002,
"heapDeltaBytes": -19463232,
"heapUsedBytes": 180473820,
"domNodes": -6548,
"jsHeapTotalBytes": 2375680,
"scriptDurationMs": 956.683,
"eventListeners": -7467,
"totalBlockingTimeMs": 19,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21719.611999999983,
"styleRecalcs": 167,
"styleRecalcDurationMs": 20.606000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21425.431,
"heapDeltaBytes": -37884636,
"heapUsedBytes": 166646192,
"domNodes": -6548,
"jsHeapTotalBytes": 2564096,
"scriptDurationMs": 944.8939999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 80,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6304.885000000013,
"styleRecalcs": 20,
"styleRecalcDurationMs": 88.459,
"layouts": 20,
"layoutDurationMs": 23.680000000000007,
"taskDurationMs": 6163.513,
"heapDeltaBytes": -30431060,
"heapUsedBytes": 179375936,
"domNodes": -6548,
"jsHeapTotalBytes": 9039872,
"scriptDurationMs": 111.02199999999998,
"eventListeners": -7472,
"totalBlockingTimeMs": 443,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6338.680999999951,
"styleRecalcs": 20,
"styleRecalcDurationMs": 98.908,
"layouts": 20,
"layoutDurationMs": 36.19799999999999,
"taskDurationMs": 6250.6050000000005,
"heapDeltaBytes": -19237400,
"heapUsedBytes": 190664344,
"domNodes": -6548,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 115.82700000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 445,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8822.262000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8523.113000000001,
"heapDeltaBytes": 26998272,
"heapUsedBytes": 180804520,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 135.371,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8530.314999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8288.044000000002,
"heapDeltaBytes": 13036492,
"heapUsedBytes": 179751928,
"domNodes": 0,
"jsHeapTotalBytes": -7602176,
"scriptDurationMs": 127.85100000000004,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 493.473999999992,
"styleRecalcs": 18,
"styleRecalcDurationMs": 25.540999999999997,
"layouts": 3,
"layoutDurationMs": 1.827,
"taskDurationMs": 137.195,
"heapDeltaBytes": 5063132,
"heapUsedBytes": 73725756,
"domNodes": 149,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.744,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 131.36999999994714,
"styleRecalcs": 8,
"styleRecalcDurationMs": 19.913,
"layouts": 2,
"layoutDurationMs": 0.603,
"taskDurationMs": 93.99899999999998,
"heapDeltaBytes": 3037788,
"heapUsedBytes": 71679156,
"domNodes": 108,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 4.640999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (7)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe change adds explicit store cleanup modes. Ordinary node removal preserves widget values while clearing tracking and preview exposures. Full graph clearing still discards widget state. Tests cover node re-addition and subgraph replacement behavior. ChangesNode removal state
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to Ordinary node deletion now retains widget values for undo and same-ID re-addition while clearing previews and tracking; teardown and canonical-state discard paths remain covered. No current merge-blocking risk is identified. Possibly related PRs
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The changed files are available and include ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #16955 +/- ##
==========================================
+ Coverage 81.23% 82.90% +1.66%
==========================================
Files 2464 2050 -414
Lines 126966 119560 -7406
Branches 32036 31275 -761
==========================================
- Hits 103141 99120 -4021
+ Misses 23310 20260 -3050
+ Partials 515 180 -335
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 661 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed at d7aef86. Ran the four touched test files at head (135 pass, 1 expected fail) and a mutation check: reverting LGraph.ts:1483 to the default 'discard-values' fails 6 of the new/renamed tests, so the keep-values coverage is real and the motivation from #15973 ('keep-values' was unreachable) holds.
One behavior change the PR body does not mention: the CRDT orphan path. agentNodeMaterializer.ts:247 calls graph.remove(orphan, { preserveCanonicalState: true }) for adapters whose record is gone. With no successor, that path used to run clearNodeOwnedStoreState in discard mode and now runs it in keep mode, and since the preserveCanonicalState branch skips detachNodeFromStores, nothing releases the widget order either. I probed this at head: after such a remove, getNodeWidgetIds(root, id) still returns the deleted node's widget ids and getWidget(id).value is still set; before this PR both were empty. Details inline.
Everything else is fine. The same-id replacement test now expecting the pre-removal values (null, 42) to carry over is the intended consequence of keep-values plus registerWidget's same-type keep rule, and the test comment documents it.
|
Review posted, fix pushed as 6a592e1, own threads resolved.
Full context for agent readersReview: #16955 (review) Verification at head Fix
Checks after the fix: focused vitest on the four files plus Author follow-up: the PR body says none of the discard paths changed; the |
|
CI on 6a592e1 settled green at 10:07Z: 76 success, 15 skipped, 0 failures. Full context for agent readersCounts come from the check-runs API for commit 6a592e1 (paginated), polled every minute from the push at 09:40Z. No reruns were needed. The remaining item for the author is the PR body sentence "none of those paths changed", which no longer describes the |
DrJKL
left a comment
There was a problem hiding this comment.
The production lifecycle change looks sound: ordinary removal retains widget values while releasing ownership and order; canonical remote removal and graph teardown still discard them. One new test presented as undo coverage does not exercise restoration from the widget store. It re-adds the same node object, whose widget already retains its edited value, and passes on the broken base implementation.
An isolated head/base install passed typecheck, format, Knip, lint, and 174 targeted tests with one expected failure. The red-base run produced six failures, but this undo-named test stayed green. Maintainability finding: delete the redundant same-object test or convert it to the real reconstruction/undo lifecycle.
| ) | ||
| }) | ||
|
|
||
| it('restores the edited value when the removed node is re-added (undo of delete)', () => { |
There was a problem hiding this comment.
This test passes on the pre-fix base. graph.remove(node) clears the store there, but graph.add(node) reuses the same object whose widget still contains the edited value, so the assertion never proves store-backed undo restoration. Delete it, or reconstruct the node through the real undo lifecycle so retained store state is required.
There was a problem hiding this comment.
Rewrote the test: it now re-adds a brand-new node instance under the same id instead of the removed object. Verified it fails on the old discard behaviour and passes with the fix.
Full context for agent readers
- Commit 4c282ca replaces
restores the edited value when the removed node is re-addedwith a version that savesnode.id, removes the node, builds a freshLGraphNodewith the same id and a default-valuedpromptwidget, adds it, and asserts the widget reads the edited value from the store. - Sanity check: temporarily forcing the
removeNodepath to'discard-values'makes this test (and two siblings) fail; reverting restores green. Vitest 7/7, typecheck, oxlint, oxfmt clean.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 4 |
| 🟡 Medium | 3 |
| 🟢 Low | 3 |
Panel: 8/8 reviewers contributed findings.
| if (!successor) { | ||
| clearNodeOwnedStoreState( | ||
| node, | ||
| options.preserveCanonicalState ? 'discard-values' : 'keep-values' |
There was a problem hiding this comment.
🟠 High — Retained states stay keyed by graphId:nodeId:name, while the same removal frees the node id via unregisterNodeState; registerWidget returns the existing state and keeps existing.value whenever existing.type === init.type, so any later node that takes that id (id-preserving paste, agentNodeMaterializer.materialize doing node.id = state.id, a same-id subgraph host, extension graph.add with an explicit id) silently comes up with the deleted node's edited values instead of its own defaults. That resurrects data a user deleted on purpose — prompt text, API keys — into an unrelated node with no indication, so replacement state transfer should be explicit rather than a side effect of key collision. Raised by 7 of 8 reviewers (gpt-5.6-sol-max adversarial and edge-case, claude-opus-5-thinking-max adversarial and edge-case, gemini-3.1-pro adversarial, kimi-k3-max adversarial and edge-case).
| useWidgetValueStore().clearNode(rootGraphId, nodeId) | ||
| if (mode === 'discard-values') { | ||
| useWidgetValueStore().clearNode(rootGraphId, nodeId) | ||
| } |
There was a problem hiding this comment.
🟠 High — The keep-values path skips clearNode, but the same removal still runs detachNodeFromStores -> releaseNodeWidgets(..., { discardValues: false }), which deletes the node's graphNodeWidgetOrders entry — the only nodeId -> widgetIds index. The retained graphWidgetStates/graphWidgetRenderStates entries are then unenumerable (getNodeWidgets returns [], and releaseNodeWidgets early-returns when the order is missing), so nothing short of clearGraph can free them and every ordinary deletion permanently grows the store with values that may be large prompt/code strings or combo options. The new SubgraphDuplicateDeleteOrder assertions show this directly — value retained, order empty — which also undercuts the "recoverable" claim in that test's name. Raised by 7 of 8 reviewers (gpt-5.6-sol-max adversarial and edge-case, claude-opus-5-thinking-max adversarial and edge-case, gemini-3.1-pro adversarial, kimi-k3-max adversarial and edge-case).
| expect(promotedWidgetId(replacement, 'count')).toBe(countId) | ||
| expect(promotedValue(replacement, 'value')).toBe('initial') | ||
| expect(promotedValue(replacement, 'count')).toBe(5) | ||
| expect(promotedValue(replacement, 'value')).toBe(null) |
There was a problem hiding this comment.
🟠 High — createTestSubgraphNode(subgraph, { id: HOST_ID }) builds a brand-new node that merely reuses the id — it is not the removed host coming back — yet the expectation is flipped to the removed host's null/42 instead of the interior widgets' live 'initial'/5. The sibling test "discards the null host value when the interior widget type changes" treats exactly that null as wrong, and a null promoted STRING can reach prompt submission, so this rewritten expectation encodes a regression rather than a rename and should not be accepted as the new contract. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, claude-opus-5-thinking-max adversarial).
| node.onRemoved?.() | ||
| if (!successor) clearNodeOwnedStoreState(node) | ||
| if (!successor) { | ||
| clearNodeOwnedStoreState( |
There was a problem hiding this comment.
🟠 High — agentNodeMaterializer.rollback() undoes a partially attached node with a plain graph.remove(node) and then re-registers the canonical snapshot captured before add(); with keep-values the half-added node's states survive and registerWidget's same-type branch preserves existing.value over the snapshot's init.value, so restore() silently fails to reinstate authoritative values and the local graph diverges from the shared CRDT document. That call site documents an explicitly non-best-effort guarantee, so it — and other "gone for good" programmatic removals — need to opt into discard-values. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max edge-case).
| // callback | ||
| node.onRemoved?.() | ||
| if (!successor) clearNodeOwnedStoreState(node) | ||
| if (!successor) { |
There was a problem hiding this comment.
🟡 Medium — observeValue gates listener dispatch on getWidget(widgetId) !== state, which previously short-circuited once clearNode evicted the entry on removal. With the entry retained, a late write to a removed node's widget (async DOM-widget callback, an upload completing after deletion, control_after_generate, extension code holding a widget reference) passes that liveness check and fires onValueChange, so the CRDT bridge in mintPortWiring.ts pushes a set_widget operation for a node that is no longer in the graph — producing orphan or resurrected state for collaborators. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial and edge-case, gpt-5.6-sol-max adversarial).
| if (mode === 'discard-values') { | ||
| useWidgetValueStore().clearNode(rootGraphId, nodeId) | ||
| } | ||
| usePreviewExposureStore().clearHost( |
There was a problem hiding this comment.
🟡 Medium — This was the only removal-path caller of graphWidgetRestorations.get(graphId)?.delete(nodeId), and releaseNodeWidgets does not touch restorations — so a record set outside a try/finally (e.g. PrimitiveNode.configure in src/extensions/core/widgetInputs.ts, cleared only if widgets are later created) now survives deletion. getRestoredWidgetValue in LGraphNode.addCustomWidget will then hand the dead node's serialized value to whatever node next occupies that graph+node id, including through the positional fallback that matches by index regardless of widget name. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| * Whether a node's owned store state — specifically its widget values — | ||
| * leaves with it. `'keep-values'` is for a node that may come back (undo of | ||
| * a deletion); `'discard-values'` is for a node that is gone for good | ||
| * (subgraph teardown, node replacement). Preview exposures are always |
There was a problem hiding this comment.
🟡 Medium — The scenario named here does not read these entries: undo runs ChangeTracker.updateState -> app.loadGraphData -> LGraph.configure -> clear(), which calls widgetValueStore.clearGraph(graphId) and rebuilds every value from the serialized widgets_values. If real undo never consults the retained state, the retention buys nothing for the case it documents while carrying the id-reuse and unbounded-retention hazards above — worth confirming against the actual undo path before merging. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, claude-opus-5-thinking-max adversarial).
| */ | ||
| export type WidgetDetachMode = 'keep-values' | 'discard-values' | ||
|
|
||
| export function clearNodeOwnedStoreState( |
There was a problem hiding this comment.
🟢 Low — The canonical mutation layer still discards on delete: graphMutations.deleteNode calls widgetStore.clearNode(...) (src/core/graph/graphMutations.ts), as does clearSemanticGraph. Two authorities now disagree about whether a removed node's values survive, so the retention this change introduces only holds when the litegraph path runs alone, making the advertised behaviour depend on which delete path fired. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
| ) | ||
| }) | ||
|
|
||
| it('restores the edited value when the removed node is re-added (undo of delete)', () => { |
There was a problem hiding this comment.
🟢 Low — This assertion holds with or without the change: BaseWidget.value reads this._state, a live reference to the same WidgetState object, so deleting the store's Map entry never nulled it, and graph.add -> setNodeId -> registerWidget re-registers with value: this.value read back off that reference. As written the test gives false confidence that store retention is what restores the value; pin the behaviour with a node rebuilt from serialization rather than the same object. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
| node: LGraphNode, | ||
| mode: WidgetDetachMode = 'discard-values' | ||
| ): void { | ||
| const graph = node.graph |
There was a problem hiding this comment.
🟢 Low — clearNodeOwnedStoreState defaults to 'discard-values' while its sibling detachNodeFromStores defaults to 'keep-values', and LGraph.removeNode invokes both halves of the same detach — passing the mode explicitly to one and silently relying on the other's default matching the branch it sits in. Making the mode a required parameter on both would stop a future "this node is gone for good" caller from retaining values by accident. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial and edge-case, kimi-k3-max adversarial).
The previous test reused the removed node object, so it passed even before the fix. Undo rebuilds nodes from serialized state, so the test now constructs a new node under the same id and asserts the store restores the edited value.
| if (!successor) { | ||
| clearNodeOwnedStoreState( | ||
| node, | ||
| options.preserveCanonicalState ? 'discard-values' : 'keep-values' |
There was a problem hiding this comment.
keep-values does not participate in the real undo flow, and the new restoration test depends on reusing a node ID that should not be reused.
Real delete and undo works as follows:
LGraph.remove()deletes the node.ChangeTracker.undo()loads the previous serialized graph snapshot.app.loadGraphData()callsrootGraph.configure().configure()clears the widget store withclearGraph().- Nodes are rebuilt and their values are restored from serialized
widgets_values.
Any widget state retained during step 1 is therefore cleared before restoration. The existing compound-undo test already passes on the merge base and confirms that widget values are restored without this change.
The new test exercises a different flow:
- Remove a node.
- Construct a fresh node.
- Manually assign the removed node's ID.
- Add the fresh node.
- Let
registerWidget()recover the retained value through the matchinggraphId:nodeId:namekey.
That is not the application's undo path. It also relies on reusing an ID when node IDs should increase and remain unique. The test consequently turns stale-key collision behavior into a contract. Internal code that must use an explicit ID, such as agent materialization, should restore its authoritative widget state directly rather than inherit values left by an earlier occupant.
Please keep ordinary removal in discard mode and revert the keep-values plumbing and synthetic same-ID tests. If a future in-memory restoration path genuinely needs retained values, that operation should own an explicit snapshot instead of leaving detached state in the global widget store.
There is also already Playwright coverage for the actual user behavior in browser_tests/tests/workflowStateRoundTrips.spec.ts (undo and redo a connected node deletion). It:
- Records a connected KSampler’s
cfgvalue and geometry. - Deletes the node through the UI.
- Undoes and verifies the node, geometry, and widget value are restored.
- Redoes, undoes again, then queues the workflow.
- Verifies the restored widget value and connections appear in the API prompt.
That test existed at this PR’s merge base and passes without the production change. It currently covers the Vue Nodes renderer; there is no equivalent legacy-renderer Playwright test.
|
Closing — DrJKL's analysis holds: real undo restores widget values from the serialized snapshot via configure(), so the keep-values path never participates. Reverting the plumbing and the synthetic same-ID tests leaves nothing to merge. Ordinary removal stays in discard mode. Full context for agent readers
|
Node removal now honors
WidgetDetachMode: 'keep-values': an ordinary delete keeps the node's widget values in the store so undo restores them. Split out of #16508 at the reviewer's request so the production fix can be reviewed on its own.Full context for agent readers
Summary
LGraph.removeNodecalledclearNodeOwnedStoreState(node)(an unconditional widget-value wipe) beforedetachNodeFromStoresever reached itskeep-values/discard-valuesbranch, so the default'keep-values'mode never retained anything and undo of a deletion came back with default widget values. Flagged in review of #15924 (#15924 (comment)) and tracked in #15973.Change
clearNodeOwnedStoreStatetakes the sameClearNodeOwnedStoreStateModeand skips the widget-value wipe on'keep-values'. Preview exposures are still cleared unconditionally, matchingdetachNodeFromStores.LGraph.removeNodepasses'keep-values'for the ordinary (no-successor) removal path. Whole-graph clear, subgraph-definition teardown, and node replacement still discard values; none of those paths changed.Tests
Four pre-existing tests asserted the bug's symptom (value gone immediately after remove) as the contract; all four were introduced or touched in #15924 alongside the bug. They now assert the documented behavior: value survives an ordinary remove and is restored on re-add; still discarded on graph clear.
promotionAfterReplacement.test.tsadditionally reflects thatwidgetValueStore.registerWidgetkeeps a same-typed re-registration's existing value over the incoming default (documented there re #13073/#13773), so a same-id host replacement after removal now carries the edited value over instead of resetting.New:
nodeShellLifecycle.test.tskeep-values block (value kept after remove, restored on re-add, discarded on clear);LGraph.test.tsremoval keeps widget value while clearing preview exposures.Verified red on
main/ green with the fix for the focused files:src/core/graph/nodeShell/nodeShellLifecycle.test.ts src/core/graph/subgraph/promotionAfterReplacement.test.ts src/lib/litegraph/src/subgraph/SubgraphDuplicateDeleteOrder.test.ts src/lib/litegraph/src/LGraph.test.ts.Provenance
Extracted unchanged from #16508 (head f210e61) in response to the request to split the detach fix from the coverage-only work. #16508 keeps the dynamic-widget fix and the
getNodeOnPoscoverage. Sibling split: the extensionconfigure()clone-isolation fix.Addresses #15973 (delete/undo
keep-valuesreachability).