Repository navigation
test(agent): cover malformed base64 update failure (re-carry onto main) - #16923
christian-byrne wants to merge 3 commits into
Conversation
|
Deployment failed for project comfy-home-v1 with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
|
Warning Review limit reached
On-demand reviews are free for the next 30 days. After that, they cost $0.25 per reviewed file. Or wait 1 minute for your next included review. View limit detailsLimit details: You’ve used all 8 included reviews currently available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1938 passed, 0 failed · 1 flaky📊 Browser Reports
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16923 +/- ##
==========================================
+ Coverage 81.82% 83.24% +1.41%
==========================================
Files 2518 2064 -454
Lines 128671 120437 -8234
Branches 33260 31225 -2035
==========================================
- Hits 105290 100253 -5037
+ Misses 22847 20004 -2843
+ Partials 534 180 -354
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
(cherry picked from commit 7d9e4fb)
eea6ca9 to
478661b
Compare
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: changes requested
I found that this test-only change is already covered by tests on the PR's current base. docFrameClient.base64.test.ts verifies malformed base64 returns null without throwing, and the existing reports the first malformed inbound frame per type test sends malformed base64 through DocFrameClient and verifies that no doc_update is dispatched. Both exercise the production parser; only telemetry is mocked. I also confirmed with mutation probes that the base64 test fails if invalid input is accepted and the client test fails if an invalid frame is dispatched.
The original throwing behavior was replaced by #16668 before this branch point. Since the added test has no distinct falsifier, there is no remaining regression coverage to merge after removing it.
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to close
The prior finding is addressed. Commit 05337e0248 removes the duplicate malformed-base64 test, and the current base-to-head diff is empty. The existing decoder and client tests still cover malformed input rejection and non-dispatch through production code; both focused files pass, with 14 tests total.
The PR description is now stale: it still says this branch carries a test, that parseServerDocFrame throws, and that equivalent coverage is absent from main. The current implementation returns null without throwing, and main already contains the decoder and dispatch coverage. Since there is no remaining change to merge, this PR can be closed.
|
Closing as superseded — this branch no longer carries any change: head Full context
|
Summary
Re-carry of the malformed-base64 characterization test from the frozen integration base onto
main.Changes
parseServerDocFramethrows for structurally validdoc_updatedata containing malformed base64, and proveDocFrameClientdispatches nodoc_updateevent.-xfrom7d9e4fb4e2722b92d77293f98566cc777068ccd9(original authorship preserved).nathaniel/agent-panel-v1branch. On currentmainthe module is still atsrc/workbench/extensions/agent/crdt/docFrameClient.ts— no import-path retarget was needed. Main'sdecodeBase64(atob, no try/catch) still throws on malformed base64, so the characterization applies as-is. No equivalent malformed-base64 test exists onmain(checkeddocFrameClient.test.tsand the file list — the base64 test file in fix(agent): reject malformed document frames #16484 is not merged).Supersedes #16660 (dead base, per the prbase re-carry sweep).
Evidence
Original lane attribution:
lane-fec-base64-1(test-only, authored by Christian Byrne).