Repository navigation
test(agent): cover malformed base64 update failure - #16660
christian-byrne wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: 🚧 Building...🎭 Playwright: ❌ 1898 passed, 54 failed · 5 flaky❌ Failed Tests📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-02T14:57:04.455Z",
"gitSha": "4eabbf1842a702cc616c1e7fa31f44a309cf9d93",
"branch": "christian-byrne/fec-base64-1-malformed-update-base64",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2013.038999999992,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.387999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.817,
"heapDeltaBytes": 2559520,
"heapUsedBytes": 97945536,
"domNodes": 14,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.733999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2012.8029999999626,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.819000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.229,
"heapDeltaBytes": 3240452,
"heapUsedBytes": 99415716,
"domNodes": 16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 7.181,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2156.558999999959,
"styleRecalcs": 82,
"styleRecalcDurationMs": 44.552,
"layouts": 14,
"layoutDurationMs": 5.066,
"taskDurationMs": 1166.512,
"heapDeltaBytes": -8090268,
"heapUsedBytes": 88874484,
"domNodes": 63,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 159.206,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2073.545999999965,
"styleRecalcs": 83,
"styleRecalcDurationMs": 42.147000000000006,
"layouts": 14,
"layoutDurationMs": 4.433999999999999,
"taskDurationMs": 1120.343,
"heapDeltaBytes": -6953224,
"heapUsedBytes": 90090428,
"domNodes": 64,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 151.26000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.6030000000114,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.696,
"layouts": 6,
"layoutDurationMs": 1.108,
"taskDurationMs": 392.515,
"heapDeltaBytes": 5747012,
"heapUsedBytes": 102655900,
"domNodes": 75,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 11.89,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.314999999976,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.509999999999998,
"layouts": 6,
"layoutDurationMs": 1.1159999999999999,
"taskDurationMs": 362.07800000000003,
"heapDeltaBytes": 5843276,
"heapUsedBytes": 102720044,
"domNodes": 76,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 10.189999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 1015.5039999999644,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.044999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 728.8919999999999,
"heapDeltaBytes": 7256844,
"heapUsedBytes": 104254856,
"domNodes": 16,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 158.588,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 922.2469999999703,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.0349999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 676.3000000000001,
"heapDeltaBytes": 7150008,
"heapUsedBytes": 104078380,
"domNodes": 18,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 141.321,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2007.0970000000443,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.084000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.1139999999998,
"heapDeltaBytes": -8727912,
"heapUsedBytes": 96063128,
"domNodes": -299,
"jsHeapTotalBytes": -3702784,
"scriptDurationMs": 40.661,
"eventListeners": -227,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2006.5559999999323,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.582,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 515.478,
"heapDeltaBytes": 16898040,
"heapUsedBytes": 121203256,
"domNodes": 12,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 31.564999999999994,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 3298.4369999999785,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.229,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2583.4610000000002,
"heapDeltaBytes": -5570344,
"heapUsedBytes": 98557008,
"domNodes": 6,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 932.437,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3251.3230000000704,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.504999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2415.309,
"heapDeltaBytes": -6081824,
"heapUsedBytes": 98645904,
"domNodes": 8,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 887.54,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4364.870999999994,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.546,
"layouts": 60,
"layoutDurationMs": 12.775,
"taskDurationMs": 2481.756,
"heapDeltaBytes": 3816328,
"heapUsedBytes": 113452428,
"domNodes": 28,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 846.563,
"eventListeners": 12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4309.418000000051,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.815,
"layouts": 60,
"layoutDurationMs": 12.045,
"taskDurationMs": 2405.612,
"heapDeltaBytes": 3834476,
"heapUsedBytes": 113483048,
"domNodes": 28,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 839.387,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 4877.194000000031,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.250999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3654.312,
"heapDeltaBytes": -13730028,
"heapUsedBytes": 98982268,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 1023.5450000000002,
"eventListeners": 192,
"totalBlockingTimeMs": 6,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 4739.060999999992,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.44,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3504.384,
"heapDeltaBytes": -12166848,
"heapUsedBytes": 99981108,
"domNodes": 4,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 975.63,
"eventListeners": 192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "minimap-idle",
"durationMs": 1997.2629999999754,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.842000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.4579999999999,
"heapDeltaBytes": -9853164,
"heapUsedBytes": 96325192,
"domNodes": 8,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 35.397000000000006,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 1997.1869999999399,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.585999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.07500000000005,
"heapDeltaBytes": -9957704,
"heapUsedBytes": 96272200,
"domNodes": 8,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 32.743,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 754.1060000000357,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.600999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.128,
"heapDeltaBytes": -5500404,
"heapUsedBytes": 91827248,
"domNodes": 18,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 141.928,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 709.9419999999554,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.192,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.90900000000005,
"heapDeltaBytes": -5847720,
"heapUsedBytes": 91963588,
"domNodes": 18,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 135.435,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2034.4809999999711,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.67,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.66099999999994,
"heapDeltaBytes": 2834448,
"heapUsedBytes": 100510112,
"domNodes": 20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 9.149000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.912999999964,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.888000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.915,
"heapDeltaBytes": 3014588,
"heapUsedBytes": 100671836,
"domNodes": 16,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 6.3149999999999995,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1857.416999999998,
"styleRecalcs": 81,
"styleRecalcDurationMs": 43.488,
"layouts": 18,
"layoutDurationMs": 5.851,
"taskDurationMs": 1122.6370000000002,
"heapDeltaBytes": 6568380,
"heapUsedBytes": 104089212,
"domNodes": 69,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 118.381,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1855.0750000000562,
"styleRecalcs": 82,
"styleRecalcDurationMs": 40.86899999999999,
"layouts": 18,
"layoutDurationMs": 6.077,
"taskDurationMs": 1076.448,
"heapDeltaBytes": 6681888,
"heapUsedBytes": 103578792,
"domNodes": 71,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 110.33,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1399.159999999938,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.372999999999998,
"layouts": 15,
"layoutDurationMs": 13.727999999999998,
"taskDurationMs": 910.239,
"heapDeltaBytes": 21678948,
"heapUsedBytes": 116204584,
"domNodes": 13671,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 31.33299999999999,
"eventListeners": 2383,
"totalBlockingTimeMs": 135,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 12515.918999999996,
"styleRecalcs": 247,
"styleRecalcDurationMs": 35.774,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9036.006,
"heapDeltaBytes": -2539996,
"heapUsedBytes": 101761964,
"domNodes": -280,
"jsHeapTotalBytes": -2015232,
"scriptDurationMs": 3106.279,
"eventListeners": -173,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 12367.274000000067,
"styleRecalcs": 246,
"styleRecalcDurationMs": 34.143,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8873.247,
"heapDeltaBytes": -13467620,
"heapUsedBytes": 90975224,
"domNodes": -282,
"jsHeapTotalBytes": -372736,
"scriptDurationMs": 3080.249,
"eventListeners": -173,
"totalBlockingTimeMs": 1,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17476.21700000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16652.459,
"heapDeltaBytes": -22181972,
"heapUsedBytes": 200082396,
"domNodes": -6548,
"jsHeapTotalBytes": 14020608,
"scriptDurationMs": 310.402,
"eventListeners": -7456,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17660.12699999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16952.249000000003,
"heapDeltaBytes": -16952068,
"heapUsedBytes": 198716384,
"domNodes": -6548,
"jsHeapTotalBytes": 6754304,
"scriptDurationMs": 361.38100000000003,
"eventListeners": -7455,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21920.545000000006,
"styleRecalcs": 177,
"styleRecalcDurationMs": 18.037000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21504.165999999997,
"heapDeltaBytes": -43962248,
"heapUsedBytes": 198685896,
"domNodes": -6548,
"jsHeapTotalBytes": 5443584,
"scriptDurationMs": 883.5310000000001,
"eventListeners": -7449,
"totalBlockingTimeMs": 130,
"frameDurationMs": 18.333333333333453,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-large-graph-pan",
"durationMs": 22372.044000000074,
"styleRecalcs": 177,
"styleRecalcDurationMs": 20.630000000000038,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22021.958,
"heapDeltaBytes": -32499980,
"heapUsedBytes": 189688648,
"domNodes": -6548,
"jsHeapTotalBytes": 11288576,
"scriptDurationMs": 982.11,
"eventListeners": -7447,
"totalBlockingTimeMs": 79,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 129.5709999999417,
"styleRecalcs": 9,
"styleRecalcDurationMs": 21.385,
"layouts": 6,
"layoutDurationMs": 2.5269999999999997,
"taskDurationMs": 106.437,
"heapDeltaBytes": 3620568,
"heapUsedBytes": 95949192,
"domNodes": 129,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.791000000000001,
"eventListeners": 27,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 494.07399999995505,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24,
"layouts": 4,
"layoutDurationMs": 1.7329999999999999,
"taskDurationMs": 146.367,
"heapDeltaBytes": 6014396,
"heapUsedBytes": 98774412,
"domNodes": 147,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.857000000000001,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## nathaniel/agent-panel-v1 #16660 +/- ##
============================================================
+ Coverage 80.67% 82.97% +2.30%
============================================================
Files 2339 2009 -330
Lines 120790 115715 -5075
Branches 35560 33893 -1667
============================================================
- Hits 97444 96017 -1427
+ Misses 22849 19354 -3495
+ Partials 497 344 -153
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Severity: Major (cross-PR conflict) What: This test pins that Why this is an issue: Whichever lands second goes red; both PRs also edit Proposed Fix: Assert the shared contract (try/catch, no |
|
Superseded by #16923 (re-carry onto Full contextRe-carry per the prbase dead-base sweep (base tip frozen 2026-09-02; target module moved nowhere — still |
Summary
Characterize the integration branch's malformed
doc_updatebase64 boundary with a focused regression test.Changes
parseServerDocFramethrows for structurally validdoc_updatedata containing malformed base64, and proveDocFrameClientdispatches nodoc_updateevent.Review Focus
This intentionally records existing behavior without changing production code. Main-based PR #16484 separately changes the parser to reject malformed frames without throwing; it cannot host this integration-branch characterization because its expected behavior differs.
Evidence