Skip to content

test(agent): cover malformed base64 update failure - #16660

Closed
christian-byrne wants to merge 1 commit into
Comfy-Org:nathaniel/agent-panel-v1from
christian-byrne:christian-byrne/fec-base64-1-malformed-update-base64
Closed

christian-byrne wants to merge 1 commit into
Comfy-Org:nathaniel/agent-panel-v1from
christian-byrne:christian-byrne/fec-base64-1-malformed-update-base64

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Characterize the integration branch's malformed doc_update base64 boundary with a focused regression test.

Changes

  • What: Prove parseServerDocFrame throws for structurally valid doc_update data containing malformed base64, and prove DocFrameClient dispatches no doc_update event.
  • Dependencies: None.

Review Focus

This intentionally records existing behavior without changing production code. Main-based PR #16484 separately changes the parser to reject malformed frames without throwing; it cannot host this integration-branch characterization because its expected behavior differs.

Evidence

$ pnpm test:unit src/workbench/extensions/agent/crdt/docFrameClient.test.ts
Test Files  1 passed (1)
Tests  7 passed (7)

$ pnpm exec oxfmt --check src/workbench/extensions/agent/crdt/docFrameClient.test.ts
All matched files use the correct format.
Finished in 801ms on 1 files using 8 threads.

$ pnpm exec eslint src/workbench/extensions/agent/crdt/docFrameClient.test.ts
Exit code 0
No diagnostics emitted.

$ pnpm typecheck
Exit code 0
Completed by the repository pre-commit hook.

@christian-byrne christian-byrne added the risk:R1 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 3ec7d5d2-d802-429d-b005-2b4a89ee89d3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: 🚧 Building...

🎭 Playwright: ❌ 1898 passed, 54 failed · 5 flaky

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 1887 / ❌ 49 / ⚠️ 5 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 8 / ❌ 5 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 94.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 97.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 99.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 103.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 94.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 108.2 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 3ms TBT · 94.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 91.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.6 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 95.9 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 99.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 135ms TBT · 110.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 1ms TBT · 91.9 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 190.2 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 105ms TBT · 185.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 92.9 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 502ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 94.1 MB
canvas-idle: DOM nodes 15
canvas-idle: event listeners 5
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 43ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 83
canvas-mouse-sweep: task duration 1143ms
canvas-mouse-sweep: script duration 155ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 85.3 MB
canvas-mouse-sweep: DOM nodes 64
canvas-mouse-sweep: event listeners 6
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 377ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 97.9 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 703ms
dom-widget-clipping: script duration 150ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 99.3 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 514ms
large-graph-idle: script duration 36ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 103.6 MB
large-graph-idle: DOM nodes -144
large-graph-idle: event listeners -111
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 2499ms
large-graph-pan: script duration 910ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 94.0 MB
large-graph-pan: DOM nodes 7
large-graph-pan: event listeners 8
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 68
large-graph-zoom: task duration 2444ms
large-graph-zoom: script duration 843ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 108.2 MB
large-graph-zoom: DOM nodes 28
large-graph-zoom: event listeners 11
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 3579ms
legacy-node-drag: script duration 1000ms
legacy-node-drag: TBT 3ms
legacy-node-drag: heap used 94.9 MB
legacy-node-drag: DOM nodes 2
legacy-node-drag: event listeners 192
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 521ms
minimap-idle: script duration 34ms
minimap-idle: TBT 0ms
minimap-idle: heap used 91.8 MB
minimap-idle: DOM nodes 8
minimap-idle: event listeners 4
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 527ms
subgraph-dom-widget-clipping: script duration 139ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 87.6 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 464ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 95.9 MB
subgraph-idle: DOM nodes 18
subgraph-idle: event listeners 6
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 42ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 82
subgraph-mouse-sweep: task duration 1100ms
subgraph-mouse-sweep: script duration 114ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 99.0 MB
subgraph-mouse-sweep: DOM nodes 70
subgraph-mouse-sweep: event listeners 6
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 30ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 910ms
subgraph-transition-enter: script duration 31ms
subgraph-transition-enter: TBT 135ms
subgraph-transition-enter: heap used 110.8 MB
subgraph-transition-enter: DOM nodes 13671
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 8955ms
viewport-pan-sweep: script duration 3093ms
viewport-pan-sweep: TBT 1ms
viewport-pan-sweep: heap used 91.9 MB
viewport-pan-sweep: DOM nodes -281
viewport-pan-sweep: event listeners -173
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16802ms
vue-large-graph-idle: script duration 336ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 190.2 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7456
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 177
vue-large-graph-pan: task duration 21763ms
vue-large-graph-pan: script duration 933ms
vue-large-graph-pan: TBT 105ms
vue-large-graph-pan: heap used 185.2 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7448
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 23ms
workflow-execution: layout count 5
workflow-execution: style recalc count 14
workflow-execution: task duration 126ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 92.9 MB
workflow-execution: DOM nodes 138
workflow-execution: event listeners 62
Raw data
{
  "timestamp": "2026-09-02T14:57:04.455Z",
  "gitSha": "4eabbf1842a702cc616c1e7fa31f44a309cf9d93",
  "branch": "christian-byrne/fec-base64-1-malformed-update-base64",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2013.038999999992,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.387999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 571.817,
      "heapDeltaBytes": 2559520,
      "heapUsedBytes": 97945536,
      "domNodes": 14,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 11.733999999999998,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2012.8029999999626,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.819000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 432.229,
      "heapDeltaBytes": 3240452,
      "heapUsedBytes": 99415716,
      "domNodes": 16,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 7.181,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2156.558999999959,
      "styleRecalcs": 82,
      "styleRecalcDurationMs": 44.552,
      "layouts": 14,
      "layoutDurationMs": 5.066,
      "taskDurationMs": 1166.512,
      "heapDeltaBytes": -8090268,
      "heapUsedBytes": 88874484,
      "domNodes": 63,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 159.206,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2073.545999999965,
      "styleRecalcs": 83,
      "styleRecalcDurationMs": 42.147000000000006,
      "layouts": 14,
      "layoutDurationMs": 4.433999999999999,
      "taskDurationMs": 1120.343,
      "heapDeltaBytes": -6953224,
      "heapUsedBytes": 90090428,
      "domNodes": 64,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 151.26000000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1726.6030000000114,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 16.696,
      "layouts": 6,
      "layoutDurationMs": 1.108,
      "taskDurationMs": 392.515,
      "heapDeltaBytes": 5747012,
      "heapUsedBytes": 102655900,
      "domNodes": 75,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 11.89,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1727.314999999976,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 17.509999999999998,
      "layouts": 6,
      "layoutDurationMs": 1.1159999999999999,
      "taskDurationMs": 362.07800000000003,
      "heapDeltaBytes": 5843276,
      "heapUsedBytes": 102720044,
      "domNodes": 76,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 10.189999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 1015.5039999999644,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.044999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 728.8919999999999,
      "heapDeltaBytes": 7256844,
      "heapUsedBytes": 104254856,
      "domNodes": 16,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 158.588,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 922.2469999999703,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 7.0349999999999975,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 676.3000000000001,
      "heapDeltaBytes": 7150008,
      "heapUsedBytes": 104078380,
      "domNodes": 18,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 141.321,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2007.0970000000443,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.084000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 512.1139999999998,
      "heapDeltaBytes": -8727912,
      "heapUsedBytes": 96063128,
      "domNodes": -299,
      "jsHeapTotalBytes": -3702784,
      "scriptDurationMs": 40.661,
      "eventListeners": -227,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2006.5559999999323,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.582,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 515.478,
      "heapDeltaBytes": 16898040,
      "heapUsedBytes": 121203256,
      "domNodes": 12,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 31.564999999999994,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3298.4369999999785,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 11.229,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2583.4610000000002,
      "heapDeltaBytes": -5570344,
      "heapUsedBytes": 98557008,
      "domNodes": 6,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 932.437,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3251.3230000000704,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 10.504999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2415.309,
      "heapDeltaBytes": -6081824,
      "heapUsedBytes": 98645904,
      "domNodes": 8,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 887.54,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4364.870999999994,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.546,
      "layouts": 60,
      "layoutDurationMs": 12.775,
      "taskDurationMs": 2481.756,
      "heapDeltaBytes": 3816328,
      "heapUsedBytes": 113452428,
      "domNodes": 28,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 846.563,
      "eventListeners": 12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4309.418000000051,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 12.815,
      "layouts": 60,
      "layoutDurationMs": 12.045,
      "taskDurationMs": 2405.612,
      "heapDeltaBytes": 3834476,
      "heapUsedBytes": 113483048,
      "domNodes": 28,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 839.387,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 4877.194000000031,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.250999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3654.312,
      "heapDeltaBytes": -13730028,
      "heapUsedBytes": 98982268,
      "domNodes": 0,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 1023.5450000000002,
      "eventListeners": 192,
      "totalBlockingTimeMs": 6,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 4739.060999999992,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 5.44,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3504.384,
      "heapDeltaBytes": -12166848,
      "heapUsedBytes": 99981108,
      "domNodes": 4,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 975.63,
      "eventListeners": 192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999952,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "minimap-idle",
      "durationMs": 1997.2629999999754,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.842000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 545.4579999999999,
      "heapDeltaBytes": -9853164,
      "heapUsedBytes": 96325192,
      "domNodes": 8,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 35.397000000000006,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 1997.1869999999399,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.585999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 497.07500000000005,
      "heapDeltaBytes": -9957704,
      "heapUsedBytes": 96272200,
      "domNodes": 8,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 32.743,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 754.1060000000357,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.600999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 545.128,
      "heapDeltaBytes": -5500404,
      "heapUsedBytes": 91827248,
      "domNodes": 18,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 141.928,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 709.9419999999554,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.192,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 508.90900000000005,
      "heapDeltaBytes": -5847720,
      "heapUsedBytes": 91963588,
      "domNodes": 18,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 135.435,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2034.4809999999711,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 11.67,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 511.66099999999994,
      "heapDeltaBytes": 2834448,
      "heapUsedBytes": 100510112,
      "domNodes": 20,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 9.149000000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.912999999964,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.888000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 415.915,
      "heapDeltaBytes": 3014588,
      "heapUsedBytes": 100671836,
      "domNodes": 16,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 6.3149999999999995,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1857.416999999998,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 43.488,
      "layouts": 18,
      "layoutDurationMs": 5.851,
      "taskDurationMs": 1122.6370000000002,
      "heapDeltaBytes": 6568380,
      "heapUsedBytes": 104089212,
      "domNodes": 69,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 118.381,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1855.0750000000562,
      "styleRecalcs": 82,
      "styleRecalcDurationMs": 40.86899999999999,
      "layouts": 18,
      "layoutDurationMs": 6.077,
      "taskDurationMs": 1076.448,
      "heapDeltaBytes": 6681888,
      "heapUsedBytes": 103578792,
      "domNodes": 71,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 110.33,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1399.159999999938,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 30.372999999999998,
      "layouts": 15,
      "layoutDurationMs": 13.727999999999998,
      "taskDurationMs": 910.239,
      "heapDeltaBytes": 21678948,
      "heapUsedBytes": 116204584,
      "domNodes": 13671,
      "jsHeapTotalBytes": 1835008,
      "scriptDurationMs": 31.33299999999999,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 135,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 12515.918999999996,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 35.774,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9036.006,
      "heapDeltaBytes": -2539996,
      "heapUsedBytes": 101761964,
      "domNodes": -280,
      "jsHeapTotalBytes": -2015232,
      "scriptDurationMs": 3106.279,
      "eventListeners": -173,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 12367.274000000067,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 34.143,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8873.247,
      "heapDeltaBytes": -13467620,
      "heapUsedBytes": 90975224,
      "domNodes": -282,
      "jsHeapTotalBytes": -372736,
      "scriptDurationMs": 3080.249,
      "eventListeners": -173,
      "totalBlockingTimeMs": 1,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17476.21700000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16652.459,
      "heapDeltaBytes": -22181972,
      "heapUsedBytes": 200082396,
      "domNodes": -6548,
      "jsHeapTotalBytes": 14020608,
      "scriptDurationMs": 310.402,
      "eventListeners": -7456,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.773333333333238,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17660.12699999999,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16952.249000000003,
      "heapDeltaBytes": -16952068,
      "heapUsedBytes": 198716384,
      "domNodes": -6548,
      "jsHeapTotalBytes": 6754304,
      "scriptDurationMs": 361.38100000000003,
      "eventListeners": -7455,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21920.545000000006,
      "styleRecalcs": 177,
      "styleRecalcDurationMs": 18.037000000000024,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21504.165999999997,
      "heapDeltaBytes": -43962248,
      "heapUsedBytes": 198685896,
      "domNodes": -6548,
      "jsHeapTotalBytes": 5443584,
      "scriptDurationMs": 883.5310000000001,
      "eventListeners": -7449,
      "totalBlockingTimeMs": 130,
      "frameDurationMs": 18.333333333333453,
      "p95FrameDurationMs": 16.700000000004366
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22372.044000000074,
      "styleRecalcs": 177,
      "styleRecalcDurationMs": 20.630000000000038,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22021.958,
      "heapDeltaBytes": -32499980,
      "heapUsedBytes": 189688648,
      "domNodes": -6548,
      "jsHeapTotalBytes": 11288576,
      "scriptDurationMs": 982.11,
      "eventListeners": -7447,
      "totalBlockingTimeMs": 79,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 129.5709999999417,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 21.385,
      "layouts": 6,
      "layoutDurationMs": 2.5269999999999997,
      "taskDurationMs": 106.437,
      "heapDeltaBytes": 3620568,
      "heapUsedBytes": 95949192,
      "domNodes": 129,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 5.791000000000001,
      "eventListeners": 27,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "workflow-execution",
      "durationMs": 494.07399999995505,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 24,
      "layouts": 4,
      "layoutDurationMs": 1.7329999999999999,
      "taskDurationMs": 146.367,
      "heapDeltaBytes": 6014396,
      "heapUsedBytes": 98774412,
      "domNodes": 147,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.857000000000001,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

🔬 E2E Coverage

⚠️ Coverage collection failed. Check the CI workflow logs.

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                     Coverage Diff                      @@
##           nathaniel/agent-panel-v1   #16660      +/-   ##
============================================================
+ Coverage                     80.67%   82.97%   +2.30%     
============================================================
  Files                          2339     2009     -330     
  Lines                        120790   115715    -5075     
  Branches                      35560    33893    -1667     
============================================================
- Hits                          97444    96017    -1427     
+ Misses                        22849    19354    -3495     
+ Partials                        497      344     -153     
Flag Coverage Δ
unit 75.87% <ø> (+0.07%) ⬆️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 379 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CodeJuggernaut

CodeJuggernaut commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Severity: Major (cross-PR conflict)

What: This test pins that parseServerDocFrame throws on malformed base64; open #16668 makes it return null ('not base64!' hits its length guard at head).

Why this is an issue: Whichever lands second goes red; both PRs also edit docFrameClient.test.ts.

Proposed Fix: Assert the shared contract (try/catch, no doc_update dispatched), or hold until #16668 lands and assert null (asserting null today fails - the decode here is bare atob).

@huang47 huang47 added risk:medium PR risk grade (advisory shadow check; grader-owned) and removed risk:R1 PR risk grade (advisory shadow check; grader-owned) labels Sep 2, 2026
@christian-byrne christian-byrne added the cursor-review Trigger multi-model Cursor agent review on this PR label Sep 2, 2026
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Superseded by #16923 (re-carry onto main): the head branch is gone and the base (nathaniel/agent-panel-v1) is frozen, but the malformed-base64 characterization still applies to current main and no equivalent test exists there yet. Closing this one; the test lives on in #16923 with original authorship preserved.

Full context

Re-carry per the prbase dead-base sweep (base tip frozen 2026-09-02; target module moved nowhere — still src/workbench/extensions/agent/crdt/docFrameClient.ts on main). Cherry-picked -x from 7d9e4fb4e onto main, single test added, 7/7 unit tests + oxfmt + eslint + vue-tsc green. Main's parser (decodeBase64 → atob, uncaught) still throws on malformed base64 in a structurally valid doc_update, so the characterization is accurate as written. The reject-without-throw change is a separate, still-open PR (#16484) with different expected behavior; this test will need a follow-up adjustment there, same as originally noted.

@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-only Agent tests, fixtures and test support only; no production changes agent-test-unit Touches Agent-related unit/component tests or their support labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-only Agent tests, fixtures and test support only; no production changes agent-test-unit Touches Agent-related unit/component tests or their support cursor-review Trigger multi-model Cursor agent review on this PR risk:medium PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants