Skip to content

Avoid running the stateless Vitest probe twice in CI and release #153

Closed

Description

@christian-byrne

At reviewed SHA 811d6a267b34f1eba2ed0969dd24ccdda565371b, both CI and release run test/stateless.test.ts once through check:stateless and again through the unfiltered full test suite.

  • Keep the unique static lint in check:stateless.
  • Remove one of the two behavioral invocations; the current duplicate also launches two fresh Node subprocesses each time.
  • Preserve one explicit behavioral probe so the statelessness contract remains merge-blocking.
Verification and scope

Exact reviewed locations:

Independent verification reproduced the workflow semantics from source. It could not produce a meaningful timing measurement in the fresh clone because dependencies were not installed; the duplicate invocation itself is deterministic from the scripts.

Open heads #123, #138, #142, and #143 do not modify these paths. Existing #149/#150 and merged #140 are unrelated.

Reviewed SHA: 811d6a267b34f1eba2ed0969dd24ccdda565371b.

Activity

  1. christian-byrne commented on Sep 4, 2026

    @christian-byrne
    ContributorAuthor

    Correction: the duplicate stateless probe moved to the frontend workspace; it was not retired. The fix is open in ComfyUI_frontend PR #16909. Keep this issue open until the workspace move and fix land.

    Full context for agent readers

    The standalone repository is read-only after comfy-multi-player PR #168, but my earlier successor check was wrong. At the exact migration head 125e8ab3a178452f534ab33f84e1a693c1734cf1, both frontend workflows still ran test/stateless.test.ts twice:

    • ci-comfy-multi-player.yaml runs check:stateless, then the unfiltered package test suite.
    • publish-comfy-multi-player.yaml does the same.
    • The package test script is vitest run, its config includes test/**/*.test.ts, and check:stateless explicitly invokes vitest run test/stateless.test.ts.

    ComfyUI_frontend PR #16909, stacked on the workspace-move branch and assigned only to christian-byrne, excludes the stateless test from each general suite while preserving check:stateless as the merge-blocking behavioral probe. Its exact head c07ff94640fa150e3c969f29d87c69199c2b7836 is green. This issue should close only after frontend PRs #16644 and #16909 merge.

  2. christian-byrne commented on Sep 23, 2026

    @christian-byrne
    ContributorAuthor

    Fixed in active standalone CI; closing.

    Full context for agent readers

    Christian's correction that comfy-multi-player remains active is now reflected in the live repository. Merged pull request #182 restored standalone ownership, CI, and release automation.

    At exact main commit c02a0ce, both workflows preserve one explicit check:stateless invocation and exclude test/stateless.test.ts from the later general suite:

    The statelessness contract remains merge-blocking without running the behavioral probe twice. Closed frontend pull request Comfy-Org/ComfyUI_frontend#16909 is no longer the consumer.

    Retirement should be revisited only when a future migration carrier exists and names the replacement gate before these standalone workflows are disabled. No workflow, release, or product branch was changed in this reconciliation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions