Repository navigation
docs(comfy-multi-player): register KA-13 and guard the invariant register - #16896
christian-byrne wants to merge 1 commit into
Conversation
…ster The stateless gate, the strict ESLint config, ADR-021 and test/stateless.test.ts all cite KA-13, but docs/INVARIANTS.md stopped at KA-12, so the label was unresolvable for anyone who followed it. Register KA-13 once, as the state-ownership invariant ADR-021 already describes, and state why it is not an alias of KA-3 (KA-3 constrains the dependency surface; KA-13 constrains state ownership; they coincide only on the framework-import ban). No citation is repointed and no rule behavior changes. Add test/invariant-ids.test.ts so this cannot recur: every KA-*/FC-* id cited in any tracked text file must resolve to a heading in docs/INVARIANTS.md. Verified by control - deleting the KA-13 heading, or suffixing it, reddens the suite. Fixes Comfy-Org/comfy-multi-player#152
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🎭 Playwright: ✅ 1914 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-04T01:29:08.827Z",
"gitSha": "bddc4c5726f12c9fcaa961d9a49d8bad0b98a160",
"branch": "desktop-shard/cmp-152-ka13-register",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2193.777999999952,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.268999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 795.617,
"heapDeltaBytes": -11380824,
"heapUsedBytes": 59015188,
"domNodes": -281,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 18.971,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2050.9279999998853,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.543,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 627.466,
"heapDeltaBytes": -11917704,
"heapUsedBytes": 57993868,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 13.310000000000002,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1989.6929999999884,
"styleRecalcs": 79,
"styleRecalcDurationMs": 48.80699999999999,
"layouts": 14,
"layoutDurationMs": 4.687,
"taskDurationMs": 1057.3619999999999,
"heapDeltaBytes": 6964068,
"heapUsedBytes": 77856644,
"domNodes": -279,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 185.17299999999997,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1900.5990000000565,
"styleRecalcs": 78,
"styleRecalcDurationMs": 44.013,
"layouts": 14,
"layoutDurationMs": 4.515,
"taskDurationMs": 974.4599999999999,
"heapDeltaBytes": -8230392,
"heapUsedBytes": 61649068,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 170.399,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1756.091000000083,
"styleRecalcs": 31,
"styleRecalcDurationMs": 20.714,
"layouts": 6,
"layoutDurationMs": 1.555,
"taskDurationMs": 467.525,
"heapDeltaBytes": 4796104,
"heapUsedBytes": 75578436,
"domNodes": 76,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 17.679000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1682.5619999999617,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.141000000000005,
"layouts": 6,
"layoutDurationMs": 1.24,
"taskDurationMs": 421.327,
"heapDeltaBytes": 5118716,
"heapUsedBytes": 75512660,
"domNodes": 74,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 14.690999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 720.7539999999426,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.795999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.1940000000001,
"heapDeltaBytes": -7500236,
"heapUsedBytes": 63296612,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 172.706,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 721.5300000000298,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.074,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.83500000000004,
"heapDeltaBytes": -7861956,
"heapUsedBytes": 62873220,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 171.05399999999997,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2039.0730000000303,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.4259999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 787.426,
"heapDeltaBytes": -14203248,
"heapUsedBytes": 87484180,
"domNodes": -270,
"jsHeapTotalBytes": -1638400,
"scriptDurationMs": 43.76199999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2070.0979999999163,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.483000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 768.967,
"heapDeltaBytes": 11160252,
"heapUsedBytes": 87435156,
"domNodes": -266,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 36.17000000000001,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 3117.202999999904,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.868000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1931.829,
"heapDeltaBytes": 29091476,
"heapUsedBytes": 93901816,
"domNodes": -277,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 969.949,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2873.068000000103,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.022000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1864.154,
"heapDeltaBytes": -9092476,
"heapUsedBytes": 93613540,
"domNodes": -271,
"jsHeapTotalBytes": -626688,
"scriptDurationMs": 893.6390000000001,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3943.94699999998,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.696999999999997,
"layouts": 60,
"layoutDurationMs": 13.207,
"taskDurationMs": 1923.9599999999996,
"heapDeltaBytes": 8322232,
"heapUsedBytes": 76007816,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 868.128,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3931.8550000000414,
"styleRecalcs": 61,
"styleRecalcDurationMs": 12.875999999999998,
"layouts": 60,
"layoutDurationMs": 14.023,
"taskDurationMs": 1913.6270000000002,
"heapDeltaBytes": 10352244,
"heapUsedBytes": 76484872,
"domNodes": -277,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 846.501,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3234.2820000000074,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.464999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2160.2999999999997,
"heapDeltaBytes": 17421580,
"heapUsedBytes": 85024404,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1049.172,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3205.895999999939,
"styleRecalcs": 40,
"styleRecalcDurationMs": 6.121999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2100.406,
"heapDeltaBytes": 26137724,
"heapUsedBytes": 93245596,
"domNodes": -280,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 1027.189,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2030.4289999999128,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.6249999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 773.426,
"heapDeltaBytes": 10651392,
"heapUsedBytes": 87474432,
"domNodes": -273,
"jsHeapTotalBytes": -2461696,
"scriptDurationMs": 39.579,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2035.4750000001332,
"styleRecalcs": 4,
"styleRecalcDurationMs": 5.995999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 695.558,
"heapDeltaBytes": 10762360,
"heapUsedBytes": 87051208,
"domNodes": -271,
"jsHeapTotalBytes": -2723840,
"scriptDurationMs": 40.59199999999999,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 678.1619999999293,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.601,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.02,
"heapDeltaBytes": 15183788,
"heapUsedBytes": 87785928,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 149.731,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 675.6780000000617,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.74,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.771,
"heapDeltaBytes": 13780044,
"heapUsedBytes": 85813100,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 158.55599999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2049.8400000000174,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.796,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 660.7219999999999,
"heapDeltaBytes": -14001200,
"heapUsedBytes": 58912724,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 13.625000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2038.3649999998852,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.898,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 649.9010000000001,
"heapDeltaBytes": -8441812,
"heapUsedBytes": 64402896,
"domNodes": -293,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 13.232000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1823.641000000066,
"styleRecalcs": 79,
"styleRecalcDurationMs": 45.176,
"layouts": 18,
"layoutDurationMs": 6.644000000000001,
"taskDurationMs": 1024.984,
"heapDeltaBytes": 2124564,
"heapUsedBytes": 75029448,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 134.545,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1857.3499999999967,
"styleRecalcs": 80,
"styleRecalcDurationMs": 52.025999999999996,
"layouts": 18,
"layoutDurationMs": 7.018,
"taskDurationMs": 1014.98,
"heapDeltaBytes": -11613112,
"heapUsedBytes": 61168128,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 132.139,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.0760000000046,
"styleRecalcs": 19,
"styleRecalcDurationMs": 36.199999999999996,
"layouts": 15,
"layoutDurationMs": 17.221999999999998,
"taskDurationMs": 1089.278,
"heapDeltaBytes": -7387604,
"heapUsedBytes": 86566248,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 38.772,
"eventListeners": 2387,
"totalBlockingTimeMs": 156,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10898.022999999966,
"styleRecalcs": 248,
"styleRecalcDurationMs": 42.31400000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6819.018,
"heapDeltaBytes": -7799256,
"heapUsedBytes": 67515860,
"domNodes": -268,
"jsHeapTotalBytes": 159744,
"scriptDurationMs": 3049.187,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9582.638000000088,
"styleRecalcs": 245,
"styleRecalcDurationMs": 37.986000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6463.381,
"heapDeltaBytes": -8153716,
"heapUsedBytes": 93695832,
"domNodes": -273,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 2881.27,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18600.66699999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17932.34,
"heapDeltaBytes": -40874264,
"heapUsedBytes": 174593680,
"domNodes": -6548,
"jsHeapTotalBytes": 2347008,
"scriptDurationMs": 401.291,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18240.004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17566.18,
"heapDeltaBytes": -41072916,
"heapUsedBytes": 175510136,
"domNodes": -6548,
"jsHeapTotalBytes": 4169728,
"scriptDurationMs": 321.58500000000004,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22910.46899999992,
"styleRecalcs": 173,
"styleRecalcDurationMs": 26.388999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22713.889,
"heapDeltaBytes": -28712788,
"heapUsedBytes": 181266528,
"domNodes": -6548,
"jsHeapTotalBytes": -4595712,
"scriptDurationMs": 1061.973,
"eventListeners": -7471,
"totalBlockingTimeMs": 208,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22076.403000000028,
"styleRecalcs": 167,
"styleRecalcDurationMs": 21.523000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21795.507,
"heapDeltaBytes": -30134432,
"heapUsedBytes": 180395484,
"domNodes": -6548,
"jsHeapTotalBytes": -6742016,
"scriptDurationMs": 941.098,
"eventListeners": -7469,
"totalBlockingTimeMs": 80,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6578.195000000051,
"styleRecalcs": 20,
"styleRecalcDurationMs": 98.13100000000003,
"layouts": 20,
"layoutDurationMs": 31.263999999999985,
"taskDurationMs": 6465.204999999999,
"heapDeltaBytes": -41822008,
"heapUsedBytes": 166976348,
"domNodes": -6548,
"jsHeapTotalBytes": 2224128,
"scriptDurationMs": 122.23600000000002,
"eventListeners": -7471,
"totalBlockingTimeMs": 333,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6638.500000000022,
"styleRecalcs": 20,
"styleRecalcDurationMs": 97.42,
"layouts": 20,
"layoutDurationMs": 39.078,
"taskDurationMs": 6560.236,
"heapDeltaBytes": -34112856,
"heapUsedBytes": 175091228,
"domNodes": -6548,
"jsHeapTotalBytes": 4218880,
"scriptDurationMs": 124.00800000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 433,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9349.751999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9104.261999999999,
"heapDeltaBytes": 6826720,
"heapUsedBytes": 174758044,
"domNodes": 0,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 198.33599999999996,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9302.110000000084,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9034.971999999998,
"heapDeltaBytes": 2862208,
"heapUsedBytes": 178057872,
"domNodes": 0,
"jsHeapTotalBytes": -11534336,
"scriptDurationMs": 187.41600000000003,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 511.7370000000392,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.400000000000002,
"layouts": 3,
"layoutDurationMs": 1.6649999999999998,
"taskDurationMs": 132.76500000000001,
"heapDeltaBytes": 5064020,
"heapUsedBytes": 73205884,
"domNodes": 149,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 13.979999999999997,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 127.64700000002449,
"styleRecalcs": 9,
"styleRecalcDurationMs": 17.266,
"layouts": 2,
"layoutDurationMs": 0.8440000000000001,
"taskDurationMs": 85.85699999999999,
"heapDeltaBytes": 3029744,
"heapUsedBytes": 72125992,
"domNodes": 110,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.973999999999998,
"eventListeners": 35,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## christian-byrne/ecw-106-comfy-multi-player-workspace #16896 +/- ##
=====================================================================================
Coverage 80.79% 80.80%
=====================================================================================
Files 2475 2475
Lines 128216 128216
Branches 34553 34553
=====================================================================================
+ Hits 103597 103603 +6
+ Misses 24103 24097 -6
Partials 516 516
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Standalone replacement: governance recovery. Frontend relocation remains deferred. Full context for agent readersThe replacement recovers governance tests and invariant registration into comfy-multi-player main. The duplicate frontend-workflow deletion is accounted for by the already-landed standalone restoration, not copied into the replacement. The replacement body attributes all ten captured comments across the three governance sources, retaining authors, dates and direct links. The earlier instruction to keep this work stacked on the frontend relocation is superseded by Christian's standalone ruling. Historical checks and review-skipped notices are preserved as history, not fresh verification or approvals. The replacement passed its local tests and gates; hosted checks and actual review remain required. This source stays preserved until code, collaboration and late-comment accounting complete. No source branch or review thread is deleted or resolved by this message. |
|
Superseded by the merged standalone recovery: Full context for agent readersChristian authorized completing source retirement after confirming that comfy-multi-player remains the canonical package repository. This frontend branch must not be retargeted to frontend main or merged into the abandoned relocation branch. Code accounting: the invariant registration, document-clock decision cross-reference, and invariant identifier test were recovered by the merged replacement. Source revision: 7532c2d . Replacement merge: Comfy-Org/comfy-multi-player@1a689e8 . The preserved statelessness invariant and its regression guard remain at:
Collaboration accounting: refreshed all four issue comments, native reviews and inline comments before retirement. No new substantive feedback since the September 17 recovery link, and no native reviews or inline findings. Original authors/dates/links are attributed in the replacement body; the previous recovery receipt is #16896 (comment) . Historical frontend checks and skipped bot review are not transferred approvals or fresh verification. This closes only this superseded source. No branch deletion, review resolution, publication, deployment or product-acceptance claim. No local verification ran under the owner's resource hold. Glossary: statelessness means package state remains owned by the caller's document; retirement means closing the redundant source pull request, not deleting its history. |
Summary
docs/INVARIANTS.mdstopped atKA-12while four compliance surfaces citedKA-13, so the label was unresolvable for anyone who followed it; this registersKA-13once and adds a guard so an unregistered id cannot ship again.Changes
KA-13entry topackages/comfy-multi-player/docs/INVARIANTS.mdas the state-ownership invariant that ADR-021 already describes andscripts/check-stateless.mjsalready enforces. Makes ADR-021's glossary line link to the register. Addstest/invariant-ids.test.ts, which asserts that everyKA-*/FC-*id cited in any tracked text file in the package resolves to a heading indocs/INVARIANTS.md.No citation is repointed, no alias is invented, and no rule behavior changes. The four existing
KA-13citations (test/stateless.test.ts:25,.agents/checks/eslint.strict.config.js:32-53,scripts/check-stateless.mjs:3,docs/decisions/ADR-021-doc-derived-lamport-clock-store.md) are untouched and now resolve.Review Focus
Why
KA-13is registered rather than folded intoKA-3. They are genuinely different rules that overlap on one clause.KA-3constrains the dependency surface (no DOM/framework/LiteGraph/server-only deps,yjsonly) so the applier is portable.KA-13constrains state ownership (no module-levellet/var, no module-level mutable collection, caller-owned documents only) so behavior does not depend on process lifetime or module-registry identity. They coincide only on the framework-import ban, which is whycheck-stateless.mjscites both and why the strict config labels its framework rulesKA-3/KA-13. Folding them would have lost the module-level-mutable-state half, whichKA-3does not cover. The entry states the distinction so the next reader does not re-derive it.The
documentTransactionTailsexception is stated, not hidden. ADR-021 amendment CLK-2'sY.Doc-keyed weak registry is the single allowlisted module-level collection; the entry names it and says why it is not durable or cross-document state.The guard's regex boundary is the subtle part.
/KA-\d+\b/readsKA-13-SOMETHINGas a citation ofKA-13, because a digit followed by-is a word boundary. My first draft had this and its negative control passed for the wrong reason. Both patterns now require a non-id character on the right. Controls run: deleting theKA-13heading reddens the suite (4 unresolved citations), and renaming it toKA-13-FOOalso reddens it.KA-0/FC-0is skipped as the documented placeholder row in theEXCEPTIONS.mdtable template.Scope of the guard. It is a register-integrity check, not a coverage check: it says an id is defined, never that it is guarded. The
UNGUARDEDmarkers stay the register's own business. It reads the working tree throughgit ls-files, so a citation in a new file is covered without extending a list.Verification
Run in this worktree at
7532c2d3d1, Node 25.9.0, pnpm 11.13.1:pnpm --filter @comfyorg/comfy-multi-player test— 72 files, 878 tests, all passtypecheck,lint,check:stateless,check:purity,check:imports,check:pins,check:profile-claims,check:coderabbit— all passProvenance
This fixes Comfy-Org/comfy-multi-player#152. It is opened here, based on #16644, rather than on the standalone repo, because that repo's
AGENTS.mdand PR template now declare it read-only history and direct all future work to this path. The gap is present in both copies; landing it here keeps a single writable source of truth. Fixing it there instead would need a maintainer decision to override the retirement notice.Fixes Comfy-Org/comfy-multi-player#152