Repository navigation
docs(adr): follow-up to #16459 — record widget restoration contract - #16862
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe ADR now records an accepted PrimitiveNode widget restoration lifecycle. It covers workflow loading, copy/paste, shared restoration state, deferred dynamic widget restoration, identity-based storage, cleanup, and preservation of ChangesPrimitiveNode restoration lifecycle
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: 🟡 Moderate · up to The documentation change may present an unimplemented coordinator as an accepted restoration-lifecycle requirement, which could misdirect future implementation and maintenance. Remove or separate that claim before merging. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The changed files are available and show documentation-only changes under ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
⚡ Performance
|
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve
I compared this ADR line by line with the merged #16459 implementation on current origin/main. The shared WidgetRestorationState, base-configure cleanup, Primitive restaging conditions, generic lookup, type-mismatch cleanup, disconnect cleanup, and graph/node store identity are represented accurately. The ADR index title, status, date, and numbering also match.
Maintainability-skill finding: the speculative future-system paragraph at line 48 should be deleted. #16459 does not implement that system, and the paragraph defines neither an invariant nor a condition for adopting it. This is non-blocking; the implemented restoration decision is otherwise complete and accurate.
Checks: Oxfmt passed on both changed files; git diff --check passed; ADR numbering remains sequential from 0001 through 0027; ADR 0006’s index title, status, and date match; referenced files and implementation symbols exist.
| build consumes the state through the generic lookup path. A completed build, | ||
| type mismatch, or disconnect clears any unconsumed state. | ||
|
|
||
| Do not add a Primitive-specific restoration type, store, or scheduler. A general |
There was a problem hiding this comment.
Please delete this future-system paragraph. #16459 implements no connectivity-to-widget-materialization system or authoritative coordinator, and this ADR provides no invariant or adoption condition for one. In an Accepted ADR, that speculative replacement reads as accepted design direction while adding nothing to the restoration contract. The current decision is complete without it.
# Conflicts: # docs/adr/README.md # docs/adr/WIDGET-SERIALIZATION-0006-preserve-primitive-widget-values-across-copy-and-paste.md
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve
The only head change since my prior review is a merge from main; the PR's own ADR text is unchanged. The restoration contract still matches the implementation, every referenced file and symbol resolves on current main, WIDGET-SERIALIZATION-0006 is unique under the domain-led identifier scheme, and the index merges cleanly.
Maintainability: the existing open finding remains. The future-system paragraph still describes an unimplemented coordinator without an invariant or adoption condition. I concur with the earlier request to delete it rather than duplicating that finding in a new inline comment. This remains non-blocking, and I found no additional duplicated architectural authority or speculative representation.
Formatting and ADR index validation pass on the current head.
…view follow-up to PR 16862) (Comfy-Org#17590) Resolves the surviving review request from [PR 16862 (PrimitiveNode widget restoration ADR follow-up)](Comfy-Org#16862): [DrJKL asked to delete the speculative future-system paragraph](Comfy-Org#16862 (comment)) in the widget-values copy/paste ADR (WIDGET-SERIALIZATION-0006, file [`docs/adr/WIDGET-SERIALIZATION-0006-preserve-primitive-widget-values-across-copy-and-paste.md`](https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/docs/adr/WIDGET-SERIALIZATION-0006-preserve-primitive-widget-values-across-copy-and-paste.md)). ## What changed Removes one sentence from the Decision section: > A general connectivity-to-widget-materialization system can replace the remaining lifecycle ordering when the application has an authoritative coordinator for that phase. Per the review: [PR 16459 (the ADR's implementation PR)](Comfy-Org#16459) implements no connectivity-to-widget-materialization system or authoritative coordinator, and the ADR defines no invariant or adoption condition for one, so the sentence reads as accepted design direction while adding nothing to the restoration contract. ## What is preserved The accepted restoration contract is intact: - "Do not add a Primitive-specific restoration type, store, or scheduler." (kept, immediately preceding the removed sentence) - The Alternatives Considered entry rejecting a Primitive-only restoration store/System - All Consequences unchanged ## Verification - `grep` confirms no remaining connectivity-to-widget-materialization / authoritative-coordinator references in the ADR - `oxfmt --check` passes on the changed file (lint-staged hook green at commit) Task row: srx-20260948.
Records the shared widget-restoration contract introduced by #16459.
Full context for agent readers
Summary
Updates ADR 0006 for the implementation that now shares
WidgetRestorationStatebetweenLGraphNode.configure()andPrimitiveNode.configure(). It documents why Primitive restoration outlives base configuration, how generic lookup and cleanup work, and why a Primitive-only store or scheduler was rejected.This follows up the final-head review request and its review envelope.
Changes
Evidence
git diff --check— passed.pnpm exec oxfmt --check docs/adr/0006-primitive-node-copy-paste-lifecycle.md docs/adr/README.md— passed.