Skip to content

docs(adr): drop speculative future-system paragraph from ADR-0006 (review follow-up to PR 16862) - #17590

Merged
christian-byrne merged 1 commit into
mainfrom
docs/adr-0006-drop-speculative-coordinator
Nov 4, 2026
Merged

christian-byrne merged 1 commit into
mainfrom
docs/adr-0006-drop-speculative-coordinator

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Resolves the surviving review request from PR 16862 (PrimitiveNode widget restoration ADR follow-up): DrJKL asked to delete the speculative future-system paragraph in the widget-values copy/paste ADR (WIDGET-SERIALIZATION-0006, file docs/adr/WIDGET-SERIALIZATION-0006-preserve-primitive-widget-values-across-copy-and-paste.md).

What changed

Removes one sentence from the Decision section:

A general connectivity-to-widget-materialization system can replace the remaining lifecycle ordering when the application has an authoritative coordinator for that phase.

Per the review: PR 16459 (the ADR's implementation PR) implements no connectivity-to-widget-materialization system or authoritative coordinator, and the ADR defines no invariant or adoption condition for one, so the sentence reads as accepted design direction while adding nothing to the restoration contract.

What is preserved

The accepted restoration contract is intact:

  • "Do not add a Primitive-specific restoration type, store, or scheduler." (kept, immediately preceding the removed sentence)
  • The Alternatives Considered entry rejecting a Primitive-only restoration store/System
  • All Consequences unchanged

Verification

  • grep confirms no remaining connectivity-to-widget-materialization / authoritative-coordinator references in the ADR
  • oxfmt --check passes on the changed file (lint-staged hook green at commit)

Task row: srx-20260948.

Per DrJKL's review request on #16862 (r3931653113): #16459 implements no
connectivity-to-widget-materialization system or authoritative coordinator,
and the ADR defines no invariant or adoption condition for one. The accepted
restoration contract (no Primitive-specific restoration type, store, or
scheduler) is preserved.

Source: #16862 (comment)
@christian-byrne
christian-byrne requested a review from a team September 13, 2026 01:32
@christian-byrne christian-byrne self-assigned this Sep 13, 2026
@coderabbitai

coderabbitai Bot commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 3828c62e-acfd-41fe-86c5-65f2a71766ec

📥 Commits

Reviewing files that changed from the base of the PR and between 9d69f83 and eb7faa4.

📒 Files selected for processing (1)
  • docs/adr/WIDGET-SERIALIZATION-0006-preserve-primitive-widget-values-across-copy-and-paste.md

Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The ADR now states that no Primitive-specific restoration type, store, or scheduler should be added. It removes a deferred alternative involving a general connectivity-to-widget-materialization coordinator.

Changes

Widget serialization ADR

Layer / File(s) Summary
Update serialization decision
docs/adr/WIDGET-SERIALIZATION-0006-preserve-primitive-widget-values-across-copy-and-paste.md
The ADR removes the statement that a general connectivity-to-widget-materialization system could replace lifecycle ordering when an authoritative coordinator exists.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: anupreet-comfy

Merge Risk: ⚪ Minimal · up to eb7fa

The ADR clarification does not change the accepted restoration contract and is ready to merge.


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ❓ Inconclusive The changed-file information is available and shows only a documentation file. However, the review context does not provide the actual PR title or commit subjects. The custom check requires an inconcl… Provide the PR title and the actual commit subjects, then reassess the check. Based on the available file list, the documentation-only exception would otherwise prevent a failure.
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the ADR documentation change and explains that it removes a speculative future-system paragraph.
Description check ✅ Passed The description explains the reason for the change, identifies the removed content, states what remains unchanged, and documents verification. It does not use all template headings, but it provides th…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Website End-To-End Regression Coverage ✅ Passed The PR changes only docs/adr/WIDGET-SERIALIZATION-0006-preserve-primitive-widget-values-across-copy-and-paste.md. It does not change files under apps/website/src/ or apps/website/public/, so the…
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed-file list contains only docs/adr/WIDGET-SERIALIZATION-0006-preserve-primitive-widget-values-across-copy-and-paste.md. It does not include src/lib/litegraph/, src/ecs/, or a graph-ent…
Full details: End-To-End Regression Coverage For Fixes

Explanation

The changed-file information is available and shows only a documentation file. However, the review context does not provide the actual PR title or commit subjects. The custom check requires an inconclusive result when commit subjects are unavailable, so the bug-fix language condition cannot be verified from the permitted metadata.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/adr-0006-drop-speculative-coordinator

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the risk:medium PR risk grade (advisory shadow check; grader-owned) label Sep 13, 2026
@mrseek-reviews
mrseek-reviews Bot requested a review from DrJKL November 4, 2026 08:34
@christian-byrne
christian-byrne added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit ecac194 Nov 4, 2026
65 checks passed
@christian-byrne
christian-byrne deleted the docs/adr-0006-drop-speculative-coordinator branch November 4, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:medium PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants