Repository navigation
fix: clear stale primitive restoration - #16841
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1921 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.78 MB gzip 🟢 -51 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 128 kB (baseline 128 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 28.9 kB (baseline 28.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 558 kB (baseline 558 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 18 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.8 MB (baseline 16.8 MB) • 🔴 +43 BBundles that do not match a named category
Status: 72 added / 72 removed / 224 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-07T04:52:10.071Z",
"gitSha": "3f9f6ae19f58837ca0dbacf56b900b773ebbf98a",
"branch": "fix/primitive-restoration-lifecycle",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2105.3679999999986,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.561,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 649.8399999999999,
"heapDeltaBytes": 9791260,
"heapUsedBytes": 79463788,
"domNodes": -277,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 11.307999999999998,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2049.923999999919,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.090000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 608.96,
"heapDeltaBytes": -1660240,
"heapUsedBytes": 68294300,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 12.510999999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1880.6500000000028,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.305,
"layouts": 14,
"layoutDurationMs": 4.724,
"taskDurationMs": 917.9470000000001,
"heapDeltaBytes": 2732024,
"heapUsedBytes": 73080328,
"domNodes": -278,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 152.671,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2003.7710000000288,
"styleRecalcs": 80,
"styleRecalcDurationMs": 46.32,
"layouts": 14,
"layoutDurationMs": 4.800000000000001,
"taskDurationMs": 999.62,
"heapDeltaBytes": -7043632,
"heapUsedBytes": 63417744,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 155.98499999999999,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.6909999999934,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.410999999999998,
"layouts": 6,
"layoutDurationMs": 1.14,
"taskDurationMs": 381.982,
"heapDeltaBytes": 5105332,
"heapUsedBytes": 75841588,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.096000000000004,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.6800000000212,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.562999999999995,
"layouts": 6,
"layoutDurationMs": 1.092,
"taskDurationMs": 404.894,
"heapDeltaBytes": 4477656,
"heapUsedBytes": 73285544,
"domNodes": 75,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 14.445000000000004,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 742.8069999999707,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.525,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.7250000000001,
"heapDeltaBytes": -7487704,
"heapUsedBytes": 63078888,
"domNodes": 18,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 155.704,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 735.7660000000124,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.941000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.267,
"heapDeltaBytes": -7777164,
"heapUsedBytes": 63032832,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 165.41400000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2073.3450000000175,
"styleRecalcs": 4,
"styleRecalcDurationMs": 12.238999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 708.217,
"heapDeltaBytes": 11090068,
"heapUsedBytes": 86499740,
"domNodes": -274,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 35.649999999999984,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.173999999979,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.6449999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 637.6930000000001,
"heapDeltaBytes": -14879972,
"heapUsedBytes": 87617120,
"domNodes": -273,
"jsHeapTotalBytes": -1376256,
"scriptDurationMs": 33.840999999999994,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2365.3439999999932,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.042,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1676.822,
"heapDeltaBytes": 26153132,
"heapUsedBytes": 92027196,
"domNodes": -276,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 825.086,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2274.7980000000325,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.26,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1665.7440000000001,
"heapDeltaBytes": 23310064,
"heapUsedBytes": 89519408,
"domNodes": -272,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 796.5629999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3780.635000000018,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.395,
"layouts": 60,
"layoutDurationMs": 14.086000000000002,
"taskDurationMs": 1786.2969999999998,
"heapDeltaBytes": 12164660,
"heapUsedBytes": 80372948,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 814.661,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3731.279000000086,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.803,
"layouts": 60,
"layoutDurationMs": 14.244,
"taskDurationMs": 1837.8839999999998,
"heapDeltaBytes": 8192304,
"heapUsedBytes": 75760740,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 805.4780000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3111.761999999999,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.621999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1968.8169999999998,
"heapDeltaBytes": 22864096,
"heapUsedBytes": 90072188,
"domNodes": 0,
"jsHeapTotalBytes": 1990656,
"scriptDurationMs": 958.723,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3199.561000000017,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.815999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2130.8030000000003,
"heapDeltaBytes": 22023288,
"heapUsedBytes": 88686516,
"domNodes": -278,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 1058.9360000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2040.996000000007,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.6760000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 642.549,
"heapDeltaBytes": 10533680,
"heapUsedBytes": 87472912,
"domNodes": -275,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 37.3,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2002.207999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 601.7020000000001,
"heapDeltaBytes": 21509516,
"heapUsedBytes": 89365464,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.302,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 624.463999999989,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.826,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.38400000000007,
"heapDeltaBytes": 15042268,
"heapUsedBytes": 87832840,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 147.29399999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 672.5010000000111,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.111999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.8070000000001,
"heapDeltaBytes": 14645988,
"heapUsedBytes": 86510540,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 149.90800000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2037.3779999999897,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.634000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 553.6659999999999,
"heapDeltaBytes": 9517248,
"heapUsedBytes": 75185664,
"domNodes": -296,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.464,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.7730000000292,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.485000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 613.9319999999999,
"heapDeltaBytes": 1956480,
"heapUsedBytes": 74600452,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 11.046999999999997,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1774.9970000000417,
"styleRecalcs": 78,
"styleRecalcDurationMs": 45.398,
"layouts": 18,
"layoutDurationMs": 6.291999999999999,
"taskDurationMs": 890.4429999999999,
"heapDeltaBytes": -620068,
"heapUsedBytes": 71153676,
"domNodes": -293,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 112.47699999999999,
"eventListeners": -222,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1734.1389999999137,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.702,
"layouts": 18,
"layoutDurationMs": 5.702000000000001,
"taskDurationMs": 894.227,
"heapDeltaBytes": 335980,
"heapUsedBytes": 71970296,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 116.66600000000001,
"eventListeners": -222,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.7479999999978,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.729999999999993,
"layouts": 15,
"layoutDurationMs": 15.450999999999995,
"taskDurationMs": 990.7490000000001,
"heapDeltaBytes": 21918128,
"heapUsedBytes": 105079268,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 33.05,
"eventListeners": 2385,
"totalBlockingTimeMs": 135,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8809.56900000001,
"styleRecalcs": 246,
"styleRecalcDurationMs": 41.041,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5930.1,
"heapDeltaBytes": 17451708,
"heapUsedBytes": 93498052,
"domNodes": -272,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 2654.313,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9438.007999999969,
"styleRecalcs": 246,
"styleRecalcDurationMs": 41.17799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6400.8189999999995,
"heapDeltaBytes": 18246480,
"heapUsedBytes": 94672692,
"domNodes": -270,
"jsHeapTotalBytes": 352256,
"scriptDurationMs": 2879.067,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18336.93599999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17652.989999999998,
"heapDeltaBytes": -34094500,
"heapUsedBytes": 176912680,
"domNodes": -6548,
"jsHeapTotalBytes": 5754880,
"scriptDurationMs": 301.223,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 18217.587999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17740.509000000002,
"heapDeltaBytes": -41158328,
"heapUsedBytes": 174635296,
"domNodes": -6548,
"jsHeapTotalBytes": 2347008,
"scriptDurationMs": 339.10699999999997,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 23465.913,
"styleRecalcs": 180,
"styleRecalcDurationMs": 25.646999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23172.073999999997,
"heapDeltaBytes": -36279484,
"heapUsedBytes": 167266908,
"domNodes": -6548,
"jsHeapTotalBytes": 2609152,
"scriptDurationMs": 949.9,
"eventListeners": -7467,
"totalBlockingTimeMs": 144,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-large-graph-pan",
"durationMs": 23409.701999999925,
"styleRecalcs": 178,
"styleRecalcDurationMs": 24.224999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23152.409,
"heapDeltaBytes": -33947792,
"heapUsedBytes": 176289088,
"domNodes": -6548,
"jsHeapTotalBytes": -3870720,
"scriptDurationMs": 949.4469999999999,
"eventListeners": -7467,
"totalBlockingTimeMs": 92,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6601.954999999975,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.24900000000001,
"layouts": 20,
"layoutDurationMs": 25.694999999999997,
"taskDurationMs": 6474.469999999999,
"heapDeltaBytes": -28502956,
"heapUsedBytes": 179461140,
"domNodes": -6548,
"jsHeapTotalBytes": 12939264,
"scriptDurationMs": 120.07,
"eventListeners": -7469,
"totalBlockingTimeMs": 428,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6594.810000000052,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.07800000000003,
"layouts": 20,
"layoutDurationMs": 26.329000000000004,
"taskDurationMs": 6521.75,
"heapDeltaBytes": -22849584,
"heapUsedBytes": 187575544,
"domNodes": -6548,
"jsHeapTotalBytes": 10547200,
"scriptDurationMs": 122.40100000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 436,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9204.305999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8954.387999999999,
"heapDeltaBytes": 4326796,
"heapUsedBytes": 176290480,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 152.79200000000003,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9206.103999999981,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8981.199,
"heapDeltaBytes": 14116728,
"heapUsedBytes": 174851076,
"domNodes": 0,
"jsHeapTotalBytes": -1048576,
"scriptDurationMs": 183.69299999999998,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.33666666666674,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 447.6910000000771,
"styleRecalcs": 12,
"styleRecalcDurationMs": 18.209999999999997,
"layouts": 3,
"layoutDurationMs": 1.0570000000000002,
"taskDurationMs": 105.146,
"heapDeltaBytes": 4818492,
"heapUsedBytes": 73804320,
"domNodes": 120,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.633999999999999,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 477.9009999999744,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.538,
"layouts": 3,
"layoutDurationMs": 1.463,
"taskDurationMs": 116.049,
"heapDeltaBytes": 4920672,
"heapUsedBytes": 72395096,
"domNodes": 144,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.008000000000001,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughPrimitive widget restoration now runs only for nodes with output links. Tests cover registered reroute nodes, graph configuration callbacks, deferred widget creation, and stale serialized values after connection. ChangesReroute widget restoration
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to Primitive restoration now avoids applying stale serialized values after an unconnected node is linked, with unit and browser coverage for the affected lifecycle. No current merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16841 +/- ##
==========================================
+ Coverage 81.42% 82.94% +1.52%
==========================================
Files 2480 2050 -430
Lines 127253 119590 -7663
Branches 34641 33310 -1331
==========================================
- Hits 103612 99198 -4414
+ Misses 23127 20212 -2915
+ Partials 514 180 -334
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 441 files with indirect coverage changes 🚀 New features to boost your workflow:
|
## Summary Maps unsupported Primitive input specs to LiteGraph's declared `custom` widget boundary instead of suppressing the type error. ## Changes - **What**: Replaces the arbitrary widget-type call with the typed `custom` fallback and covers unsupported input specs with a regression test. ## Review Focus Confirm custom input specs still create a fallback widget while satisfying `LGraphNode.addWidget()`'s `TWidgetType` contract. This carries the remaining request from [Comfy-Org#16459's review](Comfy-Org#16459 (review)); Comfy-Org#16841 carries the other two findings. ## Evidence - `pnpm test:unit src/extensions/core/widgetInputs.test.ts -t "creates a custom widget for unsupported widget types"` — failed first: received `custom_widget`, expected `custom`. - `pnpm test:unit src/extensions/core/widgetInputs.test.ts` — 32 passed. - `pnpm typecheck` — passed. - `pnpm lint:unstaged` — passed with two existing ignore-pattern warnings. - `pnpm format:check src/extensions/core/widgetInputs.ts src/extensions/core/widgetInputs.test.ts` — passed. - Commit hook: oxfmt, oxlint, eslint, typecheck — passed. - Push hook: knip — passed. <!-- authored-by:agent lane-act-fe-16459-followup-2978d62d-2234 -->
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Summary
Prevents an unconnected Primitive node loaded from a workflow from applying its stale serialized value to a later connection. Follow-up to #16459, addressing the stale-restoration finding and reroute lifecycle test gap.
Changes
Review Focus
Full graph loading registers links before node configuration. Linked Primitive → Reroute workflows therefore keep deferred restoration, while an unlinked Primitive no longer carries serialized state into a future user connection.
Red-Green Verification
222instead of target111.The focused Playwright scenario is independently regression-sensitive: temporarily removing the production guard makes it fail with
Expected: 0, Received: 222; restoring the guard makes it pass.Test Plan
pnpm test:unit src/extensions/core/widgetInputs.test.ts(31 passed)pnpm test:browser:local browser_tests/tests/primitiveNode.spec.ts --grep "without restoring a stale value"(1 passed)pnpm typecheckpnpm typecheck:browser