Repository navigation
fix: type Primitive custom widget fallback - #16864
Conversation
|
Warning Review limit reachedNext included review available in 12 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1908 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.69 MB gzip 🔴 +72 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 559 kB (baseline 559 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 18 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • 🔴 +95 BBundles that do not match a named category
Status: 72 added / 72 removed / 224 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-04T07:16:19.060Z",
"gitSha": "c27c3700287cdadd5083236c97680e21a371e8fc",
"branch": "fix/typed-custom-widget-adapter",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2042.9739999999583,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.9140000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.3540000000001,
"heapDeltaBytes": 9534556,
"heapUsedBytes": 80239440,
"domNodes": -278,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.552999999999997,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2046.100000000024,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.133000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.347,
"heapDeltaBytes": -12596392,
"heapUsedBytes": 57200100,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.521,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1856.045999999992,
"styleRecalcs": 78,
"styleRecalcDurationMs": 37.163999999999994,
"layouts": 14,
"layoutDurationMs": 4.81,
"taskDurationMs": 873.7439999999999,
"heapDeltaBytes": -8556640,
"heapUsedBytes": 62093660,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 144.53100000000003,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1877.055999999925,
"styleRecalcs": 78,
"styleRecalcDurationMs": 38.691,
"layouts": 14,
"layoutDurationMs": 4.753,
"taskDurationMs": 880.0859999999999,
"heapDeltaBytes": 5013664,
"heapUsedBytes": 75582420,
"domNodes": -278,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 141.279,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.6370000000006,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.824,
"layouts": 6,
"layoutDurationMs": 1.1090000000000002,
"taskDurationMs": 365.68399999999997,
"heapDeltaBytes": 5056152,
"heapUsedBytes": 75866316,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.221000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.2570000000424,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.714,
"layouts": 6,
"layoutDurationMs": 1.383,
"taskDurationMs": 354.228,
"heapDeltaBytes": 5071268,
"heapUsedBytes": 75895664,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.622,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 655.2329999999529,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.238999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.41200000000003,
"heapDeltaBytes": -7883280,
"heapUsedBytes": 62949204,
"domNodes": 20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 159.047,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 637.3190000000477,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.321000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.068,
"heapDeltaBytes": -7909952,
"heapUsedBytes": 62858448,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 154.98800000000003,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2041.3600000000542,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.547000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 600.9219999999999,
"heapDeltaBytes": -13858580,
"heapUsedBytes": 87990348,
"domNodes": -270,
"jsHeapTotalBytes": -1114112,
"scriptDurationMs": 33.574999999999996,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.6899999999741,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.399000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 609.004,
"heapDeltaBytes": -13923152,
"heapUsedBytes": 87035328,
"domNodes": -264,
"jsHeapTotalBytes": -65536,
"scriptDurationMs": 36.642,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2196.207999999956,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.050999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1592.725,
"heapDeltaBytes": 19827652,
"heapUsedBytes": 85517448,
"domNodes": -276,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 792.497,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2181.116999999972,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.443000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1531.3909999999996,
"heapDeltaBytes": 19037420,
"heapUsedBytes": 84707912,
"domNodes": -268,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 743.255,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3519.271999999887,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.25,
"layouts": 60,
"layoutDurationMs": 12.748000000000001,
"taskDurationMs": 1661.898,
"heapDeltaBytes": 8005216,
"heapUsedBytes": 76028232,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 756.9530000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3499.924999999962,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.931000000000003,
"layouts": 60,
"layoutDurationMs": 12.988,
"taskDurationMs": 1649.639,
"heapDeltaBytes": 11752224,
"heapUsedBytes": 79918864,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 758.576,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3071.409000000017,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.048999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1860.514,
"heapDeltaBytes": 22248352,
"heapUsedBytes": 90012320,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 937.9409999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3096.740000000068,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.055000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1879.4869999999996,
"heapDeltaBytes": 22443680,
"heapUsedBytes": 89582040,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 943.6279999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2034.3659999999772,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.7260000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.4410000000001,
"heapDeltaBytes": 10471668,
"heapUsedBytes": 87422412,
"domNodes": -278,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 37.016000000000005,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2004.1049999999814,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.1339999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.615,
"heapDeltaBytes": 22135280,
"heapUsedBytes": 88185644,
"domNodes": -277,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.717999999999996,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.1539999999977,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.449000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.40000000000003,
"heapDeltaBytes": 15191476,
"heapUsedBytes": 87945072,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 138.726,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 581.9839999999203,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.83,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.772,
"heapDeltaBytes": 15231380,
"heapUsedBytes": 87636220,
"domNodes": 14,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 138.26300000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.0580000000155,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.043000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.83400000000006,
"heapDeltaBytes": -9220296,
"heapUsedBytes": 63472872,
"domNodes": -295,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.478000000000001,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2002.9819999999745,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.647000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.78299999999996,
"heapDeltaBytes": -9918344,
"heapUsedBytes": 62841708,
"domNodes": -294,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.393000000000001,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.5620000000918,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.061,
"layouts": 18,
"layoutDurationMs": 5.352,
"taskDurationMs": 798.493,
"heapDeltaBytes": -15213748,
"heapUsedBytes": 57592268,
"domNodes": -294,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 99.61500000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.4919999999884,
"styleRecalcs": 77,
"styleRecalcDurationMs": 34.317,
"layouts": 18,
"layoutDurationMs": 5.7669999999999995,
"taskDurationMs": 790.063,
"heapDeltaBytes": -12455080,
"heapUsedBytes": 60324056,
"domNodes": -297,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 97.572,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.8590000000668,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.481999999999996,
"layouts": 15,
"layoutDurationMs": 14.494,
"taskDurationMs": 897.8599999999999,
"heapDeltaBytes": -7416260,
"heapUsedBytes": 84260424,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 29.434,
"eventListeners": 2387,
"totalBlockingTimeMs": 125,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8505.106000000069,
"styleRecalcs": 246,
"styleRecalcDurationMs": 39.519999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5625.0160000000005,
"heapDeltaBytes": -12418488,
"heapUsedBytes": 89277248,
"domNodes": -270,
"jsHeapTotalBytes": -626688,
"scriptDurationMs": 2560.7090000000003,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8285.64700000004,
"styleRecalcs": 249,
"styleRecalcDurationMs": 40.888999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5522.426,
"heapDeltaBytes": 13646616,
"heapUsedBytes": 89018964,
"domNodes": -266,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 2519.357,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17882.348999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17146.447,
"heapDeltaBytes": -33706432,
"heapUsedBytes": 177083560,
"domNodes": -6577,
"jsHeapTotalBytes": 5480448,
"scriptDurationMs": 314.946,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18099.13599999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17121.435999999998,
"heapDeltaBytes": -34329340,
"heapUsedBytes": 176532664,
"domNodes": -6548,
"jsHeapTotalBytes": -1527808,
"scriptDurationMs": 306.94599999999997,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22216.70400000005,
"styleRecalcs": 171,
"styleRecalcDurationMs": 25.487000000000037,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21875.659,
"heapDeltaBytes": -28256080,
"heapUsedBytes": 185669432,
"domNodes": -6548,
"jsHeapTotalBytes": -17317888,
"scriptDurationMs": 928.2189999999999,
"eventListeners": -7467,
"totalBlockingTimeMs": 284,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21608.34699999998,
"styleRecalcs": 170,
"styleRecalcDurationMs": 19.566000000000027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21344.681,
"heapDeltaBytes": -29149808,
"heapUsedBytes": 181244912,
"domNodes": -6548,
"jsHeapTotalBytes": -5197824,
"scriptDurationMs": 963.362,
"eventListeners": -7469,
"totalBlockingTimeMs": 104,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6335.0359999999455,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.38600000000001,
"layouts": 20,
"layoutDurationMs": 23.606,
"taskDurationMs": 6190.5549999999985,
"heapDeltaBytes": 707564,
"heapUsedBytes": 191388560,
"domNodes": -6548,
"jsHeapTotalBytes": 10137600,
"scriptDurationMs": 116.56,
"eventListeners": -7471,
"totalBlockingTimeMs": 447,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6207.899999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.17099999999999,
"layouts": 20,
"layoutDurationMs": 23.420999999999996,
"taskDurationMs": 6124.3279999999995,
"heapDeltaBytes": -12152368,
"heapUsedBytes": 189637804,
"domNodes": -6548,
"jsHeapTotalBytes": 19386368,
"scriptDurationMs": 113.12899999999999,
"eventListeners": -7473,
"totalBlockingTimeMs": 413,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9125.58999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8662.528,
"heapDeltaBytes": 18952776,
"heapUsedBytes": 176417556,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 144.911,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9014.304999999922,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8632.407,
"heapDeltaBytes": 16866208,
"heapUsedBytes": 175567708,
"domNodes": 0,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 167.04399999999998,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 454.2639999999665,
"styleRecalcs": 14,
"styleRecalcDurationMs": 21.984999999999996,
"layouts": 3,
"layoutDurationMs": 1.627,
"taskDurationMs": 105.28999999999999,
"heapDeltaBytes": 4815360,
"heapUsedBytes": 73799032,
"domNodes": 120,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.472999999999999,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 94.65299999999388,
"styleRecalcs": 7,
"styleRecalcDurationMs": 11.288,
"layouts": 1,
"layoutDurationMs": 0.75,
"taskDurationMs": 59.227000000000004,
"heapDeltaBytes": 2963204,
"heapUsedBytes": 71688636,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.328000000000002,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #16864 +/- ##
==========================================
+ Coverage 81.16% 82.76% +1.59%
==========================================
Files 2460 2044 -416
Lines 126630 119306 -7324
Branches 33742 30293 -3449
==========================================
- Hits 102781 98741 -4040
+ Misses 23333 20383 -2950
+ Partials 516 182 -334
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 465 files with indirect coverage changes 🚀 New features to boost your workflow:
|
DrJKL
left a comment
There was a problem hiding this comment.
I’m requesting changes because the type-safety fix also changes the runtime widget type from the custom input identifier to the generic custom identifier.
I traced the path through InputSpec, TWidgetType, LGraphNode.addWidget(), addCustomWidget(), toConcreteWidget(), and LegacyWidget. Unknown widget types already fall back to LegacyWidget; they do not need to lose their original type to obtain that behavior.
Maintainability-skill finding: the new label-only test creates a parallel expectation that unsupported types become custom, freezing an implementation label without proving fallback behavior. Please preserve the lowercased custom type through the typed addCustomWidget() boundary and delete that expectation.
Checks: targeted Vitest passed 32 tests; typecheck, scoped ESLint with --no-ignore, Oxfmt, and git diff --check passed. Current CI is green. This does not duplicate merged #16459 or open #16508; it is a focused follow-up to #16459’s suppression.
| } else { | ||
| // @ts-expect-error InputSpec is not typed correctly | ||
| widget = this.addWidget(type, 'value', null, () => {}, {}) | ||
| widget = this.addWidget('custom', 'value', null, () => {}, {}) |
There was a problem hiding this comment.
This removes the suppression by changing observable runtime data: unsupported input type CUSTOM_WIDGET previously remained custom_widget after addWidget() lowercased it, while this now stores custom. Both paths use LegacyWidget, so changing the discriminant is unnecessary and can break custom-node code that dispatches on its widget type. My deletion-first maintainability finding is to delete the new label-only expectation and use the typed addCustomWidget() boundary to preserve the original custom type while removing the suppression.
There was a problem hiding this comment.
Fixed in a26d3f8af. The custom type is preserved through the legacy fallback.
Full context for agent readers
The unsupported-input branch now passes a plain widget with the lowercased original type through addCustomWidget(), so toConcreteWidget() selects LegacyWidget without rewriting the discriminant to custom. The regression now verifies both legacy fallback behavior and retention of custom_widget; the prior generic-label expectation is gone. Targeted unit tests passed 32/32, typecheck passed, scoped ESLint with --no-ignore passed, Oxfmt passed, and git diff --check passed.
Address review feedback from #16864 (comment) by retaining the custom input identifier through the legacy widget fallback.
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve
The prior type-preservation finding is addressed. Unsupported widget types now pass through the LegacyWidget fallback, and the test verifies both runtime fallback behavior and the original discriminant.
An isolated install passed typecheck, scoped ESLint, oxfmt, git diff --check, and 32 targeted tests. Maintainability review found no new issue; the test observes runtime behavior rather than maintaining a parallel implementation oracle.
DrJKL
left a comment
There was a problem hiding this comment.
The prior runtime-type finding is fixed. Unsupported input types now use the typed legacy fallback while preserving their original lowercased discriminant, and the focused test covers both behaviors. No further maintainability findings.
Summary
Maps unsupported Primitive input specs to LiteGraph's declared
customwidget boundary instead of suppressing the type error.Changes
customfallback and covers unsupported input specs with a regression test.Review Focus
Confirm custom input specs still create a fallback widget while satisfying
LGraphNode.addWidget()'sTWidgetTypecontract. This carries the remaining request from #16459's review; #16841 carries the other two findings.Evidence
pnpm test:unit src/extensions/core/widgetInputs.test.ts -t "creates a custom widget for unsupported widget types"— failed first: receivedcustom_widget, expectedcustom.pnpm test:unit src/extensions/core/widgetInputs.test.ts— 32 passed.pnpm typecheck— passed.pnpm lint:unstaged— passed with two existing ignore-pattern warnings.pnpm format:check src/extensions/core/widgetInputs.ts src/extensions/core/widgetInputs.test.ts— passed.