Repository navigation
feat(nodeApi): serve the entry point and wire the host paths - #16791
benjcooley wants to merge 31 commits into
Conversation
⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-12T04:45:23.755Z",
"gitSha": "3cdf4844b368eb1f77500177c65cca240fa82282",
"branch": "benjcooley/node-api-wiring",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2025.3879999999924,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.117,
"layouts": 10,
"layoutDurationMs": 2.639,
"taskDurationMs": 501.4130000000001,
"heapDeltaBytes": -4352268,
"heapUsedBytes": 66274196,
"domNodes": -178,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 10.423,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2040.76299999997,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4220000000000006,
"layouts": 9,
"layoutDurationMs": 1.961,
"taskDurationMs": 466.136,
"heapDeltaBytes": -16704028,
"heapUsedBytes": 68539940,
"domNodes": -178,
"jsHeapTotalBytes": 10088448,
"scriptDurationMs": 8.499,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1692.5880000000006,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.213999999999999,
"layouts": 9,
"layoutDurationMs": 1.928,
"taskDurationMs": 773.0250000000001,
"heapDeltaBytes": 2736564,
"heapUsedBytes": 81870280,
"domNodes": -178,
"jsHeapTotalBytes": 9564160,
"scriptDurationMs": 122.57200000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1795.2569999999923,
"styleRecalcs": 73,
"styleRecalcDurationMs": 14.75,
"layouts": 9,
"layoutDurationMs": 2.01,
"taskDurationMs": 815.156,
"heapDeltaBytes": -14519336,
"heapUsedBytes": 69869792,
"domNodes": -178,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 133.81400000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.1699999999914,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.68,
"layouts": 13,
"layoutDurationMs": 2.5720000000000005,
"taskDurationMs": 332.675,
"heapDeltaBytes": 9017212,
"heapUsedBytes": 88370964,
"domNodes": 57,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 9.746,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.7420000000157,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.2,
"layouts": 13,
"layoutDurationMs": 2.921,
"taskDurationMs": 392.301,
"heapDeltaBytes": 6647516,
"heapUsedBytes": 85998212,
"domNodes": 57,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 13.273,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 574.3909999999914,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.9389999999999996,
"layouts": 9,
"layoutDurationMs": 2.2649999999999997,
"taskDurationMs": 416.31100000000004,
"heapDeltaBytes": 6382204,
"heapUsedBytes": 85792120,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 134.372,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 574.7929999999997,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.331,
"layouts": 10,
"layoutDurationMs": 2.508,
"taskDurationMs": 426.13100000000003,
"heapDeltaBytes": 2167800,
"heapUsedBytes": 81468440,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 133.814,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1002.9930000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 656.501,
"heapDeltaBytes": 33220264,
"heapUsedBytes": 104115360,
"domNodes": 0,
"jsHeapTotalBytes": 8810496,
"scriptDurationMs": 46.41800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 368,
"frameDurationMs": 29.411764705882366,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 986.616999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.9220000000001,
"heapDeltaBytes": 32194444,
"heapUsedBytes": 102934476,
"domNodes": 0,
"jsHeapTotalBytes": 10121216,
"scriptDurationMs": 44.428,
"eventListeners": 0,
"totalBlockingTimeMs": 356,
"frameDurationMs": 28.920588235294108,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 803.6020000000121,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.8229999999997,
"heapDeltaBytes": -6860884,
"heapUsedBytes": 75839652,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 112.105,
"eventListeners": 0,
"totalBlockingTimeMs": 154,
"frameDurationMs": 22.857142857142858,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 813.9799999999582,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.72900000000004,
"heapDeltaBytes": -7135556,
"heapUsedBytes": 74691872,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 131.488,
"eventListeners": 0,
"totalBlockingTimeMs": 178,
"frameDurationMs": 24.017647058823542,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6971.305000000001,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.0419999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6160.972,
"heapDeltaBytes": -10615328,
"heapUsedBytes": 68606052,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 4604.420999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 81,
"frameDurationMs": 22.47225806451613,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6640.085999999997,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.4190000000000001,
"layouts": 2,
"layoutDurationMs": 0.6150000000000001,
"taskDurationMs": 5778.159,
"heapDeltaBytes": -10461892,
"heapUsedBytes": 83703864,
"domNodes": -274,
"jsHeapTotalBytes": -1183744,
"scriptDurationMs": 4304.407999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 65,
"frameDurationMs": 20.9379746835443,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6985.5480000000225,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.889,
"layouts": 2,
"layoutDurationMs": 0.5839999999999999,
"taskDurationMs": 6190.906,
"heapDeltaBytes": 12310720,
"heapUsedBytes": 94638056,
"domNodes": -274,
"jsHeapTotalBytes": 8777728,
"scriptDurationMs": 4601.05,
"eventListeners": -69,
"totalBlockingTimeMs": 42,
"frameDurationMs": 24.533216783216783,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6679.860000000019,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8029999999999999,
"layouts": 3,
"layoutDurationMs": 0.6819999999999998,
"taskDurationMs": 5809.71,
"heapDeltaBytes": -11347476,
"heapUsedBytes": 72231284,
"domNodes": -274,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 4305.2210000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 12,
"frameDurationMs": 21.420192307692307,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 185.35599999998453,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.593000000000002,
"layouts": 12,
"layoutDurationMs": 3.2249999999999996,
"taskDurationMs": 138.99499999999998,
"heapDeltaBytes": 13969384,
"heapUsedBytes": 90288484,
"domNodes": 936,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7.667,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.22222222222222,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 188.85099999999966,
"styleRecalcs": 23,
"styleRecalcDurationMs": 10.858,
"layouts": 12,
"layoutDurationMs": 3.001,
"taskDurationMs": 128.75,
"heapDeltaBytes": 13905060,
"heapUsedBytes": 88874408,
"domNodes": 936,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.363999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.36666666666669,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2083.5820000000354,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.531,
"layouts": 8,
"layoutDurationMs": 2.0149999999999997,
"taskDurationMs": 575.289,
"heapDeltaBytes": -26807520,
"heapUsedBytes": 71787844,
"domNodes": -274,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 30.809,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2042.3660000000154,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4270000000000005,
"layouts": 9,
"layoutDurationMs": 1.9340000000000002,
"taskDurationMs": 567.0799999999999,
"heapDeltaBytes": -30203472,
"heapUsedBytes": 68316976,
"domNodes": -274,
"jsHeapTotalBytes": 688128,
"scriptDurationMs": 34.042,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2313.7669999999844,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.494,
"layouts": 8,
"layoutDurationMs": 1.8030000000000002,
"taskDurationMs": 1281.0579999999998,
"heapDeltaBytes": -22491748,
"heapUsedBytes": 77161644,
"domNodes": -274,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 538.482,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66618705035971,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2740.891999999917,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.85,
"layouts": 8,
"layoutDurationMs": 2.0980000000000003,
"taskDurationMs": 1356.342,
"heapDeltaBytes": 8459936,
"heapUsedBytes": 91629952,
"domNodes": -274,
"jsHeapTotalBytes": 614400,
"scriptDurationMs": 554.7930000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666463414634144,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3321.427999999969,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.241,
"layouts": 66,
"layoutDurationMs": 10.095,
"taskDurationMs": 1397.123,
"heapDeltaBytes": -3900572,
"heapUsedBytes": 81423288,
"domNodes": -250,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 544.493,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665829145728644,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3867.552000000046,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.959999999999999,
"layouts": 65,
"layoutDurationMs": 10.889,
"taskDurationMs": 1491.305,
"heapDeltaBytes": -16510672,
"heapUsedBytes": 85918416,
"domNodes": 24,
"jsHeapTotalBytes": 6328320,
"scriptDurationMs": 595.5120000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665948275862068,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2482.6379999999517,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.706999999999999,
"layouts": 4,
"layoutDurationMs": 0.811,
"taskDurationMs": 1558.3360000000002,
"heapDeltaBytes": 1682468,
"heapUsedBytes": 69853576,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 718.298,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.778378378378378,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2961.648000000082,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.9719999999999995,
"layouts": 7,
"layoutDurationMs": 1.8179999999999998,
"taskDurationMs": 1601.2269999999996,
"heapDeltaBytes": 17779328,
"heapUsedBytes": 108514068,
"domNodes": 0,
"jsHeapTotalBytes": 5660672,
"scriptDurationMs": 718.09,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76045197740113,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "litegraph-245-idle",
"durationMs": 1504.6459999999797,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.5769999999999995,
"layouts": 6,
"layoutDurationMs": 1.2099999999999997,
"taskDurationMs": 42.16999999999993,
"heapDeltaBytes": 4594088,
"heapUsedBytes": 95103444,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 24.208999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66593406593407,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "litegraph-245-idle",
"durationMs": 1505.0850000000082,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.125,
"layouts": 7,
"layoutDurationMs": 1.455,
"taskDurationMs": 46.722999999999956,
"heapDeltaBytes": 4593500,
"heapUsedBytes": 87354492,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 24.035,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66593406593406,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "litegraph-245-pan",
"durationMs": 4052.4019999999155,
"styleRecalcs": 124,
"styleRecalcDurationMs": 17.534000000000002,
"layouts": 117,
"layoutDurationMs": 8.321,
"taskDurationMs": 1461.986,
"heapDeltaBytes": -8099144,
"heapUsedBytes": 87035600,
"domNodes": -228,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 1100.554,
"eventListeners": -64,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66625514403292,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "litegraph-245-pan",
"durationMs": 4050.7599999999684,
"styleRecalcs": 124,
"styleRecalcDurationMs": 17.922,
"layouts": 117,
"layoutDurationMs": 8.546000000000001,
"taskDurationMs": 1464.0600000000002,
"heapDeltaBytes": 8260448,
"heapUsedBytes": 95646256,
"domNodes": -228,
"jsHeapTotalBytes": 2187264,
"scriptDurationMs": 1095.708,
"eventListeners": -64,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665843621399173,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "litegraph-245-progress",
"durationMs": 2353.971999999999,
"styleRecalcs": 140,
"styleRecalcDurationMs": 21.948000000000004,
"layouts": 20,
"layoutDurationMs": 4.949999999999999,
"taskDurationMs": 285.98100000000005,
"heapDeltaBytes": -859592,
"heapUsedBytes": 90909272,
"domNodes": 20,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 169.16300000000018,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66524822695035,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "litegraph-245-progress",
"durationMs": 2353.760999999963,
"styleRecalcs": 140,
"styleRecalcDurationMs": 24.755,
"layouts": 20,
"layoutDurationMs": 5.0089999999999995,
"taskDurationMs": 317.145,
"heapDeltaBytes": -1769812,
"heapUsedBytes": 68291012,
"domNodes": 20,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 182.86400000000015,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "litegraph-245-zoom",
"durationMs": 4029.62500000001,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.864999999999998,
"layouts": 70,
"layoutDurationMs": 9.425,
"taskDurationMs": 834.765,
"heapDeltaBytes": 3294804,
"heapUsedBytes": 91465440,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 651.594,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665702479338844,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "litegraph-245-zoom",
"durationMs": 4046.369000000027,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.790999999999997,
"layouts": 70,
"layoutDurationMs": 9.352,
"taskDurationMs": 864.6419999999999,
"heapDeltaBytes": 2073280,
"heapUsedBytes": 69757880,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 663.1470000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66625514403292,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "litegraph-60-idle",
"durationMs": 1513.2300000000214,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18.159000000000034,
"heapDeltaBytes": 1248592,
"heapUsedBytes": 65747020,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.98600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66593406593406,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "litegraph-60-idle",
"durationMs": 1512.4270000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 30.56700000000001,
"heapDeltaBytes": 1332460,
"heapUsedBytes": 65784632,
"domNodes": -367,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.415999999999997,
"eventListeners": -1620,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665934065934064,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "litegraph-60-pan",
"durationMs": 4039.369000000079,
"styleRecalcs": 124,
"styleRecalcDurationMs": 19.157999999999998,
"layouts": 119,
"layoutDurationMs": 8.868,
"taskDurationMs": 1377.181,
"heapDeltaBytes": 14455908,
"heapUsedBytes": 80223340,
"domNodes": 7,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 924.8050000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665702479338844,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "litegraph-60-pan",
"durationMs": 4038.917999999967,
"styleRecalcs": 124,
"styleRecalcDurationMs": 19.913,
"layouts": 119,
"layoutDurationMs": 9.052000000000001,
"taskDurationMs": 1461.7859999999998,
"heapDeltaBytes": 14427660,
"heapUsedBytes": 80232936,
"domNodes": 7,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 983.3779999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "litegraph-60-progress",
"durationMs": 2353.4779999999955,
"styleRecalcs": 140,
"styleRecalcDurationMs": 21.165999999999997,
"layouts": 20,
"layoutDurationMs": 5.029000000000003,
"taskDurationMs": 275.6259999999999,
"heapDeltaBytes": 41612,
"heapUsedBytes": 69015820,
"domNodes": 20,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 159.82600000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "litegraph-60-progress",
"durationMs": 2353.976999999986,
"styleRecalcs": 140,
"styleRecalcDurationMs": 23.86,
"layouts": 20,
"layoutDurationMs": 5.051,
"taskDurationMs": 295.998,
"heapDeltaBytes": -11048,
"heapUsedBytes": 69018216,
"domNodes": 20,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 169.76499999999993,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66595744680851,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "litegraph-60-zoom",
"durationMs": 4012.2519999999895,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.916000000000004,
"layouts": 70,
"layoutDurationMs": 9.848999999999998,
"taskDurationMs": 745.552,
"heapDeltaBytes": -12582116,
"heapUsedBytes": 68694336,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 438.34700000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66597510373444,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "litegraph-60-zoom",
"durationMs": 4028.1479999999874,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.135000000000002,
"layouts": 70,
"layoutDurationMs": 10.451999999999998,
"taskDurationMs": 805.231,
"heapDeltaBytes": -12537504,
"heapUsedBytes": 68748316,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 475.5069999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2918.884999999989,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.322,
"layouts": 8,
"layoutDurationMs": 1.799,
"taskDurationMs": 661.5000000000001,
"heapDeltaBytes": -24448480,
"heapUsedBytes": 76745936,
"domNodes": -274,
"jsHeapTotalBytes": 1736704,
"scriptDurationMs": 255.18300000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2909.3950000000177,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3360000000000003,
"layouts": 8,
"layoutDurationMs": 1.987,
"taskDurationMs": 615.015,
"heapDeltaBytes": -6026392,
"heapUsedBytes": 83620720,
"domNodes": -274,
"jsHeapTotalBytes": 913408,
"scriptDurationMs": 257.523,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665142857142854,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2050.829999999962,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.144,
"layouts": 8,
"layoutDurationMs": 1.799,
"taskDurationMs": 544.232,
"heapDeltaBytes": -29779484,
"heapUsedBytes": 71195780,
"domNodes": -274,
"jsHeapTotalBytes": 1212416,
"scriptDurationMs": 31.448000000000004,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2052.252000000067,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6490000000000005,
"layouts": 9,
"layoutDurationMs": 2.287,
"taskDurationMs": 627.849,
"heapDeltaBytes": -8301912,
"heapUsedBytes": 92950428,
"domNodes": -274,
"jsHeapTotalBytes": 688128,
"scriptDurationMs": 35.102999999999994,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2888.8919999999985,
"styleRecalcs": 27,
"styleRecalcDurationMs": 12.207000000000003,
"layouts": 8,
"layoutDurationMs": 1.936,
"taskDurationMs": 539.955,
"heapDeltaBytes": -18523324,
"heapUsedBytes": 82913240,
"domNodes": -263,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 154.312,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666473988439304,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2738.552000000027,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.283999999999999,
"layouts": 7,
"layoutDurationMs": 1.8060000000000003,
"taskDurationMs": 505.84,
"heapDeltaBytes": 4854664,
"heapUsedBytes": 89857160,
"domNodes": -255,
"jsHeapTotalBytes": 126976,
"scriptDurationMs": 157.59400000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666463414634148,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3038.9539999999897,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.1029999999999998,
"layouts": 4,
"layoutDurationMs": 0.7919999999999997,
"taskDurationMs": 687.122,
"heapDeltaBytes": 9858512,
"heapUsedBytes": 78682936,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 252.01800000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665934065934064,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3015.9320000000207,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.549,
"layouts": 6,
"layoutDurationMs": 1.2340000000000002,
"taskDurationMs": 725.115,
"heapDeltaBytes": -19839748,
"heapUsedBytes": 81245396,
"domNodes": -274,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 245.49200000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666298342541438,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 543.2759999999917,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.3,
"layouts": 11,
"layoutDurationMs": 2.5719999999999996,
"taskDurationMs": 359.514,
"heapDeltaBytes": 2971584,
"heapUsedBytes": 83823696,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 118.146,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 582.7599999998938,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.587,
"layouts": 9,
"layoutDurationMs": 2.2770000000000006,
"taskDurationMs": 395.797,
"heapDeltaBytes": 597256,
"heapUsedBytes": 71920688,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 125.24099999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668571428571433,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2024.659000000014,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.451000000000001,
"layouts": 11,
"layoutDurationMs": 2.8060000000000005,
"taskDurationMs": 516.186,
"heapDeltaBytes": -23341864,
"heapUsedBytes": 58467380,
"domNodes": -200,
"jsHeapTotalBytes": 10874880,
"scriptDurationMs": 10.221,
"eventListeners": -120,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2025.515999999982,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.247,
"layouts": 10,
"layoutDurationMs": 2.6619999999999995,
"taskDurationMs": 535.778,
"heapDeltaBytes": -2331080,
"heapUsedBytes": 79145112,
"domNodes": -200,
"jsHeapTotalBytes": 9826304,
"scriptDurationMs": 9.673,
"eventListeners": -120,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1744.7700000000168,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.631,
"layouts": 6,
"layoutDurationMs": 1.39,
"taskDurationMs": 789.672,
"heapDeltaBytes": -1539976,
"heapUsedBytes": 79955924,
"domNodes": -200,
"jsHeapTotalBytes": 10612736,
"scriptDurationMs": 97.487,
"eventListeners": -120,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.3290000000252,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.064999999999998,
"layouts": 10,
"layoutDurationMs": 2.287,
"taskDurationMs": 730.387,
"heapDeltaBytes": -2905220,
"heapUsedBytes": 79194380,
"domNodes": -200,
"jsHeapTotalBytes": 10088448,
"scriptDurationMs": 94.079,
"eventListeners": -120,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1471.919000000014,
"styleRecalcs": 19,
"styleRecalcDurationMs": 38.827999999999996,
"layouts": 6,
"layoutDurationMs": 22.818,
"taskDurationMs": 1153.794,
"heapDeltaBytes": -4955432,
"heapUsedBytes": 91833092,
"domNodes": -1359,
"jsHeapTotalBytes": 17301504,
"scriptDurationMs": 26.569000000000003,
"eventListeners": -290,
"totalBlockingTimeMs": 132,
"frameDurationMs": 19.777333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8405.692999999985,
"styleRecalcs": 251,
"styleRecalcDurationMs": 31.285999999999994,
"layouts": 9,
"layoutDurationMs": 2.1529999999999996,
"taskDurationMs": 4413.209,
"heapDeltaBytes": 6535784,
"heapUsedBytes": 88093364,
"domNodes": -274,
"jsHeapTotalBytes": 352256,
"scriptDurationMs": 1756.707,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69900596421471,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 11178.524999999921,
"styleRecalcs": 251,
"styleRecalcDurationMs": 33.169999999999995,
"layouts": 8,
"layoutDurationMs": 8.493,
"taskDurationMs": 5165.874000000001,
"heapDeltaBytes": -30641604,
"heapUsedBytes": 71338552,
"domNodes": -274,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 2013.2219999999998,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665871833084946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-245-idle",
"durationMs": 1507.7529999999797,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 72.48499999999947,
"heapDeltaBytes": 4546340,
"heapUsedBytes": 297431632,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 25.927000000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667032967032966,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-245-idle",
"durationMs": 1510.2560000000267,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 97.02499999999992,
"heapDeltaBytes": 4544872,
"heapUsedBytes": 293551692,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 27.407999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66593406593406,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-245-pan",
"durationMs": 4077.7369999999564,
"styleRecalcs": 129,
"styleRecalcDurationMs": 23.661000000000044,
"layouts": 6,
"layoutDurationMs": 5.185000000000023,
"taskDurationMs": 2235.196999999999,
"heapDeltaBytes": 4318964,
"heapUsedBytes": 301769888,
"domNodes": 7,
"jsHeapTotalBytes": 10448896,
"scriptDurationMs": 905.411,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-245-pan",
"durationMs": 4071.0960000000114,
"styleRecalcs": 129,
"styleRecalcDurationMs": 23.946000000000023,
"layouts": 6,
"layoutDurationMs": 4.141000000000005,
"taskDurationMs": 2217.739,
"heapDeltaBytes": -660180,
"heapUsedBytes": 293202208,
"domNodes": 7,
"jsHeapTotalBytes": 6778880,
"scriptDurationMs": 865.379,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665983606557376,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-245-progress",
"durationMs": 3052.9579999999896,
"styleRecalcs": 152,
"styleRecalcDurationMs": 195.289,
"layouts": 21,
"layoutDurationMs": 5.29099999999999,
"taskDurationMs": 1104.3320000000012,
"heapDeltaBytes": -3542152,
"heapUsedBytes": 294134016,
"domNodes": 28,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 122.71100000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75737704918032,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-245-progress",
"durationMs": 3034.2279999999846,
"styleRecalcs": 152,
"styleRecalcDurationMs": 192.971,
"layouts": 21,
"layoutDurationMs": 5.305000000000004,
"taskDurationMs": 1132.6079999999995,
"heapDeltaBytes": 23047244,
"heapUsedBytes": 310729256,
"domNodes": 28,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 114.70599999999997,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.758011049723763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-245-zoom",
"durationMs": 4596.096999999986,
"styleRecalcs": 99,
"styleRecalcDurationMs": 14.941999999999956,
"layouts": 99,
"layoutDurationMs": 25.857999999999993,
"taskDurationMs": 2031.9000000000003,
"heapDeltaBytes": -6819564,
"heapUsedBytes": 297339852,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 580.206,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.72654545454545,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-245-zoom",
"durationMs": 4464.819000000034,
"styleRecalcs": 99,
"styleRecalcDurationMs": 15.63399999999998,
"layouts": 99,
"layoutDurationMs": 27.223,
"taskDurationMs": 2041.5390000000002,
"heapDeltaBytes": -8528980,
"heapUsedBytes": 287068364,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 559.1850000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666044776119403,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-60-idle",
"durationMs": 1506.6679999999906,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 42.002000000000095,
"heapDeltaBytes": 1264688,
"heapUsedBytes": 306902480,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.635000000000009,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66593406593407,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "vue-60-idle",
"durationMs": 1513.6819999999034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 34.69800000000056,
"heapDeltaBytes": 1264656,
"heapUsedBytes": 307287520,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.286999999999992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667032967032966,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-60-pan",
"durationMs": 4044.548999999961,
"styleRecalcs": 123,
"styleRecalcDurationMs": 20.37899999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1594.3949999999995,
"heapDeltaBytes": 14050588,
"heapUsedBytes": 320972292,
"domNodes": 7,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 641.1309999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665702479338837,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-60-pan",
"durationMs": 4042.795000000069,
"styleRecalcs": 123,
"styleRecalcDurationMs": 19.142999999999965,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1550.8259999999998,
"heapDeltaBytes": 14074460,
"heapUsedBytes": 321381264,
"domNodes": 7,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 614.55,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665702479338844,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-60-progress",
"durationMs": 2767.2019999999975,
"styleRecalcs": 145,
"styleRecalcDurationMs": 92.63900000000002,
"layouts": 138,
"layoutDurationMs": 48.230999999999995,
"taskDurationMs": 1910.3619999999992,
"heapDeltaBytes": -7856472,
"heapUsedBytes": 323830520,
"domNodes": 28,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 81.57900000000006,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.869512195121963,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-60-progress",
"durationMs": 2753.1819999999243,
"styleRecalcs": 145,
"styleRecalcDurationMs": 88.04200000000002,
"layouts": 138,
"layoutDurationMs": 54.32799999999999,
"taskDurationMs": 1869.2539999999997,
"heapDeltaBytes": -7974564,
"heapUsedBytes": 324271608,
"domNodes": 28,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 79.76200000000011,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666060606060615,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-60-zoom",
"durationMs": 4193.878000000041,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.299000000000003,
"layouts": 70,
"layoutDurationMs": 9.093000000000018,
"taskDurationMs": 1346.9169999999995,
"heapDeltaBytes": 9513644,
"heapUsedBytes": 331412196,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 365.526,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66587301587302,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-60-zoom",
"durationMs": 4164.972999999918,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.133000000000003,
"layouts": 70,
"layoutDurationMs": 8.939000000000002,
"taskDurationMs": 1305.6140000000003,
"heapDeltaBytes": 9535580,
"heapUsedBytes": 331843472,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 361.72499999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23842.979000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23819.53,
"heapDeltaBytes": -46807628,
"heapUsedBytes": 279981824,
"domNodes": -3731,
"jsHeapTotalBytes": -2641920,
"scriptDurationMs": 326.688,
"eventListeners": -674,
"totalBlockingTimeMs": 0,
"frameDurationMs": 49.547817047817055,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-idle",
"durationMs": 24891.36099999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24867.206,
"heapDeltaBytes": -29733552,
"heapUsedBytes": 272277848,
"domNodes": -3437,
"jsHeapTotalBytes": 20447232,
"scriptDurationMs": 342.571,
"eventListeners": -674,
"totalBlockingTimeMs": 0,
"frameDurationMs": 51.764864864864876,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 27833.12000000001,
"styleRecalcs": 210,
"styleRecalcDurationMs": 22.780000000000022,
"layouts": 29,
"layoutDurationMs": 9.14899999999999,
"taskDurationMs": 27785.147999999997,
"heapDeltaBytes": -39880788,
"heapUsedBytes": 279505540,
"domNodes": -3437,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 702.111,
"eventListeners": -672,
"totalBlockingTimeMs": 0,
"frameDurationMs": 58.47100840336134,
"p95FrameDurationMs": 116.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 27850.45600000001,
"styleRecalcs": 210,
"styleRecalcDurationMs": 21.93499999999998,
"layouts": 29,
"layoutDurationMs": 8.818000000000021,
"taskDurationMs": 27830.52,
"heapDeltaBytes": -34635812,
"heapUsedBytes": 285970292,
"domNodes": -3437,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 664.261,
"eventListeners": -672,
"totalBlockingTimeMs": 0,
"frameDurationMs": 58.877378435517976,
"p95FrameDurationMs": 116.60000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8542.621999999994,
"styleRecalcs": 20,
"styleRecalcDurationMs": 51.10599999999999,
"layouts": 36,
"layoutDurationMs": 14.688000000000006,
"taskDurationMs": 8528.262,
"heapDeltaBytes": -53158372,
"heapUsedBytes": 275443716,
"domNodes": -3731,
"jsHeapTotalBytes": 15970304,
"scriptDurationMs": 110.51,
"eventListeners": -674,
"totalBlockingTimeMs": 0,
"frameDurationMs": 51.096407185628756,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8907.507000000009,
"styleRecalcs": 20,
"styleRecalcDurationMs": 56.38300000000002,
"layouts": 36,
"layoutDurationMs": 14.759999999999994,
"taskDurationMs": 8792.000999999998,
"heapDeltaBytes": -24449948,
"heapUsedBytes": 295008056,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 131.602,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.45815217391304,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12104.158999999981,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12086.412,
"heapDeltaBytes": -27995748,
"heapUsedBytes": 292494036,
"domNodes": -3437,
"jsHeapTotalBytes": 19398656,
"scriptDurationMs": 173.533,
"eventListeners": -674,
"totalBlockingTimeMs": 0,
"frameDurationMs": 49.52008196721312,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12203.268999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12195.855,
"heapDeltaBytes": -89360,
"heapUsedBytes": 271273388,
"domNodes": 0,
"jsHeapTotalBytes": -17301504,
"scriptDurationMs": 155.078,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 52.358369098712444,
"p95FrameDurationMs": 100
},
{
"name": "workflow-execution",
"durationMs": 467.9379999999469,
"styleRecalcs": 19,
"styleRecalcDurationMs": 10.617,
"layouts": 13,
"layoutDurationMs": 3.785,
"taskDurationMs": 122.452,
"heapDeltaBytes": 7613680,
"heapUsedBytes": 76730804,
"domNodes": 136,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.752,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660714285714285,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 93.37600000003476,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.679000000000001,
"layouts": 7,
"layoutDurationMs": 2.5570000000000004,
"taskDurationMs": 65.51200000000001,
"heapDeltaBytes": 4913048,
"heapUsedBytes": 82285860,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.606999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 353.48500000009153,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6769999999999999,
"layouts": 76,
"layoutDurationMs": 12.558,
"taskDurationMs": 309.748,
"heapDeltaBytes": -5977916,
"heapUsedBytes": 37896760,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 139.141,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 317.7580000000262,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.657,
"layouts": 76,
"layoutDurationMs": 12.156,
"taskDurationMs": 292.17600000000004,
"heapDeltaBytes": -6008028,
"heapUsedBytes": 38745956,
"domNodes": 4,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 132.07,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 381.2510000000202,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.7619999999999998,
"layouts": 76,
"layoutDurationMs": 12.055,
"taskDurationMs": 352.466,
"heapDeltaBytes": -2146032,
"heapUsedBytes": 91830708,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 130.202,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 378.1100000001061,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.6280000000000001,
"layouts": 76,
"layoutDurationMs": 11.860000000000001,
"taskDurationMs": 348.877,
"heapDeltaBytes": -2046424,
"heapUsedBytes": 91380332,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 127.31199999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304356,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage: 🟡 57.4% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3285 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3a64ca5d6b1a38617a46052f34df85e3a53f8bad
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (563)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## benjcooley/node-api-surface #16791 +/- ##
===============================================================
- Coverage 87.88% 87.86% -0.02%
===============================================================
Files 3172 3075 -97
Lines 171524 168901 -2623
Branches 46320 43444 -2876
===============================================================
- Hits 150737 148402 -2335
+ Misses 19821 19686 -135
+ Partials 966 813 -153
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 195 files with indirect coverage changes 🚀 New features to boost your workflow:
|
DrJKL
left a comment
There was a problem hiding this comment.
Transferred all seven host-composition findings from superseded #16691 to the wiring PR; each remains reproducible on the current stacked head.
Transfer map and revalidation
Revalidated against #16791 head 77cdd03ab17d9794483aa5d986ee3c7ccd9830a4, whose base is #16790.
This PR owns installation and production host reachability, so it receives the findings for queue guard/event integration, unplaced-link bridge installation, application/workflow lifecycle publication, preview delivery, definition-refresh notification, link-color palette restoration, and the runtime dependency cycle created when app.ts imports the API whose registry imports app.ts back.
The current setup hunk installs only the move/change bridges, graph-loading state, and window.comfy. Repository-wide searches at this stacked head still show no production callers for markAppReady, notifyWorkflowLoaded, deliverPreview, notifyDefsRefreshed, reapplyPackTypeColors, or mayRun, and no production dispatch for promptQueueAttemptEnded or promptRejected.
The comments preserve the original audit's evidence, failure sequences, remediation direction, and integration-test requirements.
| installNodeMoveBridge() | ||
| installNodeChangeBridge() | ||
| // Which the API cannot see for itself: ChangeTracker lives up here. | ||
| provideGraphLoadingState(() => ChangeTracker.isLoadingGraph) |
There was a problem hiding this comment.
[P1] Wire the complete queue contract into ComfyApp.queuePrompt(). Guards, cleanup, rejection events, and submitted-run metadata are disconnected from the real production path.
Evidence and failure sequence
The API-surface PR defines mayRun() as the guard authority, but the stacked production head has no caller. A guard returning false therefore cannot stop ComfyApp.queuePrompt().
onBeforeRun() starts from the existing promptQueueing event and stores a cleanup, but waits for promptQueueAttemptEnded; the production queue loop never dispatches that event, so cleanup is retained and can be overwritten by a later attempt. onRejected() listens for promptRejected, which is never dispatched. onAfterRun() consumes promptIds, submissions, and rejectedCount, but production's promptQueued event contains only { number, batchCount, requestId }.
Failure sequence:
- A pack installs a guard that returns
false; production queues and submits anyway. - A pack's before-run setup executes on
promptQueueing, but its returned cleanup never executes. - Backend rejection follows the normal
PromptExecutionErrorbranch, but no public rejection callback fires. - A successful submission emits
onAfterRunwith an empty prompt-ID list, no submissions, andrejected: 0regardless of the actual batch outcome.
The queue unit tests dispatch synthetic custom events directly and therefore prove normalization only, not the actual queuePrompt() integration.
Why this matters
This contract controls whether execution is allowed and brackets temporary pre-run state. Bypassing it can submit a workflow after an extension explicitly vetoes it and can leak temporary mutations/listeners after every attempt. Missing IDs and rejection counts also make pack-owned progress tracking associate work with the wrong run or report a rejected batch as successful.
Suggested direction and verification
Integrate at the authoritative per-attempt queue loop. Await mayRun() before prompt construction/submission; guarantee promptQueueAttemptEnded in a per-attempt finally; dispatch promptRejected from the typed PromptExecutionError path; collect accepted prompt IDs and per-submission executable counts; and emit one promptQueued payload matching PromptQueuedEventPayload, including rejected attempts. Define what queuePrompt() returns when a guard cancels one/all attempts and preserve existing host UI/telemetry behavior.
Add an integration test around the real ComfyApp.queuePrompt() path, not synthetic event dispatch: guard false prevents backend submission; before cleanup runs on success, rejection, and thrown prompt-build errors; rejection details reach onRejected; and mixed batch outcomes produce exact IDs, submissions, and rejected count.
There was a problem hiding this comment.
Fixed. queuePrompt() now gates on mayRun() — a guard that returns false stops the run — dispatches promptRejected with the response and status on PromptExecutionError, and dispatches promptQueueAttemptEnded unconditionally with queued/rejected counts, including on the guard-veto path so a listener that changed something to build the prompt can put it back.
There was a problem hiding this comment.
Correction to my earlier partial reply: the complete queue contract is now wired. promptQueueing starts only after auth, vetoes close the attempt, thrown prompt construction closes it from finally, response-level rejections emit promptRejected and return false, and promptQueued reports accepted prompt IDs, per-submission node counts, and rejection count. Integration tests exercise auth failure, veto, thrown construction, accepted batches, and resolved rejection.
| // that call, so the API has to be reachable and fully sourced by then. A | ||
| // pack subscribing to onNodeMoved at module scope throws otherwise. | ||
| installNodeMoveBridge() | ||
| installNodeChangeBridge() |
There was a problem hiding this comment.
[P1] Install the unplaced-link bridge on the production canvas. The bridge exists, but startup never attaches its listener.
Evidence and failure sequence
installUnplacedLinkBridge(canvas) listens to canvas.linkConnector.events and forwards link-unplaced into offerUnplacedLink(). The production setup added installNodeMoveBridge() and installNodeChangeBridge(), but does not import or call the unplaced-link installer after constructing the real canvas.
Failure sequence:
- A pack registers
onLinkUnplacedthrough the public definition API. - The user drops a link that
LinkConnectorcannot place. LinkConnectoremitslink-unplaced.- No production listener is attached to that canvas's event target.
offerUnplacedLink()is never called, and the pack cannot claim or wire the gesture.
The bridge test invokes the installer manually, so it does not cover startup installation.
Why this matters
This is the only host seam that makes the published capability reachable. Without it, the API compiles and unit tests pass while every real unplaced-link callback remains inert.
Suggested direction and verification
Import the installer in the host wiring PR and call it exactly once after the production LGraphCanvas/linkConnector exists. Assign teardown to the canvas/app lifecycle so replacing or disposing a canvas removes the old listener and cannot produce duplicate delivery.
Add a startup-path test that runs the real canvas construction/host installation seam, emits link-unplaced from that canvas, and observes the registered public callback. Include teardown/reinstall coverage to prove there is exactly one listener.
There was a problem hiding this comment.
Fixed. installUnplacedLinkBridge(canvas) runs on canvas construction and disposes any previous installation, so the bridge is live on the production canvas rather than only in tests.
| installNodeChangeBridge() | ||
| // Which the API cannot see for itself: ChangeTracker lives up here. | ||
| provideGraphLoadingState(() => ChangeTracker.isLoadingGraph) | ||
| installComfyApi(() => useCanvasStore().currentGraph, { |
There was a problem hiding this comment.
[P1] Connect the published application lifecycle to the production host. onReady, onWorkflowLoaded, and document identity are currently inert outside tests.
Evidence and failure sequence
markAppReady() is the only transition that sets the module-level ready flag and drains waiting; notifyWorkflowLoaded() is the only transition that mints documentId and invokes workflow listeners. A repository-wide production search finds no caller for either function. Their only callers are unit tests.
The production startup path installs window.comfy and loads extensions, but never calls markAppReady() after the host reaches the legacy setup() point. The production loadGraphData() path likewise completes graph configuration without calling notifyWorkflowLoaded(). The source comment at lines 62–64 even names the intended loadGraphData tail as the single call site, but that call site does not exist.
Failure sequence:
- A pack registers
comfy.onReady(listener)during module evaluation. - The listener is added to
waitingbecausereadyremainsfalse. - App startup completes, but no production code calls
markAppReady(). - The listener remains queued forever.
The workflow path is equivalent: onWorkflowLoaded listeners never run, and currentDocumentId() remains undefined after every successful workflow load.
Why this matters
These are published lifecycle guarantees, not optional instrumentation. Packs that defer DOM/canvas/store work to onReady never initialize. Packs that rebuild document-scoped projections on onWorkflowLoaded remain bound to stale graph state. The workflow API's document identity cannot distinguish edits from document swaps because it is never minted. The unit tests pass because they manually invoke the missing host transitions and therefore do not verify the production ownership path.
Suggested direction and verification
Import these host transition functions at the composition root. Call markAppReady() exactly once at the point that semantically replaces legacy extension setup(), after required host services exist. Call notifyWorkflowLoaded() exactly once at the successful tail of a real workflow configuration, after the active graph is the newly loaded graph; do not call it for undo/redo if those operations are intentionally the same document.
Add an integration-level startup test that subscribes through the public Comfy object and executes the real host startup/load seam. Assert that readiness fires once, workflow-loaded fires once per successful load, and workflow.documentId changes between two loads but not ordinary edits. The test must not call either transition function directly.
There was a problem hiding this comment.
Fixed. markAppReady() fires after the setup extension dispatch and notifyWorkflowLoaded() at the end of a successful load, so onReady and onWorkflowLoaded are sourced from the host.
| // pack subscribing to onNodeMoved at module scope throws otherwise. | ||
| installNodeMoveBridge() | ||
| installNodeChangeBridge() | ||
| // Which the API cannot see for itself: ChangeTracker lives up here. |
There was a problem hiding this comment.
[P1] Forward backend previews into the Node API registry. defs.onPreview registrations can never receive a frame in production.
Evidence and failure sequence
deliverPreview() is the sole dispatcher from a backend preview to previewSubscribers. A production search finds no caller. The only invocations are in registry tests.
The actual backend path is src/scripts/app.ts's b_preview_with_metadata handler. It receives { blob, displayNodeId, jobId }, normalizes the execution ID, creates an object URL, updates useJobPreviewStore() and useNodeOutputStore(), then releases the URL. It never resolves the owning node/type and never calls deliverPreview().
Failure sequence:
- A pack registers an
onPreviewhook for a node definition. applyTo()stores a callback inpreviewSubscribersfor that node type.- The backend emits
b_preview_with_metadata. - The app updates its internal stores, but the registry dispatcher is bypassed.
- The pack callback is never invoked, regardless of how many preview frames arrive.
Why this matters
The PR publishes preview delivery as a supported extension capability, but the real event path terminates before the API boundary. This is particularly deceptive because the registry unit test proves only that manually calling deliverPreview() invokes a subscriber; it does not prove that any backend event reaches that function. Extensions can implement against the documented API, compile, and then silently receive zero events.
Suggested direction and verification
Wire preview delivery from the existing backend event owner rather than adding a parallel listener. Resolve the exact graph and node type from the execution/display ID, construct the documented immutable PreviewFrame, and invoke deliverPreview() while the blob/object URL remains valid for the callback contract. Preserve the existing store updates.
Add a production-path test that dispatches b_preview_with_metadata through the real app event handler and asserts that a definition registered via the public API receives exactly one frame for the correct node and type. Include an unknown/deleted-node case to prove it is ignored safely.
There was a problem hiding this comment.
Fixed. The preview handler resolves the node the frame belongs to and calls deliverPreview(), so defs.onPreview registrations receive frames from the backend. Both dispatch paths also skip when the node cannot be resolved, since subscribers are keyed by type and an event can name a node in another scope.
| // Which the API cannot see for itself: ChangeTracker lives up here. | ||
| provideGraphLoadingState(() => ChangeTracker.isLoadingGraph) | ||
| installComfyApi(() => useCanvasStore().currentGraph, { | ||
| openWorkflow: async (data) => { |
There was a problem hiding this comment.
[P1] Emit onRefreshed after the host actually reloads node definitions. The public refresh notification currently has no production producer.
Evidence and failure sequence
notifyDefsRefreshed() is the only function that iterates refreshListeners; a repository-wide production search finds no caller. Tests invoke it directly.
defs.refresh() calls refreshDefs(), which lazy-imports the app and awaits app.refreshComboInNodes(). That reaches app.reloadNodeDefs(), fetches and registers definitions, refreshes widgets and outputs, invokes legacy refreshComboInNodes extensions, synchronizes promoted widget options, and updates Vue node definitions. None of those successful completion paths calls notifyDefsRefreshed().
Failure sequence:
- A pack subscribes through
comfy.defs.onRefreshed. - It or the user triggers definition refresh.
- Host definitions and widgets are rebuilt successfully.
refreshListenersis never iterated.- The pack's derived state remains based on the old definitions.
Why this matters
The API presents refresh() and onRefreshed() as the command and completion signal for the same lifecycle, but production executes only the command half. Callers cannot safely know when rebuilt definitions are available. As with preview delivery, the direct unit test hides the missing composition-root edge.
Suggested direction and verification
Make the host definition-reload owner emit one notification only after the complete successful refresh has finished, including promoted-widget synchronization and Vue registry update. Prefer placing the notification at the authoritative reloadNodeDefs()/refreshComboInNodes() completion boundary so user-initiated and API-initiated refreshes behave identically. Do not notify after a rejected refresh.
Add an integration test that subscribes through comfy.defs.onRefreshed, executes the real refresh path, and verifies ordering: the callback observes the newly registered definition and fires once. Add a rejected-refresh assertion proving it does not fire on failure.
There was a problem hiding this comment.
Fixed. notifyDefsRefreshed() fires at the end of refreshComboInNodes, and defs.refresh() now reaches the host through an injected refreshDefinitions hook rather than a lazy import of app.
| openWorkflow: async (data) => { | ||
| await this.loadGraphData(data as ComfyWorkflowJSON) | ||
| } | ||
| }) |
There was a problem hiding this comment.
[P2] Reapply pack-owned link colors after every palette load. Theme changes currently erase colors registered through the new API.
Evidence and failure sequence
The module comment correctly identifies the destructive host behavior: colorPaletteService.loadLinkColorPalette replaces/seeds LGraphCanvas.link_type_colors, wiping pack choices. setTypeColor() saves the choice in packTypeColors and calls applyPackTypeColors() only at registration time. reapplyPackTypeColors() is explicitly documented as the host callback after a palette load, but no production caller exists; only tests call it.
Failure sequence:
- A pack calls
comfy.defs.setTypeColor('PACK_TYPE', '#...'); both maps contain the color. - The user changes theme or palette.
- The palette service overwrites
LGraphCanvas.link_type_colors['PACK_TYPE']with its seeded value. - No host callback invokes
reapplyPackTypeColors(). defs.typeColor()can still report the saved pack color frompackTypeColors, while the renderer uses the wiped renderer table, so the API's read and the visible link disagree.
Why this matters
The implementation already chose a two-table ownership model specifically to survive palette replacement. Without the final host hook, that model creates internally contradictory state: querying the API says one color while the canvas draws another. The regression occurs during an ordinary user theme change and persists until the pack re-registers or the page reloads.
Suggested direction and verification
Call reapplyPackTypeColors() from the palette-loading owner immediately after it finishes replacing the renderer table. Keep palette loading responsible for the sequence; do not make every caller remember a second operation.
Add a test around the real palette-load seam: register a pack color, simulate palette replacement, run the host palette operation, and assert both typeColor() and LGraphCanvas.link_type_colors retain the pack color. Also verify that unsubscribing the color registration leaves the host palette value untouched according to the intended ownership contract.
There was a problem hiding this comment.
Fixed. reapplyPackTypeColors() runs after the palette writes LGraphCanvas.link_type_colors, so a theme change no longer erases pack-registered link colours.
| import { useNodeReplacementStore } from '@/platform/nodeReplacement/nodeReplacementStore' | ||
|
|
||
| import { useSubgraphNavigationStore } from '@/stores/subgraphNavigationStore' | ||
| import { installComfyApi } from '@/platform/nodeApi/comfyApi' |
There was a problem hiding this comment.
[P2] Remove the new defsRegistry → app → defsRegistry dependency cycle. Lazy loading postpones the cycle but does not restore dependency direction.
Evidence and failure sequence
defsRegistry.ts dynamically imports @/scripts/app to implement refreshDefs(). The application module imports and installs the Node API, and definition setup routes back into this registry, so Fallow reports the introduced cycle defsRegistry.ts → app.ts → defsRegistry.ts.
The source comment says the lazy import keeps the API module a leaf, but a dynamic import changes load timing, not ownership or dependency direction. The low-level published API registry now knows the concrete application singleton. It also contrasts with createComfyApi, which already accepts host-owned openWorkflow as an injected callback specifically to avoid importing app.
Why this matters
Cycles through a composition root make initialization order and test isolation harder to reason about, force hidden singleton coupling, and make the supposedly reusable registry impossible to instantiate without knowing about the full application. Dynamic import can hide the cycle from bundler timing while retaining runtime coupling and chunk costs.
Suggested direction and verification
Inject a narrow refreshDefinitions: () => Promise<void> host capability from the same composition root that supplies openWorkflow. Keep defsRegistry dependent only on that interface. The app remains the owner of how definitions refresh; the public API delegates without importing the app singleton.
Add a registry test with a fake injected refresher and an app composition test proving the production callback delegates to refreshComboInNodes(). Re-run Fallow's cycle analysis and require this cycle to disappear.
There was a problem hiding this comment.
Fixed. The cycle is gone: defsRegistry no longer imports @/scripts/app at all. defs.refresh() takes a host callback supplied through installComfyApi, which inverts the dependency instead of postponing it.
DrJKL
left a comment
There was a problem hiding this comment.
Request changes: the composition PR still leaves production callback, prompt, movement, deployment, and queue contracts unreliable.
Independent review scope and verification
I reviewed exact range 72456fe163170ebf9967c1b49cc16c0aa357ba29..77cdd03ab17d9794483aa5d986ee3c7ccd9830a4 independently before reading GitHub discussion. Four focused temporary repros confirmed callback misrouting, shared-subgraph omission, batch-drag silence, and the pre-canvas viewport issue. Twelve focused files passed 229 tests; typecheck, changed-file lint, and diff checks passed.
After freezing the pass, I omitted findings already covered by existing comments, including queue lifecycle, lifecycle producers, previews, unplaced-link installation, palette restoration, definition refresh, and the pre-canvas viewport issue. This review adds 5 net-new comments. It is submitted as COMMENT, not a request-changes event.
| installNodeChangeBridge() | ||
| // Which the API cannot see for itself: ChangeTracker lives up here. | ||
| provideGraphLoadingState(() => ChangeTracker.isLoadingGraph) | ||
| installComfyApi(() => useCanvasStore().currentGraph, { |
There was a problem hiding this comment.
P1 — This host composition still resolves definition callbacks through the visible graph rather than the callback node's owning graph.
Evidence, impact, and suggested direction
The registry's instance callbacks call handleFor(String(node.id)), while the API installed here resolves that ID against currentGraph. The instance-aware handleForDefinitionNode(node) already exists, but is used only for widget-type registration. In a root/subgraph repro with duplicate local ID 7, hidden InnerType#7's onCreated received the visible root's RootType#7 handle.
Creation, execution, property, resize, hover/drop, connection, and serialization hooks can therefore mutate or inspect the wrong entity. Use the actual node and owner graph for every definition callback; bridges must retain owner graph/node identity rather than only local ID. Exercise real root/subgraph configuration, execution, and serialization with duplicate IDs.
There was a problem hiding this comment.
Addressed. Definition callbacks resolve through handleForDefinitionNode, which builds a per-owner graph scope from node.graph and resolves the node inside it, rather than through the visible graph. Handle caches are also keyed by graph scope now, so a node in a subgraph no longer reuses the root graph's handle.
| into = new Map<string, LGraph>(), | ||
| visited = new Set<LGraph>() | ||
| ): Map<string, LGraph> { | ||
| if (visited.has(graph)) return into |
There was a problem hiding this comment.
P1 — A shared subgraph definition is resolved only for its first placement.
Evidence, impact, and suggested direction
This global visited: Set<LGraph> treats a reused definition object as already traversed. If two subgraph nodes reference that definition, traversal records prefix 10: and skips 20:, even though prompt flattening creates both execution paths. A real-graph probe produced a resolved literal for the first backend placement and no input for the second; cleanup then removed the dangling source.
Walk every instance path and use a per-branch recursion stack only to break cycles. Cover two placements and nested placements for literal, forwarded-output, and supplier resolution.
There was a problem hiding this comment.
Fixed. executionScopes tracks the ancestor chain rather than a global visited set, so a subgraph definition placed more than once is walked for every placement instead of only the first.
| export function installNodeMoveBridge(): void { | ||
| provideNodeMoveSource((onMove) => | ||
| layoutStore.onChange((change: LayoutChange) => { | ||
| if (change.operation.type !== 'moveNode') return |
There was a problem hiding this comment.
P1 — Normal Nodes 2.0 dragging bypasses both movement and drag-end callbacks.
Evidence, impact, and suggested direction
This bridge accepts only moveNode, but the production Vue drag path uses batchMoveNodes → batchUpdateBounds. A focused probe moved layout to {33, 44} through that exact batch path while both public callback counts remained zero; the drag-end accumulator has the same filter.
Consume the authoritative batch bounds operation, emit each moved node's resulting position, and accumulate those IDs during a Vue drag. Test the real production path with multiselect and exactly one release callback.
There was a problem hiding this comment.
Fixed. Nodes 2.0 commits a multi-node drag as batchUpdateBounds, not moveNode, so the bridge saw nothing when a selection moved. Both operations now feed the move source and the drag-end accumulator, with a regression test verified red beforehand.
| /** | ||
| * The published node API, as a converted pack imports it: | ||
| * | ||
| * import { comfy } from '/comfy/api/v2.js' |
There was a problem hiding this comment.
P1 — The documented absolute module specifier fails when ComfyUI is served from a supported reverse-proxy subpath.
Evidence, impact, and suggested direction
A browser resolves /comfy/api/v2.js from the origin root. ComfyUI explicitly supports bases such as /ComfyUI/, and host assets use api_base; in that deployment this file is at /ComfyUI/comfy/api/v2.js. Following the published import therefore requests the wrong route and aborts extension evaluation with a 404.
Provide a host-generated, base-aware stable specifier (for example through an import map) rather than an origin-absolute path, and build/load a real extension under /ComfyUI/ in regression coverage.
There was a problem hiding this comment.
Not changed, and worth a decision rather than a silent fix. The absolute specifier is the published contract — it is what the guide tells packs to write and what the generated .d.ts now declares — so changing it is a breaking change to the surface, not a bug fix. A relative or base-aware specifier would also have to survive being imported from a pack directory at an arbitrary depth. If ComfyUI behind a subpath proxy is a configuration we mean to support, I would rather track it as its own change against the contract than alter the specifier late in review. Say the word and I will file it.
There was a problem hiding this comment.
Correction to my earlier decline: fixed. index.html now maps the stable /comfy/api/v2.js specifier to %BASE_URL%comfy/api/v2.js. The regression test builds with /ComfyUI/ and verifies the emitted import map targets /ComfyUI/comfy/api/v2.js while the entry file is present.
| openWorkflow: async (data) => { | ||
| await this.loadGraphData(data as ComfyWorkflowJSON) | ||
| } | ||
| }) |
There was a problem hiding this comment.
P1 — The JavaScript boundary accepts invalid and unbounded batch counts.
Evidence, impact, and suggested direction
This forwards batch without runtime validation. The host loops while i < batchCount, so Infinity creates an unbounded submission loop, 1.5 submits twice, and zero, negative, or NaN silently do nothing. TypeScript cannot protect untyped packs at runtime.
Reuse the existing positive-safe-integer validation from setBatchCount before importing the app. Test 0, negative, fractional, NaN, Infinity, and unsafe integers and assert no host call occurs.
There was a problem hiding this comment.
Fixed. assertBatchCount rejects anything that is not a positive safe integer, and it guards both queue.run({ batch }) and queue.setBatchCount().
77cdd03 to
936c4cf
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Wired the capabilities this layer owns. Your search was right — none of these had a production caller.
Also fixed The |
936c4cf to
23fb9fb
Compare
23fb9fb to
035c216
Compare
2f5e755 to
70e8ad7
Compare
70e8ad7 to
ace3045
Compare
|
Fixing prev version before refactor. The branch now includes the surface repairs and these host fixes:
Commits: 8d2ac27, cf6c083, 75b2791, 5678f28; b2c06ec removes an obsolete static-analysis exemption exposed by the new host test. Behavior regressions failed before fixes. The combined API/host suites passed 1,117 tests with two existing skips before the last queue merge; merged queue tests pass 35/35. The complete documentation stack, including the queue merge and generated contract checks, passes 1,133 tests with the same two skips. Normal commit and push checks pass. Public signatures are unchanged. GitHub CI is still running. These tests cover component/host integration, not a complete real application boot or a browser render qualification. Reopening a document with the same saved graph UUID still needs the separate handle-lifetime repair. Review threads remain open for review. |
promptQueued was dispatched only after the whole batch loop, so when building a later item threw, the runs the backend had already accepted were never announced and onAfterRun did not fire for them. The announcement now happens whenever the attempt ends. Fixing the previous version before the refactor. Review thread: #16791 (comment)
|
Fixing the previous version before the refactor.
|
The host now marks each load that replaces the document, so handles kept from the previous one read as deleted. A workflow load marks it just before configuring, unless it restores the same document for undo or redo. The API JSON and A1111 imports mark it once the old graph is cleared, before they add nodes. Fixing the previous version before the refactor.
|
Fixing the previous version before the refactor.
|
# Conflicts: # src/platform/nodeApi/defsRegistry.test.ts
|
Fixing the previous version before the refactor.
|
|
Fixing the previous version before the refactor. Updated this branch through
Subpath evidence: a real production build with Final combined validation: 1,260 tests passed across 46 files; two existing skips. Normal hooks passed. Queue-veto/async-transport-specific findings remain assigned to removal in the refactor. |
When an opened or dropped file carries no workflow, prompt or parameters the host can read, registered pack importers are asked before the host falls back to a media node or the load error. A workflow or prompt one of them returns is loaded the way an embedded one is. A file the host can read is never offered to them.
# Conflicts: # src/platform/nodeApi/defsRegistry.ts
|
# Conflicts: # src/platform/nodeApi/workflowHandle.test.ts
The host now tells the node API which workflows are open and which is on screen. Each time a workflow is opened it gets a session id that it keeps through tab switches, edits and renames, and loses when it is closed, so opening it again starts a new session. onWorkflowLoaded listeners are now also told about an undo or redo, which rebuilds the same document; the internal load id still changes only on a real load.
|
Summary
Connects the V2 JavaScript API to ComfyUI startup, definition callbacks, widget serialization and graph/layout notifications. Keeps the existing workflow-load lifecycle and upstream execution/preview ownership checks.
Rebased onto the refreshed API surface. The obsolete strict-lint config ignore was removed so Knip passes against current main. Public declarations are unchanged; the API remains preview.
Verification
Full stack: 964 unit checks passed with two existing skips; app/browser typechecks, production/declaration builds, consumer types, lint, formatting and normal push hooks passed. Local non-sandboxed V2.1 ComfyUI passed 11 browser checks across both renderers and ten HTTP/WebSocket checks. Independent source review found no rebase blocker. GPU, Electron, deployed sandbox and full pack-corpus validation remain separate.