Repository navigation
docs(nodeApi): the guide, the example packs, and end-to-end coverage - #16792
benjcooley wants to merge 39 commits into
Conversation
⚡ Performance: ❌ 8 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-12T04:47:54.249Z",
"gitSha": "5165ecdc1fd45ea8fd4c48448cc22581e96d7c74",
"branch": "benjcooley/node-api-docs",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.7230000000181,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.007,
"layouts": 8,
"layoutDurationMs": 2.066,
"taskDurationMs": 579.16,
"heapDeltaBytes": 7322024,
"heapUsedBytes": 77318676,
"domNodes": -178,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 8.641,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2038.1049999999732,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.387,
"layouts": 9,
"layoutDurationMs": 2.292,
"taskDurationMs": 575.77,
"heapDeltaBytes": -8759928,
"heapUsedBytes": 70938280,
"domNodes": -178,
"jsHeapTotalBytes": 9826304,
"scriptDurationMs": 8.193,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.3109999999967,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.713000000000003,
"layouts": 9,
"layoutDurationMs": 2.198,
"taskDurationMs": 933.4559999999999,
"heapDeltaBytes": -17450680,
"heapUsedBytes": 66947000,
"domNodes": -178,
"jsHeapTotalBytes": 10350592,
"scriptDurationMs": 159.14999999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1777.464000000009,
"styleRecalcs": 75,
"styleRecalcDurationMs": 11.774,
"layouts": 9,
"layoutDurationMs": 2.103,
"taskDurationMs": 901.0050000000001,
"heapDeltaBytes": -362264,
"heapUsedBytes": 70102120,
"domNodes": -178,
"jsHeapTotalBytes": 8253440,
"scriptDurationMs": 157.784,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1691.1440000000084,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.455000000000001,
"layouts": 11,
"layoutDurationMs": 2.2979999999999996,
"taskDurationMs": 404.52700000000004,
"heapDeltaBytes": 2540384,
"heapUsedBytes": 72465216,
"domNodes": 57,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 10.090000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.1579999999267,
"styleRecalcs": 20,
"styleRecalcDurationMs": 5.103000000000001,
"layouts": 12,
"layoutDurationMs": 2.8400000000000003,
"taskDurationMs": 412.97,
"heapDeltaBytes": 25657328,
"heapUsedBytes": 93842208,
"domNodes": 57,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 10.488000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 585.0750000000176,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.9139999999999997,
"layouts": 9,
"layoutDurationMs": 2.3049999999999997,
"taskDurationMs": 433.27700000000004,
"heapDeltaBytes": 7135540,
"heapUsedBytes": 92251864,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 163.88400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 642.247999999995,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.7210000000000005,
"layouts": 9,
"layoutDurationMs": 2.222,
"taskDurationMs": 476.883,
"heapDeltaBytes": 1023504,
"heapUsedBytes": 70608764,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 161.878,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102567,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1124.288000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 796.6460000000001,
"heapDeltaBytes": 28769888,
"heapUsedBytes": 108213784,
"domNodes": 0,
"jsHeapTotalBytes": 13791232,
"scriptDurationMs": 63.84000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 488,
"frameDurationMs": 32.84411764705883,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1120.113999999944,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 790.2660000000002,
"heapDeltaBytes": 33447040,
"heapUsedBytes": 104423704,
"domNodes": 0,
"jsHeapTotalBytes": 9072640,
"scriptDurationMs": 61.472,
"eventListeners": 0,
"totalBlockingTimeMs": 478,
"frameDurationMs": 32.844117647058816,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.1269999999909,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.46100000000035,
"heapDeltaBytes": -7305640,
"heapUsedBytes": 76827232,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 155.78799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 25.00294117647057,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 827.6990000000524,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.23899999999986,
"heapDeltaBytes": -6132176,
"heapUsedBytes": 75928720,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 148.146,
"eventListeners": 0,
"totalBlockingTimeMs": 203,
"frameDurationMs": 24.50882352941177,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9528.151000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8532.851,
"heapDeltaBytes": -12566428,
"heapUsedBytes": 81030484,
"domNodes": -274,
"jsHeapTotalBytes": 1699840,
"scriptDurationMs": 6591.000999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 135,
"frameDurationMs": 26.609523809523804,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9266.576000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8443.135999999999,
"heapDeltaBytes": 889240,
"heapUsedBytes": 69189512,
"domNodes": 0,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 6659.728,
"eventListeners": 0,
"totalBlockingTimeMs": 140,
"frameDurationMs": 27.12521994134897,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8725.760000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7854.0520000000015,
"heapDeltaBytes": -3402600,
"heapUsedBytes": 71451796,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 6465.644,
"eventListeners": 0,
"totalBlockingTimeMs": 170,
"frameDurationMs": 29.2496644295302,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9177.165000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8274.695,
"heapDeltaBytes": -1968380,
"heapUsedBytes": 77119584,
"domNodes": 0,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 6432.353,
"eventListeners": 0,
"totalBlockingTimeMs": 140,
"frameDurationMs": 26.492196531791905,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 232.32800000002385,
"styleRecalcs": 24,
"styleRecalcDurationMs": 11.639999999999999,
"layouts": 12,
"layoutDurationMs": 3.4,
"taskDurationMs": 175.309,
"heapDeltaBytes": -14360096,
"heapUsedBytes": 76488060,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.143,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.209090909090925,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 226.31599999999708,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.171000000000001,
"layouts": 8,
"layoutDurationMs": 2.15,
"taskDurationMs": 165.70200000000003,
"heapDeltaBytes": 14095076,
"heapUsedBytes": 82502224,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.243,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.218181818181826,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-graph-idle",
"durationMs": 2105.4320000000075,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.8529999999999995,
"layouts": 4,
"layoutDurationMs": 1.0730000000000002,
"taskDurationMs": 664.62,
"heapDeltaBytes": 18461956,
"heapUsedBytes": 86041876,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 37.857,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665079365079368,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2069.3259999999327,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.374,
"layouts": 7,
"layoutDurationMs": 2.093,
"taskDurationMs": 677.7139999999999,
"heapDeltaBytes": -24036340,
"heapUsedBytes": 77274664,
"domNodes": -274,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 35.063,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258063,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2583.0720000000156,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.217,
"layouts": 6,
"layoutDurationMs": 1.5599999999999998,
"taskDurationMs": 1554.072,
"heapDeltaBytes": 3757760,
"heapUsedBytes": 84222904,
"domNodes": -274,
"jsHeapTotalBytes": 876544,
"scriptDurationMs": 652.0219999999999,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666451612903224,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2486.450999999988,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.268999999999998,
"layouts": 7,
"layoutDurationMs": 1.9749999999999999,
"taskDurationMs": 1561.3270000000005,
"heapDeltaBytes": 568856,
"heapUsedBytes": 84146756,
"domNodes": -274,
"jsHeapTotalBytes": 90112,
"scriptDurationMs": 652.5179999999999,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3567.2099999999887,
"styleRecalcs": 66,
"styleRecalcDurationMs": 7.987000000000001,
"layouts": 60,
"layoutDurationMs": 8.638,
"taskDurationMs": 1627.859,
"heapDeltaBytes": 2597172,
"heapUsedBytes": 72690712,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 634.571,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3519.7549999999183,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.992,
"layouts": 64,
"layoutDurationMs": 9.440999999999999,
"taskDurationMs": 1651.3899999999996,
"heapDeltaBytes": -12509336,
"heapUsedBytes": 69561328,
"domNodes": -250,
"jsHeapTotalBytes": 126976,
"scriptDurationMs": 644.8510000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635071090047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3099.9229999999898,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.050000000000001,
"layouts": 4,
"layoutDurationMs": 1.1150000000000002,
"taskDurationMs": 1991.297,
"heapDeltaBytes": -5270328,
"heapUsedBytes": 77532528,
"domNodes": -274,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 916.577,
"eventListeners": 113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756216216216213,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2698.709000000008,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.122000000000001,
"layouts": 4,
"layoutDurationMs": 1.1799999999999997,
"taskDurationMs": 1840.495,
"heapDeltaBytes": -14731724,
"heapUsedBytes": 71034272,
"domNodes": -259,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 821.224,
"eventListeners": 113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.874375000000004,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "litegraph-245-idle",
"durationMs": 1516.5949999999384,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.2989999999999997,
"layouts": 5,
"layoutDurationMs": 0.9849999999999998,
"taskDurationMs": 37.10099999999994,
"heapDeltaBytes": 4576524,
"heapUsedBytes": 87241168,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 22.607999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66703296703297,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "litegraph-245-idle",
"durationMs": 1516.9329999999945,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.8880000000000008,
"layouts": 4,
"layoutDurationMs": 0.9359999999999997,
"taskDurationMs": 34.76000000000001,
"heapDeltaBytes": 4577768,
"heapUsedBytes": 87451272,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 21.432999999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66593406593406,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "litegraph-245-pan",
"durationMs": 4070.467000000008,
"styleRecalcs": 124,
"styleRecalcDurationMs": 15.296000000000001,
"layouts": 117,
"layoutDurationMs": 7.227000000000001,
"taskDurationMs": 1631.79,
"heapDeltaBytes": -8332016,
"heapUsedBytes": 78928160,
"domNodes": -228,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 1245.444,
"eventListeners": -64,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665983606557372,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "litegraph-245-pan",
"durationMs": 4056.051000000025,
"styleRecalcs": 124,
"styleRecalcDurationMs": 15.106,
"layouts": 117,
"layoutDurationMs": 7.1530000000000005,
"taskDurationMs": 1641.9479999999999,
"heapDeltaBytes": -8645560,
"heapUsedBytes": 79116308,
"domNodes": -228,
"jsHeapTotalBytes": 1662976,
"scriptDurationMs": 1261.851,
"eventListeners": -64,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66625514403292,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "litegraph-245-progress",
"durationMs": 2352.630999999974,
"styleRecalcs": 140,
"styleRecalcDurationMs": 20.852,
"layouts": 20,
"layoutDurationMs": 6.055999999999999,
"taskDurationMs": 335.0619999999997,
"heapDeltaBytes": -741416,
"heapUsedBytes": 82663260,
"domNodes": 20,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 210.13700000000003,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "litegraph-245-progress",
"durationMs": 2351.6650000000254,
"styleRecalcs": 140,
"styleRecalcDurationMs": 20.107999999999997,
"layouts": 20,
"layoutDurationMs": 5.325,
"taskDurationMs": 330.0709999999998,
"heapDeltaBytes": -718412,
"heapUsedBytes": 83033664,
"domNodes": 20,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 208.12300000000005,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66524822695036,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "litegraph-245-zoom",
"durationMs": 4012.429999999995,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.333999999999997,
"layouts": 70,
"layoutDurationMs": 8.062999999999999,
"taskDurationMs": 878.9549999999999,
"heapDeltaBytes": 2779248,
"heapUsedBytes": 82821900,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 692.9120000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66597510373444,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "litegraph-245-zoom",
"durationMs": 4012.646000000018,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.033000000000001,
"layouts": 70,
"layoutDurationMs": 7.994999999999998,
"taskDurationMs": 874.4459999999998,
"heapDeltaBytes": 3218984,
"heapUsedBytes": 83448692,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 691.8740000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66597510373444,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "litegraph-60-idle",
"durationMs": 1514.2730000000029,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16.819000000000138,
"heapDeltaBytes": 1248788,
"heapUsedBytes": 79571784,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.121000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66593406593407,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "litegraph-60-idle",
"durationMs": 1523.1320000000323,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 36.422000000000175,
"heapDeltaBytes": -57432276,
"heapUsedBytes": 66009764,
"domNodes": -367,
"jsHeapTotalBytes": -1183744,
"scriptDurationMs": 10.455999999999992,
"eventListeners": -1620,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66593406593407,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "litegraph-60-pan",
"durationMs": 4040.8729999999196,
"styleRecalcs": 124,
"styleRecalcDurationMs": 16.661,
"layouts": 119,
"layoutDurationMs": 7.783999999999999,
"taskDurationMs": 1656.98,
"heapDeltaBytes": 15010812,
"heapUsedBytes": 94603020,
"domNodes": 7,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 1164.5970000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66570247933884,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "litegraph-60-pan",
"durationMs": 4040.018000000032,
"styleRecalcs": 124,
"styleRecalcDurationMs": 16.74,
"layouts": 119,
"layoutDurationMs": 7.587,
"taskDurationMs": 1670.074,
"heapDeltaBytes": 14599032,
"heapUsedBytes": 80629220,
"domNodes": 7,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 1176.099,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665702479338844,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "litegraph-60-progress",
"durationMs": 2369.0090000000055,
"styleRecalcs": 141,
"styleRecalcDurationMs": 21.309,
"layouts": 20,
"layoutDurationMs": 5.677000000000001,
"taskDurationMs": 353.05500000000035,
"heapDeltaBytes": -149076,
"heapUsedBytes": 83380140,
"domNodes": 20,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 228.2449999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66690140845071,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "litegraph-60-progress",
"durationMs": 2352.0469999999705,
"styleRecalcs": 140,
"styleRecalcDurationMs": 20.355000000000004,
"layouts": 20,
"layoutDurationMs": 5.631,
"taskDurationMs": 345.726,
"heapDeltaBytes": 11960,
"heapUsedBytes": 69598824,
"domNodes": 20,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 222.46500000000015,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "litegraph-60-zoom",
"durationMs": 4010.413999999969,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.258000000000001,
"layouts": 70,
"layoutDurationMs": 9.572,
"taskDurationMs": 892.8580000000004,
"heapDeltaBytes": -12411164,
"heapUsedBytes": 83176712,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 545.631,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66597510373444,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "litegraph-60-zoom",
"durationMs": 4027.086000000054,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.893999999999998,
"layouts": 70,
"layoutDurationMs": 9.444,
"taskDurationMs": 881.5580000000001,
"heapDeltaBytes": -12378808,
"heapUsedBytes": 69307332,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 530.2419999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3063.262000000009,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.489,
"layouts": 6,
"layoutDurationMs": 1.7670000000000003,
"taskDurationMs": 726.537,
"heapDeltaBytes": 8942164,
"heapUsedBytes": 93107704,
"domNodes": -274,
"jsHeapTotalBytes": 126976,
"scriptDurationMs": 309.09200000000004,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576086956522,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3045.6950000000234,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9089999999999991,
"layouts": 7,
"layoutDurationMs": 2.0020000000000002,
"taskDurationMs": 769.054,
"heapDeltaBytes": 4701436,
"heapUsedBytes": 89249508,
"domNodes": -274,
"jsHeapTotalBytes": 651264,
"scriptDurationMs": 316.004,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666120218579234,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2060.7289999999807,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.921,
"layouts": 7,
"layoutDurationMs": 1.697,
"taskDurationMs": 654.265,
"heapDeltaBytes": -5915720,
"heapUsedBytes": 77209416,
"domNodes": -274,
"jsHeapTotalBytes": -1183744,
"scriptDurationMs": 27.784000000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258063,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2036.8780000000015,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.3,
"layouts": 5,
"layoutDurationMs": 1.1219999999999997,
"taskDurationMs": 609.5330000000001,
"heapDeltaBytes": -1213568,
"heapUsedBytes": 86814076,
"domNodes": -274,
"jsHeapTotalBytes": -921600,
"scriptDurationMs": 29.773999999999994,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2882.9240000000027,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.623,
"layouts": 6,
"layoutDurationMs": 1.519,
"taskDurationMs": 651.0100000000001,
"heapDeltaBytes": 6435020,
"heapUsedBytes": 91355088,
"domNodes": -255,
"jsHeapTotalBytes": 1437696,
"scriptDurationMs": 209.10099999999997,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76279069767442,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2761.6459999999847,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.033000000000001,
"layouts": 3,
"layoutDurationMs": 0.477,
"taskDurationMs": 550.1709999999999,
"heapDeltaBytes": 3877700,
"heapUsedBytes": 73810744,
"domNodes": 19,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 184.81900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3172.2450000000035,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.967,
"layouts": 7,
"layoutDurationMs": 4.763999999999999,
"taskDurationMs": 904.7590000000001,
"heapDeltaBytes": -13207888,
"heapUsedBytes": 70960540,
"domNodes": -274,
"jsHeapTotalBytes": -921600,
"scriptDurationMs": 318.63599999999997,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66578947368421,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3169.5290000000114,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5460000000000005,
"layouts": 2,
"layoutDurationMs": 0.5900000000000003,
"taskDurationMs": 822.45,
"heapDeltaBytes": 11471252,
"heapUsedBytes": 81453580,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 304.39500000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66578947368421,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 613.4180000000242,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.082999999999999,
"layouts": 9,
"layoutDurationMs": 2.379,
"taskDurationMs": 441.66200000000003,
"heapDeltaBytes": -1756256,
"heapUsedBytes": 69430768,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 144.284,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66388888888889,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.074999999928,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.150999999999999,
"layouts": 9,
"layoutDurationMs": 2.335,
"taskDurationMs": 436.098,
"heapDeltaBytes": 22835932,
"heapUsedBytes": 93458628,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 142.55499999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66285714285715,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2032.8030000000297,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.3430000000000004,
"layouts": 9,
"layoutDurationMs": 2.2419999999999995,
"taskDurationMs": 576.885,
"heapDeltaBytes": -10602312,
"heapUsedBytes": 59378748,
"domNodes": -200,
"jsHeapTotalBytes": 7467008,
"scriptDurationMs": 8.611,
"eventListeners": -120,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.8160000000107,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.275,
"layouts": 9,
"layoutDurationMs": 2.3019999999999996,
"taskDurationMs": 575.515,
"heapDeltaBytes": -918596,
"heapUsedBytes": 69508040,
"domNodes": -200,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 7.795,
"eventListeners": -120,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1743.961000000013,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.045,
"layouts": 9,
"layoutDurationMs": 1.8960000000000001,
"taskDurationMs": 885.035,
"heapDeltaBytes": 1784888,
"heapUsedBytes": 72721064,
"domNodes": -200,
"jsHeapTotalBytes": 8253440,
"scriptDurationMs": 104.17,
"eventListeners": -120,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1775.492999999983,
"styleRecalcs": 79,
"styleRecalcDurationMs": 13.624,
"layouts": 9,
"layoutDurationMs": 1.848,
"taskDurationMs": 875.0479999999999,
"heapDeltaBytes": -89196,
"heapUsedBytes": 71009096,
"domNodes": -200,
"jsHeapTotalBytes": 8515584,
"scriptDurationMs": 106.91199999999999,
"eventListeners": -120,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66509433962264,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1554.2189999999891,
"styleRecalcs": 19,
"styleRecalcDurationMs": 49.403000000000006,
"layouts": 6,
"layoutDurationMs": 29.043,
"taskDurationMs": 1274.406,
"heapDeltaBytes": 18465212,
"heapUsedBytes": 110928628,
"domNodes": 19868,
"jsHeapTotalBytes": 19009536,
"scriptDurationMs": 31.211999999999996,
"eventListeners": 4126,
"totalBlockingTimeMs": 211,
"frameDurationMs": 21.17027027027026,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10532.757000000003,
"styleRecalcs": 250,
"styleRecalcDurationMs": 27.951000000000004,
"layouts": 8,
"layoutDurationMs": 2.089,
"taskDurationMs": 5736.677000000001,
"heapDeltaBytes": 10088680,
"heapUsedBytes": 90550264,
"domNodes": -274,
"jsHeapTotalBytes": 1105920,
"scriptDurationMs": 2308.002,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66598101265823,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9031.584000000066,
"styleRecalcs": 251,
"styleRecalcDurationMs": 27.877,
"layouts": 9,
"layoutDurationMs": 5.116,
"taskDurationMs": 5437.341,
"heapDeltaBytes": -242068,
"heapUsedBytes": 82350748,
"domNodes": -274,
"jsHeapTotalBytes": 843776,
"scriptDurationMs": 2159.591,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666051660516608,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-245-idle",
"durationMs": 1512.028999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 67.6589999999999,
"heapDeltaBytes": -9628584,
"heapUsedBytes": 289569528,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 22.244,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66593406593407,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-245-idle",
"durationMs": 1505.5469999999787,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 48.9809999999995,
"heapDeltaBytes": 4825616,
"heapUsedBytes": 293423380,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 19.367999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66593406593407,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-245-pan",
"durationMs": 4093.4439999999768,
"styleRecalcs": 129,
"styleRecalcDurationMs": 19.32800000000001,
"layouts": 6,
"layoutDurationMs": 4.787999999999987,
"taskDurationMs": 2468.344,
"heapDeltaBytes": 25322956,
"heapUsedBytes": 315203192,
"domNodes": 7,
"jsHeapTotalBytes": 4157440,
"scriptDurationMs": 978.421,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571428,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-245-pan",
"durationMs": 4078.4810000000107,
"styleRecalcs": 129,
"styleRecalcDurationMs": 19.545000000000034,
"layouts": 6,
"layoutDurationMs": 4.8400000000000105,
"taskDurationMs": 2423.3190000000004,
"heapDeltaBytes": -625368,
"heapUsedBytes": 292828576,
"domNodes": 7,
"jsHeapTotalBytes": 6483968,
"scriptDurationMs": 970.901,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665983606557376,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-245-progress",
"durationMs": 3061.890999999946,
"styleRecalcs": 152,
"styleRecalcDurationMs": 174.32200000000003,
"layouts": 21,
"layoutDurationMs": 5.381999999999998,
"taskDurationMs": 1151.129000000001,
"heapDeltaBytes": -4009424,
"heapUsedBytes": 304463648,
"domNodes": 28,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 119.08800000000008,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666483516483513,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-245-progress",
"durationMs": 3032.87899999998,
"styleRecalcs": 151,
"styleRecalcDurationMs": 155.62599999999998,
"layouts": 20,
"layoutDurationMs": 4.600999999999994,
"taskDurationMs": 1031.276,
"heapDeltaBytes": 22964616,
"heapUsedBytes": 312074296,
"domNodes": 28,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 107.92499999999983,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.758011049723763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-245-zoom",
"durationMs": 4730.062999999973,
"styleRecalcs": 99,
"styleRecalcDurationMs": 12.45099999999999,
"layouts": 99,
"layoutDurationMs": 26.635999999999992,
"taskDurationMs": 2142.95,
"heapDeltaBytes": 20314332,
"heapUsedBytes": 307858596,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 607.091,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.784751773049642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-245-zoom",
"durationMs": 4730.587000000014,
"styleRecalcs": 99,
"styleRecalcDurationMs": 12.174999999999992,
"layouts": 99,
"layoutDurationMs": 26.032,
"taskDurationMs": 2104.472,
"heapDeltaBytes": -6668652,
"heapUsedBytes": 288433524,
"domNodes": 0,
"jsHeapTotalBytes": 593920,
"scriptDurationMs": 608.7640000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.72473498233216,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-60-idle",
"durationMs": 1515.5919999999696,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27.815000000000367,
"heapDeltaBytes": 1266268,
"heapUsedBytes": 324006716,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.568000000000021,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66593406593407,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-60-idle",
"durationMs": 1514.0760000000455,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27.108000000000132,
"heapDeltaBytes": 1266512,
"heapUsedBytes": 315830376,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.701999999999988,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66593406593407,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-60-pan",
"durationMs": 4060.8459999999695,
"styleRecalcs": 123,
"styleRecalcDurationMs": 15.618999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1789.606,
"heapDeltaBytes": -10242536,
"heapUsedBytes": 313852928,
"domNodes": 7,
"jsHeapTotalBytes": 4112384,
"scriptDurationMs": 727.574,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73471074380165,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-60-pan",
"durationMs": 4042.7530000000615,
"styleRecalcs": 123,
"styleRecalcDurationMs": 16.658000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1771.834,
"heapDeltaBytes": 17226392,
"heapUsedBytes": 333076068,
"domNodes": 7,
"jsHeapTotalBytes": 5853184,
"scriptDurationMs": 720.307,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-60-progress",
"durationMs": 2733.347999999978,
"styleRecalcs": 144,
"styleRecalcDurationMs": 81.93299999999998,
"layouts": 138,
"layoutDurationMs": 39.47699999999998,
"taskDurationMs": 1852.3119999999994,
"heapDeltaBytes": -7463616,
"heapUsedBytes": 317305316,
"domNodes": 28,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 83.09600000000006,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66646341463414,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-60-progress",
"durationMs": 2799.4390000000067,
"styleRecalcs": 148,
"styleRecalcDurationMs": 86.75900000000003,
"layouts": 140,
"layoutDurationMs": 40.016999999999996,
"taskDurationMs": 1876.9590000000012,
"heapDeltaBytes": -8163448,
"heapUsedBytes": 307736936,
"domNodes": 28,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 84.4069999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.86626506024096,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-60-zoom",
"durationMs": 4245.490000000018,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.51099999999999,
"layouts": 70,
"layoutDurationMs": 8.141000000000009,
"taskDurationMs": 1393.320000000001,
"heapDeltaBytes": 9714560,
"heapUsedBytes": 324493976,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 407.849,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665882352941182,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-60-zoom",
"durationMs": 4261.774999999943,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.579999999999977,
"layouts": 70,
"layoutDurationMs": 7.948000000000011,
"taskDurationMs": 1385.9980000000007,
"heapDeltaBytes": 9362040,
"heapUsedBytes": 315629452,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 403.73400000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666015625,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 26684.871999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 26531.615,
"heapDeltaBytes": -40464840,
"heapUsedBytes": 278260716,
"domNodes": -3731,
"jsHeapTotalBytes": 4435968,
"scriptDurationMs": 297.58399999999995,
"eventListeners": -674,
"totalBlockingTimeMs": 0,
"frameDurationMs": 53.04612326043737,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-idle",
"durationMs": 27054.371999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 26962.655000000002,
"heapDeltaBytes": -2631984,
"heapUsedBytes": 288777388,
"domNodes": -3437,
"jsHeapTotalBytes": 26738688,
"scriptDurationMs": 314.743,
"eventListeners": -674,
"totalBlockingTimeMs": 0,
"frameDurationMs": 54.856072874493925,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 31055.376000000026,
"styleRecalcs": 209,
"styleRecalcDurationMs": 18.754999999999967,
"layouts": 29,
"layoutDurationMs": 10.285999999999989,
"taskDurationMs": 30997.047999999995,
"heapDeltaBytes": -16266688,
"heapUsedBytes": 278010864,
"domNodes": 0,
"jsHeapTotalBytes": -14417920,
"scriptDurationMs": 728.3499999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 62.851821862348174,
"p95FrameDurationMs": 133.20000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 31889.755000000037,
"styleRecalcs": 210,
"styleRecalcDurationMs": 19.735000000000003,
"layouts": 29,
"layoutDurationMs": 10.272000000000004,
"taskDurationMs": 31860.253999999997,
"heapDeltaBytes": -25019204,
"heapUsedBytes": 295911020,
"domNodes": -3437,
"jsHeapTotalBytes": 20639744,
"scriptDurationMs": 743.694,
"eventListeners": -672,
"totalBlockingTimeMs": 0,
"frameDurationMs": 67.83425531914894,
"p95FrameDurationMs": 133.3000000000011
},
{
"name": "vue-node-resize-workload",
"durationMs": 9830.31299999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.36500000000001,
"layouts": 36,
"layoutDurationMs": 16.694999999999986,
"taskDurationMs": 9815.037,
"heapDeltaBytes": -10737192,
"heapUsedBytes": 311842756,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 122.35499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 60.6969135802469,
"p95FrameDurationMs": 116.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 9719.594999999914,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.83099999999997,
"layouts": 36,
"layoutDurationMs": 16.821,
"taskDurationMs": 9705.005,
"heapDeltaBytes": -7817008,
"heapUsedBytes": 312059020,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 128.17100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 58.28143712574849,
"p95FrameDurationMs": 116.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 13673.793999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13575.329,
"heapDeltaBytes": -17664252,
"heapUsedBytes": 277221468,
"domNodes": -3437,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 161.885,
"eventListeners": -674,
"totalBlockingTimeMs": 0,
"frameDurationMs": 52.76486486486486,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 13478.982999999971,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13406.382000000001,
"heapDeltaBytes": -22962512,
"heapUsedBytes": 271504580,
"domNodes": -3434,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 166.61900000000009,
"eventListeners": -674,
"totalBlockingTimeMs": 0,
"frameDurationMs": 53.01574803149608,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "workflow-execution",
"durationMs": 125.90000000000146,
"styleRecalcs": 12,
"styleRecalcDurationMs": 11.491000000000001,
"layouts": 10,
"layoutDurationMs": 4.420999999999999,
"taskDurationMs": 95.13300000000001,
"heapDeltaBytes": 5282608,
"heapUsedBytes": 75676928,
"domNodes": 132,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 13.466000000000001,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 114.81900000001133,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.518,
"layouts": 9,
"layoutDurationMs": 2.6489999999999996,
"taskDurationMs": 81.20799999999998,
"heapDeltaBytes": 4918056,
"heapUsedBytes": 74818632,
"domNodes": 98,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.460999999999998,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142844,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 503.84699999995064,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.691,
"layouts": 76,
"layoutDurationMs": 14.674,
"taskDurationMs": 467.362,
"heapDeltaBytes": -4871352,
"heapUsedBytes": 41183516,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 224.223,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903224,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 502.0590000000311,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.7020000000000001,
"layouts": 76,
"layoutDurationMs": 15.001000000000001,
"taskDurationMs": 456.741,
"heapDeltaBytes": -5067180,
"heapUsedBytes": 40883708,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 213.71699999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 544.7260000000824,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.76,
"layouts": 76,
"layoutDurationMs": 14.58,
"taskDurationMs": 506.864,
"heapDeltaBytes": -176968,
"heapUsedBytes": 101196876,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 197.79,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 613.8320000000022,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.867,
"layouts": 76,
"layoutDurationMs": 16.258000000000003,
"taskDurationMs": 572.5020000000001,
"heapDeltaBytes": 232176,
"heapUsedBytes": 101411476,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 240.61599999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.591666666666672,
"p95FrameDurationMs": 33.30000000000018
}
]
}🔬 E2E Coverage: 🟡 58.1% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3294 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3cdf4844b368eb1f77500177c65cca240fa82282
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (568)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## benjcooley/node-api-wiring #16792 +/- ##
==============================================================
+ Coverage 87.86% 87.87% +0.01%
==============================================================
Files 3075 3076 +1
Lines 168901 168905 +4
Branches 43444 43436 -8
==============================================================
+ Hits 148402 148431 +29
+ Misses 19686 19661 -25
Partials 813 813
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 20 files with indirect coverage changes 🚀 New features to boost your workflow:
|
DrJKL
left a comment
There was a problem hiding this comment.
Transferred both generator findings from superseded #16691 to the documentation/generator PR; both remain reproducible on the current stacked head.
Transfer map and revalidation
Revalidated against #16792 head 0fa1ca8c31eb81209ad056fe54d4cbc3f2dd5afb, whose base is #16791.
The generated .d.ts still compiles only as a self-contained declaration and does not declare or test the documented /comfy/api/v2.js value import. The API-member generator still regex-scans every interface rather than traversing the exported Comfy type graph; the generated allowlist demonstrably contains private implementation names including Record, idMethods, identityProps, methods, and readonlyHint.
Both comments preserve the original audit's evidence, consequences, suggested architecture, and executable verification requirements.
| }) | ||
| } | ||
|
|
||
| export function buildApiDts(directory = DIR) { |
There was a problem hiding this comment.
[P1] Emit a declaration for the runtime /comfy/api/v2.js module and its comfy export. The generated contract cannot type-check the import shown in its own header.
Evidence and failure sequence
buildApiDts() concatenates exported interfaces and type aliases from src/platform/nodeApi, but emits no ambient module declaration for /comfy/api/v2.js and no comfy: Comfy value export. The generated header documents import { comfy } from '/comfy/api/v2.js', yet compiling a consumer containing that exact statement still produces TS2307: Cannot find module '/comfy/api/v2.js' or its corresponding type declarations.
The current apiDts.test.ts compiles only the declaration file as /comfy-api.d.ts. That proves its copied declarations are internally self-consistent, but never creates a consumer source file or asks TypeScript to resolve the documented runtime module specifier.
Failure sequence: a custom-node author installs the generated .d.ts, copies the documented import, and receives no module or exported value type despite the runtime file existing.
Why this matters
The declaration artifact is specifically intended to be the compile-time contract for converted packs. If it cannot type the only supported import path, editors and conversion checks either fail outright or fall back to untyped JavaScript at the exact public boundary this generator is meant to stabilize.
Suggested direction and verification
Emit an ambient declaration matching the runtime specifier and value, for example a module declaration for /comfy/api/v2.js that exports const comfy: Comfy while keeping supporting public types reachable. Ensure the form works with the actual module-resolution/compiler settings used by pack tooling.
Extend the test host with a consumer .ts file containing the exact documented import and at least one typed API access. Compile the declaration plus consumer and require zero diagnostics. Add a negative member access to prove comfy is typed as Comfy, not any or unknown.
There was a problem hiding this comment.
Fixed. The contract now ends with an ambient declaration for the module packs actually import. It emits its declarations without export so the file stays a global script — inside a module the same block means augmentation, and augmenting a module with no other declaration is an error — and the specifier is matched by a wildcard because an ambient name may not be a rooted path. A new test compiles a pack that writes import { comfy } from '/comfy/api/v2.js' and asserts an invented member is the sole diagnostic.
|
|
||
| const DIR = new URL('../../src/platform/nodeApi/', import.meta.url).pathname | ||
|
|
||
| export function deriveApiMembers(dir = DIR) { |
There was a problem hiding this comment.
[P2] Derive the conformance surface from the exported Comfy type graph, not every interface-shaped block. The generated allowlist currently publishes private implementation members.
Evidence and failure sequence
deriveApiMembers() regex-scans every TypeScript file and deliberately matches both exported and unexported interfaces. It then treats every first-token member line as public. This is not reachability analysis; it has no knowledge of which types are reachable from Comfy.
The generated apiSurface.ts demonstrates the leak: it includes Record, methods, idMethods, identityProps, and readonlyHint. Those names come from internal HandleSpec/property-spec machinery in closedProxy.ts, not from the pack-facing Comfy contract. A converted extension using one of those names can therefore pass the conformance member check even though no public handle exposes it.
The regex is also structurally unable to model intersections, aliases, inherited interfaces, mapped types, overload reachability, computed names, or syntax formatting changes. The comment acknowledges earlier false negatives and broadens the scan, but broadening trades them for false positives rather than establishing an authoritative surface.
Why this matters
The conformance allowlist is a trust boundary for generated/converted extension code. Approving private names weakens its ability to catch unsupported APIs and makes changes to unrelated internal interfaces alter the published surface. Maintaining a second, regex-derived notion of public API also allows the declaration generator and conformance generator to drift.
Suggested direction and verification
Use one TypeScript compiler/AST traversal rooted at the exported Comfy interface (and explicitly exported public entry types), recursively following reachable property, parameter, and return types. Exclude declarations not reachable from those roots. Share that public-type discovery with gen_api_dts.mjs so declarations and conformance derive from the same authority.
Add negative assertions that internal HandleSpec members are absent and positive assertions for members reached through nested return types, generics, aliases, and inherited interfaces. Regenerate apiSurface.ts and inspect the diff for removed private names.
There was a problem hiding this comment.
Fixed. The generator walks the type graph from the exported Comfy root instead of regex-scanning every interface in the folder, following heritage clauses so inherited members like isDeleted survive. All eight names you listed are gone. I checked each of the 21 names the old scanner emitted and the new one drops: selector/apply belong to the internal Registration, the snake_case fields to RawNodeDef (the backend wire shape, converted before anything published sees it), listener to internal Subscription types, namedSlotsAvailable to a parameter-only ResolveOptions, and the rest — theme, container, button, config, callback — were never interface members at all; the line regex had been matching function parameters.
DrJKL
left a comment
There was a problem hiding this comment.
Request changes: the extension-author package still has broken authoritative commands, contradictory versioning, an unusable local E2E path, and incomplete public guidance.
Independent review scope and verification
I independently reviewed exact range 77cdd03ab17d9794483aa5d986ee3c7ccd9830a4..0fa1ca8c31eb81209ad056fe54d4cbc3f2dd5afb before reading GitHub discussion. Focused declaration, surface, capability, runtime, and async-resolution tests passed. Typecheck:browser, knip, format, syntax checks, and diff checks passed. Consumer compilation failed on the exact documented import as described in the existing comment; the documented generator command failed; a space-path run exited 0 with zero bytes; and the documented local targeted Playwright path failed both specs.
After freezing the pass, I omitted the two findings already covered by existing comments: the missing runtime module/value declaration and the self-validating private-member API_MEMBERS artifact. This review adds 10 net-new comments and is submitted as COMMENT, not a request-changes event.
| The exact TypeScript surface is generated from `src/platform/nodeApi/`: | ||
|
|
||
| ```sh | ||
| node scripts/magic-patch/gen_api_dts.mjs > comfy-api.d.ts |
There was a problem hiding this comment.
P1 — The authoritative declaration-generation command points to a file that does not exist.
Evidence, impact, and suggested direction
The generator lives at scripts/node-api/gen_api_dts.mjs, but this guide and registration.md direct authors to scripts/magic-patch/gen_api_dts.mjs; source comments similarly advertise the wrong surface-generator path. Running this exact command from the repository root exited 1 with “Cannot find module” and produced 0 bytes.
Correct every command and source comment, then regression-test the exact documented snippets from the repository root so the declared source of truth cannot be dead on first use.
There was a problem hiding this comment.
Fixed. The command pointed at scripts/magic-patch/, which does not exist — the generators live in scripts/node-api/. Corrected in README.md, reference.md, registration.md and the header of apiSurface.ts, which carried the same stale path.
| }) | ||
| ``` | ||
|
|
||
| The module path is `/comfy/api/v2.js`; the API contract currently reports |
There was a problem hiding this comment.
P1 — The documentation advertises API major 1 even though the runtime supports only major 2.
Evidence, impact, and suggested direction
This says the contract reports 1.0, and registration.md demonstrates major 1. Runtime NODE_API_VERSION is 2.0, SUPPORTED_MAJORS contains only 2, and every runnable example pins 2; the focused runtime suite confirms forMajor(1) throws.
An author following the prose fails during module initialization. Generate or check documented version values from NODE_API_VERSION/SUPPORTED_MAJORS, and regression-test every version snippet.
There was a problem hiding this comment.
Fixed. The runtime reports 2.0 (NODE_API_VERSION, with SUPPORTED_MAJORS = [2]), so the README's comfy.version === '1.0' was simply wrong. Corrected.
There was a problem hiding this comment.
Fixed. All version examples now agree with the runtime contract: version 2.0, major 2. The newly reported stale values in registration.md are corrected as well.
| ``` | ||
|
|
||
| The command mounts `tools/devtools` and starts ComfyUI at `localhost:8188`. | ||
| The command mounts `tools/devtools`, the published node API example packs under |
There was a problem hiding this comment.
P1 — This documented local E2E workflow mounts the examples but the Vite frontend suppresses every example extension.
Evidence, impact, and suggested direction
The launcher mounts all four How-To packs and this guide says to run Vite plus test:browser:local, but Vite unconditionally answers /api/extensions with []. Live checks showed Vite returning an empty list while the backend listed every module. After warm-up, the exact targeted command failed both new specs: the How-To menu lacked “Resume,” and the stable demo exported unresolved nodes.
Proxy the dynamic extension list and extension files through Vite, or run this documented path against a current built frontend served by the backend. Add a regression that executes the exact three-terminal workflow described here.
There was a problem hiding this comment.
Fixed, and I hit this myself before reading the thread. The dev server answers /api/extensions with an empty list, so port 5173 loads no pack at all and a pack test there passes vacuously or fails for the wrong reason. scripts/start-comfyui-e2e.sh now takes COMFYUI_FRONTEND_ROOT and passes --front-end-root, and the README documents building dist, serving it from the container, and pointing Playwright at 8188. It also warns that .env pins PLAYWRIGHT_SETUP_API_URL to another port — without overriding it every test dies in fixture setup with a 405 that reads like a product failure. I ran both nodeApi specs through the documented commands to confirm they work.
There was a problem hiding this comment.
Fixed and verified end to end. start-comfyui-e2e.sh accepts COMFYUI_FRONTEND_ROOT and passes --front-end-root; the README documents building this checkout, serving that build from the backend with the example packs mounted, and overriding the setup API URL. Both Node API specs passed through that workflow.
|
|
||
| ### Domain roots | ||
|
|
||
| | Member | Type | Guide | |
There was a problem hiding this comment.
P2 — The promised navigable reference omits reachable public roots, methods, callbacks, and projection types.
Evidence, impact, and suggested direction
This domain table omits Comfy.system/SystemHandle.monitor(); later command and workflow sections omit playSound() and documentId(); builder/definition sections omit onPromptSerialize, PromptInputProjection, and PromptInputProjector. The generated capability block names some omissions but gives no usage route.
Document every reachable root, member, callback, and public type. Prefer a compiler-derived public-member index checked against reference entries so navigability does not depend on a manually maintained partial list.
There was a problem hiding this comment.
Not addressed in this pass. The reference is generated from the surface and its capability list is checked against the code by capabilityDoc.test.ts, but you are right that the prose navigation does not enumerate every reachable root, callback and projection. That is a docs completeness gap rather than a drift risk, and I would rather land it as its own change than hand-edit a generated file late in review. Happy to file it if you want it tracked.
There was a problem hiding this comment.
Fixed. The reference now includes the system root, monitoring, onPromptSerialize, projection types, commands.playSound, workflow.documentId, and the missing reachable collection/handle names. A compiler-derived test walks every type reachable from Comfy and requires each public type name in the reference.
| - `self.input(nameOrIndex)` creates the only reference a resolver may forward. | ||
|
|
||
| Resolution follows chains to a physical backend output, literal, or omission, | ||
| with cycle detection. A resolver must be pure and synchronous. It cannot edit |
There was a problem hiding this comment.
P2 — The guide forbids async resolvers even though the runtime deliberately supports and awaits them.
Evidence, impact, and suggested direction
Resolver and supplier types accept promises, the prompt path awaits them, and focused async tests pass. Only synchronous editor inspection warns and treats a promise as unresolved. This guide, how-to.md, and demo-nodes.md instead state that resolvers must be synchronous.
Document the supported async prompt behavior and the different synchronous inspection semantics, then contract-check that prose against the async resolution tests.
There was a problem hiding this comment.
Not addressed. I want to check the specific wording against the runtime before changing it — resolution now runs resolvers concurrently with an AbortSignal and a deadline, so if the guide forbids async resolvers outright it is wrong, but I would rather quote the offending sentence back to you than rewrite the section on my own reading. Point me at it and I will fix it in this PR.
There was a problem hiding this comment.
Fixed. The guide now states the actual split contract: async resolvers are awaited concurrently on the prompt path with cancellation/deadline support, while synchronous editor inspection treats a pending promise as unresolved. A prose-consistency test pins that distinction.
| }) | ||
| } | ||
|
|
||
| export function buildApiDts(directory = DIR) { |
There was a problem hiding this comment.
P2 — Declaration generation exposes host-private plumbing and types impossible root mutations as valid.
Evidence, impact, and suggested direction
This scrapes every exported implementation interface/type, publishing host-only PropSpec, HandleSpec, HandleToken, NodeCollections, movement sources, and ResolveOptions; the reference then documents their private fields. It also promotes implementation diagnostics such as graph.cacheSize. Separately, after adding the missing runtime value declaration, strict TypeScript accepted comfy.queue = comfy.queue because root members are not readonly even though runtime freezes the root.
Define an explicit public facade rooted at Comfy, exclude diagnostics and provider plumbing, and mark root members readonly. Add negative compile tests for private names and root assignment.
There was a problem hiding this comment.
Not addressed. Same reason as the reference gap: narrowing what the .d.ts exposes is a change to the generated contract, and the surface generator just changed shape in this PR. I would rather do it deliberately with its own test than fold it into this round.
There was a problem hiding this comment.
Fixed. Declaration generation is rooted at the exported Comfy facade, root members are readonly, host-only provider/plumbing types are excluded, and compile tests reject both private names and root assignment.
| ], | ||
| execution: 'frontend', | ||
| onCreated(node) { | ||
| node.widgets.get('ping')?.on('activate', async () => { |
There was a problem hiding this comment.
P2 — The activation examples teach unhandled-rejection and silent-failure patterns at a synchronous listener boundary.
Evidence, impact, and suggested direction
Several listeners are declared async or discard command promises without a catch. This ping path parses JSON before safe error handling; the event POST never checks response.ok; storage and command actions also have no failure path. The public listener contract returns void and the bridge invokes listeners synchronously without awaiting or catching them, so network, JSON, storage, or command failures become unhandled rejections or leave stale UI.
Use named async actions invoked as void action().catch(...), validate status and response shape before success, and expose a clear failure state. Add E2E assertions for failed response, malformed JSON, and rejected command/storage routes.
There was a problem hiding this comment.
Not addressed. Agreed in principle — the example should model handling the rejection rather than teaching a fire-and-forget listener, since these packs are what conversions copy from. Worth doing; I did not want to churn the examples in the same push as the generator and doc fixes.
There was a problem hiding this comment.
Fixed. Synchronous listeners invoke named async actions through a shared rejection handler; backend requests validate status and payload shape; storage and command failures surface explicit status. E2E covers HTTP failure, malformed JSON, storage rejection, backend-event rejection, and command rejection.
| amount?.setValue(Math.max(0, Math.min(1, x / width))) | ||
| } | ||
| }) | ||
| canvasCleanups.set( |
There was a problem hiding this comment.
P2 — Canvas-widget cleanup is keyed only by graph-local node ID.
Evidence, impact, and suggested direction
The API contract warns that local IDs repeat across root and subgraph definitions. Two CanvasMeters with the same local ID overwrite this map entry; removing one can unsubscribe the other and leak the first subscription. Other examples already use graphId:nodeId composite identity.
Key both insertion and removal by node.graphId plus node.id, and regress with duplicate local IDs in two graph scopes.
There was a problem hiding this comment.
Not addressed. Real, and the same class of bug as the handle-cache keying I fixed in #16790: a graph-local node id collides across subgraphs, so cleanup can key to the wrong node. The example should key by graphId and node id together, which is what its own stateKey helper already does elsewhere in the pack.
There was a problem hiding this comment.
Fixed. Canvas cleanup uses the same graphId:nodeId composite identity for registration and removal, preventing equal local IDs in different graph scopes from colliding.
| }) | ||
| expect(prompt['14'].inputs.text).toMatch(/^rendered-\d{4}-\d{2}-\d{2}$/) | ||
|
|
||
| await comfyPage.command.executeCommand('Comfy.QueuePrompt') |
There was a problem hiding this comment.
P2 — The claimed real backend run can pass even when result handling is broken.
Evidence, impact, and suggested direction
Queue completion here means submission, not backend execution. After invoking the command, the test checks unrelated widget, route, and graph actions but never asserts that HowToTextOutput's executed value or badge changed from “not run.” Disabling or throwing in the backend run path would not be detected by this assertion sequence.
Poll and assert node 3's executed result/badge, and verify with a temporary mutant that breaking the backend result path makes this spec fail.
There was a problem hiding this comment.
Not addressed. Fair — the assertion can pass without proving the result path. Worth strengthening, and the local e2e setup now documented in this PR makes it cheap to verify a stronger assertion actually holds against a real backend.
There was a problem hiding this comment.
Fixed. The E2E test polls the real per-node execution output and requires the backend result text, so queue submission alone cannot satisfy it. This passed against the mounted example corpus and real backend.
| ) | ||
| } | ||
|
|
||
| if (import.meta.url === `file://${process.argv[1]}`) { |
There was a problem hiding this comment.
P2 — The generators silently emit nothing when the checkout path contains spaces.
Evidence, impact, and suggested direction
Both generators derive paths from URL .pathname and compare encoded import.meta.url with an unencoded file:// process path. Running a copied generator/source under /tmp/node api review exited 0 with zero bytes, so an author can believe generation succeeded and commit an empty contract.
Use fileURLToPath(import.meta.url) plus resolved filesystem paths for both directory and entry-point checks. Run generator tests from a temporary path containing spaces and assert nonempty output.
There was a problem hiding this comment.
Fixed. import.meta.url percent-encodes a space while process.argv[1] does not, so in a checkout whose path contains one the entry guard was false and both generators exited 0 having written nothing. They now compare against pathToFileURL(process.argv[1]).href. Verified from a directory with a space in its name: the old comparison is false there, the new one true.
There was a problem hiding this comment.
Correction to my earlier incomplete reply: the entry guard alone was insufficient. All three generators now use fileURLToPath for filesystem paths, and the test copies the scripts and source into a temporary checkout whose path contains spaces, executes both generators there, and requires nonempty declaration and surface output.
0fa1ca8 to
81ad16d
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Both generator findings are fixed. The member list now walks the type graph from The walk follows heritage clauses too — without that it dropped The contract now declares the entry point. It named The new test compiles a pack that writes |
81ad16d to
951744b
Compare
951744b to
2f05c9b
Compare
92ccc3b to
fc97c98
Compare
fc97c98 to
9a5bd8c
Compare
There was a problem hiding this comment.
Verdict: request changes. The renderer-switch helper is fixed; the conversion recipe still loses saved widget values and changes prompt inputs.
Reviewed af010f9 against its wiring base. The two-file delta reads the live renderer setting and pins the extension-provenance fixture's pack inventory. The earlier generator fixes remain present. One P1 finding blocks this revision:
- The per-widget suppression recipe removes a saved workflow cell and restores a previously omitted prompt input. A fresh real-runtime probe reproduces both changes.
Existing findings still open or contested
- P1, confirmed: serialization recipe. Real
LGraphNode.serialize()andgraphToPrompt()produce saved cells["derived",17]and prompt{"following":17}for the legacy widget. The documented conversion produces[17]and{"text":"derived","following":17}. Using the prompt-only serialization option restores the original results. Correct the conversion skill and its widget reference together. - P2, confirmed: lifecycle registrations. The table still passes node/result values to methods that take listener functions. The builder stores the first argument and later calls it. Show callback registration syntax.
- P2, confirmed: incoming getters.
setOption('values', options.values)evaluates the incoming getter immediately. Preserving untouched existing descriptors does not preserve that accessor. Use a function-valued combo option for a live list. - P2, confirmed: KSampler notification. The tutorial still attaches
onExecutedto KSampler. Its ordinary backend result contains no UI output, so the backend does not emit the event required by the exercise. Demonstrate UI-result delivery with PreviewImage. - P2, confirmed: global declaration collision. A fresh strict TypeScript consumer compiles normally, then fails with TS2345 when an unrelated global
Pointaddsz. Keep the supporting declarations inside the ambient module and regenerate. - P3, confirmed: activation helpers. The three one-use helpers still split a single Ctrl/Cmd+Enter handler across the module. Inline the condition and callback at their sole registration.
- P3, confirmed: how-to payload scope.
HOW_TO_TEXTstill belongs to one scenario and should live in that test. - P3, confirmed: named phases. The two long how-to scenarios still have no
test.stepblocks. Group their existing actions and assertions without adding more cases. - P3, confirmed: setup ownership. Initial workflow loads remain in the ordinary scenario bodies. Scope the shared hook to the workflow-based cases; exclude storage and the route-interception case.
- P3, contested: canvas reset. The current guide no longer requires this reset and
CanvasHelper.resetViewno longer exists. Withdraw this suggestion rather than recreate the removed helper. - P3, confirmed: reload helper. Both raw reload/readiness pairs still bypass
workflow.reloadAndWaitForApp(), including its Vue readiness behavior. - P3, confirmed: demo payload scope.
DEMO_TEXTalso has one owning test. - Structure patch: contested as an exact replacement. Its constants, steps and hook advice remain applicable, but it predates the renderer loop and storage case and includes the removed reset method. Adapt the valid parts.
- Reload patch: confirmed and still unapplied. The referenced helper exists.
- Demo setup patch: confirmed and still unapplied. Its local payload and setup ownership apply to the current test.
- P2, partially addressed: async resolution. The prohibition on async resolvers is fixed, but the primary execution/graph/slot guides still equate synchronous inspection with awaited prompt results. The new inline finding identifies the remaining distinction.
The unanswered September findings above remain open on code evidence. The earlier author reply about both generator findings concerns module publication and private-member discovery; those fixes are present and do not settle the later global-name collision.
Earlier findings addressed in the current history
The following fixes are present at the reviewed head. The head links identify a checked commit containing each fix, not its original pre-rebase introduction.
- Missing runtime declaration: the ambient runtime module exports typed
comfy; the ordinary strict consumer compiles. - Private allowlist members: traversal starts at Comfy and follows reachable declarations and heritage. All 378 generated members match the committed output; the disputed private members are absent.
- Generator command: the guide names the existing generator.
- API major version: the examples now require major 2.
- Mounted-pack E2E setup: the instructions use built assets and the backend frontend root, with both Playwright URL overrides.
- Reference omissions: every specifically reported root, hook and type is documented, including system/monitor, prompt serialization, projection types, playSound and documentId.
- Private declarations and mutable roots: the generator filters by reachability and the public roots are readonly.
- Async action errors: shared rejection handling reports failures; HTTP and parsed response checks precede success.
- Canvas cleanup identity: insertion/removal both use graph plus node ID. The callback probe preserves independent cleanup for equal local IDs in different graphs.
- Backend completion assertion: the spec polls actual output from HowToTextOutput rather than treating queue submission as completion.
- Spaces in checkout paths: generators use filesystem paths and canonical entry checks. The production fix is present; the new inline test finding concerns whether its regression detects a no-op CLI.
Each of these original threads already has an author reply. No additional addressed-thread reply is needed. No thread was resolved.
The renderer-selection finding from the unposted draft is also addressed in af010f9. getPosition() now reads Comfy.VueNodes.Enabled on every call rather than using the initial test tag. The provenance setup registers its route before the lazy comfyPage fixture boots; the nested imported-app scenario can still override that route.
Checked and cleared
- Existing storage prefixes compose correctly with returned logical names; the real adapter passed set/list/get/remove with an in-memory transport. Secure storage guarantees remain conditional on the optional host.
- The notes renderer owns its subscriptions and teardown. Hidden widgets intentionally retain serialization unless the separate serialization option changes.
- Settings redeclaration preserves values; unknown commands reject; removed chrome contributions reject updates; slot reordering updates endpoints without recreating links.
- The network parsing helpers and shared async action runner own boundary validation and repeated rejection handling. They are not redundant one-use aliases. Independent example packs need not share their definitions or private state maps.
- The generator units have separate outputs and share reachability. The finding is their exclusion from TypeScript checking, not a demand for another abstraction or dependency.
- The example import-lint exception matches browser execution of the published URL. Generated-output exclusions do not establish that Node tooling was typechecked.
- The rejected-command E2E test injects a failure into the real pack handler; it does not substitute synthetic UI for product behavior. Renderer-dependent widget cases remain useful. Only the direct storage API round trip lacks a renderer-dependent assertion.
- The selector parser accepts the escaped
loras.$noticeattribute. Escaping is not the cause of the renderer-switch failure. - An author's claim that the CLI regression proves emission is covered by the existing falsifier requirement. It is not an unmatched owner request and does not justify a new skill-gap report.
Verification, overlap and limits
Six deep-review shards covered conversion guidance, service/how-to guidance, other guides/reference, examples/generators/setup, maintainability, and tests. No lane was skipped. The final two-file delta was reviewed directly. Generated declarations were compiler-checked and compared with generated output rather than manually reread as independent prose. The serialization probe ran again at this head; other probe results apply to unchanged code from the preceding draft. No combined-branch merge test ran.
- Fresh serialization probe: one expected failing Vitest case, two failed equivalence assertions. Legacy and corrected-control results matched. The probe executes the real workflow serializer, prompt builder and public widget construction.
- Strict TypeScript probe: zero ordinary-consumer diagnostics; one TS2345 after adding an unrelated global Point member.
- Actual result adapter: legacy
{value:[42]}displays42, while the converted drawing recipe displays an empty string. - Exact recipe/adapter probes verified the missing color subscription, native rejection of the documented relative route, and forwarded-supply conversion failure with a passing direct-output control. These use small boundary doubles, not a full browser/backend run.
- Current-head replacement CI reports successful unit, typecheck, lint, Fallow and E2E status checks. Earlier runs at this SHA include failed gates and cancelled jobs; those results are retained in the snapshot rather than described as an all-green history. The earlier downstream renderer-switch failures no longer support an open finding against this helper.
- Current-head Playwright discovery found 15 cases across the node-API and provenance specs. No backend or local E2E suite was started. Tracked files remain unchanged. Aggregate CI success is not evidence that every copied documentation recipe executes correctly.
- The native file-drop finding follows the browser's protected drag-data contract and actual callback/host dispatch. No OS drag ran. The restrictive-permission mount finding follows the container UID, direct mounts and the previous staging fix; no container was started.
- Refreshed all unresolved threads and open-PR overlaps. Inspected relevant hunks from #17759, #23164, #22024, #18398, #17194, #12142, #12144, #17507, #17516 and #18448. The downstream widget-commit fix does not repair these conversion recipes. The optional secure broker is absent from this reviewed tree, so its enforcement was not verified.
- The retread check found no demonstrated regression of an earlier fixed finding, repeated disposition flips, or qualifying sequence of new defects requiring domain escalation. No substantiated unmatched owner request was found.
- The earlier overlap pass also inspected widget serialization/restoration and layout hunks from #9230, #10286, #14262, #20880, #20055, #20105 and #23143. None changes the recipe's distinction between saved-cell suppression and prompt-only omission.
- This round's overlap refresh found changed heads for #16790, #16791 and #23167. Their deltas concern a type export, an unchanged wiring tree, and theme tooling entries. Expanded fixture-dependency coverage also examined #15065, #17243, #17265, #17356, #17762, #17870, #20509, #22949 and #23171. Their network mocks, optional live-network configuration, import order and billing flags do not supersede the provenance inventory route or live renderer lookup. All 27 unresolved threads and their replies match the preceding snapshot; every one has a disposition above.
| So **delete the override, do not translate it.** Address widgets by name — that | ||
| is native — and let core serialize the positional array as it already does. The | ||
| pack's serialize hook largely disappears rather than being ported. |
There was a problem hiding this comment.
[P2] Separate format migration from the byte-identical conversion requirement
The skill requires byte-identical workflow output, but this instruction replaces a name-keyed object with a positional array. Reading old workflows in onConfigured does not preserve the outgoing format. This needs an explicit migration decision, rather than a claim that both requirements can be met.
| So **delete the override, do not translate it.** Address widgets by name — that | |
| is native — and let core serialize the positional array as it already does. The | |
| pack's serialize hook largely disappears rather than being ported. | |
| Replacing a dict-shaped `widgets_values` with the core positional array changes | |
| the saved format and cannot pass the byte-identical conversion requirement. | |
| Escalate this case for an explicit format-migration decision before converting it. |
| stateFor(node).surface = surface | ||
| }) | ||
| b.onExecuted((node, result) => { | ||
| stateFor(node).value = String(result.text[0] ?? '') |
There was a problem hiding this comment.
[P2] Preserve the backend result key in this conversion
The before example reads value[0], but toExecutionResult fills text only from raw.text. Executing the actual adapter with {value:[42]} changes the displayed result from 42 to an empty string. Read the original field through raw.
| stateFor(node).value = String(result.text[0] ?? '') | |
| const values = result.raw.value | |
| stateFor(node).value = Array.isArray(values) ? String(values[0] ?? '') : '' |
| test('persists public storage across a page reload', async ({ | ||
| comfyPage | ||
| }) => { |
There was a problem hiding this comment.
[P2] Run the renderer-independent storage round trip once
This case directly calls the same storage adapter and reloads the page in both renderer variants. It never renders or interacts with a node, so the second boot/reload has no distinct renderer failure to detect. Move this case outside the renderer loop, preserving the real persistence check. This relocation crosses the surrounding describe block.
| `InputSlotHandle.resolvedSource()` exposes the same final result for editor | ||
| behavior without changing topology. |
There was a problem hiding this comment.
[P2] Qualify synchronous inspection after documenting async resolution
The prompt builder awaits async resolvers and suppliers. resolvedSource() and resolvedSupplies() instead call synchronous paths: a promise-returning resolver is unresolved, and an async supplier contributes no edge. The original async prohibition is fixed, but this equivalence claim remains wrong. Apply the same qualification to the supply-conversion paragraph and graph/slot guides; those separated edits require coordinated prose changes.
| `InputSlotHandle.resolvedSource()` exposes the same final result for editor | |
| behavior without changing topology. | |
| `InputSlotHandle.resolvedSource()` performs synchronous editor inspection. It | |
| cannot await resolver promises; the prompt path awaits them instead. |
| broadcaster.outputs | ||
| .at(edge.from.output) | ||
| ?.connectTo(edge.to.nodeId, { index: edge.to.input }) |
There was a problem hiding this comment.
[P2] Connect the resolved source rather than the supply-rule owner
forwardInput can resolve a supplier to an upstream output. An input-only broadcaster has no output to connect here; a broadcaster with another output can create the wrong link. The exact snippet creates no link for the existing supported relay shape, while a direct-output control succeeds.
| broadcaster.outputs | |
| .at(edge.from.output) | |
| ?.connectTo(edge.to.nodeId, { index: edge.to.input }) | |
| comfy.graph.node(edge.from.nodeId)?.outputs | |
| .at(edge.from.output) | |
| ?.connectTo(edge.to.nodeId, { index: edge.to.input }) |
| /** | ||
| * Prose that reads as a call but names no member. | ||
| * | ||
| * `resolve` and `mount` are contract keys the pack implements rather than | ||
| * members it calls; the rest are English. | ||
| */ |
There was a problem hiding this comment.
[P3] Nit: remove implementation narration
This block is implementation explanation or change history, rather than a machine directive or a short exported API contract. The repository requires that prose outside source/test comments. Keep any necessary history in the PR description; the function, config value or assertion below states the current behavior.
| /** | |
| * Prose that reads as a call but names no member. | |
| * | |
| * `resolve` and `mount` are contract keys the pack implements rather than | |
| * members it calls; the rest are English. | |
| */ |
| */ | ||
| const NOT_MEMBERS = new Set(['delete', 'punt', 'remove', 'the', 'it']) | ||
|
|
||
| /** The middle column of every mapping row, which is where destinations live. */ |
There was a problem hiding this comment.
[P3] Nit: remove implementation narration
This block is implementation explanation or change history, rather than a machine directive or a short exported API contract. The repository requires that prose outside source/test comments. Keep any necessary history in the PR description; the function, config value or assertion below states the current behavior.
| /** The middle column of every mapping row, which is where destinations live. */ |
| .map((cells) => cells[2]) | ||
| } | ||
|
|
||
| /** Members named as calls (`foo(`) or accesses (`.foo`) inside code spans. */ |
There was a problem hiding this comment.
[P3] Nit: remove implementation narration
This block is implementation explanation or change history, rather than a machine directive or a short exported API contract. The repository requires that prose outside source/test comments. Keep any necessary history in the PR description; the function, config value or assertion below states the current behavior.
| /** Members named as calls (`foo(`) or accesses (`.foo`) inside code spans. */ |
| function membersIn(cell: string): string[] { | ||
| const code = [...cell.matchAll(/`([^`]+)`/g)] | ||
| .map((m) => m[1]) | ||
| // A file path's extension is not a member access. |
There was a problem hiding this comment.
[P3] Nit: remove implementation narration
This block is implementation explanation or change history, rather than a machine directive or a short exported API contract. The repository requires that prose outside source/test comments. Keep any necessary history in the PR description; the function, config value or assertion below states the current behavior.
| // A file path's extension is not a member access. |
| // Without this, a rename that breaks the parse would make every assertion | ||
| // below vacuously true — the check would report success having read nothing. |
There was a problem hiding this comment.
[P3] Nit: remove implementation narration
This block is implementation explanation or change history, rather than a machine directive or a short exported API contract. The repository requires that prose outside source/test comments. Keep any necessary history in the PR description; the function, config value or assertion below states the current behavior.
| // Without this, a rename that breaks the parse would make every assertion | |
| // below vacuously true — the check would report success having read nothing. |
The guide, the how-to table and the conversion skill said a legacy serializeValue override that returns nothing becomes serialize: false. That flag stops the value being saved and still sends it, the reverse of the override. The replacement is options.serialize: false. The generated declarations carry the corrected doc comment. Fixing the previous version before the refactor. Review thread: #16792 (comment)
|
Fixing the previous version before the refactor.
|
A handle belongs to the workflow it came from. Loading another workflow, including by switching tabs, retires it; undo and redo keep it. Fixing the previous version before the refactor.
|
Fixing the previous version before the refactor.
|
…rsions Regenerates the declarations and the surface list for the new members, and says in the guides that group handles report isDeleted and follow their group through undo, that select() and centerOn() skip a handle from another graph, that a subgraph's boundary links are listed, and how to test the API version. Fixing the previous version before the refactor.
|
Fixing the previous version before the refactor.
|
|
Fixing the previous version before the refactor. Updated this branch through
The compiler tests reproduce the old global Point collision and recipe failures. The generation test now starts with deliberately stale output. Final combined validation: 1,260 tests passed across 46 files, with two existing skips. Normal hooks passed. Generator/tooling relocation and remaining browser-harness cleanup are still separate follow-ups. |
During dragover a browser hides the dragged files, so the example's check of their names always failed and the node never offered itself as a drop target. It now accepts any file item there and still checks for .txt when the file is dropped. Fixing the previous version before the refactor.
The four example packs were mounted straight from the checkout, so a checkout with restrictive permissions left them unreadable by the container user. They are now copied into the launcher's temporary staging area, made readable and checked, as devtools already is. Fixing the previous version before the refactor.
Storage does not depend on the renderer, so the round trip no longer runs once per renderer. Its saved key is now removed in a finally, so a failed assertion cannot leave it on the shared backend user. Fixing the previous version before the refactor.
The launcher test's fixture had no example packs, so it failed once the launcher began staging them. The fixture now has the four packs with restrictive permissions, and the test checks that every custom-node mount is a readable staged copy with the pack's own content. Fixing the previous version before the refactor.
Regenerates the declarations and the surface list, and describes queryNodes, panBy, setResizable, onSelectionChanged, the connection event's slot name, mountViewportPanel and registerImporter. The guide also says an extension may register before or after the type it matches.
|
documentId() is now the id of the open document's editing session. The reference describes workflow.current(), the document handle and the four session events, and says how the session's life differs from a node handle's. The guide shows keeping per-document state and releasing it when the document closes.
|
Summary
Publishes the V2 JavaScript declaration, reference and runnable native custom-node examples, with checks that keep the documented surface aligned with runtime behavior. Documents availability and provider limits.
Rebased onto the refreshed wiring branch; the generated public declaration is unchanged. Browser helpers now follow the live renderer during switching, and the extension-provenance fixture pins its script inventory so installed examples do not alter its screenshot. The API remains preview.
Verification
Full stack: 964 unit checks passed with two existing skips. Declaration generation/conformance, published-type consumer, app/browser typechecks, build, lint, formatting and normal push hooks passed. The published examples, storage persistence, failure handling and COMBO-to-legacy execution passed 11 local non-sandboxed browser checks across canvas/Vue against V2.1 Core. Ten V2.1 HTTP/WebSocket checks also passed. Independent rebase review found no remaining blocker.
Two additional local renderer-switch checks passed with empty and populated dynamic groups. Replacement Linux CI is pending for the existing notice/screenshot cases; no snapshot was changed.