Repository navigation
chore(agent): remove temporary CRDT status strip - #16759
Conversation
The ungated CRDT status strip in AgentPanelRoot (data-testid agent-crdt-status) was a stopgap for bug reporting. The CRDT debug instrument (#16365, CrdtDevPanel in AgentPanel's #instrument slot) now carries the same connection/document/update information behind the crdtDebug gate, so the strip and its four agent.crdt* locale keys are removed from all 15 locales. RUN-CLOUD-E2E.md verify step points at the instrument instead.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1916 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.68 MB gzip 🟢 -1.33 kBDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 20 added / 20 removed / 16 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • 🟢 -2.98 kBBundles that do not match a named category
Status: 93 added / 93 removed / 203 unchanged ⚡ Performance
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (17)
💤 Files with no reviewable changes (16)
Included review availability: Your plan provides up to 10 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe agent panel no longer renders the inline CRDT status banner. CRDT verification now uses the debug instrument. Obsolete CRDT status translations were removed from the locale files. ChangesCRDT status cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The obsolete CRDT status display is removed and verification guidance now points to the gated debug panel. No current merge-blocking risk is identified. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: Description checkExplanation The description provides clear context, change details, rationale, affected locales, verification steps, and related issues. It does not reproduce every template heading, but it contains the required information and is sufficiently complete. Full details: End-To-End Regression Coverage For FixesExplanation The changed-file list and PR description are available, but the PR title and commit subjects are not provided. The check requires those fields to detect bug-fix language, so the result cannot be determined without guessing. Full details: Adr Compliance For Entity/Litegraph ChangesExplanation The changed-file list contains locale files, ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16759 +/- ##
==========================================
+ Coverage 81.04% 82.67% +1.62%
==========================================
Files 2452 2040 -412
Lines 125698 118976 -6722
Branches 33423 30050 -3373
==========================================
- Hits 101875 98365 -3510
+ Misses 23312 20431 -2881
+ Partials 511 180 -331
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 431 files with indirect coverage changes 🚀 New features to boost your workflow:
|
CodeJuggernaut
left a comment
There was a problem hiding this comment.
Walked the diff and its blast radius against the current head; nothing to add.
Removes temporary CRDT status strip. Dev instrument (#16365) replaces it. 15 locales, −78 lines.
Full context for agent readers
What
agent-crdt-statusstrip fromAgentPanelRoot.vue(thev-if="crdtStatus.enabled"block that rendered "CRDT {connection} · {workflowId} · {updates} updates · {frame}").agent.crdt*locale keys (crdtStatus,crdtConnected,crdtDisconnected,crdtNoDocument) fromenand the 14 generated locales so no orphan keys remain.crdt/RUN-CLOUD-E2E.mdverify step now points at the CRDT debug instrument (?crdtDebug=1) instead of the strip.crdtStatusitself is kept: it feeds<CrdtDevPanel :status="crdtStatus" …>inAgentPanel's#instrumentslot.Why
The strip was a stopgap so testers could report CRDT connection state. #16365 restores the gated dev panel, which shows the same connection / document / update information plus the event log, so the always-on strip is redundant and was pushing the composer below the fold on small viewports (see the header comment in
CrdtDevPanel.vue).Stacking
Single commit rebased onto
mainafter #16365 merged as8f3b1569e4241ebbb5a9333da2bd09465947c40c.Gates (local, this head)
vue-tsc --noEmitexit 0vitest run src/workbench/extensions/agent74 files / 945 tests passoxlint --type-aware0/0,oxfmt --checkclean, husky pre-commit (lint-staged +pnpm lint) passedRelated
agent-crdt-status.