Repository navigation
fix(agent): gate the CRDT debug status strip behind DEV - #16706
christian-byrne wants to merge 2 commits into
Conversation
The `agent-crdt-status` monospace strip in AgentPanelRoot rendered whenever `crdtStatus.enabled` was true, which is unconditional (hardcoded true in useAgentCrdtFollower's status computed). It shipped as always-on production telemetry to every user with the agent panel open, with zero test coverage, while the CrdtDevPanel instrument right below it is correctly gated behind import.meta.env.DEV. Gate the strip behind the same isCrdtDevPanelEnabled check so the two debug surfaces mount/unmount together instead of the strip alone surviving into a production build.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe CRDT status banner and ChangesCRDT Debug UI Visibility
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The CRDT debug status strip now appears only in development builds alongside the development panel, while production builds omit both surfaces. No current merge-blocking risk remains. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: Description checkExplanation The description clearly explains the issue, the fix, testing results, and relevant context. It does not use the exact template headings, but it provides the required information and is complete enough for review. Full details: End-To-End Regression Coverage For FixesExplanation The changed-file list is available, but the PR title and commit subjects are not provided. The check requires one of those sources to establish the bug-fix signal. The description uses fix-related wording, but that is not an allowed substitute for the title or commit subjects. Resolution Provide the PR title and commit subjects, then verify whether the bug-fix signal is present. If it is present, the PR changes frontend files under src/ and no browser_tests/ file, and the description does not concretely explain why an end-to-end regression test is impractical, ask the author to add or update a Playwright regression test under browser_tests/ or add that explanation. Full details: Adr Compliance For Entity/Litegraph ChangesExplanation The changed files are ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 1910 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.68 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.42 MB (baseline 1.42 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.59 MB (baseline 3.59 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 296 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-03T07:32:31.480Z",
"gitSha": "6d2cc96b7ec7dca337eef097234633fbcb5667ea",
"branch": "christian-byrne/crdt-rm7-debug-status-strip-gate",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2049.139000000082,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.312000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 630.529,
"heapDeltaBytes": -2798500,
"heapUsedBytes": 66916560,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 14.769,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2035.472000000027,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.013999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 619.897,
"heapDeltaBytes": 1163348,
"heapUsedBytes": 71997044,
"domNodes": -284,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 14.437999999999999,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2229.1439999999056,
"styleRecalcs": 83,
"styleRecalcDurationMs": 52.346999999999994,
"layouts": 14,
"layoutDurationMs": 5.369000000000001,
"taskDurationMs": 1223.2699999999998,
"heapDeltaBytes": 2599144,
"heapUsedBytes": 72540608,
"domNodes": -279,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 215.181,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1942.8669999999784,
"styleRecalcs": 79,
"styleRecalcDurationMs": 44.541,
"layouts": 14,
"layoutDurationMs": 4.5,
"taskDurationMs": 1012.6919999999999,
"heapDeltaBytes": 6733112,
"heapUsedBytes": 77534024,
"domNodes": -279,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 173.714,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1729.4749999999794,
"styleRecalcs": 31,
"styleRecalcDurationMs": 20.719,
"layouts": 6,
"layoutDurationMs": 1.3130000000000002,
"taskDurationMs": 452.99399999999997,
"heapDeltaBytes": 4734508,
"heapUsedBytes": 75506628,
"domNodes": 77,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 17.252,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1688.784999999939,
"styleRecalcs": 30,
"styleRecalcDurationMs": 21.418,
"layouts": 6,
"layoutDurationMs": 1.239,
"taskDurationMs": 438.8380000000001,
"heapDeltaBytes": 5142424,
"heapUsedBytes": 75956628,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 15.875999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 722.4360000000161,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.347,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.683,
"heapDeltaBytes": -7213444,
"heapUsedBytes": 63237120,
"domNodes": 16,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 168.89,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 734.1959999999972,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.928,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.78900000000004,
"heapDeltaBytes": -7463836,
"heapUsedBytes": 63302200,
"domNodes": 14,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 169.89,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2052.3849999999584,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.792000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 776.3100000000001,
"heapDeltaBytes": 11140564,
"heapUsedBytes": 86314284,
"domNodes": -269,
"jsHeapTotalBytes": -888832,
"scriptDurationMs": 47.74300000000001,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2055.823999999916,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.411000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 793.4219999999999,
"heapDeltaBytes": 11279520,
"heapUsedBytes": 86491136,
"domNodes": -273,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 42.505,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2984.421999999995,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.907,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1866.453,
"heapDeltaBytes": 16262744,
"heapUsedBytes": 93049872,
"domNodes": -273,
"jsHeapTotalBytes": -2498560,
"scriptDurationMs": 896.351,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2977.620999999999,
"styleRecalcs": 62,
"styleRecalcDurationMs": 8.719999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1842.6689999999999,
"heapDeltaBytes": 27153992,
"heapUsedBytes": 93070460,
"domNodes": -280,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 888.8349999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3913.511999999969,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.937999999999997,
"layouts": 60,
"layoutDurationMs": 13.169,
"taskDurationMs": 1876.592,
"heapDeltaBytes": 16648664,
"heapUsedBytes": 84096192,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 827.406,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3986.672999999996,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.943999999999999,
"layouts": 60,
"layoutDurationMs": 12.996,
"taskDurationMs": 1893.056,
"heapDeltaBytes": 8495664,
"heapUsedBytes": 75834684,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 836.28,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3149.850000000015,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.72,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2104.514,
"heapDeltaBytes": 25186304,
"heapUsedBytes": 93690232,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1033.7,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3180.8169999999336,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.646999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2129.72,
"heapDeltaBytes": 26367992,
"heapUsedBytes": 93768104,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1043.824,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2038.966000000073,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.9,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 698.2170000000001,
"heapDeltaBytes": -14863948,
"heapUsedBytes": 88011376,
"domNodes": -271,
"jsHeapTotalBytes": -1638400,
"scriptDurationMs": 40.02799999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2042.2190000000455,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.220000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 740.54,
"heapDeltaBytes": 10463572,
"heapUsedBytes": 86893616,
"domNodes": -268,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 41.66400000000001,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 671.4009999999462,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.505,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.33299999999997,
"heapDeltaBytes": 14856920,
"heapUsedBytes": 87512604,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 150.004,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 677.9589999999871,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.302,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.25899999999996,
"heapDeltaBytes": 14455220,
"heapUsedBytes": 86464196,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 148.221,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.0949999999457,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.683999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 623.0899999999999,
"heapDeltaBytes": 297320,
"heapUsedBytes": 72933380,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 13.321999999999997,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2019.6849999999813,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.711999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 631.4599999999999,
"heapDeltaBytes": -8323040,
"heapUsedBytes": 63820056,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 13.411000000000003,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1840.0229999999738,
"styleRecalcs": 80,
"styleRecalcDurationMs": 48.288,
"layouts": 18,
"layoutDurationMs": 6.772,
"taskDurationMs": 1002.4039999999999,
"heapDeltaBytes": -14788212,
"heapUsedBytes": 57830236,
"domNodes": -294,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 129.39600000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1772.1449999999095,
"styleRecalcs": 78,
"styleRecalcDurationMs": 43.791,
"layouts": 18,
"layoutDurationMs": 6.83,
"taskDurationMs": 962.124,
"heapDeltaBytes": 1794284,
"heapUsedBytes": 74733312,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 128.093,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1433.499999999981,
"styleRecalcs": 19,
"styleRecalcDurationMs": 35.04399999999999,
"layouts": 15,
"layoutDurationMs": 17.616000000000003,
"taskDurationMs": 1079.569,
"heapDeltaBytes": -5467496,
"heapUsedBytes": 86153388,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 37.201,
"eventListeners": 2383,
"totalBlockingTimeMs": 161,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10953.085999999985,
"styleRecalcs": 245,
"styleRecalcDurationMs": 37.612,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6877.174999999999,
"heapDeltaBytes": -31946044,
"heapUsedBytes": 69148756,
"domNodes": -274,
"jsHeapTotalBytes": -1114112,
"scriptDurationMs": 3135.146,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9796.24299999989,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.523,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6364.9259999999995,
"heapDeltaBytes": 16967344,
"heapUsedBytes": 92813308,
"domNodes": -268,
"jsHeapTotalBytes": -1482752,
"scriptDurationMs": 2819.0559999999996,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18504.68999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17949.477000000003,
"heapDeltaBytes": -42495616,
"heapUsedBytes": 174365952,
"domNodes": -6548,
"jsHeapTotalBytes": 499712,
"scriptDurationMs": 353.50800000000004,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18170.53899999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17445.134000000002,
"heapDeltaBytes": -33672768,
"heapUsedBytes": 175899596,
"domNodes": -6577,
"jsHeapTotalBytes": -3821568,
"scriptDurationMs": 304.993,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22491.321000000084,
"styleRecalcs": 179,
"styleRecalcDurationMs": 25.34200000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22285.842,
"heapDeltaBytes": -24688796,
"heapUsedBytes": 176548788,
"domNodes": -6548,
"jsHeapTotalBytes": 4182016,
"scriptDurationMs": 998.13,
"eventListeners": -7471,
"totalBlockingTimeMs": 140,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22496.33700000004,
"styleRecalcs": 177,
"styleRecalcDurationMs": 23.760000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22103.137,
"heapDeltaBytes": -38096576,
"heapUsedBytes": 170612272,
"domNodes": -6548,
"jsHeapTotalBytes": -3543040,
"scriptDurationMs": 1005.787,
"eventListeners": -7471,
"totalBlockingTimeMs": 160,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6600.017999999977,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.07400000000004,
"layouts": 20,
"layoutDurationMs": 26.580999999999992,
"taskDurationMs": 6535.833,
"heapDeltaBytes": -7737684,
"heapUsedBytes": 197333984,
"domNodes": -6548,
"jsHeapTotalBytes": 18087936,
"scriptDurationMs": 131.33800000000002,
"eventListeners": -7471,
"totalBlockingTimeMs": 482,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6370.702999999935,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.625,
"layouts": 20,
"layoutDurationMs": 23.65600000000001,
"taskDurationMs": 6291.719,
"heapDeltaBytes": -7365476,
"heapUsedBytes": 180836640,
"domNodes": -6548,
"jsHeapTotalBytes": 18817024,
"scriptDurationMs": 110.662,
"eventListeners": -7473,
"totalBlockingTimeMs": 447,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9299.564000000031,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9014.548,
"heapDeltaBytes": 11750360,
"heapUsedBytes": 180684084,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 157.48799999999997,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9138.56599999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8773.332000000002,
"heapDeltaBytes": 19653300,
"heapUsedBytes": 176392396,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 153.54999999999995,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 127.36799999993309,
"styleRecalcs": 8,
"styleRecalcDurationMs": 22.031,
"layouts": 3,
"layoutDurationMs": 1.6379999999999997,
"taskDurationMs": 103.40000000000002,
"heapDeltaBytes": 3142800,
"heapUsedBytes": 71880120,
"domNodes": 110,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 10.598999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 100.9040000000141,
"styleRecalcs": 6,
"styleRecalcDurationMs": 13.875,
"layouts": 2,
"layoutDurationMs": 1.2699999999999998,
"taskDurationMs": 76.55400000000002,
"heapDeltaBytes": 3058760,
"heapUsedBytes": 71979972,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.265999999999998,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16706 +/- ##
==========================================
+ Coverage 80.88% 82.56% +1.67%
==========================================
Files 2448 2033 -415
Lines 124940 118132 -6808
Branches 31531 32067 +536
==========================================
- Hits 101052 97530 -3522
+ Misses 23380 20425 -2955
+ Partials 508 177 -331
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 552 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 5 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
| 🟢 Low | 3 |
| ⚪ Nit | 1 |
Panel: 6/8 reviewers contributed findings.
Reviewers that did not contribute: kimi-k3-max:adversarial (error), kimi-k3-max:edge-case (error)
|
|
||
| const strip = screen.queryByTestId('agent-crdt-status') | ||
| const devPanel = screen.queryByTestId('crdt-dev-panel-chip') | ||
| expect(strip === null).toBe(devPanel === null) |
There was a problem hiding this comment.
🟡 Medium — This guard passes against the pre-fix template too: Vitest runs with import.meta.env.DEV === true and crdtStatus.enabled is hardcoded true, so both nodes render either way and strip === null / devPanel === null are equally false. The assertion is also vacuously satisfied when neither element renders, so the production gate is untested while CI reports it as covered — stub the env (vi.stubEnv('DEV', false), as src/base/assert.test.ts does) before render() and assert the strip is absent. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| /> | ||
| <div | ||
| v-if="crdtStatus.enabled" | ||
| v-if="isCrdtDevPanelEnabled && crdtStatus.enabled" |
There was a problem hiding this comment.
🟢 Low — The gate suppresses display but not collection: useAgentCrdtFollower is still instantiated unconditionally and calls recordDevEvent on every outbound frame and inbound doc update, so production builds keep a 500-entry module-level buffer of parsed frames, doc node-id sets, and human:<userId>:<tabId> actor strings — with no UI left to clear it. If the intent is that this debug data never reaches users, gate recordDevEvent on the same flag. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
| render(AgentPanelRoot, { global: { plugins: [i18n] } }) | ||
|
|
||
| const strip = screen.queryByTestId('agent-crdt-status') | ||
| const devPanel = screen.queryByTestId('crdt-dev-panel-chip') |
There was a problem hiding this comment.
🟢 Low — crdt-dev-panel-chip is a poor probe for "the dev panel mounted": it renders under v-if="!open", where open is seeded from localStorage['Comfy.Agent.CrdtDevPanel.open'], which happy-dom shares across tests in this file and neither the setup file nor the local beforeEach clears. Once anything persists 'true', the chip disappears while the strip stays and this test fails for an unrelated reason; query the unconditional panel root testid crdt-dev-panel instead. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| /> | ||
| <div | ||
| v-if="crdtStatus.enabled" | ||
| v-if="isCrdtDevPanelEnabled && crdtStatus.enabled" |
There was a problem hiding this comment.
🟢 Low — crdt/RUN-CLOUD-E2E.md uses this strip (data-testid="agent-crdt-status") as its primary in-app verification signal and offers a hosted FE preview as a run target, but preview deploys are production builds where import.meta.env.DEV is false — so neither the strip nor the CrdtDevPanel will render there. Update that run sheet's verification step, or expose the signal in a way that survives a production build. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
| /> | ||
| <div | ||
| v-if="crdtStatus.enabled" | ||
| v-if="isCrdtDevPanelEnabled && crdtStatus.enabled" |
There was a problem hiding this comment.
⚪ Nit — The crdtStatus.enabled conjunct is dead — useAgentCrdtFollower builds its status with a literal enabled: true — so the condition reduces to isCrdtDevPanelEnabled while reading as if the strip tracks follower enablement. Either drop the conjunct or make AgentCrdtStatus.enabled reflect real state. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
The regression test passed against the pre-fix template: vitest runs with DEV=true and crdtStatus.enabled is hardcoded, so both nodes always rendered and the null-equality check held either way. Stub DEV=false to assert the strip and CrdtDevPanel are absent, keep a DEV=true case for the rendered side, and probe the unconditional crdt-dev-panel root instead of the chip, which only renders while the panel is closed. Note in the cloud E2E run sheet that the strip is DEV-only so a hosted preview build is no longer a valid target for that verification step.
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed head 81defd91dd9f5e001b9bd5aa5c7fb89ca6d24384 against main (merge-base fa42e3b263). The one-line template gate is correct and behavior-preserving for dev builds; the regression test did not actually exercise it. Fixes pushed in a234e10405.
Vacuous test: passed unchanged on the pre-fix template. Fixed in a234e10.
Chip probe depends on persisted localStorage open state. Fixed in a234e10.
Run sheet targets a hosted preview where the strip no longer renders. Fixed in a234e10.
Full context for agent readers
Verification performed on the PR head in a worktree off the PR branch.
The template change at AgentPanelRoot.vue line 966 gates the agent-crdt-status strip on isCrdtDevPanelEnabled && crdtStatus.enabled, where isCrdtDevPanelEnabled = import.meta.env.DEV (line 408, inside script setup) and crdtStatus.enabled is the literal enabled: true in useAgentCrdtFollower.ts line 556. So the effective gate is import.meta.env.DEV, matching the CrdtDevPanel gate on line 981. Correct fix for CRDT-RM-7.
Test finding (issue, fixed): I checked out the merge-base AgentPanelRoot.vue under the PR's test file and ran the new test; it passed. Vitest runs with DEV=true, so the strip and the chip both render pre- and post-fix and strip === null equals devPanel === null in both worlds. It would also pass if neither rendered. The rewritten test calls vi.stubEnv('DEV', false) before mount and asserts both agent-crdt-status and crdt-dev-panel are absent; a second case stubs DEV=true and asserts both are present. With the merge-base template the DEV=false case now fails (expected <div> to be null), with the PR template it passes. vite.config.mts sets unstubEnvs: true so no manual cleanup is needed.
Probe finding (suggestion, fixed): crdt-dev-panel-chip renders under v-if="!open" in CrdtDevPanel.vue, and open seeds from localStorage['Comfy.Agent.CrdtDevPanel.open']. The test now probes the unconditional crdt-dev-panel root.
Run sheet finding (suggestion, fixed): crdt/RUN-CLOUD-E2E.md lists the strip as the first verification signal and offers the FE PR 15457 hosted preview as a run target; preview deploys are production builds where import.meta.env.DEV is false. Added a sentence noting the strip and dev panel are DEV-only and pointing hosted-preview runs at canvas updates and /ws frames instead.
Left as-is: the dead crdtStatus.enabled conjunct. It reads as if the strip tracks follower enablement while enabled is hardcoded true. Dropping it is a one-token change but it also removes the only consumer of AgentCrdtStatus.enabled; if the field is meant to become real later the conjunct is the right shape, otherwise a follow-up should remove both. Author's call.
Left as-is: recordDevEvent still runs unconditionally in production (devPanelLog.ts keeps a 500-entry buffer of parsed frames and actor strings with no UI to drain it). Real, but it is a separate change in the follower/log layer rather than the template exposure this PR scopes to; worth its own row.
Checks on a234e10405: AgentPanelRoot.test.ts 115/115, eslint/oxlint/oxfmt clean on the touched files, vue-tsc --noEmit exit 0.
| /> | ||
| <div | ||
| v-if="crdtStatus.enabled" | ||
| v-if="isCrdtDevPanelEnabled && crdtStatus.enabled" |
There was a problem hiding this comment.
nitpick: crdtStatus.enabled is the literal enabled: true from useAgentCrdtFollower (line 556), so this reduces to isCrdtDevPanelEnabled while reading as if the strip tracks follower enablement. Left as-is: dropping it also removes the only consumer of AgentCrdtStatus.enabled; keep it if the field is meant to become real, otherwise remove both in a follow-up. Separately, crdt/RUN-CLOUD-E2E.md used this strip as its primary verification signal and offers a hosted preview (production build) as a target; I added a DEV-only note there in a234e10.
|
Took this one for a conflict-fix and stopped short of pushing, because the rebase shows the PR has been fully superseded on The conflict in The gate this PR keys on is also gone. The run-sheet note is superseded too. That is all three files, so my read is that this should be closed as superseded rather than rebased. Not closing it here since that is not this lane's call. The |
|
Closing as superseded. All three files in this PR are no-ops against current Full context for agent readersRe-verified against
The CRDT-RM-7 sub-item this PR carried is satisfied on |
Closes the CRDT-RM-7 finding that the
agent-crdt-statusmonospace strip inAgentPanelRoot.vuerenders for every user with the agent panel open, not just in dev builds — because it is gated only oncrdtStatus.enabled, which is hardcodedtrueinuseAgentCrdtFollower's status computed. TheCrdtDevPanelinstrument directly below it is already correctly gated onisCrdtDevPanelEnabled(import.meta.env.DEV); this strip was not.Change
Gate the strip on
isCrdtDevPanelEnabled && crdtStatus.enabledso both debug surfaces mount/unmount together.Testing
AgentPanelRoot.test.tsfull file: 114/114 passing.vue-tsc --noEmit: clean.eslint: clean.Context
Prior work on this (PR #16209 / #16275, "port dev panel instrument to v2 ci-fix line") landed a much larger rework — a first-class debug-consent gate (
crdtDebugGate.ts), snapshot/report helpers, and a fullerCrdtDevPanel— but only into thechristian-byrne/integration-candidate-v2-ci-fixbranch, which never reachedmain. That branch has diverged too far from currentmain's follower architecture (EcsFollowerAdapter/createOpSendervs. the oldDocOp/LiteGraph seams) to port directly; this PR is the minimal, narrowly-scoped fix for the concrete production-exposure gap on currentmain, tracked as todo rowCRDT-RM-7.