Skip to content

[backport core/1.52] feat(nodes): brand Comfy Cloud partner nodes on canvas and in the registry - #16728

Merged
DrJKL merged 1 commit into
core/1.52from
backport-16535-to-core-1.52
Sep 3, 2026
Merged

DrJKL merged 1 commit into
core/1.52from
backport-16535-to-core-1.52

Conversation

@DrJKL

@DrJKL DrJKL commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Backport of #16535 to core/1.52.

Conflict resolution preserves the target branch's Vue-node badge and pricing implementation. The standalone usePartitionedBadges.test.ts conflict was dropped because that test was introduced by the later ECS migration (#14246), which is not present on core/1.52; the Comfy Cloud behavior is covered in badgeRendererParity.test.ts instead.

…istry (#16535)

Comfy Cloud nodes are `api_node`s like every other partner node, so
nothing on the canvas or in node search told them apart from Kling or
Veo. This gives them the Comfy mark.

- **Canvas (Nodes 2.0 only — see Review Focus)**: Comfy Cloud nodes
render the round Comfy badge, tinted brand yellow. The core-node logo is
a *source* badge (defers to `NodeSourceBadgeMode`, yields to a price
badge); this mark is *provider identity* on a node that always carries a
price, so both of those rules would have hidden it permanently. It gets
its own condition — that `|| isComfyCloudNode` is the one behavioural
change in the PR.
- **Node registry (search + library)**: adds `comfy-cloud.svg` and
safelists it. No code change was needed — `getProviderIcon` already
resolves `icon-[comfy--comfy-cloud]` by naming convention, so the asset
wires itself up.
- Detection is `python_module === 'comfy_api_nodes.nodes_comfy_cloud'`.
Verified against Comfy-Org/ComfyUI#15935: `init_builtin_api_nodes` globs
`comfy_api_nodes/nodes_*.py`, `load_custom_node(...,
module_parent="comfy_api_nodes")` sets `RELATIVE_PYTHON_MODULE`, and
`server.py` serves that as `python_module` in `/object_info`.

An earlier revision also painted the provider pill solid brand yellow
via a new `solid` variant on `BadgePill`. That was dropped: at pill size
the outline read as neither useful nor noticeable, and the full-colour
logo carries the identity on its own. `BadgePill.vue`,
`NodeProviderBadge.vue` and `categoryUtil.ts` are back to main, which is
why they are absent from the diff.

**The safelist is load-bearing and has no test.** `getProviderIcon`
builds the class at runtime, so
`packages/design-system/src/css/style.css` needs the `comfy-cloud` entry
in its `@source inline(...)` list or the icon renders in dev and
silently disappears from the production stylesheet. It rendered before
that entry existed only because a test file happened to contain the
literal class name for the scanner to find.

**The classic canvas is unchanged, and it is the default for the user
this feature targets.** `Comfy.VueNodes.Enabled` is `defaultValue:
false` with `defaultsByInstallVersion: { '1.41.0': isCloud || isDesktop
}`, so a plain local ComfyUI install renders the classic canvas. Driving
both renderers off the same node shows the legacy output is
byte-identical for Comfy Cloud and Kling:

| `python_module` | legacy draw objects | Vue |
|---|---|---|
| `…nodes_comfy_cloud` | `["#1 🦊", "$0.05 x 3 Runs"]` |
`hasComfyCloudBadge: true` |
| `…nodes_kling` | `["#1 🦊", "$0.05 x 3 Runs"]` | `hasComfyCloudBadge:
false` |

`getNodeSource` classifies every `comfy_api_nodes.*` module as Core, so
the legacy canvas shows the generic core fox for both. Local users still
get the icon in node search and the library, and the node description
carries the rate, but on canvas the Summary's problem is unsolved for
them.

Not folded in here: the classic canvas has no logo badge concept at all,
so it needs a third `BadgeData` variant, a restructured
`buildDrawObjects` (its `if (row.kind === 'core') continue` gives every
other row the credits icon), `python_module` threaded through
`computeBadges`, and a second hardcoded copy of the brand colour as an
SVG data URI. That is the shared row model plus the legacy draw path —
its own PR and its own risk grade, not a rider on ~120 additive lines.
Tracked as
[BE-11449](https://linear.app/comfyorg/issue/BE-11449/comfy-cloud-nodes-show-the-comfy-mark-on-the-classic-canvas)
and pinned by two tests in `badgeRendererParity.test.ts` that fail when
it lands.

`getProviderIcon` also feeds three standalone call sites
(`NodeSearchListItem`, `NodeLibrarySidebarTabV2`,
`PartnerNodeAccessPanel`). All three rendered no provider icon for Comfy
Cloud before this PR, since `icon-[comfy--comfy-cloud]` had no asset;
they now get the full-colour mark with no change of their own.

<img width="817" height="737" alt="image"
src="https://github.com/user-attachments/assets/712618c4-3e05-4f81-a288-f92374512343"
/>

- Comfy-Org/ComfyUI#15935 — the nodes themselves
- Comfy-Org/cloud#7588 → #7676 → #7678 — provider contract, frozen
manifests, execution and billing
- Comfy-Org/cloud#7593 — ingest-side recursion guard

---------

Co-authored-by: Deep Mehta <deep@comfy.org>
@DrJKL DrJKL added the backport Backporting a PR onto a release candidate label Sep 3, 2026
@DrJKL
DrJKL requested a review from a team as a code owner September 3, 2026 02:41
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 45d79a1c-5279-4e99-9e83-0389077471c7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1984 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1963 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🌐 Website E2E

Caution

Some tests failed.

Status ❌ Failed
Report View Report
Screenshot diffs 0
Other failures 2

Warning

2 non-screenshot failures — these require manual review.

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/03/2026, 02:43:35 AM UTC

Links

@codecov

codecov Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...erer/extensions/vueNodes/components/NodeBadges.vue 0.00% 1 Missing ⚠️
@@              Coverage Diff              @@
##           core/1.52   #16728      +/-   ##
=============================================
- Coverage      82.01%   79.59%   -2.42%     
=============================================
  Files           1907     2237     +330     
  Lines         109080   114088    +5008     
  Branches       29778    30967    +1189     
=============================================
+ Hits           89462    90810    +1348     
- Misses         19268    22800    +3532     
- Partials         350      478     +128     
Flag Coverage Δ
e2e 66.33% <75.00%> (-0.10%) ⬇️
unit 73.94% <75.00%> (+<0.01%) ⬆️
website-unit 27.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...sions/vueNodes/composables/usePartitionedBadges.ts 82.45% <100.00%> (+0.47%) ⬆️
...erer/extensions/vueNodes/components/NodeBadges.vue 52.94% <0.00%> (-2.62%) ⬇️

... and 345 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL DrJKL assigned deepme987 and unassigned DrJKL Sep 3, 2026
@DrJKL
DrJKL enabled auto-merge (squash) September 3, 2026 02:45
@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 3, 2026
@DrJKL
DrJKL merged commit 670a3fa into core/1.52 Sep 3, 2026
88 of 89 checks passed
@DrJKL
DrJKL deleted the backport-16535-to-core-1.52 branch September 3, 2026 02:55
DrJKL pushed a commit that referenced this pull request Sep 5, 2026
…canvas and in the registry (#17047)

## Summary

Backport of #16535 to `core/1.51` — brands Comfy Cloud partner nodes on
the canvas and in the registry.

## Changes

- **What**: Cherry-pick of #16535 adapted to core/1.51's **pre-ECS**
badge architecture, mirroring the already-merged 1.52 backport #16728.
Adds the Comfy Cloud badge (node detected via `python_module ===
'comfy_api_nodes.nodes_comfy_cloud'`) in `usePartitionedBadges.ts` /
`NodeBadges.vue`, plus the `comfy-cloud` icon and the design-system CSS.
- Dropped `usePartitionedBadges.test.ts` — it targets the ECS-refactored
composable, which isn't present on core/1.51 (same call #16728 made).
`badgeRendererParity.test.ts` is the pre-ECS-adapted version from
#16728.

## Review Focus

- The badge-file changes are byte-identical to the merged 1.52 backport
(#16728); the core/1.51→core/1.52 base delta for those files is exactly
#16728's diff, so this reuses a proven resolution.
- Verified locally: `typecheck` clean, `badgeRendererParity.test.ts`
passes, format clean.

## References

- Backport of #16535 (main). Sibling backport: #16728 (core/1.52,
merged).

Co-authored-by: Deep Mehta <deep@comfy.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:R2 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants