Repository navigation
[backport core/1.51] feat(nodes): brand Comfy Cloud partner nodes on canvas and in the registry - #17047
Conversation
…istry (#16535) Comfy Cloud nodes are `api_node`s like every other partner node, so nothing on the canvas or in node search told them apart from Kling or Veo. This gives them the Comfy mark. - **Canvas (Nodes 2.0 only — see Review Focus)**: Comfy Cloud nodes render the round Comfy badge, tinted brand yellow. The core-node logo is a *source* badge (defers to `NodeSourceBadgeMode`, yields to a price badge); this mark is *provider identity* on a node that always carries a price, so both of those rules would have hidden it permanently. It gets its own condition — that `|| isComfyCloudNode` is the one behavioural change in the PR. - **Node registry (search + library)**: adds `comfy-cloud.svg` and safelists it. No code change was needed — `getProviderIcon` already resolves `icon-[comfy--comfy-cloud]` by naming convention, so the asset wires itself up. - Detection is `python_module === 'comfy_api_nodes.nodes_comfy_cloud'`. Verified against Comfy-Org/ComfyUI#15935: `init_builtin_api_nodes` globs `comfy_api_nodes/nodes_*.py`, `load_custom_node(..., module_parent="comfy_api_nodes")` sets `RELATIVE_PYTHON_MODULE`, and `server.py` serves that as `python_module` in `/object_info`. An earlier revision also painted the provider pill solid brand yellow via a new `solid` variant on `BadgePill`. That was dropped: at pill size the outline read as neither useful nor noticeable, and the full-colour logo carries the identity on its own. `BadgePill.vue`, `NodeProviderBadge.vue` and `categoryUtil.ts` are back to main, which is why they are absent from the diff. **The safelist is load-bearing and has no test.** `getProviderIcon` builds the class at runtime, so `packages/design-system/src/css/style.css` needs the `comfy-cloud` entry in its `@source inline(...)` list or the icon renders in dev and silently disappears from the production stylesheet. It rendered before that entry existed only because a test file happened to contain the literal class name for the scanner to find. **The classic canvas is unchanged, and it is the default for the user this feature targets.** `Comfy.VueNodes.Enabled` is `defaultValue: false` with `defaultsByInstallVersion: { '1.41.0': isCloud || isDesktop }`, so a plain local ComfyUI install renders the classic canvas. Driving both renderers off the same node shows the legacy output is byte-identical for Comfy Cloud and Kling: | `python_module` | legacy draw objects | Vue | |---|---|---| | `…nodes_comfy_cloud` | `["#1 🦊", "$0.05 x 3 Runs"]` | `hasComfyCloudBadge: true` | | `…nodes_kling` | `["#1 🦊", "$0.05 x 3 Runs"]` | `hasComfyCloudBadge: false` | `getNodeSource` classifies every `comfy_api_nodes.*` module as Core, so the legacy canvas shows the generic core fox for both. Local users still get the icon in node search and the library, and the node description carries the rate, but on canvas the Summary's problem is unsolved for them. Not folded in here: the classic canvas has no logo badge concept at all, so it needs a third `BadgeData` variant, a restructured `buildDrawObjects` (its `if (row.kind === 'core') continue` gives every other row the credits icon), `python_module` threaded through `computeBadges`, and a second hardcoded copy of the brand colour as an SVG data URI. That is the shared row model plus the legacy draw path — its own PR and its own risk grade, not a rider on ~120 additive lines. Tracked as [BE-11449](https://linear.app/comfyorg/issue/BE-11449/comfy-cloud-nodes-show-the-comfy-mark-on-the-classic-canvas) and pinned by two tests in `badgeRendererParity.test.ts` that fail when it lands. `getProviderIcon` also feeds three standalone call sites (`NodeSearchListItem`, `NodeLibrarySidebarTabV2`, `PartnerNodeAccessPanel`). All three rendered no provider icon for Comfy Cloud before this PR, since `icon-[comfy--comfy-cloud]` had no asset; they now get the full-colour mark with no change of their own. <img width="817" height="737" alt="image" src="https://github.com/user-attachments/assets/712618c4-3e05-4f81-a288-f92374512343" /> - Comfy-Org/ComfyUI#15935 — the nodes themselves - Comfy-Org/cloud#7588 → #7676 → #7678 — provider contract, frozen manifests, execution and billing - Comfy-Org/cloud#7593 — ingest-side recursion guard --------- Co-authored-by: Deep Mehta <deep@comfy.org>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1830 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-05T01:24:49.136Z",
"gitSha": "e1d7646b051bc7bb4db95d857d07739561548d7b",
"branch": "backport-16535-to-core-1.51",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2014.6689999999694,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.334,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.603,
"heapDeltaBytes": 5021624,
"heapUsedBytes": 71491588,
"domNodes": 14,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 6.077000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2038.137000000006,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.096,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.45700000000005,
"heapDeltaBytes": 5009072,
"heapUsedBytes": 71312928,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 8.055000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1855.3459999999973,
"styleRecalcs": 78,
"styleRecalcDurationMs": 39.908,
"layouts": 12,
"layoutDurationMs": 3.6920000000000006,
"taskDurationMs": 827.636,
"heapDeltaBytes": 227544,
"heapUsedBytes": 66680672,
"domNodes": 61,
"jsHeapTotalBytes": 24121344,
"scriptDurationMs": 116.24700000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1823.9650000000438,
"styleRecalcs": 76,
"styleRecalcDurationMs": 36.867,
"layouts": 12,
"layoutDurationMs": 3.5389999999999997,
"taskDurationMs": 846.5859999999999,
"heapDeltaBytes": -157160,
"heapUsedBytes": 66294336,
"domNodes": 58,
"jsHeapTotalBytes": 25169920,
"scriptDurationMs": 111.91699999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.6810000000187,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.621000000000002,
"layouts": 6,
"layoutDurationMs": 0.6679999999999999,
"taskDurationMs": 367.711,
"heapDeltaBytes": 7839808,
"heapUsedBytes": 74064980,
"domNodes": 78,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 9.285,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1718.0869999999686,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.567999999999998,
"layouts": 6,
"layoutDurationMs": 0.652,
"taskDurationMs": 384.73900000000003,
"heapDeltaBytes": 8374100,
"heapUsedBytes": 74804760,
"domNodes": 74,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 10.709999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 576.3640000000123,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.941999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.884,
"heapDeltaBytes": -10640144,
"heapUsedBytes": 55695036,
"domNodes": 18,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 57.383,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 576.2019999999666,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.505000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.336,
"heapDeltaBytes": -10870936,
"heapUsedBytes": 55717904,
"domNodes": 18,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 57.05400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2016.3139999999657,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.851,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 593.154,
"heapDeltaBytes": 10649488,
"heapUsedBytes": 71217492,
"domNodes": -283,
"jsHeapTotalBytes": 2457600,
"scriptDurationMs": 13.246,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2041.0339999999678,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.4590000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 594.427,
"heapDeltaBytes": 9899600,
"heapUsedBytes": 70553724,
"domNodes": -284,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 13.977999999999998,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2165.6810000000064,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.816000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1181.348,
"heapDeltaBytes": 2724652,
"heapUsedBytes": 64232772,
"domNodes": -283,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 330.484,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2159.1959999999517,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.445999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1205.852,
"heapDeltaBytes": 15458324,
"heapUsedBytes": 77563896,
"domNodes": -285,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 323.03499999999997,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3182.2400000000357,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.753000000000002,
"layouts": 60,
"layoutDurationMs": 7.348000000000001,
"taskDurationMs": 1369.858,
"heapDeltaBytes": -3810840,
"heapUsedBytes": 59123484,
"domNodes": -287,
"jsHeapTotalBytes": 4554752,
"scriptDurationMs": 382.835,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3248.2069999999794,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.304999999999998,
"layouts": 60,
"layoutDurationMs": 7.559,
"taskDurationMs": 1426.79,
"heapDeltaBytes": -956508,
"heapUsedBytes": 62213664,
"domNodes": -287,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 385.39599999999996,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2030.1370000000247,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.766999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.3759999999999,
"heapDeltaBytes": 2828160,
"heapUsedBytes": 64506080,
"domNodes": -284,
"jsHeapTotalBytes": 2981888,
"scriptDurationMs": 14.259999999999994,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2035.2120000000014,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.275999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 620.785,
"heapDeltaBytes": 13125648,
"heapUsedBytes": 75426908,
"domNodes": -284,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 16.341000000000005,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 609.4909999999913,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.438999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.816,
"heapDeltaBytes": -10320604,
"heapUsedBytes": 56373300,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 115.758,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 623.3949999999595,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.455,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.69199999999995,
"heapDeltaBytes": -9981780,
"heapUsedBytes": 56474952,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 126.37199999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2037.5930000000153,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.399999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.90100000000007,
"heapDeltaBytes": 5632696,
"heapUsedBytes": 72129872,
"domNodes": 20,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 6.6770000000000005,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1990.8770000000686,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.667999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.593,
"heapDeltaBytes": 5434940,
"heapUsedBytes": 72145604,
"domNodes": 20,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 7.020999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.642999999985,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.279,
"layouts": 16,
"layoutDurationMs": 4.042000000000001,
"taskDurationMs": 742.2610000000001,
"heapDeltaBytes": -3799536,
"heapUsedBytes": 62819976,
"domNodes": 65,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 82.71199999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.3080000000646,
"styleRecalcs": 79,
"styleRecalcDurationMs": 37.616,
"layouts": 16,
"layoutDurationMs": 4.075,
"taskDurationMs": 782.378,
"heapDeltaBytes": -3726764,
"heapUsedBytes": 62819528,
"domNodes": 65,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 85.647,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1433.9259999999285,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.751,
"layouts": 14,
"layoutDurationMs": 12.642000000000001,
"taskDurationMs": 965.4550000000002,
"heapDeltaBytes": -5751420,
"heapUsedBytes": 78339200,
"domNodes": 13673,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 18.598999999999997,
"eventListeners": 2375,
"totalBlockingTimeMs": 147,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8295.884999999998,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.592,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4180.584,
"heapDeltaBytes": 21833248,
"heapUsedBytes": 83014720,
"domNodes": -281,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 1074.491,
"eventListeners": -165,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8720.894000000044,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.63999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4547.656,
"heapDeltaBytes": 26032592,
"heapUsedBytes": 87392536,
"domNodes": -281,
"jsHeapTotalBytes": 6057984,
"scriptDurationMs": 1228.019,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17449.393999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16661.832000000002,
"heapDeltaBytes": -29108988,
"heapUsedBytes": 169214820,
"domNodes": -8312,
"jsHeapTotalBytes": -9641984,
"scriptDurationMs": 124.96300000000001,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16997.450999999957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16389.126999999997,
"heapDeltaBytes": -27918864,
"heapUsedBytes": 172419324,
"domNodes": -8341,
"jsHeapTotalBytes": -9637888,
"scriptDurationMs": 106.00699999999999,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21006.347000000005,
"styleRecalcs": 169,
"styleRecalcDurationMs": 17.23000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20317.189,
"heapDeltaBytes": -13960792,
"heapUsedBytes": 186343180,
"domNodes": -8312,
"jsHeapTotalBytes": -16785408,
"scriptDurationMs": 416.818,
"eventListeners": -16381,
"totalBlockingTimeMs": 53,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20647.21099999997,
"styleRecalcs": 168,
"styleRecalcDurationMs": 18.05899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20041.389,
"heapDeltaBytes": -13700840,
"heapUsedBytes": 186638844,
"domNodes": -8312,
"jsHeapTotalBytes": -13639680,
"scriptDurationMs": 395.26700000000005,
"eventListeners": -16383,
"totalBlockingTimeMs": 108,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 463.25000000001637,
"styleRecalcs": 13,
"styleRecalcDurationMs": 18.375999999999998,
"layouts": 3,
"layoutDurationMs": 0.6280000000000001,
"taskDurationMs": 107.549,
"heapDeltaBytes": 4977920,
"heapUsedBytes": 70442424,
"domNodes": 126,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 6.781999999999998,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 113.23000000004413,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.523,
"layouts": 3,
"layoutDurationMs": 1.3319999999999999,
"taskDurationMs": 74.844,
"heapDeltaBytes": 2917748,
"heapUsedBytes": 68460424,
"domNodes": 127,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 3.8580000000000005,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.51 #17047 +/- ##
=============================================
- Coverage 81.73% 79.17% -2.57%
=============================================
Files 1886 2213 +327
Lines 107461 112364 +4903
Branches 29430 30579 +1149
=============================================
+ Hits 87838 88963 +1125
- Misses 19274 22942 +3668
- Partials 349 459 +110
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 329 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Backport of #16535 to
core/1.51— brands Comfy Cloud partner nodes on the canvas and in the registry.Changes
python_module === 'comfy_api_nodes.nodes_comfy_cloud') inusePartitionedBadges.ts/NodeBadges.vue, plus thecomfy-cloudicon and the design-system CSS.usePartitionedBadges.test.ts— it targets the ECS-refactored composable, which isn't present on core/1.51 (same call [backport core/1.52] feat(nodes): brand Comfy Cloud partner nodes on canvas and in the registry #16728 made).badgeRendererParity.test.tsis the pre-ECS-adapted version from [backport core/1.52] feat(nodes): brand Comfy Cloud partner nodes on canvas and in the registry #16728.Review Focus
typecheckclean,badgeRendererParity.test.tspasses, format clean.References