Repository navigation
ci: surface git diff failure in e2e new-spec detection instead of swallowing it - #16705
Conversation
…llowing it Follow-up to #15660. In `playwright-video-new-tests`, the detect step piped `git diff ... | grep '\.spec\.ts$' || true` — the `|| true` swallows the whole pipeline's exit code, so a `git diff` failure (e.g. the fallback `base.sha` isn't in the local object store) reads identically to "no new specs" and silently no-ops the video job. Split into two statements so `git diff`'s own exit code trips the runner's `-e` and aborts the step instead of masking a build error as an empty result.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe E2E workflow now runs added-file discovery separately from ChangesE2E test detection
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The workflow now exposes diff failures while retaining valid no-new-spec behavior. No current merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
Full details: Description checkExplanation The description provides the change rationale, implementation details, edge-case behavior, validation evidence, and scope. It does not use every template heading exactly, but it covers the required information and is sufficiently complete. Full details: End-To-End Regression Coverage For FixesExplanation The PR changes only Full details: Website End-To-End Regression CoverageExplanation The PR changes only Full details: Adr Compliance For Entity/Litegraph ChangesExplanation The only changed file listed is ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 1914 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.68 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 558 kB (baseline 558 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 35 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 297 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-03T18:28:11.558Z",
"gitSha": "53db7d901de4b672e2a4bb1ef0fd971611cf0e47",
"branch": "ci/e2e-detect-diff-failure",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2052.324999999996,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.6759999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 630.368,
"heapDeltaBytes": 354984,
"heapUsedBytes": 70721104,
"domNodes": -284,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 12.788,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2068.2169999999473,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.645999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 607.2180000000001,
"heapDeltaBytes": -12390464,
"heapUsedBytes": 57387772,
"domNodes": -278,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 12.091999999999999,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1942.6559999999995,
"styleRecalcs": 76,
"styleRecalcDurationMs": 44.225,
"layouts": 14,
"layoutDurationMs": 5.244999999999999,
"taskDurationMs": 1004.774,
"heapDeltaBytes": 664064,
"heapUsedBytes": 69763628,
"domNodes": -288,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 159.96200000000002,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1855.197999999973,
"styleRecalcs": 74,
"styleRecalcDurationMs": 38.214,
"layouts": 14,
"layoutDurationMs": 4.559,
"taskDurationMs": 922.015,
"heapDeltaBytes": -7687336,
"heapUsedBytes": 62639532,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 154.39899999999997,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.5119999999952,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.018000000000004,
"layouts": 6,
"layoutDurationMs": 1.2570000000000001,
"taskDurationMs": 451.863,
"heapDeltaBytes": 4748972,
"heapUsedBytes": 74641000,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 16.453999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.2600000000584,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.559,
"layouts": 6,
"layoutDurationMs": 1.0510000000000004,
"taskDurationMs": 419.5679999999999,
"heapDeltaBytes": 4770716,
"heapUsedBytes": 75020048,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.651999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 832.0289999999773,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.831000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 562.0110000000001,
"heapDeltaBytes": -7482364,
"heapUsedBytes": 63021024,
"domNodes": 16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 189.68099999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 727.865999999949,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.390000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.12100000000004,
"heapDeltaBytes": -7478404,
"heapUsedBytes": 62864960,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 160.965,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.8719999999694,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.6259999999999972,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 724.2099999999999,
"heapDeltaBytes": -14334064,
"heapUsedBytes": 87232792,
"domNodes": -273,
"jsHeapTotalBytes": -589824,
"scriptDurationMs": 38.446,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2049.7010000000273,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.1170000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 760.378,
"heapDeltaBytes": 10089868,
"heapUsedBytes": 86241844,
"domNodes": -275,
"jsHeapTotalBytes": -888832,
"scriptDurationMs": 40.59099999999999,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2548.4409999999684,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.757,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1716.1589999999999,
"heapDeltaBytes": 22575856,
"heapUsedBytes": 88451812,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 813.685,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2422.4269999999706,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.91,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1708.8009999999997,
"heapDeltaBytes": 21565172,
"heapUsedBytes": 87645336,
"domNodes": -272,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 798.2230000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3813.3599999999888,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.795000000000003,
"layouts": 60,
"layoutDurationMs": 14.443,
"taskDurationMs": 1843.576,
"heapDeltaBytes": 8499672,
"heapUsedBytes": 76103952,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 810.446,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3747.443999999973,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.600999999999997,
"layouts": 60,
"layoutDurationMs": 13.857999999999999,
"taskDurationMs": 1784.755,
"heapDeltaBytes": 9761436,
"heapUsedBytes": 76578508,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 785.62,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3185.3249999999775,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.697000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2047.7099999999998,
"heapDeltaBytes": 25511088,
"heapUsedBytes": 93429032,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1001.382,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3181.551000000013,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.745,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2051.4770000000003,
"heapDeltaBytes": 17781352,
"heapUsedBytes": 85109844,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 993.7550000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2045.9940000000074,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.6950000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 756.077,
"heapDeltaBytes": -16068172,
"heapUsedBytes": 87423096,
"domNodes": -270,
"jsHeapTotalBytes": -1638400,
"scriptDurationMs": 43.313,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2041.1139999999932,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.239,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 615.4440000000001,
"heapDeltaBytes": -14977616,
"heapUsedBytes": 88534692,
"domNodes": -267,
"jsHeapTotalBytes": -1376256,
"scriptDurationMs": 36.904999999999994,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 669.3500000000085,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.847,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.59099999999995,
"heapDeltaBytes": 14891696,
"heapUsedBytes": 87716812,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 146.87,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 636.8579999999611,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.944,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.284,
"heapDeltaBytes": 15210340,
"heapUsedBytes": 87936824,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 147.24699999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.2509999999966,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.473999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 594.16,
"heapDeltaBytes": -15461972,
"heapUsedBytes": 57430764,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 11.219,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2087.0650000000524,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.251000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 624.947,
"heapDeltaBytes": -7505640,
"heapUsedBytes": 65240996,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 11.605,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1773.8039999999842,
"styleRecalcs": 78,
"styleRecalcDurationMs": 43.445,
"layouts": 18,
"layoutDurationMs": 6.397,
"taskDurationMs": 913.757,
"heapDeltaBytes": -16084580,
"heapUsedBytes": 56834988,
"domNodes": -293,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 115.067,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1804.6009999999342,
"styleRecalcs": 78,
"styleRecalcDurationMs": 42.073,
"layouts": 18,
"layoutDurationMs": 5.927,
"taskDurationMs": 881.499,
"heapDeltaBytes": -12271480,
"heapUsedBytes": 59767212,
"domNodes": -296,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 113.71700000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.0749999999916,
"styleRecalcs": 18,
"styleRecalcDurationMs": 33.43500000000001,
"layouts": 14,
"layoutDurationMs": 15.477,
"taskDurationMs": 1038.0110000000002,
"heapDeltaBytes": -9400176,
"heapUsedBytes": 84217612,
"domNodes": 13751,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 33.18300000000001,
"eventListeners": 2387,
"totalBlockingTimeMs": 147,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8859.250000000031,
"styleRecalcs": 245,
"styleRecalcDurationMs": 40.136,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6254.9400000000005,
"heapDeltaBytes": 23544192,
"heapUsedBytes": 88941076,
"domNodes": -272,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 2737.8239999999996,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8434.864999999945,
"styleRecalcs": 247,
"styleRecalcDurationMs": 39.358,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5762.231,
"heapDeltaBytes": -12824352,
"heapUsedBytes": 89276772,
"domNodes": -266,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 2575.931,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18499.466999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18218.877,
"heapDeltaBytes": -24360940,
"heapUsedBytes": 187726932,
"domNodes": -6548,
"jsHeapTotalBytes": 6758400,
"scriptDurationMs": 325.75600000000003,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17896.391999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17385.819000000003,
"heapDeltaBytes": -23894564,
"heapUsedBytes": 179742884,
"domNodes": -6548,
"jsHeapTotalBytes": 7577600,
"scriptDurationMs": 285.806,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 24264.663999999982,
"styleRecalcs": 180,
"styleRecalcDurationMs": 30.66000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24132.327,
"heapDeltaBytes": -13811820,
"heapUsedBytes": 190754076,
"domNodes": -6548,
"jsHeapTotalBytes": 2232320,
"scriptDurationMs": 1024.569,
"eventListeners": -7469,
"totalBlockingTimeMs": 295,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-large-graph-pan",
"durationMs": 23024.847000000023,
"styleRecalcs": 172,
"styleRecalcDurationMs": 24.708999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22867.743,
"heapDeltaBytes": -46706828,
"heapUsedBytes": 167082532,
"domNodes": -6548,
"jsHeapTotalBytes": -10526720,
"scriptDurationMs": 945.409,
"eventListeners": -7467,
"totalBlockingTimeMs": 240,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6815.090999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 95.163,
"layouts": 20,
"layoutDurationMs": 31.22799999999999,
"taskDurationMs": 6767.704999999999,
"heapDeltaBytes": -22846184,
"heapUsedBytes": 191051440,
"domNodes": -6548,
"jsHeapTotalBytes": -471040,
"scriptDurationMs": 160.94200000000004,
"eventListeners": -7469,
"totalBlockingTimeMs": 503,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6584.666000000084,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.11099999999998,
"layouts": 20,
"layoutDurationMs": 24.344000000000005,
"taskDurationMs": 6501.708,
"heapDeltaBytes": -29815960,
"heapUsedBytes": 180177832,
"domNodes": -6548,
"jsHeapTotalBytes": 10846208,
"scriptDurationMs": 121.227,
"eventListeners": -7471,
"totalBlockingTimeMs": 465,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9218.041999999969,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9081.140000000001,
"heapDeltaBytes": -13510040,
"heapUsedBytes": 176849924,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 153.12800000000004,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9355.539000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9200.318000000001,
"heapDeltaBytes": 24511704,
"heapUsedBytes": 180332628,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 148.69299999999996,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 119.47600000002012,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.030999999999995,
"layouts": 2,
"layoutDurationMs": 0.804,
"taskDurationMs": 74.56599999999999,
"heapDeltaBytes": 3024908,
"heapUsedBytes": 70780032,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.124000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 113.962000000015,
"styleRecalcs": 9,
"styleRecalcDurationMs": 20.674000000000007,
"layouts": 2,
"layoutDurationMs": 1.3989999999999998,
"taskDurationMs": 80.89399999999999,
"heapDeltaBytes": 3200332,
"heapUsedBytes": 72172304,
"domNodes": 111,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.343999999999999,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16705 +/- ##
==========================================
+ Coverage 80.86% 82.68% +1.82%
==========================================
Files 2448 2041 -407
Lines 124943 119006 -5937
Branches 31531 30619 -912
==========================================
- Hits 101040 98406 -2634
+ Misses 23395 20420 -2975
+ Partials 508 180 -328
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
CodeJuggernaut
left a comment
There was a problem hiding this comment.
Walked the workflow step against the current head; nothing to add.
|
Detection step fixed; required CI is green at Full context for agent readersRoot cause: the container executes the step with POSIX Evidence: |
Follow-up to #15660. Implements the non-blocking residual noted in that PR's approval review:
Change
In
playwright-video-new-tests's detect step,git diff --name-only --diff-filter=A "$DIFF_RANGE" ... | grep '\.spec\.ts$' || truepipedgit diffstraight intogrep, with|| trueguarding the whole pipeline. Under the runner'sbash -eo pipefail, that|| trueswallows agit difffailure identically to "grep matched nothing" — so if$DIFF_RANGEever references a sha that isn't in the local object store (e.g. a shallow fetch, or a base sha that's been GC'd), the step reports zero new specs instead of erroring, and the video job silently no-ops.Split into two statements:
ADDED_FILES=$(git diff ...)thenNEW_FILES=$(grep ... <<< "$ADDED_FILES" || true). Now agit difffailure trips its own exit code under-eand aborts the step with a visible error; onlygrep's "no match" case is swallowed, which is the actually-intended no-new-specs path.Evidence
Fixture-verified under the runner's real shell (
bash --noprofile --norc -eo pipefail), same style as the source PR's review:|| true)git difffailshas-new-tests=falsehas-new-tests=falsehas-new-tests=false(unchanged)has-new-tests=truehas-new-tests=true(unchanged)has-new-tests=falsehas-new-tests=false(unchanged)Commands run:
No behavior change on any of the five outcomes #15660 already verified (all-green, video-skipped, real failure, cancelled, should-run false) — this only changes what happens when the diff command itself errors, which was previously unreachable/silent.