Skip to content

ci: stop e2e blaming PRs for the base branch's specs and for cancellations - #15660

Merged
christian-byrne merged 6 commits into
mainfrom
ci/new-spec-detection-base
Sep 2, 2026
Merged

christian-byrne merged 6 commits into
mainfrom
ci/new-spec-detection-base

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Aug 23, 2026 •

Copy link
Copy Markdown
Contributor

Two defects in ci-tests-e2e.yaml that both made this workflow blame a PR for something it did not do. Same file, so they are one PR.

1. New-spec detection uses a base that never moves

playwright-video-new-tests runs the spec files a PR adds. On a branch whose base is stale it instead runs specs other people merged, and fails on them.

github.event.pull_request.base.sha is recorded when the PR opens and does not advance with the base branch. actions/checkout leaves HEAD at refs/pull/N/merge, which already contains everything the base gained since. Three-dot diffing the merge commit against that frozen SHA therefore reports the base's own additions as added by the PR.

Measured on #14073, using the exact merge commit from its run (a580416262, logged as Merge 957bfb36d2 into b2d6e414df), branch point 2026-07-23:

detection new spec files
git diff --diff-filter=A $BASE_SHA...HEAD (before) 22
git diff --diff-filter=A HEAD^1 HEAD (after) 0

22 matches that run's NEW_SPEC_FILES list exactly, and 0 is correct — 14073 modifies previewAsText.spec.ts and adds no spec. The job failed on subgraphResizePreservation.spec.ts, which came from #14461. Rebasing "fixed" it, which is why this reads as flakiness rather than a bug. It gets worse the longer a branch lives.

2. A cancelled run is reported as a failed one

e2e-status funnels cancelled into the same branch as failure and prints E2E failed. Since e2e-status is a required check, a cancelled run leaves a red required check with a message asserting the tests failed. On 14073 this cost real time chasing a failure that never happened — run 31986467016 was cancelled 50s in, and the PR looked broken.

Still exits non-zero: merging without e2e having run would be a false green. Only the diagnosis changes, plus the three job results are now echoed — the old message named none of them, so you could not tell which leg failed without opening the run.

upload-e2e-coverage already special-cases cancelled, so the distinction exists in this file; the status gate just did not make it.

Verified across all five outcomes (all-green, video-skipped, real failure, cancelled, should-run false) — exit codes unchanged except that cancelled now says so.

pull_request.base.sha is fixed when the PR opens and does not follow the base branch, so a long-lived branch attributes every spec the base gained since then to itself. HEAD is refs/pull/N/merge, whose first parent is the base tip actually merged onto.
@christian-byrne
christian-byrne requested a review from a team August 23, 2026 01:20
@christian-byrne christian-byrne self-assigned this Aug 23, 2026
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 23, 2026
@coderabbitai

coderabbitai Bot commented Aug 23, 2026 •

Copy link
Copy Markdown
Contributor

Important

Approval pending

CodeRabbit has no unresolved comments, but it has not reviewed the latest commit.

Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 23, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1889 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1868 / ❌ 0 / ⚠️ 2 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle: 9.66 MB gzip ⚪ 0 B

Details

Summary

  • Raw size: 41 MB baseline 41 MB — ⚪ 0 B
  • Gzip: 9.66 MB baseline 9.66 MB — ⚪ 0 B
  • Brotli: 6.8 MB baseline 6.8 MB — ⚪ 0 B
  • Bundles: 447 current • 447 baseline

Category Glance
Vendor & Third-Party ⚪ 0 B (18.1 MB) · Other ⚪ 0 B (16.3 MB) · Data & Services ⚪ 0 B (3.58 MB) · Graph Workspace ⚪ 0 B (1.4 MB) · Panels & Settings ⚪ 0 B (621 kB) · Utilities & Hooks ⚪ 0 B (555 kB) · + 5 more

App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 B

Main entry bundles and manifests

Status: 1 unchanged

Graph Workspace — 1.4 MB (baseline 1.4 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

Status: 3 unchanged

Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

Status: 17 unchanged

Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

Status: 27 unchanged

User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

Status: 11 unchanged

Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

Status: 8 unchanged

UI Components — 115 kB (baseline 115 kB) • ⚪ 0 B

Reusable component library chunks

Status: 15 unchanged

Data & Services — 3.58 MB (baseline 3.58 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

Status: 17 unchanged

Utilities & Hooks — 555 kB (baseline 555 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

Status: 36 unchanged

Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 18 unchanged

Other — 16.3 MB (baseline 16.3 MB) • ⚪ 0 B

Bundles that do not match a named category

Status: 294 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.8 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.1 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.9 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.8 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 113ms TBT · 94.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.7 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 166.8 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 184ms TBT · 161.6 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 458ms TBT · 174.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.5 MB heap

⚠️ 9 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
canvas-idle: task duration 539ms 543ms +1% ⚠️ z=4.8
canvas-mouse-sweep: layout duration 5ms 4ms -9% ⚠️ z=4.4
canvas-zoom-sweep: layout duration 1ms 1ms -14% ⚠️ z=9.3
dom-widget-clipping: task duration 464ms 435ms -6% ⚠️ z=4.3
dom-widget-clipping: script duration 156ms 152ms -2% ⚠️ z=25.9
large-graph-pan: task duration 1696ms 1563ms -8% ⚠️ z=11.2
large-graph-pan: script duration 800ms 773ms -3% ⚠️ z=18.5
subgraph-idle: task duration 541ms 483ms -11% ⚠️ z=3.6
workflow-execution: event listeners 99 74 -25% ⚠️ z=5.1
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms -0% z=-0.5
canvas-idle: p95 frame time 17ms 17ms +1% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 9ms 8ms -16% z=-3.4
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 10 10 +0% z=-2.1
canvas-idle: task duration 539ms 543ms +1% ⚠️ z=4.8
canvas-idle: script duration 11ms 9ms -18% z=-7.4
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 57.5 MB 61.6 MB +7% —
canvas-idle: DOM nodes -280 -278 -1% z=-235.3
canvas-idle: event listeners -155 -172 +11% z=-38.8
canvas-mouse-sweep: avg frame time 17ms 17ms -0% z=-0.9
canvas-mouse-sweep: p95 frame time 17ms 17ms +1% —
canvas-mouse-sweep: layout duration 5ms 4ms -9% ⚠️ z=4.4
canvas-mouse-sweep: style recalc duration 41ms 37ms -11% z=-1.8
canvas-mouse-sweep: layout count 14 14 +0% —
canvas-mouse-sweep: style recalc count 77 77 -1% z=-0.9
canvas-mouse-sweep: task duration 939ms 846ms -10% z=-0.3
canvas-mouse-sweep: script duration 149ms 140ms -6% z=0.7
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 68.9 MB 59.9 MB -13% —
canvas-mouse-sweep: DOM nodes -281 -280 -0% z=-132.3
canvas-mouse-sweep: event listeners -187 -155 -17% z=-39.2
canvas-zoom-sweep: avg frame time 17ms 17ms -0% z=-0.3
canvas-zoom-sweep: p95 frame time 17ms 17ms +0% —
canvas-zoom-sweep: layout duration 1ms 1ms -14% ⚠️ z=9.3
canvas-zoom-sweep: style recalc duration 17ms 17ms -5% z=-1.7
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 32 33 +2% z=2.7
canvas-zoom-sweep: task duration 396ms 352ms -11% z=1.1
canvas-zoom-sweep: script duration 13ms 11ms -19% z=-5.5
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 65.0 MB 70.8 MB +9% —
canvas-zoom-sweep: DOM nodes 76 79 +3% z=-0.9
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.9
dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.2
dom-widget-clipping: p95 frame time 17ms 17ms -0% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 9ms 6ms -25% z=-4.3
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 11 11 -5% z=-5.2
dom-widget-clipping: task duration 464ms 435ms -6% ⚠️ z=4.3
dom-widget-clipping: script duration 156ms 152ms -2% ⚠️ z=25.9
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 83.9 MB 83.8 MB -0% —
dom-widget-clipping: DOM nodes 18 17 -6% z=-3.6
dom-widget-clipping: event listeners 2 2 +0% variance too high
large-graph-idle: avg frame time 17ms 17ms +0% z=-0.6
large-graph-idle: p95 frame time 17ms 17ms +0% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 5ms 4ms -14% z=-7.6
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 5 5 +0% z=-21.0
large-graph-idle: task duration 634ms 581ms -8% z=0.7
large-graph-idle: script duration 35ms 34ms -2% z=-6.5
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 82.5 MB 82.5 MB -0% —
large-graph-idle: DOM nodes -268 -270 +1% z=-326.0
large-graph-idle: event listeners -155 -169 +9% z=-32.0
large-graph-pan: avg frame time 17ms 17ms +0% z=0.3
large-graph-pan: p95 frame time 17ms 17ms +0% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 12ms 12ms -1% z=-7.2
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 66 65 -2% z=-7.9
large-graph-pan: task duration 1696ms 1563ms -8% ⚠️ z=11.2
large-graph-pan: script duration 800ms 773ms -3% ⚠️ z=18.5
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 84.3 MB 78.8 MB -7% —
large-graph-pan: DOM nodes -274 -123 -55% z=-85.8
large-graph-pan: event listeners -183 -90 -51% z=-114.0
large-graph-zoom: avg frame time 17ms 17ms +0% —
large-graph-zoom: p95 frame time 17ms 17ms +0% —
large-graph-zoom: layout duration 13ms 13ms +2% —
large-graph-zoom: style recalc duration 10ms 13ms +30% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 60 61 +2% —
large-graph-zoom: task duration 1737ms 1670ms -4% —
large-graph-zoom: script duration 759ms 752ms -1% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 75.8 MB 70.1 MB -8% —
large-graph-zoom: DOM nodes 0 -127 — —
large-graph-zoom: event listeners 8 -86 -1169% —
legacy-node-drag: avg frame time 17ms 17ms -0% —
legacy-node-drag: p95 frame time 17ms 17ms -0% —
legacy-node-drag: layout duration 0ms 0ms +0% —
legacy-node-drag: style recalc duration 5ms 5ms +11% —
legacy-node-drag: layout count 0 0 +0% —
legacy-node-drag: style recalc count 40 40 +0% —
legacy-node-drag: task duration 1968ms 1883ms -4% —
legacy-node-drag: script duration 927ms 946ms +2% —
legacy-node-drag: TBT 0ms 0ms +0% —
legacy-node-drag: heap used 84.9 MB 86.9 MB +2% —
legacy-node-drag: DOM nodes 0 0 +0% —
legacy-node-drag: event listeners 188 188 +0% —
minimap-idle: avg frame time 17ms 17ms -0% z=-0.4
minimap-idle: p95 frame time 17ms 17ms -0% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 1ms 2ms +162% z=-8.9
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 1 3 +200% z=-9.6
minimap-idle: task duration 600ms 538ms -10% z=0.2
minimap-idle: script duration 38ms 30ms -21% z=-6.8
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 84.1 MB 83.8 MB -0% —
minimap-idle: DOM nodes -278 -274 -1% z=-214.3
minimap-idle: event listeners 4 4 +0% z=-0.9
subgraph-dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.1
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms +0% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 11ms 10ms -10% z=-3.3
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 46 46 +0% z=-3.3
subgraph-dom-widget-clipping: task duration 423ms 391ms -8% z=0.7
subgraph-dom-widget-clipping: script duration 141ms 136ms -3% z=1.3
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 83.0 MB 81.9 MB -1% —
subgraph-dom-widget-clipping: DOM nodes 18 18 +0% z=-3.7
subgraph-dom-widget-clipping: event listeners 8 8 +0% z=-1.4
subgraph-idle: avg frame time 17ms 17ms +0% z=0.4
subgraph-idle: p95 frame time 17ms 17ms -1% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 8ms 8ms -7% z=-3.7
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 9 10 +11% z=-1.4
subgraph-idle: task duration 541ms 483ms -11% ⚠️ z=3.6
subgraph-idle: script duration 10ms 8ms -23% z=-4.8
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 60.8 MB 66.7 MB +10% —
subgraph-idle: DOM nodes -296 -296 -0% z=-212.2
subgraph-idle: event listeners -199 -215 +8% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms -0% z=-0.1
subgraph-mouse-sweep: p95 frame time 17ms 17ms -0% —
subgraph-mouse-sweep: layout duration 5ms 5ms -9% z=0.6
subgraph-mouse-sweep: style recalc duration 37ms 34ms -9% z=-2.6
subgraph-mouse-sweep: layout count 18 18 +0% —
subgraph-mouse-sweep: style recalc count 77 77 +0% z=-1.6
subgraph-mouse-sweep: task duration 919ms 799ms -13% z=0.5
subgraph-mouse-sweep: script duration 105ms 99ms -5% z=-0.2
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 57.6 MB 57.8 MB +1% —
subgraph-mouse-sweep: DOM nodes -296 -297 +0% z=-162.9
subgraph-mouse-sweep: event listeners -201 -201 +0% variance too high
subgraph-transition-enter: avg frame time 17ms 17ms -0% —
subgraph-transition-enter: p95 frame time 17ms 17ms -0% —
subgraph-transition-enter: layout duration 14ms 14ms -1% —
subgraph-transition-enter: style recalc duration 29ms 30ms +2% —
subgraph-transition-enter: layout count 15 14 -7% —
subgraph-transition-enter: style recalc count 19 18 -5% —
subgraph-transition-enter: task duration 963ms 898ms -7% —
subgraph-transition-enter: script duration 31ms 28ms -12% —
subgraph-transition-enter: TBT 130ms 113ms -13% —
subgraph-transition-enter: heap used 99.9 MB 94.6 MB -5% —
subgraph-transition-enter: DOM nodes 13751 13751 +0% —
subgraph-transition-enter: event listeners 2383 2381 -0% —
viewport-pan-sweep: avg frame time 17ms 17ms +0% —
viewport-pan-sweep: p95 frame time 17ms 17ms +0% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 38ms 39ms +5% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 247 248 +0% —
viewport-pan-sweep: task duration 5995ms 5565ms -7% —
viewport-pan-sweep: script duration 2618ms 2542ms -3% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 80.8 MB 85.7 MB +6% —
viewport-pan-sweep: DOM nodes -270 -268 -1% —
viewport-pan-sweep: event listeners -137 -169 +23% —
vue-large-graph-idle: avg frame time 18ms 18ms +0% —
vue-large-graph-idle: p95 frame time 17ms 17ms -0% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 15216ms 16925ms +11% —
vue-large-graph-idle: script duration 244ms 311ms +27% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 166.0 MB 166.8 MB +0% —
vue-large-graph-idle: DOM nodes -6548 -6548 +0% —
vue-large-graph-idle: event listeners -7475 -7473 -0% —
vue-large-graph-pan: avg frame time 18ms 18ms +0% —
vue-large-graph-pan: p95 frame time 17ms 17ms -0% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 17ms 20ms +15% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 138 176 +27% —
vue-large-graph-pan: task duration 18420ms 21402ms +16% —
vue-large-graph-pan: script duration 886ms 928ms +5% —
vue-large-graph-pan: TBT 41ms 184ms +349% —
vue-large-graph-pan: heap used 168.1 MB 161.6 MB -4% —
vue-large-graph-pan: DOM nodes -6548 -6548 +0% —
vue-large-graph-pan: event listeners -7471 -7470 -0% —
vue-node-resize-workload: avg frame time 18ms 18ms +0% —
vue-node-resize-workload: p95 frame time 17ms 17ms +0% —
vue-node-resize-workload: layout duration 25ms 24ms -5% —
vue-node-resize-workload: style recalc duration 79ms 74ms -7% —
vue-node-resize-workload: layout count 20 20 +0% —
vue-node-resize-workload: style recalc count 20 20 +0% —
vue-node-resize-workload: task duration 5582ms 6210ms +11% —
vue-node-resize-workload: script duration 103ms 116ms +12% —
vue-node-resize-workload: TBT 303ms 458ms +51% —
vue-node-resize-workload: heap used 169.9 MB 174.5 MB +3% —
vue-node-resize-workload: DOM nodes -6548 -6548 +0% —
vue-node-resize-workload: event listeners -7471 -7470 -0% —
workflow-execution: avg frame time 17ms 17ms -0% z=0.1
workflow-execution: p95 frame time 17ms 17ms -1% —
workflow-execution: layout duration 1ms 1ms -18% z=-5.1
workflow-execution: style recalc duration 18ms 18ms -2% z=-2.9
workflow-execution: layout count 3 3 -17% z=-4.5
workflow-execution: style recalc count 10 9 -10% z=-4.3
workflow-execution: task duration 96ms 87ms -9% z=-3.3
workflow-execution: script duration 8ms 6ms -20% z=-7.8
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 69.5 MB 68.5 MB -1% —
workflow-execution: DOM nodes 121 115 -5% z=-6.5
workflow-execution: event listeners 99 74 -25% ⚠️ z=5.1
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-09-01T08:24:06.744Z",
  "gitSha": "e959bc020f45bdb29d123850229819c4965c6712",
  "branch": "ci/new-spec-detection-base",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2120.342999999991,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.718000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 599.8840000000001,
      "heapDeltaBytes": -1448968,
      "heapUsedBytes": 67761296,
      "domNodes": -277,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 9.400000000000002,
      "eventListeners": -189,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2055.676999999946,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.864000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 486.10300000000007,
      "heapDeltaBytes": -8671204,
      "heapUsedBytes": 61401848,
      "domNodes": -278,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.347,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1800.8479999999736,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 34.807,
      "layouts": 14,
      "layoutDurationMs": 4.261,
      "taskDurationMs": 838.5169999999999,
      "heapDeltaBytes": -7439304,
      "heapUsedBytes": 62435140,
      "domNodes": -281,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 138.97400000000002,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1856.9599999999582,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 39.311,
      "layouts": 14,
      "layoutDurationMs": 4.680999999999999,
      "taskDurationMs": 852.982,
      "heapDeltaBytes": -6930548,
      "heapUsedBytes": 63269000,
      "domNodes": -279,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 141.12199999999999,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1667.6119999999628,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 16.786999999999995,
      "layouts": 6,
      "layoutDurationMs": 1.0700000000000003,
      "taskDurationMs": 353.38000000000005,
      "heapDeltaBytes": 4359348,
      "heapUsedBytes": 74545640,
      "domNodes": 80,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 10.321,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1723.1009999999287,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.308,
      "layouts": 6,
      "layoutDurationMs": 1.053,
      "taskDurationMs": 351.371,
      "heapDeltaBytes": 4404812,
      "heapUsedBytes": 73877404,
      "domNodes": 77,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 11.075999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 658.3590000000186,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.754,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 438.399,
      "heapDeltaBytes": 18160936,
      "heapUsedBytes": 88147496,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 153.255,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 631.1589999999114,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.107999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 432.02900000000005,
      "heapDeltaBytes": 17800792,
      "heapUsedBytes": 87661128,
      "domNodes": 16,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 150.848,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2019.5120000000202,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.447000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 557.762,
      "heapDeltaBytes": 22158992,
      "heapUsedBytes": 87044544,
      "domNodes": -269,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 34.178,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2037.9840000000513,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.064000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 603.5180000000001,
      "heapDeltaBytes": 10352824,
      "heapUsedBytes": 85939644,
      "domNodes": -271,
      "jsHeapTotalBytes": -2179072,
      "scriptDurationMs": 33.717999999999996,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2210.3669999999624,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 10.884000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1551.1019999999999,
      "heapDeltaBytes": 22266136,
      "heapUsedBytes": 88070648,
      "domNodes": 2,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 774.7120000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2171.3479999999663,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.248999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1575.1529999999998,
      "heapDeltaBytes": 2136504,
      "heapUsedBytes": 77156236,
      "domNodes": -247,
      "jsHeapTotalBytes": -380928,
      "scriptDurationMs": 771.9449999999999,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3520.380999999986,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 15.681000000000001,
      "layouts": 60,
      "layoutDurationMs": 12.823999999999998,
      "taskDurationMs": 1712.132,
      "heapDeltaBytes": -2236148,
      "heapUsedBytes": 71635028,
      "domNodes": -254,
      "jsHeapTotalBytes": -1130496,
      "scriptDurationMs": 762.765,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3427.287999999976,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.598000000000003,
      "layouts": 60,
      "layoutDurationMs": 12.925999999999998,
      "taskDurationMs": 1627.149,
      "heapDeltaBytes": 7697608,
      "heapUsedBytes": 75310788,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 742.024,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3117.9610000000366,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.618999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1911.5650000000003,
      "heapDeltaBytes": 23433936,
      "heapUsedBytes": 92926976,
      "domNodes": 0,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 962.5039999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3070.194000000015,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.3629999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1854.002,
      "heapDeltaBytes": 21642228,
      "heapUsedBytes": 89267832,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 929.03,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2004.8360000000116,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.309000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 536.8779999999998,
      "heapDeltaBytes": 22133088,
      "heapUsedBytes": 88128228,
      "domNodes": -275,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 30.96,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2004.613000000063,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.2450000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 539.8779999999999,
      "heapDeltaBytes": 21811700,
      "heapUsedBytes": 87672968,
      "domNodes": -273,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 29.932000000000006,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 572.7800000000229,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 8.908000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 391.806,
      "heapDeltaBytes": 14057632,
      "heapUsedBytes": 86105720,
      "domNodes": 16,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 137.126,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 585.6919999999946,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.281,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 389.49899999999997,
      "heapDeltaBytes": 14064452,
      "heapUsedBytes": 85644116,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 135.39700000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.3860000000304,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.297000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 481.626,
      "heapDeltaBytes": -7658648,
      "heapUsedBytes": 64280384,
      "domNodes": -295,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.459999999999998,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2013.8820000000806,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.707000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 483.756,
      "heapDeltaBytes": 3186852,
      "heapUsedBytes": 75588536,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.66,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1715.6520000000341,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 33.052,
      "layouts": 18,
      "layoutDurationMs": 4.8999999999999995,
      "taskDurationMs": 781.547,
      "heapDeltaBytes": -10436684,
      "heapUsedBytes": 61776328,
      "domNodes": -297,
      "jsHeapTotalBytes": 3923968,
      "scriptDurationMs": 95.671,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1735.433999999941,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 34.552,
      "layouts": 18,
      "layoutDurationMs": 4.915,
      "taskDurationMs": 815.823,
      "heapDeltaBytes": -12581904,
      "heapUsedBytes": 59530916,
      "domNodes": -297,
      "jsHeapTotalBytes": 7069696,
      "scriptDurationMs": 103.302,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1383.2689999999275,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 29.933999999999994,
      "layouts": 14,
      "layoutDurationMs": 14.033999999999997,
      "taskDurationMs": 898.2209999999999,
      "heapDeltaBytes": 26474776,
      "heapUsedBytes": 99208100,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 27.567,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 113,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8261.513999999977,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 39.324,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5618.848,
      "heapDeltaBytes": 15238868,
      "heapUsedBytes": 90590812,
      "domNodes": -268,
      "jsHeapTotalBytes": -1429504,
      "scriptDurationMs": 2589.3390000000004,
      "eventListeners": -169,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8248.919999999998,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 39.196000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5511.872,
      "heapDeltaBytes": 13854080,
      "heapUsedBytes": 89177048,
      "domNodes": -268,
      "jsHeapTotalBytes": -643072,
      "scriptDurationMs": 2495.017,
      "eventListeners": -169,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17766.530000000046,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17034.412,
      "heapDeltaBytes": -36779212,
      "heapUsedBytes": 174110008,
      "domNodes": -6548,
      "jsHeapTotalBytes": 516096,
      "scriptDurationMs": 315.32500000000005,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17515.415000000074,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16815.822999999997,
      "heapDeltaBytes": -34676752,
      "heapUsedBytes": 175608728,
      "domNodes": -6548,
      "jsHeapTotalBytes": 4235264,
      "scriptDurationMs": 306.94300000000004,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21780.309999999987,
      "styleRecalcs": 175,
      "styleRecalcDurationMs": 20.098000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21386.132,
      "heapDeltaBytes": -40507128,
      "heapUsedBytes": 162437092,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1040384,
      "scriptDurationMs": 919.853,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 215,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21821.002000000022,
      "styleRecalcs": 176,
      "styleRecalcDurationMs": 19.603000000000037,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21417.620999999996,
      "heapDeltaBytes": -31728048,
      "heapUsedBytes": 176476592,
      "domNodes": -6548,
      "jsHeapTotalBytes": -3805184,
      "scriptDurationMs": 935.207,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 153,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6273.392000000002,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 74.882,
      "layouts": 20,
      "layoutDurationMs": 24.077,
      "taskDurationMs": 6164.852,
      "heapDeltaBytes": -18420180,
      "heapUsedBytes": 184881432,
      "domNodes": -6548,
      "jsHeapTotalBytes": 10481664,
      "scriptDurationMs": 116.81099999999999,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 500,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6404.15900000005,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 72.68599999999998,
      "layouts": 20,
      "layoutDurationMs": 23.88499999999999,
      "taskDurationMs": 6254.965999999999,
      "heapDeltaBytes": -32560240,
      "heapUsedBytes": 181098508,
      "domNodes": -6548,
      "jsHeapTotalBytes": 11624448,
      "scriptDurationMs": 114.745,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 415,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 111.60599999993792,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 13.761000000000001,
      "layouts": 2,
      "layoutDurationMs": 0.6659999999999999,
      "taskDurationMs": 70.16399999999999,
      "heapDeltaBytes": 3149900,
      "heapUsedBytes": 71020440,
      "domNodes": 110,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 5.0630000000000015,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 464.5989999999074,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 22.004,
      "layouts": 3,
      "layoutDurationMs": 0.9479999999999998,
      "taskDurationMs": 104.523,
      "heapDeltaBytes": 5045260,
      "heapUsedBytes": 72650728,
      "domNodes": 119,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.001999999999998,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 47977 70456 68.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.3% 398
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.4% 258
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 44.7% 204

@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Aug 23, 2026
A cancelled run lands in the failure branch, so e2e-status prints 'E2E failed' and a required check goes red for something that never ran. Still exits non-zero, since merging without e2e would be a false green. Also echoes the three job results, which the old message omitted.
@christian-byrne christian-byrne changed the title ci: detect new spec files against the merged base, not the stale PR base ci: stop e2e blaming PRs for the base branch's specs and for cancellations Aug 23, 2026
@codecov

codecov Bot commented Aug 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #15660      +/-   ##
==========================================
+ Coverage   79.38%   82.98%   +3.60%     
==========================================
  Files        2217     2059     -158     
  Lines      112241   118391    +6150     
  Branches    35106    36535    +1429     
==========================================
+ Hits        89100    98251    +9151     
+ Misses      22662    19784    -2878     
+ Partials      479      356     -123     
Flag Coverage Δ
e2e 66.63% <ø> (-0.79%) ⬇️
unit 76.29% <ø> (+2.85%) ⬆️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 891 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Root-cause analysis checks out. refs/pull/N/merge has the current base tip as parent 1, so base.sha is always an ancestor of it — three-dot degenerates to two-dot and the base's own additions get attributed to the PR. HEAD^1 is the right base. I re-ran the gate script under the runner's default shell (bash -eo pipefail) across all five outcomes and the exit codes are as claimed.

Two gaps below, both in the cancellation half. Neither blocks.

Severity Count
BLOCKER 0
SHOULD FIX 2
TRIVIAL 2

Comment thread .github/workflows/ci-tests-e2e.yaml Resolved
Comment thread .github/workflows/ci-tests-e2e.yaml Resolved
Comment thread .github/workflows/ci-tests-e2e.yaml Resolved
Comment thread .github/workflows/ci-tests-e2e.yaml Resolved
@benceruleanlu

Copy link
Copy Markdown
Member

@christian-byrne I saw @benjcooley give a review so I'm assigning you back to this PR, when you're done you can reassign @benjcooley

@christian-byrne

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@huang47 huang47 added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@christian-byrne
christian-byrne removed the request for review from ryan-di September 2, 2026 11:51

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed the four follow-up commits (3b609ed, c62b427, bc665cb, f7ac5c9). All four items are genuinely fixed, not papered over. Approving.

I re-ran the revised gate under the runner's real shell (bash --noprofile --norc -eo pipefail) across nine outcomes, and built git fixtures for the range changes rather than reasoning about them:

scenario result
all green E2E passed, exit 0
video skipped (push/merge_group) E2E passed, exit 0
intentional path skip E2E skipped, exit 0
real failure E2E failed, exit 1
pure cancellation E2E cancelled, not failed, exit 1
mixed failure + cancellation E2E failed, exit 1
changes cancelled changes gate did not complete (cancelled), exit 1
changes failed changes gate did not complete (failure), exit 1
setup failed (all skipped) E2E failed, exit 1

The mixed row is the one that mattered — it now reports the failure instead of sending someone to burn a rerun.

On the fail-closed gate: I checked changes-filter's should-run, which is ${{ github.event_name != 'pull_request' || ... }}. That expression can only ever produce the literal "true" or "false", never empty, so gating on needs.changes.result == 'success' fully closes the false-green hole rather than narrowing it. Good.

On the diff range: I confirmed with a fixture that the round-1 two-dot fallback really did misreport — a spec file the base deleted after the branch point came back as A alongside the PR's own file. The restored three-dot form returns only the PR's file. Also verified git diff "A..B" and git diff "A...B" as single arguments behave identically to the two-argument form, and that git rev-parse --verify --quiet HEAD^2 exits 1 silently on a non-merge HEAD, so the else branch is reached cleanly.

One non-blocking note for later, not this PR: ... | grep '\.spec\.ts$' || true on the detect line still makes "git diff failed" indistinguishable from "no new specs" — if the fallback ever runs against a sha that isn't in the local object store, the video job silently no-ops. That swallow predates this PR and the failure mode is only a missing video, so it isn't worth holding the merge. Splitting the diff from the grep would close it whenever someone next touches that step.

@christian-byrne
christian-byrne added this pull request to the merge queue Sep 2, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 2, 2026
@christian-byrne
christian-byrne added this pull request to the merge queue Sep 2, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 2, 2026
@christian-byrne
christian-byrne added this pull request to the merge queue Sep 2, 2026
Merged via the queue into main with commit 4662730 Sep 2, 2026
117 checks passed
@christian-byrne
christian-byrne deleted the ci/new-spec-detection-base branch September 2, 2026 21:06
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Follow-up carrier for the non-blocking git diff | grep || true swallow noted in the approval review: #16705.

christian-byrne added a commit that referenced this pull request Sep 4, 2026
…llowing it (#16705)

Follow-up to
[#15660](#15660).
Implements the non-blocking residual noted in [that PR's approval
review](#15660 (review)):

> `... | grep '\.spec\.ts$' || true` on the detect line still makes "git
diff failed" indistinguishable from "no new specs" — if the fallback
ever runs against a sha that isn't in the local object store, the video
job silently no-ops. That swallow predates this PR and the failure mode
is only a missing video, so it isn't worth holding the merge. Splitting
the diff from the grep would close it whenever someone next touches that
step.

## Change

In `playwright-video-new-tests`'s detect step, `git diff --name-only
--diff-filter=A "$DIFF_RANGE" ... | grep '\.spec\.ts$' || true` piped
`git diff` straight into `grep`, with `|| true` guarding the whole
pipeline. Under the runner's `bash -eo pipefail`, that `|| true`
swallows a `git diff` failure identically to "grep matched nothing" — so
if `$DIFF_RANGE` ever references a sha that isn't in the local object
store (e.g. a shallow fetch, or a base sha that's been GC'd), the step
reports zero new specs instead of erroring, and the video job silently
no-ops.

Split into two statements: `ADDED_FILES=$(git diff ...)` then
`NEW_FILES=$(grep ... <<< "$ADDED_FILES" || true)`. Now a `git diff`
failure trips its own exit code under `-e` and aborts the step with a
visible error; only `grep`'s "no match" case is swallowed, which is the
actually-intended no-new-specs path.

## Evidence

Fixture-verified under the runner's real shell (`bash --noprofile --norc
-eo pipefail`), same style as the source PR's review:

| scenario | before (piped, `\|\| true`) | after (split) |
| --- | --- | --- |
| `git diff` fails | swallowed — reads as `has-new-tests=false` | step
aborts (exit 1), error surfaced |
| no new specs, diff succeeds | `has-new-tests=false` |
`has-new-tests=false` (unchanged) |
| new spec found | `has-new-tests=true` | `has-new-tests=true`
(unchanged) |
| empty diff | `has-new-tests=false` | `has-new-tests=false` (unchanged)
|

Commands run:
```
bash --noprofile --norc -eo pipefail -c '... git diff | grep ... || true ...'   # reproduces the swallow
bash --noprofile --norc -eo pipefail -c '... ADDED_FILES=$(false); NEW_FILES=$(grep <<< "$ADDED_FILES" || true) ...'  # confirms split form aborts
# + no-spec / spec-found / empty-diff cases re-verified against the split form
actionlint .github/workflows/ci-tests-e2e.yaml   # no new findings (existing SC2016/SC2086 info-level notes elsewhere, untouched by this diff)
python3 -c "import yaml; yaml.safe_load(open('.github/workflows/ci-tests-e2e.yaml'))"   # YAML valid
```

No behavior change on any of the five outcomes #15660 already verified
(all-green, video-skipped, real failure, cancelled, should-run false) —
this only changes what happens when the diff command itself errors,
which was previously unreachable/silent.

<!-- authored-by:agent lane-act-fe-15660-followup-8f074af2 -->

---------

Co-authored-by: Amp <amp@ampcode.com>
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 14, 2026
…ellations (Comfy-Org#16682)

## Problem

Merge-group runs of the required `website-e2e` check were exceeding the
15-minute job timeout, silently dequeuing approved PRs:

- [Comfy-Org#15753 group
18:13Z](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/33665855796):
cancelled
- [Comfy-Org#15660 group
18:28Z](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/33667445294):
cancelled after 15m04s during Playwright
- [Passing control
run](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/33669067839):
407 tests took 8.2m, with a 9m47s total job time

On 4-core hosted runners, Playwright used two workers. Test retries and
runner variation left too little margin for checkout, install, build,
reporting, and deployment.

## Fix

Shard the Playwright run four ways instead of raising the timeout or
weakening coverage:

- `website-e2e-shard` builds and runs one quarter of the suite,
uploading a blob report.
- `website-e2e-report` requires all four reports, merges HTML and JSON
with Playwright 1.61.1, deploys the report, and distinguishes test
failures from infrastructure/reporting failures.
- `website-e2e` remains the stable required-check context and passes
only when the complete report succeeds.
- Focused script tests cover complete success, test failure, incomplete
delivery, download failure, report-merge failure, and gate behavior.

The shape follows the sharded matrix and merge-report pattern in
`ci-tests-e2e.yaml`.

## Evidence

At head `90a3bd08d6`, [run 33936522288, attempt
2](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/33936522288)
ran all four shards, downloaded all reports, merged and deployed the
report, and passed the stable `website-e2e` gate. The branch has since
been updated with `main` and hardened further; current-head checks are
the authoritative merge gate.

Local verification on the current branch:

- `pnpm test:unit scripts/cicd/website-e2e-workflow.test.ts` — 6 passed
- `pnpm typecheck:scripts` — passed
- `pnpm typecheck:website` — 0 errors
- Full pre-push checks, including format, lint, typecheck, and knip —
passed

---------

Co-authored-by: Amp <amp@ampcode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned) size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants