Repository navigation
fix(agent-crdt): remove deleted follower widgets - #16684
Conversation
|
Important Approval pendingCodeRabbit has no unresolved comments, but it has not reviewed the latest commit. Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.
Comment |
🎭 Playwright: ✅ 1903 passed, 0 failed📊 Browser Reports
🎨 Storybook: ❌ FailedDetails⏰ Completed at: 09/02/2026, 08:22:52 PM UTC Links
📦 Bundle: 9.68 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.42 MB (baseline 1.42 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.59 MB (baseline 3.59 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 295 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-02T20:31:41.115Z",
"gitSha": "fd94c54bde9e68f44de80c1ffd5e0a3934232ff2",
"branch": "christian-byrne/op5-evfail19-widget-removal",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2077.578000000017,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.943000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 605.159,
"heapDeltaBytes": -13145248,
"heapUsedBytes": 56590768,
"domNodes": -278,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.19,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2019.6300000000065,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.036999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.33399999999995,
"heapDeltaBytes": -13279304,
"heapUsedBytes": 56490416,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.308000000000002,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1874.8500000000377,
"styleRecalcs": 79,
"styleRecalcDurationMs": 40.536,
"layouts": 14,
"layoutDurationMs": 4.444,
"taskDurationMs": 871.1059999999999,
"heapDeltaBytes": -8480584,
"heapUsedBytes": 61527200,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 157.775,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1857.7649999999721,
"styleRecalcs": 78,
"styleRecalcDurationMs": 38.333000000000006,
"layouts": 14,
"layoutDurationMs": 4.247,
"taskDurationMs": 848.044,
"heapDeltaBytes": -7854952,
"heapUsedBytes": 62715972,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 156.296,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.8969999999936,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.687999999999999,
"layouts": 6,
"layoutDurationMs": 1.0030000000000001,
"taskDurationMs": 341.233,
"heapDeltaBytes": 4421796,
"heapUsedBytes": 73459688,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.535000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1666.4970000000494,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.449000000000002,
"layouts": 6,
"layoutDurationMs": 0.9430000000000001,
"taskDurationMs": 340.656,
"heapDeltaBytes": 5118452,
"heapUsedBytes": 75732520,
"domNodes": 76,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 9.348000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 661.5900000000465,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.505,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.48199999999997,
"heapDeltaBytes": -7779456,
"heapUsedBytes": 62861772,
"domNodes": 18,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 165.65999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 649.4169999999713,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.7909999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.326,
"heapDeltaBytes": -7741208,
"heapUsedBytes": 62844820,
"domNodes": 18,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 160.95999999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2026.4740000000074,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.468,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.6239999999999,
"heapDeltaBytes": 10958588,
"heapUsedBytes": 86557340,
"domNodes": -270,
"jsHeapTotalBytes": -884736,
"scriptDurationMs": 33.043000000000006,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2072.8699999999662,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.763,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 593.0759999999999,
"heapDeltaBytes": -14027968,
"heapUsedBytes": 86996692,
"domNodes": -270,
"jsHeapTotalBytes": -847872,
"scriptDurationMs": 30.858999999999998,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2151.0660000000144,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.070000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1530.0880000000002,
"heapDeltaBytes": 21147704,
"heapUsedBytes": 87126056,
"domNodes": -270,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 767.933,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2221.2690000000066,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.633999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1606.573,
"heapDeltaBytes": -17177740,
"heapUsedBytes": 84113492,
"domNodes": -270,
"jsHeapTotalBytes": 688128,
"scriptDurationMs": 790.551,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3437.8300000000195,
"styleRecalcs": 61,
"styleRecalcDurationMs": 9.513,
"layouts": 60,
"layoutDurationMs": 11.276000000000002,
"taskDurationMs": 1619.814,
"heapDeltaBytes": 9611724,
"heapUsedBytes": 76283396,
"domNodes": -280,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 748.782,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3456.818999999996,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.796,
"layouts": 60,
"layoutDurationMs": 11.154999999999998,
"taskDurationMs": 1632.9499999999998,
"heapDeltaBytes": -26083884,
"heapUsedBytes": 77340900,
"domNodes": -274,
"jsHeapTotalBytes": -585728,
"scriptDurationMs": 747.294,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3093.4330000000045,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.582,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1846.857,
"heapDeltaBytes": 17558720,
"heapUsedBytes": 84920800,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 943.554,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2943.5029999999642,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.555000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1818.2310000000002,
"heapDeltaBytes": 17458684,
"heapUsedBytes": 84849808,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 914.8270000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2038.5540000000333,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.553999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.235,
"heapDeltaBytes": -15345252,
"heapUsedBytes": 87183084,
"domNodes": -268,
"jsHeapTotalBytes": -323584,
"scriptDurationMs": 33.114000000000004,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2016.567000000009,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.5390000000000021,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.913,
"heapDeltaBytes": 21962260,
"heapUsedBytes": 87744536,
"domNodes": -276,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 26.137000000000008,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 576.1130000000207,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.979000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.3399999999999,
"heapDeltaBytes": 15185620,
"heapUsedBytes": 87444592,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 142.974,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.654000000005,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.567999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.70000000000005,
"heapDeltaBytes": 15080852,
"heapUsedBytes": 88067144,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 141.677,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.463000000016,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.103999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.66999999999996,
"heapDeltaBytes": -8685816,
"heapUsedBytes": 64079428,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.907,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1990.4520000000048,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.166999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.348,
"heapDeltaBytes": -8664592,
"heapUsedBytes": 64084924,
"domNodes": -296,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 6.9609999999999985,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1750.144999999975,
"styleRecalcs": 78,
"styleRecalcDurationMs": 35.553000000000004,
"layouts": 18,
"layoutDurationMs": 4.926,
"taskDurationMs": 786.651,
"heapDeltaBytes": -11514932,
"heapUsedBytes": 61123432,
"domNodes": -295,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 102.01500000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.238000000014,
"styleRecalcs": 79,
"styleRecalcDurationMs": 32.439,
"layouts": 18,
"layoutDurationMs": 4.326,
"taskDurationMs": 763.023,
"heapDeltaBytes": -12439304,
"heapUsedBytes": 60302492,
"domNodes": -294,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 99.592,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.5739999999532,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.859000000000005,
"layouts": 15,
"layoutDurationMs": 15.428999999999998,
"taskDurationMs": 882.6469999999999,
"heapDeltaBytes": -7309604,
"heapUsedBytes": 86717588,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 28.932,
"eventListeners": 2381,
"totalBlockingTimeMs": 137,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8399.597000000029,
"styleRecalcs": 248,
"styleRecalcDurationMs": 33.434000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5612.529,
"heapDeltaBytes": 13097888,
"heapUsedBytes": 89110260,
"domNodes": -268,
"jsHeapTotalBytes": -397312,
"scriptDurationMs": 2625.622,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8265.569000000029,
"styleRecalcs": 247,
"styleRecalcDurationMs": 31.507,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5564.6,
"heapDeltaBytes": 8824080,
"heapUsedBytes": 84559148,
"domNodes": -270,
"jsHeapTotalBytes": -1445888,
"scriptDurationMs": 2571.1040000000003,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16040.264000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15043.806999999999,
"heapDeltaBytes": -26265944,
"heapUsedBytes": 175523192,
"domNodes": -6548,
"jsHeapTotalBytes": -3227648,
"scriptDurationMs": 233.73,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16211.801000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15163.059999999998,
"heapDeltaBytes": -35516868,
"heapUsedBytes": 174557580,
"domNodes": -6548,
"jsHeapTotalBytes": -7139328,
"scriptDurationMs": 239.37900000000002,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 19968.774999999936,
"styleRecalcs": 167,
"styleRecalcDurationMs": 15.82699999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19605.901,
"heapDeltaBytes": -41735956,
"heapUsedBytes": 166246564,
"domNodes": -6548,
"jsHeapTotalBytes": -3399680,
"scriptDurationMs": 871.346,
"eventListeners": -7467,
"totalBlockingTimeMs": 6,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20184.043999999973,
"styleRecalcs": 168,
"styleRecalcDurationMs": 16.282000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19756.046,
"heapDeltaBytes": -20815320,
"heapUsedBytes": 191452248,
"domNodes": -6548,
"jsHeapTotalBytes": -1912832,
"scriptDurationMs": 900.971,
"eventListeners": -7471,
"totalBlockingTimeMs": 52,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5735.802000000035,
"styleRecalcs": 20,
"styleRecalcDurationMs": 90.97099999999998,
"layouts": 20,
"layoutDurationMs": 21.90600000000001,
"taskDurationMs": 5655.725,
"heapDeltaBytes": -33790208,
"heapUsedBytes": 172712688,
"domNodes": -6548,
"jsHeapTotalBytes": 4771840,
"scriptDurationMs": 122.46600000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 338,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5795.120999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.82000000000001,
"layouts": 20,
"layoutDurationMs": 20.858,
"taskDurationMs": 5682.344,
"heapDeltaBytes": -27871872,
"heapUsedBytes": 177130388,
"domNodes": -6548,
"jsHeapTotalBytes": 11366400,
"scriptDurationMs": 101.02900000000001,
"eventListeners": -7473,
"totalBlockingTimeMs": 356,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8132.1590000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7711.059,
"heapDeltaBytes": 17326852,
"heapUsedBytes": 175370332,
"domNodes": 0,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 109.65900000000006,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8207.446000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7664.6179999999995,
"heapDeltaBytes": -2197992,
"heapUsedBytes": 175831792,
"domNodes": -3,
"jsHeapTotalBytes": -11272192,
"scriptDurationMs": 114.26999999999998,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 113.58900000004724,
"styleRecalcs": 8,
"styleRecalcDurationMs": 17.02,
"layouts": 3,
"layoutDurationMs": 1.724,
"taskDurationMs": 95.16000000000001,
"heapDeltaBytes": 3427932,
"heapUsedBytes": 72115048,
"domNodes": 148,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.565000000000003,
"eventListeners": 40,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 91.10799999996289,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.781,
"layouts": 2,
"layoutDurationMs": 0.972,
"taskDurationMs": 68.51699999999998,
"heapDeltaBytes": 3017588,
"heapUsedBytes": 71494300,
"domNodes": 106,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.1960000000000015,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16684 +/- ##
==========================================
+ Coverage 80.82% 82.41% +1.58%
==========================================
Files 2444 2032 -412
Lines 124795 117499 -7296
Branches 33024 31314 -1710
==========================================
- Hits 100869 96840 -4029
+ Misses 23423 20481 -2942
+ Partials 503 178 -325
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 422 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Duplicate fix in flight: #16361 (same author, same two files, open, head aae96b2) fixes the same FEC-3 stale-widget bug by tracking event.changes.keys.get(name)?.action === 'delete' in onNodesChanged and reconciling those nodes. This PR does it state-based at apply time. Both target main and will conflict on ecsFollowerAdapter.ts and the integration test; one of them should be closed or rebased onto the other. The state-based check here is the better mechanism, since it reads the map as it stands when the frame is applied, so a delete followed by a re-add of the same key inside one frame coalesces to a plain setWidget (verified locally) instead of a full reconcile.
Verified the mechanism against createGraphMutations in src/core/graph/graphMutations.ts: reconcileNode on an existing node runs widgetStore.clearNode then re-registers every widget in the payload, so it both drops the deleted key and applies the other changed names that the continue skips. A value-only change still takes setWidget and never calls clearNode (verified with a spy). Remaining gap is in the whole-map replacement branch, inline below.
Full context for agent readers
Local verification on head 6592674: pnpm exec vitest run src/workbench/extensions/agent/crdt 236 passed. Four probe tests written against the adapter: (1) replace the node's widgets Y.Map with a fresh map lacking stale and the stale widget survives with value 9 (fails, see inline issue); (2) value-only change leaves useWidgetValueStore().clearNode uncalled and applies the value; (3) delete plus re-add of stale in one frame ends with the new value and seed intact; (4) in-place delete keeps seed and the node, clearNode called once.
Reachability of the replacement gap: the applier's widgetsOf in comfy-multi-player/src/applier.ts creates the widgets Y.Map on first write, so two actors that concurrently first-write different widgets on a node with no map yet each set their own map; Yjs keeps one. A follower that already applied the losing actor's setWidget then sees a path-length-1 widgets change whose new map lacks that key, enumerates only the new keys, and keeps the loser's widget forever. The doc converges, the projection does not.
When a remote frame replaces a node's whole `widgets` map, the follower previously seeded the per-widget change set from the new map's keys only, so widgets present in the old map but absent from the new one survived in the widget store. Track replaced widget maps separately and route those nodes through `reconcileNode`, which clears and re-registers the node's widgets from the current payload. Cover the in-place delete, the same-frame delete plus re-add (which must stay on the targeted `setWidget` path), and the replaced-map case in the follower adapter integration tests.
|
Pushed 387e15e: replaced widget maps now go through Full context for agent readersThe whole-map replacement branch in Verification in the worktree: Still open for the author: #16361 (same files, event-based |
CodeJuggernaut
left a comment
There was a problem hiding this comment.
Both delete shapes reconcile and same-frame re-adds stay targeted, all pinned; LGTM.
Summary
Removes stale projected widget state when a remote CRDT update deletes one key in place from an existing widget map.
Changes
Review Focus
Please verify that full-node reconciliation is the appropriate deletion path while ordinary widget value changes retain their targeted update path.
Linear: FE-1995
Source reproducer: #16361
Verification
pnpm vitest run src/workbench/extensions/agent/crdt— 236 passedpnpm typecheckpnpm exec eslint src/workbench/extensions/agent/crdt/ecsFollowerAdapter.ts src/workbench/extensions/agent/crdt/ecsFollowerAdapter.integration.test.tspnpm exec oxfmt --check src/workbench/extensions/agent/crdt/ecsFollowerAdapter.ts src/workbench/extensions/agent/crdt/ecsFollowerAdapter.integration.test.tsScreenshots (if applicable)
Not applicable; no UI change.