Skip to content

[backport cloud/1.53] test: cover link/store contracts + fix widget-leak and perf bugs - #16679

Merged
comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-16512-to-cloud-1.53
Sep 2, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-16512-to-cloud-1.53

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backport of #16512 to cloud/1.53. Fixes promoted-widget values leaking across unrelated subgraph node instances (#16250) and nested-promotion widget registration ignoring a rejected store registration (#16013, #16251); adds the regression tests requested in #16008. The auto-backport failed only on the ADR index table; resolved by adding the ADR 0027 row and omitting the ADR 0026 row, which does not exist on this branch.

Full context for agent readers

)

Addresses part of #15973.

1. **`transformLinkReferences` (`remapLinkReferences`) coverage parity**
— parametrized `linkDeduplication.transformLinkReferences.test.ts` over
all five serialized reference-location kinds (node `input.link`, node
`output.links`, subgraph boundary `linkIds`, reroute `linkIds`,
`linkExtensions`) under both "replace" (same-origin remap) and "remove"
(different-origin prune) modes via `normalizeConfiguredTopology`. No
functional gap found — pure coverage.

2. **`LinkDedupDropMetadata` telemetry** — `LinkDedupDropMetadata` was
fully typed/documented in `src/platform/telemetry/types.ts` but never
wired to an emission call site; only `console.warn` fired. Added
`trackLinkDedupDrop` to the dispatcher and call it from
`normalizeConfiguredTopology` for different-origin drops. Tests assert
it fires exactly once with `{ droppedLinkId, survivorLinkId, target }`
independent of the `console.warn` string assertion, and does not fire
for a same-origin remap.

3. **Store collision contracts** — `storeCollisionContracts.test.ts`
(added by PR #15720 per the tracking issue) does not exist anywhere yet
— confirmed absent on `origin/main` and this branch. Added it:
`nodeDataStore`/`linkStore`/`rerouteStore` reject registration at an
occupied identity key; `widgetValueStore` resolves a collision at its
structural key (`graphId:nodeId:name`) per documented
same-type-keeps-value / different-type-overwrites semantics. Each store
already had its own collision tests (not duplicated here) but no shared
cross-store suite existed. Note: `docs/exceptions-log.md` EX-002's full
closing condition also requires ADR-text corrections (PRs #15720/#15761)
— out of scope here. Independently verified ADR-0016/0018 already match
current code (not stale as EX-002's text about "PRs #15720/#15761"
implies for an older, unlinked ADR revision).

4. **Fixes #16008** — `nodeOutputStore` output-image writes scaling
quadratically. The actual O(N²) fix (bounding
`createNodeOutputsMutationView`'s commit to the single changed key
instead of calling `replaceOutputsFromLegacy` on every write) already
landed via commit `af617ef478` (#16156), confirmed by reading
`src/scripts/app.ts`. What was missing was the regression test the issue
explicitly asks for. Added a scaling-detector test in `app.test.ts`: N
sequential output writes for N distinct nodes must each commit exactly
one `setOutputFromLegacy` call and never call
`replaceOutputsFromLegacy`. Verified it fails when the old buggy
`commit` callback is reintroduced.

5. **Fixes #16250** — promoted widget values leaking across unrelated
`SubgraphNode` instances. Root cause: `SubgraphNode._setWidget`
registered promoted widget state under `widgetId(rootGraph.id, this.id,
name)` even while `this.id` was still `UNASSIGNED_NODE_ID` during
construction, so every constructing `SubgraphNode` with the same
promoted input name shared one registration key. A discarded clipboard
clone (`LGraphCanvas`'s clone-and-serialize path never calls
`graph.add()`) could leave its value behind under that shared key,
inherited by a later unrelated same-named/typed promoted input via
`widgetValueStore`'s same-type-keeps-value collision resolution. Fix:
`_setWidget` now skips store registration while `this.id ===
UNASSIGNED_NODE_ID`; `onAdded` performs the deferred first-time
registration once a real id is assigned (extends its existing migration
loop). Updated one existing test (`SubgraphNode.test.ts`) that had
encoded the old buggy "transient widgetId during construction" behavior
as intended; added a new regression test exercising the literal
clipboard clone-and-discard path.

6. **Fixes #16013, Fixes #16251** — confirmed both issues describe the
exact same defect: `seedNestedPromotedInputState`
(`src/core/graph/subgraph/promotionUtils.ts`) assigned
`hostInput.widgetId = id` before calling `registerWidget(...)` and
ignored its return value — same defect class PR #15767 fixed in
`SubgraphNode._setWidget`. Fixed with the same pattern: capture
`registerWidget`'s return, assign `widgetId` only on success, retract
the widget locator on rejection. Exported the previously-private
function and added a direct unit test (an end-to-end nested-promotion
repro proved too coupled to `_setWidget`'s own connect-time resolution
to reliably reach this fallback path in an integration test).

- Item 4: fixed the missing regression test only; the perf fix itself
was already on `main` via an unrelated PR. Verified independently by
reading the code, not just trusting the research pass.
- Item 6: #16013 and #16251 are the same defect — one commit, both
"Fixes" lines apply, no separate handling needed.
- Item 3: did not touch `docs/exceptions-log.md` — closing EX-002 fully
requires the ADR-text-correction PRs (#15720/#15761) referenced in its
closing condition, which are out of scope for this PR.
- Item 5: updated `SubgraphNode.test.ts`'s "migrates promoted widget
bindings when added to a graph" test, since it explicitly asserted on
the old (leaky) "transient widgetId during construction" behavior as a
feature.

`pnpm test:unit` (19,354 passed, 2 pre-existing/unrelated flakes
confirmed independent — `cameraFraming.test.ts` and
`comfyIngestTypes.test.ts`, both pass in isolation and touch no file in
this diff), `pnpm typecheck`, `pnpm lint`, `pnpm format:check`, `pnpm
knip` all clean. Every fix's regression test was verified to fail
against the pre-fix code and pass against the fix.

This PR also implements the concrete deferred lifecycle item from
[#16238](#16238):
prevent promoted-widget identity/value from crossing unrelated
`SubgraphNode` instance boundaries. It covers the deferred cleanup note
in [review thread
r3898759028](#16238 (comment))
and the instance-boundary oracle requested in [the QA
follow-up](#16238 (comment)).

<!-- authored-by:agent addr-drain -->
@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned) labels Sep 2, 2026
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 22fb3b55-c1a3-4037-a4a2-da0aff451aa3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/02/2026, 06:09:12 PM UTC

Links

🎭 Playwright: ✅ 1891 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1870 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.4 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.3 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 128ms TBT · 98.1 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.8 MB heap
vue-large-graph-idle: · 54.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 160.7 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 186ms TBT · 167.5 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 488ms TBT · 172.3 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 513ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 61.8 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -170
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 47ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 83
canvas-mouse-sweep: task duration 1011ms
canvas-mouse-sweep: script duration 164ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 66.9 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -171
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 391ms
canvas-zoom-sweep: script duration 13ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.4 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 467ms
dom-widget-clipping: script duration 162ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 84.2 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 685ms
large-graph-idle: script duration 37ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.8 MB
large-graph-idle: DOM nodes -269
large-graph-idle: event listeners -154
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 63
large-graph-pan: task duration 1643ms
large-graph-pan: script duration 797ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 80.4 MB
large-graph-pan: DOM nodes 2
large-graph-pan: event listeners 5
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1785ms
large-graph-zoom: script duration 797ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.4 MB
large-graph-zoom: DOM nodes 2
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1972ms
legacy-node-drag: script duration 983ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 86.7 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 584ms
minimap-idle: script duration 34ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.8 MB
minimap-idle: DOM nodes -273
minimap-idle: event listeners -155
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 417ms
subgraph-dom-widget-clipping: script duration 144ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.3 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 531ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 59.6 MB
subgraph-idle: DOM nodes -298
subgraph-idle: event listeners -200
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 39ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 858ms
subgraph-mouse-sweep: script duration 113ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 58.3 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -200
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 972ms
subgraph-transition-enter: script duration 31ms
subgraph-transition-enter: TBT 128ms
subgraph-transition-enter: heap used 98.1 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 40ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5814ms
viewport-pan-sweep: script duration 2594ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 74.8 MB
viewport-pan-sweep: DOM nodes -271
viewport-pan-sweep: event listeners -154
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17795ms
vue-large-graph-idle: script duration 325ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 160.7 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7473
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 27ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 176
vue-large-graph-pan: task duration 23065ms
vue-large-graph-pan: script duration 983ms
vue-large-graph-pan: TBT 186ms
vue-large-graph-pan: heap used 167.5 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7467
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 25ms
vue-node-resize-workload: style recalc duration 75ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6530ms
vue-node-resize-workload: script duration 123ms
vue-node-resize-workload: TBT 488ms
vue-node-resize-workload: heap used 172.3 MB
vue-node-resize-workload: DOM nodes -6539
vue-node-resize-workload: event listeners -7470
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 24ms
workflow-execution: layout count 3
workflow-execution: style recalc count 18
workflow-execution: task duration 120ms
workflow-execution: script duration 12ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.3 MB
workflow-execution: DOM nodes 151
workflow-execution: event listeners 99
Raw data
{
  "timestamp": "2026-09-02T18:20:44.637Z",
  "gitSha": "53bce3c10b8ab813c4a566ffa94a565b87a1fd5d",
  "branch": "backport-16512-to-cloud-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2038.759999999968,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.256000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 514.651,
      "heapDeltaBytes": -10897540,
      "heapUsedBytes": 59504968,
      "domNodes": -280,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 9.884,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2037.7279999999018,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.022,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 511.72399999999993,
      "heapDeltaBytes": 540180,
      "heapUsedBytes": 70076964,
      "domNodes": -280,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 9.623,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2230.3190000000086,
      "styleRecalcs": 89,
      "styleRecalcDurationMs": 55.550000000000004,
      "layouts": 14,
      "layoutDurationMs": 5.417,
      "taskDurationMs": 1154.4660000000001,
      "heapDeltaBytes": 6437328,
      "heapUsedBytes": 76247568,
      "domNodes": -280,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 179.427,
      "eventListeners": -187,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1814.4770000000108,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 37.697,
      "layouts": 14,
      "layoutDurationMs": 4.628,
      "taskDurationMs": 867.6839999999999,
      "heapDeltaBytes": -6338904,
      "heapUsedBytes": 64126752,
      "domNodes": -280,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 147.634,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1733.2989999999882,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 18.183000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.279,
      "taskDurationMs": 384.69199999999995,
      "heapDeltaBytes": 4407764,
      "heapUsedBytes": 74755288,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 12.987999999999996,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1684.44199999999,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.455,
      "layouts": 6,
      "layoutDurationMs": 1.12,
      "taskDurationMs": 398.18699999999995,
      "heapDeltaBytes": 4440916,
      "heapUsedBytes": 74933456,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 13.336999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 662.7330000000029,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.174999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 470.596,
      "heapDeltaBytes": 18135992,
      "heapUsedBytes": 88462736,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 165.228,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 742.3330000000306,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.362000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 463.45699999999994,
      "heapDeltaBytes": 17847596,
      "heapUsedBytes": 88130572,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 158.152,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2055.1600000000008,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.642,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 717.967,
      "heapDeltaBytes": -13785744,
      "heapUsedBytes": 86819260,
      "domNodes": -268,
      "jsHeapTotalBytes": -1617920,
      "scriptDurationMs": 39.806,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2039.641999999958,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.859000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 653.0289999999999,
      "heapDeltaBytes": -13982312,
      "heapUsedBytes": 86740260,
      "domNodes": -269,
      "jsHeapTotalBytes": -2404352,
      "scriptDurationMs": 34.595,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2387.4440000000163,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 9.705999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1717.8519999999996,
      "heapDeltaBytes": 18587172,
      "heapUsedBytes": 85039772,
      "domNodes": 0,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 846.631,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2175.0679999998965,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 10.566000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1568.9070000000004,
      "heapDeltaBytes": 17677688,
      "heapUsedBytes": 83597812,
      "domNodes": 4,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 747.837,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3830.718000000047,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 11.963999999999999,
      "layouts": 60,
      "layoutDurationMs": 13.883,
      "taskDurationMs": 1846.222,
      "heapDeltaBytes": 9323528,
      "heapUsedBytes": 76378644,
      "domNodes": 2,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 832.2769999999999,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3515.470999999934,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 12.075,
      "layouts": 60,
      "layoutDurationMs": 13.691000000000003,
      "taskDurationMs": 1723.9250000000002,
      "heapDeltaBytes": 7737812,
      "heapUsedBytes": 75373288,
      "domNodes": 2,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 761.169,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3176.0249999999814,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.421999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2025.3229999999999,
      "heapDeltaBytes": 26418744,
      "heapUsedBytes": 94037688,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 1005.152,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3070.5920000000333,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.407000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1919.202,
      "heapDeltaBytes": 20061372,
      "heapUsedBytes": 87694204,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 959.9759999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2041.1300000000097,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.0539999999999976,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 589.945,
      "heapDeltaBytes": -14844280,
      "heapUsedBytes": 87743916,
      "domNodes": -271,
      "jsHeapTotalBytes": -831488,
      "scriptDurationMs": 35.782,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2018.1440000000066,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.5080000000000024,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 577.273,
      "heapDeltaBytes": 21883728,
      "heapUsedBytes": 88064600,
      "domNodes": -274,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 32.6,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 588.9389999999821,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.182999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 412.2180000000001,
      "heapDeltaBytes": 14816300,
      "heapUsedBytes": 87295696,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 144.478,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 632.370999999921,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.783000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 420.973,
      "heapDeltaBytes": 14849492,
      "heapUsedBytes": 87355060,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 144.215,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2023.286999999982,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.575000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 536.105,
      "heapDeltaBytes": -11900112,
      "heapUsedBytes": 60722332,
      "domNodes": -297,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 9.943999999999997,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.5820000000804,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.250000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 526.415,
      "heapDeltaBytes": -8243460,
      "heapUsedBytes": 64303664,
      "domNodes": -298,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 9.378999999999998,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1808.907999999974,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 41.895,
      "layouts": 18,
      "layoutDurationMs": 6.050999999999999,
      "taskDurationMs": 897.2309999999999,
      "heapDeltaBytes": -11517636,
      "heapUsedBytes": 61035500,
      "domNodes": -296,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 118.997,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1740.8680000000913,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 36.578,
      "layouts": 18,
      "layoutDurationMs": 5.498,
      "taskDurationMs": 818.6070000000001,
      "heapDeltaBytes": -11378332,
      "heapUsedBytes": 61249304,
      "domNodes": -295,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 106.971,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1413.4990000000016,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 31.145000000000007,
      "layouts": 15,
      "layoutDurationMs": 15.037000000000003,
      "taskDurationMs": 972.0190000000002,
      "heapDeltaBytes": 19964428,
      "heapUsedBytes": 102890032,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 30.756,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 128,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8396.312999999964,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 40.078,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5747.625,
      "heapDeltaBytes": -24417528,
      "heapUsedBytes": 76051144,
      "domNodes": -268,
      "jsHeapTotalBytes": -868352,
      "scriptDurationMs": 2617.331,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8440.545999999926,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 39.833999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5880.191,
      "heapDeltaBytes": 4991100,
      "heapUsedBytes": 80724212,
      "domNodes": -273,
      "jsHeapTotalBytes": -643072,
      "scriptDurationMs": 2569.802,
      "eventListeners": -169,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18325.80200000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17747.665,
      "heapDeltaBytes": -47380800,
      "heapUsedBytes": 162833512,
      "domNodes": -6548,
      "jsHeapTotalBytes": -4321280,
      "scriptDurationMs": 302.033,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18147.257999999965,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17841.774,
      "heapDeltaBytes": -29154268,
      "heapUsedBytes": 174096192,
      "domNodes": -6548,
      "jsHeapTotalBytes": -6205440,
      "scriptDurationMs": 347.729,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23233.79699999998,
      "styleRecalcs": 176,
      "styleRecalcDurationMs": 24.075000000000014,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22968.95,
      "heapDeltaBytes": -36627188,
      "heapUsedBytes": 176100288,
      "domNodes": -6548,
      "jsHeapTotalBytes": -7798784,
      "scriptDurationMs": 955.6869999999999,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 126,
      "frameDurationMs": 17.77666666666652,
      "p95FrameDurationMs": 16.799999999995634
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23366.24500000005,
      "styleRecalcs": 175,
      "styleRecalcDurationMs": 30.632999999999967,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 23161.502000000004,
      "heapDeltaBytes": -28533416,
      "heapUsedBytes": 175188928,
      "domNodes": -6548,
      "jsHeapTotalBytes": -7503872,
      "scriptDurationMs": 1009.7529999999999,
      "eventListeners": -7465,
      "totalBlockingTimeMs": 245,
      "frameDurationMs": 17.773333333333238,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6510.7840000000015,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 72.35000000000002,
      "layouts": 20,
      "layoutDurationMs": 23.87600000000001,
      "taskDurationMs": 6441.660000000001,
      "heapDeltaBytes": -30106832,
      "heapUsedBytes": 179673056,
      "domNodes": -6548,
      "jsHeapTotalBytes": 11464704,
      "scriptDurationMs": 122.75199999999998,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 418,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6657.180999999923,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.895,
      "layouts": 20,
      "layoutDurationMs": 26.222999999999995,
      "taskDurationMs": 6617.478,
      "heapDeltaBytes": -28048856,
      "heapUsedBytes": 181708696,
      "domNodes": -6529,
      "jsHeapTotalBytes": 12980224,
      "scriptDurationMs": 124.163,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 557,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 478.4099999999398,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 24.492,
      "layouts": 3,
      "layoutDurationMs": 1.689,
      "taskDurationMs": 122.76100000000001,
      "heapDeltaBytes": 5314156,
      "heapUsedBytes": 73937464,
      "domNodes": 153,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 12.519,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 466.7509999999311,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 23.125999999999998,
      "layouts": 3,
      "layoutDurationMs": 1.6879999999999997,
      "taskDurationMs": 117.259,
      "heapDeltaBytes": 5264684,
      "heapUsedBytes": 73513740,
      "domNodes": 148,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 11.083999999999998,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 47993 70502 68.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.4% 397
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.4% 258
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 44.7% 204

@github-actions
github-actions Bot requested a review from DrJKL September 2, 2026 18:07
@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@codecov

codecov Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.16667% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/lib/litegraph/src/linkDeduplication.ts 0.00% 2 Missing ⚠️
src/platform/telemetry/TelemetryRegistry.ts 0.00% 2 Missing ⚠️
src/core/graph/subgraph/promotionUtils.ts 88.88% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.53   #16679   +/-   ##
=============================================
  Coverage              ?   83.26%           
=============================================
  Files                 ?     2023           
  Lines                 ?   116999           
  Branches              ?    32455           
=============================================
  Hits                  ?    97420           
  Misses                ?    19233           
  Partials              ?      346           
Flag Coverage Δ
e2e 66.58% <52.94%> (?)
unit 76.52% <85.71%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lib/litegraph/src/subgraph/SubgraphNode.ts 89.85% <100.00%> (ø)
...emetry/providers/cloud/PostHogTelemetryProvider.ts 67.88% <100.00%> (ø)
...form/telemetry/providers/host/HostTelemetrySink.ts 30.57% <100.00%> (ø)
src/platform/telemetry/types.ts 97.05% <ø> (ø)
src/core/graph/subgraph/promotionUtils.ts 91.36% <88.88%> (ø)
src/lib/litegraph/src/linkDeduplication.ts 72.35% <0.00%> (ø)
src/platform/telemetry/TelemetryRegistry.ts 22.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

comfy-pr-bot pushed a commit that referenced this pull request Sep 2, 2026
…ak and perf bugs (#16678)

Backport of #16512 to `core/1.53`. Fixes promoted-widget values leaking
across unrelated subgraph node instances (#16250) and nested-promotion
widget registration ignoring a rejected store registration (#16013,
#16251); adds the regression tests requested in #16008. The
auto-backport failed only on the ADR index table; resolved by adding the
ADR 0027 row and omitting the ADR 0026 row, which does not exist on this
branch.

<details><summary>Full context for agent readers</summary>

- Source: #16512 (merged to main 2026-09-02T15:05Z as
bd7f5cf), labeled needs-backport +
core/1.53 + cloud/1.53 after merge; the label-triggered auto-backport
run failed with a content conflict in `docs/adr/README.md` on both
targets.
- Conflict resolution: main's README hunk added rows for ADR 0026 and
0027; `core/1.53` has neither `0026-frontend-document-model.md` nor its
row, so only the 0027 row was kept (its file is added by this
cherry-pick). No source-file conflicts.
- Verification on this branch: `pnpm vitest run` over every touched test
file (16 files, 434 passed, 1 skipped), `pnpm typecheck` clean, `pnpm
oxlint` on touched files clean.
- Sibling backport: cloud/1.53 is #16679.
- Tracking: #15973

<!-- authored-by:agent w3-bp16512 -->
</details>

@CodeJuggernaut CodeJuggernaut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faithful backport - the payload matches the approved source PR byte for byte, and the index deviation is correct for this branch; no issues.

@huang47 huang47 removed the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
// that gets discarded), letting a later unrelated instance inherit
// this value. onAdded() performs the deferred registration once a
// real id is assigned.
delete input.widgetId

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete has been a source of issues with the compatibility proxies we're using.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same bytes as main (bd7f5cf) and the merged core twin (#16678). Main already uses delete input.widgetId at two older sites in this file (the rehydrate loop in onAdded and the _setWidget reset), so the pattern predates this change.

Proposal: keep this backport identical to main; land a forward fix on main switching all three sites to input.widgetId = undefined (type is already optional), then backport that to both 1.53 branches. If you would rather the fix go in here first, say so and I will push it.

Full context for agent readers

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forward fix on main: #16717 (replaces delete input.widgetId with input.widgetId = undefined at all three sites in this file). Will backport to both 1.53 branches once it lands.

@CodeJuggernaut

Copy link
Copy Markdown
Contributor

Two items landed after the approvals here: DrJKL's SubgraphNode.ts:659 concern about delete under the compatibility proxies is still unanswered, and playwright-tests-chromium-sharded (5, 16) is red at head while the byte-identical core/1.53 twin #16678 is green. Worth settling both before merge.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Rerunning the failed shard: interaction.spec.ts › Viewport settings › Keeps viewport settings when changing tabs touches nothing in this diff and passed on the identical core twin #16678. The delete question is answered in the thread with a forward-fix proposal on main.

Full context for agent readers

@comfy-pr-bot
comfy-pr-bot merged commit 293b339 into cloud/1.53 Sep 2, 2026
169 of 172 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-16512-to-cloud-1.53 branch September 2, 2026 22:08
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 3, 2026
…6717)

## Summary

Replaces `delete input.widgetId` with `input.widgetId = undefined` at
the three call sites in `SubgraphNode.ts` (unlink cleanup,
unassigned-node guard, failed-registration guard).

`widgetId` is an optional field (`widgetId?: WidgetId`,
`src/lib/litegraph/src/interfaces.ts:375`), so assignment is a
semantically equivalent, proxy-safe replacement for `delete`.

## Why

Follow-up from a review thread on the cloud/1.53 backport
[Comfy-Org#16679](Comfy-Org#16679 (comment)):

> `delete` has been a source of issues with the compatibility proxies
we're using. — @DrJKL

That backport kept the pattern byte-identical to `main` (it predates the
change under review, also present at the merged core twin
[Comfy-Org#16678](Comfy-Org#16678)).
This PR is the forward fix on `main`; both `cloud/1.53` and `core/1.53`
can backport it once merged.

## Verification

- No caller checks key presence (`in` / `hasOwnProperty`) or serializes
`input` directly — pure behavior-preserving substitution.
- `SubgraphNode.test.ts` + `SubgraphNode.titleButton.test.ts`: 61/61
passed.
- Full `src/lib/litegraph/src/subgraph/` suite: 323/323 passed.
- `eslint` on the changed file: 0 errors (2 pre-existing, unrelated
warnings).
- Full-project `vue-tsc --noEmit`: clean.

Co-authored-by: cheap-drain <christian@ampcode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants