Repository navigation
[backport cloud/1.53] test: cover link/store contracts + fix widget-leak and perf bugs - #16679
Conversation
) Addresses part of #15973. 1. **`transformLinkReferences` (`remapLinkReferences`) coverage parity** — parametrized `linkDeduplication.transformLinkReferences.test.ts` over all five serialized reference-location kinds (node `input.link`, node `output.links`, subgraph boundary `linkIds`, reroute `linkIds`, `linkExtensions`) under both "replace" (same-origin remap) and "remove" (different-origin prune) modes via `normalizeConfiguredTopology`. No functional gap found — pure coverage. 2. **`LinkDedupDropMetadata` telemetry** — `LinkDedupDropMetadata` was fully typed/documented in `src/platform/telemetry/types.ts` but never wired to an emission call site; only `console.warn` fired. Added `trackLinkDedupDrop` to the dispatcher and call it from `normalizeConfiguredTopology` for different-origin drops. Tests assert it fires exactly once with `{ droppedLinkId, survivorLinkId, target }` independent of the `console.warn` string assertion, and does not fire for a same-origin remap. 3. **Store collision contracts** — `storeCollisionContracts.test.ts` (added by PR #15720 per the tracking issue) does not exist anywhere yet — confirmed absent on `origin/main` and this branch. Added it: `nodeDataStore`/`linkStore`/`rerouteStore` reject registration at an occupied identity key; `widgetValueStore` resolves a collision at its structural key (`graphId:nodeId:name`) per documented same-type-keeps-value / different-type-overwrites semantics. Each store already had its own collision tests (not duplicated here) but no shared cross-store suite existed. Note: `docs/exceptions-log.md` EX-002's full closing condition also requires ADR-text corrections (PRs #15720/#15761) — out of scope here. Independently verified ADR-0016/0018 already match current code (not stale as EX-002's text about "PRs #15720/#15761" implies for an older, unlinked ADR revision). 4. **Fixes #16008** — `nodeOutputStore` output-image writes scaling quadratically. The actual O(N²) fix (bounding `createNodeOutputsMutationView`'s commit to the single changed key instead of calling `replaceOutputsFromLegacy` on every write) already landed via commit `af617ef478` (#16156), confirmed by reading `src/scripts/app.ts`. What was missing was the regression test the issue explicitly asks for. Added a scaling-detector test in `app.test.ts`: N sequential output writes for N distinct nodes must each commit exactly one `setOutputFromLegacy` call and never call `replaceOutputsFromLegacy`. Verified it fails when the old buggy `commit` callback is reintroduced. 5. **Fixes #16250** — promoted widget values leaking across unrelated `SubgraphNode` instances. Root cause: `SubgraphNode._setWidget` registered promoted widget state under `widgetId(rootGraph.id, this.id, name)` even while `this.id` was still `UNASSIGNED_NODE_ID` during construction, so every constructing `SubgraphNode` with the same promoted input name shared one registration key. A discarded clipboard clone (`LGraphCanvas`'s clone-and-serialize path never calls `graph.add()`) could leave its value behind under that shared key, inherited by a later unrelated same-named/typed promoted input via `widgetValueStore`'s same-type-keeps-value collision resolution. Fix: `_setWidget` now skips store registration while `this.id === UNASSIGNED_NODE_ID`; `onAdded` performs the deferred first-time registration once a real id is assigned (extends its existing migration loop). Updated one existing test (`SubgraphNode.test.ts`) that had encoded the old buggy "transient widgetId during construction" behavior as intended; added a new regression test exercising the literal clipboard clone-and-discard path. 6. **Fixes #16013, Fixes #16251** — confirmed both issues describe the exact same defect: `seedNestedPromotedInputState` (`src/core/graph/subgraph/promotionUtils.ts`) assigned `hostInput.widgetId = id` before calling `registerWidget(...)` and ignored its return value — same defect class PR #15767 fixed in `SubgraphNode._setWidget`. Fixed with the same pattern: capture `registerWidget`'s return, assign `widgetId` only on success, retract the widget locator on rejection. Exported the previously-private function and added a direct unit test (an end-to-end nested-promotion repro proved too coupled to `_setWidget`'s own connect-time resolution to reliably reach this fallback path in an integration test). - Item 4: fixed the missing regression test only; the perf fix itself was already on `main` via an unrelated PR. Verified independently by reading the code, not just trusting the research pass. - Item 6: #16013 and #16251 are the same defect — one commit, both "Fixes" lines apply, no separate handling needed. - Item 3: did not touch `docs/exceptions-log.md` — closing EX-002 fully requires the ADR-text-correction PRs (#15720/#15761) referenced in its closing condition, which are out of scope for this PR. - Item 5: updated `SubgraphNode.test.ts`'s "migrates promoted widget bindings when added to a graph" test, since it explicitly asserted on the old (leaky) "transient widgetId during construction" behavior as a feature. `pnpm test:unit` (19,354 passed, 2 pre-existing/unrelated flakes confirmed independent — `cameraFraming.test.ts` and `comfyIngestTypes.test.ts`, both pass in isolation and touch no file in this diff), `pnpm typecheck`, `pnpm lint`, `pnpm format:check`, `pnpm knip` all clean. Every fix's regression test was verified to fail against the pre-fix code and pass against the fix. This PR also implements the concrete deferred lifecycle item from [#16238](#16238): prevent promoted-widget identity/value from crossing unrelated `SubgraphNode` instance boundaries. It covers the deferred cleanup note in [review thread r3898759028](#16238 (comment)) and the instance-boundary oracle requested in [the QA follow-up](#16238 (comment)). <!-- authored-by:agent addr-drain -->
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1891 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-02T18:20:44.637Z",
"gitSha": "53bce3c10b8ab813c4a566ffa94a565b87a1fd5d",
"branch": "backport-16512-to-cloud-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2038.759999999968,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.256000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.651,
"heapDeltaBytes": -10897540,
"heapUsedBytes": 59504968,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.884,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2037.7279999999018,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.022,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.72399999999993,
"heapDeltaBytes": 540180,
"heapUsedBytes": 70076964,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.623,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2230.3190000000086,
"styleRecalcs": 89,
"styleRecalcDurationMs": 55.550000000000004,
"layouts": 14,
"layoutDurationMs": 5.417,
"taskDurationMs": 1154.4660000000001,
"heapDeltaBytes": 6437328,
"heapUsedBytes": 76247568,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 179.427,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1814.4770000000108,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.697,
"layouts": 14,
"layoutDurationMs": 4.628,
"taskDurationMs": 867.6839999999999,
"heapDeltaBytes": -6338904,
"heapUsedBytes": 64126752,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 147.634,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1733.2989999999882,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.183000000000003,
"layouts": 6,
"layoutDurationMs": 1.279,
"taskDurationMs": 384.69199999999995,
"heapDeltaBytes": 4407764,
"heapUsedBytes": 74755288,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.987999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1684.44199999999,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.455,
"layouts": 6,
"layoutDurationMs": 1.12,
"taskDurationMs": 398.18699999999995,
"heapDeltaBytes": 4440916,
"heapUsedBytes": 74933456,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.336999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 662.7330000000029,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.174999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.596,
"heapDeltaBytes": 18135992,
"heapUsedBytes": 88462736,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 165.228,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 742.3330000000306,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.362000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.45699999999994,
"heapDeltaBytes": 17847596,
"heapUsedBytes": 88130572,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 158.152,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2055.1600000000008,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.642,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 717.967,
"heapDeltaBytes": -13785744,
"heapUsedBytes": 86819260,
"domNodes": -268,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 39.806,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2039.641999999958,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.859000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 653.0289999999999,
"heapDeltaBytes": -13982312,
"heapUsedBytes": 86740260,
"domNodes": -269,
"jsHeapTotalBytes": -2404352,
"scriptDurationMs": 34.595,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2387.4440000000163,
"styleRecalcs": 62,
"styleRecalcDurationMs": 9.705999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1717.8519999999996,
"heapDeltaBytes": 18587172,
"heapUsedBytes": 85039772,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 846.631,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2175.0679999998965,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.566000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1568.9070000000004,
"heapDeltaBytes": 17677688,
"heapUsedBytes": 83597812,
"domNodes": 4,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 747.837,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3830.718000000047,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.963999999999999,
"layouts": 60,
"layoutDurationMs": 13.883,
"taskDurationMs": 1846.222,
"heapDeltaBytes": 9323528,
"heapUsedBytes": 76378644,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 832.2769999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3515.470999999934,
"styleRecalcs": 61,
"styleRecalcDurationMs": 12.075,
"layouts": 60,
"layoutDurationMs": 13.691000000000003,
"taskDurationMs": 1723.9250000000002,
"heapDeltaBytes": 7737812,
"heapUsedBytes": 75373288,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 761.169,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3176.0249999999814,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.421999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2025.3229999999999,
"heapDeltaBytes": 26418744,
"heapUsedBytes": 94037688,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1005.152,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3070.5920000000333,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.407000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1919.202,
"heapDeltaBytes": 20061372,
"heapUsedBytes": 87694204,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 959.9759999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2041.1300000000097,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.0539999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.945,
"heapDeltaBytes": -14844280,
"heapUsedBytes": 87743916,
"domNodes": -271,
"jsHeapTotalBytes": -831488,
"scriptDurationMs": 35.782,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2018.1440000000066,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.5080000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.273,
"heapDeltaBytes": 21883728,
"heapUsedBytes": 88064600,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.6,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 588.9389999999821,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.182999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.2180000000001,
"heapDeltaBytes": 14816300,
"heapUsedBytes": 87295696,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 144.478,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 632.370999999921,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.783000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.973,
"heapDeltaBytes": 14849492,
"heapUsedBytes": 87355060,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 144.215,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.286999999982,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.575000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.105,
"heapDeltaBytes": -11900112,
"heapUsedBytes": 60722332,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.943999999999997,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.5820000000804,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.250000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.415,
"heapDeltaBytes": -8243460,
"heapUsedBytes": 64303664,
"domNodes": -298,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.378999999999998,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1808.907999999974,
"styleRecalcs": 78,
"styleRecalcDurationMs": 41.895,
"layouts": 18,
"layoutDurationMs": 6.050999999999999,
"taskDurationMs": 897.2309999999999,
"heapDeltaBytes": -11517636,
"heapUsedBytes": 61035500,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 118.997,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1740.8680000000913,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.578,
"layouts": 18,
"layoutDurationMs": 5.498,
"taskDurationMs": 818.6070000000001,
"heapDeltaBytes": -11378332,
"heapUsedBytes": 61249304,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 106.971,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1413.4990000000016,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.145000000000007,
"layouts": 15,
"layoutDurationMs": 15.037000000000003,
"taskDurationMs": 972.0190000000002,
"heapDeltaBytes": 19964428,
"heapUsedBytes": 102890032,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 30.756,
"eventListeners": 2381,
"totalBlockingTimeMs": 128,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8396.312999999964,
"styleRecalcs": 248,
"styleRecalcDurationMs": 40.078,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5747.625,
"heapDeltaBytes": -24417528,
"heapUsedBytes": 76051144,
"domNodes": -268,
"jsHeapTotalBytes": -868352,
"scriptDurationMs": 2617.331,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8440.545999999926,
"styleRecalcs": 246,
"styleRecalcDurationMs": 39.833999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5880.191,
"heapDeltaBytes": 4991100,
"heapUsedBytes": 80724212,
"domNodes": -273,
"jsHeapTotalBytes": -643072,
"scriptDurationMs": 2569.802,
"eventListeners": -169,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18325.80200000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17747.665,
"heapDeltaBytes": -47380800,
"heapUsedBytes": 162833512,
"domNodes": -6548,
"jsHeapTotalBytes": -4321280,
"scriptDurationMs": 302.033,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18147.257999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17841.774,
"heapDeltaBytes": -29154268,
"heapUsedBytes": 174096192,
"domNodes": -6548,
"jsHeapTotalBytes": -6205440,
"scriptDurationMs": 347.729,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 23233.79699999998,
"styleRecalcs": 176,
"styleRecalcDurationMs": 24.075000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22968.95,
"heapDeltaBytes": -36627188,
"heapUsedBytes": 176100288,
"domNodes": -6548,
"jsHeapTotalBytes": -7798784,
"scriptDurationMs": 955.6869999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 126,
"frameDurationMs": 17.77666666666652,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-large-graph-pan",
"durationMs": 23366.24500000005,
"styleRecalcs": 175,
"styleRecalcDurationMs": 30.632999999999967,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23161.502000000004,
"heapDeltaBytes": -28533416,
"heapUsedBytes": 175188928,
"domNodes": -6548,
"jsHeapTotalBytes": -7503872,
"scriptDurationMs": 1009.7529999999999,
"eventListeners": -7465,
"totalBlockingTimeMs": 245,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6510.7840000000015,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.35000000000002,
"layouts": 20,
"layoutDurationMs": 23.87600000000001,
"taskDurationMs": 6441.660000000001,
"heapDeltaBytes": -30106832,
"heapUsedBytes": 179673056,
"domNodes": -6548,
"jsHeapTotalBytes": 11464704,
"scriptDurationMs": 122.75199999999998,
"eventListeners": -7469,
"totalBlockingTimeMs": 418,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6657.180999999923,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.895,
"layouts": 20,
"layoutDurationMs": 26.222999999999995,
"taskDurationMs": 6617.478,
"heapDeltaBytes": -28048856,
"heapUsedBytes": 181708696,
"domNodes": -6529,
"jsHeapTotalBytes": 12980224,
"scriptDurationMs": 124.163,
"eventListeners": -7471,
"totalBlockingTimeMs": 557,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 478.4099999999398,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.492,
"layouts": 3,
"layoutDurationMs": 1.689,
"taskDurationMs": 122.76100000000001,
"heapDeltaBytes": 5314156,
"heapUsedBytes": 73937464,
"domNodes": 153,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 12.519,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 466.7509999999311,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.125999999999998,
"layouts": 3,
"layoutDurationMs": 1.6879999999999997,
"taskDurationMs": 117.259,
"heapDeltaBytes": 5264684,
"heapUsedBytes": 73513740,
"domNodes": 148,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 11.083999999999998,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.53 #16679 +/- ##
=============================================
Coverage ? 83.26%
=============================================
Files ? 2023
Lines ? 116999
Branches ? 32455
=============================================
Hits ? 97420
Misses ? 19233
Partials ? 346
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…ak and perf bugs (#16678) Backport of #16512 to `core/1.53`. Fixes promoted-widget values leaking across unrelated subgraph node instances (#16250) and nested-promotion widget registration ignoring a rejected store registration (#16013, #16251); adds the regression tests requested in #16008. The auto-backport failed only on the ADR index table; resolved by adding the ADR 0027 row and omitting the ADR 0026 row, which does not exist on this branch. <details><summary>Full context for agent readers</summary> - Source: #16512 (merged to main 2026-09-02T15:05Z as bd7f5cf), labeled needs-backport + core/1.53 + cloud/1.53 after merge; the label-triggered auto-backport run failed with a content conflict in `docs/adr/README.md` on both targets. - Conflict resolution: main's README hunk added rows for ADR 0026 and 0027; `core/1.53` has neither `0026-frontend-document-model.md` nor its row, so only the 0027 row was kept (its file is added by this cherry-pick). No source-file conflicts. - Verification on this branch: `pnpm vitest run` over every touched test file (16 files, 434 passed, 1 skipped), `pnpm typecheck` clean, `pnpm oxlint` on touched files clean. - Sibling backport: cloud/1.53 is #16679. - Tracking: #15973 <!-- authored-by:agent w3-bp16512 --> </details>
CodeJuggernaut
left a comment
There was a problem hiding this comment.
Faithful backport - the payload matches the approved source PR byte for byte, and the index deviation is correct for this branch; no issues.
| // that gets discarded), letting a later unrelated instance inherit | ||
| // this value. onAdded() performs the deferred registration once a | ||
| // real id is assigned. | ||
| delete input.widgetId |
There was a problem hiding this comment.
delete has been a source of issues with the compatibility proxies we're using.
There was a problem hiding this comment.
Same bytes as main (bd7f5cf) and the merged core twin (#16678). Main already uses delete input.widgetId at two older sites in this file (the rehydrate loop in onAdded and the _setWidget reset), so the pattern predates this change.
Proposal: keep this backport identical to main; land a forward fix on main switching all three sites to input.widgetId = undefined (type is already optional), then backport that to both 1.53 branches. If you would rather the fix go in here first, say so and I will push it.
Full context for agent readers
- Sites on main:
SubgraphNode.tslines 351, 659, 680 (git show origin/main:src/lib/litegraph/src/subgraph/SubgraphNode.ts). - Backport PRs: [backport core/1.53] test: cover link/store contracts + fix widget-leak and perf bugs #16678 (core/1.53, merged), [backport cloud/1.53] test: cover link/store contracts + fix widget-leak and perf bugs #16679 (cloud/1.53, this PR).
- Type:
widgetId?: WidgetIdinsrc/lib/litegraph/src/interfaces.ts:375. - Not resolving this thread; reviewer's call.
There was a problem hiding this comment.
forward fix on main: #16717 (replaces delete input.widgetId with input.widgetId = undefined at all three sites in this file). Will backport to both 1.53 branches once it lands.
|
Two items landed after the approvals here: DrJKL's |
|
Rerunning the failed shard: Full context for agent readers
|
…6717) ## Summary Replaces `delete input.widgetId` with `input.widgetId = undefined` at the three call sites in `SubgraphNode.ts` (unlink cleanup, unassigned-node guard, failed-registration guard). `widgetId` is an optional field (`widgetId?: WidgetId`, `src/lib/litegraph/src/interfaces.ts:375`), so assignment is a semantically equivalent, proxy-safe replacement for `delete`. ## Why Follow-up from a review thread on the cloud/1.53 backport [Comfy-Org#16679](Comfy-Org#16679 (comment)): > `delete` has been a source of issues with the compatibility proxies we're using. — @DrJKL That backport kept the pattern byte-identical to `main` (it predates the change under review, also present at the merged core twin [Comfy-Org#16678](Comfy-Org#16678)). This PR is the forward fix on `main`; both `cloud/1.53` and `core/1.53` can backport it once merged. ## Verification - No caller checks key presence (`in` / `hasOwnProperty`) or serializes `input` directly — pure behavior-preserving substitution. - `SubgraphNode.test.ts` + `SubgraphNode.titleButton.test.ts`: 61/61 passed. - Full `src/lib/litegraph/src/subgraph/` suite: 323/323 passed. - `eslint` on the changed file: 0 errors (2 pre-existing, unrelated warnings). - Full-project `vue-tsc --noEmit`: clean. Co-authored-by: cheap-drain <christian@ampcode.com>
Backport of #16512 to
cloud/1.53. Fixes promoted-widget values leaking across unrelated subgraph node instances (#16250) and nested-promotion widget registration ignoring a rejected store registration (#16013, #16251); adds the regression tests requested in #16008. The auto-backport failed only on the ADR index table; resolved by adding the ADR 0027 row and omitting the ADR 0026 row, which does not exist on this branch.Full context for agent readers
docs/adr/README.mdon both targets.cloud/1.53has neither0026-frontend-document-model.mdnor its row, so only the 0027 row was kept (its file is added by this cherry-pick). No source-file conflicts.pnpm vitest runover every touched test file (16 files, 434 passed, 1 skipped),pnpm typecheckclean,pnpm oxlinton touched files clean.