Repository navigation
[backport core/1.53] test: cover link/store contracts + fix widget-leak and perf bugs - #16678
Conversation
) Addresses part of #15973. 1. **`transformLinkReferences` (`remapLinkReferences`) coverage parity** — parametrized `linkDeduplication.transformLinkReferences.test.ts` over all five serialized reference-location kinds (node `input.link`, node `output.links`, subgraph boundary `linkIds`, reroute `linkIds`, `linkExtensions`) under both "replace" (same-origin remap) and "remove" (different-origin prune) modes via `normalizeConfiguredTopology`. No functional gap found — pure coverage. 2. **`LinkDedupDropMetadata` telemetry** — `LinkDedupDropMetadata` was fully typed/documented in `src/platform/telemetry/types.ts` but never wired to an emission call site; only `console.warn` fired. Added `trackLinkDedupDrop` to the dispatcher and call it from `normalizeConfiguredTopology` for different-origin drops. Tests assert it fires exactly once with `{ droppedLinkId, survivorLinkId, target }` independent of the `console.warn` string assertion, and does not fire for a same-origin remap. 3. **Store collision contracts** — `storeCollisionContracts.test.ts` (added by PR #15720 per the tracking issue) does not exist anywhere yet — confirmed absent on `origin/main` and this branch. Added it: `nodeDataStore`/`linkStore`/`rerouteStore` reject registration at an occupied identity key; `widgetValueStore` resolves a collision at its structural key (`graphId:nodeId:name`) per documented same-type-keeps-value / different-type-overwrites semantics. Each store already had its own collision tests (not duplicated here) but no shared cross-store suite existed. Note: `docs/exceptions-log.md` EX-002's full closing condition also requires ADR-text corrections (PRs #15720/#15761) — out of scope here. Independently verified ADR-0016/0018 already match current code (not stale as EX-002's text about "PRs #15720/#15761" implies for an older, unlinked ADR revision). 4. **Fixes #16008** — `nodeOutputStore` output-image writes scaling quadratically. The actual O(N²) fix (bounding `createNodeOutputsMutationView`'s commit to the single changed key instead of calling `replaceOutputsFromLegacy` on every write) already landed via commit `af617ef478` (#16156), confirmed by reading `src/scripts/app.ts`. What was missing was the regression test the issue explicitly asks for. Added a scaling-detector test in `app.test.ts`: N sequential output writes for N distinct nodes must each commit exactly one `setOutputFromLegacy` call and never call `replaceOutputsFromLegacy`. Verified it fails when the old buggy `commit` callback is reintroduced. 5. **Fixes #16250** — promoted widget values leaking across unrelated `SubgraphNode` instances. Root cause: `SubgraphNode._setWidget` registered promoted widget state under `widgetId(rootGraph.id, this.id, name)` even while `this.id` was still `UNASSIGNED_NODE_ID` during construction, so every constructing `SubgraphNode` with the same promoted input name shared one registration key. A discarded clipboard clone (`LGraphCanvas`'s clone-and-serialize path never calls `graph.add()`) could leave its value behind under that shared key, inherited by a later unrelated same-named/typed promoted input via `widgetValueStore`'s same-type-keeps-value collision resolution. Fix: `_setWidget` now skips store registration while `this.id === UNASSIGNED_NODE_ID`; `onAdded` performs the deferred first-time registration once a real id is assigned (extends its existing migration loop). Updated one existing test (`SubgraphNode.test.ts`) that had encoded the old buggy "transient widgetId during construction" behavior as intended; added a new regression test exercising the literal clipboard clone-and-discard path. 6. **Fixes #16013, Fixes #16251** — confirmed both issues describe the exact same defect: `seedNestedPromotedInputState` (`src/core/graph/subgraph/promotionUtils.ts`) assigned `hostInput.widgetId = id` before calling `registerWidget(...)` and ignored its return value — same defect class PR #15767 fixed in `SubgraphNode._setWidget`. Fixed with the same pattern: capture `registerWidget`'s return, assign `widgetId` only on success, retract the widget locator on rejection. Exported the previously-private function and added a direct unit test (an end-to-end nested-promotion repro proved too coupled to `_setWidget`'s own connect-time resolution to reliably reach this fallback path in an integration test). - Item 4: fixed the missing regression test only; the perf fix itself was already on `main` via an unrelated PR. Verified independently by reading the code, not just trusting the research pass. - Item 6: #16013 and #16251 are the same defect — one commit, both "Fixes" lines apply, no separate handling needed. - Item 3: did not touch `docs/exceptions-log.md` — closing EX-002 fully requires the ADR-text-correction PRs (#15720/#15761) referenced in its closing condition, which are out of scope for this PR. - Item 5: updated `SubgraphNode.test.ts`'s "migrates promoted widget bindings when added to a graph" test, since it explicitly asserted on the old (leaky) "transient widgetId during construction" behavior as a feature. `pnpm test:unit` (19,354 passed, 2 pre-existing/unrelated flakes confirmed independent — `cameraFraming.test.ts` and `comfyIngestTypes.test.ts`, both pass in isolation and touch no file in this diff), `pnpm typecheck`, `pnpm lint`, `pnpm format:check`, `pnpm knip` all clean. Every fix's regression test was verified to fail against the pre-fix code and pass against the fix. This PR also implements the concrete deferred lifecycle item from [#16238](#16238): prevent promoted-widget identity/value from crossing unrelated `SubgraphNode` instance boundaries. It covers the deferred cleanup note in [review thread r3898759028](#16238 (comment)) and the instance-boundary oracle requested in [the QA follow-up](#16238 (comment)). <!-- authored-by:agent addr-drain -->
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1889 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-02T18:18:56.183Z",
"gitSha": "e687ea94c48a881f4374cfc748cf0d2a34038516",
"branch": "backport-16512-to-core-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2058.977999999968,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.563999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.223,
"heapDeltaBytes": -9861196,
"heapUsedBytes": 59848692,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.758999999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2048.3330000000706,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.709999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.8189999999999,
"heapDeltaBytes": -1367248,
"heapUsedBytes": 68411468,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.418000000000001,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2015.6470000000013,
"styleRecalcs": 77,
"styleRecalcDurationMs": 43.942,
"layouts": 14,
"layoutDurationMs": 6.642,
"taskDurationMs": 1053.923,
"heapDeltaBytes": -7032168,
"heapUsedBytes": 63145644,
"domNodes": -284,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 175.71200000000002,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1873.2610000000705,
"styleRecalcs": 77,
"styleRecalcDurationMs": 42.125,
"layouts": 14,
"layoutDurationMs": 5.119,
"taskDurationMs": 897.9430000000001,
"heapDeltaBytes": 6487628,
"heapUsedBytes": 77104384,
"domNodes": -282,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 160.552,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.1490000000022,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.942,
"layouts": 6,
"layoutDurationMs": 1.3359999999999996,
"taskDurationMs": 378.9359999999999,
"heapDeltaBytes": 4391540,
"heapUsedBytes": 75035116,
"domNodes": 77,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 11.540000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1672.6079999999683,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.294,
"layouts": 6,
"layoutDurationMs": 1.0420000000000003,
"taskDurationMs": 356.981,
"heapDeltaBytes": 4694988,
"heapUsedBytes": 75056916,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.227,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 642.9220000000555,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.412,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.233,
"heapDeltaBytes": 18451760,
"heapUsedBytes": 87933832,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 161.09599999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 695.0080000000298,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.735999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.113,
"heapDeltaBytes": -7168272,
"heapUsedBytes": 63068728,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 159.534,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2043.7410000000114,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.513000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 638.1709999999999,
"heapDeltaBytes": 10908704,
"heapUsedBytes": 85859420,
"domNodes": -270,
"jsHeapTotalBytes": -868352,
"scriptDurationMs": 35.336,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2048.5729999999194,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.863000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 613.17,
"heapDeltaBytes": 10808180,
"heapUsedBytes": 86133080,
"domNodes": -271,
"jsHeapTotalBytes": -1654784,
"scriptDurationMs": 35.581,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2264.7890000000075,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.343,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1631.3519999999996,
"heapDeltaBytes": 18630320,
"heapUsedBytes": 84686512,
"domNodes": -274,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 835.6320000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2192.7429999999504,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.372999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1607.9650000000001,
"heapDeltaBytes": 19383592,
"heapUsedBytes": 84586656,
"domNodes": -269,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 803.452,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3571.098999999947,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.247,
"layouts": 60,
"layoutDurationMs": 12.365,
"taskDurationMs": 1707.655,
"heapDeltaBytes": 7774856,
"heapUsedBytes": 75373744,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 774.072,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3637.7180000000635,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.436000000000003,
"layouts": 60,
"layoutDurationMs": 11.871,
"taskDurationMs": 1705.336,
"heapDeltaBytes": 8793396,
"heapUsedBytes": 75744908,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 768.395,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3061.8559999999775,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.167999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1952.735,
"heapDeltaBytes": 22275428,
"heapUsedBytes": 88858260,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 972.602,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3062.0810000000347,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.577999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1902.5349999999999,
"heapDeltaBytes": 20028876,
"heapUsedBytes": 86910600,
"domNodes": 2,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 937.711,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2020.9899999999834,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.268999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 590.5409999999999,
"heapDeltaBytes": 10448008,
"heapUsedBytes": 86950472,
"domNodes": -270,
"jsHeapTotalBytes": -1916928,
"scriptDurationMs": 32.227000000000004,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2048.39800000002,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.033999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 615,
"heapDeltaBytes": -15092868,
"heapUsedBytes": 87388500,
"domNodes": -266,
"jsHeapTotalBytes": -831488,
"scriptDurationMs": 38.269999999999996,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 601.929000000041,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.638,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.53000000000003,
"heapDeltaBytes": 14778504,
"heapUsedBytes": 87583512,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 139.887,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 584.2370000000301,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.925999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.6000000000001,
"heapDeltaBytes": 14744220,
"heapUsedBytes": 87249272,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 140.316,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2024.0519999999833,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.106000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.18399999999997,
"heapDeltaBytes": -8350280,
"heapUsedBytes": 64298204,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.048999999999998,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2018.6280000000352,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.777999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.0450000000001,
"heapDeltaBytes": -8375736,
"heapUsedBytes": 64302812,
"domNodes": -295,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.456,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.2280000000392,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.839999999999996,
"layouts": 18,
"layoutDurationMs": 5.2490000000000006,
"taskDurationMs": 840.497,
"heapDeltaBytes": 252264,
"heapUsedBytes": 72887600,
"domNodes": -295,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 112.619,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.8369999999559,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.019,
"layouts": 18,
"layoutDurationMs": 5.264,
"taskDurationMs": 823.6329999999999,
"heapDeltaBytes": -9462920,
"heapUsedBytes": 63178432,
"domNodes": -297,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 109.03299999999999,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.1330000000726,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.98800000000001,
"layouts": 15,
"layoutDurationMs": 15.817000000000002,
"taskDurationMs": 952.1320000000002,
"heapDeltaBytes": 21066052,
"heapUsedBytes": 108522096,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 31.467999999999996,
"eventListeners": 2381,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8529.615000000034,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.711,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5890.866,
"heapDeltaBytes": 28013344,
"heapUsedBytes": 92925700,
"domNodes": -267,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 2729.498,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8544.025000000034,
"styleRecalcs": 246,
"styleRecalcDurationMs": 34.088,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5835.613,
"heapDeltaBytes": -11929048,
"heapUsedBytes": 88896800,
"domNodes": -271,
"jsHeapTotalBytes": -1392640,
"scriptDurationMs": 2682.263,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17643.101000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16950.168,
"heapDeltaBytes": -28191044,
"heapUsedBytes": 175176480,
"domNodes": -6548,
"jsHeapTotalBytes": 2879488,
"scriptDurationMs": 285.59299999999996,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17491.42500000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16812.362,
"heapDeltaBytes": -35086176,
"heapUsedBytes": 175363540,
"domNodes": -6548,
"jsHeapTotalBytes": 3424256,
"scriptDurationMs": 285.373,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21948.983999999997,
"styleRecalcs": 176,
"styleRecalcDurationMs": 19.120000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21465.965,
"heapDeltaBytes": -49171068,
"heapUsedBytes": 166369716,
"domNodes": -6548,
"jsHeapTotalBytes": 2564096,
"scriptDurationMs": 901.235,
"eventListeners": -7469,
"totalBlockingTimeMs": 153,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21474.997999999912,
"styleRecalcs": 169,
"styleRecalcDurationMs": 17.78099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21150.637,
"heapDeltaBytes": -45234204,
"heapUsedBytes": 168153988,
"domNodes": -6548,
"jsHeapTotalBytes": -5525504,
"scriptDurationMs": 875.3829999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 64,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6406.30299999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.318,
"layouts": 20,
"layoutDurationMs": 25.39000000000001,
"taskDurationMs": 6323.515,
"heapDeltaBytes": -32288932,
"heapUsedBytes": 175830756,
"domNodes": -6547,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 118.71200000000002,
"eventListeners": -7471,
"totalBlockingTimeMs": 460,
"frameDurationMs": 17.773333333333298,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6293.050999999991,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.60099999999997,
"layouts": 20,
"layoutDurationMs": 24.521,
"taskDurationMs": 6188.393,
"heapDeltaBytes": -8221156,
"heapUsedBytes": 194224700,
"domNodes": -6548,
"jsHeapTotalBytes": 16773120,
"scriptDurationMs": 111.256,
"eventListeners": -7471,
"totalBlockingTimeMs": 433,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "workflow-execution",
"durationMs": 105.38999999994303,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.845,
"layouts": 3,
"layoutDurationMs": 1.613,
"taskDurationMs": 81.815,
"heapDeltaBytes": 3270516,
"heapUsedBytes": 72089052,
"domNodes": 137,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.524000000000002,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 472.4469999998746,
"styleRecalcs": 19,
"styleRecalcDurationMs": 22.567,
"layouts": 2,
"layoutDurationMs": 1.044,
"taskDurationMs": 108.231,
"heapDeltaBytes": 5177040,
"heapUsedBytes": 72842676,
"domNodes": 150,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.898000000000002,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.53 #16678 +/- ##
=============================================
+ Coverage 83.26% 83.27% +0.01%
=============================================
Files 2023 2023
Lines 116974 116998 +24
Branches 33038 33043 +5
=============================================
+ Hits 97397 97429 +32
- Misses 19221 19223 +2
+ Partials 356 346 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 20 files with indirect coverage changes 🚀 New features to boost your workflow:
|
CodeJuggernaut
left a comment
There was a problem hiding this comment.
Matches the approved source PR file for file; no issues.
…eak and perf bugs (#16679) Backport of #16512 to `cloud/1.53`. Fixes promoted-widget values leaking across unrelated subgraph node instances (#16250) and nested-promotion widget registration ignoring a rejected store registration (#16013, #16251); adds the regression tests requested in #16008. The auto-backport failed only on the ADR index table; resolved by adding the ADR 0027 row and omitting the ADR 0026 row, which does not exist on this branch. <details><summary>Full context for agent readers</summary> - Source: #16512 (merged to main 2026-09-02T15:05Z as bd7f5cf), labeled needs-backport + core/1.53 + cloud/1.53 after merge; the label-triggered auto-backport run failed with a content conflict in `docs/adr/README.md` on both targets. - Conflict resolution: main's README hunk added rows for ADR 0026 and 0027; `cloud/1.53` has neither `0026-frontend-document-model.md` nor its row, so only the 0027 row was kept (its file is added by this cherry-pick). No source-file conflicts. - Verification on this branch: `pnpm vitest run` over every touched test file (16 files, 434 passed, 1 skipped), `pnpm typecheck` clean, `pnpm oxlint` on touched files clean. - Sibling backport: core/1.53 is #16678. - Tracking: #15973 <!-- authored-by:agent w3-bp16512 --> </details>
…6717) ## Summary Replaces `delete input.widgetId` with `input.widgetId = undefined` at the three call sites in `SubgraphNode.ts` (unlink cleanup, unassigned-node guard, failed-registration guard). `widgetId` is an optional field (`widgetId?: WidgetId`, `src/lib/litegraph/src/interfaces.ts:375`), so assignment is a semantically equivalent, proxy-safe replacement for `delete`. ## Why Follow-up from a review thread on the cloud/1.53 backport [Comfy-Org#16679](Comfy-Org#16679 (comment)): > `delete` has been a source of issues with the compatibility proxies we're using. — @DrJKL That backport kept the pattern byte-identical to `main` (it predates the change under review, also present at the merged core twin [Comfy-Org#16678](Comfy-Org#16678)). This PR is the forward fix on `main`; both `cloud/1.53` and `core/1.53` can backport it once merged. ## Verification - No caller checks key presence (`in` / `hasOwnProperty`) or serializes `input` directly — pure behavior-preserving substitution. - `SubgraphNode.test.ts` + `SubgraphNode.titleButton.test.ts`: 61/61 passed. - Full `src/lib/litegraph/src/subgraph/` suite: 323/323 passed. - `eslint` on the changed file: 0 errors (2 pre-existing, unrelated warnings). - Full-project `vue-tsc --noEmit`: clean. Co-authored-by: cheap-drain <christian@ampcode.com>
Backport of #16512 to
core/1.53. Fixes promoted-widget values leaking across unrelated subgraph node instances (#16250) and nested-promotion widget registration ignoring a rejected store registration (#16013, #16251); adds the regression tests requested in #16008. The auto-backport failed only on the ADR index table; resolved by adding the ADR 0027 row and omitting the ADR 0026 row, which does not exist on this branch.Full context for agent readers
docs/adr/README.mdon both targets.core/1.53has neither0026-frontend-document-model.mdnor its row, so only the 0027 row was kept (its file is added by this cherry-pick). No source-file conflicts.pnpm vitest runover every touched test file (16 files, 434 passed, 1 skipped),pnpm typecheckclean,pnpm oxlinton touched files clean.