Repository navigation
test(agent-crdt): characterize malformed follower updates - #16664
Conversation
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: 9 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour. 📝 WalkthroughWalkthroughThis change adds tests for ChangesFollowerDoc update validation
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 2072 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.96 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.87 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.46 MB (baseline 1.46 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 123 kB (baseline 123 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.87 MB (baseline 3.87 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 577 kB (baseline 577 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.8 MB (baseline 17.8 MB) • ⚪ 0 BBundles that do not match a named category Status: 302 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-21T22:11:19.256Z",
"gitSha": "2427a5057126c9336fcec2066f2646cf732755e8",
"branch": "christian-byrne/fec-update-1-malformed-yjs",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2087.6250000000027,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.505,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 616.4719999999999,
"heapDeltaBytes": 15904756,
"heapUsedBytes": 77910992,
"domNodes": -263,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 13.977,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1991.3470000000189,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.317999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.0919999999999,
"heapDeltaBytes": 4545492,
"heapUsedBytes": 66779216,
"domNodes": -265,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.052,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1757.9739999999902,
"styleRecalcs": 74,
"styleRecalcDurationMs": 26.823,
"layouts": 14,
"layoutDurationMs": 4.39,
"taskDurationMs": 759.501,
"heapDeltaBytes": 16671488,
"heapUsedBytes": 78832236,
"domNodes": -262,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 151.638,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1893.7670000000253,
"styleRecalcs": 78,
"styleRecalcDurationMs": 31.799,
"layouts": 14,
"layoutDurationMs": 4.827999999999999,
"taskDurationMs": 905.123,
"heapDeltaBytes": 3040168,
"heapUsedBytes": 65149328,
"domNodes": -265,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 161.846,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.304000000055,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.271,
"layouts": 6,
"layoutDurationMs": 1.1800000000000002,
"taskDurationMs": 350.32399999999996,
"heapDeltaBytes": 2231708,
"heapUsedBytes": 64299464,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.988999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.7469999999794,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.144,
"layouts": 6,
"layoutDurationMs": 1.335,
"taskDurationMs": 355.072,
"heapDeltaBytes": 2186904,
"heapUsedBytes": 64324392,
"domNodes": 74,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.638000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 663.722000000007,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.027000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.513,
"heapDeltaBytes": 18123044,
"heapUsedBytes": 80305164,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 161.388,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 644.0100000000939,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.577000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.95099999999996,
"heapDeltaBytes": 18218676,
"heapUsedBytes": 80355440,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 158.091,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1246.0820000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 957.914,
"heapDeltaBytes": 10566820,
"heapUsedBytes": 96767384,
"domNodes": -294,
"jsHeapTotalBytes": 24793088,
"scriptDurationMs": 58.29200000000001,
"eventListeners": -195,
"totalBlockingTimeMs": 603,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1205.8850000000803,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 866.572,
"heapDeltaBytes": 31212072,
"heapUsedBytes": 101853908,
"domNodes": 0,
"jsHeapTotalBytes": 18771968,
"scriptDurationMs": 61.27199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 594,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 840.6830000000127,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.36199999999974,
"heapDeltaBytes": 14306460,
"heapUsedBytes": 90332112,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 147.565,
"eventListeners": 0,
"totalBlockingTimeMs": 223,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.7170000000833,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.2139999999997,
"heapDeltaBytes": 14198504,
"heapUsedBytes": 90712464,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 144.341,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9612.31700000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8706.614,
"heapDeltaBytes": 11104536,
"heapUsedBytes": 93262404,
"domNodes": -14,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 7305.3,
"eventListeners": 0,
"totalBlockingTimeMs": 665,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9428.995999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8559.606,
"heapDeltaBytes": -10293280,
"heapUsedBytes": 71541140,
"domNodes": -12,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 6868.093,
"eventListeners": 0,
"totalBlockingTimeMs": 197,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9210.64899999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8334.742,
"heapDeltaBytes": 1931700,
"heapUsedBytes": 83709076,
"domNodes": -10,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 6698.029,
"eventListeners": 0,
"totalBlockingTimeMs": 333,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9231.906999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8348.753,
"heapDeltaBytes": 11944248,
"heapUsedBytes": 93702832,
"domNodes": -10,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 6745.99,
"eventListeners": 0,
"totalBlockingTimeMs": 181,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2042.6449999999932,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.7940000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.253,
"heapDeltaBytes": 2856640,
"heapUsedBytes": 83467424,
"domNodes": -251,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 36.797,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2019.2899999999554,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.9089999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.607,
"heapDeltaBytes": 2583456,
"heapUsedBytes": 83831096,
"domNodes": -253,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 36.36700000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2180.603000000019,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.638999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1597.7299999999998,
"heapDeltaBytes": 15700056,
"heapUsedBytes": 79941788,
"domNodes": -259,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 804.6990000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2324.647000000027,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.393000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1545.9270000000004,
"heapDeltaBytes": 19970788,
"heapUsedBytes": 84208940,
"domNodes": 2,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 867.156,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3695.678999999984,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.681999999999999,
"layouts": 60,
"layoutDurationMs": 15.322,
"taskDurationMs": 1824.2160000000001,
"heapDeltaBytes": 8006456,
"heapUsedBytes": 73747308,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 836.573,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3486.450999999988,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.558000000000002,
"layouts": 60,
"layoutDurationMs": 14.078999999999999,
"taskDurationMs": 1668.226,
"heapDeltaBytes": 8660440,
"heapUsedBytes": 74303688,
"domNodes": -263,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 790.598,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3127.482999999984,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.638000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1960.3739999999998,
"heapDeltaBytes": 25785056,
"heapUsedBytes": 91514492,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 1001.425,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3013.1419999999025,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.005999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1776.129,
"heapDeltaBytes": 23942152,
"heapUsedBytes": 89807212,
"domNodes": 2,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 991.8299999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.9169999999976,
"styleRecalcs": 4,
"styleRecalcDurationMs": 5.542999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 700.6759999999999,
"heapDeltaBytes": -3810692,
"heapUsedBytes": 84069500,
"domNodes": -254,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 38.45799999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.6079999999774,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.150999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.9069999999999,
"heapDeltaBytes": -4835052,
"heapUsedBytes": 83874984,
"domNodes": -250,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 37.954,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.6519999999969,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.011,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.8790000000001,
"heapDeltaBytes": 14703576,
"heapUsedBytes": 78380248,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 146.88500000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.3710000000001,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.969999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.70399999999995,
"heapDeltaBytes": 13683260,
"heapUsedBytes": 76633280,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 142.255,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1999.7650000000249,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.118999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.51300000000003,
"heapDeltaBytes": -468440,
"heapUsedBytes": 62212488,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.711,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.3439999999891,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.800999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.996,
"heapDeltaBytes": 14489052,
"heapUsedBytes": 78025608,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.148,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1735.0480000000061,
"styleRecalcs": 78,
"styleRecalcDurationMs": 28.301,
"layouts": 18,
"layoutDurationMs": 5.469,
"taskDurationMs": 827.645,
"heapDeltaBytes": 17530992,
"heapUsedBytes": 81060600,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 112.79400000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.8290000000134,
"styleRecalcs": 76,
"styleRecalcDurationMs": 26.286000000000005,
"layouts": 18,
"layoutDurationMs": 5.792000000000001,
"taskDurationMs": 756.23,
"heapDeltaBytes": 17459020,
"heapUsedBytes": 81005192,
"domNodes": -280,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 101.083,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.811000000037,
"styleRecalcs": 17,
"styleRecalcDurationMs": 27.768,
"layouts": 5,
"layoutDurationMs": 11.777,
"taskDurationMs": 973.527,
"heapDeltaBytes": 18398008,
"heapUsedBytes": 102144432,
"domNodes": 13667,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 31.751999999999995,
"eventListeners": 2383,
"totalBlockingTimeMs": 133,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8275.199000000044,
"styleRecalcs": 248,
"styleRecalcDurationMs": 40.471,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5785.76,
"heapDeltaBytes": -6509036,
"heapUsedBytes": 80379128,
"domNodes": -248,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 2725.326,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8318.861999999968,
"styleRecalcs": 247,
"styleRecalcDurationMs": 39.662000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5620.370999999999,
"heapDeltaBytes": 296540,
"heapUsedBytes": 80342336,
"domNodes": -248,
"jsHeapTotalBytes": 446464,
"scriptDurationMs": 2663.542,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17706.05400000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17552.788,
"heapDeltaBytes": -41164792,
"heapUsedBytes": 176387168,
"domNodes": -8061,
"jsHeapTotalBytes": -15142912,
"scriptDurationMs": 295.119,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17311.091000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16974.364,
"heapDeltaBytes": -53299524,
"heapUsedBytes": 180512400,
"domNodes": -8065,
"jsHeapTotalBytes": -5050368,
"scriptDurationMs": 272.92299999999994,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21986.689000000013,
"styleRecalcs": 154,
"styleRecalcDurationMs": 23.214999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21876.723,
"heapDeltaBytes": -41792212,
"heapUsedBytes": 189724312,
"domNodes": -8061,
"jsHeapTotalBytes": -12251136,
"scriptDurationMs": 929.359,
"eventListeners": -14928,
"totalBlockingTimeMs": 129,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21560.103000000025,
"styleRecalcs": 160,
"styleRecalcDurationMs": 20.02599999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21416.319000000003,
"heapDeltaBytes": -48813968,
"heapUsedBytes": 190373252,
"domNodes": -8061,
"jsHeapTotalBytes": -18128896,
"scriptDurationMs": 889.795,
"eventListeners": -14928,
"totalBlockingTimeMs": 100,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6622.030999999993,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.374,
"layouts": 20,
"layoutDurationMs": 26.779999999999998,
"taskDurationMs": 6578.210999999999,
"heapDeltaBytes": -40697784,
"heapUsedBytes": 196330332,
"domNodes": -8061,
"jsHeapTotalBytes": 15925248,
"scriptDurationMs": 131.028,
"eventListeners": -14927,
"totalBlockingTimeMs": 493,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6472.480000000019,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.99599999999998,
"layouts": 20,
"layoutDurationMs": 24.831000000000007,
"taskDurationMs": 6442.931999999999,
"heapDeltaBytes": -79844060,
"heapUsedBytes": 172936380,
"domNodes": -8060,
"jsHeapTotalBytes": 2449408,
"scriptDurationMs": 121.334,
"eventListeners": -14928,
"totalBlockingTimeMs": 502,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8795.00799999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8643.033999999998,
"heapDeltaBytes": -27596996,
"heapUsedBytes": 173923936,
"domNodes": 0,
"jsHeapTotalBytes": -20447232,
"scriptDurationMs": 142.46900000000008,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8821.390999999949,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8585.378999999999,
"heapDeltaBytes": 27126444,
"heapUsedBytes": 190832512,
"domNodes": 0,
"jsHeapTotalBytes": -9699328,
"scriptDurationMs": 159.775,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.33666666666674,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 121.03899999999612,
"styleRecalcs": 7,
"styleRecalcDurationMs": 18.682000000000002,
"layouts": 4,
"layoutDurationMs": 1.9649999999999996,
"taskDurationMs": 100.01700000000002,
"heapDeltaBytes": 3322948,
"heapUsedBytes": 68649300,
"domNodes": 110,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 13.344000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 102.41300000006959,
"styleRecalcs": 8,
"styleRecalcDurationMs": 18.653999999999996,
"layouts": 3,
"layoutDurationMs": 1.692,
"taskDurationMs": 78.46300000000001,
"heapDeltaBytes": 3035664,
"heapUsedBytes": 64823340,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.480000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 87a85bed7a9d24fcb85e441867b7f93e641258ce
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16664 +/- ##
==========================================
+ Coverage 83.15% 84.23% +1.08%
==========================================
Files 2972 2274 -698
Lines 146279 129194 -17085
Branches 39639 36272 -3367
==========================================
- Hits 121631 108832 -12799
+ Misses 23372 20066 -3306
+ Partials 1276 296 -980
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
CodeJuggernaut
left a comment
There was a problem hiding this comment.
Honest characterization of the propagation contract; no issues.
| expect(onUpdate).toHaveBeenCalledOnce() | ||
| }) | ||
|
|
||
| it('propagates a malformed Yjs update without recording it', () => { |
There was a problem hiding this comment.
Severity: Minor
What: The malformed-update case stops at FollowerDoc.
Why this is an issue: The caller records lastSeq before this apply fails, a seq desync this test neither covers nor cites.
Proposed Fix: Add the bridge-level case (corrupt N, then N+1 resubscribes), or cite the defect here.
There was a problem hiding this comment.
Left as-is: this PR intentionally characterizes the FollowerDoc boundary only. The bridge-level containment and resubscribe defect is tracked in #16869.
|
Related defect on Severity: Major What: Why this is an issue: A corrupt frame throws after its seq is recorded, the gap detector never trips, and the follower silently freezes. Proposed Fix: Advance |
|
Update: #16372 already carries the fix for this (apply wrapped in try/catch, |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 3 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
| 🟢 Low | 1 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
| const onUpdate = vi.fn() | ||
| follower.addEventListener('update', onUpdate) | ||
|
|
||
| expect(() => follower.applyRemoteUpdate(Uint8Array.of(0))).toThrow( |
There was a problem hiding this comment.
🟡 Medium — This test pins propagation as the contract for malformed remote updates, but the production caller (LayoutFollowerBridge.onDocUpdate) advances lastSeq before calling applyRemoteUpdate and wraps it in no try/catch, so a single corrupt frame throws out of the socket listener while the gap detector now believes the follower is caught up — no reportError(), no resubscribe, and silent divergence for the rest of the session. Consider pinning containment plus recovery (catch, report, resubscribe) instead, or at minimum not baking the throwing behaviour in as intended. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gemini-3.1-pro adversarial, gpt-5.6-sol-max adversarial).
There was a problem hiding this comment.
Deferred to #16869: recovery requires a production bridge change plus bridge-level coverage. This PR remains a characterization of the current FollowerDoc propagation contract.
| 'Unexpected end of array' | ||
| ) | ||
|
|
||
| expect(onUpdate).not.toHaveBeenCalled() |
There was a problem hiding this comment.
🟢 Low — Uint8Array.of(0) fails at the first decode step, so the assertions only cover input that could never partially apply, and the test never asserts follower.doc is unchanged. Yjs integrates struct refs inside a transaction with no rollback, so an update truncated later (e.g. update.slice(0, -1)) can mutate the doc and advance stateVector() while updatesApplied stays 0 — add a doc-state assertion with a truncated real update to actually cover atomicity. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
There was a problem hiding this comment.
Left as-is: this test makes no atomicity claim. It characterizes counters and events for a deterministic first-decode rejection; partial-apply behavior needs separate targeted coverage.
| follower.addEventListener('update', onUpdate) | ||
|
|
||
| expect(() => follower.applyRemoteUpdate(Uint8Array.of(0))).toThrow( | ||
| 'Unexpected end of array' |
There was a problem hiding this comment.
⚪ Nit — Matching 'Unexpected end of array' couples the test to an internal lib0 decoder message via substring match: it will pass on any unrelated error containing that text and break on a yjs/lib0 bump with no behaviour change. Asserting that it throws at all, or on a type this codebase owns, expresses the intent more durably. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
There was a problem hiding this comment.
Left as-is: the exact decoder error is part of this narrow characterization. Matching any thrown error would let an unrelated regression satisfy the test.
There was a problem hiding this comment.
Yeah, but this is still a form of change-detector.
The base branch was changed.
47aa175 to
483b21b
Compare
|
Deployment failed for project comfy-home-v1 with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
483b21b to
1c865fa
Compare
|
Rebased without semantic diff; local checks are green. Hosted CI is still running, so this is not merge-ready yet. Full context for agent readers
Next action: wait for hosted CI and reviewer disposition, then rerun the stale-green guard before any authorized merge. |
|
Brought this up to current Checked the two things a characterization test can quietly lose while it waits. It still characterizes current behaviour, and the malformed-update case is a real guard rather than a restatement: moving One limitation worth stating explicitly, since the test name invites a stronger reading than it earns. It asserts that a malformed update does not advance I have not changed the test to cover that, because tightening it here would overlap the recovery work in flight on #16372 and this PR is deliberately characterization-only. Flagging it so the gap is a known one rather than an assumed-covered one. |
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve
The direct FollowerDoc characterization is useful and the focused test passes. I found one non-blocking naming issue: the current name can be read as a stronger atomic-rejection guarantee than the assertions establish.
Existing findings confirmed or contested
- Sequence recovery coverage: contested for this PR. I confirmed that
LayoutFollowerBridgeadvanceslastSeqbeforeapplyRemoteUpdate, but that behavior predates this test-only diff. This PR explicitly limits itself to the directFollowerDocboundary, so bridge recovery belongs in the separate production recovery change. - Containment and resubscribe: contested for the same scope reason. The missing containment is real production behavior, but this diff neither introduces nor claims to fix it.
- Partial Yjs application: confirmed as a limitation, not an atomicity contract this PR should add. I reproduced a late-truncated update that throws after mutating the destination document and advancing its state vector. The inline naming change avoids implying that the test proves rollback.
- Exact decoder message: confirmed.
FollowerDocdoes not own lib0's message and no caller branches on it. Matching only that an error is thrown would preserve the behavior under a dependency wording change.
Checked and cleared
- The bridge sequence bug is not introduced by this diff and is outside the stated direct-boundary characterization.
- The test does not claim that
Y.Docis unchanged after every malformed update. The issue is the broader wording, not a missing rollback assertion in this PR. - The valid update test uses real Yjs and checks document state, the counter, and the event. It is not mock-only or duplicated by the neighboring composition tests.
- Fallow found no new duplication, complexity, dead-code, dependency, or maintainability issue in the changed file.
Coverage
Standard-depth correctness, maintainability, idiomaticity, tests, and documentation lanes reviewed the full one-file diff. Standard specialist lenses covered blast radius, regression risk, malformed-boundary handling, idempotency, deletion-first maintainability, comments, TypeScript, unit-test quality, mock boundaries, setup ownership, and executed proof. No Playwright lane was applicable because browser_tests/ is unchanged.
Focused Vitest: 1 file, 2 tests passed. ESLint and oxfmt passed. A separate late-truncation experiment reproduced partial Yjs application. All checks ran against 8a639ff74ebd337d98a309c78dcaf535c6b0b8aa.
Co-authored-by: Alexander Brown <drjkl@comfy.org>
8b5c4a7
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve
The automated follow-up only formatted the applied naming suggestion. The renamed test now states the exact truncated-input case and the two asserted outcomes, so the prior P2 naming concern is resolved.
Existing findings
- Exact decoder wording: still confirmed as P3.
FollowerDocdoes not own or translate lib0'sUnexpected end of arraytext, and no caller consumes it. Matching only that the call throws would avoid a dependency-wording change-detector. I am not duplicating the existing inline thread. - Bridge sequence recovery: still contested for this PR. The production concern is real but predates this test-only diff and remains outside its stated direct-boundary scope.
- Containment and resubscribe: still contested for the same scope reason. This head changes no production behavior.
Coverage
Standard-depth correctness, maintainability, idiomaticity, tests, and documentation lanes reviewed the full file and the exact d21772ca..8b5c4a7c follow-up diff. No new finding was introduced by the formatting commit. Fallow found no scoped complexity or duplication issue.
Focused Vitest passed 2/2. Typecheck, changed-file ESLint, type-aware oxlint, and the full format check exited 0. Oxlint reported five unrelated existing warnings. Hosted checks for this SHA have no failures or pending jobs.
…er updates (#18343) Backports #16664 to `cloud/1.54`. The target has the exact production `followerDoc.ts` blob exercised by the source (`a153fabeb0d41945b00ab2710dd10e2024644648`), but lacked the 36-line characterization test. The source merge cherry-picked cleanly with provenance preserved. Verification: - target tip pinned before push: `19a4f18b799f228a0faf39d951c22a4fdb53daf8` - carrier head: `f3a5f6563a` - `git diff --check origin/cloud/1.54...HEAD`: passed - local Vitest/lint/typecheck/build: deferred under the active desktop resource hold; hosted CI is the verification authority Source merge: `0206eb200518e5134dca0534538cbbad0ddf8f49` Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: GitHub Action <action@github.com>
…r updates (#18342) Backports #16664 to `core/1.54`. The target has the exact production `followerDoc.ts` blob exercised by the source (`a153fabeb0d41945b00ab2710dd10e2024644648`), but lacked the 36-line characterization test. The source merge cherry-picked cleanly with provenance preserved. Verification: - target tip pinned before push: `6d2daca629b4e21155ae8270e0fce503da4ee482` - carrier head: `39981a129f` - `git diff --check origin/core/1.54...HEAD`: passed - local Vitest/lint/typecheck/build: deferred under the active desktop resource hold; hosted CI is the verification authority Source merge: `0206eb200518e5134dca0534538cbbad0ddf8f49` Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: GitHub Action <action@github.com>
Summary
Adds focused regression evidence for the current malformed-update boundary in
FollowerDoc.Changes
updatesAppliedcounter.Review Focus
This is characterization only: production error handling, retry, logging, projection, and user-facing behavior are unchanged.
Evidence