Skip to content

[backport cloud/1.54] test(agent-crdt): characterize malformed follower updates - #18343

Merged
DrJKL merged 1 commit into
cloud/1.54from
christian-byrne/backport-16664-cloud-1.54
Sep 22, 2026
Merged

DrJKL merged 1 commit into
cloud/1.54from
christian-byrne/backport-16664-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backports #16664 to cloud/1.54.

The target has the exact production followerDoc.ts blob exercised by the source (a153fabeb0d41945b00ab2710dd10e2024644648), but lacked the 36-line characterization test. The source merge cherry-picked cleanly with provenance preserved.

Verification:

  • target tip pinned before push: 19a4f18b799f228a0faf39d951c22a4fdb53daf8
  • carrier head: f3a5f6563a
  • git diff --check origin/cloud/1.54...HEAD: passed
  • local Vitest/lint/typecheck/build: deferred under the active desktop resource hold; hosted CI is the verification authority

Source merge: 0206eb200518e5134dca0534538cbbad0ddf8f49

## Summary

Adds focused regression evidence for the current malformed-update
boundary in `FollowerDoc`.

## Changes

- **What**: Covers one valid host update and one malformed Yjs update,
including the thrown decode error, absent follower event, and unchanged
`updatesApplied` counter.

## Review Focus

This is characterization only: production error handling, retry,
logging, projection, and user-facing behavior are unchanged.

## Evidence

```text
$ pnpm test:unit src/workbench/extensions/agent/crdt/followerDoc.test.ts
Test Files  1 passed (1)
Tests  2 passed (2)

$ pnpm exec oxfmt --check src/workbench/extensions/agent/crdt/followerDoc.test.ts
All matched files use the correct format.
Finished in 111ms on 1 files using 8 threads.

$ pnpm exec eslint src/workbench/extensions/agent/crdt/followerDoc.test.ts
No output; exit 0.

$ pnpm typecheck
$ vue-tsc --noEmit
No diagnostics; exit 0.
```

<!-- authored-by:agent lane-fec-update-1 -->

---------

Co-authored-by: Alexander Brown <drjkl@comfy.org>
Co-authored-by: GitHub Action <action@github.com>
(cherry picked from commit 0206eb2)
@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: adc8e313-9567-45e9-a00d-c96724681553

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 22, 2026 3:04am UTC

Request Review

@DrJKL
DrJKL enabled auto-merge (squash) September 22, 2026 03:07
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/22/2026, 03:13:20 AM UTC

Links

🎭 Playwright: ✅ 1931 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1910 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.5 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.7 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 127ms TBT · 79.7 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.3 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.4 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 73ms TBT · 172.5 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 441ms TBT · 167.1 MB heap
vue-zoom-out-idle: · 54.6 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.4 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.7 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 547ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 63.5 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -179
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 28ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 73
canvas-mouse-sweep: task duration 889ms
canvas-mouse-sweep: script duration 152ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 66.3 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -180
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 352ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.3 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 438ms
dom-widget-clipping: script duration 155ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 84.3 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 604ms
large-graph-idle: script duration 33ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.5 MB
large-graph-idle: DOM nodes -267
large-graph-idle: event listeners -163
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1576ms
large-graph-pan: script duration 766ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 71.3 MB
large-graph-pan: DOM nodes -280
large-graph-pan: event listeners -95
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1650ms
large-graph-zoom: script duration 755ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.7 MB
large-graph-zoom: DOM nodes 1
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1881ms
legacy-node-drag: script duration 937ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 85.9 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 604ms
minimap-idle: script duration 37ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.5 MB
minimap-idle: DOM nodes -272
minimap-idle: event listeners -179
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 399ms
subgraph-dom-widget-clipping: script duration 140ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.9 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 492ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 62.8 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -210
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 29ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 80
subgraph-mouse-sweep: task duration 808ms
subgraph-mouse-sweep: script duration 101ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 66.0 MB
subgraph-mouse-sweep: DOM nodes -294
subgraph-mouse-sweep: event listeners -242
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 913ms
subgraph-transition-enter: script duration 28ms
subgraph-transition-enter: TBT 127ms
subgraph-transition-enter: heap used 79.7 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 39ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5626ms
viewport-pan-sweep: script duration 2588ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 74.3 MB
viewport-pan-sweep: DOM nodes -272
viewport-pan-sweep: event listeners -163
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17471ms
vue-large-graph-idle: script duration 293ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.4 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 170
vue-large-graph-pan: task duration 21624ms
vue-large-graph-pan: script duration 920ms
vue-large-graph-pan: TBT 73ms
vue-large-graph-pan: heap used 172.5 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 28ms
vue-node-resize-workload: style recalc duration 86ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6307ms
vue-node-resize-workload: script duration 125ms
vue-node-resize-workload: TBT 441ms
vue-node-resize-workload: heap used 167.1 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14930
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8639ms
vue-zoom-out-idle: script duration 146ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 170.4 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 18ms
workflow-execution: layout count 3
workflow-execution: style recalc count 14
workflow-execution: task duration 92ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.7 MB
workflow-execution: DOM nodes 128
workflow-execution: event listeners 50
Raw data
{
  "timestamp": "2026-09-22T03:19:12.299Z",
  "gitSha": "8f971ee4b654f7fdc053720fad3b59c28d676559",
  "branch": "christian-byrne/backport-16664-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2069.1959999999767,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.927,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 597.693,
      "heapDeltaBytes": 2248592,
      "heapUsedBytes": 72117060,
      "domNodes": -280,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 11.108,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2037.9069999999047,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.862,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 495.68300000000005,
      "heapDeltaBytes": -9765480,
      "heapUsedBytes": 60981136,
      "domNodes": -280,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 8.28,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1814.4110000000069,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 27.178,
      "layouts": 14,
      "layoutDurationMs": 4.234,
      "taskDurationMs": 841.9639999999999,
      "heapDeltaBytes": -3143644,
      "heapUsedBytes": 67934292,
      "domNodes": -279,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 145.159,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1916.983000000073,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 28.082000000000004,
      "layouts": 14,
      "layoutDurationMs": 4.186999999999999,
      "taskDurationMs": 935.462,
      "heapDeltaBytes": 1197636,
      "heapUsedBytes": 71036380,
      "domNodes": -281,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 158.028,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1721.3580000000093,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.48,
      "layouts": 6,
      "layoutDurationMs": 1.1470000000000002,
      "taskDurationMs": 357.20799999999997,
      "heapDeltaBytes": 4646956,
      "heapUsedBytes": 75691192,
      "domNodes": 75,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 12.069000000000003,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1664.8179999999684,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 16.236,
      "layouts": 6,
      "layoutDurationMs": 1.054,
      "taskDurationMs": 347.649,
      "heapDeltaBytes": 4350396,
      "heapUsedBytes": 73938796,
      "domNodes": 78,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 10.498000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 636.6450000000441,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.454999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 434.289,
      "heapDeltaBytes": 18758748,
      "heapUsedBytes": 88635656,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 150.89799999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 649.3090000000166,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.755000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 442.113,
      "heapDeltaBytes": 18045264,
      "heapUsedBytes": 88055924,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 158.839,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2029.798000000028,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.477000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 602.778,
      "heapDeltaBytes": 10144316,
      "heapUsedBytes": 86870316,
      "domNodes": -267,
      "jsHeapTotalBytes": -1679360,
      "scriptDurationMs": 32.47,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2033.9089999999942,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.691000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 604.3620000000001,
      "heapDeltaBytes": 9939444,
      "heapUsedBytes": 86091036,
      "domNodes": -266,
      "jsHeapTotalBytes": -892928,
      "scriptDurationMs": 32.943,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2117.0659999999657,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 10.009000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1536.959,
      "heapDeltaBytes": 14206640,
      "heapUsedBytes": 80587224,
      "domNodes": -275,
      "jsHeapTotalBytes": 1798144,
      "scriptDurationMs": 760.388,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2246.393000000012,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 15.906000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1616.0359999999998,
      "heapDeltaBytes": -7728828,
      "heapUsedBytes": 68873628,
      "domNodes": -284,
      "jsHeapTotalBytes": 1466368,
      "scriptDurationMs": 771.544,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3463.23000000001,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.344,
      "layouts": 60,
      "layoutDurationMs": 12.544,
      "taskDurationMs": 1665.2519999999997,
      "heapDeltaBytes": 8513764,
      "heapUsedBytes": 76087852,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 760.308,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3440.4439999999568,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 11.280999999999995,
      "layouts": 60,
      "layoutDurationMs": 12.722000000000001,
      "taskDurationMs": 1634.373,
      "heapDeltaBytes": 8416880,
      "heapUsedBytes": 76412204,
      "domNodes": 2,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 749.457,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2997.0330000000445,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.242,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1876.317,
      "heapDeltaBytes": 22134788,
      "heapUsedBytes": 89951896,
      "domNodes": 0,
      "jsHeapTotalBytes": 1466368,
      "scriptDurationMs": 935.3750000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3099.109999999996,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.152,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1886.32,
      "heapDeltaBytes": 22540132,
      "heapUsedBytes": 90091852,
      "domNodes": 0,
      "jsHeapTotalBytes": 1728512,
      "scriptDurationMs": 938.9289999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2022.325999999964,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 5.769999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 605.1970000000001,
      "heapDeltaBytes": 22164784,
      "heapUsedBytes": 88406876,
      "domNodes": -273,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 40.449,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2037.6270000000432,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 6.106,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 602.517,
      "heapDeltaBytes": 9025592,
      "heapUsedBytes": 86739028,
      "domNodes": -270,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 32.83,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 561.2169999999992,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.197,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 397.651,
      "heapDeltaBytes": 14698372,
      "heapUsedBytes": 87829864,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 139.603,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 622.3599999999578,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.178999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 400.162,
      "heapDeltaBytes": 14971716,
      "heapUsedBytes": 88111816,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 141.20499999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2006.8150000000173,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.917999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 492.19100000000003,
      "heapDeltaBytes": -12825504,
      "heapUsedBytes": 59812044,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.623000000000001,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2008.1349999999247,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.543,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 491.045,
      "heapDeltaBytes": -141432,
      "heapUsedBytes": 71923924,
      "domNodes": -293,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.980999999999998,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1800.2290000000016,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 31.337999999999997,
      "layouts": 18,
      "layoutDurationMs": 5.388000000000001,
      "taskDurationMs": 831.576,
      "heapDeltaBytes": -1753336,
      "heapUsedBytes": 69943860,
      "domNodes": -295,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 103.822,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1707.606999999939,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 26.345999999999997,
      "layouts": 18,
      "layoutDurationMs": 4.555,
      "taskDurationMs": 784.8340000000001,
      "heapDeltaBytes": -4379008,
      "heapUsedBytes": 68487720,
      "domNodes": -293,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 99.16900000000001,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1384.6620000000485,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 30.68200000000001,
      "layouts": 15,
      "layoutDurationMs": 14.467999999999998,
      "taskDurationMs": 912.8780000000003,
      "heapDeltaBytes": -11053928,
      "heapUsedBytes": 83602588,
      "domNodes": 13751,
      "jsHeapTotalBytes": 14942208,
      "scriptDurationMs": 28.098999999999993,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 127,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8297.968999999966,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 37.354,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5528.302,
      "heapDeltaBytes": -17894264,
      "heapUsedBytes": 85347852,
      "domNodes": -267,
      "jsHeapTotalBytes": -1155072,
      "scriptDurationMs": 2527.7180000000003,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8344.014000000016,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 40.073,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5724.603999999999,
      "heapDeltaBytes": -5703920,
      "heapUsedBytes": 70539488,
      "domNodes": -277,
      "jsHeapTotalBytes": 1466368,
      "scriptDurationMs": 2648.044,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18411.284999999963,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17609.147,
      "heapDeltaBytes": -57573384,
      "heapUsedBytes": 177787180,
      "domNodes": -8068,
      "jsHeapTotalBytes": -17334272,
      "scriptDurationMs": 298.79699999999997,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.773333333333238,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18118.94600000005,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17333.612,
      "heapDeltaBytes": -36063808,
      "heapUsedBytes": 181705140,
      "domNodes": -8068,
      "jsHeapTotalBytes": -3309568,
      "scriptDurationMs": 287.215,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22331.886,
      "styleRecalcs": 168,
      "styleRecalcDurationMs": 21.520999999999958,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22073.544,
      "heapDeltaBytes": -35582248,
      "heapUsedBytes": 182771584,
      "domNodes": -8068,
      "jsHeapTotalBytes": -9994240,
      "scriptDurationMs": 905.022,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 112,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21502.948999999942,
      "styleRecalcs": 171,
      "styleRecalcDurationMs": 19.457999999999977,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21174.416,
      "heapDeltaBytes": -39801764,
      "heapUsedBytes": 178939844,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10498048,
      "scriptDurationMs": 934.211,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 33,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6469.363999999985,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 85.81099999999996,
      "layouts": 20,
      "layoutDurationMs": 30.245999999999995,
      "taskDurationMs": 6338.288,
      "heapDeltaBytes": -55216572,
      "heapUsedBytes": 175093668,
      "domNodes": -8068,
      "jsHeapTotalBytes": 2969600,
      "scriptDurationMs": 115.013,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 446,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6380.0869999998895,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 85.443,
      "layouts": 20,
      "layoutDurationMs": 26.012000000000008,
      "taskDurationMs": 6276.548999999999,
      "heapDeltaBytes": -50856136,
      "heapUsedBytes": 175386588,
      "domNodes": -8068,
      "jsHeapTotalBytes": 3010560,
      "scriptDurationMs": 134.549,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 436,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9028.108000000031,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8670.875999999998,
      "heapDeltaBytes": 20539732,
      "heapUsedBytes": 179056864,
      "domNodes": 0,
      "jsHeapTotalBytes": -6815744,
      "scriptDurationMs": 148.312,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.330000000000048,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9012.579999999958,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8607.797999999999,
      "heapDeltaBytes": 6921712,
      "heapUsedBytes": 178336152,
      "domNodes": 0,
      "jsHeapTotalBytes": -9699328,
      "scriptDurationMs": 142.82600000000002,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 463.67799999995896,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 23.27,
      "layouts": 4,
      "layoutDurationMs": 1.953,
      "taskDurationMs": 117.202,
      "heapDeltaBytes": 5079076,
      "heapUsedBytes": 73995476,
      "domNodes": 149,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 14.44,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 100.7600000000366,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 13.501000000000001,
      "layouts": 2,
      "layoutDurationMs": 0.595,
      "taskDurationMs": 65.80100000000002,
      "heapDeltaBytes": 3007648,
      "heapUsedBytes": 72190976,
      "domNodes": 106,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 4.475999999999999,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666665,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 22, 2026
@codecov

codecov Bot commented Sep 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18343   +/-   ##
=============================================
  Coverage              ?   78.49%           
=============================================
  Files                 ?     2005           
  Lines                 ?   110642           
  Branches              ?    33406           
=============================================
  Hits                  ?    86848           
  Misses                ?    23615           
  Partials              ?      179           
Flag Coverage Δ
unit 78.49% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL
DrJKL merged commit 5b91184 into cloud/1.54 Sep 22, 2026
92 checks passed
@DrJKL
DrJKL deleted the christian-byrne/backport-16664-cloud-1.54 branch September 22, 2026 03:33
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-only Agent tests, fixtures and test support only; no production changes agent-test-unit Touches Agent-related unit/component tests or their support labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-only Agent tests, fixtures and test support only; no production changes agent-test-unit Touches Agent-related unit/component tests or their support risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants