Repository navigation
fix(e2e): remove stale VHS per_batch value-drift allowlist entries - #16650
Conversation
VHS_VAEDecodeBatched.per_batch / VHS_VAEEncodeBatched.per_batch no longer drift on save/reload, so the ROUNDTRIP_VALUE_ALLOWED_KEYS_LITEGRAPH/_VUE entries in valueDrift.ts are stale and fail allNodes.spec.ts's S3 staleValueDriftKeys assertion on every PR based on current main. Removes the matching ROUNDTRIP_VALUE_ALLOWLIST entry in allNodesRoundtripTier.ts to satisfy the bidirectional exact-renderer-contract check. Root cause identified in qax-19 (four disjoint PRs failing identical custom_nodes_e2e shards: #16365, #16406, #16462, #16555).
|
Warning Review limit reachedNext included review available in 14 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Comment |
🎭 Playwright: ✅ 1898 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 9.68 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.42 MB (baseline 1.42 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.59 MB (baseline 3.59 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 295 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-02T13:18:01.020Z",
"gitSha": "a491c776bb3145db62d37b14a12aa707a8e37972",
"branch": "op8b/fix-valuedrift-stale-keys",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2058.899999999994,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.120000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.887,
"heapDeltaBytes": 5353564,
"heapUsedBytes": 75239468,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.295,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2018.0689999999686,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.193999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.733,
"heapDeltaBytes": -10879536,
"heapUsedBytes": 59443252,
"domNodes": -279,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.467000000000001,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1740.349999999978,
"styleRecalcs": 74,
"styleRecalcDurationMs": 23.391999999999996,
"layouts": 14,
"layoutDurationMs": 3.0669999999999997,
"taskDurationMs": 637.954,
"heapDeltaBytes": 10695868,
"heapUsedBytes": 81097988,
"domNodes": -279,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 99.368,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1691.3879999999608,
"styleRecalcs": 74,
"styleRecalcDurationMs": 23.625999999999998,
"layouts": 14,
"layoutDurationMs": 3.068,
"taskDurationMs": 656.956,
"heapDeltaBytes": -7012596,
"heapUsedBytes": 63689704,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 102.442,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1672.171999999989,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.029,
"layouts": 6,
"layoutDurationMs": 0.9219999999999998,
"taskDurationMs": 290.525,
"heapDeltaBytes": 4470144,
"heapUsedBytes": 74375472,
"domNodes": 79,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.413999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1680.7369999999082,
"styleRecalcs": 29,
"styleRecalcDurationMs": 15.820999999999998,
"layouts": 6,
"layoutDurationMs": 1.0519999999999998,
"taskDurationMs": 296.462,
"heapDeltaBytes": 5075912,
"heapUsedBytes": 75698444,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.399000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 543.852999999956,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.3359999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.337,
"heapDeltaBytes": -8037496,
"heapUsedBytes": 62692760,
"domNodes": 18,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 118.556,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 517.0519999999215,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.101,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 335.21099999999996,
"heapDeltaBytes": -8105900,
"heapUsedBytes": 62472072,
"domNodes": 20,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 111.967,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2034.973999999977,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.913,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.18799999999993,
"heapDeltaBytes": -13148728,
"heapUsedBytes": 87577884,
"domNodes": -264,
"jsHeapTotalBytes": -1626112,
"scriptDurationMs": 28.489,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2045.1480000000402,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.489,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.532,
"heapDeltaBytes": -13985700,
"heapUsedBytes": 86340520,
"domNodes": -263,
"jsHeapTotalBytes": -839680,
"scriptDurationMs": 28.062000000000005,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2078.5769999999957,
"styleRecalcs": 65,
"styleRecalcDurationMs": 8.337000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1242.393,
"heapDeltaBytes": 22164416,
"heapUsedBytes": 88177688,
"domNodes": 6,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 605.7719999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2097.299000000021,
"styleRecalcs": 66,
"styleRecalcDurationMs": 8.646999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1213.773,
"heapDeltaBytes": 10158188,
"heapUsedBytes": 87162440,
"domNodes": -274,
"jsHeapTotalBytes": -1437696,
"scriptDurationMs": 563.182,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3164.771999999971,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.803,
"layouts": 60,
"layoutDurationMs": 11.977000000000002,
"taskDurationMs": 1308.9820000000002,
"heapDeltaBytes": 8489360,
"heapUsedBytes": 75553832,
"domNodes": -277,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 567.971,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3110.8829999999443,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.305,
"layouts": 60,
"layoutDurationMs": 12.255,
"taskDurationMs": 1320.552,
"heapDeltaBytes": 7723996,
"heapUsedBytes": 75375056,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 570.121,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2303.003999999987,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.1389999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1364.267,
"heapDeltaBytes": 13714884,
"heapUsedBytes": 81026448,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 650.657,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2281.8039999999655,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.5870000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1396.498,
"heapDeltaBytes": 13595316,
"heapUsedBytes": 81044276,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 650.171,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2017.5930000000335,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.3210000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.056,
"heapDeltaBytes": -14979436,
"heapUsedBytes": 86859440,
"domNodes": -266,
"jsHeapTotalBytes": -1888256,
"scriptDurationMs": 31.009999999999994,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 1995.5999999999676,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.7040000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.19300000000004,
"heapDeltaBytes": 22228676,
"heapUsedBytes": 88373448,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 27.637999999999995,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 525.5470000000173,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 301.66700000000003,
"heapDeltaBytes": 15185248,
"heapUsedBytes": 88010656,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 96.726,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 523.2579999999416,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.032000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 320.307,
"heapDeltaBytes": 14886116,
"heapUsedBytes": 87874224,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 104.825,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.961000000033,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.181000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.066,
"heapDeltaBytes": 8216332,
"heapUsedBytes": 80647396,
"domNodes": -293,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.888000000000002,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1993.1629999999814,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.616,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.957,
"heapDeltaBytes": -8581400,
"heapUsedBytes": 64080492,
"domNodes": -294,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.898999999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.8360000000334,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.876,
"layouts": 18,
"layoutDurationMs": 3.8289999999999993,
"taskDurationMs": 645.144,
"heapDeltaBytes": 10385956,
"heapUsedBytes": 82406996,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 72.119,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.2050000000636,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.632,
"layouts": 18,
"layoutDurationMs": 4.5360000000000005,
"taskDurationMs": 662.2040000000001,
"heapDeltaBytes": -316920,
"heapUsedBytes": 71523744,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 79.569,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 882.4749999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.895,
"layouts": 16,
"layoutDurationMs": 10.157,
"taskDurationMs": 687.9089999999999,
"heapDeltaBytes": -3659780,
"heapUsedBytes": 94208352,
"domNodes": 13751,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 22.052000000000003,
"eventListeners": 2381,
"totalBlockingTimeMs": 105,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8137.18300000005,
"styleRecalcs": 249,
"styleRecalcDurationMs": 31.42,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4378.156,
"heapDeltaBytes": -15676756,
"heapUsedBytes": 84897996,
"domNodes": -266,
"jsHeapTotalBytes": -352256,
"scriptDurationMs": 1921.0259999999998,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8197.281999999974,
"styleRecalcs": 249,
"styleRecalcDurationMs": 30.709000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4498.338000000001,
"heapDeltaBytes": 14977492,
"heapUsedBytes": 91146004,
"domNodes": -266,
"jsHeapTotalBytes": -1437696,
"scriptDurationMs": 2003.3590000000002,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12637.176999999952,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11874.819000000001,
"heapDeltaBytes": -29534780,
"heapUsedBytes": 175076300,
"domNodes": -6548,
"jsHeapTotalBytes": -1245184,
"scriptDurationMs": 187.863,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12654.346999999916,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11870.856,
"heapDeltaBytes": -13472936,
"heapUsedBytes": 174254636,
"domNodes": -6548,
"jsHeapTotalBytes": 2625536,
"scriptDurationMs": 220.704,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 15497.368999999992,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.535999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14925.910000000002,
"heapDeltaBytes": -19319480,
"heapUsedBytes": 190007028,
"domNodes": -6548,
"jsHeapTotalBytes": -3682304,
"scriptDurationMs": 729.391,
"eventListeners": -7473,
"totalBlockingTimeMs": 62,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 15570.517999999993,
"styleRecalcs": 87,
"styleRecalcDurationMs": 14.315999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15061.544,
"heapDeltaBytes": -530868,
"heapUsedBytes": 187244488,
"domNodes": -6548,
"jsHeapTotalBytes": -1118208,
"scriptDurationMs": 794.08,
"eventListeners": -7473,
"totalBlockingTimeMs": 56,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4362.786000000028,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.13199999999999,
"layouts": 20,
"layoutDurationMs": 24.110999999999994,
"taskDurationMs": 4267.59,
"heapDeltaBytes": -6806916,
"heapUsedBytes": 180894096,
"domNodes": -6548,
"jsHeapTotalBytes": 18874368,
"scriptDurationMs": 75.396,
"eventListeners": -7473,
"totalBlockingTimeMs": 36,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4548.6439999999675,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.56800000000001,
"layouts": 20,
"layoutDurationMs": 21.670999999999996,
"taskDurationMs": 4449.226000000001,
"heapDeltaBytes": -38914032,
"heapUsedBytes": 176720144,
"domNodes": -6548,
"jsHeapTotalBytes": 12832768,
"scriptDurationMs": 78.16399999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 51,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "workflow-execution",
"durationMs": 88.00299999995786,
"styleRecalcs": 7,
"styleRecalcDurationMs": 10.798,
"layouts": 2,
"layoutDurationMs": 0.568,
"taskDurationMs": 60.26100000000001,
"heapDeltaBytes": 3108536,
"heapUsedBytes": 70195340,
"domNodes": 109,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.188,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 442.9450000000088,
"styleRecalcs": 14,
"styleRecalcDurationMs": 14.442,
"layouts": 3,
"layoutDurationMs": 0.7060000000000001,
"taskDurationMs": 81.87,
"heapDeltaBytes": 4785764,
"heapUsedBytes": 73358244,
"domNodes": 119,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.487999999999999,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16650 +/- ##
==========================================
+ Coverage 80.74% 82.36% +1.61%
==========================================
Files 2440 2031 -409
Lines 124530 117289 -7241
Branches 31139 29407 -1732
==========================================
- Hits 100553 96604 -3949
+ Misses 23475 20507 -2968
+ Partials 502 178 -324
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…y-Org#16676) Human Ben: This fixes the issues causing the E2E Custom Nodes Tests to fail. ## Summary S3 reported value drift on all 82 ComfyUI-VideoHelperSuite nodes even though no value changed. `widgets_values` is a union of a positional array and a name-keyed record (`zWidgetValues = z.union([z.array(z.any()), z.record(z.any())])`), and VHS rewrites its own nodes to the record form in `onSerialize`: ```js chainCallback(this, "onSerialize", function(info) { info.widgets_values = {}; for (let w of this.widgets) info.widgets_values[w.name] = w.value; }); ``` The tier compared the raw value, so a legal reshape read as drift on every widget: ``` VHS_DuplicateImages: widgets_values [1] -> {"multiply_by":1} on pristine reload VHS_MergeImages: ["match A","nearest-exact","disabled"] -> {"merge_strategy":"match A","scale_method":"nearest-exact","crop":"disabled"} ``` This is correct pack behaviour and schema-legal, so the test was wrong — not the product. ## Changes - When only the shape differs, key both sides by widget name before comparing. Identical values in different containers no longer read as drift; a real value change still fails. - Normalization engages only when `Array.isArray(before) !== Array.isArray(after)`. Same-shape comparisons keep their existing strict/non-strict paths untouched, so detection is unchanged everywhere it already works. - Names come from a new serializer-aligned list. Positional `widgets_values` omits `serialize === false` widgets, so the full widget list would shift every index after the first hidden one and compare the wrong pairs. ## Why not ledger it Adding 82 entries would have recreated the stale-entry problem that produced the failures this is chasing: entries stop reproducing after an upstream change, then fail closed as stale. Normalizing the comparison keeps the tier able to detect genuine drift with no calibration surface to rot. ## Testing - Browser typecheck, ESLint, oxfmt clean. - Full custom-node suite dispatched on this branch; `core:1/2` and `cloud 2/5` are the VHS-carrying slices that fail on `main`. No unit test: this logic lives inside a `page.evaluate` closure that Playwright stringifies, so it cannot import a shared helper, and duplicating it into a testable module would leave two copies to drift. The file's existing helpers (`preserves`, `byId`) are inline for the same reason. The E2E run against the real pack is the proof. ## Context `main` is currently red on exactly these two slices. This is unrelated to the earlier stale-allowlist failures fixed in Comfy-Org#16650 — that fix is what exposed this.
Problem
browser_tests/fixtures/customNode/valueDrift.tshad twoROUNDTRIP_VALUE_ALLOWED_KEYS_LITEGRAPH/_VUEentries forComfyUI-VideoHelperSuite(VHS_VAEDecodeBatched.per_batch,VHS_VAEEncodeBatched.per_batch) that no longer actually drift on save/reload. This failsallNodes.spec.ts's S3 exact-contracts assertion (staleValueDriftKeys) on every PR based on currentmain, because the assertion flags an allowed key as stale once it's no longer observed drifting.Root cause identified in
qax-19: four disjoint PRs were failing identicalcustom_nodes_e2eshards on this same VHS baseline — #16365, #16406, #16462, #16555.Fix
ComfyUI-VideoHelperSuiteentries fromROUNDTRIP_VALUE_ALLOWED_KEYS_LITEGRAPH/ROUNDTRIP_VALUE_ALLOWED_KEYS_VUEinvalueDrift.ts.ROUNDTRIP_VALUE_ALLOWLISTentry inallNodesRoundtripTier.ts— the two ledgers are cross-checked bidirectionally (every exact-value-drift node needs aROUNDTRIP_VALUE_ALLOWLISTreason and vice versa), so leaving the allowlist entry behind would tripROUNDTRIP_VALUE_ALLOWLIST entry ... has no exact renderer contract.interactionProfiles/ComfyUI-VideoHelperSuite.jsonfixture mentions the node names, for a different purpose).Verification
pnpm exec vitest run browser_tests/fixtures/customNode/valueDrift.test.ts— 14/14 pass.pnpm typecheck(vue-tsc --noEmit) — clean.oxfmt --check/oxlinton both changed files — clean.allNodes.spec.tsS3 Playwright tier here (needs a real browser + live custom-node pack manifests); the fix follows directly from readingstaleValueDriftKeys's semantics and the bidirectional ledger check inallNodesRoundtripTier.ts, so this should resolve the shard failures on Restore the CRDT debug instrument #16365/test(ui): port shared media slice coverage #16406/test: cover FE follower projection convergence #16462/test(crdt): assert follower node-slot parity across batch boundaries (R-96) #16555 once their CI reruns.Source:
valuedrift-1/qax-19.