Skip to content

fix(e2e): remove stale VHS per_batch value-drift allowlist entries - #16650

Merged
christian-byrne merged 1 commit into
mainfrom
op8b/fix-valuedrift-stale-keys
Sep 2, 2026
Merged

christian-byrne merged 1 commit into
mainfrom
op8b/fix-valuedrift-stale-keys

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Problem

browser_tests/fixtures/customNode/valueDrift.ts had two ROUNDTRIP_VALUE_ALLOWED_KEYS_LITEGRAPH/_VUE entries for ComfyUI-VideoHelperSuite (VHS_VAEDecodeBatched.per_batch, VHS_VAEEncodeBatched.per_batch) that no longer actually drift on save/reload. This fails allNodes.spec.ts's S3 exact-contracts assertion (staleValueDriftKeys) on every PR based on current main, because the assertion flags an allowed key as stale once it's no longer observed drifting.

Root cause identified in qax-19: four disjoint PRs were failing identical custom_nodes_e2e shards on this same VHS baseline — #16365, #16406, #16462, #16555.

Fix

  • Removed the stale ComfyUI-VideoHelperSuite entries from ROUNDTRIP_VALUE_ALLOWED_KEYS_LITEGRAPH / ROUNDTRIP_VALUE_ALLOWED_KEYS_VUE in valueDrift.ts.
  • Removed the matching ROUNDTRIP_VALUE_ALLOWLIST entry in allNodesRoundtripTier.ts — the two ledgers are cross-checked bidirectionally (every exact-value-drift node needs a ROUNDTRIP_VALUE_ALLOWLIST reason and vice versa), so leaving the allowlist entry behind would trip ROUNDTRIP_VALUE_ALLOWLIST entry ... has no exact renderer contract.
  • Confirmed no other pack references either of the two removed node/key pairs (only an unrelated interactionProfiles/ComfyUI-VideoHelperSuite.json fixture mentions the node names, for a different purpose).

Verification

Source: valuedrift-1 / qax-19.

VHS_VAEDecodeBatched.per_batch / VHS_VAEEncodeBatched.per_batch no longer
drift on save/reload, so the ROUNDTRIP_VALUE_ALLOWED_KEYS_LITEGRAPH/_VUE
entries in valueDrift.ts are stale and fail allNodes.spec.ts's S3
staleValueDriftKeys assertion on every PR based on current main. Removes
the matching ROUNDTRIP_VALUE_ALLOWLIST entry in allNodesRoundtripTier.ts
to satisfy the bidirectional exact-renderer-contract check.

Root cause identified in qax-19 (four disjoint PRs failing identical
custom_nodes_e2e shards: #16365, #16406, #16462, #16555).
@christian-byrne
christian-byrne requested a review from a team September 2, 2026 13:05
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 14 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: c6961220-2647-488b-839a-f0c912289524

📥 Commits

Reviewing files that changed from the base of the PR and between 26eba65 and 1d5e4ae.

📒 Files selected for processing (2)
  • browser_tests/fixtures/customNode/allNodesRoundtripTier.ts
  • browser_tests/fixtures/customNode/valueDrift.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1898 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1877 / ❌ 0 / ⚠️ 2 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle: 9.68 MB gzip ⚪ 0 B

Details

Summary

  • Raw size: 41 MB baseline 41 MB — ⚪ 0 B
  • Gzip: 9.68 MB baseline 9.68 MB — ⚪ 0 B
  • Brotli: 6.81 MB baseline 6.81 MB — ⚪ 0 B
  • Bundles: 447 current • 447 baseline

Category Glance
Vendor & Third-Party ⚪ 0 B (18.1 MB) · Other ⚪ 0 B (16.4 MB) · Data & Services ⚪ 0 B (3.59 MB) · Graph Workspace ⚪ 0 B (1.42 MB) · Panels & Settings ⚪ 0 B (621 kB) · Utilities & Hooks ⚪ 0 B (560 kB) · + 5 more

App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 B

Main entry bundles and manifests

Status: 1 unchanged

Graph Workspace — 1.42 MB (baseline 1.42 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

Status: 3 unchanged

Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

Status: 17 unchanged

Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

Status: 27 unchanged

User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

Status: 11 unchanged

Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

Status: 8 unchanged

UI Components — 117 kB (baseline 117 kB) • ⚪ 0 B

Reusable component library chunks

Status: 15 unchanged

Data & Services — 3.59 MB (baseline 3.59 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

Status: 16 unchanged

Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

Status: 36 unchanged

Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 18 unchanged

Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 B

Bundles that do not match a named category

Status: 295 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.0 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.6 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.0 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 105ms TBT · 89.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 166.6 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 59ms TBT · 179.9 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 44ms TBT · 170.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.5 MB heap

⚠️ 4 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
canvas-zoom-sweep: layout duration 1ms 1ms -1% ⚠️ z=7.6
dom-widget-clipping: script duration 164ms 115ms -30% ⚠️ z=14.6
large-graph-pan: task duration 1628ms 1228ms -25% ⚠️ z=3.4
large-graph-pan: script duration 810ms 584ms -28% ⚠️ z=8.9
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms +0% z=0.4
canvas-idle: p95 frame time 17ms 17ms -0% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 9ms 7ms -22% z=-4.7
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 9 10 +11% z=-2.1
canvas-idle: task duration 494ms 448ms -9% z=1.7
canvas-idle: script duration 9ms 8ms -7% z=-7.8
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 54.5 MB 64.2 MB +18% —
canvas-idle: DOM nodes -280 -280 -0% z=-236.9
canvas-idle: event listeners -150 -150 +0% z=-34.1
canvas-mouse-sweep: avg frame time 17ms 17ms -0% z=-0.9
canvas-mouse-sweep: p95 frame time 17ms 17ms +0% —
canvas-mouse-sweep: layout duration 5ms 3ms -33% z=-2.8
canvas-mouse-sweep: style recalc duration 39ms 24ms -40% z=-6.0
canvas-mouse-sweep: layout count 14 14 +0% —
canvas-mouse-sweep: style recalc count 77 74 -4% z=-2.0
canvas-mouse-sweep: task duration 923ms 647ms -30% z=-3.7
canvas-mouse-sweep: script duration 164ms 101ms -39% z=-5.4
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 58.9 MB 69.0 MB +17% —
canvas-mouse-sweep: DOM nodes -282 -279 -1% z=-131.8
canvas-mouse-sweep: event listeners -152 -150 -1% z=-38.0
canvas-zoom-sweep: avg frame time 17ms 17ms -0% z=0.5
canvas-zoom-sweep: p95 frame time 17ms 17ms +0% —
canvas-zoom-sweep: layout duration 1ms 1ms -1% ⚠️ z=7.6
canvas-zoom-sweep: style recalc duration 16ms 14ms -10% z=-3.4
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 31 30 -3% z=-2.8
canvas-zoom-sweep: task duration 357ms 293ms -18% z=-1.5
canvas-zoom-sweep: script duration 10ms 9ms -8% z=-5.9
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 72.2 MB 71.6 MB -1% —
canvas-zoom-sweep: DOM nodes 76 78 +3% z=-1.6
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.9
dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.1
dom-widget-clipping: p95 frame time 17ms 17ms -0% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 9ms 5ms -39% z=-5.9
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 12 12 -4% z=-3.2
dom-widget-clipping: task duration 452ms 342ms -24% z=-1.4
dom-widget-clipping: script duration 164ms 115ms -30% ⚠️ z=14.6
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 60.0 MB 59.7 MB -1% —
dom-widget-clipping: DOM nodes 20 19 -5% z=-2.2
dom-widget-clipping: event listeners 2 1 -50% variance too high
large-graph-idle: avg frame time 17ms 17ms +0% z=-0.2
large-graph-idle: p95 frame time 17ms 17ms +0% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 5ms 4ms -22% z=-7.7
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 5 8 +50% z=-13.1
large-graph-idle: task duration 593ms 492ms -17% z=-0.9
large-graph-idle: script duration 33ms 28ms -15% z=-7.1
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 82.8 MB 82.9 MB +0% —
large-graph-idle: DOM nodes -269 -264 -2% z=-318.8
large-graph-idle: event listeners -148 -146 -1% z=-28.2
large-graph-pan: avg frame time 17ms 17ms +0% z=0.8
large-graph-pan: p95 frame time 17ms 17ms -0% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 9ms 8ms -2% z=-11.0
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 63 66 +4% z=-6.4
large-graph-pan: task duration 1628ms 1228ms -25% ⚠️ z=3.4
large-graph-pan: script duration 810ms 584ms -28% ⚠️ z=8.9
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 79.9 MB 83.6 MB +5% —
large-graph-pan: DOM nodes -274 -134 -51% z=-92.7
large-graph-pan: event listeners 6 -85 -1517% z=-108.6
large-graph-zoom: avg frame time 17ms 17ms +0% —
large-graph-zoom: p95 frame time 17ms 17ms -0% —
large-graph-zoom: layout duration 12ms 12ms +4% —
large-graph-zoom: style recalc duration 10ms 11ms +6% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 61 62 +2% —
large-graph-zoom: task duration 1673ms 1315ms -21% —
large-graph-zoom: script duration 761ms 569ms -25% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 72.8 MB 72.0 MB -1% —
large-graph-zoom: DOM nodes -276 -137 -51% —
large-graph-zoom: event listeners 8 8 +0% —
legacy-node-drag: avg frame time 17ms 17ms +0% —
legacy-node-drag: p95 frame time 17ms 17ms -0% —
legacy-node-drag: layout duration 0ms 0ms +0% —
legacy-node-drag: style recalc duration 5ms 6ms +22% —
legacy-node-drag: layout count 0 0 +0% —
legacy-node-drag: style recalc count 40 44 +9% —
legacy-node-drag: task duration 1918ms 1380ms -28% —
legacy-node-drag: script duration 966ms 650ms -33% —
legacy-node-drag: TBT 0ms 0ms +0% —
legacy-node-drag: heap used 83.4 MB 77.3 MB -7% —
legacy-node-drag: DOM nodes 0 7 — —
legacy-node-drag: event listeners 188 186 -1% —
minimap-idle: avg frame time 17ms 17ms +0% z=0.7
minimap-idle: p95 frame time 17ms 17ms +0% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 2ms 3ms +60% z=-8.0
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 2 5 +150% z=-6.7
minimap-idle: task duration 549ms 465ms -15% z=-1.3
minimap-idle: script duration 32ms 29ms -10% z=-7.0
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 84.1 MB 83.6 MB -1% —
minimap-idle: DOM nodes -273 -270 -1% z=-211.0
minimap-idle: event listeners -148 -85 -43% z=-135.7
subgraph-dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.1
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms +0% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 11ms 8ms -29% z=-5.5
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 46 47 +1% z=-2.5
subgraph-dom-widget-clipping: task duration 413ms 311ms -25% z=-3.6
subgraph-dom-widget-clipping: script duration 143ms 101ms -29% z=-4.3
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 83.4 MB 83.9 MB +1% —
subgraph-dom-widget-clipping: DOM nodes 18 19 +6% z=-2.8
subgraph-dom-widget-clipping: event listeners 6 7 +17% z=-1.6
subgraph-idle: avg frame time 17ms 17ms +0% z=-0.2
subgraph-idle: p95 frame time 17ms 17ms -0% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 8ms 6ms -23% z=-5.8
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 9 11 +17% z=-0.6
subgraph-idle: task duration 483ms 405ms -16% z=1.1
subgraph-idle: script duration 8ms 7ms -9% z=-5.0
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 61.7 MB 69.0 MB +12% —
subgraph-idle: DOM nodes -295 -294 -1% z=-210.9
subgraph-idle: event listeners -196 -211 +8% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms +0% z=0.8
subgraph-mouse-sweep: p95 frame time 17ms 17ms -0% —
subgraph-mouse-sweep: layout duration 5ms 4ms -14% z=-1.6
subgraph-mouse-sweep: style recalc duration 36ms 26ms -27% z=-4.9
subgraph-mouse-sweep: layout count 18 18 +0% —
subgraph-mouse-sweep: style recalc count 78 77 -1% z=-1.6
subgraph-mouse-sweep: task duration 816ms 654ms -20% z=-1.6
subgraph-mouse-sweep: script duration 107ms 76ms -29% z=-3.8
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 56.2 MB 73.4 MB +31% —
subgraph-mouse-sweep: DOM nodes -294 -296 +1% z=-162.2
subgraph-mouse-sweep: event listeners -196 -226 +15% variance too high
subgraph-transition-enter: avg frame time 17ms 17ms +0% —
subgraph-transition-enter: p95 frame time 17ms 17ms +0% —
subgraph-transition-enter: layout duration 16ms 10ms -36% —
subgraph-transition-enter: style recalc duration 33ms 24ms -27% —
subgraph-transition-enter: layout count 16 16 +0% —
subgraph-transition-enter: style recalc count 20 20 +0% —
subgraph-transition-enter: task duration 943ms 688ms -27% —
subgraph-transition-enter: script duration 30ms 22ms -25% —
subgraph-transition-enter: TBT 144ms 105ms -27% —
subgraph-transition-enter: heap used 82.5 MB 89.8 MB +9% —
subgraph-transition-enter: DOM nodes 13751 13751 +0% —
subgraph-transition-enter: event listeners 2381 2381 +0% —
viewport-pan-sweep: avg frame time 17ms 17ms -0% —
viewport-pan-sweep: p95 frame time 17ms 17ms -0% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 35ms 31ms -11% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 248 249 +0% —
viewport-pan-sweep: task duration 5790ms 4438ms -23% —
viewport-pan-sweep: script duration 2660ms 1962ms -26% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 82.5 MB 83.9 MB +2% —
viewport-pan-sweep: DOM nodes -266 -266 +0% —
viewport-pan-sweep: event listeners -162 -147 -9% —
vue-large-graph-idle: avg frame time 18ms 18ms -2% —
vue-large-graph-idle: p95 frame time 17ms 17ms -0% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 16449ms 11873ms -28% —
vue-large-graph-idle: script duration 281ms 204ms -27% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 167.7 MB 166.6 MB -1% —
vue-large-graph-idle: DOM nodes -6548 -6548 +0% —
vue-large-graph-idle: event listeners -7473 -7473 +0% —
vue-large-graph-pan: avg frame time 18ms 17ms -3% —
vue-large-graph-pan: p95 frame time 17ms 17ms -0% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 17ms 14ms -19% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 167 82 -51% —
vue-large-graph-pan: task duration 20555ms 14994ms -27% —
vue-large-graph-pan: script duration 906ms 762ms -16% —
vue-large-graph-pan: TBT 74ms 59ms -20% —
vue-large-graph-pan: heap used 168.2 MB 179.9 MB +7% —
vue-large-graph-pan: DOM nodes -6548 -6548 +0% —
vue-large-graph-pan: event listeners -7469 -7473 +0% —
vue-node-resize-workload: avg frame time 18ms 18ms -2% —
vue-node-resize-workload: p95 frame time 17ms 17ms -0% —
vue-node-resize-workload: layout duration 23ms 23ms +1% —
vue-node-resize-workload: style recalc duration 81ms 61ms -24% —
vue-node-resize-workload: layout count 20 20 +0% —
vue-node-resize-workload: style recalc count 20 20 +0% —
vue-node-resize-workload: task duration 6102ms 4358ms -29% —
vue-node-resize-workload: script duration 110ms 77ms -30% —
vue-node-resize-workload: TBT 383ms 44ms -89% —
vue-node-resize-workload: heap used 172.1 MB 170.5 MB -1% —
vue-node-resize-workload: DOM nodes -6548 -6548 +0% —
vue-node-resize-workload: event listeners -7471 -7472 +0% —
workflow-execution: avg frame time 17ms 17ms -0% z=0.1
workflow-execution: p95 frame time 17ms 17ms -1% —
workflow-execution: layout duration 1ms 1ms -32% z=-6.3
workflow-execution: style recalc duration 18ms 13ms -30% z=-5.3
workflow-execution: layout count 3 3 -17% z=-4.5
workflow-execution: style recalc count 12 11 -13% z=-3.6
workflow-execution: task duration 100ms 71ms -29% z=-4.8
workflow-execution: script duration 8ms 6ms -23% z=-7.8
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 68.9 MB 68.5 MB -1% —
workflow-execution: DOM nodes 119 114 -4% z=-6.6
workflow-execution: event listeners 67 49 -27% z=-0.7
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-09-02T13:18:01.020Z",
  "gitSha": "a491c776bb3145db62d37b14a12aa707a8e37972",
  "branch": "op8b/fix-valuedrift-stale-keys",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2058.899999999994,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.120000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 478.887,
      "heapDeltaBytes": 5353564,
      "heapUsedBytes": 75239468,
      "domNodes": -280,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.295,
      "eventListeners": -150,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2018.0689999999686,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.193999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 416.733,
      "heapDeltaBytes": -10879536,
      "heapUsedBytes": 59443252,
      "domNodes": -279,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.467000000000001,
      "eventListeners": -150,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1740.349999999978,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 23.391999999999996,
      "layouts": 14,
      "layoutDurationMs": 3.0669999999999997,
      "taskDurationMs": 637.954,
      "heapDeltaBytes": 10695868,
      "heapUsedBytes": 81097988,
      "domNodes": -279,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 99.368,
      "eventListeners": -150,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1691.3879999999608,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 23.625999999999998,
      "layouts": 14,
      "layoutDurationMs": 3.068,
      "taskDurationMs": 656.956,
      "heapDeltaBytes": -7012596,
      "heapUsedBytes": 63689704,
      "domNodes": -278,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 102.442,
      "eventListeners": -150,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1672.171999999989,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 12.029,
      "layouts": 6,
      "layoutDurationMs": 0.9219999999999998,
      "taskDurationMs": 290.525,
      "heapDeltaBytes": 4470144,
      "heapUsedBytes": 74375472,
      "domNodes": 79,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 9.413999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1680.7369999999082,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 15.820999999999998,
      "layouts": 6,
      "layoutDurationMs": 1.0519999999999998,
      "taskDurationMs": 296.462,
      "heapDeltaBytes": 5075912,
      "heapUsedBytes": 75698444,
      "domNodes": 77,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 9.399000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 543.852999999956,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.3359999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 348.337,
      "heapDeltaBytes": -8037496,
      "heapUsedBytes": 62692760,
      "domNodes": 18,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 118.556,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 517.0519999999215,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 5.101,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 335.21099999999996,
      "heapDeltaBytes": -8105900,
      "heapUsedBytes": 62472072,
      "domNodes": 20,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 111.967,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2034.973999999977,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 3.913,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 488.18799999999993,
      "heapDeltaBytes": -13148728,
      "heapUsedBytes": 87577884,
      "domNodes": -264,
      "jsHeapTotalBytes": -1626112,
      "scriptDurationMs": 28.489,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2045.1480000000402,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 4.489,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 496.532,
      "heapDeltaBytes": -13985700,
      "heapUsedBytes": 86340520,
      "domNodes": -263,
      "jsHeapTotalBytes": -839680,
      "scriptDurationMs": 28.062000000000005,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2078.5769999999957,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 8.337000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1242.393,
      "heapDeltaBytes": 22164416,
      "heapUsedBytes": 88177688,
      "domNodes": 6,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 605.7719999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2097.299000000021,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 8.646999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1213.773,
      "heapDeltaBytes": 10158188,
      "heapUsedBytes": 87162440,
      "domNodes": -274,
      "jsHeapTotalBytes": -1437696,
      "scriptDurationMs": 563.182,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3164.771999999971,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 10.803,
      "layouts": 60,
      "layoutDurationMs": 11.977000000000002,
      "taskDurationMs": 1308.9820000000002,
      "heapDeltaBytes": 8489360,
      "heapUsedBytes": 75553832,
      "domNodes": -277,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 567.971,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3110.8829999999443,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 11.305,
      "layouts": 60,
      "layoutDurationMs": 12.255,
      "taskDurationMs": 1320.552,
      "heapDeltaBytes": 7723996,
      "heapUsedBytes": 75375056,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 570.121,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2303.003999999987,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 6.1389999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1364.267,
      "heapDeltaBytes": 13714884,
      "heapUsedBytes": 81026448,
      "domNodes": 8,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 650.657,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2281.8039999999655,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 5.5870000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1396.498,
      "heapDeltaBytes": 13595316,
      "heapUsedBytes": 81044276,
      "domNodes": 6,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 650.171,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2017.5930000000335,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 4.3210000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 489.056,
      "heapDeltaBytes": -14979436,
      "heapUsedBytes": 86859440,
      "domNodes": -266,
      "jsHeapTotalBytes": -1888256,
      "scriptDurationMs": 31.009999999999994,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 1995.5999999999676,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 1.7040000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 440.19300000000004,
      "heapDeltaBytes": 22228676,
      "heapUsedBytes": 88373448,
      "domNodes": -273,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 27.637999999999995,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 525.5470000000173,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 6.997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 301.66700000000003,
      "heapDeltaBytes": 15185248,
      "heapUsedBytes": 88010656,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 96.726,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 523.2579999999416,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 8.032000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 320.307,
      "heapDeltaBytes": 14886116,
      "heapUsedBytes": 87874224,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 104.825,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.961000000033,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.181000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 405.066,
      "heapDeltaBytes": 8216332,
      "heapUsedBytes": 80647396,
      "domNodes": -293,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 6.888000000000002,
      "eventListeners": -226,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1993.1629999999814,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.616,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 403.957,
      "heapDeltaBytes": -8581400,
      "heapUsedBytes": 64080492,
      "domNodes": -294,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 6.898999999999999,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1705.8360000000334,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 25.876,
      "layouts": 18,
      "layoutDurationMs": 3.8289999999999993,
      "taskDurationMs": 645.144,
      "heapDeltaBytes": 10385956,
      "heapUsedBytes": 82406996,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 72.119,
      "eventListeners": -226,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1711.2050000000636,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 26.632,
      "layouts": 18,
      "layoutDurationMs": 4.5360000000000005,
      "taskDurationMs": 662.2040000000001,
      "heapDeltaBytes": -316920,
      "heapUsedBytes": 71523744,
      "domNodes": -296,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 79.569,
      "eventListeners": -226,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 882.4749999999995,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 23.895,
      "layouts": 16,
      "layoutDurationMs": 10.157,
      "taskDurationMs": 687.9089999999999,
      "heapDeltaBytes": -3659780,
      "heapUsedBytes": 94208352,
      "domNodes": 13751,
      "jsHeapTotalBytes": 13107200,
      "scriptDurationMs": 22.052000000000003,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 105,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8137.18300000005,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 31.42,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4378.156,
      "heapDeltaBytes": -15676756,
      "heapUsedBytes": 84897996,
      "domNodes": -266,
      "jsHeapTotalBytes": -352256,
      "scriptDurationMs": 1921.0259999999998,
      "eventListeners": -132,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8197.281999999974,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 30.709000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4498.338000000001,
      "heapDeltaBytes": 14977492,
      "heapUsedBytes": 91146004,
      "domNodes": -266,
      "jsHeapTotalBytes": -1437696,
      "scriptDurationMs": 2003.3590000000002,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12637.176999999952,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11874.819000000001,
      "heapDeltaBytes": -29534780,
      "heapUsedBytes": 175076300,
      "domNodes": -6548,
      "jsHeapTotalBytes": -1245184,
      "scriptDurationMs": 187.863,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12654.346999999916,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11870.856,
      "heapDeltaBytes": -13472936,
      "heapUsedBytes": 174254636,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2625536,
      "scriptDurationMs": 220.704,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15497.368999999992,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 13.535999999999992,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14925.910000000002,
      "heapDeltaBytes": -19319480,
      "heapUsedBytes": 190007028,
      "domNodes": -6548,
      "jsHeapTotalBytes": -3682304,
      "scriptDurationMs": 729.391,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 62,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15570.517999999993,
      "styleRecalcs": 87,
      "styleRecalcDurationMs": 14.315999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15061.544,
      "heapDeltaBytes": -530868,
      "heapUsedBytes": 187244488,
      "domNodes": -6548,
      "jsHeapTotalBytes": -1118208,
      "scriptDurationMs": 794.08,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 56,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4362.786000000028,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 62.13199999999999,
      "layouts": 20,
      "layoutDurationMs": 24.110999999999994,
      "taskDurationMs": 4267.59,
      "heapDeltaBytes": -6806916,
      "heapUsedBytes": 180894096,
      "domNodes": -6548,
      "jsHeapTotalBytes": 18874368,
      "scriptDurationMs": 75.396,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 36,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4548.6439999999675,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 60.56800000000001,
      "layouts": 20,
      "layoutDurationMs": 21.670999999999996,
      "taskDurationMs": 4449.226000000001,
      "heapDeltaBytes": -38914032,
      "heapUsedBytes": 176720144,
      "domNodes": -6548,
      "jsHeapTotalBytes": 12832768,
      "scriptDurationMs": 78.16399999999999,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 51,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "workflow-execution",
      "durationMs": 88.00299999995786,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 10.798,
      "layouts": 2,
      "layoutDurationMs": 0.568,
      "taskDurationMs": 60.26100000000001,
      "heapDeltaBytes": 3108536,
      "heapUsedBytes": 70195340,
      "domNodes": 109,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.188,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 442.9450000000088,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 14.442,
      "layouts": 3,
      "layoutDurationMs": 0.7060000000000001,
      "taskDurationMs": 81.87,
      "heapDeltaBytes": 4785764,
      "heapUsedBytes": 73358244,
      "domNodes": 119,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.487999999999999,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48225 70895 68.0% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.4% 397
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.8% 255
src/scripts/app.ts 71.6% 251
src/scripts/pnginfo.ts 21.4% 221
src/renderer/core/canvas/pathRenderer.ts 24.7% 192

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@codecov

codecov Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #16650      +/-   ##
==========================================
+ Coverage   80.74%   82.36%   +1.61%     
==========================================
  Files        2440     2031     -409     
  Lines      124530   117289    -7241     
  Branches    31139    29407    -1732     
==========================================
- Hits       100553    96604    -3949     
+ Misses      23475    20507    -2968     
+ Partials      502      178     -324     
Flag Coverage Δ
e2e 68.02% <ø> (+0.01%) ⬆️
unit 76.68% <ø> (ø)
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 415 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CodeJuggernaut CodeJuggernaut left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed allowlist entries have no surviving references; LGTM.

@christian-byrne
christian-byrne added this pull request to the merge queue Sep 2, 2026
Merged via the queue into main with commit 4b6095a Sep 2, 2026
91 checks passed
@christian-byrne
christian-byrne deleted the op8b/fix-valuedrift-stale-keys branch September 2, 2026 15:46
pull Bot pushed a commit to Mu-L/ComfyUI_frontend that referenced this pull request Sep 2, 2026
…y-Org#16676)

Human Ben: This fixes the issues causing the E2E Custom Nodes Tests to
fail.

## Summary

S3 reported value drift on all 82 ComfyUI-VideoHelperSuite nodes even
though no value changed. `widgets_values` is a union of a positional
array and a name-keyed record (`zWidgetValues =
z.union([z.array(z.any()), z.record(z.any())])`), and VHS rewrites its
own nodes to the record form in `onSerialize`:

```js
chainCallback(this, "onSerialize", function(info) {
    info.widgets_values = {};
    for (let w of this.widgets) info.widgets_values[w.name] = w.value;
});
```

The tier compared the raw value, so a legal reshape read as drift on
every widget:

```
VHS_DuplicateImages: widgets_values [1] -> {"multiply_by":1} on pristine reload
VHS_MergeImages: ["match A","nearest-exact","disabled"]
              -> {"merge_strategy":"match A","scale_method":"nearest-exact","crop":"disabled"}
```

This is correct pack behaviour and schema-legal, so the test was wrong —
not the product.

## Changes

- When only the shape differs, key both sides by widget name before
comparing. Identical values in different containers no longer read as
drift; a real value change still fails.
- Normalization engages only when `Array.isArray(before) !==
Array.isArray(after)`. Same-shape comparisons keep their existing
strict/non-strict paths untouched, so detection is unchanged everywhere
it already works.
- Names come from a new serializer-aligned list. Positional
`widgets_values` omits `serialize === false` widgets, so the full widget
list would shift every index after the first hidden one and compare the
wrong pairs.

## Why not ledger it

Adding 82 entries would have recreated the stale-entry problem that
produced the failures this is chasing: entries stop reproducing after an
upstream change, then fail closed as stale. Normalizing the comparison
keeps the tier able to detect genuine drift with no calibration surface
to rot.

## Testing

- Browser typecheck, ESLint, oxfmt clean.
- Full custom-node suite dispatched on this branch; `core:1/2` and
`cloud 2/5` are the VHS-carrying slices that fail on `main`.

No unit test: this logic lives inside a `page.evaluate` closure that
Playwright stringifies, so it cannot import a shared helper, and
duplicating it into a testable module would leave two copies to drift.
The file's existing helpers (`preserves`, `byId`) are inline for the
same reason. The E2E run against the real pack is the proof.

## Context

`main` is currently red on exactly these two slices. This is unrelated
to the earlier stale-allowlist failures fixed in Comfy-Org#16650 — that fix is
what exposed this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants