Skip to content

[backport cloud/1.52] feat(telemetry): instrument unified auth lifecycle and image load failures - #16614

Merged
comfy-pr-bot merged 1 commit into
cloud/1.52from
backport-16072-to-cloud-1.52
Sep 2, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.52from
backport-16072-to-cloud-1.52

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #16072 to cloud/1.52

Automatically created by backport workflow.

…lures (#16072)

## Summary

Follow-up to #16063: the unified-auth incident (FE-1595) was invisible
in telemetry — every path that killed image loads only `console.warn`ed.
This instruments the lifecycle so the fix's effect is measurable and a
recurrence alerts instead of waiting on customer reports.

## Why this is needed

Diagnosing FE-1595 required the artist's Network tab because none of the
failing seams emit telemetry:

- The proactive `refreshUnified()` failure — the moment the
session-cookie rotation chain dies — was `console.warn` only.
- Session-cookie creation failure (`useSessionCookie.createSession`) was
swallowed with a warn; that cookie is the only credential `<img>`/media
loads carry.
- The user-facing symptom itself (`ImagePreview` load error) set local
state only, so affected-user counts were unknowable.
- `trackUnifiedAuthRetry` covered only axios/fetch transports and only
reached Datadog RUM, so PostHog could not query or alert on any of it.

## Changes

- **What**: `trackUnifiedAuthRefresh` lifecycle event (`succeeded` /
`retry_scheduled` / `retries_exhausted` / `permanent_failure`, with
`retry_count`) emitted from `refreshUnified()`; measures the
retry/backoff added in #16063.
- **What**: `reportError(..., { errorType:
'session_cookie_creation_failure' })` on swallowed `createSession`
failures (dual-sink per repo convention).
- **What**: `trackImageLoadFailed({ source: 'node_image_preview' })`
from `ImagePreview`'s error handler — no filenames/PII, source tag only.
- **What**: `'ws'` transport + `'token_unavailable'` reason on
`UnifiedAuthRetryMetadata`, emitted when WebSocket connect cannot obtain
a token under unified auth.
- **What**: PostHog provider now implements
`trackUnifiedAuthRetry`/`trackUnifiedAuthRefresh` (previously
Datadog-only), enabling PostHog queries and alerts.

## Review Focus

- Event volume: `auth.unified.refresh.succeeded` fires ~once per 85min
per active session; `app:image_load_failed` fires per failed `<img>`
render in node previews. Both go to Datadog actions; only the
unified-auth events go to PostHog.
- `retry_count` is attached to non-succeeded outcomes only.

## Tests

- Refresh lifecycle outcomes asserted across the existing
retry/backoff/permanent-failure store tests.
- `session_cookie_creation_failure` report on swallowed createSession
failure.
- Image-error telemetry asserted in the existing ImagePreview failure
test.
- Both providers' new methods covered. 216 tests green across the five
touched suites; typecheck/lint/knip clean.

No UI change (telemetry only), so no screenshots.

Related: FE-1595 (linear.app/comfyorg/issue/FE-1595)
@comfy-pr-bot
comfy-pr-bot requested a review from a team as a code owner September 2, 2026 06:41
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/02/2026, 06:43:13 AM UTC

Links

🎭 Playwright: ✅ 1985 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1964 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.7 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.0 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 126ms TBT · 100.7 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 166.3 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 134ms TBT · 175.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 7
canvas-idle: task duration 527ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 66.1 MB
canvas-idle: DOM nodes -284
canvas-idle: event listeners -167
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 41ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 948ms
canvas-mouse-sweep: script duration 107ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 67.7 MB
canvas-mouse-sweep: DOM nodes -282
canvas-mouse-sweep: event listeners -152
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 355ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 63.1 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 364ms
dom-widget-clipping: script duration 53ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 70.6 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 8ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 627ms
large-graph-idle: script duration 15ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 69.3 MB
large-graph-idle: DOM nodes -279
large-graph-idle: event listeners -149
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 17ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1225ms
large-graph-pan: script duration 324ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 63.9 MB
large-graph-pan: DOM nodes -283
large-graph-pan: event listeners -148
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 17ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 66
large-graph-zoom: task duration 1417ms
large-graph-zoom: script duration 391ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 66.7 MB
large-graph-zoom: DOM nodes -137
large-graph-zoom: event listeners -73
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 10ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 46
legacy-node-drag: task duration 1456ms
legacy-node-drag: script duration 465ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 66.7 MB
legacy-node-drag: DOM nodes 11
legacy-node-drag: event listeners 185
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 8ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 639ms
minimap-idle: script duration 19ms
minimap-idle: TBT 0ms
minimap-idle: heap used 70.2 MB
minimap-idle: DOM nodes -276
minimap-idle: event listeners -149
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 401ms
subgraph-dom-widget-clipping: script duration 127ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 71.2 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 498ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 56.0 MB
subgraph-idle: DOM nodes -281
subgraph-idle: event listeners -166
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 37ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 75
subgraph-mouse-sweep: task duration 819ms
subgraph-mouse-sweep: script duration 87ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 77.0 MB
subgraph-mouse-sweep: DOM nodes -282
subgraph-mouse-sweep: event listeners -151
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 30ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 934ms
subgraph-transition-enter: script duration 17ms
subgraph-transition-enter: TBT 126ms
subgraph-transition-enter: heap used 100.7 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2373
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 42ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4163ms
viewport-pan-sweep: script duration 990ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 72.4 MB
viewport-pan-sweep: DOM nodes -279
viewport-pan-sweep: event listeners -132
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17508ms
vue-large-graph-idle: script duration 123ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 166.3 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16389
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 21ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 174
vue-large-graph-pan: task duration 21762ms
vue-large-graph-pan: script duration 451ms
vue-large-graph-pan: TBT 134ms
vue-large-graph-pan: heap used 175.9 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16387
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 17ms
workflow-execution: layout count 3
workflow-execution: style recalc count 9
workflow-execution: task duration 83ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 62.6 MB
workflow-execution: DOM nodes 122
workflow-execution: event listeners 37
Raw data
{
  "timestamp": "2026-09-02T06:54:37.004Z",
  "gitSha": "d1c5d9439563fbb76d4146724d1f177b02e44990",
  "branch": "backport-16072-to-cloud-1.52",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2041.2469999999985,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.345000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 540.5600000000001,
      "heapDeltaBytes": -3674544,
      "heapUsedBytes": 58106112,
      "domNodes": -285,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 8.993,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2068.1580000000395,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.882,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 513.5699999999999,
      "heapDeltaBytes": 18900264,
      "heapUsedBytes": 80467780,
      "domNodes": -283,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.035,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2005.1640000000361,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 47.307,
      "layouts": 12,
      "layoutDurationMs": 3.9709999999999996,
      "taskDurationMs": 1034.5330000000001,
      "heapDeltaBytes": -3435880,
      "heapUsedBytes": 59454240,
      "domNodes": -282,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 110.89399999999999,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1824.4720000000143,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 34.478,
      "layouts": 12,
      "layoutDurationMs": 3.3369999999999997,
      "taskDurationMs": 860.6769999999999,
      "heapDeltaBytes": 19530844,
      "heapUsedBytes": 82545552,
      "domNodes": -281,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 103.574,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1738.3990000000153,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.479,
      "layouts": 6,
      "layoutDurationMs": 0.6630000000000001,
      "taskDurationMs": 358.40399999999994,
      "heapDeltaBytes": 3189544,
      "heapUsedBytes": 66324376,
      "domNodes": 76,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 9.838000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1715.4540000000225,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 14.783000000000001,
      "layouts": 6,
      "layoutDurationMs": 0.554,
      "taskDurationMs": 352.322,
      "heapDeltaBytes": 3375072,
      "heapUsedBytes": 65902892,
      "domNodes": 75,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 9.55,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 570.2600000000189,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.534,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 360.608,
      "heapDeltaBytes": 10816620,
      "heapUsedBytes": 73812084,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 53.431999999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 573.4209999999393,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.292000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 368.14099999999996,
      "heapDeltaBytes": 11143064,
      "heapUsedBytes": 74268448,
      "domNodes": 18,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 53.011,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2053.9509999999837,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.938999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 620.617,
      "heapDeltaBytes": -4161080,
      "heapUsedBytes": 73032572,
      "domNodes": -278,
      "jsHeapTotalBytes": -1318912,
      "scriptDurationMs": 15.192,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2055.246000000011,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.07,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 632.967,
      "heapDeltaBytes": -4742056,
      "heapUsedBytes": 72372036,
      "domNodes": -279,
      "jsHeapTotalBytes": -1843200,
      "scriptDurationMs": 14.334000000000003,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2199.175999999966,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 15.738999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1232.3319999999999,
      "heapDeltaBytes": -14526308,
      "heapUsedBytes": 63846736,
      "domNodes": -282,
      "jsHeapTotalBytes": 2088960,
      "scriptDurationMs": 330.704,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2184.329000000048,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 17.443,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1218.358,
      "heapDeltaBytes": -8219480,
      "heapUsedBytes": 70135344,
      "domNodes": -284,
      "jsHeapTotalBytes": 217088,
      "scriptDurationMs": 317.63,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3183.41700000002,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 16.906000000000006,
      "layouts": 60,
      "layoutDurationMs": 8.396,
      "taskDurationMs": 1358.157,
      "heapDeltaBytes": -9297828,
      "heapUsedBytes": 70391752,
      "domNodes": 14,
      "jsHeapTotalBytes": 5541888,
      "scriptDurationMs": 389.31499999999994,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3231.086000000005,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 16.633000000000003,
      "layouts": 60,
      "layoutDurationMs": 8.334,
      "taskDurationMs": 1475.2589999999998,
      "heapDeltaBytes": -9900628,
      "heapUsedBytes": 69534536,
      "domNodes": -288,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 393.188,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2320.097999999973,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.530000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1474.795,
      "heapDeltaBytes": -17183688,
      "heapUsedBytes": 69991824,
      "domNodes": 10,
      "jsHeapTotalBytes": 8949760,
      "scriptDurationMs": 470.748,
      "eventListeners": 184,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2251.2859999999364,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.857999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1436.228,
      "heapDeltaBytes": -15365200,
      "heapUsedBytes": 69986488,
      "domNodes": 12,
      "jsHeapTotalBytes": 8425472,
      "scriptDurationMs": 459.205,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2095.452000000023,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.275999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 662.156,
      "heapDeltaBytes": -11958724,
      "heapUsedBytes": 73527852,
      "domNodes": -273,
      "jsHeapTotalBytes": 3661824,
      "scriptDurationMs": 22.835,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2045.686000000046,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.8530000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 616.482,
      "heapDeltaBytes": -11681628,
      "heapUsedBytes": 73601032,
      "domNodes": -278,
      "jsHeapTotalBytes": 3399680,
      "scriptDurationMs": 15.805000000000003,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 608.998999999983,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.584,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 399.58700000000005,
      "heapDeltaBytes": 11547072,
      "heapUsedBytes": 74578004,
      "domNodes": 16,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 128.18,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 624.1459999999961,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.974999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 402.34999999999997,
      "heapDeltaBytes": 11852916,
      "heapUsedBytes": 74767868,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 125.65300000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2038.6290000000145,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.448999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 496.63199999999995,
      "heapDeltaBytes": -7210100,
      "heapUsedBytes": 55783976,
      "domNodes": -280,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 6.888,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2023.8150000000132,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.165000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 498.51800000000003,
      "heapDeltaBytes": -1443292,
      "heapUsedBytes": 61753408,
      "domNodes": -281,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 7.507999999999999,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1740.2450000000158,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 36.989000000000004,
      "layouts": 16,
      "layoutDurationMs": 4.824,
      "taskDurationMs": 826.8040000000001,
      "heapDeltaBytes": 18706952,
      "heapUsedBytes": 81685832,
      "domNodes": -281,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 87.876,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1751.4309999999114,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 36.124,
      "layouts": 16,
      "layoutDurationMs": 4.8790000000000004,
      "taskDurationMs": 810.228,
      "heapDeltaBytes": 16845656,
      "heapUsedBytes": 79784872,
      "domNodes": -283,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 85.493,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1384.7170000000233,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 30.089000000000006,
      "layouts": 15,
      "layoutDurationMs": 13.23,
      "taskDurationMs": 934.2800000000002,
      "heapDeltaBytes": 22053804,
      "heapUsedBytes": 105592780,
      "domNodes": 13673,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 16.730000000000008,
      "eventListeners": 2373,
      "totalBlockingTimeMs": 126,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8346.675000000005,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 42.001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4169.637,
      "heapDeltaBytes": -1349240,
      "heapUsedBytes": 75847120,
      "domNodes": -278,
      "jsHeapTotalBytes": -831488,
      "scriptDurationMs": 998.131,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8261.518000000024,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 42.440000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4156.29,
      "heapDeltaBytes": -1582700,
      "heapUsedBytes": 75918476,
      "domNodes": -279,
      "jsHeapTotalBytes": -831488,
      "scriptDurationMs": 982.1809999999999,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18531.478999999992,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17628.118000000002,
      "heapDeltaBytes": -64597692,
      "heapUsedBytes": 167663200,
      "domNodes": -8312,
      "jsHeapTotalBytes": -15405056,
      "scriptDurationMs": 129.997,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18466.842999999928,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17388.652000000002,
      "heapDeltaBytes": -32002516,
      "heapUsedBytes": 180993104,
      "domNodes": -8312,
      "jsHeapTotalBytes": -10051584,
      "scriptDurationMs": 115.66600000000001,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22731.93600000002,
      "styleRecalcs": 175,
      "styleRecalcDurationMs": 22.450000000000024,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22102.826,
      "heapDeltaBytes": -53191792,
      "heapUsedBytes": 173785064,
      "domNodes": -8312,
      "jsHeapTotalBytes": -19845120,
      "scriptDurationMs": 458.87699999999995,
      "eventListeners": -16388,
      "totalBlockingTimeMs": 158,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22123.60799999999,
      "styleRecalcs": 173,
      "styleRecalcDurationMs": 19.62900000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21421.241,
      "heapDeltaBytes": -31567524,
      "heapUsedBytes": 195037508,
      "domNodes": -8312,
      "jsHeapTotalBytes": -20176896,
      "scriptDurationMs": 442.24099999999993,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 109,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 122.9879999999639,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 19.526,
      "layouts": 3,
      "layoutDurationMs": 1.288,
      "taskDurationMs": 89.227,
      "heapDeltaBytes": 3231316,
      "heapUsedBytes": 65563884,
      "domNodes": 116,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 6.529,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 106.37599999995473,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 15.034000000000002,
      "layouts": 2,
      "layoutDurationMs": 0.9659999999999999,
      "taskDurationMs": 77.11199999999998,
      "heapDeltaBytes": 3079316,
      "heapUsedBytes": 65789056,
      "domNodes": 128,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.7429999999999986,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 46450 68776 67.5% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.4% 1212
src/LGraphNode.ts 64.3% 464
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/LGraph.ts 73.0% 312
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 38.0% 258
src/scripts/app.ts 71.2% 241
src/scripts/pnginfo.ts 21.5% 219
src/stores/assetsStore.ts 45.0% 203

@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@codecov

codecov Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 58.13953% with 18 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/scripts/api.ts 0.00% 7 Missing ⚠️
src/platform/telemetry/TelemetryRegistry.ts 0.00% 4 Missing ⚠️
...emetry/providers/cloud/PostHogTelemetryProvider.ts 66.66% 2 Missing and 2 partials ⚠️
...try/providers/cloud/DatadogRumTelemetryProvider.ts 71.42% 1 Missing and 1 partial ⚠️
...rc/platform/workspace/stores/workspaceAuthStore.ts 90.90% 1 Missing ⚠️
@@              Coverage Diff               @@
##           cloud/1.52   #16614      +/-   ##
==============================================
+ Coverage       79.66%   82.04%   +2.37%     
==============================================
  Files            2243     1913     -330     
  Lines          115250   110294    -4956     
  Branches        33462    31800    -1662     
==============================================
- Hits            91816    90488    -1328     
+ Misses          22942    19466    -3476     
+ Partials          492      340     -152     
Flag Coverage Δ
e2e 66.03% <10.00%> (-0.08%) ⬇️
unit 74.09% <55.81%> (-0.01%) ⬇️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/auth/session/useSessionCookie.ts 94.25% <100.00%> (+0.06%) ⬆️
src/platform/telemetry/types.ts 97.05% <ø> (ø)
...er/extensions/vueNodes/components/ImagePreview.vue 91.28% <100.00%> (+0.04%) ⬆️
...rc/platform/workspace/stores/workspaceAuthStore.ts 90.57% <90.90%> (-0.02%) ⬇️
...try/providers/cloud/DatadogRumTelemetryProvider.ts 89.47% <71.42%> (-4.08%) ⬇️
src/platform/telemetry/TelemetryRegistry.ts 23.74% <0.00%> (-0.71%) ⬇️
...emetry/providers/cloud/PostHogTelemetryProvider.ts 71.88% <66.66%> (-0.24%) ⬇️
src/scripts/api.ts 69.27% <0.00%> (-0.75%) ⬇️

... and 349 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot added this pull request to the merge queue Sep 2, 2026
@huang47 huang47 added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Merged via the queue into cloud/1.52 with commit 9bbc9ab Sep 2, 2026
101 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-16072-to-cloud-1.52 branch September 2, 2026 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants