Repository navigation
[backport core/1.52] feat(telemetry): instrument unified auth lifecycle and image load failures - #16613
Conversation
…lures (#16072) ## Summary Follow-up to #16063: the unified-auth incident (FE-1595) was invisible in telemetry — every path that killed image loads only `console.warn`ed. This instruments the lifecycle so the fix's effect is measurable and a recurrence alerts instead of waiting on customer reports. ## Why this is needed Diagnosing FE-1595 required the artist's Network tab because none of the failing seams emit telemetry: - The proactive `refreshUnified()` failure — the moment the session-cookie rotation chain dies — was `console.warn` only. - Session-cookie creation failure (`useSessionCookie.createSession`) was swallowed with a warn; that cookie is the only credential `<img>`/media loads carry. - The user-facing symptom itself (`ImagePreview` load error) set local state only, so affected-user counts were unknowable. - `trackUnifiedAuthRetry` covered only axios/fetch transports and only reached Datadog RUM, so PostHog could not query or alert on any of it. ## Changes - **What**: `trackUnifiedAuthRefresh` lifecycle event (`succeeded` / `retry_scheduled` / `retries_exhausted` / `permanent_failure`, with `retry_count`) emitted from `refreshUnified()`; measures the retry/backoff added in #16063. - **What**: `reportError(..., { errorType: 'session_cookie_creation_failure' })` on swallowed `createSession` failures (dual-sink per repo convention). - **What**: `trackImageLoadFailed({ source: 'node_image_preview' })` from `ImagePreview`'s error handler — no filenames/PII, source tag only. - **What**: `'ws'` transport + `'token_unavailable'` reason on `UnifiedAuthRetryMetadata`, emitted when WebSocket connect cannot obtain a token under unified auth. - **What**: PostHog provider now implements `trackUnifiedAuthRetry`/`trackUnifiedAuthRefresh` (previously Datadog-only), enabling PostHog queries and alerts. ## Review Focus - Event volume: `auth.unified.refresh.succeeded` fires ~once per 85min per active session; `app:image_load_failed` fires per failed `<img>` render in node previews. Both go to Datadog actions; only the unified-auth events go to PostHog. - `retry_count` is attached to non-succeeded outcomes only. ## Tests - Refresh lifecycle outcomes asserted across the existing retry/backoff/permanent-failure store tests. - `session_cookie_creation_failure` report on swallowed createSession failure. - Image-error telemetry asserted in the existing ImagePreview failure test. - Both providers' new methods covered. 216 tests green across the five touched suites; typecheck/lint/knip clean. No UI change (telemetry only), so no screenshots. Related: FE-1595 (linear.app/comfyorg/issue/FE-1595)
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1984 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-02T06:54:50.321Z",
"gitSha": "04aa0323f9c3066832dda13af5b9cf5533e0b07a",
"branch": "backport-16072-to-core-1.52",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2080.393000000072,
"styleRecalcs": 8,
"styleRecalcDurationMs": 12.708,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 673.8159999999999,
"heapDeltaBytes": 2736824,
"heapUsedBytes": 65285672,
"domNodes": -282,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 11.026000000000002,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2070.126000000073,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.346999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.14599999999996,
"heapDeltaBytes": 16773316,
"heapUsedBytes": 78999728,
"domNodes": -282,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.370999999999998,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1906.0629999999037,
"styleRecalcs": 76,
"styleRecalcDurationMs": 41.42,
"layouts": 12,
"layoutDurationMs": 3.7349999999999994,
"taskDurationMs": 947.931,
"heapDeltaBytes": 11825336,
"heapUsedBytes": 74748304,
"domNodes": -283,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 114.42299999999999,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1823.6970000000383,
"styleRecalcs": 73,
"styleRecalcDurationMs": 36.847,
"layouts": 12,
"layoutDurationMs": 3.529,
"taskDurationMs": 891.5769999999999,
"heapDeltaBytes": -5913512,
"heapUsedBytes": 57029804,
"domNodes": -283,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 110.812,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1685.0130000000263,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.702999999999996,
"layouts": 6,
"layoutDurationMs": 0.672,
"taskDurationMs": 408.265,
"heapDeltaBytes": 3297856,
"heapUsedBytes": 66356080,
"domNodes": 76,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 11.6,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.5119999999479,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.222,
"layouts": 6,
"layoutDurationMs": 0.5339999999999999,
"taskDurationMs": 410.24799999999993,
"heapDeltaBytes": 2932980,
"heapUsedBytes": 66120888,
"domNodes": 77,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 11.688,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 587.2659999999996,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.833999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.84399999999994,
"heapDeltaBytes": 10485676,
"heapUsedBytes": 72049012,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 57.510000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 584.3849999998838,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.528,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.04400000000004,
"heapDeltaBytes": 10409232,
"heapUsedBytes": 72195564,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 55.245000000000005,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2068.255000000022,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.652999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 687.0079999999998,
"heapDeltaBytes": -1585632,
"heapUsedBytes": 75674648,
"domNodes": -276,
"jsHeapTotalBytes": -528384,
"scriptDurationMs": 17.079,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2066.6630000000623,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.276,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 641.891,
"heapDeltaBytes": -4148252,
"heapUsedBytes": 73218280,
"domNodes": -272,
"jsHeapTotalBytes": -1052672,
"scriptDurationMs": 17.292,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2341.963000000078,
"styleRecalcs": 68,
"styleRecalcDurationMs": 16.900000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1340.73,
"heapDeltaBytes": -13751256,
"heapUsedBytes": 64149432,
"domNodes": -287,
"jsHeapTotalBytes": 4190208,
"scriptDurationMs": 376.17400000000004,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2183.7319999999636,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.127,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1213.931,
"heapDeltaBytes": -2587132,
"heapUsedBytes": 75646620,
"domNodes": -240,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 355.844,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3248.446999999942,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.156000000000002,
"layouts": 60,
"layoutDurationMs": 8.119,
"taskDurationMs": 1431.158,
"heapDeltaBytes": -8197688,
"heapUsedBytes": 70976760,
"domNodes": -289,
"jsHeapTotalBytes": 4452352,
"scriptDurationMs": 391.837,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3232.771999999841,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.909,
"layouts": 60,
"layoutDurationMs": 7.558000000000001,
"taskDurationMs": 1431.587,
"heapDeltaBytes": -9060696,
"heapUsedBytes": 69306428,
"domNodes": -290,
"jsHeapTotalBytes": 5763072,
"scriptDurationMs": 385.57800000000003,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2320.895999999948,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.399000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1489.285,
"heapDeltaBytes": -16877532,
"heapUsedBytes": 70522612,
"domNodes": 12,
"jsHeapTotalBytes": 9474048,
"scriptDurationMs": 484.018,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2476.9189999999526,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.204,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1472.952,
"heapDeltaBytes": 11989864,
"heapUsedBytes": 92092344,
"domNodes": 10,
"jsHeapTotalBytes": 7270400,
"scriptDurationMs": 467.608,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2040.9639999999172,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.7650000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 724.7829999999999,
"heapDeltaBytes": -13086280,
"heapUsedBytes": 65038884,
"domNodes": -283,
"jsHeapTotalBytes": 3403776,
"scriptDurationMs": 19.137,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2038.2690000001276,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.247,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 667.5060000000001,
"heapDeltaBytes": -12815464,
"heapUsedBytes": 65109224,
"domNodes": -284,
"jsHeapTotalBytes": 3403776,
"scriptDurationMs": 17.974999999999998,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 578.9310000000114,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.518,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.19899999999996,
"heapDeltaBytes": 11531772,
"heapUsedBytes": 74675900,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 116.55199999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 642.9339999999684,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.135,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.43100000000004,
"heapDeltaBytes": 11857644,
"heapUsedBytes": 74535436,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 124.46000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2023.4709999999723,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.583000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.341,
"heapDeltaBytes": 18458472,
"heapUsedBytes": 81523372,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.553000000000002,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.2079999998641,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.7719999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.437,
"heapDeltaBytes": 12291748,
"heapUsedBytes": 75291548,
"domNodes": -283,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 5.752000000000002,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1728.5320000000866,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.279,
"layouts": 16,
"layoutDurationMs": 4.779999999999999,
"taskDurationMs": 827.65,
"heapDeltaBytes": 5816652,
"heapUsedBytes": 68365692,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 89.07699999999998,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.3969999999772,
"styleRecalcs": 74,
"styleRecalcDurationMs": 34.444,
"layouts": 16,
"layoutDurationMs": 4.494,
"taskDurationMs": 791.141,
"heapDeltaBytes": 12010956,
"heapUsedBytes": 75144836,
"domNodes": -284,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 87.299,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.5040000001827,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.002000000000002,
"layouts": 14,
"layoutDurationMs": 14.559,
"taskDurationMs": 922.7400000000001,
"heapDeltaBytes": 20396712,
"heapUsedBytes": 103581652,
"domNodes": 13673,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 15.542000000000007,
"eventListeners": 2373,
"totalBlockingTimeMs": 143,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8330.538999999932,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.228,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4272.311000000001,
"heapDeltaBytes": 6706660,
"heapUsedBytes": 83773552,
"domNodes": -245,
"jsHeapTotalBytes": -40960,
"scriptDurationMs": 1092.736,
"eventListeners": -135,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8621.54200000009,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.528,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4500.883,
"heapDeltaBytes": -6541840,
"heapUsedBytes": 70616452,
"domNodes": -282,
"jsHeapTotalBytes": 3891200,
"scriptDurationMs": 1085.028,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16898.37900000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16384.498,
"heapDeltaBytes": -49341748,
"heapUsedBytes": 181277160,
"domNodes": -8312,
"jsHeapTotalBytes": -13705216,
"scriptDurationMs": 116.69699999999999,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16829.455000000053,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16052.75,
"heapDeltaBytes": -40337916,
"heapUsedBytes": 176122160,
"domNodes": -8312,
"jsHeapTotalBytes": -18378752,
"scriptDurationMs": 109.049,
"eventListeners": -16393,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20381.800999999996,
"styleRecalcs": 168,
"styleRecalcDurationMs": 16.965000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19853.594999999998,
"heapDeltaBytes": -23716884,
"heapUsedBytes": 195402640,
"domNodes": -8312,
"jsHeapTotalBytes": -22753280,
"scriptDurationMs": 405.74699999999996,
"eventListeners": -16387,
"totalBlockingTimeMs": 40,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20936.82200000012,
"styleRecalcs": 175,
"styleRecalcDurationMs": 17.824000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20444.415999999997,
"heapDeltaBytes": -28099540,
"heapUsedBytes": 192940488,
"domNodes": -8312,
"jsHeapTotalBytes": -25538560,
"scriptDurationMs": 402.03600000000006,
"eventListeners": -16387,
"totalBlockingTimeMs": 39,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 471.4200000000801,
"styleRecalcs": 20,
"styleRecalcDurationMs": 26.805000000000003,
"layouts": 10,
"layoutDurationMs": 2.4879999999999995,
"taskDurationMs": 128.25900000000001,
"heapDeltaBytes": 5377232,
"heapUsedBytes": 67604632,
"domNodes": 150,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.315,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 483.7360000001354,
"styleRecalcs": 19,
"styleRecalcDurationMs": 19.680000000000003,
"layouts": 11,
"layoutDurationMs": 2.543,
"taskDurationMs": 115.52200000000002,
"heapDeltaBytes": 5110848,
"heapUsedBytes": 67821852,
"domNodes": 145,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.481000000000002,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
} |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.52 #16613 +/- ##
=============================================
- Coverage 82.02% 82.01% -0.01%
=============================================
Files 1907 1907
Lines 109038 109084 +46
Branches 30233 30248 +15
=============================================
+ Hits 89438 89465 +27
- Misses 19253 19282 +29
+ Partials 347 337 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 17 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #16072 to
core/1.52Automatically created by backport workflow.