Skip to content

feat(billing): recover from a failed 3DS challenge with retry or a different card - #16561

Closed
comfydesigner wants to merge 6 commits into
comfydesigner/confirm-after-failed-challengefrom
comfydesigner/failed-challenge-recovery
Closed

comfydesigner wants to merge 6 commits into
comfydesigner/confirm-after-failed-challengefrom
comfydesigner/failed-challenge-recovery

Conversation

@comfydesigner

Copy link
Copy Markdown
Contributor

Closes FE-1988. Stacked on #16531 (review that first — it re-enables confirm after a failed challenge; this PR builds the recovery flow around it).

Design: failed-challenge recovery, combined flow.

What changes

After a failed 3DS challenge, both preview components now show one mapped notice with two live routes instead of a raw SDK string over a dead retry button:

  • Copy: "Verification didn't finish. Your bank didn't confirm this payment. Try again, or use a different card." The authenticationError prop is removed — raw Stripe SDK text (handleNextAction: The PaymentIntent supplied is not in the requires_action state) no longer reaches the notice; only mapped copy renders. Members without billing access still get the manager-required line.
  • Try again = the confirm button, which fix(billing): let the customer pay again after a failed bank verification #16531 keeps live. A failed challenge leaves the intent at requires_payment_method, so confirming starts a fresh attempt.
  • use a different card = inline link in the notice (saved-method confirm only) emitting the existing changePaymentMethod event, which escalates to the wide payment screen with the quote intact. The transition preview has no card swap, so it gets the retry-only copy.
  • Placement: the notice moves from the top of the column to directly above the pay action; the top slot stays reserved for the reconciliation hold.
  • Retry button: no longer renders for failed_retryable (handleNextAction cannot resume a finished challenge — same removal as fix(billing): remove the failed-verification retry affordance #16123, expressed as narrowing the button to requires_action). If fix(billing): remove the failed-verification retry affordance #16123 lands first, this rebases onto its alert simplification.

Known seams

┆ Linear: FE-1988

@coderabbitai

coderabbitai Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: aab86b34-4ca9-4640-a400-209d0f590fa9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 2, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1891 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1870 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/04/2026, 12:49:47 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.5 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.8 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 135ms TBT · 93.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.5 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 166.6 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 24ms TBT · 155.0 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 378ms TBT · 172.3 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 487ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 55.5 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -155
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 35ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 845ms
canvas-mouse-sweep: script duration 155ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 65.7 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -171
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 342ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 70.9 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 440ms
dom-widget-clipping: script duration 158ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 83.8 MB
dom-widget-clipping: DOM nodes 20
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 575ms
large-graph-idle: script duration 29ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.8 MB
large-graph-idle: DOM nodes -268
large-graph-idle: event listeners -154
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1593ms
large-graph-pan: script duration 792ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 82.8 MB
large-graph-pan: DOM nodes -270
large-graph-pan: event listeners -168
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 11ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1623ms
large-graph-zoom: script duration 747ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.4 MB
large-graph-zoom: DOM nodes 2
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1868ms
legacy-node-drag: script duration 947ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 83.0 MB
legacy-node-drag: DOM nodes 2
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 558ms
minimap-idle: script duration 27ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.4 MB
minimap-idle: DOM nodes -271
minimap-idle: event listeners -155
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 397ms
subgraph-dom-widget-clipping: script duration 138ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.0 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 466ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 60.4 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -201
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 35ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 788ms
subgraph-mouse-sweep: script duration 104ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 58.0 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -201
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 888ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 135ms
subgraph-transition-enter: heap used 93.5 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 34ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5555ms
viewport-pan-sweep: script duration 2592ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 84.5 MB
viewport-pan-sweep: DOM nodes -269
viewport-pan-sweep: event listeners -139
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 15685ms
vue-large-graph-idle: script duration 288ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 166.6 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7471
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 16ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 165
vue-large-graph-pan: task duration 19936ms
vue-large-graph-pan: script duration 905ms
vue-large-graph-pan: TBT 24ms
vue-large-graph-pan: heap used 155.0 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7469
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 21ms
vue-node-resize-workload: style recalc duration 80ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5843ms
vue-node-resize-workload: script duration 103ms
vue-node-resize-workload: TBT 378ms
vue-node-resize-workload: heap used 172.3 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7471
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 18ms
workflow-execution: layout count 3
workflow-execution: style recalc count 12
workflow-execution: task duration 99ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.4 MB
workflow-execution: DOM nodes 173
workflow-execution: event listeners 89
Raw data
{
  "timestamp": "2026-09-04T01:06:06.701Z",
  "gitSha": "5ed431730cf0e88a4ff2bb891189e8eb5c87552d",
  "branch": "comfydesigner/failed-challenge-recovery",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2020.8210000000122,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.527000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 485.333,
      "heapDeltaBytes": -11400736,
      "heapUsedBytes": 57557284,
      "domNodes": -279,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.372,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2017.2320000000354,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.327000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 488.88700000000006,
      "heapDeltaBytes": -10074232,
      "heapUsedBytes": 58849132,
      "domNodes": -280,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 7.316,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1825.716,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 35.269999999999996,
      "layouts": 14,
      "layoutDurationMs": 4.012999999999999,
      "taskDurationMs": 844.371,
      "heapDeltaBytes": -4788824,
      "heapUsedBytes": 64745160,
      "domNodes": -281,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 154.07,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1801.2560000000803,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 33.73800000000001,
      "layouts": 14,
      "layoutDurationMs": 4.026,
      "taskDurationMs": 845.486,
      "heapDeltaBytes": 4089540,
      "heapUsedBytes": 73109792,
      "domNodes": -281,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 155.374,
      "eventListeners": -187,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1722.9319999999575,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.715,
      "layouts": 6,
      "layoutDurationMs": 0.9079999999999999,
      "taskDurationMs": 344.02600000000007,
      "heapDeltaBytes": 4318436,
      "heapUsedBytes": 74383416,
      "domNodes": 78,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 10.004,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1684.3340000000353,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 16.486,
      "layouts": 6,
      "layoutDurationMs": 0.985,
      "taskDurationMs": 340.148,
      "heapDeltaBytes": 4292992,
      "heapUsedBytes": 74253472,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 9.454,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 659.1450000000236,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.218000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 449.49799999999993,
      "heapDeltaBytes": 18722512,
      "heapUsedBytes": 87983128,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 162.05800000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 617.8239999999278,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 8.837000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 430.989,
      "heapDeltaBytes": 18113360,
      "heapUsedBytes": 87704792,
      "domNodes": 22,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 153.11,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2024.565999999993,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.110999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 566.0519999999999,
      "heapDeltaBytes": -13084116,
      "heapUsedBytes": 86879868,
      "domNodes": -268,
      "jsHeapTotalBytes": -1093632,
      "scriptDurationMs": 26.588,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2039.1500000000633,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.562000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 584.54,
      "heapDeltaBytes": -13209432,
      "heapUsedBytes": 86757588,
      "domNodes": -268,
      "jsHeapTotalBytes": -1617920,
      "scriptDurationMs": 32.11299999999999,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2244.658999999956,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 11.999999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1619.464,
      "heapDeltaBytes": 12439732,
      "heapUsedBytes": 89068840,
      "domNodes": -272,
      "jsHeapTotalBytes": 405504,
      "scriptDurationMs": 803.424,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2210.635000000025,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 12.068000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1567.5140000000001,
      "heapDeltaBytes": -15692860,
      "heapUsedBytes": 84541088,
      "domNodes": -267,
      "jsHeapTotalBytes": -1392640,
      "scriptDurationMs": 780.772,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3493.237000000022,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.069,
      "layouts": 60,
      "layoutDurationMs": 11.183,
      "taskDurationMs": 1637.1439999999998,
      "heapDeltaBytes": 8740304,
      "heapUsedBytes": 76012748,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 756.989,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3482.420999999931,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 10.781999999999996,
      "layouts": 60,
      "layoutDurationMs": 10.95,
      "taskDurationMs": 1607.9690000000003,
      "heapDeltaBytes": 8473868,
      "heapUsedBytes": 75750160,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 737.149,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2882.0930000000544,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 6.053999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1834.9220000000003,
      "heapDeltaBytes": 20820648,
      "heapUsedBytes": 87612568,
      "domNodes": 4,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 914.01,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3040.0580000000446,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.650999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1901.1660000000002,
      "heapDeltaBytes": 18713484,
      "heapUsedBytes": 86475236,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 980.336,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2034.920999999997,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.139999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 587.287,
      "heapDeltaBytes": -14758936,
      "heapUsedBytes": 87154016,
      "domNodes": -269,
      "jsHeapTotalBytes": -1617920,
      "scriptDurationMs": 29.744999999999994,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2005.8599999999842,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 3.705,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 528.571,
      "heapDeltaBytes": 21799408,
      "heapUsedBytes": 87645440,
      "domNodes": -272,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 24.716999999999988,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 607.071000000019,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 13.418999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 408.09399999999994,
      "heapDeltaBytes": 14845360,
      "heapUsedBytes": 87009896,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 140.848,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 570.643999999902,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.543000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 385.33700000000005,
      "heapDeltaBytes": 14857248,
      "heapUsedBytes": 86977168,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 135.848,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.749000000037,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.039,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 467.01599999999996,
      "heapDeltaBytes": -8511660,
      "heapUsedBytes": 63642360,
      "domNodes": -297,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 6.966999999999998,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.8139999999867,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.899,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 465.74199999999996,
      "heapDeltaBytes": -8983736,
      "heapUsedBytes": 63018512,
      "domNodes": -297,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.057,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1709.4399999999723,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 35.706,
      "layouts": 18,
      "layoutDurationMs": 5.195,
      "taskDurationMs": 787.945,
      "heapDeltaBytes": -12037076,
      "heapUsedBytes": 59871696,
      "domNodes": -297,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 106.567,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1732.4109999999564,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 34.292,
      "layouts": 18,
      "layoutDurationMs": 4.705,
      "taskDurationMs": 787.299,
      "heapDeltaBytes": -10159132,
      "heapUsedBytes": 61842776,
      "domNodes": -296,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 101.39399999999999,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1386.5960000000541,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 30.839999999999993,
      "layouts": 14,
      "layoutDurationMs": 14.902000000000003,
      "taskDurationMs": 887.6510000000002,
      "heapDeltaBytes": 278712,
      "heapUsedBytes": 98017148,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 28.965999999999998,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 135,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8356.258000000025,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 35.75,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5592.616,
      "heapDeltaBytes": -7390476,
      "heapUsedBytes": 92591616,
      "domNodes": -269,
      "jsHeapTotalBytes": -868352,
      "scriptDurationMs": 2614.325,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8366.639000000077,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 33.120999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5516.451,
      "heapDeltaBytes": -15474984,
      "heapUsedBytes": 84721792,
      "domNodes": -269,
      "jsHeapTotalBytes": -1130496,
      "scriptDurationMs": 2570.221,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16344.727000000035,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15656.171,
      "heapDeltaBytes": -46299992,
      "heapUsedBytes": 175289220,
      "domNodes": -6548,
      "jsHeapTotalBytes": -2527232,
      "scriptDurationMs": 290.388,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16620.432999999935,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15713.098,
      "heapDeltaBytes": -28639336,
      "heapUsedBytes": 174129520,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2875392,
      "scriptDurationMs": 284.668,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20634.54299999995,
      "styleRecalcs": 171,
      "styleRecalcDurationMs": 16.237999999999975,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20216.067,
      "heapDeltaBytes": -38872084,
      "heapUsedBytes": 162488828,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2871296,
      "scriptDurationMs": 945.6410000000001,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 15,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20050.423000000024,
      "styleRecalcs": 158,
      "styleRecalcDurationMs": 15.168999999999988,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19656.250999999997,
      "heapDeltaBytes": -40087620,
      "heapUsedBytes": 162617372,
      "domNodes": -6548,
      "jsHeapTotalBytes": 958464,
      "scriptDurationMs": 864.852,
      "eventListeners": -7467,
      "totalBlockingTimeMs": 32,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5979.335999999989,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 83.895,
      "layouts": 20,
      "layoutDurationMs": 21.734,
      "taskDurationMs": 5841.497,
      "heapDeltaBytes": -27244496,
      "heapUsedBytes": 180726452,
      "domNodes": -6548,
      "jsHeapTotalBytes": 9007104,
      "scriptDurationMs": 102.25099999999999,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 450,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5974.786999999992,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 76.83299999999998,
      "layouts": 20,
      "layoutDurationMs": 20.656999999999996,
      "taskDurationMs": 5844.177,
      "heapDeltaBytes": -21201472,
      "heapUsedBytes": 180647152,
      "domNodes": -6548,
      "jsHeapTotalBytes": 17293312,
      "scriptDurationMs": 103.93100000000001,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 305,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 459.7639999999501,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 18.209999999999997,
      "layouts": 3,
      "layoutDurationMs": 1.7029999999999998,
      "taskDurationMs": 107.18599999999999,
      "heapDeltaBytes": 5281528,
      "heapUsedBytes": 72657608,
      "domNodes": 149,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 10.341000000000001,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 115.25600000004488,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 17.647,
      "layouts": 3,
      "layoutDurationMs": 2.08,
      "taskDurationMs": 90.05799999999999,
      "heapDeltaBytes": 3685992,
      "heapUsedBytes": 70883136,
      "domNodes": 196,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.375000000000001,
      "eventListeners": 79,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48000 70481 68.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.3% 398
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.4% 258
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 44.7% 204

@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@codecov

codecov Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ponents/SubscriptionTransitionPreviewWorkspace.vue 75.00% 2 Missing ⚠️
@@                               Coverage Diff                                @@
##           comfydesigner/confirm-after-failed-challenge   #16561      +/-   ##
================================================================================
+ Coverage                                         82.67%   83.27%   +0.59%     
================================================================================
  Files                                              2042     2024      -18     
  Lines                                            121307   116966    -4341     
  Branches                                          34165    33121    -1044     
================================================================================
- Hits                                             100291    97402    -2889     
+ Misses                                            20592    19218    -1374     
+ Partials                                            424      346      -78     
Flag Coverage Δ
e2e 66.61% <ø> (+0.02%) ⬆️
unit 76.52% <91.66%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ponents/SubscriptionAddPaymentPreviewWorkspace.vue 93.71% <100.00%> (+0.34%) ⬆️
...nents/SubscriptionRequiredDialogContentUnified.vue 54.46% <ø> (ø)
...nts/SubscriptionRequiredDialogContentWorkspace.vue 100.00% <ø> (ø)
...m/workspace/composables/useSubscriptionCheckout.ts 89.15% <100.00%> (ø)
...platform/workspace/stores/billingOperationStore.ts 93.20% <100.00%> (+0.38%) ⬆️
...ponents/SubscriptionTransitionPreviewWorkspace.vue 93.22% <75.00%> (-1.51%) ⬇️

... and 161 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfydesigner comfydesigner added the cursor-review Trigger multi-model Cursor agent review on this PR label Sep 2, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @comfydesigner.

Found 8 finding(s).

Severity Count
🟠 High 2
🟡 Medium 3
🟢 Low 2
⚪ Nit 1

Panel: 8/8 reviewers contributed findings.

authenticationState === 'requires_action') &&
canRetryAuthentication
)
!(authenticationState === 'requires_action' && canRetryAuthentication)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High — Narrowing this guard to requires_action only lets the hosted actionUrl "Complete verification" button render while the operation is failed_retryable; the store never clears actionUrl on failure, so the user is pointed back at the challenge that just failed, directly above the new alert saying it didn't finish. In capture mode this is a dead end: UnifiedStripePaymentSelector receives verification-pending = Boolean(actionUrl) and disables its pay button, so the notice's "Try again" has no working affordance now that the in-page retry is gone. Keep failed_retryable in the exclusion (or clear actionUrl on failure).

Raised by 5 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, gemini-3.1-pro edge-case, kimi-k3-max edge-case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in b7146af — the hosted verification button no longer renders during failed_retryable in either preview, and the previously-vacuous test now passes an actionUrl and asserts the button's absence.

{{ $t('subscription.preview.completeVerification') }}
</Button>

<div

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High — Dropping authenticationError discards the mapped decline detail that billingOperationStore.updateAuthenticationState writes into operation.errorMessage via billingFailureDetail (insufficient funds, expired card, incorrect CVC, do-not-retry decline), so every failure now reads "Your bank didn't confirm this payment. Try again." and steers the user into a retry that fails identically. The !canRetryAuthentication branch is also wrong for a Stripe.js load failure, which sets canRetryAuthentication = false and now renders "needs attention from a workspace billing manager" for a purely client-side problem. useSubscriptionCheckout's authenticationError is left computed and exported with no consumer.

Raised by 6 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case, kimi-k3-max edge-case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in b7146af, one level deeper than the comment asks: failed_retryable's errorMessage is now guaranteed mapped at the source (the two raw-SDK call sites map through billingFailureDetail / the auth-failed fallback), and both previews render it as a verdict line under the notice via a failureDetail prop. The customer sees 'Your card has insufficient funds', never handleNextAction prose.

authenticationState === 'requires_action') &&
canRetryAuthentication
)
!(authenticationState === 'requires_action' && canRetryAuthentication)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — Same guard narrowing as the add-payment preview: with a retained actionUrl, a "Complete verification" button linking to the already-failed challenge renders immediately above the alert stating verification didn't finish. The confirm button stays enabled on this rail, so it is contradictory presentation rather than a fully blocked flow, but the exclusion should still cover failed_retryable.

Raised by 5 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, gemini-3.1-pro edge-case, kimi-k3-max edge-case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same fix as the add-payment preview, same commit — button hidden, verdict line added.

>
{{
$t(
canRetryAuthentication

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — Same loss of the store's mapped decline detail as the add-payment preview, and it bites harder here: this rail charges the subscription's existing default card and offers no "use a different card" escape, so a hard decline loops on generic "Try again" copy that cannot succeed. The canRetryAuthentication ternary also mislabels a Stripe.js load failure as needing a workspace billing manager.

Raised by 4 of 8 reviewers (gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case, kimi-k3-max edge-case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same fix — and the escape concern is the transition preview's structural reality (payment on file, no swap affordance); the verdict line at least names why, and terminal declines route to the declined step with Update payment method one PR down the stack.

embeddedCheckoutEnabled &&
(authenticationState === 'failed_retryable' ||
authenticationState === 'requires_action') &&
authenticationState === 'requires_action' &&

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — Gating the retry button on requires_action alone removes the only in-page way to retry the existing PaymentIntent, even though canRetryAuthentication is still true in failed_retryable because the store deliberately keeps the client secret. failed_retryable is also set when Stripe fails to load or handleNextAction throws — cases where the original intent still requires action and the pending operation may still hold checkoutMutationLocked, so the fresh submit the new copy steers users toward is either silently rejected or starts a second subscribe operation while the first is still polling. Note TopUpCreditsDialogContentWorkspace.vue still retries the same intent for this state, and the mirrored change at SubscriptionTransitionPreviewWorkspace.vue:242 has the same gap.

Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional: retrying the existing intent via handleNextAction is exactly what never worked (it can't resume a finished challenge — the loop #16123 removes). canRetryAuthentication staying true reflects the client secret being retained, not the retry being viable. The fresh attempt through confirm is the recovery.

class="m-0"
>
<template #useDifferentCard>
<button

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — This inline button has no disabled guard, while the back, promo, and pay controls in this component are all gated on interactionLocked. The alert stays mounted while a fresh attempt is in flight (authenticationState only clears once the new operation registers), so it can be clicked mid-request and emit changePaymentMethod, replacing the saved-method pay button with a freshly keyed UnifiedStripePaymentSelector while the confirm is still outstanding.

Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in b7146af — the link disables with interactionLocked like its siblings.

'billingOperation.challengeFailedRetry'
)
expect(
screen.queryByRole('button', {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — This assertion passes vacuously: no actionUrl prop is rendered, so the "Complete verification" button could not have appeared regardless of the template change. The case that actually regressed is failed_retryable with a retained actionUrl, which now does render the button — add actionUrl to the props here and in the mirrored assertion at SubscriptionTransitionPreviewWorkspace.test.ts:148.

Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right — fixed in b7146af; the test now supplies the actionUrl and the assertion is load-bearing against the newly hidden button.

{{ $t('billingOperation.authenticationManagerRequired') }}
</p>
<i18n-t
v-else-if="savedMethods?.length"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ Nit — savedMethods is not card-only (the component supports saved Alipay methods), so a non-empty list can render "use a different card" for a checkout whose saved method isn't a card, and the emitted flow opens the generic payment-method selector anyway. Neutral copy such as "use a different payment method" would avoid the mismatch.

Raised by 1 of 8 reviewers (gpt-5.6-sol-max edge-case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair catch on precision; keeping the designed copy for now since the escalation opens the full payment selector (cards and Alipay both), and the notice names the common case. Flagged for the design side to consider 'use a different payment method' if Alipay-saved checkouts grow.

@huang47 huang47 added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@huang47 huang47 removed the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@vercel

vercel Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
comfy-home-v1 Error Error Sep 4, 2026 12:39am UTC

Request Review

@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 4, 2026

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core of this is right, and two parts are genuinely good:

  • Mapping result.error.decline_code ?? result.error.code through billingFailureDetail instead of surfacing result.error.message finally stops raw Stripe SDK prose (handleNextAction: The PaymentIntent supplied is not in the requires_action state) reaching a customer. That's the right direction.
  • I verified the "Try again = the confirm button" claim against the base: isVerificationRecoveryActive locks only on requires_action and a reconciliation hold, so the confirm action really is live during failed_retryable. The copy points at a working button.
  • I also checked that failed_retryable is a server-supplied value in the generated contract (authentication_state in @comfyorg/ingest-types), so "retryable" is the server's assertion, not something the FE inferred. Good.

One blocking issue: in production the notice renders two sentences that say the same thing, because failureDetail is never empty. Detail inline — the tests miss it because they only exercise the specific-reason case or omit the prop entirely.

And one question about the #15942 ordering seam you flagged in the description, which I'd like pinned down before this merges rather than at rebase time.

{{ $t('billingOperation.challengeFailedRetry') }}
</p>
<p
v-if="canRetryAuthentication && failureDetail"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (blocking): failureDetail is always truthy in production, so this second paragraph always renders — and for the most common 3DS failure it just repeats the line above it.

failureDetail is activeCheckoutOperation.errorMessage, which setAuthenticationRetry now fills with (code && billingFailureDetail(operation.type, code)) || t('billingOperation.authenticationFailedDetail'). billingFailureDetail never returns empty for a subscription: unmatched codes fall through to t('billingOperation.subscriptionFailedDetail'), and the catch branch hardcodes authenticationFailedDetail. So v-if="canRetryAuthentication && failureDetail" is effectively v-if="canRetryAuthentication".

A failed handleNextAction typically reports payment_intent_authentication_failure, which billingFailureDetail maps to authenticationFailedDetail. The customer then reads:

Verification didn't finish. Your bank didn't confirm this payment. Try again, or use a different card.
We couldn't complete payment verification. Please try again.

Two "try again" instructions stacked in one box. For an unmapped code it's worse — "We couldn't update your subscription. Please try again." contradicts the framing, since the subscription isn't what failed; verification is.

That undercuts the PR's own goal of "one mapped notice with two live routes".

This sub-line only earns its place when it carries a specific bank verdict (insufficient funds, expired card, incorrect CVC). Could we have billingFailureDetail return null for the unmapped/generic cases and let callers apply their own fallback, so this can render only when there's a real reason to show? That mirrors how #15944's reason box is gated.

The tests don't catch this: confirmLock.test.ts passes a specific reason ('Your card has insufficient funds.', which composes fine), and the two new notice tests pass no failureDetail at all. Worth a case with a generic detail asserting the box doesn't say "try again" twice.

setAuthenticationRetry(
opId,
result.error.message ||
(code && billingFailureDetail(operation.type, code)) ||

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: this is the source of the always-truthy detail described on SubscriptionAddPaymentPreviewWorkspace.vue:301.

The || fallback here reads as "use the mapped copy if we have one, else the generic", but billingFailureDetail already absorbs the generic case internally (subscriptionFailedDetail for unmatched subscription codes), so the right-hand side only fires when code is null. The consumer therefore can't distinguish "the bank told us something" from "we have nothing specific", which is the distinction the notice UI needs.

Having billingFailureDetail return null when it has no specific mapping would make both this call site and the notice express what they actually mean.

size="unset"
:disabled="interactionLocked"
class="inline p-0 text-sm text-inherit underline underline-offset-2"
@click="$emit('changePaymentMethod')"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: how do you want to sequence this against #15942?

Your description notes that #15942 locks the saved-method Change affordance during failed_retryable via challengeInFlight, and that it needs the same narrowing this stack gave the confirm button or "the link renders dead once that PR lands". I confirmed challengeInFlight isn't on this head, so today the link works.

The concern is that #15942 is open and not a draft, so whichever of the two merges second decides whether this ships broken. If #15942 lands first, the notice keeps telling customers to "use a different card" while the control that does it is disabled — and nothing in either PR's tests would fail.

Could we make that ordering explicit — either land the one-line narrowing in #15942 itself, or add a test here that asserts the link is enabled during failed_retryable so the regression surfaces on rebase rather than in production?

@comfydesigner

Copy link
Copy Markdown
Contributor Author

Closing: the full-page checkout (#19264) covers failed-challenge recovery, and the embedded dialog keeps Pay disabled until it's removed. Tracked in FE-1988 (canceled).

This branch had an error being deployed

1 failed deployment
Preview – comfy-home-v1 — 3c25c255 Deployed Sep 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor agent review on this PR risk:R3 PR risk grade (advisory shadow check; grader-owned) risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants