Repository navigation
feat(billing): a receipt screen when payment lands but the workspace lags - #16848
comfydesigner wants to merge 1 commit into
Conversation
…lags When a payment goes through but the workspace update doesn't catch up (reconciliation_needed), customers in the unified checkout dialog now land on a dedicated outcome screen instead of staying parked on the confirm step with a footer note: - It confirms the payment was received and that they won't be charged again, and hands them the operation id to give support if the workspace doesn't catch up on its own. - Got it closes the dialog; Contact support opens the existing Zendesk request form pre-filled with the account details. - The step is terminal: no retry, no payment collection, no spinner. Hosts that don't render recovery steps keep today's behavior exactly: the inline reconciliation block in the confirm footer and toast delivery are untouched.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1895 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-03T21:41:42.088Z",
"gitSha": "1a51eb9f56ce0363bd442e2d5534f5e6fd4c7099",
"branch": "comfydesigner/reconciliation-outcome",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1991.5660000000344,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.430000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 296.536,
"heapDeltaBytes": -10737184,
"heapUsedBytes": 59020848,
"domNodes": -281,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 5.651999999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2005.864000000031,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.316,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.864,
"heapDeltaBytes": 2057108,
"heapUsedBytes": 71790116,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.035,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1723.325999999986,
"styleRecalcs": 74,
"styleRecalcDurationMs": 25.447999999999997,
"layouts": 14,
"layoutDurationMs": 3.781,
"taskDurationMs": 532.844,
"heapDeltaBytes": 4462132,
"heapUsedBytes": 74143464,
"domNodes": -280,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 89.757,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1741.1140000000387,
"styleRecalcs": 74,
"styleRecalcDurationMs": 28.708000000000006,
"layouts": 14,
"layoutDurationMs": 4.114000000000001,
"taskDurationMs": 638.306,
"heapDeltaBytes": -7280184,
"heapUsedBytes": 62924112,
"domNodes": -280,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 111.649,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1659.3979999999533,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.366999999999999,
"layouts": 6,
"layoutDurationMs": 1.017,
"taskDurationMs": 216.63,
"heapDeltaBytes": 4369184,
"heapUsedBytes": 75017744,
"domNodes": 77,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 8.254000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1657.905000000028,
"styleRecalcs": 29,
"styleRecalcDurationMs": 14.682,
"layouts": 6,
"layoutDurationMs": 1.061,
"taskDurationMs": 264.40999999999997,
"heapDeltaBytes": 4397440,
"heapUsedBytes": 74741744,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.000000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 432.6260000000275,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.462000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 273.66,
"heapDeltaBytes": -8054648,
"heapUsedBytes": 62455352,
"domNodes": 20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 94.31,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 522.8640000000269,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.708,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.897,
"heapDeltaBytes": 17549120,
"heapUsedBytes": 87706564,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 116.804,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2000.3999999999564,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.312999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 331.596,
"heapDeltaBytes": 22145188,
"heapUsedBytes": 87783628,
"domNodes": -251,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 24.172999999999995,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2007.2730000000547,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.772000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.836,
"heapDeltaBytes": 22585692,
"heapUsedBytes": 87167660,
"domNodes": -269,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 30.618,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2077.541999999994,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.382000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1003.0300000000001,
"heapDeltaBytes": 21480972,
"heapUsedBytes": 87702156,
"domNodes": 8,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 508.88999999999993,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2588.0280000000084,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.259999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1162.979,
"heapDeltaBytes": 26682016,
"heapUsedBytes": 92428176,
"domNodes": -272,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 545.5360000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3119.462999999996,
"styleRecalcs": 64,
"styleRecalcDurationMs": 12.869000000000002,
"layouts": 60,
"layoutDurationMs": 12.902,
"taskDurationMs": 1104.719,
"heapDeltaBytes": 7734148,
"heapUsedBytes": 75279480,
"domNodes": 10,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 491.32399999999996,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3520.6960000000436,
"styleRecalcs": 63,
"styleRecalcDurationMs": 14.492999999999995,
"layouts": 60,
"layoutDurationMs": 14.357,
"taskDurationMs": 1237.375,
"heapDeltaBytes": 9910248,
"heapUsedBytes": 76170096,
"domNodes": -274,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 526.72,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2159.735000000012,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.270000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1200.081,
"heapDeltaBytes": 18787032,
"heapUsedBytes": 87889388,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 593.369,
"eventListeners": 184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2482.88500000001,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.544000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1392.345,
"heapDeltaBytes": 18125812,
"heapUsedBytes": 87354564,
"domNodes": 6,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 672.884,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2001.3740000000553,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.412999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 350.34,
"heapDeltaBytes": -15162232,
"heapUsedBytes": 87265264,
"domNodes": -266,
"jsHeapTotalBytes": -1884160,
"scriptDurationMs": 25.303,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2014.5219999999426,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.9700000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.70000000000005,
"heapDeltaBytes": 21796872,
"heapUsedBytes": 87511732,
"domNodes": -271,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.578000000000007,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 447.4330000000464,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.215,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 276.583,
"heapDeltaBytes": 15105312,
"heapUsedBytes": 87435460,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 91.756,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 524.7980000000325,
"styleRecalcs": 47,
"styleRecalcDurationMs": 15.501,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.345,
"heapDeltaBytes": 15067520,
"heapUsedBytes": 87369868,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 106.489,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1992.9460000000176,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.88,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 286.71100000000007,
"heapDeltaBytes": 1413856,
"heapUsedBytes": 73835772,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 4.732,
"eventListeners": -229,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.0230000000038,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.572999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.03000000000003,
"heapDeltaBytes": 3302736,
"heapUsedBytes": 75769848,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.694999999999999,
"eventListeners": -229,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.1239999999925,
"styleRecalcs": 78,
"styleRecalcDurationMs": 26.536,
"layouts": 18,
"layoutDurationMs": 4.699,
"taskDurationMs": 526.245,
"heapDeltaBytes": -621644,
"heapUsedBytes": 70423376,
"domNodes": -294,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 73.438,
"eventListeners": -229,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.9949999999963,
"styleRecalcs": 77,
"styleRecalcDurationMs": 32.719,
"layouts": 18,
"layoutDurationMs": 5.351,
"taskDurationMs": 617.81,
"heapDeltaBytes": -12291400,
"heapUsedBytes": 60385856,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 87.197,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 850.9710000000155,
"styleRecalcs": 21,
"styleRecalcDurationMs": 24.081,
"layouts": 17,
"layoutDurationMs": 11.626999999999999,
"taskDurationMs": 685.1319999999998,
"heapDeltaBytes": 20982908,
"heapUsedBytes": 108165388,
"domNodes": 13751,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 20.334999999999997,
"eventListeners": 2381,
"totalBlockingTimeMs": 67,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8223.974999999995,
"styleRecalcs": 248,
"styleRecalcDurationMs": 40.58200000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3888.1670000000004,
"heapDeltaBytes": 12509656,
"heapUsedBytes": 88251216,
"domNodes": -270,
"jsHeapTotalBytes": -1171456,
"scriptDurationMs": 1788.522,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9363.732999999911,
"styleRecalcs": 249,
"styleRecalcDurationMs": 43.74,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4370.173000000001,
"heapDeltaBytes": 13893140,
"heapUsedBytes": 90013132,
"domNodes": -268,
"jsHeapTotalBytes": -647168,
"scriptDurationMs": 1940.535,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12154.896000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11149.041000000001,
"heapDeltaBytes": -12728232,
"heapUsedBytes": 176364436,
"domNodes": -6548,
"jsHeapTotalBytes": -4153344,
"scriptDurationMs": 164.70200000000003,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 12825.004000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12277.682999999999,
"heapDeltaBytes": -34567188,
"heapUsedBytes": 175881132,
"domNodes": -6548,
"jsHeapTotalBytes": -5963776,
"scriptDurationMs": 177.98600000000002,
"eventListeners": -7477,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14364.391000000012,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.787999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13803.907,
"heapDeltaBytes": -40111068,
"heapUsedBytes": 169997228,
"domNodes": -6548,
"jsHeapTotalBytes": 2162688,
"scriptDurationMs": 603.392,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14819.528999999988,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.257999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14426.113999999998,
"heapDeltaBytes": -44422000,
"heapUsedBytes": 165728660,
"domNodes": -6548,
"jsHeapTotalBytes": -7778304,
"scriptDurationMs": 684.976,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 4431.2769999999655,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.96400000000001,
"layouts": 20,
"layoutDurationMs": 22.514999999999993,
"taskDurationMs": 4316.226000000001,
"heapDeltaBytes": -34451440,
"heapUsedBytes": 175921112,
"domNodes": -6548,
"jsHeapTotalBytes": 14483456,
"scriptDurationMs": 76.154,
"eventListeners": -7471,
"totalBlockingTimeMs": 32,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4698.713999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 55.480000000000004,
"layouts": 20,
"layoutDurationMs": 23.710999999999995,
"taskDurationMs": 4562.503,
"heapDeltaBytes": -39545012,
"heapUsedBytes": 170528096,
"domNodes": -6548,
"jsHeapTotalBytes": 16580608,
"scriptDurationMs": 85.62599999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 55,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 101.22499999999945,
"styleRecalcs": 8,
"styleRecalcDurationMs": 13.155999999999999,
"layouts": 2,
"layoutDurationMs": 1.1709999999999998,
"taskDurationMs": 65.07199999999999,
"heapDeltaBytes": 3302428,
"heapUsedBytes": 71663312,
"domNodes": 136,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 101.02400000005218,
"styleRecalcs": 7,
"styleRecalcDurationMs": 17.357999999999997,
"layouts": 2,
"layoutDurationMs": 0.786,
"taskDurationMs": 66.75699999999999,
"heapDeltaBytes": 3152368,
"heapUsedBytes": 71101148,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.146000000000001,
"eventListeners": 51,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## comfydesigner/checkout-failure-dialog #16848 +/- ##
======================================================================
Coverage 82.30% 82.30%
======================================================================
Files 2021 2022 +1
Lines 116826 116858 +32
Branches 32371 32383 +12
======================================================================
+ Hits 96152 96179 +27
- Misses 20496 20501 +5
Partials 178 178
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
The screen itself is in good shape and I couldn't find a defect in the routing. Things I checked and found correct:
- Re-entry can't loop. The initializer only claims
subscriptionActionOperation?.status === 'pending', so reopening on an already-reconciling operation keeps today's pricing-entry + footer-block behavior, exactly as the description says. operationIdis server-derived (reconciliationOperationIdreads the operation's ownopIdonly while its status isreconciliation_needed), not assembled on the client.- The out-of-credits banner can't stack under it — #15944 left that block positively gated to
pricing/preview, so the new step is safe inside the fixed-heightoverflow-hiddenpanel. useCurrentUser()insidehandleContactSupportis fine: it reads Pinia only, noinject/lifecycle, and it's the same patternComfy.ContactSupportuses inuseCoreCommands.ts:890.muted-textonly/size="unset"are real variants inbutton.variants.ts.
Not approving yet only because of the red e2e below — I don't think this PR caused it, but it should have an answer before the stack merges. Two non-blocking suggestions inline.
Unanchored
browser_tests/tests/dialogs/checkout3dsStates.spec.ts:167 › Checkout 3DS verifying re-entry › cancel returns to plan selection @cloud fails here, and it failed all 3 retries — not a flake.
It isn't yours: the same test fails on #15944 (run 33705704392) and #16571 (run 33705710528) at their current heads, so it enters somewhere below this PR in the checkout-3ds-cancel lineage. It does not fail on #16561, which sits on the other branch. The test was added by this stack (it doesn't exist on main), and #15923's latest head hasn't had the e2e job run, so I couldn't isolate whether it entered at #15923 or #15944.
Could you take a look at where it breaks? cancel returns to plan selection is exactly the re-entry/step-routing surface this PR extends, so I'd rather not approve on top of it while it's red.
(creditsTile.spec.ts:489 also fails, but it fails on both lineages including #16561, so that one looks environmental rather than stack-caused.)
| const { userEmail, resolvedUserInfo } = useCurrentUser() | ||
| const supportUrl = buildSupportUrl({ | ||
| userEmail: userEmail.value, | ||
| userId: resolvedUserInfo.value?.id |
There was a problem hiding this comment.
suggestion: the operation id is the one thing this screen exists to hand over, and it's the one thing the support link doesn't carry.
The screen says "If it doesn't resolve, give support this ID", then Contact support opens the Zendesk form pre-filled with email and user id only. The customer has to switch back to the dialog, read an opaque id off the screen, and retype it into the form — with the dialog possibly already closed behind the new tab.
buildSupportUrl takes a params object and appends to a URLSearchParams, so threading the id through as another Zendesk field looks cheap. Worth checking whether there's an existing field for it; if not, even putting it in the description prefill would save the retype.
| {{ $t('billingOperation.reconciliationSupportLabel') }} | ||
| </span> | ||
| <span class="font-mono text-sm text-base-foreground">{{ | ||
| operationId |
There was a problem hiding this comment.
suggestion: a copy-to-clipboard affordance on the id would be worth it here.
This is a monospace opaque identifier that the copy above explicitly asks the customer to relay to support. Selecting it by hand on mobile — inside a dialog that closes when they hit "Got it" — is the fiddliest possible step in an already-bad moment for them.
Non-blocking, and it pairs with the support-URL point on the parent: if the id ends up prefilled in the Zendesk form, this matters less.
When a payment goes through but the workspace doesn't update (
reconciliation_needed), users now get a clear receipt screen instead of a technical note pinned under the confirm button: it says the payment was received, that they won't be charged again, and hands them the operation ID to give support if the workspace doesn't catch up on its own. "Got it" closes the dialog; "Contact support" opens the existing Zendesk request form (buildSupportUrlfromsrc/platform/support/config.ts, same destination as theComfy.ContactSupportcommand), pre-filled with account details.Implementation notes:
SubscriptionReconciliationWorkspace.vue(outcome 5d), modeled on the 5c processing-error step: lucide clock in the shared warning treatment, boxed support label + monospace operation id (box omitted when no id is known, mirroring 5b's reason box).useSubscriptionCheckout.ts: the terminal-operation resolution after subscribe, and the verifying-step watcher for a livepending → reconciliation_neededtransition. Both are gated onrendersRecoverySteps, so only the unified dialog host opts in.handleReconciliationCloseemitsclose(false)— the payment landed but the subscription isn't confirmed active, so the close never claimssubscribed.billingOperation.*locale keys:reconciliationScreenTitle,reconciliationScreenDetail,reconciliationSupportLabel,gotIt,contactSupport(the only existing "Got it" key is scoped toagent.*).Linear: FE-1992
Stacked on #16571 (
comfydesigner/checkout-failure-dialog); retarget tomainwhen that merges.