Skip to content

feat(billing): a receipt screen when payment lands but the workspace lags - #16848

Closed
comfydesigner wants to merge 1 commit into
comfydesigner/checkout-failure-dialogfrom
comfydesigner/reconciliation-outcome
Closed

comfydesigner wants to merge 1 commit into
comfydesigner/checkout-failure-dialogfrom
comfydesigner/reconciliation-outcome

Conversation

@comfydesigner

Copy link
Copy Markdown
Contributor

When a payment goes through but the workspace doesn't update (reconciliation_needed), users now get a clear receipt screen instead of a technical note pinned under the confirm button: it says the payment was received, that they won't be charged again, and hands them the operation ID to give support if the workspace doesn't catch up on its own. "Got it" closes the dialog; "Contact support" opens the existing Zendesk request form (buildSupportUrl from src/platform/support/config.ts, same destination as the Comfy.ContactSupport command), pre-filled with account details.

Implementation notes:

  • New SubscriptionReconciliationWorkspace.vue (outcome 5d), modeled on the 5c processing-error step: lucide clock in the shared warning treatment, boxed support label + monospace operation id (box omitted when no id is known, mirroring 5b's reason box).
  • Routing uses the same two hooks the declined/processing outcomes use in useSubscriptionCheckout.ts: the terminal-operation resolution after subscribe, and the verifying-step watcher for a live pending → reconciliation_needed transition. Both are gated on rendersRecoverySteps, so only the unified dialog host opts in.
  • The step is terminal for the dialog: no retry, no update-payment affordance, no spinner. handleReconciliationClose emits close(false) — the payment landed but the subscription isn't confirmed active, so the close never claims subscribed.
  • Legacy hosts and the existing footer reconciliation block are untouched; re-entry with an already-reconciling operation also keeps today's behavior (pricing entry + footer block), since the dialog-owning claim only applies to pending charges.
  • New billingOperation.* locale keys: reconciliationScreenTitle, reconciliationScreenDetail, reconciliationSupportLabel, gotIt, contactSupport (the only existing "Got it" key is scoped to agent.*).
  • Tests: colocated component test; composable tests for in-flow routing, re-entry routing, close semantics, and the unchanged legacy host.

Linear: FE-1992

Stacked on #16571 (comfydesigner/checkout-failure-dialog); retarget to main when that merges.

…lags

When a payment goes through but the workspace update doesn't catch up
(reconciliation_needed), customers in the unified checkout dialog now
land on a dedicated outcome screen instead of staying parked on the
confirm step with a footer note:

- It confirms the payment was received and that they won't be charged
  again, and hands them the operation id to give support if the
  workspace doesn't catch up on its own.
- Got it closes the dialog; Contact support opens the existing Zendesk
  request form pre-filled with the account details.
- The step is terminal: no retry, no payment collection, no spinner.

Hosts that don't render recovery steps keep today's behavior exactly:
the inline reconciliation block in the confirm footer and toast
delivery are untouched.
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 8babecee-12ee-4a4a-8665-51e47567b4a7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/03/2026, 09:31:42 PM UTC

Links

🎭 Playwright: ✅ 1895 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1874 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 67ms TBT · 103.2 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.0 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 168.0 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 160.1 MB heap
vue-node-resize-workload: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 44ms TBT · 165.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 328ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 62.4 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -168
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 27ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 586ms
canvas-mouse-sweep: script duration 101ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 65.4 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -168
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 14ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 241ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.4 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 301ms
dom-widget-clipping: script duration 106ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 71.6 MB
dom-widget-clipping: DOM nodes 20
dom-widget-clipping: event listeners 0
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 8
large-graph-idle: task duration 386ms
large-graph-idle: script duration 27ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.4 MB
large-graph-idle: DOM nodes -260
large-graph-idle: event listeners -152
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1083ms
large-graph-pan: script duration 527ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 85.9 MB
large-graph-pan: DOM nodes -132
large-graph-pan: event listeners 5
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 64
large-graph-zoom: task duration 1171ms
large-graph-zoom: script duration 509ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.2 MB
large-graph-zoom: DOM nodes -132
large-graph-zoom: event listeners 8
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 44
legacy-node-drag: task duration 1296ms
legacy-node-drag: script duration 633ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 83.6 MB
legacy-node-drag: DOM nodes 7
legacy-node-drag: event listeners 185
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 7
minimap-idle: task duration 397ms
minimap-idle: script duration 27ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.3 MB
minimap-idle: DOM nodes -269
minimap-idle: event listeners -153
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 13ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 307ms
subgraph-dom-widget-clipping: script duration 99ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.4 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 320ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 71.3 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -229
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 30ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 572ms
subgraph-mouse-sweep: script duration 80ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 62.4 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -214
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 24ms
subgraph-transition-enter: layout count 17
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 685ms
subgraph-transition-enter: script duration 20ms
subgraph-transition-enter: TBT 67ms
subgraph-transition-enter: heap used 103.2 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 42ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 4129ms
viewport-pan-sweep: script duration 1865ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 85.0 MB
viewport-pan-sweep: DOM nodes -269
viewport-pan-sweep: event listeners -165
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 11713ms
vue-large-graph-idle: script duration 171ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 168.0 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7476
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 14ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 70
vue-large-graph-pan: task duration 14115ms
vue-large-graph-pan: script duration 644ms
vue-large-graph-pan: TBT 0ms
vue-large-graph-pan: heap used 160.1 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7473
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 55ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4439ms
vue-node-resize-workload: script duration 81ms
vue-node-resize-workload: TBT 44ms
vue-node-resize-workload: heap used 165.2 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7471
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 2
workflow-execution: style recalc count 8
workflow-execution: task duration 66ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.1 MB
workflow-execution: DOM nodes 122
workflow-execution: event listeners 50
Raw data
{
  "timestamp": "2026-09-03T21:41:42.088Z",
  "gitSha": "1a51eb9f56ce0363bd442e2d5534f5e6fd4c7099",
  "branch": "comfydesigner/reconciliation-outcome",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 1991.5660000000344,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.430000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 296.536,
      "heapDeltaBytes": -10737184,
      "heapUsedBytes": 59020848,
      "domNodes": -281,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 5.651999999999999,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2005.864000000031,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.316,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 358.864,
      "heapDeltaBytes": 2057108,
      "heapUsedBytes": 71790116,
      "domNodes": -280,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 9.035,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1723.325999999986,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 25.447999999999997,
      "layouts": 14,
      "layoutDurationMs": 3.781,
      "taskDurationMs": 532.844,
      "heapDeltaBytes": 4462132,
      "heapUsedBytes": 74143464,
      "domNodes": -280,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 89.757,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1741.1140000000387,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 28.708000000000006,
      "layouts": 14,
      "layoutDurationMs": 4.114000000000001,
      "taskDurationMs": 638.306,
      "heapDeltaBytes": -7280184,
      "heapUsedBytes": 62924112,
      "domNodes": -280,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 111.649,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1659.3979999999533,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 12.366999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.017,
      "taskDurationMs": 216.63,
      "heapDeltaBytes": 4369184,
      "heapUsedBytes": 75017744,
      "domNodes": 77,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 8.254000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1657.905000000028,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 14.682,
      "layouts": 6,
      "layoutDurationMs": 1.061,
      "taskDurationMs": 264.40999999999997,
      "heapDeltaBytes": 4397440,
      "heapUsedBytes": 74741744,
      "domNodes": 77,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 12.000000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 432.6260000000275,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 6.462000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 273.66,
      "heapDeltaBytes": -8054648,
      "heapUsedBytes": 62455352,
      "domNodes": 20,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 94.31,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999998,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 522.8640000000269,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.708,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 328.897,
      "heapDeltaBytes": 17549120,
      "heapUsedBytes": 87706564,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 116.804,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2000.3999999999564,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.312999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 331.596,
      "heapDeltaBytes": 22145188,
      "heapUsedBytes": 87783628,
      "domNodes": -251,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 24.172999999999995,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2007.2730000000547,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.772000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 439.836,
      "heapDeltaBytes": 22585692,
      "heapUsedBytes": 87167660,
      "domNodes": -269,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 30.618,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2077.541999999994,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.382000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1003.0300000000001,
      "heapDeltaBytes": 21480972,
      "heapUsedBytes": 87702156,
      "domNodes": 8,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 508.88999999999993,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2588.0280000000084,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 13.259999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1162.979,
      "heapDeltaBytes": 26682016,
      "heapUsedBytes": 92428176,
      "domNodes": -272,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 545.5360000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3119.462999999996,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 12.869000000000002,
      "layouts": 60,
      "layoutDurationMs": 12.902,
      "taskDurationMs": 1104.719,
      "heapDeltaBytes": 7734148,
      "heapUsedBytes": 75279480,
      "domNodes": 10,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 491.32399999999996,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3520.6960000000436,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 14.492999999999995,
      "layouts": 60,
      "layoutDurationMs": 14.357,
      "taskDurationMs": 1237.375,
      "heapDeltaBytes": 9910248,
      "heapUsedBytes": 76170096,
      "domNodes": -274,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 526.72,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2159.735000000012,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 7.270000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1200.081,
      "heapDeltaBytes": 18787032,
      "heapUsedBytes": 87889388,
      "domNodes": 8,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 593.369,
      "eventListeners": 184,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2482.88500000001,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 7.544000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1392.345,
      "heapDeltaBytes": 18125812,
      "heapUsedBytes": 87354564,
      "domNodes": 6,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 672.884,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2001.3740000000553,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 5.412999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 350.34,
      "heapDeltaBytes": -15162232,
      "heapUsedBytes": 87265264,
      "domNodes": -266,
      "jsHeapTotalBytes": -1884160,
      "scriptDurationMs": 25.303,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2014.5219999999426,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 3.9700000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 442.70000000000005,
      "heapDeltaBytes": 21796872,
      "heapUsedBytes": 87511732,
      "domNodes": -271,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 29.578000000000007,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 447.4330000000464,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 10.215,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 276.583,
      "heapDeltaBytes": 15105312,
      "heapUsedBytes": 87435460,
      "domNodes": 22,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 91.756,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999998,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 524.7980000000325,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 15.501,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 338.345,
      "heapDeltaBytes": 15067520,
      "heapUsedBytes": 87369868,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 106.489,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1992.9460000000176,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.88,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 286.71100000000007,
      "heapDeltaBytes": 1413856,
      "heapUsedBytes": 73835772,
      "domNodes": -296,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 4.732,
      "eventListeners": -229,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.0230000000038,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.572999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 353.03000000000003,
      "heapDeltaBytes": 3302736,
      "heapUsedBytes": 75769848,
      "domNodes": -297,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.694999999999999,
      "eventListeners": -229,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1689.1239999999925,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 26.536,
      "layouts": 18,
      "layoutDurationMs": 4.699,
      "taskDurationMs": 526.245,
      "heapDeltaBytes": -621644,
      "heapUsedBytes": 70423376,
      "domNodes": -294,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 73.438,
      "eventListeners": -229,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1692.9949999999963,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 32.719,
      "layouts": 18,
      "layoutDurationMs": 5.351,
      "taskDurationMs": 617.81,
      "heapDeltaBytes": -12291400,
      "heapUsedBytes": 60385856,
      "domNodes": -296,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 87.197,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 850.9710000000155,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 24.081,
      "layouts": 17,
      "layoutDurationMs": 11.626999999999999,
      "taskDurationMs": 685.1319999999998,
      "heapDeltaBytes": 20982908,
      "heapUsedBytes": 108165388,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11534336,
      "scriptDurationMs": 20.334999999999997,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 67,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8223.974999999995,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 40.58200000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3888.1670000000004,
      "heapDeltaBytes": 12509656,
      "heapUsedBytes": 88251216,
      "domNodes": -270,
      "jsHeapTotalBytes": -1171456,
      "scriptDurationMs": 1788.522,
      "eventListeners": -167,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9363.732999999911,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 43.74,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4370.173000000001,
      "heapDeltaBytes": 13893140,
      "heapUsedBytes": 90013132,
      "domNodes": -268,
      "jsHeapTotalBytes": -647168,
      "scriptDurationMs": 1940.535,
      "eventListeners": -163,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12154.896000000008,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11149.041000000001,
      "heapDeltaBytes": -12728232,
      "heapUsedBytes": 176364436,
      "domNodes": -6548,
      "jsHeapTotalBytes": -4153344,
      "scriptDurationMs": 164.70200000000003,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12825.004000000035,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12277.682999999999,
      "heapDeltaBytes": -34567188,
      "heapUsedBytes": 175881132,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5963776,
      "scriptDurationMs": 177.98600000000002,
      "eventListeners": -7477,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14364.391000000012,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 12.787999999999993,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13803.907,
      "heapDeltaBytes": -40111068,
      "heapUsedBytes": 169997228,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2162688,
      "scriptDurationMs": 603.392,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14819.528999999988,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 15.257999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14426.113999999998,
      "heapDeltaBytes": -44422000,
      "heapUsedBytes": 165728660,
      "domNodes": -6548,
      "jsHeapTotalBytes": -7778304,
      "scriptDurationMs": 684.976,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4431.2769999999655,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 53.96400000000001,
      "layouts": 20,
      "layoutDurationMs": 22.514999999999993,
      "taskDurationMs": 4316.226000000001,
      "heapDeltaBytes": -34451440,
      "heapUsedBytes": 175921112,
      "domNodes": -6548,
      "jsHeapTotalBytes": 14483456,
      "scriptDurationMs": 76.154,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 32,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4698.713999999995,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 55.480000000000004,
      "layouts": 20,
      "layoutDurationMs": 23.710999999999995,
      "taskDurationMs": 4562.503,
      "heapDeltaBytes": -39545012,
      "heapUsedBytes": 170528096,
      "domNodes": -6548,
      "jsHeapTotalBytes": 16580608,
      "scriptDurationMs": 85.62599999999999,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 55,
      "frameDurationMs": 17.223333333333297,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 101.22499999999945,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 13.155999999999999,
      "layouts": 2,
      "layoutDurationMs": 1.1709999999999998,
      "taskDurationMs": 65.07199999999999,
      "heapDeltaBytes": 3302428,
      "heapUsedBytes": 71663312,
      "domNodes": 136,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 6,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 101.02400000005218,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 17.357999999999997,
      "layouts": 2,
      "layoutDurationMs": 0.786,
      "taskDurationMs": 66.75699999999999,
      "heapDeltaBytes": 3152368,
      "heapUsedBytes": 71101148,
      "domNodes": 108,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.146000000000001,
      "eventListeners": 51,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48043 70547 68.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.4% 397
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.1% 330
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.4% 258
src/scripts/app.ts 71.6% 250
src/scripts/pnginfo.ts 21.4% 221
src/renderer/core/canvas/pathRenderer.ts 24.7% 192

@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 3, 2026
@codecov

codecov Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.81818% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...nents/SubscriptionRequiredDialogContentUnified.vue 25.00% 6 Missing ⚠️
@@                          Coverage Diff                           @@
##           comfydesigner/checkout-failure-dialog   #16848   +/-   ##
======================================================================
  Coverage                                  82.30%   82.30%           
======================================================================
  Files                                       2021     2022    +1     
  Lines                                     116826   116858   +32     
  Branches                                   32371    32383   +12     
======================================================================
+ Hits                                       96152    96179   +27     
- Misses                                     20496    20501    +5     
  Partials                                     178      178           
Flag Coverage Δ
e2e 68.08% <ø> (+0.01%) ⬆️
unit 76.63% <81.81%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...components/SubscriptionReconciliationWorkspace.vue 100.00% <100.00%> (ø)
...m/workspace/composables/useSubscriptionCheckout.ts 89.21% <100.00%> (+0.13%) ⬆️
...nents/SubscriptionRequiredDialogContentUnified.vue 50.74% <25.00%> (-1.64%) ⬇️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The screen itself is in good shape and I couldn't find a defect in the routing. Things I checked and found correct:

  • Re-entry can't loop. The initializer only claims subscriptionActionOperation?.status === 'pending', so reopening on an already-reconciling operation keeps today's pricing-entry + footer-block behavior, exactly as the description says.
  • operationId is server-derived (reconciliationOperationId reads the operation's own opId only while its status is reconciliation_needed), not assembled on the client.
  • The out-of-credits banner can't stack under it — #15944 left that block positively gated to pricing/preview, so the new step is safe inside the fixed-height overflow-hidden panel.
  • useCurrentUser() inside handleContactSupport is fine: it reads Pinia only, no inject/lifecycle, and it's the same pattern Comfy.ContactSupport uses in useCoreCommands.ts:890.
  • muted-textonly / size="unset" are real variants in button.variants.ts.

Not approving yet only because of the red e2e below — I don't think this PR caused it, but it should have an answer before the stack merges. Two non-blocking suggestions inline.

Unanchored

browser_tests/tests/dialogs/checkout3dsStates.spec.ts:167 › Checkout 3DS verifying re-entry › cancel returns to plan selection @cloud fails here, and it failed all 3 retries — not a flake.

It isn't yours: the same test fails on #15944 (run 33705704392) and #16571 (run 33705710528) at their current heads, so it enters somewhere below this PR in the checkout-3ds-cancel lineage. It does not fail on #16561, which sits on the other branch. The test was added by this stack (it doesn't exist on main), and #15923's latest head hasn't had the e2e job run, so I couldn't isolate whether it entered at #15923 or #15944.

Could you take a look at where it breaks? cancel returns to plan selection is exactly the re-entry/step-routing surface this PR extends, so I'd rather not approve on top of it while it's red.

(creditsTile.spec.ts:489 also fails, but it fails on both lineages including #16561, so that one looks environmental rather than stack-caused.)

const { userEmail, resolvedUserInfo } = useCurrentUser()
const supportUrl = buildSupportUrl({
userEmail: userEmail.value,
userId: resolvedUserInfo.value?.id

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: the operation id is the one thing this screen exists to hand over, and it's the one thing the support link doesn't carry.

The screen says "If it doesn't resolve, give support this ID", then Contact support opens the Zendesk form pre-filled with email and user id only. The customer has to switch back to the dialog, read an opaque id off the screen, and retype it into the form — with the dialog possibly already closed behind the new tab.

buildSupportUrl takes a params object and appends to a URLSearchParams, so threading the id through as another Zendesk field looks cheap. Worth checking whether there's an existing field for it; if not, even putting it in the description prefill would save the retype.

{{ $t('billingOperation.reconciliationSupportLabel') }}
</span>
<span class="font-mono text-sm text-base-foreground">{{
operationId

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: a copy-to-clipboard affordance on the id would be worth it here.

This is a monospace opaque identifier that the copy above explicitly asks the customer to relay to support. Selecting it by hand on mobile — inside a dialog that closes when they hit "Got it" — is the fiddliest possible step in an already-bad moment for them.

Non-blocking, and it pairs with the support-URL point on the parent: if the id ends up prefilled in the Zendesk form, this matters less.

This branch had an error being deployed

1 failed deployment
Preview – comfy-home-v1 — 82529f7f Deployed Sep 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:R3 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants