Repository navigation
test(crdt): assert follower node-slot parity across batch boundaries (R-96) - #16555
Conversation
|
Warning Review limit reachedNext included review available in 5 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Comment |
|
@coderabbitai review |
|
🎭 Playwright: ✅ 1914 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.68 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 296 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-03T12:33:13.968Z",
"gitSha": "89261bab461a91f2c4a164dd809bef6736f89e2b",
"branch": "op9d__r87-1",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2077.3099999999545,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.9129999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 573.7829999999999,
"heapDeltaBytes": -11437776,
"heapUsedBytes": 58518528,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.041,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2056.3869999999724,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.5230000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.57099999999997,
"heapDeltaBytes": -8415488,
"heapUsedBytes": 62284648,
"domNodes": -278,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.665,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1776.1310000000208,
"styleRecalcs": 75,
"styleRecalcDurationMs": 32.003,
"layouts": 14,
"layoutDurationMs": 4.056000000000001,
"taskDurationMs": 793.078,
"heapDeltaBytes": -7225216,
"heapUsedBytes": 63475784,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 127.49,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1802.8470000000425,
"styleRecalcs": 75,
"styleRecalcDurationMs": 32.309999999999995,
"layouts": 14,
"layoutDurationMs": 4.08,
"taskDurationMs": 824.7500000000001,
"heapDeltaBytes": -12333052,
"heapUsedBytes": 58490160,
"domNodes": -283,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 128.11999999999998,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1687.5840000000153,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.28,
"layouts": 6,
"layoutDurationMs": 1.2599999999999998,
"taskDurationMs": 343.44399999999996,
"heapDeltaBytes": 5036368,
"heapUsedBytes": 75840968,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.023000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.6809999999896,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.494,
"layouts": 6,
"layoutDurationMs": 1.2519999999999998,
"taskDurationMs": 349.234,
"heapDeltaBytes": 5088240,
"heapUsedBytes": 75912992,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.196000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 619.8479999999904,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.908000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.95399999999995,
"heapDeltaBytes": 17844780,
"heapUsedBytes": 88398528,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 138.295,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 614.5210000000816,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.065,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.786,
"heapDeltaBytes": -8130004,
"heapUsedBytes": 62608768,
"domNodes": 20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 144.46300000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2032.9499999999712,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.6120000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 570.171,
"heapDeltaBytes": -14055000,
"heapUsedBytes": 86566160,
"domNodes": -268,
"jsHeapTotalBytes": -1638400,
"scriptDurationMs": 31.10600000000001,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2056.2400000000025,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.615000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.1410000000001,
"heapDeltaBytes": -13940612,
"heapUsedBytes": 86716968,
"domNodes": -268,
"jsHeapTotalBytes": -1638400,
"scriptDurationMs": 41.794999999999995,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2154.852999999946,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.182000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1415.197,
"heapDeltaBytes": 21563656,
"heapUsedBytes": 87725488,
"domNodes": -273,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 680.323,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2197.4590000000944,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.575999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1468.4879999999998,
"heapDeltaBytes": 19063668,
"heapUsedBytes": 84699112,
"domNodes": -274,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 692.1709999999999,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3513.590000000022,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.424999999999997,
"layouts": 60,
"layoutDurationMs": 13.711999999999998,
"taskDurationMs": 1579.999,
"heapDeltaBytes": 11734372,
"heapUsedBytes": 79851620,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 685.2539999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3541.565999999989,
"styleRecalcs": 61,
"styleRecalcDurationMs": 12.1,
"layouts": 60,
"layoutDurationMs": 14.038,
"taskDurationMs": 1586.8510000000003,
"heapDeltaBytes": 8313488,
"heapUsedBytes": 76022856,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 689.1460000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 2791.4619999999672,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.430999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1708.2799999999997,
"heapDeltaBytes": 20400176,
"heapUsedBytes": 87695268,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 834.536,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2886.1499999999296,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.314000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1720.2379999999996,
"heapDeltaBytes": 19266192,
"heapUsedBytes": 86993064,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 843.73,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2029.6500000000037,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.156000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 563.452,
"heapDeltaBytes": -15800644,
"heapUsedBytes": 87329160,
"domNodes": -267,
"jsHeapTotalBytes": -1376256,
"scriptDurationMs": 33.85399999999999,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 1993.6219999999594,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.8390000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.4670000000001,
"heapDeltaBytes": 22190624,
"heapUsedBytes": 88228236,
"domNodes": -271,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.751999999999995,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 562.7889999999525,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.068,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.47100000000006,
"heapDeltaBytes": 15131432,
"heapUsedBytes": 87660672,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 121.12599999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 576.6969999999674,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.415,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.564,
"heapDeltaBytes": 14806208,
"heapUsedBytes": 87701088,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 123.088,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.6720000000473,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.773000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.65900000000005,
"heapDeltaBytes": 1350196,
"heapUsedBytes": 73906720,
"domNodes": -298,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.871999999999998,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2001.1919999999463,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.678,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.156,
"heapDeltaBytes": -5932028,
"heapUsedBytes": 66771520,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.802,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.9879999999712,
"styleRecalcs": 77,
"styleRecalcDurationMs": 31.695,
"layouts": 18,
"layoutDurationMs": 4.825,
"taskDurationMs": 760.8589999999999,
"heapDeltaBytes": -1057320,
"heapUsedBytes": 71028568,
"domNodes": -295,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 89.516,
"eventListeners": -228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1720.2359999999999,
"styleRecalcs": 78,
"styleRecalcDurationMs": 32.07699999999999,
"layouts": 18,
"layoutDurationMs": 4.763,
"taskDurationMs": 761.9970000000001,
"heapDeltaBytes": 1876444,
"heapUsedBytes": 73709044,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 91.137,
"eventListeners": -228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1382.6699999999619,
"styleRecalcs": 18,
"styleRecalcDurationMs": 27.595999999999997,
"layouts": 14,
"layoutDurationMs": 11.723999999999998,
"taskDurationMs": 877.419,
"heapDeltaBytes": -5473360,
"heapUsedBytes": 88013404,
"domNodes": 13751,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 29.836999999999996,
"eventListeners": 2387,
"totalBlockingTimeMs": 127,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8197.878000000002,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.199000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5111.485,
"heapDeltaBytes": 13320408,
"heapUsedBytes": 88924080,
"domNodes": -270,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 2251.8959999999997,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8190.2240000000575,
"styleRecalcs": 246,
"styleRecalcDurationMs": 39.87500000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5205.652000000001,
"heapDeltaBytes": 17387580,
"heapUsedBytes": 92466832,
"domNodes": -271,
"jsHeapTotalBytes": 647168,
"scriptDurationMs": 2323.9649999999997,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14629.947000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14034.767000000002,
"heapDeltaBytes": -34273836,
"heapUsedBytes": 176281056,
"domNodes": -6548,
"jsHeapTotalBytes": 3645440,
"scriptDurationMs": 245.23,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 14737.502999999946,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14091.794,
"heapDeltaBytes": -36271380,
"heapUsedBytes": 174363008,
"domNodes": -6548,
"jsHeapTotalBytes": -5955584,
"scriptDurationMs": 299.288,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 18089.245000000006,
"styleRecalcs": 150,
"styleRecalcDurationMs": 19.828000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17743.686999999998,
"heapDeltaBytes": -30215092,
"heapUsedBytes": 179995288,
"domNodes": -6548,
"jsHeapTotalBytes": -5955584,
"scriptDurationMs": 886.6769999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 19,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18410.45299999996,
"styleRecalcs": 160,
"styleRecalcDurationMs": 20.917999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17932.396,
"heapDeltaBytes": -25917992,
"heapUsedBytes": 190321808,
"domNodes": -6548,
"jsHeapTotalBytes": 3313664,
"scriptDurationMs": 920.373,
"eventListeners": -7469,
"totalBlockingTimeMs": 28,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5355.06399999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.409,
"layouts": 20,
"layoutDurationMs": 23.35899999999999,
"taskDurationMs": 5203.072000000001,
"heapDeltaBytes": -22751552,
"heapUsedBytes": 179992676,
"domNodes": -6548,
"jsHeapTotalBytes": 16752640,
"scriptDurationMs": 98.06599999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 195,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5318.748000000028,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.76299999999996,
"layouts": 20,
"layoutDurationMs": 22.929999999999993,
"taskDurationMs": 5213.150000000001,
"heapDeltaBytes": -29618428,
"heapUsedBytes": 177029184,
"domNodes": -6548,
"jsHeapTotalBytes": 9793536,
"scriptDurationMs": 99.443,
"eventListeners": -7473,
"totalBlockingTimeMs": 200,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7406.17199999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7189.855000000001,
"heapDeltaBytes": 7827084,
"heapUsedBytes": 175904844,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 120.10399999999998,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7388.738999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7186.046000000001,
"heapDeltaBytes": -10484088,
"heapUsedBytes": 174755412,
"domNodes": 0,
"jsHeapTotalBytes": -4456448,
"scriptDurationMs": 148.88800000000003,
"eventListeners": -13,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 97.58899999997084,
"styleRecalcs": 8,
"styleRecalcDurationMs": 13.539000000000003,
"layouts": 3,
"layoutDurationMs": 1.4120000000000001,
"taskDurationMs": 68.31400000000001,
"heapDeltaBytes": 3036244,
"heapUsedBytes": 71457108,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.088,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 90.63800000001265,
"styleRecalcs": 7,
"styleRecalcDurationMs": 11.258000000000001,
"layouts": 2,
"layoutDurationMs": 0.988,
"taskDurationMs": 56.42299999999999,
"heapDeltaBytes": 3029096,
"heapUsedBytes": 71868864,
"domNodes": 104,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 4.179999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16555 +/- ##
==========================================
+ Coverage 81.11% 82.67% +1.56%
==========================================
Files 2458 2040 -418
Lines 126457 118979 -7478
Branches 33692 30053 -3639
==========================================
- Hits 102573 98369 -4204
+ Misses 23369 20430 -2939
+ Partials 515 180 -335
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Addresses review feedback: #16555 (comment)
|
@coderabbitai review |
Rate Limit Exceeded
|
|
qax-19: Full context for agent readers
Both keys are checked into Fix: drop the two stale |
…omfy-Org#16650) ## Problem `browser_tests/fixtures/customNode/valueDrift.ts` had two `ROUNDTRIP_VALUE_ALLOWED_KEYS_LITEGRAPH`/`_VUE` entries for `ComfyUI-VideoHelperSuite` (`VHS_VAEDecodeBatched.per_batch`, `VHS_VAEEncodeBatched.per_batch`) that no longer actually drift on save/reload. This fails `allNodes.spec.ts`'s S3 exact-contracts assertion (`staleValueDriftKeys`) on every PR based on current `main`, because the assertion flags an allowed key as stale once it's no longer observed drifting. Root cause identified in `qax-19`: four disjoint PRs were failing identical `custom_nodes_e2e` shards on this same VHS baseline — [Comfy-Org#16365](Comfy-Org#16365), [Comfy-Org#16406](Comfy-Org#16406), [Comfy-Org#16462](Comfy-Org#16462), [Comfy-Org#16555](Comfy-Org#16555). ## Fix - Removed the stale `ComfyUI-VideoHelperSuite` entries from `ROUNDTRIP_VALUE_ALLOWED_KEYS_LITEGRAPH` / `ROUNDTRIP_VALUE_ALLOWED_KEYS_VUE` in `valueDrift.ts`. - Removed the matching `ROUNDTRIP_VALUE_ALLOWLIST` entry in `allNodesRoundtripTier.ts` — the two ledgers are cross-checked bidirectionally (every exact-value-drift node needs a `ROUNDTRIP_VALUE_ALLOWLIST` reason and vice versa), so leaving the allowlist entry behind would trip `ROUNDTRIP_VALUE_ALLOWLIST entry ... has no exact renderer contract`. - Confirmed no other pack references either of the two removed node/key pairs (only an unrelated `interactionProfiles/ComfyUI-VideoHelperSuite.json` fixture mentions the node names, for a different purpose). ## Verification - `pnpm exec vitest run browser_tests/fixtures/customNode/valueDrift.test.ts` — 14/14 pass. - `pnpm typecheck` (`vue-tsc --noEmit`) — clean. - `oxfmt --check` / `oxlint` on both changed files — clean. - Pre-commit hook (typecheck, typecheck:browser, lint, format, knip) — clean. - Did **not** run the live `allNodes.spec.ts` S3 Playwright tier here (needs a real browser + live custom-node pack manifests); the fix follows directly from reading `staleValueDriftKeys`'s semantics and the bidirectional ledger check in `allNodesRoundtripTier.ts`, so this should resolve the shard failures on Comfy-Org#16365/Comfy-Org#16406/Comfy-Org#16462/Comfy-Org#16555 once their CI reruns. Source: `valuedrift-1` / `qax-19`. Co-authored-by: cheap-drain <christian@ampcode.com>
…(R-96) Adds a permanent regression asserting EcsFollowerAdapter node input/output link slots converge identically whether add_node+connect ops are delivered as one combined Yjs update (single frame) or as separate singleton frames. R-96 (logs/RISK-REGISTER.md) characterized this divergence on FE PR #16462, built on top of draft PRs #16373/#16375 (clock/identity hardening + document activation seam), not yet on main. Reproducing directly against current main (real EcsFollowerAdapter + createGraphMutations + comfy-multi-player applier, no mocks): FollowerDoc.applyRemoteUpdate applies one Yjs update as one transaction regardless of how many upstream ops it bundles, so the adapter's Y.Map observers fire once per delivered frame either way and nodeActions/ changedLinks accumulate identically. Verified against plain connect, grow (new-slot) connect, and node-replace+connect combined in one frame — all converge. The defect does not reproduce on main today. Landing this test now gives R-96 a permanent tripwire: if the batch-boundary parity ever regresses (e.g. once #16373/#16375 land), this fails before it reaches production.
Addresses review feedback: #16555 (comment)
053c122 to
7a67ed3
Compare
DrJKL
left a comment
There was a problem hiding this comment.
Reviewed the current head. This is a focused regression test for node-slot parity across combined and split CRDT frames. It uses fresh Pinia state per scenario, checks both link topology and node slot state, and the applicable CI is green.
What
Adds a permanent regression test asserting
EcsFollowerAdapternodeinput/output link-slot state converges identically whether
add_node+connectops are delivered as one combined Yjs update (single frame)or as separate singleton frames.
Why (R-96)
logs/RISK-REGISTER.mdR-96 characterized a batch-boundary defect on FE PR#16462's QA-8 property suite: when
connectshares one Yjs update with nodeadds,
inputs[].link/outputs[].linkscould remain empty in the combinedcase while the link store still converged. That characterization ran on top
of draft PRs #16373/#16375 (clock/identity hardening +
GraphDocumentactivation seam), not present on
main.Reproduction result: does not reproduce on main today
Reproducing directly against current
main— realEcsFollowerAdapter,createGraphMutations, and@comfyorg/comfy-multi-player'sapplyOps, nomocks — the divergence does not occur:
FollowerDoc.applyRemoteUpdateapplies a delivered Yjs update as onetransaction regardless of how many upstream ops it bundles, so the
adapter's
Y.Mapobservers fire once per delivered frame either way andnodeActions/changedLinksaccumulate identically beforeapplyQueuedFramebuilds the mutation batch.connect,grow(new-slot)
connect, and a higher-stamped node replace +connect. Allthree converge with singleton-frame delivery.
This PR lands the regression as a tripwire rather than leaving the finding
report-only: if batch-boundary parity regresses later (e.g. once
#16373/#16375 land and change delivery/identity semantics), this test fails
before it reaches production. No production code changed — this is a
verification/policy PR, not a fix, because there is nothing to fix on main
yet.
Verification
pnpm exec vitest run src/workbench/extensions/agent/crdt/— 18 files,177 passed (includes the 6 in the touched file).
pnpm exec eslint— clean on the touched file.pnpm typecheck(vue-tsc --noEmit) — clean.pnpm exec oxfmt/pnpm exec oxlint --type-aware— clean.Trace
R-96 (SEV2,
logs/RISK-REGISTER.md), QA-8 (reports/lanes/qa8prop.md, FEPR #16462), program todo row
r87-1.