Repository navigation
test: characterize draft cache hash collision aliasing - #16378
Conversation
|
Warning Review limit reachedNext included review available in 3 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Comment |
christian-byrne
left a comment
There was a problem hiding this comment.
Self-review at head fac02cad432c3e0762323fd618541bd1eeefcf68: this is a tests-only characterization of R-78, isolated to draftCacheV2.property.test.ts. It intentionally asserts the current collision aliasing behavior for the known 684dbc71 key and does not change production cache behavior. Local verification passed: focused Vitest 9/9, focused oxfmt --check, pnpm lint:unstaged, normal pre-commit pnpm typecheck, and pre-push knip --cache.
🎭 Playwright: ✅ 1888 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.63 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.4 MB (baseline 1.4 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 115 kB (baseline 115 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.57 MB (baseline 3.57 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 555 kB (baseline 555 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.2 MB (baseline 16.2 MB) • ⚪ 0 BBundles that do not match a named category Status: 294 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-31T11:32:03.656Z",
"gitSha": "6b6dc168e90a56660d08cdc998c7c2a6c1c53087",
"branch": "christian-byrne/r78-cache-collision-test",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2068.509000000006,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.881,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.64,
"heapDeltaBytes": -1358684,
"heapUsedBytes": 62088976,
"domNodes": -279,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 11.161000000000001,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2056.1360000000377,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.452999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.5079999999999,
"heapDeltaBytes": -1072972,
"heapUsedBytes": 68610220,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.799999999999999,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2063.1380000000377,
"styleRecalcs": 81,
"styleRecalcDurationMs": 54.391000000000005,
"layouts": 14,
"layoutDurationMs": 4.899000000000001,
"taskDurationMs": 1064.092,
"heapDeltaBytes": -9010264,
"heapUsedBytes": 59928316,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 177.57099999999997,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1849.5379999999386,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.667,
"layouts": 14,
"layoutDurationMs": 4.7,
"taskDurationMs": 903.5329999999999,
"heapDeltaBytes": -8583488,
"heapUsedBytes": 61368360,
"domNodes": -284,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 160.923,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.9949999999885,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.973999999999997,
"layouts": 6,
"layoutDurationMs": 1.3660000000000003,
"taskDurationMs": 370.869,
"heapDeltaBytes": 4433752,
"heapUsedBytes": 74471668,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.802999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1732.65600000002,
"styleRecalcs": 31,
"styleRecalcDurationMs": 19.491,
"layouts": 6,
"layoutDurationMs": 0.9549999999999998,
"taskDurationMs": 376.853,
"heapDeltaBytes": 4365344,
"heapUsedBytes": 74519856,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.749000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 640.4089999999769,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.562999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.37600000000003,
"heapDeltaBytes": 17827072,
"heapUsedBytes": 87963316,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 161.08700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 700.1710000000685,
"styleRecalcs": 13,
"styleRecalcDurationMs": 10.665,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.998,
"heapDeltaBytes": 18026488,
"heapUsedBytes": 87918832,
"domNodes": 22,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 161.605,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2057.327999999984,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.021000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 616.294,
"heapDeltaBytes": 11050864,
"heapUsedBytes": 85972652,
"domNodes": -270,
"jsHeapTotalBytes": -860160,
"scriptDurationMs": 36.919999999999995,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2049.433000000022,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.044999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 605.4019999999999,
"heapDeltaBytes": 10854564,
"heapUsedBytes": 86022256,
"domNodes": -272,
"jsHeapTotalBytes": -1908736,
"scriptDurationMs": 34.93800000000001,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2346.0699999999974,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.176999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1695.6630000000002,
"heapDeltaBytes": -20286952,
"heapUsedBytes": 80587700,
"domNodes": -271,
"jsHeapTotalBytes": -1122304,
"scriptDurationMs": 826.92,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2339.8890000000847,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.421999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1667.4889999999998,
"heapDeltaBytes": 11127104,
"heapUsedBytes": 87277980,
"domNodes": -274,
"jsHeapTotalBytes": -110592,
"scriptDurationMs": 810.2850000000001,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3464.0830000000165,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.709000000000001,
"layouts": 60,
"layoutDurationMs": 12.142999999999997,
"taskDurationMs": 1716.0529999999999,
"heapDeltaBytes": 10188108,
"heapUsedBytes": 76538752,
"domNodes": -278,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 775.222,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3647.3290000000134,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.213,
"layouts": 60,
"layoutDurationMs": 12.466000000000001,
"taskDurationMs": 1768.519,
"heapDeltaBytes": 10001528,
"heapUsedBytes": 75785264,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 801.704,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3186.567000000025,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.598,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1982.167,
"heapDeltaBytes": 4689252,
"heapUsedBytes": 83793720,
"domNodes": -281,
"jsHeapTotalBytes": -704512,
"scriptDurationMs": 969.475,
"eventListeners": -1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3151.9120000000385,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.873000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1951.494,
"heapDeltaBytes": 22967092,
"heapUsedBytes": 89916540,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 967.916,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.889000000002,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.321,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 591.249,
"heapDeltaBytes": -14759180,
"heapUsedBytes": 87445076,
"domNodes": -273,
"jsHeapTotalBytes": -1609728,
"scriptDurationMs": 31.972,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2006.6920000000437,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.2130000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.177,
"heapDeltaBytes": 21805572,
"heapUsedBytes": 87133196,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.017000000000003,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.161999999973,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.689,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.87399999999997,
"heapDeltaBytes": 13675572,
"heapUsedBytes": 79111468,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 140.421,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 576.020000000085,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.612999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.41499999999996,
"heapDeltaBytes": 13946768,
"heapUsedBytes": 86096992,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 142.3,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.5549999999876,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.981999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.602,
"heapDeltaBytes": -11558724,
"heapUsedBytes": 60453928,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.645,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2054.1690000000017,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.116000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.32,
"heapDeltaBytes": -7774020,
"heapUsedBytes": 64522240,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.565,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1738.8819999999896,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.492999999999995,
"layouts": 18,
"layoutDurationMs": 5.733999999999999,
"taskDurationMs": 864.594,
"heapDeltaBytes": 830112,
"heapUsedBytes": 72934860,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 115.43699999999998,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.0479999999252,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.809999999999995,
"layouts": 18,
"layoutDurationMs": 5.662999999999999,
"taskDurationMs": 891.5150000000001,
"heapDeltaBytes": -12665788,
"heapUsedBytes": 59529484,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 121.809,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1419.2699999999832,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.48999999999999,
"layouts": 15,
"layoutDurationMs": 16.269,
"taskDurationMs": 956.51,
"heapDeltaBytes": -9235184,
"heapUsedBytes": 86066004,
"domNodes": 13671,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 31.005000000000006,
"eventListeners": 2383,
"totalBlockingTimeMs": 149,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8820.996999999978,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.812999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6110.007,
"heapDeltaBytes": -21367448,
"heapUsedBytes": 78809284,
"domNodes": -267,
"jsHeapTotalBytes": -630784,
"scriptDurationMs": 2814.488,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8575.338999999985,
"styleRecalcs": 245,
"styleRecalcDurationMs": 33.857,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5846.969000000001,
"heapDeltaBytes": 12802764,
"heapUsedBytes": 88530696,
"domNodes": -275,
"jsHeapTotalBytes": -1159168,
"scriptDurationMs": 2633.186,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17738.97500000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16965.751,
"heapDeltaBytes": -33556240,
"heapUsedBytes": 175778868,
"domNodes": -6548,
"jsHeapTotalBytes": -3309568,
"scriptDurationMs": 301.455,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17802.987999999914,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17041.325,
"heapDeltaBytes": -41337224,
"heapUsedBytes": 175353292,
"domNodes": -6548,
"jsHeapTotalBytes": 2301952,
"scriptDurationMs": 297.385,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21770.644000000004,
"styleRecalcs": 169,
"styleRecalcDurationMs": 19.177,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21277.439000000002,
"heapDeltaBytes": -21158696,
"heapUsedBytes": 191929796,
"domNodes": -6548,
"jsHeapTotalBytes": -7159808,
"scriptDurationMs": 937.1260000000001,
"eventListeners": -7467,
"totalBlockingTimeMs": 149,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21401.21499999998,
"styleRecalcs": 164,
"styleRecalcDurationMs": 18.726999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21022.067,
"heapDeltaBytes": -25311884,
"heapUsedBytes": 176229992,
"domNodes": -6548,
"jsHeapTotalBytes": 249856,
"scriptDurationMs": 932.8499999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 121,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6274.651000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.86999999999999,
"layouts": 20,
"layoutDurationMs": 23.087999999999997,
"taskDurationMs": 6165.045999999999,
"heapDeltaBytes": -27582816,
"heapUsedBytes": 176755716,
"domNodes": -6548,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 119.844,
"eventListeners": -7469,
"totalBlockingTimeMs": 420,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6450.671000000057,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.94999999999996,
"layouts": 20,
"layoutDurationMs": 24.445000000000007,
"taskDurationMs": 6315.4,
"heapDeltaBytes": -17498876,
"heapUsedBytes": 191771368,
"domNodes": -6548,
"jsHeapTotalBytes": 14491648,
"scriptDurationMs": 121.01200000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 452,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 107.57599999999456,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.53,
"layouts": 3,
"layoutDurationMs": 1.285,
"taskDurationMs": 82.07999999999998,
"heapDeltaBytes": 3187912,
"heapUsedBytes": 71457420,
"domNodes": 130,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.265,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 128.00900000002002,
"styleRecalcs": 7,
"styleRecalcDurationMs": 19.428,
"layouts": 2,
"layoutDurationMs": 1.468,
"taskDurationMs": 98.104,
"heapDeltaBytes": 3118456,
"heapUsedBytes": 66492644,
"domNodes": 127,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.386999999999999,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16378 +/- ##
==========================================
+ Coverage 81.25% 83.25% +2.00%
==========================================
Files 2402 2022 -380
Lines 123442 116938 -6504
Branches 34492 33011 -1481
==========================================
- Hits 100300 97357 -2943
+ Misses 22543 19229 -3314
+ Partials 599 352 -247
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
|
CodeJuggernaut
left a comment
There was a problem hiding this comment.
Approving - the collision guard change is correct and scoped; the test-placement note is non-blocking.
|
Follow-up: #16548 addresses the test-placement note from the approval review — moves the R-78 characterization into its own |
## Summary Adds a permanent characterization test for R-78 draft-cache aliasing. The test documents the current behavior for the known FNV-1a 32-bit collision pair `workflows/ewip.json` / `workflows/4hbab.json`: both map to draft key `684dbc71`, so the second `upsertEntry` overwrites the first index entry and `getEntryByPath` for the first path returns the second draft metadata. This is intentionally a current-risk characterization, not a behavior fix. It does not change the hash function, add collision detection, or migrate draft keys. ## Context Trace: R-78 in the in-app-agent risk register, OPP-25 determinism audit, FE issue #16371, Linear FE-1952. Stale-main policy: this branch is based on current FE `main` at `f954e479a37b168a9596aa05a1ce1dec1e9a93b4`. The change is isolated to the workflow draft cache test surface and does not depend on the open CRDT integration heads. ## Verification - `pnpm test:unit src/platform/workflow/persistence/base/draftCacheV2.property.test.ts` -> 1 file passed, 9 tests passed - `pnpm exec oxfmt --check src/platform/workflow/persistence/base/draftCacheV2.property.test.ts` -> passed - `pnpm lint:unstaged` -> passed - normal pre-commit hook -> lint-staged and `pnpm typecheck` passed - normal pre-push hook -> `knip --cache` passed Co-authored-by: Christian Byrne <christian@comfy.org>
Follow-up to #16378 — CodeJuggernaut approved with a non-blocking test-placement note: the R-78 collision-aliasing characterization test is a fixed-input regression, not a property, so it belongs in its own file rather than draftCacheV2.property.test.ts. Moves it to draftCacheV2.collision.test.ts, matching the alternative naming already given in the originating todo row (r78-cache-1).
Follow-up to #16378 — CodeJuggernaut approved with a non-blocking test-placement note: the R-78 collision-aliasing characterization test is a fixed-input regression, not a property, so it belongs in its own file rather than draftCacheV2.property.test.ts. Moves it to draftCacheV2.collision.test.ts, matching the alternative naming already given in the originating todo row (r78-cache-1).
…16548) ## Summary Follow-up to #16378. Addresses the non-blocking test-placement note from CodeJuggernaut's approval: the R-78 draft-cache collision characterization ([comment](#16378 (review))) is a fixed-input regression, not a property-based test, so it did not belong in `draftCacheV2.property.test.ts`. Moves it into its own `draftCacheV2.collision.test.ts`, matching the alternative naming already given in the originating todo row for this work (`r78-cache-1`: "...or a new `draftCacheV2.collision.test.ts` colocated alongside"). No behavior change — same assertions, same known colliding pair (`workflows/ewip.json` / `workflows/4hbab.json` -> `684dbc71`). ## Verification - `pnpm test:unit src/platform/workflow/persistence/base/draftCacheV2.property.test.ts src/platform/workflow/persistence/base/draftCacheV2.collision.test.ts` -> 2 files, 9 tests passed - `pnpm exec oxfmt --check` -> passed - `pnpm typecheck` -> passed - `pnpm exec eslint` -> passed <!-- authored-by:agent addr-drain -->
Summary
Adds a permanent characterization test for R-78 draft-cache aliasing. The test documents the current behavior for the known FNV-1a 32-bit collision pair
workflows/ewip.json/workflows/4hbab.json: both map to draft key684dbc71, so the secondupsertEntryoverwrites the first index entry andgetEntryByPathfor the first path returns the second draft metadata.This is intentionally a current-risk characterization, not a behavior fix. It does not change the hash function, add collision detection, or migrate draft keys.
Context
Trace: R-78 in the in-app-agent risk register, OPP-25 determinism audit, FE issue #16371, Linear FE-1952.
Stale-main policy: this branch is based on current FE
mainatf954e479a37b168a9596aa05a1ce1dec1e9a93b4. The change is isolated to the workflow draft cache test surface and does not depend on the open CRDT integration heads.Verification
pnpm test:unit src/platform/workflow/persistence/base/draftCacheV2.property.test.ts-> 1 file passed, 9 tests passedpnpm exec oxfmt --check src/platform/workflow/persistence/base/draftCacheV2.property.test.ts-> passedpnpm lint:unstaged-> passedpnpm typecheckpassedknip --cachepassed