Repository navigation
test(assets): verify bulk-insert asset values - #16391
christian-byrne wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe bulk asset insertion browser test now verifies the output filenames assigned to the two inserted ChangesAsset output validation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This adds coverage confirming bulk-inserted output assets populate the expected loader filenames. It does not change production behavior and is ready to merge. Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (5 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The available metadata shows a change under Full details: Adr Compliance For Entity/Litegraph ChangesExplanation The PR is related to graph entities because it changes the Assets sidebar test for inserted Full details: Description checkExplanation The description clearly explains the test change, expected values, scope, production impact, and validation results. It does not include the template's explicit Changes or Review Focus headings, but the required information is substantially present and screenshots are not applicable.
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 1916 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.68 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 558 kB (baseline 558 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 35 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 297 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-03T20:55:00.459Z",
"gitSha": "ca4092eba4271610acfa7800e80fa80398faf835",
"branch": "test/assets-bulk-insert-values",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2039.1750000000002,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.038999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.66300000000007,
"heapDeltaBytes": -10124456,
"heapUsedBytes": 60240032,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.403,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2049.357999999984,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.555,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.3070000000001,
"heapDeltaBytes": -7738188,
"heapUsedBytes": 62690884,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.652000000000003,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1993.2960000000435,
"styleRecalcs": 82,
"styleRecalcDurationMs": 46.208,
"layouts": 14,
"layoutDurationMs": 4.883,
"taskDurationMs": 979.3139999999999,
"heapDeltaBytes": -4548404,
"heapUsedBytes": 66311376,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 170.345,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1814.5869999999604,
"styleRecalcs": 75,
"styleRecalcDurationMs": 34.006,
"layouts": 14,
"layoutDurationMs": 4.156,
"taskDurationMs": 821.0959999999999,
"heapDeltaBytes": -6632400,
"heapUsedBytes": 63824188,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 148.361,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.0310000000445,
"styleRecalcs": 31,
"styleRecalcDurationMs": 21.619000000000003,
"layouts": 6,
"layoutDurationMs": 1.1340000000000001,
"taskDurationMs": 362.19500000000005,
"heapDeltaBytes": 4802268,
"heapUsedBytes": 75544000,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.572999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.9910000000027,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.267999999999997,
"layouts": 6,
"layoutDurationMs": 1.239,
"taskDurationMs": 349.197,
"heapDeltaBytes": 5101880,
"heapUsedBytes": 75919768,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.905000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 660.0559999999973,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.942999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.77200000000005,
"heapDeltaBytes": 18835012,
"heapUsedBytes": 87995172,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 161.554,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 682.0950000000039,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.5600000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.604,
"heapDeltaBytes": -7465604,
"heapUsedBytes": 62989828,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 159.48900000000003,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2048.366000000044,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.89,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 605.398,
"heapDeltaBytes": -14918164,
"heapUsedBytes": 86723244,
"domNodes": -267,
"jsHeapTotalBytes": -327680,
"scriptDurationMs": 38.286,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2039.527000000021,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.118,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.494,
"heapDeltaBytes": -13684828,
"heapUsedBytes": 87488392,
"domNodes": -268,
"jsHeapTotalBytes": -851968,
"scriptDurationMs": 33.51800000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2241.2100000000237,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.463,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1625.6820000000002,
"heapDeltaBytes": -17754864,
"heapUsedBytes": 84736296,
"domNodes": -276,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 790.211,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2260.7360000000654,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.152999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1655.8990000000003,
"heapDeltaBytes": 8275288,
"heapUsedBytes": 84712076,
"domNodes": -275,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 807.524,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3563.883999999973,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.43,
"layouts": 60,
"layoutDurationMs": 12.306000000000001,
"taskDurationMs": 1694.6830000000002,
"heapDeltaBytes": 8046288,
"heapUsedBytes": 75764380,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 767.537,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3451.5440000000126,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.434000000000001,
"layouts": 60,
"layoutDurationMs": 11.840999999999998,
"taskDurationMs": 1603.548,
"heapDeltaBytes": 8176232,
"heapUsedBytes": 75743368,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 746.504,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3125.6060000000048,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1948.057,
"heapDeltaBytes": 25424140,
"heapUsedBytes": 92749492,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1002.3499999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3086.4879999999175,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.875999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1909.201,
"heapDeltaBytes": 23081260,
"heapUsedBytes": 91120256,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 990.097,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 1994.685000000004,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.9130000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.0970000000001,
"heapDeltaBytes": 22244820,
"heapUsedBytes": 88135820,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.219,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2001.372999999944,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.705999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.7139999999999,
"heapDeltaBytes": 21934072,
"heapUsedBytes": 87962832,
"domNodes": -269,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.759999999999994,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 586.783999999966,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.014000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.471,
"heapDeltaBytes": 14347352,
"heapUsedBytes": 86192980,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 143.976,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.4590000000189,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.931,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.166,
"heapDeltaBytes": 14903460,
"heapUsedBytes": 87662420,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 139.42499999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.4309999999737,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.842000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.60099999999994,
"heapDeltaBytes": 2035172,
"heapUsedBytes": 74972148,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.084,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1997.5999999999203,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.6579999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.302,
"heapDeltaBytes": 8067784,
"heapUsedBytes": 80984672,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.863000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1740.5519999999797,
"styleRecalcs": 78,
"styleRecalcDurationMs": 35.295,
"layouts": 18,
"layoutDurationMs": 4.729000000000001,
"taskDurationMs": 793.389,
"heapDeltaBytes": 10706892,
"heapUsedBytes": 83631988,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 101.13600000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1790.1200000000017,
"styleRecalcs": 79,
"styleRecalcDurationMs": 37.285,
"layouts": 18,
"layoutDurationMs": 5.411,
"taskDurationMs": 829.0079999999999,
"heapDeltaBytes": -9764872,
"heapUsedBytes": 62829300,
"domNodes": -295,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 117.765,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1385.528000000022,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.626,
"layouts": 14,
"layoutDurationMs": 15.402999999999997,
"taskDurationMs": 917.2869999999997,
"heapDeltaBytes": -3605432,
"heapUsedBytes": 93462852,
"domNodes": 13751,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 30.850999999999996,
"eventListeners": 2385,
"totalBlockingTimeMs": 133,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8423.636999999928,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.989,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5832.864,
"heapDeltaBytes": 13755376,
"heapUsedBytes": 89013196,
"domNodes": -270,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 2691.618,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8396.561999999903,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.512,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5741.133,
"heapDeltaBytes": 23987776,
"heapUsedBytes": 89166332,
"domNodes": -268,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 2674.502,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17080.466999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16618.137,
"heapDeltaBytes": -35293216,
"heapUsedBytes": 175261304,
"domNodes": -6552,
"jsHeapTotalBytes": -4907008,
"scriptDurationMs": 263.185,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16859.290999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16200.979,
"heapDeltaBytes": -48556792,
"heapUsedBytes": 176331744,
"domNodes": -6548,
"jsHeapTotalBytes": -4706304,
"scriptDurationMs": 263.659,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21225.803999999924,
"styleRecalcs": 169,
"styleRecalcDurationMs": 18.297000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20851.308,
"heapDeltaBytes": -22036852,
"heapUsedBytes": 180499264,
"domNodes": -6548,
"jsHeapTotalBytes": -811008,
"scriptDurationMs": 934.784,
"eventListeners": -7469,
"totalBlockingTimeMs": 87,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20537.99200000003,
"styleRecalcs": 170,
"styleRecalcDurationMs": 17.11499999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20189.678,
"heapDeltaBytes": -35771356,
"heapUsedBytes": 166869056,
"domNodes": -6549,
"jsHeapTotalBytes": 1851392,
"scriptDurationMs": 908.562,
"eventListeners": -7469,
"totalBlockingTimeMs": 51,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6160.079999999994,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.36500000000002,
"layouts": 20,
"layoutDurationMs": 23.204,
"taskDurationMs": 6022.737,
"heapDeltaBytes": -23385420,
"heapUsedBytes": 179391352,
"domNodes": -6548,
"jsHeapTotalBytes": 14917632,
"scriptDurationMs": 108.635,
"eventListeners": -7471,
"totalBlockingTimeMs": 425,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5817.455999999993,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.68399999999998,
"layouts": 20,
"layoutDurationMs": 22.493999999999986,
"taskDurationMs": 5683.889000000001,
"heapDeltaBytes": -24606724,
"heapUsedBytes": 179584068,
"domNodes": -6548,
"jsHeapTotalBytes": 16719872,
"scriptDurationMs": 100.14799999999998,
"eventListeners": -7473,
"totalBlockingTimeMs": 382,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8545.795999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8317.6,
"heapDeltaBytes": 14290112,
"heapUsedBytes": 175616768,
"domNodes": 0,
"jsHeapTotalBytes": -3145728,
"scriptDurationMs": 151.30300000000008,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8211.571000000049,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7721.836999999999,
"heapDeltaBytes": 10391108,
"heapUsedBytes": 175962260,
"domNodes": 0,
"jsHeapTotalBytes": -11796480,
"scriptDurationMs": 142.351,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 451.184000000012,
"styleRecalcs": 15,
"styleRecalcDurationMs": 21.098000000000006,
"layouts": 3,
"layoutDurationMs": 0.7520000000000001,
"taskDurationMs": 100.39199999999998,
"heapDeltaBytes": 4802504,
"heapUsedBytes": 72586116,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.216999999999999,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 104.41699999989851,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.037,
"layouts": 2,
"layoutDurationMs": 0.865,
"taskDurationMs": 68.76599999999999,
"heapDeltaBytes": 3017056,
"heapUsedBytes": 71596596,
"domNodes": 106,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.442999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌐 Website E2ETip All tests passed.
🎨 Storybook: ✅ Built — View Storybook🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-16391.vercel.app This commit: https://website-frontend-fei3rav94-comfyui.vercel.app Last updated: 2026-09-01T06:15:30Z for |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16391 +/- ##
==========================================
+ Coverage 81.15% 82.72% +1.56%
==========================================
Files 2460 2042 -418
Lines 126623 119145 -7478
Branches 33739 30433 -3306
==========================================
- Hits 102766 98564 -4202
+ Misses 23341 20400 -2941
+ Partials 516 181 -335
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
240bff4 to
c58c3e6
Compare
|
@coderabbitai review |
|
bab7e78 to
c6c6cc0
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Verdict: mechanism works — I built both dists locally and the checks pass. But the PR body drastically understates scope.
- Empirically verified: localhost AND cloud builds at head fold the gate exactly as the check assumes;
pnpm test:assets-flag-artifactgreen for both, 12/12 unit tests green - Body says "No production behavior changes" but the diff ships a new
build-manifest.jsonin every production dist and adds CI steps — update body or split - Two fragility notes + one nit inline
Full context for agent readers
What I verified (head c6c6cc0, worktree checkout, Node 25.9.0)
| # | Check | Result |
|---|---|---|
| V1 | Unit tests scripts/checkAssetsFlagArtifact.test.ts |
12/12 passed |
| V2 | Real localhost build (vite build, unminified) → gate in dist |
Folds to function isAssetAPIEnabled() {\n return false;\n} — rolldown constant-folds the define-substituted cross-module isCloud and drops the dead settings branch. EXPECTED_DISTRIBUTION=localhost EXPECTED_FRONTEND_COMMIT=<head> pnpm test:assets-flag-artifact → exit 0 |
| V3 | Real cloud build (DISTRIBUTION=cloud vite build) → gate in dist |
Folds to the settings-only return; useSettingStore identifier survives bundling unrenamed. Check → exit 0 |
| V4 | build-manifest.json contents |
{"commit":"c6c6cc0…","distribution":"localhost"} — matches provenance assertions |
| V5 | CI step ordering | frontend-dist artifact upload happens BEFORE the desktop rebuild overwrites dist/, so sharded Playwright jobs still get the localhost build; cloud composite action builds into dist/ and uploads its own artifact before the cloud verify step. Ordering correct |
| V6 | Bulk-insert assertion fixture APIs | getNodeRefsByType (NodeOperationsHelper.ts:116) and getWidget(i).getValue() (litegraphUtils.ts:392) exist |
| V7 | Job-id UUID change | Also deduplicates the previously hardcoded 'previewable-count-job' string in mockJobDetail to previewableCountJob.id — good single-source fix |
Findings
| # | Severity | Finding |
|---|---|---|
| F1 | major (process) | PR title/body describe only the bulk-insert widget assertion ("No production behavior changes"), but the diff also ships: a vite emit-build-manifest plugin (new file in every production dist), 3 new CI verify steps + a full desktop build in the setup job, a new 107-line script + 99-line unit test, two mobile smoke tests, and the job-id UUID change. Reviewers and future archaeologists will miss all of that from the body. Update the body (or split the artifact-verification system into its own PR) |
| F2 | fragility (documented risk, currently green) | The gate regex requires an unminified named function declaration. SHOULD_MINIFY is only true when ENABLE_MINIFY=true (never set in CI today), and the fold behavior + useSettingStore name survival are rolldown implementation details. If a minified dist is ever pointed at this check, it hard-fails with "found 0". Worth a comment in the script stating the unminified assumption |
| F3 | minor | checkAssetsFlagArtifact silently skips provenance when EXPECTED_FRONTEND_COMMIT is unset (only EXPECTED_DISTRIBUTION is required). A local run against a stale dist passes the gate check without noticing the wrong commit. Consider a warning when skipping |
| F4 | nit | mobileListSmokeTest.describe('FE-130 assets sidebar route mocks', …) duplicates the existing test.describe title in the same file — report grouping becomes ambiguous. A distinct title (e.g. "FE-130 assets sidebar mobile smoke") keeps traces unambiguous |
| F5 | positive | The empirical design is sound: provenance (commit + distribution) via emitted manifest, fixture-leak scan, and distribution-specific gate shape — checked against the actual shipped artifact rather than source. That closes the gap where source looks right but the build regresses |
Also: |
|
@coderabbitai review |
|
Addresses review feedback by narrowing this PR to its unique bulk-insert assertion; the artifact gate and mobile smoke coverage now have separate owners on main. #16391 (comment) #16391 (comment) #16391 (comment) #16391 (comment)
c6c6cc0 to
cda187f
Compare
|
Narrowed to the seven unique bulk-insert assertions. Duplicate mobile and artifact work removed. Rebased onto current main. Full context for agent readers
|
|
@coderabbitai review |
|
|
Deployment failed for project comfy-home-v1 with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
|
Merged current Full context for agent readersThe branch was 130 commits behind Exact-head results: |
Summary
Bulk insertion now proves both nodes reference the selected outputs. No production behavior changes. Extends the existing route-mocked Assets sidebar bulk-insertion journey. After selecting two generated outputs and choosing Insert all assets as nodes, the test now inspects the real graph nodes and requires their loader widgets to contain exactly
alpha.png [output]andbeta.png [output].Verification
Validation:
GET /api/users; CI is the execution gate