Repository navigation
test(assets): cover mobile sidebar smoke - #16366
christian-byrne wants to merge 5 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughAdded assets sidebar locators and a touch-control validation flow. Added mobile fixtures and smoke tests for asset listing, filtering, grouping, view switching, selection, and deletion confirmation on standard mobile and iOS configurations. ChangesAssets sidebar mobile coverage
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to This PR only adds mobile end-to-end test coverage for the Assets sidebar (list, filter, group, selection, and delete flows) and does not modify any production code. Reported test-authoring issues from earlier review rounds appear to have been addressed, and CI checks for the relevant mobile and aggregate E2E projects have passed. There is no material risk to production behavior from merging this change. Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The changed files are available and both are under Resolution Provide the PR title and commit subjects, then re-run this check. The available metadata shows that the PR adds a Playwright regression flow under ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 1943 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 9.92 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 622 kB (baseline 622 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 26.2 kB (baseline 26.2 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 118 kB (baseline 118 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.69 MB (baseline 3.69 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 558 kB (baseline 558 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.1 MB (baseline 17.1 MB) • ⚪ 0 BBundles that do not match a named category Status: 296 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-10T22:49:25.437Z",
"gitSha": "328d0b31547e4446e5d17c8b6c657f93dda471c7",
"branch": "test/assets-mobile-smoke",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.1349999999916,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.656999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.227,
"heapDeltaBytes": 14775852,
"heapUsedBytes": 76263696,
"domNodes": -267,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 8.49,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1997.289999999964,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.799999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.803,
"heapDeltaBytes": 6492032,
"heapUsedBytes": 68561524,
"domNodes": -264,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 9.450999999999997,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1825.0610000000052,
"styleRecalcs": 75,
"styleRecalcDurationMs": 29.396000000000004,
"layouts": 14,
"layoutDurationMs": 4.645,
"taskDurationMs": 745.946,
"heapDeltaBytes": 6459332,
"heapUsedBytes": 68666192,
"domNodes": -261,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 169.70499999999998,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1781.6339999999968,
"styleRecalcs": 74,
"styleRecalcDurationMs": 26.458000000000002,
"layouts": 14,
"layoutDurationMs": 3.6339999999999995,
"taskDurationMs": 819.065,
"heapDeltaBytes": 1191092,
"heapUsedBytes": 63319676,
"domNodes": -260,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 163.11999999999998,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.8330000000033,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.861,
"layouts": 6,
"layoutDurationMs": 1.014,
"taskDurationMs": 404.84400000000005,
"heapDeltaBytes": 2070488,
"heapUsedBytes": 63279840,
"domNodes": 75,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 14.782,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.271000000007,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.270000000000003,
"layouts": 6,
"layoutDurationMs": 1.217,
"taskDurationMs": 357.919,
"heapDeltaBytes": 2067800,
"heapUsedBytes": 64086152,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.868,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 644.1400000000499,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.899000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.742,
"heapDeltaBytes": 18121592,
"heapUsedBytes": 80278672,
"domNodes": 16,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 164.07,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 665.8899999999903,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.686999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.0830000000001,
"heapDeltaBytes": 18127280,
"heapUsedBytes": 79156204,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 164.96,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2045.8550000000173,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.291,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 617.067,
"heapDeltaBytes": 3116592,
"heapUsedBytes": 82803172,
"domNodes": -249,
"jsHeapTotalBytes": -1581056,
"scriptDurationMs": 35.044999999999995,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2032.3449999999639,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.281000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 604.0799999999999,
"heapDeltaBytes": 3721648,
"heapUsedBytes": 82978480,
"domNodes": -248,
"jsHeapTotalBytes": -1056768,
"scriptDurationMs": 32.332999999999984,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2209.811000000002,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.347999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1608.336,
"heapDeltaBytes": 15177184,
"heapUsedBytes": 79539024,
"domNodes": -252,
"jsHeapTotalBytes": 2060288,
"scriptDurationMs": 818.7919999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2248.344999999972,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.957999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1600.248,
"heapDeltaBytes": 14885252,
"heapUsedBytes": 78916724,
"domNodes": -245,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 832.797,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3595.4530000000204,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.097000000000003,
"layouts": 60,
"layoutDurationMs": 12.041,
"taskDurationMs": 1720.7859999999998,
"heapDeltaBytes": 8401428,
"heapUsedBytes": 74692280,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 789.0469999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3571.303000000057,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.685999999999998,
"layouts": 60,
"layoutDurationMs": 11.424,
"taskDurationMs": 1671.2530000000002,
"heapDeltaBytes": 7695312,
"heapUsedBytes": 73800236,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 781.015,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3158.188999999993,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.821999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1993.411,
"heapDeltaBytes": -10425228,
"heapUsedBytes": 80251112,
"domNodes": -261,
"jsHeapTotalBytes": 2019328,
"scriptDurationMs": 997.3149999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3189.5719999999983,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.239000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1967.8570000000002,
"heapDeltaBytes": -2538112,
"heapUsedBytes": 88024744,
"domNodes": -263,
"jsHeapTotalBytes": -77824,
"scriptDurationMs": 979.311,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.380000000022,
"styleRecalcs": 5,
"styleRecalcDurationMs": 8.198,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 647.651,
"heapDeltaBytes": -3544252,
"heapUsedBytes": 83422620,
"domNodes": -252,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 39.318000000000005,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2021.2760000000571,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.3649999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.2649999999999,
"heapDeltaBytes": 19740880,
"heapUsedBytes": 83613228,
"domNodes": -253,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.625,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 597.5050000000124,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.449,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.192,
"heapDeltaBytes": 13876124,
"heapUsedBytes": 77023840,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 147.678,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 558.7249999999813,
"styleRecalcs": 49,
"styleRecalcDurationMs": 12.456999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 357.45000000000005,
"heapDeltaBytes": 13619572,
"heapUsedBytes": 76887648,
"domNodes": 24,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 140.88400000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.3979999999765,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.306999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.234,
"heapDeltaBytes": -315540,
"heapUsedBytes": 62666144,
"domNodes": -277,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.127,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.0589999999365,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.863000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.704,
"heapDeltaBytes": 7879728,
"heapUsedBytes": 71167480,
"domNodes": -275,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.550000000000001,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1757.4200000000246,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.621,
"layouts": 18,
"layoutDurationMs": 5.58,
"taskDurationMs": 837.7809999999998,
"heapDeltaBytes": -1332196,
"heapUsedBytes": 62195236,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 112.687,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.48200000008,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.153999999999996,
"layouts": 18,
"layoutDurationMs": 4.978,
"taskDurationMs": 788.926,
"heapDeltaBytes": 12857880,
"heapUsedBytes": 75962064,
"domNodes": -277,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 111.97200000000001,
"eventListeners": -202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.459999999986,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.647999999999993,
"layouts": 5,
"layoutDurationMs": 13.323000000000002,
"taskDurationMs": 898.5580000000002,
"heapDeltaBytes": 19735356,
"heapUsedBytes": 100353788,
"domNodes": 13587,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 31.749999999999993,
"eventListeners": 2387,
"totalBlockingTimeMs": 148,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8474.724999999979,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.577,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5879.703,
"heapDeltaBytes": -12722008,
"heapUsedBytes": 66287964,
"domNodes": -246,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 2766.869,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8457.288999999946,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.666000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5895.01,
"heapDeltaBytes": -12854776,
"heapUsedBytes": 66582320,
"domNodes": -248,
"jsHeapTotalBytes": 2613248,
"scriptDurationMs": 2803.3460000000005,
"eventListeners": -136,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17167.33800000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16710.351,
"heapDeltaBytes": -29034508,
"heapUsedBytes": 166156216,
"domNodes": -6542,
"jsHeapTotalBytes": 1683456,
"scriptDurationMs": 303.094,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16787.095000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16319.187,
"heapDeltaBytes": -21129556,
"heapUsedBytes": 194237384,
"domNodes": -6542,
"jsHeapTotalBytes": 3162112,
"scriptDurationMs": 273.48699999999997,
"eventListeners": -7478,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20822.905999999988,
"styleRecalcs": 155,
"styleRecalcDurationMs": 18.700999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20591.822,
"heapDeltaBytes": -19879084,
"heapUsedBytes": 188291816,
"domNodes": -6542,
"jsHeapTotalBytes": -4038656,
"scriptDurationMs": 992.665,
"eventListeners": -7474,
"totalBlockingTimeMs": 40,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20838.233999999942,
"styleRecalcs": 163,
"styleRecalcDurationMs": 16.878999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20530.006,
"heapDeltaBytes": -32086836,
"heapUsedBytes": 165974620,
"domNodes": -6542,
"jsHeapTotalBytes": -1011712,
"scriptDurationMs": 966.683,
"eventListeners": -7472,
"totalBlockingTimeMs": 34,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4594.925999999987,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.09400000000002,
"layouts": 20,
"layoutDurationMs": 22.09699999999999,
"taskDurationMs": 4494.146,
"heapDeltaBytes": -17635920,
"heapUsedBytes": 183544512,
"domNodes": -6542,
"jsHeapTotalBytes": 22474752,
"scriptDurationMs": 92.987,
"eventListeners": -7476,
"totalBlockingTimeMs": 151,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6063.97000000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.78699999999999,
"layouts": 20,
"layoutDurationMs": 22.579999999999988,
"taskDurationMs": 5979.572999999999,
"heapDeltaBytes": -8300556,
"heapUsedBytes": 193686792,
"domNodes": -6542,
"jsHeapTotalBytes": 12935168,
"scriptDurationMs": 110.31700000000001,
"eventListeners": -7476,
"totalBlockingTimeMs": 298,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8461.355000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8199.897,
"heapDeltaBytes": 1545576,
"heapUsedBytes": 179453820,
"domNodes": 0,
"jsHeapTotalBytes": -2883584,
"scriptDurationMs": 133.87899999999996,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8481.387999999924,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8307.164999999999,
"heapDeltaBytes": -9044564,
"heapUsedBytes": 161328844,
"domNodes": 0,
"jsHeapTotalBytes": -12845056,
"scriptDurationMs": 134.71699999999998,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 476.9979999999805,
"styleRecalcs": 19,
"styleRecalcDurationMs": 26.707,
"layouts": 5,
"layoutDurationMs": 2.337,
"taskDurationMs": 140.617,
"heapDeltaBytes": 5160528,
"heapUsedBytes": 66901332,
"domNodes": 151,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 16.608,
"eventListeners": 83,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 108.77700000003188,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.588000000000001,
"layouts": 3,
"layoutDurationMs": 1.507,
"taskDurationMs": 81.682,
"heapDeltaBytes": 2995680,
"heapUsedBytes": 64936260,
"domNodes": 126,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.489000000000002,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16366 +/- ##
==========================================
+ Coverage 82.09% 83.38% +1.29%
==========================================
Files 2570 2090 -480
Lines 130526 121413 -9113
Branches 35656 33381 -2275
==========================================
- Hits 107158 101246 -5912
+ Misses 22781 19988 -2793
+ Partials 587 179 -408
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@coderabbitai review |
|
bd9461c to
08fea6e
Compare
|
Retargeted to
Full context for agent readersThe prior seven-commit stack was semantically transplanted onto current Verification: oxfmt, oxlint, ESLint, frontend typecheck, browser typecheck, knip, and both targeted Playwright projects passed. The first local Playwright attempt could not reach the already-running ComfyUI backend; after the endpoint was confirmed healthy, both tests passed without code changes. GitHub now reports base Next stage: let CI finish, then run the required high-tier line-level external review. Glossary: CI = continuous integration; semantic transplant = replaying only the intended change onto the canonical base rather than carrying the old stack's unrelated ancestry. |
|
|
Full context for agent readersPer-check diagnosis:
Fix commits:
Verification:
|
|
@coderabbitai review |
|
|
DrJKL
left a comment
There was a problem hiding this comment.
Requesting changes for two browser-test convention violations. Typecheck, browser typecheck, scoped lint/format, and Playwright --list pass; exact-head CI is green. The existing report that #16391 duplicates this diff also needs consolidation, but I am not repeating it inline.
| }) | ||
| } | ||
|
|
||
| const mobileCloudAssets = [ |
There was a problem hiding this comment.
This raw /api/assets response is inferred ad hoc. browser_tests/README.md requires endpoint mocks to use the authoritative generated type or schema so contract drift fails typecheck. Please annotate the response data, or define a fixture with satisfies, using the generated assets response type.
There was a problem hiding this comment.
Fixed in d27370e (now 9bea836 after rebase).
The mock is now annotated against the authoritative source: AssetResponse / AssetItem from src/platform/assets/schemas/assetSchema.ts, which derives from the generated zAsset / zListAssetsResponse in @comfyorg/ingest-types. The response object is a single AssetResponse literal and each element is built through an explicit (name, index): AssetItem => return annotation, so the object literals stay fresh and excess-property checking applies.
Verified it actually rejects drift rather than just compiling. Three deliberate mis-shapes, each against pnpm typecheck:browser:
- field renamed (
name->filename):
error TS2322: ... Property 'name' is missing in type ... but required - field added that the contract does not have (
removed_by_api_drift: true):
error TS2353: Object literal may only specify known properties, and 'removed_by_api_drift' does not exist in type ... - wrong primitive (
has_more: 'false'):
error TS2322: Type 'string' is not assignable to type 'boolean'
Clean tree passes. The .map() alone was not enough for case 2 - without the explicit return annotation the element literals lose freshness and the extra field slips through - so the annotation is on the callback return, not just the array.
| ).toISOString() | ||
| })) | ||
|
|
||
| async function verifyMobileListFilterGroupDelete(comfyPage: ComfyPage) { |
There was a problem hiding this comment.
browser_tests/README.md explicitly says reusable interaction routines do not belong as free-standing functions in a spec. Both new tests are wrappers around this routine. Move the sequence to the Assets page object, a focused helper under fixtures/helpers/, or a composed Playwright fixture.
There was a problem hiding this comment.
Fixed in 02218ed (now 9bea836 after rebase).
Moved the sequence onto the AssetsSidebarTab page object in browser_tests/fixtures/components/SidebarTab.ts as expectTouchControlsUsable({ assetName, groupedAssetName }), per the README rule at browser_tests/README.md:306.
The locator wiring went with it, since that was inline in the spec too:
getListViewItemByName(name)getSeeMoreOutputsButton(name)- was a rawgetByRole('button', { name: 'See more outputs' })in the spec bodydeleteConfirmDialog- aConfirmDialogowned by the tab, so the routine no longer needs a wholeComfyPagejust to reach the confirm buttons
The spec now holds only test.describe / test blocks, the fixture, imports and the mock data. The ComfyPage type import is gone with the free-standing function.
christian-byrne
left a comment
There was a problem hiding this comment.
Exact-head review found one issue.
Annotate the raw /api/assets mock with AssetResponse/AssetItem from src/platform/assets/schemas/assetSchema so a contract change fails typecheck instead of leaving the test passing against a fiction. Addresses review feedback: #16366 (comment)
browser_tests/README.md requires reusable interaction routines and locator wiring to live in a page object, not as free-standing functions in a spec. The list/filter/group/delete sequence becomes AssetsSidebarTab.expectTouchControlsUsable, with the list-item and "See more outputs" locators alongside the tab's other locators. Addresses review feedback: #16366 (comment)
The cloud project sets grepInvert /@oss|@mobile-ios/, so a title tagged both @mobile-ios and @cloud is selected by mobile-safari only and never by cloud — the tag advertised coverage no project ran. mobile-safari already downloads the frontend-dist-cloud artifact, so @mobile-ios on its own is the combined Cloud + iOS run. Addresses review feedback: #16366 (comment)
6f8761d to
9bea836
Compare
Summary
Adds one mobile Assets journey across list, filter, group, and delete controls. This covers the mobile list/filter/group/delete smoke case, tracked internally as TC-OPS-03. Each routed test switches to list view, filters to one named output, clears the filter, opens a two-output group, returns to the list, selects by touch, opens deletion confirmation, verifies both choices are fully in view, and cancels cleanly.
Changes
Review Focus
The tests share typed job, Asset API, job-detail, and media fixtures so the same behavior runs against the OSS-shaped Pixel 5 project and Cloud-shaped iPhone 15 WebKit project.
Verification
Stacked on #16331. Validation: browser and root typechecks, ESLint, type-aware Oxlint, formatting, Knip, diff checks, commit hooks, push hook, and Playwright collection passed. Local execution reached fixture setup but the shared backend reset
/api/userswith a socket hang-up; CI is the execution gate.