Repository navigation
fix(agent): wait for first flag delivery in production - #16279
christian-byrne wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ❌ 1791 passed, 47 failed · 2 flaky❌ Failed Tests📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-30T06:00:20.936Z",
"gitSha": "28f836498e61a3948a6ee7a8ffdc4cba2a561cae",
"branch": "christian-byrne/op5-feh8-stale-flag",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2040.8130000000142,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.277999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.43100000000004,
"heapDeltaBytes": -8718996,
"heapUsedBytes": 60960724,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.424,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2012.6730000000634,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.192,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.41900000000004,
"heapDeltaBytes": 9031772,
"heapUsedBytes": 79010960,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.226,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1882.1500000000242,
"styleRecalcs": 76,
"styleRecalcDurationMs": 45.008,
"layouts": 14,
"layoutDurationMs": 4.781,
"taskDurationMs": 876.5849999999999,
"heapDeltaBytes": 11585396,
"heapUsedBytes": 81678452,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 128.17899999999997,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1738.943000000063,
"styleRecalcs": 74,
"styleRecalcDurationMs": 29.884,
"layouts": 14,
"layoutDurationMs": 3.742,
"taskDurationMs": 705.7950000000001,
"heapDeltaBytes": -12745460,
"heapUsedBytes": 57678176,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 112.71499999999997,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1658.5509999999886,
"styleRecalcs": 29,
"styleRecalcDurationMs": 12.361,
"layouts": 6,
"layoutDurationMs": 0.9010000000000001,
"taskDurationMs": 286.15599999999995,
"heapDeltaBytes": 4407992,
"heapUsedBytes": 74694568,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 8.656,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.9920000000138,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.322,
"layouts": 6,
"layoutDurationMs": 0.9580000000000001,
"taskDurationMs": 279.934,
"heapDeltaBytes": 3739632,
"heapUsedBytes": 67191964,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.081,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 521.269000000018,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.018999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.31800000000004,
"heapDeltaBytes": 18815480,
"heapUsedBytes": 88825308,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 123.86500000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 573.488999999995,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.038,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.06,
"heapDeltaBytes": 18581400,
"heapUsedBytes": 88366492,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 128.478,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2056.485000000009,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.188,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.299,
"heapDeltaBytes": -10485308,
"heapUsedBytes": 86018784,
"domNodes": -269,
"jsHeapTotalBytes": 4419584,
"scriptDurationMs": 30.276000000000003,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2037.2059999999692,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.965999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.61099999999993,
"heapDeltaBytes": 7407876,
"heapUsedBytes": 83020144,
"domNodes": -272,
"jsHeapTotalBytes": -1384448,
"scriptDurationMs": 26.804999999999996,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2130.4849999999647,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.819999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1278.664,
"heapDeltaBytes": 19072228,
"heapUsedBytes": 84951524,
"domNodes": -266,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 619.472,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2094.2119999999704,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.543000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1229.0520000000001,
"heapDeltaBytes": 20821320,
"heapUsedBytes": 87260796,
"domNodes": -272,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 585.817,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3163.326999999981,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.209999999999999,
"layouts": 60,
"layoutDurationMs": 11.484000000000002,
"taskDurationMs": 1352.2910000000002,
"heapDeltaBytes": 7740816,
"heapUsedBytes": 75943204,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 590.536,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3132.6329999999416,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.476999999999997,
"layouts": 60,
"layoutDurationMs": 11.217999999999998,
"taskDurationMs": 1342.1159999999998,
"heapDeltaBytes": 8191332,
"heapUsedBytes": 76375968,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 605.4379999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2241.6350000000307,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.169000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1580.7640000000001,
"heapDeltaBytes": 348976,
"heapUsedBytes": 80700040,
"domNodes": -281,
"jsHeapTotalBytes": 344064,
"scriptDurationMs": 753.6650000000001,
"eventListeners": -1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2346.367999999984,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.003999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1515.8580000000002,
"heapDeltaBytes": 14365856,
"heapUsedBytes": 82355580,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 741.6630000000001,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2003.9300000000253,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.73,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.99999999999994,
"heapDeltaBytes": 21812816,
"heapUsedBytes": 88775348,
"domNodes": -275,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 25.924999999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2027.1890000000212,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.801999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.42900000000003,
"heapDeltaBytes": 9197576,
"heapUsedBytes": 86264684,
"domNodes": -273,
"jsHeapTotalBytes": -1908736,
"scriptDurationMs": 28.845000000000002,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 539.8820000000342,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.684,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.5439999999999,
"heapDeltaBytes": 14700684,
"heapUsedBytes": 86774676,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 109.084,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 496.2350000000697,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.489000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 316.75,
"heapDeltaBytes": 14288768,
"heapUsedBytes": 86644124,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 111.075,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.9860000000167,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.423,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.772,
"heapDeltaBytes": -5935852,
"heapUsedBytes": 66561020,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.326,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2002.982999999972,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.068,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.3070000000001,
"heapDeltaBytes": 10227056,
"heapUsedBytes": 82795324,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 6.043999999999999,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.6030000000433,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.195000000000004,
"layouts": 18,
"layoutDurationMs": 4.176000000000001,
"taskDurationMs": 656.8369999999999,
"heapDeltaBytes": -14436552,
"heapUsedBytes": 58091724,
"domNodes": -294,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 83.913,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1758.8799999999765,
"styleRecalcs": 78,
"styleRecalcDurationMs": 31.053000000000004,
"layouts": 18,
"layoutDurationMs": 4.7589999999999995,
"taskDurationMs": 680.935,
"heapDeltaBytes": -14945584,
"heapUsedBytes": 57320492,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 84.449,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 867.2510000000102,
"styleRecalcs": 20,
"styleRecalcDurationMs": 24.223000000000003,
"layouts": 16,
"layoutDurationMs": 11.72,
"taskDurationMs": 716.912,
"heapDeltaBytes": 19971168,
"heapUsedBytes": 103220224,
"domNodes": 13671,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 20.252,
"eventListeners": 2381,
"totalBlockingTimeMs": 94,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8262.742000000002,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.731,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4504.927,
"heapDeltaBytes": -10931728,
"heapUsedBytes": 89613384,
"domNodes": -266,
"jsHeapTotalBytes": -598016,
"scriptDurationMs": 2007.609,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8264.68900000009,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.904,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4514.279,
"heapDeltaBytes": -9862660,
"heapUsedBytes": 89897744,
"domNodes": -260,
"jsHeapTotalBytes": -860160,
"scriptDurationMs": 2041.246,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14689.436999999998,
"styleRecalcs": 1,
"styleRecalcDurationMs": 16.261,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14168.280999999999,
"heapDeltaBytes": -34594172,
"heapUsedBytes": 177712500,
"domNodes": -6547,
"jsHeapTotalBytes": 466944,
"scriptDurationMs": 208.35400000000004,
"eventListeners": -7472,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 14664.597999999954,
"styleRecalcs": 1,
"styleRecalcDurationMs": 15.999999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14197.077,
"heapDeltaBytes": -18706076,
"heapUsedBytes": 176738956,
"domNodes": -6547,
"jsHeapTotalBytes": -4976640,
"scriptDurationMs": 206.368,
"eventListeners": -7470,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17429.797000000006,
"styleRecalcs": 147,
"styleRecalcDurationMs": 28.341000000000033,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17050.792,
"heapDeltaBytes": -25209948,
"heapUsedBytes": 166495580,
"domNodes": -6547,
"jsHeapTotalBytes": -634880,
"scriptDurationMs": 707.019,
"eventListeners": -7468,
"totalBlockingTimeMs": 34,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 17524.112999999943,
"styleRecalcs": 148,
"styleRecalcDurationMs": 27.89799999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17162.493000000002,
"heapDeltaBytes": -37729708,
"heapUsedBytes": 166778704,
"domNodes": -6547,
"jsHeapTotalBytes": 3686400,
"scriptDurationMs": 701.3750000000001,
"eventListeners": -7470,
"totalBlockingTimeMs": 14,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 5251.969000000031,
"styleRecalcs": 21,
"styleRecalcDurationMs": 72.741,
"layouts": 20,
"layoutDurationMs": 20.346000000000004,
"taskDurationMs": 5164.663,
"heapDeltaBytes": -24629480,
"heapUsedBytes": 177305868,
"domNodes": -6547,
"jsHeapTotalBytes": 15425536,
"scriptDurationMs": 92.807,
"eventListeners": -7468,
"totalBlockingTimeMs": 200,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5279.296999999929,
"styleRecalcs": 21,
"styleRecalcDurationMs": 75.36300000000001,
"layouts": 20,
"layoutDurationMs": 21.138000000000005,
"taskDurationMs": 5156.063999999999,
"heapDeltaBytes": -20377476,
"heapUsedBytes": 182584024,
"domNodes": -6547,
"jsHeapTotalBytes": 14172160,
"scriptDurationMs": 89.58999999999999,
"eventListeners": -7470,
"totalBlockingTimeMs": 170,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "workflow-execution",
"durationMs": 447.9599999999664,
"styleRecalcs": 15,
"styleRecalcDurationMs": 16.097,
"layouts": 2,
"layoutDurationMs": 0.436,
"taskDurationMs": 81.61899999999999,
"heapDeltaBytes": 5074484,
"heapUsedBytes": 72815032,
"domNodes": 128,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 6.045999999999998,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 439.0690000000177,
"styleRecalcs": 14,
"styleRecalcDurationMs": 15.504999999999999,
"layouts": 2,
"layoutDurationMs": 0.506,
"taskDurationMs": 84.57999999999998,
"heapDeltaBytes": 5058988,
"heapUsedBytes": 73142280,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.049,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## christian-byrne/integration-candidate-v2-ci-fix #16279 +/- ##
==================================================================================
Coverage ? 83.25%
==================================================================================
Files ? 2027
Lines ? 117317
Branches ? 34407
==================================================================================
Hits ? 97676
Misses ? 19299
Partials ? 342
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
TL;DR: Closing — superseded by the base's gate rewrite. Bug this fixed can't occur anymore. Merged #16273 covers the waiver lane. Full context for agent readersWhy superseded, not rebased: This PR patched the OLD async The ci-fix base (now at e04d292 line) rewrote the gate entirely:
So on the new base the flag reads Why not port the test: the staged test hunk references Residual (tracked separately, not a reason to keep this PR): Waiver report: |
Summary
Wait for the first PostHog feature-flag delivery before enabling the agent panel in production, preventing a stale persisted
truevalue from briefly mounting the panel for a de-flagged user.Changes
trueis ignored until delivery and then applied.Review Focus
Please verify that the production gate remains fail-closed before delivery while development retains its immediate force-enable behavior.
Screenshots (if applicable)
Not applicable; this is feature-gate timing behavior covered by unit tests.