Repository navigation
refactor: replace PrimeVue overlays and composites - #16272
Conversation
|
Important Review skippedWe couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. 📝 WalkthroughWalkthroughThis pull request adds shared menu, popover, splitter, tab, and autocomplete components. It migrates application surfaces and browser tests to these components, adds panel sizing and persistence logic, replaces the gallery implementation, and adds Playwright video planning and publishing workflows. ChangesShared UI components and contracts
Priority: ➖ Normal Estimated code review effort: 5 (Critical) | ~120 minutes Merge Risk: ⚪ Minimal · up to The inspected changes preserve the cited test cleanup, keyboard access, validation feedback, and canvas-relative menu positioning. No unresolved actionable risk was identified; the PR is ready subject to normal checks. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings
🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Comment |
🎭 Playwright: ✅ 2233 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 10.1 MB gzip 🟢 -75.8 kBDetailsSummary
Category Glance App Entry Points — 4.04 kB (baseline 3.98 kB) • 🔴 +56 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.47 MB) • 🟢 -14.8 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 135 kB (baseline 135 kB) • 🔴 +6 BTop-level views, pages, and routed surfaces
Status: 15 added / 15 removed / 3 unchanged Panels & Settings — 648 kB (baseline 648 kB) • 🔴 +289 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 53.7 kB (baseline 53.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 6 unchanged Editors & Dialogs — 133 kB (baseline 133 kB) • 🔴 +6 BModals, dialogs, drawers, and in-app editors
Status: 9 added / 9 removed UI Components — 220 kB (baseline 194 kB) • 🔴 +26 kBReusable component library chunks
Status: 18 added / 16 removed / 2 unchanged Data & Services — 4.15 MB (baseline 4.17 MB) • 🟢 -15.9 kBStores, services, APIs, and repositories
Status: 12 added / 12 removed / 4 unchanged Utilities & Hooks — 580 kB (baseline 580 kB) • 🔴 +100 BHelpers, composables, and utility bundles
Status: 22 added / 22 removed / 16 unchanged Vendor & Third-Party — 17 MB (baseline 17.2 MB) • 🟢 -281 kBExternal libraries and shared vendor chunks
Status: 2 added / 2 removed / 16 unchanged Other — 18.4 MB (baseline 18.5 MB) • 🟢 -112 kBBundles that do not match a named category
Status: 143 added / 142 removed / 167 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-05T23:42:07.098Z",
"gitSha": "73bf319c56f3311bd1efece35fa055003c356919",
"branch": "primevue-removal/phase-4-overlays",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.7930000000024,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.8960000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.786,
"heapDeltaBytes": 7325180,
"heapUsedBytes": 74405356,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.219,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2024.2999999999256,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.869000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.7389999999999,
"heapDeltaBytes": 6909420,
"heapUsedBytes": 74964176,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 16.410999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1768.523000000016,
"styleRecalcs": 74,
"styleRecalcDurationMs": 15.753000000000004,
"layouts": 12,
"layoutDurationMs": 5.023,
"taskDurationMs": 832.301,
"heapDeltaBytes": 2843448,
"heapUsedBytes": 70970556,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 170.02,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1809.6160000000054,
"styleRecalcs": 75,
"styleRecalcDurationMs": 18.179000000000002,
"layouts": 12,
"layoutDurationMs": 5.111,
"taskDurationMs": 901.3689999999999,
"heapDeltaBytes": 3073436,
"heapUsedBytes": 69831756,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 175.22899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740745,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.2740000000313,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.137999999999999,
"layouts": 3,
"layoutDurationMs": 0.8420000000000001,
"taskDurationMs": 410.62300000000005,
"heapDeltaBytes": 8942720,
"heapUsedBytes": 76955100,
"domNodes": 45,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.880999999999998,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.524999999966,
"styleRecalcs": 20,
"styleRecalcDurationMs": 8.189,
"layouts": 3,
"layoutDurationMs": 1.1369999999999998,
"taskDurationMs": 448.108,
"heapDeltaBytes": 9576440,
"heapUsedBytes": 77535428,
"domNodes": 45,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 18.06800000000001,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 654.5330000000149,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.7479999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.657,
"heapDeltaBytes": -5317620,
"heapUsedBytes": 63660124,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 171.00300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 721.9109999999773,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.8329999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.91100000000006,
"heapDeltaBytes": -5694632,
"heapUsedBytes": 62001392,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 175.472,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069753,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1142.862999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 814.2819999999999,
"heapDeltaBytes": 14451844,
"heapUsedBytes": 84682820,
"domNodes": 0,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 70.905,
"eventListeners": 0,
"totalBlockingTimeMs": 521,
"frameDurationMs": 33.82058823529413,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1417.728000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1128.9779999999998,
"heapDeltaBytes": 20081380,
"heapUsedBytes": 90598872,
"domNodes": 0,
"jsHeapTotalBytes": 6717440,
"scriptDurationMs": 79.457,
"eventListeners": 0,
"totalBlockingTimeMs": 788,
"frameDurationMs": 41.661764705882355,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.1900000000164,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.4040000000004,
"heapDeltaBytes": -7670784,
"heapUsedBytes": 79923600,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 163.267,
"eventListeners": 0,
"totalBlockingTimeMs": 223,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 926.9110000000182,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.7849999999999,
"heapDeltaBytes": -8113168,
"heapUsedBytes": 79688308,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 180.909,
"eventListeners": 0,
"totalBlockingTimeMs": 229,
"frameDurationMs": 24.560526315789502,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11399.496,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10357.765,
"heapDeltaBytes": 3146852,
"heapUsedBytes": 88928056,
"domNodes": -141,
"jsHeapTotalBytes": -3018752,
"scriptDurationMs": 8594.137,
"eventListeners": -73,
"totalBlockingTimeMs": 1639,
"frameDurationMs": 32.757471264367815,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10650.287999999931,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9727.368,
"heapDeltaBytes": -16979472,
"heapUsedBytes": 68018240,
"domNodes": -141,
"jsHeapTotalBytes": -9834496,
"scriptDurationMs": 7979.232999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 1056,
"frameDurationMs": 31.230205278592376,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11382.903999999997,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.6180000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10506.121000000001,
"heapDeltaBytes": 7594216,
"heapUsedBytes": 93285832,
"domNodes": -141,
"jsHeapTotalBytes": -1445888,
"scriptDurationMs": 8776.875,
"eventListeners": -73,
"totalBlockingTimeMs": 1544,
"frameDurationMs": 32.61575931232092,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10613.27899999992,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.06699999999999935,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9728.793,
"heapDeltaBytes": -16489124,
"heapUsedBytes": 68764836,
"domNodes": -141,
"jsHeapTotalBytes": -9572352,
"scriptDurationMs": 7974.221,
"eventListeners": -69,
"totalBlockingTimeMs": 1160,
"frameDurationMs": 31.502373887240353,
"p95FrameDurationMs": 66.5
},
{
"name": "large-graph-idle",
"durationMs": 2008.1819999999766,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.126000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 612.9689999999999,
"heapDeltaBytes": -3636256,
"heapUsedBytes": 85143952,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 36.92300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2022.2729999999274,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.668,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 636.103,
"heapDeltaBytes": -3207268,
"heapUsedBytes": 85400940,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 42.095000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2312.151999999969,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.927,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1689.47,
"heapDeltaBytes": -10054948,
"heapUsedBytes": 79073168,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 872.6320000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.786231884057965,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2754.043999999908,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.172,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1797.566,
"heapDeltaBytes": -9731344,
"heapUsedBytes": 80029392,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 923.338,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666060606060604,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3755.991999999992,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.887,
"layouts": 60,
"layoutDurationMs": 18.675,
"taskDurationMs": 1871.875,
"heapDeltaBytes": 5328684,
"heapUsedBytes": 73760796,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 867.813,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66577777777778,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3838.9139999999315,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.893,
"layouts": 60,
"layoutDurationMs": 18.019000000000002,
"taskDurationMs": 1842.14,
"heapDeltaBytes": 9728688,
"heapUsedBytes": 78111996,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 864.402,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665652173913045,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3170.9240000000136,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.565,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2032.437,
"heapDeltaBytes": 20984904,
"heapUsedBytes": 89653436,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 1053.8120000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.843617021276593,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3208.939999999984,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.601000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2036.449,
"heapDeltaBytes": 21737308,
"heapUsedBytes": 91185800,
"domNodes": 0,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 1053.572,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.841052631578947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2012.4829999999747,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.9760000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 641.2350000000001,
"heapDeltaBytes": -3325564,
"heapUsedBytes": 86841924,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 39.940000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2019.0279999999348,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.9439999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 683.7009999999999,
"heapDeltaBytes": 19936736,
"heapUsedBytes": 88547388,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 42.74600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 597.8460000000041,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.4239999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.25900000000007,
"heapDeltaBytes": -9175144,
"heapUsedBytes": 60914120,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 148.30499999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 649.5000000001028,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.172000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.52600000000007,
"heapDeltaBytes": 12605196,
"heapUsedBytes": 76736980,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 150.25900000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102556,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.4919999999897,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.6699999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.357,
"heapDeltaBytes": 7550552,
"heapUsedBytes": 77643448,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.535999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.216000000005,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.6699999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 561.831,
"heapDeltaBytes": 7614268,
"heapUsedBytes": 77497040,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.767000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.5529999999753,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.6,
"layouts": 16,
"layoutDurationMs": 5.332,
"taskDurationMs": 743.9169999999999,
"heapDeltaBytes": -357912,
"heapUsedBytes": 69547064,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 106.565,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.6079999999656,
"styleRecalcs": 77,
"styleRecalcDurationMs": 18.18,
"layouts": 16,
"layoutDurationMs": 6.303,
"taskDurationMs": 828.7289999999999,
"heapDeltaBytes": -758160,
"heapUsedBytes": 68757208,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 118.53099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.868999999935,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.852000000000004,
"layouts": 5,
"layoutDurationMs": 15.631000000000002,
"taskDurationMs": 1093.7469999999998,
"heapDeltaBytes": 6389300,
"heapUsedBytes": 105443088,
"domNodes": 14570,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 35.236999999999995,
"eventListeners": 2458,
"totalBlockingTimeMs": 144,
"frameDurationMs": 19.594594594594593,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9303.38800000004,
"styleRecalcs": 250,
"styleRecalcDurationMs": 22.656999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6045.700999999999,
"heapDeltaBytes": -18728788,
"heapUsedBytes": 69483700,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 2914.605,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69605026929982,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9616.23700000007,
"styleRecalcs": 249,
"styleRecalcDurationMs": 23.198000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6368.615999999999,
"heapDeltaBytes": -19214212,
"heapUsedBytes": 69564552,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 3098.0789999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585788561525,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18829.045000000064,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18266.905000000002,
"heapDeltaBytes": -33509084,
"heapUsedBytes": 182761340,
"domNodes": -3046,
"jsHeapTotalBytes": 7770112,
"scriptDurationMs": 292.623,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.44137931034483,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-large-graph-idle",
"durationMs": 20959.57699999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20491.772,
"heapDeltaBytes": -35800848,
"heapUsedBytes": 181066432,
"domNodes": -3046,
"jsHeapTotalBytes": 7016448,
"scriptDurationMs": 455.85900000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 56,
"frameDurationMs": 37.17358156028369,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 24160.29800000001,
"styleRecalcs": 182,
"styleRecalcDurationMs": 20.401000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23779.77,
"heapDeltaBytes": -36061660,
"heapUsedBytes": 187017772,
"domNodes": -3046,
"jsHeapTotalBytes": 1679360,
"scriptDurationMs": 942.7969999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 54,
"frameDurationMs": 44.91765799256505,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 24119.312000000034,
"styleRecalcs": 180,
"styleRecalcDurationMs": 21.55100000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23781.706,
"heapDeltaBytes": -44291380,
"heapUsedBytes": 187045308,
"domNodes": -3046,
"jsHeapTotalBytes": 7163904,
"scriptDurationMs": 964.8950000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 42,
"frameDurationMs": 44.9919776119403,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6925.833000000011,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.43499999999997,
"layouts": 20,
"layoutDurationMs": 30.179999999999986,
"taskDurationMs": 6833.498,
"heapDeltaBytes": 755416,
"heapUsedBytes": 218621376,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 121.94999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 26,
"frameDurationMs": 40.78235294117647,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-node-resize-workload",
"durationMs": 6957.118999999921,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.58400000000002,
"layouts": 20,
"layoutDurationMs": 29.104000000000006,
"taskDurationMs": 6805.536,
"heapDeltaBytes": 763228,
"heapUsedBytes": 214948488,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 121.56899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.739181286549716,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10840.896000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10614.834,
"heapDeltaBytes": -38663824,
"heapUsedBytes": 177024472,
"domNodes": -3046,
"jsHeapTotalBytes": -6709248,
"scriptDurationMs": 193.60900000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.144366197183096,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9898.73399999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9647.691,
"heapDeltaBytes": -51204076,
"heapUsedBytes": 172698048,
"domNodes": -3046,
"jsHeapTotalBytes": 892928,
"scriptDurationMs": 159.63799999999995,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.078965517241386,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 119.97999999994136,
"styleRecalcs": 8,
"styleRecalcDurationMs": 10.883,
"layouts": 3,
"layoutDurationMs": 0.954,
"taskDurationMs": 89.93499999999999,
"heapDeltaBytes": 4173356,
"heapUsedBytes": 69705108,
"domNodes": 102,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.751999999999995,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 100.1419999998916,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.08,
"layouts": 2,
"layoutDurationMs": 0.8699999999999999,
"taskDurationMs": 71.60199999999998,
"heapDeltaBytes": 3982848,
"heapUsedBytes": 69549404,
"domNodes": 98,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.0050000000000034,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.649999999999938,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 991.7000000000371,
"styleRecalcs": 78,
"styleRecalcDurationMs": 98.86399999999999,
"layouts": 76,
"layoutDurationMs": 29.098,
"taskDurationMs": 961.389,
"heapDeltaBytes": 18708604,
"heapUsedBytes": 90615116,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 393.14700000000005,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1328.017999999929,
"styleRecalcs": 78,
"styleRecalcDurationMs": 122.867,
"layouts": 76,
"layoutDurationMs": 34.491,
"taskDurationMs": 1300.7259999999999,
"heapDeltaBytes": -4954060,
"heapUsedBytes": 66866392,
"domNodes": 76,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 549.44,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.31558441558443,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1523.7410000000864,
"styleRecalcs": 78,
"styleRecalcDurationMs": 275.772,
"layouts": 76,
"layoutDurationMs": 31.575,
"taskDurationMs": 1486.168,
"heapDeltaBytes": 10797504,
"heapUsedBytes": 118479808,
"domNodes": 76,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 499.96,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.473493975903605,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1522.2759999999198,
"styleRecalcs": 78,
"styleRecalcDurationMs": 278.77299999999997,
"layouts": 76,
"layoutDurationMs": 30.959,
"taskDurationMs": 1505.5349999999999,
"heapDeltaBytes": 10784692,
"heapUsedBytes": 118638944,
"domNodes": 76,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 498.261,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.697560975609765,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (331 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since f9b3e0ba76696ed11716301a9ac7392c75cdcc7c
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-16272.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-hewh8v3n7-comfyui.vercel.app Last updated: 2026-09-23T17:56:49Z for |
|
Updating Playwright Expectations |
|
/update-playwright |
c29cc7e to
38e3313
Compare
81f388c to
def7710
Compare
38e3313 to
9501c63
Compare
def7710 to
8bea35d
Compare
8bea35d to
c482cd6
Compare
|
Severity: Major What: Why this is an issue: The "more options" button cannot close the menu it opened; Proposed Fix: Make the button the |
dante01yoon
left a comment
There was a problem hiding this comment.
Approving at df5f47ad. The blocker is resolved: the CI split landed separately as #20222, this branch is now based on its merge commit (1073b9b4), and the diff no longer touches .github/ or scripts/cicd/. git range-diff against b81b989f shows the rebase only dropped the seven CI commits and the CI hunks from 34a76d6d and b21dfe9d; every overlay commit is otherwise unchanged.
The three new commits look good:
ContextMenunow uses'always'only when areferenceis passed, so pointer-anchored menus no longer re-measure each frame, and9e01e47dproves it by asserting nogetBoundingClientRectcalls while the menu sits idle;ComfyActionbar.test.tsmocks the lazyComfyRunButtonmodule instead of stubbing it, which removes the teardown race, and it keeps the realContextMenu.
All required checks pass on this head (121 pass, 17 skipped). The modelStore JSDoc nit stays non-blocking.
Summary
Replaces Phase 4 PrimeVue overlays and composite controls with Reka-backed components and a local gallery carousel.
Changes
Review Focus
Keyboard dismissal and focus return, portaled submenus, splitter persistence across layout changes, and gallery navigation.
Visual reference: full before/after report.